bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

- Enable WARMSTART
- Pass fd to libwrap
- Add blocklist
From Greg A. Woods

- Tidy up debugging

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

Fix building rpcbind with MKYP=no

We add enough of the YP headers to security.c so the security checks
can remain as is.

branches: 1.14.4;
Revert accidently committed enabling WARMSTART.

Write the "warm start" file to /var/run rather than /tmp.
(Restore changes clobbered by merge of FreeBSD changes. Hi christos!)

Enable WARNS=4 by default, except for:
cpuctl dumplfs hprop ipf iprop-log kadmin kcm kdc kdigest
kimpersonate kstash ktutil makefs ndbootd ntp pppd quot
racoon racoonctl rtadvd sntp sup tcpdchk tcpdmatch tcpdump
traceroute traceroute6 user veriexecgen wsmoused zic
(Mostly third-party applications)

branches: 1.11.14;
Depracate ND_DEBUG and BIND_DEBUG in favour of RPCBIND_DEBUG.
Add commented out entries for RPCBIND_DEBUG and SVC_RUN_DEBUG in Makefile.

branches: 1.10.4;
Since Christos cleaned up the use of libc internals here, we can switch
these from USE_SSP to USE_FORT as they should be.

get rid of libc cruft. requested by tls

Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Only compile in IPv6 support if ${USE_INET6} != "no"

MKINET6 is for providing IPv6 infrastructure.
USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6).

Make building IPv6 support controllable by MKINET6

use NETBSDSRCDIR as appropriate

branches: 1.3.2;
Oops, previous should not have been committed.

Free buffer used in xdrmem_create.

rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

Include explicitly <rump/rump_syscallshotgun.h> for previous indirect users
via <rump/rump.h>.

Handle memory allocations and error exit codes consistently.

branches: 1.7.2; 1.7.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

merge RUMP changes.

Depracate ND_DEBUG and BIND_DEBUG in favour of RPCBIND_DEBUG.
Add commented out entries for RPCBIND_DEBUG and SVC_RUN_DEBUG in Makefile.

branches: 1.4.4;
- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Coverity CID 3653: Fix memory leak.

branches: 1.2.2;
Plug a few memory leaks.

branches: 1.1.2;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

- Enable WARMSTART
- Pass fd to libwrap
- Add blocklist
From Greg A. Woods

- Tidy up debugging

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

merge RUMP changes.

fix unused variable warnings.

branches: 1.6.34; 1.6.40;
deal with namespace pollution caused by tcpd.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

use bounded string op

Fix typo in a comment (from Onno van der Linden; PR#15792)

Make showmount -e work on lp64be. From Matt Green. While at it, also
fix another occurence of passing &int to xdr_long.

branches: 1.1.2; 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

Handle memory allocations and error exit codes consistently.

branches: 1.6.2; 1.6.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Fix off-by-one found by Coverity, CID 1529.

Don't compare a char to NULL.

More #include <stdlib.h> string, etc. cleanup

branches: 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

NULL does not need a cast

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

branches: 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

Handle memory allocations and error exit codes consistently.

branches: 1.8.2; 1.8.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

NULL does not need a cast

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Coverity CID 1070: Check for NULL deref that cannot happen.

Coverity CID 3653: Fix memory leak.

appease gcc -Wuninitialized

For the local case, return serv_uaddr in addrmerge, not the address
by which the client contacted rpcbind.

Also fix a missing \n in a debug printf.

From Martin Blapp, mb@imp.ch

branches: 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

fix spelling mistakes, mainly in comments and log messages.

rpcbind(8): restore previous behaviour. Wait instead of breaking from
the loop if svc_fdset_getmax fails.

thanks rin.

rpcbind(8): Use reallocarr, fix reallocation logic.

In my_svc_run(), only update the fd count _after_ the allocation
succeeds (which may be after waiting in the loop). This function
previously tried to go to a label that doesn't exist. I wonder why
GCC didn't catch this before but does now.

avoid potential uninitialised variable use.

- Enable WARMSTART
- Pass fd to libwrap
- Add blocklist
From Greg A. Woods

- Tidy up debugging

Include explicitly <rump/rump_syscallshotgun.h> for previous indirect users
via <rump/rump.h>.

check strdup results too
include the function name in out of memory messages

Handle memory allocations and error exit codes consistently.

branches: 1.20.2; 1.20.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

Limit size of buffer:
https://github.com/guidovranken/rpcbomb/blob/master/rpcbind_patch.txt
XXX: pullup-7

branches: 1.18.6;
CID 1338514: Check NULL returns

merge RUMP changes.

NULL does not need a cast

Use __dead

fix -Wsign-compare issues

This code has been broken for ~ 20 years!
Initialise the 'fromlen' parameter for recvfrom() prior to the call, instead
of passing in a 'random' value off the stack.
This should fix the problems with ypbind on current.
I suspect the old kernel was not objecting to -ve buffer lengths.

branches: 1.12.4;
deal with namespace pollution caused by tcpd.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

branches: 1.10.16; 1.10.18;
Don't compare a char to NULL.

Use a non-blocking SVC for TCP connections.

null commit

poll.h, not sys/poll.h

branches: 1.6.2;
Do not check unitialized variables as error values. This is generally
frowned upon, or so I hear.

branches: 1.5.2;
Plug memory leak in error case (would have happened very rarely).

Make sure that freeing the temporary buffer always happens; previous
commit would still result in a leak.

Plug a few memory leaks.

Free buffer used in xdrmem_create.

branches: 1.1.2;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

fix path to the warmstart file.

Use today's date. Sort options. Remove superfluous Tn macro. Wording improvement.

fix typo, date, document -L

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

Fix preamble

branches: 1.10.4;
Xref netconfig(5). Requested by Martin S. Weber in PR bin/39605.

Capitalize a letter to match other sentences in the list.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

document that access control is provided by libwrap.

Sort sections, drop a .Pp.

Fix date, and add RCS Id.

rpcinfo is in section 8.

branches: 1.3.2;
- Fix .Nd usage; no need to supply hyphen explicitly and the description is
short enough to put on the same line.
- Kill the comma at the end of SEE ALSO list.
- Remove empty line in the source.
- Break line at the end of statement in the source for better output (in other
words, let the roff to format it).

branches: 1.2.2;
Reflect changed Unix domain socket name.

rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

rpcbind(8): Use reallocarr, fix reallocation logic.

In my_svc_run(), only update the fd count _after_ the allocation
succeeds (which may be after waiting in the loop). This function
previously tried to go to a label that doesn't exist. I wonder why
GCC didn't catch this before but does now.

- Enable WARMSTART
- Pass fd to libwrap
- Add blocklist
From Greg A. Woods

- Tidy up debugging

Include explicitly <rump/rump_syscallshotgun.h> for previous indirect users
via <rump/rump.h>.

Don't pass an uinitialized pm_prot to rpcinfo. It expects 0 for local,
so give it 0.

check strdup results too
include the function name in out of memory messages

Handle memory allocations and error exit codes consistently.

branches: 1.25.2; 1.25.4;
don't lock for RUMP

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

merge RUMP changes.

use EXIT_SUCCESS/EXIT_FAILURE consistently.

check setrlimit too

CID 1009289: Check getrlimit

fix unused variable warnings.

branches: 1.18.2; 1.18.8;
NULL does not need a cast

Use __dead

remove unnecessary superuser check -- bind will fail if bind fails

Depracate ND_DEBUG and BIND_DEBUG in favour of RPCBIND_DEBUG.
Add commented out entries for RPCBIND_DEBUG and SVC_RUN_DEBUG in Makefile.

branches: 1.14.4;
PR/36440: Martin Husemann: rpcbind complains about non-errors.
Don't complain about EAFNOSUPPORT.

deal with namespace pollution caused by tcpd.

PR/36319: Michael van Elst: rpcinfo -p requires root privileges
Explicitly chmod 777 the local socket.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

PR/36313: Juergen Hannken-Illjes: Change the name "rpcbind" to "sunrpc"
which is used in the new services.

branches: 1.9.4; 1.9.6;
Adapt rpcbind(8) to new return value from socket(2) for unsupported
address families.

Coverity CID 2294: Fix memory leak.
While here remove some bogus casts.

branches: 1.7.2;
Decrease log severity to debug if a protocol is not supported by the
kernel. This avoids "rpcbind: cannot create socket for tcp6" messages
at startup on IPv4-only kernels.

branches: 1.6.2;
Make a v6 socket v6-only, since rpcbind does host-based checking (all NFS
code already did this).

Don't pass NULL as an integer.

use bounded string op

Use a non-blocking SVC for TCP connections.

branches: 1.2.2;
don't use LOG_CONS

branches: 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

Use __dead

fix -Wsign-compare issues

deal with namespace pollution caused by tcpd.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

branches: 1.1.4;
This file was omitted in the original commit.

- Enable WARMSTART
- Pass fd to libwrap
- Add blocklist
From Greg A. Woods

- Tidy up debugging

Fix building rpcbind with MKYP=no

We add enough of the YP headers to security.c so the security checks
can remain as is.

branches: 1.12.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

fix -Wsign-compare issues

deal with namespace pollution caused by tcpd.

- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Proper bounds access, found by Coverity, CID 1470.

use bounded string op

labels (even default:) _must_ be followed by statements! usr.bin/fgen/fgen.l

branches: 1.5.4;
Ok.. really get it right this time (that's ntohs, not htons.. need coffee).

Fix botched reserved port check for the -L option case. From
IWAMOTO Toshihiro <iwamoto@sat.t.u-tokyo.ac.jp>, PR 10321

Use IPV6PORT_RESERVED in the INET6 case, for consistency.

Host access checking for a local socket makes no sense.

Need <string.h> for LP64 systems.

rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

Include explicitly <rump/rump_syscallshotgun.h> for previous indirect users
via <rump/rump.h>.

- fix wrong size allocation that triggers buffer overflow
- remove unneeded casts and assertions
XXX: pullup-8

Handle memory allocations and error exit codes consistently.

branches: 1.21.2; 1.21.4;
merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

branches: 1.20.8;
merge RUMP changes.

perror -> warn

CID 1018907: Freeifaddrs

use new scopeid functions

branches: 1.16.8; 1.16.14;
fix -Wsign-compare issues

Remove clause 3 and 4 from TNF licenses

branches: 1.14.6;
Depracate ND_DEBUG and BIND_DEBUG in favour of RPCBIND_DEBUG.
Add commented out entries for RPCBIND_DEBUG and SVC_RUN_DEBUG in Makefile.

branches: 1.13.4;
- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

Coverity CID 783: Add an assertion for a NULL deref.

Support MKINET6=no building after the -Wuninitalized fix.
Noted by Jukka Salmi in email.

appease gcc -Wuninitialized

null commit

poll.h, not sys/poll.h

For the local case, return serv_uaddr in addrmerge, not the address
by which the client contacted rpcbind.

Also fix a missing \n in a debug printf.

From Martin Blapp, mb@imp.ch

For an AF_LOCAL connection, don't attempt to do the address merge dance.
While here, fix some memory leaks in error cases.

Move routines which fill in tbuf in addrmerge(). The fixes in 1.4 pick a new
interface but don't fill in tbuf which results in clients getting garbage back
in part of the answer. This makes sure there's something in tbuf.

At some point this whole logic should be looked at, as just picking a random
local up interface for non-local requests doesn't feel right.

When merging addresses, and no direct match is found, pick the first
configured interface that is preferably not local or point to point.
This appears to be what Solaris does as well.

branches: 1.3.2;
Make sure to free the netconfig entry in addrmerge().

branches: 1.2.2;
Need <string.h> for LP64 systems.

rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.

Fix compile warnings.
(Restore changes clobbered by merge of FreeBSD changes. Hi christos!)

Write the "warm start" file to /var/run rather than /tmp.
(Restore changes clobbered by merge of FreeBSD changes. Hi christos!)

merge FreeBSD changes:
- fixes CVE-2015-7236
- adds -h hostip to bind, -6 for only ipv6 access, -a for abort gracefully
- documents -w (warmstart)
XXX: should fix warmstart file to go to /var/run instead of /tmp

Fix compile warnings.

Write the "warm start" file to /var/run rather than /tmp.

- unlink the warmstart file first and then open it exclusively.
(From Brian Ginsbach)
- ifdef the whole file #ifdef WARMSTART to save space.

branches: 1.2.4;
- WARNS = 4
- De __P
- While starting up, send messages to stderr not syslog.
- Fix error messages
- Don't play with umask and forget to restore it on error

branches: 1.1.4;
rpcbind, the successor to portmap. Taken from Sun TI-RPC source code,
then modified. This still contains some ugly special casing for
procedures in the security section, but I haven't found a nicer way
so far.