bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.14.46;
Enable WARNS=4 by default, except for:
cpuctl dumplfs hprop ipf iprop-log kadmin kcm kdc kdigest
kimpersonate kstash ktutil makefs ndbootd ntp pppd quot
racoon racoonctl rtadvd sntp sup tcpdchk tcpdmatch tcpdump
traceroute traceroute6 user veriexecgen wsmoused zic
(Mostly third-party applications)

branches: 1.13.20;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Fixes from Liam J. Foy to use poll, and proper signals. (from OpenBSD)
While there, ansify, and fix const abuse.

use NETBSDSRCDIR as appropriate

use utmpx.

Use pidfile(3).

rcsid fascism

doesn't need libkvm any more

specify man pages the new way.

rwhod wasn't too happy after the off_t change - its lseek() to check the
boottime was broken. Replaced this code with kvm_nlist()/kvm_read() to be
more efficient.

no longer need lib hackery

hack to make getloadavg() link properly

Add RCS identifiers.

branches: 1.1.1;
after 0.2.2 "stable" patches applied

New sentence, new line.
Add -u to SYNOPSIS. Fix some typos.
Use more markup. Bump date for -u.

Add -u option: rwhod will drop privledges and become the given user.

reviewed by jwise

Fix argument name, and move Pp where it belongs. From YOMURA Masanori in private mail.

Add "by default" (Liam Foy)

Remove trailing space, fix a Xref.

Change g flag to i as in the PR.
Don't allow interval to be set to > 11 minutes.
Rephrase option blurb.

PR/30648: Liam J. Foy: rwhod patch to reduce time interval between broadcasts

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

Sort sections and SEE ALSO.

Whitespace nits.

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

The service name of the rwhod(8) is not "rwho" but "who".

WARNSify

gethostname(3) is no longer a syscall

xref gethostname(3) not gethostname(2), RCSid police

update structure definitions for 64-bit safety (already done in the relevant
header files), and kill the note about checking /netbsd's nlist, since that
is no longer done (since the kernel namelist isn't actually used for
anything).

sync with 44lite

vmunix -> netbsd

Add RCS indentifiers.

branches: 1.1.1;
after 0.2.2 "stable" patches applied

sysctl(KERN_BOPOTIME) started returning a struct timespec in 2009.
Update to match.... We're slow but we get there eventually!

NFC for any of these programs, struct timeval and struct timespec
are the same size, and only the tv_sec field of boottime is used,
and that's unchanged.

branches: 1.40.28; 1.40.30;
include <pwd.h>

branches: 1.39.2; 1.39.8;
Use __dead

Fix -Wsign-compare issue

branches: 1.37.6;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

Clarify how one is supposed to use the pointers returned by getutentries()
(the utmpentry.c code), specifically with respect to who owns them and
when to free them. Now they're owned by utmpentry.c, only. Abolish the
freeutentries() function, which was the wrong abstraction; add instead
endutentries(), which flushes out the internally managed memory.

Update callers as necessary. Some (e.g. talkd) had been leaking memory;
others (e.g. syslogd) had been accidentally freeing and reloading utmp
more often than necessary. There are a couple untidy bits in users and
rwhod that someone should look after sometime, maybe.

Fixes PR bin/35131, which was about talkd's memory leak.

branches: 1.35.6;
convert __attribute__s to applicable cdefs.h macros

branches: 1.34.10;
assign to wd.wd_recvtime rather than casting a pointer to it
to a time_t pointer to call time(3).

Off by one in copying stuff to struct whoent. Found by Liam Foy.

Sync usage with man page.

Add -u option: rwhod will drop privledges and become the given user.

reviewed by jwise

Patch from Liam J. Foy:
- cleanup sendto code.
- fix usage.

Change g flag to i as in the PR.
Don't allow interval to be set to > 11 minutes.
Rephrase option blurb.

PR/30648: Liam J. Foy: rwhod patch to reduce time interval between broadcasts

Remove a unnecessary semicolon and trailing spaces.

- Use the timer* macros from sys/time.h, no need to invent a new time add
function if it already exists.
- Improve a few function/variable names and use EXIT_FAILURE.

Initialize events not revents. Noted by Peter Postma. The timer changes he
can make himself :-)

Fixes from Liam J. Foy to use poll, and proper signals. (from OpenBSD)
While there, ansify, and fix const abuse.

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

use bounded string op

PR/20318: Johnny Billquist: rwhod does not compile with -DDEBUG

use utmpx.

More format string cleanups by sommerfeld.

branches: 1.17.4;
avoid memory leak on realloc() error.

From FreeBSD bin/14844 (slightly modified): Due to signed calculations
with the packet size, a short packet would trigger an infinite loop
on little endian machines.

branches: 1.15.4;
Use pidfile(3).

branches: 1.14.2;
fix error in previous pointed out by bad. minor KNFing.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

deprecate register, use warn/err

WARNSify

Lseek(2) usage cleanup: the use of L_SET/L_INCR/L_XTND is deprecated,
use SEEK_SET/SEEK_CUR/SEEK_END instead.

Fix some potential buffer overflow problems.
From David Holland <dholland@hcs.harvard.edu>

sync with 44lite

rwhod wasn't too happy after the off_t change - its lseek() to check the
boottime was broken. Replaced this code with kvm_nlist()/kvm_read() to be
more efficient.

kill bad casts

kill extern'd lseek()

From: mrm@sceard.com (M.R.Murphy)
Fix memory leak.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
after 0.2.2 "stable" patches applied