openssl: Stop dragging libpthread into every libcrypto user.

With the new _NETBSD_PTHREAD_CREATE_WEAK, libcrypto can have a call
to pthread_create without linking against libpthread, so it is not
necessary to link all libcrypto users against libpthread too.

Applications that link against libcrypto but not libpthread can't use
threaded OpenSSL functionality, of course -- OSSL_set_max_threads
will always fail in such applications.

This reverts all the makefile churn that I found for unnecessary
libpthread linkage since the openssl 3.5 import.

PR lib/59685: libcrypto should not depend on libpthread

adjust the previous to use the normal form of this construct.

XXX: make it a CC_WNO*?

Fixed syntax error from previous commit.

Unbreak LLVM builds.

LLVM does not have -Wuse-after-free and thus also complains about
-Wnon-use-after-free.

use -Wno-error=use-after-free for sign.c. GCC 14 incorrectly complains.

branches: 1.34.2;
crypto needs threads

branches: 1.33.2;
bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

Handle OpenSSL-3.x

branches: 1.31.6;
Add blocklist support to libwrap which enables all programs using libwrap
to block access from hosts we deny. (libwrap support from Greg A. Woods)

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

convert HAVE_GCC == 7 to HAVE_GCC >= 7.

use -Wno-error=format-truncation for code that seems particularly annoying
or unlikely to actually fail. some of the syslogd ones are not too hard
to fix, but most remain.

branches: 1.27.4;
only set api compat for 1.0

define OPENSSL_API_COMPAT

(doesn't entirely unbreak build yet)

Remove MKCRYPTO option.

Originally, MKCRYPTO was introduced because the United States
classified cryptography as a munition and restricted its export. The
export controls were substantially relaxed fifteen years ago, and are
essentially irrelevant for software with published source code.

In the intervening time, nobody bothered to remove the option after
its motivation -- the US export restriction -- was eliminated. I'm
not aware of any other operating system that has a similar option; I
expect it is mainly out of apathy for churn that we still have it.
Today, cryptography is an essential part of modern computing -- you
can't use the internet responsibly without cryptography.

The position of the TNF board of directors is that TNF makes no
representation that MKCRYPTO=no satisfies any country's cryptography
regulations.

My personal position is that the availability of cryptography is a
basic human right; that any local laws restricting it to a privileged
few are fundamentally immoral; and that it is wrong for developers to
spend effort crippling cryptography to work around such laws.

As proposed on tech-crypto, tech-security, and tech-userlevel to no
objections:

https://mail-index.netbsd.org/tech-crypto/2017/05/06/msg000719.html
https://mail-index.netbsd.org/tech-security/2017/05/06/msg000928.html
https://mail-index.netbsd.org/tech-userlevel/2017/05/06/msg010547.html

P.S. Reviewing all the uses of MKCRYPTO in src revealed a lot of
*bad* crypto that was conditional on it, e.g. DES in telnet... That
should probably be removed too, but on the grounds that it is bad,
not on the grounds that it is (nominally) crypto.

WARNS=4

branches: 1.23.6;
Allow syslogd to compile when MKCRYPTO=no. No promises as to whether
it works or not, as this has been broken since late 2008, when the
"encrypted connections" support was added to syslogd.

Enable WARNS=4 by default, except for:
cpuctl dumplfs hprop ipf iprop-log kadmin kcm kdc kdigest
kimpersonate kstash ktutil makefs ndbootd ntp pppd quot
racoon racoonctl rtadvd sntp sup tcpdchk tcpdmatch tcpdump
traceroute traceroute6 user veriexecgen wsmoused zic
(Mostly third-party applications)

branches: 1.21.2;
Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Only compile in IPv6 support if ${USE_INET6} != "no"

MKINET6 is for providing IPv6 infrastructure.
USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6).

use NETBSDSRCDIR as appropriate

add utmpx support;

no need for KAME_SCOPEID any longer

-DLIBWRAP will enable libwrap-based filtering on UDP socket messages.
PR 13348

IPv6 support in syslogd. actually we need library update as well.
NetBSD PR #8934 from Feico Dillema <dillema@acm.org> (with memory leak fix).

branches: 1.13.6;
symlink /var/run/log to /dev/log for transition period.

nit: order rcsid/sccsids

enable WARNS=1 by default, but disable in unclean 3rd party code

Add WARNS=1

- Fix warnings
- Use ttymsg from libutil.

Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

Merge/sync with 4.4lite2 -- just a change in version numbers and
RCS id strings.

specify man pages the new way.

don't need -lutil

Add RCS identifiers.

And a few more...

branches: 1.1.1;
Initial revision

- always set *to_buf to a timestamp, even if there was none reported/parseable
(Frank Kardel).
- merge the timestamp copying code to one place.
- factor out the debugging printf function.

Allow syslogd to compile when MKCRYPTO=no. No promises as to whether
it works or not, as this has been broken since late 2008, when the
"encrypted connections" support was added to syslogd.

Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

RCSID police.

branches: 1.4.4;
Use pidfile(3).

Merge/sync with 4.4lite2 -- just a change in version numbers and
RCS id strings.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sign.c: mark a variable used only in asserts as __diagused

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

Adjust to OpenSSL-1.1

- always set *to_buf to a timestamp, even if there was none reported/parseable
(Frank Kardel).
- merge the timestamp copying code to one place.
- factor out the debugging printf function.

WARNS=4

fix resource leaks and NULL uses found by Coverity scan.
Releng-ok by riz

branches: 1.3.8;
fix -Wsign-compare issues

Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

s/betwen/between/ and s/singed/signed/.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

syslog.conf(5): add back .Pp lost in previous

syslog.conf(5): improve markup

Use tagged lists, mark up literals, be consistent about options
(global): vs parameters (of a TLS action), fold TLS authentication
description into the TLS options section.

s/optons/options/

Remove workaround for ancient HTML generation code.

Remove duplicate word from the sentence.

Fix typos.

branches: 1.22.2; 1.22.4;
Typo

Bump date for FIFO support.

add support for outputting to FIFO's (Anthony Mallet)

RFC 5848

branches: 1.18.6; 1.18.12;
Fix previous: Dd argument and lost Em markup.

fold long lines.

.br -> .Pp, capitalize subsection titles

branches: 1.15.2;
Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Make HTML-save.

Merge the thorpej-syslogd-hack-branch down to the trunk. Enhancements
include:

- Extend the syntax of syslog.conf to allow selections of log destinations
by comma-separated lists of program name (including kernel-generated
messages) and originating host name.
- Ability to pipe selected messages through arbitrary filter commands.
- Ability to specify priority comparison operations.
- Improvements to domain name handling.
- Conversion to use kqueue for communication and signal events, eliminating
all unsafe signal handlers.
- Allow spaces as well as tabs in syslog.conf.
- Log kernel printfs at LOG_NOTICE instad of LOG_CRIT.
- Ability to log facility/priority with a log message.
- Reliability improvements.

branches: 1.11.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

Match example code with example comment; multiple selectors should be
separated by semicolons (in BUGS section); from jmc@openbsd.
While here, use more macros.

Drop a .Pp, sort sections.

Add sections to some xrefs.

branches: 1.7.4;
The "ftp" facility was not listed.

- Fix location of RCS Id string.
- It's now syslogd.pid, not syslog.pid.

branches: 1.5.8;
minor .Nm cleanup

Merge/sync with 4.4lite2. Fixed HISTORY line for syslog.conf.5. Note
that the claim in the HISTORY line for syslogd.8 that it appeared in
4.3BSD is probably bogus -- I remember it being a lot older.

document 'info' level; pr#1137 from Kenneth Stailey

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

PR/59455: Aaron: Added CAVEATS section from OpenBSD about syslogd not creating
files, but only logging to existing files.

syslogd.8 & syslogd.c: add -k option

Provide a means of disabling the translation of (remote) messages
received with facility kern to facility user. Feature equivalent to
what FreeBSD added years ago, though the code is slightly different
(a bit easier to follow expressively). Patches from RVP, provided in
PR lib/57172 (with very minor tweaks by me).

branches: 1.59.4;
syslogd: make -d accept an optional argument

Make it possible to specify the debug message categories with an
optional numeric argument. You'll have to read the fine source to
find out what they are. The number can be specified as the usual
decimal, hex (0x), or octal (0) literal with an optional ~negation.

Since syslogd uses getopt(3), not getopt_long(3), do a bit of
gymnastics so that both -d42 and -d 42 are accepted (I'm not inventing
long names for all the existing options just to support an optional
argument to -d).

-d without an argument still uses the old D_DEFAULT selection just in
case someone really relies on that. You can disable all debug
messages with -d0 but still get syslogd not daemonized.

Sort options.

syslogd: allow the reporting of buffer overflows to be disabled.

This generally isn't a good thing, nothing should be discard silently.
However, for systems that don't want big syslogd buffers or are too slow
to log effectively this reporting can now be disabled.

syslogd: allow the receiving buffer size to be set.

This allows the admin to try and avoid buffer overflow when a log of
logging appears in bursts.

branches: 1.55.4; 1.55.6;
Remove workaround for ancient HTML generation code.

fix thinko

Remove trailing whitespace.

Note enchancements that appeared in NetBSD 6.0.

branches: 1.51.2;
Remove unnecessary Bk/Ek pairs from SYNOPSIS.
No effective change except where I used the opportunity to sort options
and/or option descriptions.

add aliases for the protocol format

branches: 1.49.6;
reinstate a sentence partly removed in v1.43 regarding the default
facility/priority for local kernel messages

draft-ietf-syslog-protocol-23 -> RFC 5424

Bump date for previous.

note some options' optarg in DESCRIPTION as well.

make -o option consistent with others.

Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

branches: 1.42.2; 1.42.12; 1.42.24;
PR/14563: Brian A. Seklecki: syslogd binds udp sockets on all interfaces
Add -b option to pass a bind address.

Add -T to SYNOPSIS.

Fix typo.

PR 32579: Add a -T flag to syslogd, which causes it to use local time for
messages received from the network. Useful for collecting logs from
devices which do not have correct time.

Add it to usage.

Document it, also document that syslogd adds a timestamp with the local
time if it does not recognize the original timestamp field. Bump date.

Approved by wrstuden@.

Add reference to RFC 3164. From Pavel Cahyna in PR 32578.

branches: 1.37.2; 1.37.4; 1.37.6;
Fix typo, and make HTML-save.

Merge the thorpej-syslogd-hack-branch down to the trunk. Enhancements
include:

- Extend the syntax of syslog.conf to allow selections of log destinations
by comma-separated lists of program name (including kernel-generated
messages) and originating host name.
- Ability to pipe selected messages through arbitrary filter commands.
- Ability to specify priority comparison operations.
- Improvements to domain name handling.
- Conversion to use kqueue for communication and signal events, eliminating
all unsafe signal handlers.
- Allow spaces as well as tabs in syslog.conf.
- Log kernel printfs at LOG_NOTICE instad of LOG_CRIT.
- Ability to log facility/priority with a log message.
- Reliability improvements.

branches: 1.35.2;
Add -S to SYNOPSIS; sort descriptions; bump date for new -S flag.

Don't fsync() kernel messages by default -- enable it with the "-S" flag.
This avoids some seriously gratuitous disk hosage in various cases.

XXX It would probably be better to allow this to be specified in the config
file somehow.

Implement -r, which prevents syslogd from compressing multiple messages with
the same string into "last message repeated N times", and instead forces
syslogd to write out every message.

Based on '-c' in FreeBSD's syslogd, although a different option letter was
chosen because their syslogd requires '-c -c' to get this functionality,
and we don't have the support for logging to pipes which is what FreeBSD's
syslogd with a single '-c' is related to.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

setup -> set up.

New sentence, new line.

Add an explanation of the log format. From PR#14290.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

Sort options in man page, don't mention non-existing '-S' option,
use some more markup and improve existing one.
Sync usage() with man page.

Grammar fixes and a markup fix.

branches: 1.25.2;
Drop a .Pp, sort SEE ALSO.

Whitespace nits.

- No more lost error messages during syslogd startup, they now all appear on
stdout before syslogd becomes a daemon.
- Flags for setuid/setgid/chroot syslogd after initialization is completed
- Warning instead of silent ignoring for malformed lines (with spaces instead
of tags)
Approved by Christos

-DLIBWRAP will enable libwrap-based filtering on UDP socket messages.
PR 13348

new `-n' switch to avoid looking up hostnames.

Logical markup. Reported in bin/12816 by Tetsuya Isaki.

Xr newsyslog.

Remove caveat about behavior of `syslogd -s' when forwarding rules are
present -- this behavior has been fixed.

Back out and redo previous at Bill Sommerfeld's <sommerfeld@netbsd.org>
request:

instead of the -S flag, fix the -s flag to not open a socket
if there are no forwarding rules in /etc/syslog.conf

The behavior of syslogd when -s is specified and there are forwarding rules
should still be made cleaner.

1.) bring usage text up to date, and clarify description of `-s' option
in man page and comments -- for some time it has no longer prevents
an inet socket from being opened, just caused it to be ignored

2.) Fix this problem with `-s' -- syslogd always opens an inet socket, even if
-s is specified and it has nowhere to send to. This socket is then
shutdown(), but there is no way to not have this socket open.

Users setting up paranoid installations can now specify `-S' which
prevents any non-unix-domain sockets from being opened, even if
forwarding is specified in /etc/syslogd.conf.

As per the previous fix, this is not made the default for `-s', as it
also prevents syslogd from forwarding log messages.

3.) document the above in the man page and usage.

Justification: in light of the possibility of future DoS attacks, or the
desire to set up a machine which is relatively uninformative in the face
of port scans, users may quite legitimately want to control what sockets
are open on their machine. Telling such users that they cannot run
syslogd is non-ideal.

branches: 1.15.4;
- Fix location of RCS Id string.
- It's now syslogd.pid, not syslog.pid.

branches: 1.14.4;
s/acknowledgment/acknowledgement/

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

/var/run/log.

/dev/log moved to /var/run/syslog.socket.

Clean up SYNOPSIS formatting.

- allow -p /log/socket to appear more than once (and work as expected
if given this). this is extremely useful for chrooted daemons that
still want to create log entries via a local mechanism.

- create a new -P option that takes a filename of log sockets (equiv.
of calling syslogd which -p <each line of file>. this is useful
for the case of many chroot areas and keeping this information in
one place rather than having to remember it all.

if no -p options are given, the default (_PATH_LOG) is used as normal.

Change occurrences of "UNIX" to .Ux or .At as appropriate.

minor .Nm cleanup

alternate -> alternative, per PR 2643

Fix PR/2371, a spelling error and missing -s from the description.

Added code to implement mode in which syslogd listens only to unix
domain socket (triggered by -s option) and documentation for
same. This closes pr 1761, although the code is slightly different.

Merge/sync with 4.4lite2. Fixed HISTORY line for syslog.conf.5. Note
that the claim in the HISTORY line for syslogd.8 that it appeared in
4.3BSD is probably bogus -- I remember it being a lot older.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

use the correct variable - thanks, autobuild!

If '-u' or '-g' is given, create the pidfile prior to changing e[ug]id

The subsequent call to pidfile(3) after we daemonize will correctly take
over the pidfile.

Note: this will likely leave the truncated pidfile in place upon exit,
since the effective user is unlikely to have write permissions on
_PATH_VARRUN. This isn't a problem, since pidfile(3) does the right
thing at startup again, and the the pidfile being truncated will not
lead to erroneous diagnosis.

This fixes bin/27309, which I filed a little over 20 years ago.

Terminate full sentence comments with a period / capitalize correctly.
(No functional changes.)

syslogd.8 & syslogd.c: add -k option

Provide a means of disabling the translation of (remote) messages
received with facility kern to facility user. Feature equivalent to
what FreeBSD added years ago, though the code is slightly different
(a bit easier to follow expressively). Patches from RVP, provided in
PR lib/57172 (with very minor tweaks by me).

syslog.h & syslogd.c: avoid incorrect facility double-shifting

As discussed in PR lib/57172, don't double-shift facility values when
calculating logging contexts. Patch suggested by RVP, an approach also
consistent with what OpenBSD did, which is to simply remove LOG_MAKEPRI
and adjust the only place it's used in the tree. (This has the benefit
of exposing any third-party software that may have also been using the
incorrect value all this time.)

syslogd.c: avoid use of undefined macro (NFCI)

SIGN_NUM_PRIVALS isn't defined anywhere; fix the block, though it's not
actually applicable in NetBSD builds. Issue noted by and patch from RVP
as a peripheral item in PR lib/57172.

branches: 1.141.2;
syslogd.c: fix a typo in a comment

syslogd: make -d accept an optional argument

Make it possible to specify the debug message categories with an
optional numeric argument. You'll have to read the fine source to
find out what they are. The number can be specified as the usual
decimal, hex (0x), or octal (0) literal with an optional ~negation.

Since syslogd uses getopt(3), not getopt_long(3), do a bit of
gymnastics so that both -d42 and -d 42 are accepted (I'm not inventing
long names for all the existing options just to support an optional
argument to -d).

-d without an argument still uses the old D_DEFAULT selection just in
case someone really relies on that. You can disable all debug
messages with -d0 but still get syslogd not daemonized.

s/auxillary/auxiliary/ in comments.

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

s/bacause/because/

syslogd: in die(), don't call die() again recursively.

Particularly not for something as immaterial as close failing.

PR 55795

make the buffer fit any 32 bit number.

PR/55794: Jan Schaumann: Eliminate unchecked malloc

When reporting an error before daemonizing, prefix the error message
with the program name.

s/lenght/length/

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

Revert previous - local merge mishap

Sort options.

Make it compilable with gcc

syslogd: allow the reporting of buffer overflows to be disabled.

This generally isn't a good thing, nothing should be discard silently.
However, for systems that don't want big syslogd buffers or are too slow
to log effectively this reporting can now be disabled.

syslogd: allow the receiving buffer size to be set.

This allows the admin to try and avoid buffer overflow when a log of
logging appears in bursts.

branches: 1.125.2;
grow AF_UNIX receive buffer size

branches: 1.124.2;
Use looked up remote host for remote message without a hostname

An incoming remote message may not necessarily have a hostname
between the timestamp and the message. The the source of the remote
sender is already looked up so use that hostname/IP address rather
than the local hostname.

XXX: pullup-8
XXX: pullup-7
XXX: pullup-6

branches: 1.123.8;
PR/51234: Onno van der Linden: syslogd sometimes incorrectly handles iso to
bsd time conversion

tidy/fix printing of paths from sockaddr_un

- always set *to_buf to a timestamp, even if there was none reported/parseable
(Frank Kardel).
- merge the timestamp copying code to one place.
- factor out the debugging printf function.

- when checking hostname of incoming remote messages, fallback to checking
remote host if the message doesn't contain a hostname
- don't truncate IP addresses when reading syslogd.conf

branches: 1.119.4;
CID 1132759: Abort on dehumanize_number error on constant built-in string.

CID 1128379: Fix TOCTOU, always open the file first with non-blocking I/O,
do that stat later and leave the file as non-blocking because it does not
make a difference for plain files.

add support for outputting to FIFO's (Anthony Mallet)

fix two bugs related to queues (Anthony Mallet)
- the default values are in humanized number form so strtol does not work
- fix reversed size tests

PR/47861: Fredrik Pettai: keep track of the address family for each socket
opened and don't send the a message to the wrong family type.

ut_line does not have /dev in front of it. Add it, from dholland@

PR/47449: David Holland: Don't log to terminals with mesg n, unless it is a
wall message.

branches: 1.112.2;
remove dup O_NDELAY.

- fix writev1() to pre-decrement count.
- always open ttys with O_NDELAY.

don't call isatty() to the fd before opening it.

WARNS=4

Open and write to ttys using non-blocking I/O to prevent DoS when hardware
or software flow control prevents tty writes or when the tty line is too
slow to respond.

improve error handling.

add aliases for the protocol format

branches: 1.105.2; 1.105.4;
NULL does not need a cast

Now need to use own buffer for klog read due to previous change.

Defer the processing of incomplete line at the end of buffer so that
kernel printf messages logged to /var/log/messages become always
easier to read.

branches: 1.102.2;
Explicitly mark a NEWREF as unused

Properly use format strings

Allow syslogd to compile when MKCRYPTO=no. No promises as to whether
it works or not, as this has been broken since late 2008, when the
"encrypted connections" support was added to syslogd.

PR/40563: Takahiro Hayashi: syslogd(8) refers freed pointer on exiting

PR/40438: Takahiro Hayashi: syslogd(8) refers freed area

sign-compare fixes for amd64

fix -Wsign-compare issues

fix suseconds_t format.

PR/40043: Geoff C. Wing: syslogd timestamping and protocol parsing deficiencies
Syslogd does not properly handle:

1) the ADDDATE flag which is set with -T invocation and when messages
come from the kernel. Other cases where it is set it is ignored
as timestamping is always done (e.g. logmsg_async())

2) the variable found_ts in check_timestamp(). It would determine
whether or not the message had a (possibly valid) timestamp, set
found_ts to true, then ignore that in most cases. If we can't find
a timestamp return.

3) messages without a parsable timestamp should get one when outputting
the BSD syslog format so that a syslog-protocol timestamp isn't
injected (chopped off with BSD syslog length) giving something like:
"2008-11-27T15:0 cisco -: 1790:"
^ time might have been 2008-11-27T15:02:35.296497+11:00

4) syslog protocol version checking only checked for a leading numeral
one (1) then skipped two places (presuming a space). Messages sent
from some sources (e.g. my cisco) may be
"1795: Nov 27 04:12:52: %LINEPROTO-5-..."
which would be chopped to
"95: Nov 27 04:12:52: %LINEPROTO-5-..."

PR/39874: Geoff C. Wing: For compatibility trim hostname domains in bsd
output format when matching host lines.

Remove trailing whitespace.

use localtime_r

Call tzset() to init TZ information for localtime().

make sure that we memset the struct tm we pass to mktime and set isdst to -1
so that it will figure out if daylight savings is to be applied or not. From
Anon Ymous

PR/39857: Bernd Ernesti: Fix broken output caused by a wrong offset. From
Martin Schuette.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

Clarify how one is supposed to use the pointers returned by getutentries()
(the utmpentry.c code), specifically with respect to who owns them and
when to free them. Now they're owned by utmpentry.c, only. Abolish the
freeutentries() function, which was the wrong abstraction; add instead
endutentries(), which flushes out the internally managed memory.

Update callers as necessary. Some (e.g. talkd) had been leaking memory;
others (e.g. syslogd) had been accidentally freeing and reloading utmp
more often than necessary. There are a couple untidy bits in users and
rwhod that someone should look after sometime, maybe.

Fixes PR bin/35131, which was about talkd's memory leak.

branches: 1.84.18;
PR/34979: Scott Ellis: Detect 0 length name and skip it instead of infinite
loop.

matches_spec: fix a bug so that "+host111,host1" actually matches to host1.
add a simple sanity check.

PR/30879: Jukka Salmi: syslogd(8) doesn't parse `@' hostname specification
correctly

PR/28753: Martin J. Laubach: syslogd disables remote logging on non-fatal errors

Sync usage with man page (-b).

PR/14563: Brian A. Seklecki: syslogd binds udp sockets on all interfaces
Add -b option to pass a bind address.

It's "its."

PR 32579: Add a -T flag to syslogd, which causes it to use local time for
messages received from the network. Useful for collecting logs from
devices which do not have correct time.

Add it to usage.

Document it, also document that syslogd adds a timestamp with the local
time if it does not recognize the original timestamp field. Bump date.

Approved by wrstuden@.

appease gcc -Wuninitialized

Abolish the magic 7, and count iovectors explicitly.

Make syslogd automatically recover from full disks by noticing that the
write error was ENOSPC and either wait for a successfull write or a
different errno.

Fix typo that caused priories to compare incorrectly. PR bin/28376 and
bin/28380. Fix from Geoff Wing.

-u changed to -U when porting from FreeBSD; update comment.

We have to read the config file the first time after we allocate the
kqueue descriptor, because we set up events after we parse the file.

Unfortuntately, this means that we also have to do the chroot before
we read the config file. But this is OK -- the config file has to be
in the chroot environment anyway, because it has to be able to get to
it after SIGHUP.

Grrr, all because stupid kqueue descriptors are not inherited across
a fork. LAME.

Merge the thorpej-syslogd-hack-branch down to the trunk. Enhancements
include:

- Extend the syntax of syslog.conf to allow selections of log destinations
by comma-separated lists of program name (including kernel-generated
messages) and originating host name.
- Ability to pipe selected messages through arbitrary filter commands.
- Ability to specify priority comparison operations.
- Improvements to domain name handling.
- Conversion to use kqueue for communication and signal events, eliminating
all unsafe signal handlers.
- Allow spaces as well as tabs in syslog.conf.
- Log kernel printfs at LOG_NOTICE instad of LOG_CRIT.
- Ability to log facility/priority with a log message.
- Reliability improvements.

branches: 1.69.2;
Add (unsigned char) cast to ctype functions

Postpone initial setting of the alarm timer until after the call to daemon(),
as the timer would be cleared by daemon's fork().

Add -S to usage.

Don't fsync() kernel messages by default -- enable it with the "-S" flag.
This avoids some seriously gratuitous disk hosage in various cases.

XXX It would probably be better to allow this to be specified in the config
file somehow.

branches: 1.65.4;
use "volatile sig_atomic_t" for gothup; Havard Eidnes

make SIGHUP handler very small, and call init() from the main poll() loop.
should fix PR bin/24682.

Implement -r, which prevents syslogd from compressing multiple messages with
the same string into "last message repeated N times", and instead forces
syslogd to write out every message.

Based on '-c' in FreeBSD's syslogd, although a different option letter was
chosen because their syslogd requires '-c -c' to get this functionality,
and we don't have the support for logging to pipes which is what FreeBSD's
syslogd with a single '-c' is related to.

safer use of realloc

no need for explicit '?'; openbsd

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

whitespace fix

strlcpy audit

die if out-of-range uid/gid is specified.

set IPV6_V6ONLY to 1 to avoid complicated access control issue
(libwrap takes care of it, but just to be sure)

add utmpx support;

no need for KAME_SCOPEID any longer

ANSIfy, and some KNF. Sort options in getopt-switch. Drop some unneeded
include files.

Sort options in man page, don't mention non-existing '-S' option,
use some more markup and improve existing one.
Sync usage() with man page.

branches: 1.51.2;
remove commented out debug printf() accidentally committed in the last rev.
noted by YAMAMOTO Takashi<yamt@mwd.biglobe.ne.jp> in private email.

logpath_add(): store pointer to strdup(3)ed copy of path provided.
fixes -P /some/file.

None of the other calls to logerror() include a newline at the end of the
message, and it causes an unnecessary empty line in the syslog output.

Put pidfile after daemonize. This would fix newsyslog(8) error.

- No more lost error messages during syslogd startup, they now all appear on
stdout before syslogd becomes a daemon.
- Flags for setuid/setgid/chroot syslogd after initialization is completed
- Warning instead of silent ignoring for malformed lines (with spaces instead
of tags)
Approved by Christos

-DLIBWRAP will enable libwrap-based filtering on UDP socket messages.
PR 13348

new `-n' switch to avoid looking up hostnames.

plug memory leak. PR 12444.

convert to use getprogname()

Don't prematurely terminate log message on a 0x80 character

Use setlocale(3) to activate support for international characters.
This should fix PR bin/11007 by Bill Sommerfeld.

prevent one byte overrun in printline()

Fix minor thinko in previous. Make sure we close and keep closed all
sockets in the situation where all of the following are true:

* /etc/syslogd.conf contained forwarding actions when we were
started up or when we last received a HUP

* /etc/syslogd.conf has had all forwarding actions removed

* we are running with -s

and we receive a HUP.

Fix opening/closing of sockets when receiving a HUP, and /etc/syslog.conf
has been changed from having forwarding actions to having none, or vice versa.

Improve behavior of `syslogd -s'.

Even if we are forwarding, don't bind to udp/514 if running with `-s'.

Back out and redo previous at Bill Sommerfeld's <sommerfeld@netbsd.org>
request:

instead of the -S flag, fix the -s flag to not open a socket
if there are no forwarding rules in /etc/syslog.conf

The behavior of syslogd when -s is specified and there are forwarding rules
should still be made cleaner.

1.) bring usage text up to date, and clarify description of `-s' option
in man page and comments -- for some time it has no longer prevents
an inet socket from being opened, just caused it to be ignored

2.) Fix this problem with `-s' -- syslogd always opens an inet socket, even if
-s is specified and it has nowhere to send to. This socket is then
shutdown(), but there is no way to not have this socket open.

Users setting up paranoid installations can now specify `-S' which
prevents any non-unix-domain sockets from being opened, even if
forwarding is specified in /etc/syslogd.conf.

As per the previous fix, this is not made the default for `-s', as it
also prevents syslogd from forwarding log messages.

3.) document the above in the man page and usage.

Justification: in light of the possibility of future DoS attacks, or the
desire to set up a machine which is relatively uninformative in the face
of port scans, users may quite legitimately want to control what sockets
are open on their machine. Telling such users that they cannot run
syslogd is non-ideal.

branches: 1.34.4;
* in secure mode (-s), still open the inet sockets but do a shutdown(,SHUT_RD)
on each of them, and don't bother listening on them. this allows messages
to be forwarded even with -s enabled.

XXX: not 100% sure if this is susceptable to a DoS, e.g someone filling
up kernel buffers with a backlog of packets not being read, but shutdown(2)
should prevent that even if it possibly doesn't at this time.

* minor KNF

use sizeof(foo) instead of hardcoded value, to help synchronizing
variable def and function parameter.

RCSID police.

be more friendly with non-IPv6 kernel.

IPv6 support in syslogd. actually we need library update as well.
NetBSD PR #8934 from Feico Dillema <dillema@acm.org> (with memory leak fix).

add some debug messages.

branches: 1.28.4;
save/restore errno as necessary (printf() et al might have modified it...)

Use pidfile(3).

Because the old bound check is used at several places we need to make
sure that the array is really NULL terminated. Fixes PR bin/7062.

Correct precedence in calculation of storage for pollfds.

- Don't use static array hack if neither "-p" nor "-P" are used.
- Because the logsocket array is not NULL terminated use the entry number
for bound checks.

Use correct expression "sizeof(char *)" instead of "sizeof(char **)"
to calculate memory size.

- allow -p /log/socket to appear more than once (and work as expected
if given this). this is extremely useful for chrooted daemons that
still want to create log entries via a local mechanism.

- create a new -P option that takes a filename of log sockets (equiv.
of calling syslogd which -p <each line of file>. this is useful
for the case of many chroot areas and keeping this information in
one place rather than having to remember it all.

if no -p options are given, the default (_PATH_LOG) is used as normal.

Use "[host]: " as prefix for forwarded messages to distinguish them
from message originated by the forwarding host, fixes PR bin/5860 by
Greg A. Woods.

use AF_LOCAL instead of AF_UNIX

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

Fix arithmetics lossage on typeless pointers.

prefer snprintf() to sprintf()

getopt returns -1 not EOF

Commit userland part of pr-1891.

If f->f_type is F_FORW, don't close f->file.

Store constant `F_UNUSED' into the right place f->f_type
rather than f->f_file.

Cast time_t's to long, and use %ld format, when printing.

- Fix warnings
- Use ttymsg from libutil.

NULL => 0 (Arne Juul; PR#3629)

add 0 and 0x prefixes for octal and hex numbers, in debug messages (based on pr#2964).

do not write pid file in debug mode. (pr#2825)

Added code to implement mode in which syslogd listens only to unix
domain socket (triggered by -s option) and documentation for
same. This closes pr 1761, although the code is slightly different.

cast return value of hstrerror() as this changes with the incoming bind
distribution to be const char *, and, causes a warning.

Merge/Sync with 4.4lite2. This is the 4.4lite2 version with NetBSD bug
fixes thrown in (and an apparent pre-NetBSD fix to a hardcoded
"vmunix"). I also set the ttymsg timeout to one second (as per our
previous version), rather than the five minutes set in lite2, and made
the timeout set by a #define.

Use hstrerror(), not h_errlist[].

fix priority mangling when sending to remote syslogds. (pr 1039, by
Jarle Greipsland.) Fix not exactly the same as the one in the PR, but close.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

add parens around defines with expressions that could expand poorly
depending on the usage.

branches: 1.7.16;
according to C99 6.5.15 in a conditional expression, both
operands should be of compatible types.

So, use ((void)0) here to match `void dbprintf()'

Format string annotation.

- always set *to_buf to a timestamp, even if there was none reported/parseable
(Frank Kardel).
- merge the timestamp copying code to one place.
- factor out the debugging printf function.

PR/47861: Fredrik Pettai: keep track of the address family for each socket
opened and don't send the a message to the wrong family type.

branches: 1.3.6; 1.3.8; 1.3.12;
Add queue macros SLIST_FOREACH_SAFE, STAILQ_FOREACH_SAFE, STAILQ_LAST,
SIMPLEQ_CONCAT, and SIMPLEQ_LAST.

Remove seperate definitions outside of queue.h.

branches: 1.2.2;
Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

tls.c: wrap debug-only data in #ifndef NDEBUG

s/wich/which in comments.

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

fix typos in word "successful".

With TLSv1.3 a client has to receive and process metadata.

Update dispatch_tls_eof() to check for metadata and
rearm on success.

Ok: christos@

branches: 1.16.4; 1.16.6;
include dh.h in the right spot.

Correct misleading indentation.

Adjust to OpenSSL-1.1

need <sys/stat.h>

branches: 1.12.2;
PR/50751: David Binderman: check bounds before dereferencing.

PR/47861: Fredrik Pettai: keep track of the address family for each socket
opened and don't send the a message to the wrong family type.

branches: 1.10.2;
WARNS=4

branches: 1.9.2;
fix resource leaks and NULL uses found by Coverity scan.
Releng-ok by riz

branches: 1.8.2;
Simplify.

According to the Oxford Dictionary of Etymology, a wether is a male sheep
or ram.

Properly use format strings

cast isblank(3)'s argument to unsigned char.

fix -Wsign-compare issues

Remove trailing whitespace.

no point in using int_fast16_t here.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections

include dh.h in the right spot.

Remove trailing whitespace.

Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
and draft-rfc timestamps
- reliable tcp connections with queueing
- encrypted connections