History log of /xsrc/external/mit/xorg-server.old/dist/randr/
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
64af8fac 02-Nov-2024 mrg <mrg@NetBSD.org>

merge upstream change 14f480010a93ff962fef66a16412fafff81ad632:

Subject: [PATCH] randr: avoid integer truncation in length check of
ProcRRChange*Property

Affected are ProcRRChangeProviderProperty and ProcRRChangeOutputProperty.
See also xserver@8f454b79 where this same bug was fixed for the core
protocol and XI.

This fixes an OOB read and the resulting information disclosure.

Length calculation for the request was clipped to a 32-bit integer. With
the correct stuff->nUnits value the expected request size was
truncated, passing the REQUEST_FIXED_SIZE check.

The server then proceeded with reading at least stuff->num_items bytes
(depending on stuff->format) from the request and stuffing whatever it
finds into the property. In the process it would also allocate at least
stuff->nUnits bytes, i.e. 4GB.

CVE-2023-6478, ZDI-CAN-22561

This vulnerability was discovered by:
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

bc1411c9 28-Oct-2023 mrg <mrg@NetBSD.org>

merge security fixes from xorg-server 21.1.9 into xorg-server 10.

Fixes CVE-2023-5367 and CVE-2023-5380.

706f2543 09-Jun-2016 mrg <mrg@NetBSD.org>

initial import of existing netbsd xorg-server 1.10 sources in the
xorg-server.old subdir.