Home | History | Annotate | Line # | Download | only in dist
sshsig.c revision 1.1.1.5
      1 /* $OpenBSD: sshsig.c,v 1.20 2021/01/31 10:50:10 dtucker Exp $ */
      2 /*
      3  * Copyright (c) 2019 Google LLC
      4  *
      5  * Permission to use, copy, modify, and distribute this software for any
      6  * purpose with or without fee is hereby granted, provided that the above
      7  * copyright notice and this permission notice appear in all copies.
      8  *
      9  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
     10  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
     11  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
     12  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
     13  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
     14  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
     15  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
     16  */
     17 
     18 #include <stdio.h>
     19 #include <stdlib.h>
     20 #include <stdarg.h>
     21 #include <errno.h>
     22 #include <string.h>
     23 #include <unistd.h>
     24 
     25 #include "authfd.h"
     26 #include "authfile.h"
     27 #include "log.h"
     28 #include "misc.h"
     29 #include "sshbuf.h"
     30 #include "sshsig.h"
     31 #include "ssherr.h"
     32 #include "sshkey.h"
     33 #include "match.h"
     34 #include "digest.h"
     35 
     36 #define SIG_VERSION		0x01
     37 #define MAGIC_PREAMBLE		"SSHSIG"
     38 #define MAGIC_PREAMBLE_LEN	(sizeof(MAGIC_PREAMBLE) - 1)
     39 #define BEGIN_SIGNATURE		"-----BEGIN SSH SIGNATURE-----\n"
     40 #define END_SIGNATURE		"-----END SSH SIGNATURE-----"
     41 #define RSA_SIGN_ALG		"rsa-sha2-512" /* XXX maybe make configurable */
     42 #define RSA_SIGN_ALLOWED	"rsa-sha2-512,rsa-sha2-256"
     43 #define HASHALG_DEFAULT		"sha512" /* XXX maybe make configurable */
     44 #define HASHALG_ALLOWED		"sha256,sha512"
     45 
     46 int
     47 sshsig_armor(const struct sshbuf *blob, struct sshbuf **out)
     48 {
     49 	struct sshbuf *buf = NULL;
     50 	int r = SSH_ERR_INTERNAL_ERROR;
     51 
     52 	*out = NULL;
     53 
     54 	if ((buf = sshbuf_new()) == NULL) {
     55 		error_f("sshbuf_new failed");
     56 		r = SSH_ERR_ALLOC_FAIL;
     57 		goto out;
     58 	}
     59 
     60 	if ((r = sshbuf_put(buf, BEGIN_SIGNATURE,
     61 	    sizeof(BEGIN_SIGNATURE)-1)) != 0) {
     62 		error_fr(r, "sshbuf_putf");
     63 		goto out;
     64 	}
     65 
     66 	if ((r = sshbuf_dtob64(blob, buf, 1)) != 0) {
     67 		error_fr(r, "base64 encode signature");
     68 		goto out;
     69 	}
     70 
     71 	if ((r = sshbuf_put(buf, END_SIGNATURE,
     72 	    sizeof(END_SIGNATURE)-1)) != 0 ||
     73 	    (r = sshbuf_put_u8(buf, '\n')) != 0) {
     74 		error_fr(r, "sshbuf_put");
     75 		goto out;
     76 	}
     77 	/* success */
     78 	*out = buf;
     79 	buf = NULL; /* transferred */
     80 	r = 0;
     81  out:
     82 	sshbuf_free(buf);
     83 	return r;
     84 }
     85 
     86 int
     87 sshsig_dearmor(struct sshbuf *sig, struct sshbuf **out)
     88 {
     89 	int r;
     90 	size_t eoffset = 0;
     91 	struct sshbuf *buf = NULL;
     92 	struct sshbuf *sbuf = NULL;
     93 	char *b64 = NULL;
     94 
     95 	if ((sbuf = sshbuf_fromb(sig)) == NULL) {
     96 		error_f("sshbuf_fromb failed");
     97 		return SSH_ERR_ALLOC_FAIL;
     98 	}
     99 
    100 	if ((r = sshbuf_cmp(sbuf, 0,
    101 	    BEGIN_SIGNATURE, sizeof(BEGIN_SIGNATURE)-1)) != 0) {
    102 		error("Couldn't parse signature: missing header");
    103 		goto done;
    104 	}
    105 
    106 	if ((r = sshbuf_consume(sbuf, sizeof(BEGIN_SIGNATURE)-1)) != 0) {
    107 		error_fr(r, "consume");
    108 		goto done;
    109 	}
    110 
    111 	if ((r = sshbuf_find(sbuf, 0, "\n" END_SIGNATURE,
    112 	    sizeof("\n" END_SIGNATURE)-1, &eoffset)) != 0) {
    113 		error("Couldn't parse signature: missing footer");
    114 		goto done;
    115 	}
    116 
    117 	if ((r = sshbuf_consume_end(sbuf, sshbuf_len(sbuf)-eoffset)) != 0) {
    118 		error_fr(r, "consume");
    119 		goto done;
    120 	}
    121 
    122 	if ((b64 = sshbuf_dup_string(sbuf)) == NULL) {
    123 		error_f("sshbuf_dup_string failed");
    124 		r = SSH_ERR_ALLOC_FAIL;
    125 		goto done;
    126 	}
    127 
    128 	if ((buf = sshbuf_new()) == NULL) {
    129 		error_f("sshbuf_new() failed");
    130 		r = SSH_ERR_ALLOC_FAIL;
    131 		goto done;
    132 	}
    133 
    134 	if ((r = sshbuf_b64tod(buf, b64)) != 0) {
    135 		error_fr(r, "decode base64");
    136 		goto done;
    137 	}
    138 
    139 	/* success */
    140 	*out = buf;
    141 	r = 0;
    142 	buf = NULL; /* transferred */
    143 done:
    144 	sshbuf_free(buf);
    145 	sshbuf_free(sbuf);
    146 	free(b64);
    147 	return r;
    148 }
    149 
    150 static int
    151 sshsig_wrap_sign(struct sshkey *key, const char *hashalg,
    152     const char *sk_provider, const char *sk_pin, const struct sshbuf *h_message,
    153     const char *sig_namespace, struct sshbuf **out,
    154     sshsig_signer *signer, void *signer_ctx)
    155 {
    156 	int r;
    157 	size_t slen = 0;
    158 	u_char *sig = NULL;
    159 	struct sshbuf *blob = NULL;
    160 	struct sshbuf *tosign = NULL;
    161 	const char *sign_alg = NULL;
    162 
    163 	if ((tosign = sshbuf_new()) == NULL ||
    164 	    (blob = sshbuf_new()) == NULL) {
    165 		error_f("sshbuf_new failed");
    166 		r = SSH_ERR_ALLOC_FAIL;
    167 		goto done;
    168 	}
    169 
    170 	if ((r = sshbuf_put(tosign, MAGIC_PREAMBLE, MAGIC_PREAMBLE_LEN)) != 0 ||
    171 	    (r = sshbuf_put_cstring(tosign, sig_namespace)) != 0 ||
    172 	    (r = sshbuf_put_string(tosign, NULL, 0)) != 0 || /* reserved */
    173 	    (r = sshbuf_put_cstring(tosign, hashalg)) != 0 ||
    174 	    (r = sshbuf_put_stringb(tosign, h_message)) != 0) {
    175 		error_fr(r, "assemble message to sign");
    176 		goto done;
    177 	}
    178 
    179 	/* If using RSA keys then default to a good signature algorithm */
    180 	if (sshkey_type_plain(key->type) == KEY_RSA)
    181 		sign_alg = RSA_SIGN_ALG;
    182 
    183 	if (signer != NULL) {
    184 		if ((r = signer(key, &sig, &slen,
    185 		    sshbuf_ptr(tosign), sshbuf_len(tosign),
    186 		    sign_alg, sk_provider, sk_pin, 0, signer_ctx)) != 0) {
    187 			error_r(r, "Couldn't sign message (signer)");
    188 			goto done;
    189 		}
    190 	} else {
    191 		if ((r = sshkey_sign(key, &sig, &slen,
    192 		    sshbuf_ptr(tosign), sshbuf_len(tosign),
    193 		    sign_alg, sk_provider, sk_pin, 0)) != 0) {
    194 			error_r(r, "Couldn't sign message");
    195 			goto done;
    196 		}
    197 	}
    198 
    199 	if ((r = sshbuf_put(blob, MAGIC_PREAMBLE, MAGIC_PREAMBLE_LEN)) != 0 ||
    200 	    (r = sshbuf_put_u32(blob, SIG_VERSION)) != 0 ||
    201 	    (r = sshkey_puts(key, blob)) != 0 ||
    202 	    (r = sshbuf_put_cstring(blob, sig_namespace)) != 0 ||
    203 	    (r = sshbuf_put_string(blob, NULL, 0)) != 0 || /* reserved */
    204 	    (r = sshbuf_put_cstring(blob, hashalg)) != 0 ||
    205 	    (r = sshbuf_put_string(blob, sig, slen)) != 0) {
    206 		error_fr(r, "assemble signature object");
    207 		goto done;
    208 	}
    209 
    210 	if (out != NULL) {
    211 		*out = blob;
    212 		blob = NULL;
    213 	}
    214 	r = 0;
    215 done:
    216 	free(sig);
    217 	sshbuf_free(blob);
    218 	sshbuf_free(tosign);
    219 	return r;
    220 }
    221 
    222 /* Check preamble and version. */
    223 static int
    224 sshsig_parse_preamble(struct sshbuf *buf)
    225 {
    226 	int r = SSH_ERR_INTERNAL_ERROR;
    227 	uint32_t sversion;
    228 
    229 	if ((r = sshbuf_cmp(buf, 0, MAGIC_PREAMBLE, MAGIC_PREAMBLE_LEN)) != 0 ||
    230 	    (r = sshbuf_consume(buf, (sizeof(MAGIC_PREAMBLE)-1))) != 0 ||
    231 	    (r = sshbuf_get_u32(buf, &sversion)) != 0) {
    232 		error("Couldn't verify signature: invalid format");
    233 		return r;
    234 	}
    235 
    236 	if (sversion > SIG_VERSION) {
    237 		error("Signature version %lu is larger than supported "
    238 		    "version %u", (unsigned long)sversion, SIG_VERSION);
    239 		return SSH_ERR_INVALID_FORMAT;
    240 	}
    241 	return 0;
    242 }
    243 
    244 static int
    245 sshsig_check_hashalg(const char *hashalg)
    246 {
    247 	if (hashalg == NULL ||
    248 	    match_pattern_list(hashalg, HASHALG_ALLOWED, 0) == 1)
    249 		return 0;
    250 	error_f("unsupported hash algorithm \"%.100s\"", hashalg);
    251 	return SSH_ERR_SIGN_ALG_UNSUPPORTED;
    252 }
    253 
    254 static int
    255 sshsig_peek_hashalg(struct sshbuf *signature, char **hashalgp)
    256 {
    257 	struct sshbuf *buf = NULL;
    258 	char *hashalg = NULL;
    259 	int r = SSH_ERR_INTERNAL_ERROR;
    260 
    261 	if (hashalgp != NULL)
    262 		*hashalgp = NULL;
    263 	if ((buf = sshbuf_fromb(signature)) == NULL)
    264 		return SSH_ERR_ALLOC_FAIL;
    265 	if ((r = sshsig_parse_preamble(buf)) != 0)
    266 		goto done;
    267 	if ((r = sshbuf_get_string_direct(buf, NULL, NULL)) != 0 ||
    268 	    (r = sshbuf_get_string_direct(buf, NULL, NULL)) != 0 ||
    269 	    (r = sshbuf_get_string(buf, NULL, NULL)) != 0 ||
    270 	    (r = sshbuf_get_cstring(buf, &hashalg, NULL)) != 0 ||
    271 	    (r = sshbuf_get_string_direct(buf, NULL, NULL)) != 0) {
    272 		error_fr(r, "parse signature object");
    273 		goto done;
    274 	}
    275 
    276 	/* success */
    277 	r = 0;
    278 	*hashalgp = hashalg;
    279 	hashalg = NULL;
    280  done:
    281 	free(hashalg);
    282 	sshbuf_free(buf);
    283 	return r;
    284 }
    285 
    286 static int
    287 sshsig_wrap_verify(struct sshbuf *signature, const char *hashalg,
    288     const struct sshbuf *h_message, const char *expect_namespace,
    289     struct sshkey **sign_keyp, struct sshkey_sig_details **sig_details)
    290 {
    291 	int r = SSH_ERR_INTERNAL_ERROR;
    292 	struct sshbuf *buf = NULL, *toverify = NULL;
    293 	struct sshkey *key = NULL;
    294 	const u_char *sig;
    295 	char *got_namespace = NULL, *sigtype = NULL, *sig_hashalg = NULL;
    296 	size_t siglen;
    297 
    298 	debug_f("verify message length %zu", sshbuf_len(h_message));
    299 	if (sig_details != NULL)
    300 		*sig_details = NULL;
    301 	if (sign_keyp != NULL)
    302 		*sign_keyp = NULL;
    303 
    304 	if ((toverify = sshbuf_new()) == NULL) {
    305 		error_f("sshbuf_new failed");
    306 		r = SSH_ERR_ALLOC_FAIL;
    307 		goto done;
    308 	}
    309 	if ((r = sshbuf_put(toverify, MAGIC_PREAMBLE,
    310 	    MAGIC_PREAMBLE_LEN)) != 0 ||
    311 	    (r = sshbuf_put_cstring(toverify, expect_namespace)) != 0 ||
    312 	    (r = sshbuf_put_string(toverify, NULL, 0)) != 0 || /* reserved */
    313 	    (r = sshbuf_put_cstring(toverify, hashalg)) != 0 ||
    314 	    (r = sshbuf_put_stringb(toverify, h_message)) != 0) {
    315 		error_fr(r, "assemble message to verify");
    316 		goto done;
    317 	}
    318 
    319 	if ((r = sshsig_parse_preamble(signature)) != 0)
    320 		goto done;
    321 
    322 	if ((r = sshkey_froms(signature, &key)) != 0 ||
    323 	    (r = sshbuf_get_cstring(signature, &got_namespace, NULL)) != 0 ||
    324 	    (r = sshbuf_get_string(signature, NULL, NULL)) != 0 ||
    325 	    (r = sshbuf_get_cstring(signature, &sig_hashalg, NULL)) != 0 ||
    326 	    (r = sshbuf_get_string_direct(signature, &sig, &siglen)) != 0) {
    327 		error_fr(r, "parse signature object");
    328 		goto done;
    329 	}
    330 
    331 	if (sshbuf_len(signature) != 0) {
    332 		error("Signature contains trailing data");
    333 		r = SSH_ERR_INVALID_FORMAT;
    334 		goto done;
    335 	}
    336 
    337 	if (strcmp(expect_namespace, got_namespace) != 0) {
    338 		error("Couldn't verify signature: namespace does not match");
    339 		debug_f("expected namespace \"%s\" received \"%s\"",
    340 		    expect_namespace, got_namespace);
    341 		r = SSH_ERR_SIGNATURE_INVALID;
    342 		goto done;
    343 	}
    344 	if (strcmp(hashalg, sig_hashalg) != 0) {
    345 		error("Couldn't verify signature: hash algorithm mismatch");
    346 		debug_f("expected algorithm \"%s\" received \"%s\"",
    347 		    hashalg, sig_hashalg);
    348 		r = SSH_ERR_SIGNATURE_INVALID;
    349 		goto done;
    350 	}
    351 	/* Ensure that RSA keys use an acceptable signature algorithm */
    352 	if (sshkey_type_plain(key->type) == KEY_RSA) {
    353 		if ((r = sshkey_get_sigtype(sig, siglen, &sigtype)) != 0) {
    354 			error_r(r, "Couldn't verify signature: unable to get "
    355 			    "signature type");
    356 			goto done;
    357 		}
    358 		if (match_pattern_list(sigtype, RSA_SIGN_ALLOWED, 0) != 1) {
    359 			error("Couldn't verify signature: unsupported RSA "
    360 			    "signature algorithm %s", sigtype);
    361 			r = SSH_ERR_SIGN_ALG_UNSUPPORTED;
    362 			goto done;
    363 		}
    364 	}
    365 	if ((r = sshkey_verify(key, sig, siglen, sshbuf_ptr(toverify),
    366 	    sshbuf_len(toverify), NULL, 0, sig_details)) != 0) {
    367 		error_r(r, "Signature verification failed");
    368 		goto done;
    369 	}
    370 
    371 	/* success */
    372 	r = 0;
    373 	if (sign_keyp != NULL) {
    374 		*sign_keyp = key;
    375 		key = NULL; /* transferred */
    376 	}
    377 done:
    378 	free(got_namespace);
    379 	free(sigtype);
    380 	free(sig_hashalg);
    381 	sshbuf_free(buf);
    382 	sshbuf_free(toverify);
    383 	sshkey_free(key);
    384 	return r;
    385 }
    386 
    387 static int
    388 hash_buffer(const struct sshbuf *m, const char *hashalg, struct sshbuf **bp)
    389 {
    390 	char *hex, hash[SSH_DIGEST_MAX_LENGTH];
    391 	int alg, r = SSH_ERR_INTERNAL_ERROR;
    392 	struct sshbuf *b = NULL;
    393 
    394 	*bp = NULL;
    395 	memset(hash, 0, sizeof(hash));
    396 
    397 	if ((r = sshsig_check_hashalg(hashalg)) != 0)
    398 		return r;
    399 	if ((alg = ssh_digest_alg_by_name(hashalg)) == -1) {
    400 		error_f("can't look up hash algorithm %s", hashalg);
    401 		return SSH_ERR_INTERNAL_ERROR;
    402 	}
    403 	if ((r = ssh_digest_buffer(alg, m, hash, sizeof(hash))) != 0) {
    404 		error_fr(r, "ssh_digest_buffer");
    405 		return r;
    406 	}
    407 	if ((hex = tohex(hash, ssh_digest_bytes(alg))) != NULL) {
    408 		debug3_f("final hash: %s", hex);
    409 		freezero(hex, strlen(hex));
    410 	}
    411 	if ((b = sshbuf_new()) == NULL) {
    412 		r = SSH_ERR_ALLOC_FAIL;
    413 		goto out;
    414 	}
    415 	if ((r = sshbuf_put(b, hash, ssh_digest_bytes(alg))) != 0) {
    416 		error_fr(r, "sshbuf_put");
    417 		goto out;
    418 	}
    419 	*bp = b;
    420 	b = NULL; /* transferred */
    421 	/* success */
    422 	r = 0;
    423  out:
    424 	sshbuf_free(b);
    425 	explicit_bzero(hash, sizeof(hash));
    426 	return r;
    427 }
    428 
    429 int
    430 sshsig_signb(struct sshkey *key, const char *hashalg,
    431     const char *sk_provider, const char *sk_pin,
    432     const struct sshbuf *message, const char *sig_namespace,
    433     struct sshbuf **out, sshsig_signer *signer, void *signer_ctx)
    434 {
    435 	struct sshbuf *b = NULL;
    436 	int r = SSH_ERR_INTERNAL_ERROR;
    437 
    438 	if (hashalg == NULL)
    439 		hashalg = HASHALG_DEFAULT;
    440 	if (out != NULL)
    441 		*out = NULL;
    442 	if ((r = hash_buffer(message, hashalg, &b)) != 0) {
    443 		error_fr(r, "hash buffer");
    444 		goto out;
    445 	}
    446 	if ((r = sshsig_wrap_sign(key, hashalg, sk_provider, sk_pin, b,
    447 	    sig_namespace, out, signer, signer_ctx)) != 0)
    448 		goto out;
    449 	/* success */
    450 	r = 0;
    451  out:
    452 	sshbuf_free(b);
    453 	return r;
    454 }
    455 
    456 int
    457 sshsig_verifyb(struct sshbuf *signature, const struct sshbuf *message,
    458     const char *expect_namespace, struct sshkey **sign_keyp,
    459     struct sshkey_sig_details **sig_details)
    460 {
    461 	struct sshbuf *b = NULL;
    462 	int r = SSH_ERR_INTERNAL_ERROR;
    463 	char *hashalg = NULL;
    464 
    465 	if (sig_details != NULL)
    466 		*sig_details = NULL;
    467 	if (sign_keyp != NULL)
    468 		*sign_keyp = NULL;
    469 	if ((r = sshsig_peek_hashalg(signature, &hashalg)) != 0)
    470 		return r;
    471 	debug_f("signature made with hash \"%s\"", hashalg);
    472 	if ((r = hash_buffer(message, hashalg, &b)) != 0) {
    473 		error_fr(r, "hash buffer");
    474 		goto out;
    475 	}
    476 	if ((r = sshsig_wrap_verify(signature, hashalg, b, expect_namespace,
    477 	    sign_keyp, sig_details)) != 0)
    478 		goto out;
    479 	/* success */
    480 	r = 0;
    481  out:
    482 	sshbuf_free(b);
    483 	free(hashalg);
    484 	return r;
    485 }
    486 
    487 static int
    488 hash_file(int fd, const char *hashalg, struct sshbuf **bp)
    489 {
    490 	char *hex, rbuf[8192], hash[SSH_DIGEST_MAX_LENGTH];
    491 	ssize_t n, total = 0;
    492 	struct ssh_digest_ctx *ctx;
    493 	int alg, oerrno, r = SSH_ERR_INTERNAL_ERROR;
    494 	struct sshbuf *b = NULL;
    495 
    496 	*bp = NULL;
    497 	memset(hash, 0, sizeof(hash));
    498 
    499 	if ((r = sshsig_check_hashalg(hashalg)) != 0)
    500 		return r;
    501 	if ((alg = ssh_digest_alg_by_name(hashalg)) == -1) {
    502 		error_f("can't look up hash algorithm %s", hashalg);
    503 		return SSH_ERR_INTERNAL_ERROR;
    504 	}
    505 	if ((ctx = ssh_digest_start(alg)) == NULL) {
    506 		error_f("ssh_digest_start failed");
    507 		return SSH_ERR_INTERNAL_ERROR;
    508 	}
    509 	for (;;) {
    510 		if ((n = read(fd, rbuf, sizeof(rbuf))) == -1) {
    511 			if (errno == EINTR || errno == EAGAIN)
    512 				continue;
    513 			oerrno = errno;
    514 			error_f("read: %s", strerror(errno));
    515 			ssh_digest_free(ctx);
    516 			errno = oerrno;
    517 			r = SSH_ERR_SYSTEM_ERROR;
    518 			goto out;
    519 		} else if (n == 0) {
    520 			debug2_f("hashed %zu bytes", total);
    521 			break; /* EOF */
    522 		}
    523 		total += (size_t)n;
    524 		if ((r = ssh_digest_update(ctx, rbuf, (size_t)n)) != 0) {
    525 			error_fr(r, "ssh_digest_update");
    526 			goto out;
    527 		}
    528 	}
    529 	if ((r = ssh_digest_final(ctx, hash, sizeof(hash))) != 0) {
    530 		error_fr(r, "ssh_digest_final");
    531 		goto out;
    532 	}
    533 	if ((hex = tohex(hash, ssh_digest_bytes(alg))) != NULL) {
    534 		debug3_f("final hash: %s", hex);
    535 		freezero(hex, strlen(hex));
    536 	}
    537 	if ((b = sshbuf_new()) == NULL) {
    538 		r = SSH_ERR_ALLOC_FAIL;
    539 		goto out;
    540 	}
    541 	if ((r = sshbuf_put(b, hash, ssh_digest_bytes(alg))) != 0) {
    542 		error_fr(r, "sshbuf_put");
    543 		goto out;
    544 	}
    545 	*bp = b;
    546 	b = NULL; /* transferred */
    547 	/* success */
    548 	r = 0;
    549  out:
    550 	sshbuf_free(b);
    551 	ssh_digest_free(ctx);
    552 	explicit_bzero(hash, sizeof(hash));
    553 	return r;
    554 }
    555 
    556 int
    557 sshsig_sign_fd(struct sshkey *key, const char *hashalg,
    558     const char *sk_provider, const char *sk_pin,
    559     int fd, const char *sig_namespace, struct sshbuf **out,
    560     sshsig_signer *signer, void *signer_ctx)
    561 {
    562 	struct sshbuf *b = NULL;
    563 	int r = SSH_ERR_INTERNAL_ERROR;
    564 
    565 	if (hashalg == NULL)
    566 		hashalg = HASHALG_DEFAULT;
    567 	if (out != NULL)
    568 		*out = NULL;
    569 	if ((r = hash_file(fd, hashalg, &b)) != 0) {
    570 		error_fr(r, "hash_file");
    571 		return r;
    572 	}
    573 	if ((r = sshsig_wrap_sign(key, hashalg, sk_provider, sk_pin, b,
    574 	    sig_namespace, out, signer, signer_ctx)) != 0)
    575 		goto out;
    576 	/* success */
    577 	r = 0;
    578  out:
    579 	sshbuf_free(b);
    580 	return r;
    581 }
    582 
    583 int
    584 sshsig_verify_fd(struct sshbuf *signature, int fd,
    585     const char *expect_namespace, struct sshkey **sign_keyp,
    586     struct sshkey_sig_details **sig_details)
    587 {
    588 	struct sshbuf *b = NULL;
    589 	int r = SSH_ERR_INTERNAL_ERROR;
    590 	char *hashalg = NULL;
    591 
    592 	if (sig_details != NULL)
    593 		*sig_details = NULL;
    594 	if (sign_keyp != NULL)
    595 		*sign_keyp = NULL;
    596 	if ((r = sshsig_peek_hashalg(signature, &hashalg)) != 0)
    597 		return r;
    598 	debug_f("signature made with hash \"%s\"", hashalg);
    599 	if ((r = hash_file(fd, hashalg, &b)) != 0) {
    600 		error_fr(r, "hash_file");
    601 		goto out;
    602 	}
    603 	if ((r = sshsig_wrap_verify(signature, hashalg, b, expect_namespace,
    604 	    sign_keyp, sig_details)) != 0)
    605 		goto out;
    606 	/* success */
    607 	r = 0;
    608  out:
    609 	sshbuf_free(b);
    610 	free(hashalg);
    611 	return r;
    612 }
    613 
    614 struct sshsigopt {
    615 	int ca;
    616 	char *namespaces;
    617 };
    618 
    619 struct sshsigopt *
    620 sshsigopt_parse(const char *opts, const char *path, u_long linenum,
    621     const char **errstrp)
    622 {
    623 	struct sshsigopt *ret;
    624 	int r;
    625 	const char *errstr = NULL;
    626 
    627 	if ((ret = calloc(1, sizeof(*ret))) == NULL)
    628 		return NULL;
    629 	if (opts == NULL || *opts == '\0')
    630 		return ret; /* Empty options yields empty options :) */
    631 
    632 	while (*opts && *opts != ' ' && *opts != '\t') {
    633 		/* flag options */
    634 		if ((r = opt_flag("cert-authority", 0, &opts)) != -1) {
    635 			ret->ca = 1;
    636 		} else if (opt_match(&opts, "namespaces")) {
    637 			if (ret->namespaces != NULL) {
    638 				errstr = "multiple \"namespaces\" clauses";
    639 				goto fail;
    640 			}
    641 			ret->namespaces = opt_dequote(&opts, &errstr);
    642 			if (ret->namespaces == NULL)
    643 				goto fail;
    644 		}
    645 		/*
    646 		 * Skip the comma, and move to the next option
    647 		 * (or break out if there are no more).
    648 		 */
    649 		if (*opts == '\0' || *opts == ' ' || *opts == '\t')
    650 			break;		/* End of options. */
    651 		/* Anything other than a comma is an unknown option */
    652 		if (*opts != ',') {
    653 			errstr = "unknown key option";
    654 			goto fail;
    655 		}
    656 		opts++;
    657 		if (*opts == '\0') {
    658 			errstr = "unexpected end-of-options";
    659 			goto fail;
    660 		}
    661 	}
    662 	/* success */
    663 	return ret;
    664  fail:
    665 	if (errstrp != NULL)
    666 		*errstrp = errstr;
    667 	sshsigopt_free(ret);
    668 	return NULL;
    669 }
    670 
    671 void
    672 sshsigopt_free(struct sshsigopt *opts)
    673 {
    674 	if (opts == NULL)
    675 		return;
    676 	free(opts->namespaces);
    677 	free(opts);
    678 }
    679 
    680 static int
    681 parse_principals_key_and_options(const char *path, u_long linenum, char *line,
    682     const char *required_principal, char **principalsp, struct sshkey **keyp,
    683     struct sshsigopt **sigoptsp)
    684 {
    685 	char *opts = NULL, *tmp, *cp, *principals = NULL;
    686 	const char *reason = NULL;
    687 	struct sshsigopt *sigopts = NULL;
    688 	struct sshkey *key = NULL;
    689 	int r = SSH_ERR_INTERNAL_ERROR;
    690 
    691 	if (principalsp != NULL)
    692 		*principalsp = NULL;
    693 	if (sigoptsp != NULL)
    694 		*sigoptsp = NULL;
    695 	if (keyp != NULL)
    696 		*keyp = NULL;
    697 
    698 	cp = line;
    699 	cp = cp + strspn(cp, " \t"); /* skip leading whitespace */
    700 	if (*cp == '#' || *cp == '\0')
    701 		return SSH_ERR_KEY_NOT_FOUND; /* blank or all-comment line */
    702 
    703 	/* format: identity[,identity...] [option[,option...]] key */
    704 	if ((tmp = strdelimw(&cp)) == NULL) {
    705 		error("%s:%lu: invalid line", path, linenum);
    706 		r = SSH_ERR_INVALID_FORMAT;
    707 		goto out;
    708 	}
    709 	if ((principals = strdup(tmp)) == NULL) {
    710 		error_f("strdup failed");
    711 		r = SSH_ERR_ALLOC_FAIL;
    712 		goto out;
    713 	}
    714 	/*
    715 	 * Bail out early if we're looking for a particular principal and this
    716 	 * line does not list it.
    717 	 */
    718 	if (required_principal != NULL) {
    719 		if (match_pattern_list(required_principal,
    720 		    principals, 0) != 1) {
    721 			/* principal didn't match */
    722 			r = SSH_ERR_KEY_NOT_FOUND;
    723 			goto out;
    724 		}
    725 		debug_f("%s:%lu: matched principal \"%s\"",
    726 		    path, linenum, required_principal);
    727 	}
    728 
    729 	if ((key = sshkey_new(KEY_UNSPEC)) == NULL) {
    730 		error_f("sshkey_new failed");
    731 		r = SSH_ERR_ALLOC_FAIL;
    732 		goto out;
    733 	}
    734 	if (sshkey_read(key, &cp) != 0) {
    735 		/* no key? Check for options */
    736 		opts = cp;
    737 		if (sshkey_advance_past_options(&cp) != 0) {
    738 			error("%s:%lu: invalid options", path, linenum);
    739 			r = SSH_ERR_INVALID_FORMAT;
    740 			goto out;
    741 		}
    742 		*cp++ = '\0';
    743 		skip_space(&cp);
    744 		if (sshkey_read(key, &cp) != 0) {
    745 			error("%s:%lu: invalid key", path, linenum);
    746 			r = SSH_ERR_INVALID_FORMAT;
    747 			goto out;
    748 		}
    749 	}
    750 	debug3("%s:%lu: options %s", path, linenum, opts == NULL ? "" : opts);
    751 	if ((sigopts = sshsigopt_parse(opts, path, linenum, &reason)) == NULL) {
    752 		error("%s:%lu: bad options: %s", path, linenum, reason);
    753 		r = SSH_ERR_INVALID_FORMAT;
    754 		goto out;
    755 	}
    756 	/* success */
    757 	if (principalsp != NULL) {
    758 		*principalsp = principals;
    759 		principals = NULL; /* transferred */
    760 	}
    761 	if (sigoptsp != NULL) {
    762 		*sigoptsp = sigopts;
    763 		sigopts = NULL; /* transferred */
    764 	}
    765 	if (keyp != NULL) {
    766 		*keyp = key;
    767 		key = NULL; /* transferred */
    768 	}
    769 	r = 0;
    770  out:
    771 	free(principals);
    772 	sshsigopt_free(sigopts);
    773 	sshkey_free(key);
    774 	return r;
    775 }
    776 
    777 static int
    778 check_allowed_keys_line(const char *path, u_long linenum, char *line,
    779     const struct sshkey *sign_key, const char *principal,
    780     const char *sig_namespace)
    781 {
    782 	struct sshkey *found_key = NULL;
    783 	int r, found = 0;
    784 	const char *reason = NULL;
    785 	struct sshsigopt *sigopts = NULL;
    786 
    787 	/* Parse the line */
    788 	if ((r = parse_principals_key_and_options(path, linenum, line,
    789 	    principal, NULL, &found_key, &sigopts)) != 0) {
    790 		/* error already logged */
    791 		goto done;
    792 	}
    793 
    794 	/* Check whether options preclude the use of this key */
    795 	if (sigopts->namespaces != NULL &&
    796 	    match_pattern_list(sig_namespace, sigopts->namespaces, 0) != 1) {
    797 		error("%s:%lu: key is not permitted for use in signature "
    798 		    "namespace \"%s\"", path, linenum, sig_namespace);
    799 		goto done;
    800 	}
    801 
    802 	if (!sigopts->ca && sshkey_equal(found_key, sign_key)) {
    803 		/* Exact match of key */
    804 		debug("%s:%lu: matched key and principal", path, linenum);
    805 		/* success */
    806 		found = 1;
    807 	} else if (sigopts->ca && sshkey_is_cert(sign_key) &&
    808 	    sshkey_equal_public(sign_key->cert->signature_key, found_key)) {
    809 		/* Match of certificate's CA key */
    810 		if ((r = sshkey_cert_check_authority(sign_key, 0, 1, 0,
    811 		    principal, &reason)) != 0) {
    812 			error("%s:%lu: certificate not authorized: %s",
    813 			    path, linenum, reason);
    814 			goto done;
    815 		}
    816 		debug("%s:%lu: matched certificate CA key", path, linenum);
    817 		/* success */
    818 		found = 1;
    819 	} else {
    820 		/* Principal matched but key didn't */
    821 		goto done;
    822 	}
    823  done:
    824 	sshkey_free(found_key);
    825 	sshsigopt_free(sigopts);
    826 	return found ? 0 : SSH_ERR_KEY_NOT_FOUND;
    827 }
    828 
    829 int
    830 sshsig_check_allowed_keys(const char *path, const struct sshkey *sign_key,
    831     const char *principal, const char *sig_namespace)
    832 {
    833 	FILE *f = NULL;
    834 	char *line = NULL;
    835 	size_t linesize = 0;
    836 	u_long linenum = 0;
    837 	int r = SSH_ERR_INTERNAL_ERROR, oerrno;
    838 
    839 	/* Check key and principal against file */
    840 	if ((f = fopen(path, "r")) == NULL) {
    841 		oerrno = errno;
    842 		error("Unable to open allowed keys file \"%s\": %s",
    843 		    path, strerror(errno));
    844 		errno = oerrno;
    845 		return SSH_ERR_SYSTEM_ERROR;
    846 	}
    847 
    848 	while (getline(&line, &linesize, f) != -1) {
    849 		linenum++;
    850 		r = check_allowed_keys_line(path, linenum, line, sign_key,
    851 		    principal, sig_namespace);
    852 		free(line);
    853 		line = NULL;
    854 		linesize = 0;
    855 		if (r == SSH_ERR_KEY_NOT_FOUND)
    856 			continue;
    857 		else if (r == 0) {
    858 			/* success */
    859 			fclose(f);
    860 			return 0;
    861 		} else
    862 			break;
    863 	}
    864 	/* Either we hit an error parsing or we simply didn't find the key */
    865 	fclose(f);
    866 	free(line);
    867 	return r == 0 ? SSH_ERR_KEY_NOT_FOUND : r;
    868 }
    869 
    870 static int
    871 cert_filter_principals(const char *path, u_long linenum,
    872     char **principalsp, const struct sshkey *cert)
    873 {
    874 	char *cp, *oprincipals, *principals;
    875 	const char *reason;
    876 	struct sshbuf *nprincipals;
    877 	int r = SSH_ERR_INTERNAL_ERROR, success = 0;
    878 
    879 	oprincipals = principals = *principalsp;
    880 	*principalsp = NULL;
    881 
    882 	if ((nprincipals = sshbuf_new()) == NULL) {
    883 		r = SSH_ERR_ALLOC_FAIL;
    884 		goto out;
    885 	}
    886 
    887 	while ((cp = strsep(&principals, ",")) != NULL && *cp != '\0') {
    888 		if (strcspn(cp, "!?*") != strlen(cp)) {
    889 			debug("%s:%lu: principal \"%s\" not authorized: "
    890 			    "contains wildcards", path, linenum, cp);
    891 			continue;
    892 		}
    893 		/* Check against principals list in certificate */
    894 		if ((r = sshkey_cert_check_authority(cert, 0, 1, 0,
    895 		    cp, &reason)) != 0) {
    896 			debug("%s:%lu: principal \"%s\" not authorized: %s",
    897 			    path, linenum, cp, reason);
    898 			continue;
    899 		}
    900 		if ((r = sshbuf_putf(nprincipals, "%s%s",
    901 		    sshbuf_len(nprincipals) != 0 ? "," : "", cp)) != 0) {
    902 			error_f("buffer error");
    903 			goto out;
    904 		}
    905 	}
    906 	if (sshbuf_len(nprincipals) == 0) {
    907 		error("%s:%lu: no valid principals found", path, linenum);
    908 		r = SSH_ERR_KEY_CERT_INVALID;
    909 		goto out;
    910 	}
    911 	if ((principals = sshbuf_dup_string(nprincipals)) == NULL) {
    912 		error_f("buffer error");
    913 		goto out;
    914 	}
    915 	/* success */
    916 	success = 1;
    917 	*principalsp = principals;
    918  out:
    919 	sshbuf_free(nprincipals);
    920 	free(oprincipals);
    921 	return success ? 0 : r;
    922 }
    923 
    924 static int
    925 get_matching_principals_from_line(const char *path, u_long linenum, char *line,
    926     const struct sshkey *sign_key, char **principalsp)
    927 {
    928 	struct sshkey *found_key = NULL;
    929 	char *principals = NULL;
    930 	int r, found = 0;
    931 	struct sshsigopt *sigopts = NULL;
    932 
    933 	if (principalsp != NULL)
    934 		*principalsp = NULL;
    935 
    936 	/* Parse the line */
    937 	if ((r = parse_principals_key_and_options(path, linenum, line,
    938 	    NULL, &principals, &found_key, &sigopts)) != 0) {
    939 		/* error already logged */
    940 		goto done;
    941 	}
    942 
    943 	if (!sigopts->ca && sshkey_equal(found_key, sign_key)) {
    944 		/* Exact match of key */
    945 		debug("%s:%lu: matched key", path, linenum);
    946 		/* success */
    947 		found = 1;
    948 	} else if (sigopts->ca && sshkey_is_cert(sign_key) &&
    949 	    sshkey_equal_public(sign_key->cert->signature_key, found_key)) {
    950 		/* Remove principals listed in file but not allowed by cert */
    951 		if ((r = cert_filter_principals(path, linenum,
    952 		    &principals, sign_key)) != 0) {
    953 			/* error already displayed */
    954 			debug_r(r, "%s:%lu: cert_filter_principals",
    955 			    path, linenum);
    956 			goto done;
    957 		}
    958 		debug("%s:%lu: matched certificate CA key", path, linenum);
    959 		/* success */
    960 		found = 1;
    961 	} else {
    962 		/* Key didn't match */
    963 		goto done;
    964 	}
    965  done:
    966 	if (found && principalsp != NULL) {
    967 		*principalsp = principals;
    968 		principals = NULL; /* transferred */
    969 	}
    970 	free(principals);
    971 	sshkey_free(found_key);
    972 	sshsigopt_free(sigopts);
    973 	return found ? 0 : SSH_ERR_KEY_NOT_FOUND;
    974 }
    975 
    976 int
    977 sshsig_find_principals(const char *path, const struct sshkey *sign_key,
    978     char **principals)
    979 {
    980 	FILE *f = NULL;
    981 	char *line = NULL;
    982 	size_t linesize = 0;
    983 	u_long linenum = 0;
    984 	int r = SSH_ERR_INTERNAL_ERROR, oerrno;
    985 
    986 	if ((f = fopen(path, "r")) == NULL) {
    987 		oerrno = errno;
    988 		error("Unable to open allowed keys file \"%s\": %s",
    989 		    path, strerror(errno));
    990 		errno = oerrno;
    991 		return SSH_ERR_SYSTEM_ERROR;
    992 	}
    993 
    994 	while (getline(&line, &linesize, f) != -1) {
    995 		linenum++;
    996 		r = get_matching_principals_from_line(path, linenum, line,
    997 		    sign_key, principals);
    998 		free(line);
    999 		line = NULL;
   1000 		linesize = 0;
   1001 		if (r == SSH_ERR_KEY_NOT_FOUND)
   1002 			continue;
   1003 		else if (r == 0) {
   1004 			/* success */
   1005 			fclose(f);
   1006 			return 0;
   1007 		} else
   1008 			break;
   1009 	}
   1010 	free(line);
   1011 	/* Either we hit an error parsing or we simply didn't find the key */
   1012 	if (ferror(f) != 0) {
   1013 		oerrno = errno;
   1014 		fclose(f);
   1015 		error("Unable to read allowed keys file \"%s\": %s",
   1016 		    path, strerror(errno));
   1017 		errno = oerrno;
   1018 		return SSH_ERR_SYSTEM_ERROR;
   1019 	}
   1020 	fclose(f);
   1021 	return r == 0 ? SSH_ERR_KEY_NOT_FOUND : r;
   1022 }
   1023 
   1024 int
   1025 sshsig_get_pubkey(struct sshbuf *signature, struct sshkey **pubkey)
   1026 {
   1027 	struct sshkey *pk = NULL;
   1028 	int r = SSH_ERR_SIGNATURE_INVALID;
   1029 
   1030 	if (pubkey == NULL)
   1031 		return SSH_ERR_INTERNAL_ERROR;
   1032 	if ((r = sshsig_parse_preamble(signature)) != 0)
   1033 		return r;
   1034 	if ((r = sshkey_froms(signature, &pk)) != 0)
   1035 		return r;
   1036 
   1037 	*pubkey = pk;
   1038 	pk = NULL;
   1039 	return 0;
   1040 }
   1041