1 1.1.1.2 christos HOW TO CONTRIBUTE TO OpenSSL 2 1.1.1.2 christos ---------------------------- 3 1.1 christos 4 1.1 christos (Please visit https://www.openssl.org/community/getting-started.html for 5 1.1 christos other ideas about how to contribute.) 6 1.1 christos 7 1.1.1.2 christos Development is done on GitHub, https://github.com/openssl/openssl. 8 1.1.1.2 christos 9 1.1.1.2 christos To request new features or report bugs, please open an issue on GitHub 10 1.1.1.2 christos 11 1.1.1.2 christos To submit a patch, please open a pull request on GitHub. If you are thinking 12 1.1.1.2 christos of making a large contribution, open an issue for it before starting work, 13 1.1.1.2 christos to get comments from the community. Someone may be already working on 14 1.1.1.2 christos the same thing or there may be reasons why that feature isn't implemented. 15 1.1.1.2 christos 16 1.1.1.2 christos To make it easier to review and accept your pull request, please follow these 17 1.1.1.2 christos guidelines: 18 1.1.1.2 christos 19 1.1.1.2 christos 1. Anything other than a trivial contribution requires a Contributor 20 1.1.1.2 christos License Agreement (CLA), giving us permission to use your code. See 21 1.1.1.2 christos https://www.openssl.org/policies/cla.html for details. If your 22 1.1.1.2 christos contribution is too small to require a CLA, put "CLA: trivial" on a 23 1.1.1.2 christos line by itself in your commit message body. 24 1.1 christos 25 1.1 christos 2. All source files should start with the following text (with 26 1.1 christos appropriate comment characters at the start of each line and the 27 1.1 christos year(s) updated): 28 1.1 christos 29 1.1 christos Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved. 30 1.1 christos 31 1.1 christos Licensed under the OpenSSL license (the "License"). You may not use 32 1.1 christos this file except in compliance with the License. You can obtain a copy 33 1.1 christos in the file LICENSE in the source distribution or at 34 1.1 christos https://www.openssl.org/source/license.html 35 1.1 christos 36 1.1 christos 3. Patches should be as current as possible; expect to have to rebase 37 1.1.1.2 christos often. We do not accept merge commits, you will have to remove them 38 1.1.1.2 christos (usually by rebasing) before it will be acceptable. 39 1.1 christos 40 1.1 christos 4. Patches should follow our coding style (see 41 1.1.1.2 christos https://www.openssl.org/policies/codingstyle.html) and compile 42 1.1.1.2 christos without warnings. Where gcc or clang is available you should use the 43 1.1 christos --strict-warnings Configure option. OpenSSL compiles on many varied 44 1.1.1.2 christos platforms: try to ensure you only use portable features. Clean builds via 45 1.1.1.2 christos GitHub Actions and AppVeyor are required, and they are started automatically 46 1.1.1.2 christos whenever a PR is created or updated. 47 1.1 christos 48 1.1 christos 5. When at all possible, patches should include tests. These can 49 1.1 christos either be added to an existing test, or completely new. Please see 50 1.1 christos test/README for information on the test framework. 51 1.1 christos 52 1.1 christos 6. New features or changed functionality must include 53 1.1.1.2 christos documentation. Please look at the "pod" files in doc/man[1357] for 54 1.1.1.2 christos examples of our style. Run "make doc-nits" to make sure that your 55 1.1.1.2 christos documentation changes are clean. 56 1.1.1.2 christos 57 1.1.1.2 christos 7. For user visible changes (API changes, behaviour changes, ...), 58 1.1.1.2 christos consider adding a note in CHANGES. This could be a summarising 59 1.1.1.2 christos description of the change, and could explain the grander details. 60 1.1.1.2 christos Have a look through existing entries for inspiration. 61 1.1.1.2 christos Please note that this is NOT simply a copy of git-log one-liners. 62 1.1.1.2 christos Also note that security fixes get an entry in CHANGES. 63 1.1.1.2 christos This file helps users get more in depth information of what comes 64 1.1.1.2 christos with a specific release without having to sift through the higher 65 1.1.1.2 christos noise ratio in git-log. 66 1.1.1.2 christos 67 1.1.1.2 christos 8. For larger or more important user visible changes, as well as 68 1.1.1.2 christos security fixes, please add a line in NEWS. On exception, it might be 69 1.1.1.2 christos worth adding a multi-line entry (such as the entry that announces all 70 1.1.1.2 christos the types that became opaque with OpenSSL 1.1.0). 71 1.1.1.2 christos This file helps users get a very quick summary of what comes with a 72 1.1.1.2 christos specific release, to see if an upgrade is worth the effort. 73