1 1.1 christos HOW TO CONTRIBUTE PATCHES TO OpenSSL 2 1.1 christos ------------------------------------ 3 1.1 christos 4 1.1 christos (Please visit https://www.openssl.org/community/getting-started.html for 5 1.1 christos other ideas about how to contribute.) 6 1.1 christos 7 1.1 christos Development is coordinated on the openssl-dev mailing list (see the 8 1.1 christos above link or https://mta.openssl.org for information on subscribing). 9 1.1 christos If you are unsure as to whether a feature will be useful for the general 10 1.1 christos OpenSSL community you might want to discuss it on the openssl-dev mailing 11 1.1 christos list first. Someone may be already working on the same thing or there 12 1.1 christos may be a good reason as to why that feature isn't implemented. 13 1.1 christos 14 1.1 christos To submit a patch, make a pull request on GitHub. If you think the patch 15 1.1 christos could use feedback from the community, please start a thread on openssl-dev 16 1.1 christos to discuss it. 17 1.1 christos 18 1.1 christos Having addressed the following items before the PR will help make the 19 1.1 christos acceptance and review process faster: 20 1.1 christos 21 1.1 christos 1. Anything other than trivial contributions will require a contributor 22 1.1 christos licensing agreement, giving us permission to use your code. See 23 1.1 christos https://www.openssl.org/policies/cla.html for details. 24 1.1 christos 25 1.1 christos 2. All source files should start with the following text (with 26 1.1 christos appropriate comment characters at the start of each line and the 27 1.1 christos year(s) updated): 28 1.1 christos 29 1.1 christos Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved. 30 1.1 christos 31 1.1 christos Licensed under the OpenSSL license (the "License"). You may not use 32 1.1 christos this file except in compliance with the License. You can obtain a copy 33 1.1 christos in the file LICENSE in the source distribution or at 34 1.1 christos https://www.openssl.org/source/license.html 35 1.1 christos 36 1.1 christos 3. Patches should be as current as possible; expect to have to rebase 37 1.1 christos often. We do not accept merge commits; You will be asked to remove 38 1.1 christos them before a patch is considered acceptable. 39 1.1 christos 40 1.1 christos 4. Patches should follow our coding style (see 41 1.1 christos https://www.openssl.org/policies/codingstyle.html) and compile without 42 1.1 christos warnings. Where gcc or clang is availble you should use the 43 1.1 christos --strict-warnings Configure option. OpenSSL compiles on many varied 44 1.1 christos platforms: try to ensure you only use portable features. 45 1.1 christos Clean builds via Travis and AppVeyor are expected, and done whenever 46 1.1 christos a PR is created or updated. 47 1.1 christos 48 1.1 christos 5. When at all possible, patches should include tests. These can 49 1.1 christos either be added to an existing test, or completely new. Please see 50 1.1 christos test/README for information on the test framework. 51 1.1 christos 52 1.1 christos 6. New features or changed functionality must include 53 1.1 christos documentation. Please look at the "pod" files in doc/apps, doc/crypto 54 1.1 christos and doc/ssl for examples of our style. 55