packetProcessing.c revision 1.1.1.4 1 1.1 christos #include "config.h"
2 1.1 christos #include "sntptest.h"
3 1.1 christos #include "networking.h"
4 1.1 christos #include "ntp_stdlib.h"
5 1.1 christos #include "unity.h"
6 1.1 christos
7 1.1.1.3 christos
8 1.1 christos const char * Version = "stub unit test Version string";
9 1.1 christos
10 1.1 christos // Hacks into the key database.
11 1.1 christos extern struct key* key_ptr;
12 1.1 christos extern int key_cnt;
13 1.1 christos
14 1.1 christos
15 1.1.1.3 christos void PrepareAuthenticationTest(int key_id,int key_len,const char* type,const void* key_seq);
16 1.1.1.3 christos void PrepareAuthenticationTestMD5(int key_id,int key_len,const void* key_seq);
17 1.1.1.3 christos void setUp(void);
18 1.1.1.3 christos void tearDown(void);
19 1.1.1.3 christos void test_TooShortLength(void);
20 1.1.1.3 christos void test_LengthNotMultipleOfFour(void);
21 1.1.1.3 christos void test_TooShortExtensionFieldLength(void);
22 1.1.1.3 christos void test_UnauthenticatedPacketReject(void);
23 1.1.1.3 christos void test_CryptoNAKPacketReject(void);
24 1.1.1.3 christos void test_AuthenticatedPacketInvalid(void);
25 1.1.1.3 christos void test_AuthenticatedPacketUnknownKey(void);
26 1.1.1.3 christos void test_ServerVersionTooOld(void);
27 1.1.1.3 christos void test_ServerVersionTooNew(void);
28 1.1.1.3 christos void test_NonWantedMode(void);
29 1.1.1.3 christos void test_KoDRate(void);
30 1.1.1.3 christos void test_KoDDeny(void);
31 1.1.1.3 christos void test_RejectUnsyncedServer(void);
32 1.1.1.3 christos void test_RejectWrongResponseServerMode(void);
33 1.1.1.3 christos void test_AcceptNoSentPacketBroadcastMode(void);
34 1.1.1.3 christos void test_CorrectUnauthenticatedPacket(void);
35 1.1.1.3 christos void test_CorrectAuthenticatedPacketMD5(void);
36 1.1.1.3 christos void test_CorrectAuthenticatedPacketSHA1(void);
37 1.1.1.3 christos
38 1.1.1.3 christos
39 1.1 christos static struct pkt testpkt;
40 1.1 christos static struct pkt testspkt;
41 1.1 christos static sockaddr_u testsock;
42 1.1 christos bool restoreKeyDb;
43 1.1 christos
44 1.1.1.3 christos
45 1.1.1.3 christos void
46 1.1.1.3 christos PrepareAuthenticationTest(int key_id,
47 1.1 christos int key_len,
48 1.1 christos const char* type,
49 1.1 christos const void* key_seq) {
50 1.1 christos char str[25];
51 1.1.1.3 christos snprintf(str, 25, "%d", key_id);
52 1.1 christos ActivateOption("-a", str);
53 1.1 christos
54 1.1 christos key_cnt = 1;
55 1.1.1.3 christos key_ptr = emalloc(sizeof(struct key));
56 1.1 christos key_ptr->next = NULL;
57 1.1 christos key_ptr->key_id = key_id;
58 1.1 christos key_ptr->key_len = key_len;
59 1.1 christos memcpy(key_ptr->type, "MD5", 3);
60 1.1 christos
61 1.1 christos TEST_ASSERT_TRUE(key_len < sizeof(key_ptr->key_seq));
62 1.1 christos
63 1.1 christos memcpy(key_ptr->key_seq, key_seq, key_ptr->key_len);
64 1.1 christos restoreKeyDb = true;
65 1.1 christos }
66 1.1 christos
67 1.1.1.3 christos
68 1.1.1.3 christos void
69 1.1.1.3 christos PrepareAuthenticationTestMD5(int key_id,
70 1.1 christos int key_len,
71 1.1 christos const void* key_seq) {
72 1.1 christos PrepareAuthenticationTest(key_id, key_len, "MD5", key_seq);
73 1.1 christos }
74 1.1 christos
75 1.1.1.3 christos
76 1.1.1.3 christos void
77 1.1.1.3 christos setUp(void) {
78 1.1 christos
79 1.1 christos sntptest();
80 1.1 christos restoreKeyDb = false;
81 1.1 christos
82 1.1 christos /* Initialize the test packet and socket,
83 1.1 christos * so they contain at least some valid data. */
84 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING, NTP_VERSION,
85 1.1 christos MODE_SERVER);
86 1.1 christos testpkt.stratum = STRATUM_REFCLOCK;
87 1.1 christos memcpy(&testpkt.refid, "GPS\0", 4);
88 1.1 christos
89 1.1 christos /* Set the origin timestamp of the received packet to the
90 1.1 christos * same value as the transmit timestamp of the sent packet. */
91 1.1 christos l_fp tmp;
92 1.1 christos tmp.l_ui = 1000UL;
93 1.1 christos tmp.l_uf = 0UL;
94 1.1 christos
95 1.1 christos HTONL_FP(&tmp, &testpkt.org);
96 1.1 christos HTONL_FP(&tmp, &testspkt.xmt);
97 1.1 christos }
98 1.1 christos
99 1.1.1.3 christos
100 1.1.1.3 christos void
101 1.1.1.3 christos tearDown(void) {
102 1.1 christos
103 1.1 christos if (restoreKeyDb) {
104 1.1 christos key_cnt = 0;
105 1.1 christos free(key_ptr);
106 1.1 christos key_ptr = NULL;
107 1.1 christos }
108 1.1 christos
109 1.1 christos sntptest_destroy(); //only on the final test!! if counter == 0 etc...
110 1.1 christos }
111 1.1 christos
112 1.1 christos
113 1.1 christos
114 1.1.1.3 christos void
115 1.1.1.3 christos test_TooShortLength(void) {
116 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
117 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC - 1,
118 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
119 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
120 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC - 1,
121 1.1 christos MODE_BROADCAST, &testspkt, "UnitTest"));
122 1.1 christos }
123 1.1 christos
124 1.1.1.3 christos
125 1.1.1.3 christos void
126 1.1.1.3 christos test_LengthNotMultipleOfFour(void) {
127 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
128 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC + 6,
129 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
130 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
131 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC + 3,
132 1.1 christos MODE_BROADCAST, &testspkt, "UnitTest"));
133 1.1 christos }
134 1.1 christos
135 1.1.1.3 christos
136 1.1.1.3 christos void
137 1.1.1.3 christos test_TooShortExtensionFieldLength(void) {
138 1.1 christos /* The lower 16-bits are the length of the extension field.
139 1.1 christos * This lengths must be multiples of 4 bytes, which gives
140 1.1 christos * a minimum of 4 byte extension field length. */
141 1.1 christos testpkt.exten[7] = htonl(3); // 3 bytes is too short.
142 1.1 christos
143 1.1 christos /* We send in a pkt_len of header size + 4 byte extension
144 1.1 christos * header + 24 byte MAC, this prevents the length error to
145 1.1 christos * be caught at an earlier stage */
146 1.1 christos int pkt_len = LEN_PKT_NOMAC + 4 + 24;
147 1.1 christos
148 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
149 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
150 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
151 1.1 christos }
152 1.1 christos
153 1.1.1.3 christos
154 1.1.1.3 christos void
155 1.1.1.3 christos test_UnauthenticatedPacketReject(void) {
156 1.1 christos //sntptest();
157 1.1 christos // Activate authentication option
158 1.1 christos ActivateOption("-a", "123");
159 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
160 1.1 christos
161 1.1 christos int pkt_len = LEN_PKT_NOMAC;
162 1.1 christos
163 1.1 christos // We demand authentication, but no MAC header is present.
164 1.1 christos TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
165 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
166 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
167 1.1 christos }
168 1.1 christos
169 1.1.1.3 christos
170 1.1.1.3 christos void
171 1.1.1.3 christos test_CryptoNAKPacketReject(void) {
172 1.1 christos // Activate authentication option
173 1.1 christos ActivateOption("-a", "123");
174 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
175 1.1 christos
176 1.1 christos int pkt_len = LEN_PKT_NOMAC + 4; // + 4 byte MAC = Crypto-NAK
177 1.1 christos
178 1.1 christos TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
179 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
180 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
181 1.1 christos }
182 1.1 christos
183 1.1.1.3 christos
184 1.1.1.3 christos void
185 1.1.1.3 christos test_AuthenticatedPacketInvalid(void) {
186 1.1 christos // Activate authentication option
187 1.1 christos PrepareAuthenticationTestMD5(50, 9, "123456789");
188 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
189 1.1 christos
190 1.1 christos // Prepare the packet.
191 1.1 christos int pkt_len = LEN_PKT_NOMAC;
192 1.1 christos
193 1.1 christos testpkt.exten[0] = htonl(50);
194 1.1 christos int mac_len = make_mac((char*)&testpkt, pkt_len,
195 1.1 christos MAX_MD5_LEN, key_ptr,
196 1.1 christos (char*)&testpkt.exten[1]);
197 1.1 christos
198 1.1 christos pkt_len += 4 + mac_len;
199 1.1 christos
200 1.1 christos // Now, alter the MAC so it becomes invalid.
201 1.1 christos testpkt.exten[1] += 1;
202 1.1 christos
203 1.1 christos TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
204 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
205 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
206 1.1 christos }
207 1.1 christos
208 1.1.1.3 christos
209 1.1.1.3 christos void
210 1.1.1.3 christos test_AuthenticatedPacketUnknownKey(void) {
211 1.1 christos // Activate authentication option
212 1.1 christos PrepareAuthenticationTestMD5(30, 9, "123456789");
213 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
214 1.1 christos
215 1.1 christos // Prepare the packet. Observe that the Key-ID expected is 30,
216 1.1 christos // but the packet has a key id of 50.
217 1.1 christos int pkt_len = LEN_PKT_NOMAC;
218 1.1 christos
219 1.1 christos testpkt.exten[0] = htonl(50);
220 1.1 christos int mac_len = make_mac((char*)&testpkt, pkt_len,
221 1.1 christos MAX_MD5_LEN, key_ptr,
222 1.1 christos (char*)&testpkt.exten[1]);
223 1.1 christos pkt_len += 4 + mac_len;
224 1.1 christos
225 1.1 christos TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
226 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
227 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
228 1.1 christos }
229 1.1 christos
230 1.1.1.3 christos
231 1.1.1.3 christos void
232 1.1.1.3 christos test_ServerVersionTooOld(void) {
233 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
234 1.1 christos
235 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
236 1.1 christos NTP_OLDVERSION - 1,
237 1.1 christos MODE_CLIENT);
238 1.1 christos TEST_ASSERT_TRUE(PKT_VERSION(testpkt.li_vn_mode) < NTP_OLDVERSION);
239 1.1 christos
240 1.1 christos int pkt_len = LEN_PKT_NOMAC;
241 1.1 christos
242 1.1 christos TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
243 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
244 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
245 1.1 christos }
246 1.1 christos
247 1.1.1.3 christos
248 1.1.1.3 christos void
249 1.1.1.3 christos test_ServerVersionTooNew(void) {
250 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
251 1.1 christos
252 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
253 1.1 christos NTP_VERSION + 1,
254 1.1 christos MODE_CLIENT);
255 1.1 christos TEST_ASSERT_TRUE(PKT_VERSION(testpkt.li_vn_mode) > NTP_VERSION);
256 1.1 christos
257 1.1 christos int pkt_len = LEN_PKT_NOMAC;
258 1.1 christos
259 1.1 christos TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
260 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
261 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
262 1.1 christos }
263 1.1 christos
264 1.1.1.3 christos
265 1.1.1.3 christos void
266 1.1.1.3 christos test_NonWantedMode(void) {
267 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
268 1.1 christos
269 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
270 1.1 christos NTP_VERSION,
271 1.1 christos MODE_CLIENT);
272 1.1 christos
273 1.1 christos // The packet has a mode of MODE_CLIENT, but process_pkt expects MODE_SERVER
274 1.1 christos
275 1.1 christos TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
276 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
277 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
278 1.1 christos }
279 1.1 christos
280 1.1.1.3 christos
281 1.1 christos /* Tests bug 1597 */
282 1.1.1.3 christos void
283 1.1.1.3 christos test_KoDRate(void) {
284 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
285 1.1 christos
286 1.1 christos testpkt.stratum = STRATUM_PKT_UNSPEC;
287 1.1 christos memcpy(&testpkt.refid, "RATE", 4);
288 1.1 christos
289 1.1 christos TEST_ASSERT_EQUAL(KOD_RATE,
290 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
291 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
292 1.1 christos }
293 1.1 christos
294 1.1.1.3 christos
295 1.1.1.3 christos void
296 1.1.1.3 christos test_KoDDeny(void) {
297 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
298 1.1 christos
299 1.1 christos testpkt.stratum = STRATUM_PKT_UNSPEC;
300 1.1 christos memcpy(&testpkt.refid, "DENY", 4);
301 1.1 christos
302 1.1 christos TEST_ASSERT_EQUAL(KOD_DEMOBILIZE,
303 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
304 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
305 1.1 christos }
306 1.1 christos
307 1.1.1.3 christos
308 1.1.1.3 christos void
309 1.1.1.3 christos test_RejectUnsyncedServer(void) {
310 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
311 1.1 christos
312 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOTINSYNC,
313 1.1 christos NTP_VERSION,
314 1.1 christos MODE_SERVER);
315 1.1 christos
316 1.1 christos TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
317 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
318 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
319 1.1 christos }
320 1.1 christos
321 1.1.1.3 christos
322 1.1.1.3 christos void
323 1.1.1.3 christos test_RejectWrongResponseServerMode(void) {
324 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
325 1.1 christos
326 1.1 christos l_fp tmp;
327 1.1 christos tmp.l_ui = 1000UL;
328 1.1 christos tmp.l_uf = 0UL;
329 1.1 christos HTONL_FP(&tmp, &testpkt.org);
330 1.1 christos
331 1.1 christos tmp.l_ui = 2000UL;
332 1.1 christos tmp.l_uf = 0UL;
333 1.1 christos HTONL_FP(&tmp, &testspkt.xmt);
334 1.1 christos
335 1.1 christos TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
336 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
337 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
338 1.1 christos }
339 1.1 christos
340 1.1.1.3 christos
341 1.1.1.3 christos void
342 1.1.1.3 christos test_AcceptNoSentPacketBroadcastMode(void) {
343 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
344 1.1 christos
345 1.1 christos testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
346 1.1 christos NTP_VERSION,
347 1.1 christos MODE_BROADCAST);
348 1.1 christos
349 1.1 christos TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
350 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
351 1.1 christos MODE_BROADCAST, NULL, "UnitTest"));
352 1.1 christos }
353 1.1 christos
354 1.1.1.3 christos
355 1.1.1.3 christos void
356 1.1.1.3 christos test_CorrectUnauthenticatedPacket(void) {
357 1.1 christos TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
358 1.1 christos
359 1.1 christos TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
360 1.1 christos process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
361 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
362 1.1 christos }
363 1.1 christos
364 1.1.1.3 christos
365 1.1.1.3 christos void
366 1.1.1.3 christos test_CorrectAuthenticatedPacketMD5(void) {
367 1.1 christos PrepareAuthenticationTestMD5(10, 15, "123456789abcdef");
368 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
369 1.1 christos
370 1.1 christos int pkt_len = LEN_PKT_NOMAC;
371 1.1 christos
372 1.1 christos // Prepare the packet.
373 1.1 christos testpkt.exten[0] = htonl(10);
374 1.1 christos int mac_len = make_mac((char*)&testpkt, pkt_len,
375 1.1 christos MAX_MD5_LEN, key_ptr,
376 1.1 christos (char*)&testpkt.exten[1]);
377 1.1 christos
378 1.1 christos pkt_len += 4 + mac_len;
379 1.1 christos
380 1.1 christos TEST_ASSERT_EQUAL(pkt_len,
381 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
382 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
383 1.1 christos
384 1.1 christos }
385 1.1 christos
386 1.1.1.3 christos
387 1.1.1.3 christos void
388 1.1.1.3 christos test_CorrectAuthenticatedPacketSHA1(void) {
389 1.1 christos PrepareAuthenticationTest(20, 15, "SHA1", "abcdefghijklmno");
390 1.1 christos TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
391 1.1 christos
392 1.1 christos int pkt_len = LEN_PKT_NOMAC;
393 1.1 christos
394 1.1 christos // Prepare the packet.
395 1.1 christos testpkt.exten[0] = htonl(20);
396 1.1 christos int mac_len = make_mac((char*)&testpkt, pkt_len,
397 1.1 christos MAX_MAC_LEN, key_ptr,
398 1.1 christos (char*)&testpkt.exten[1]);
399 1.1 christos
400 1.1 christos pkt_len += 4 + mac_len;
401 1.1 christos
402 1.1 christos TEST_ASSERT_EQUAL(pkt_len,
403 1.1 christos process_pkt(&testpkt, &testsock, pkt_len,
404 1.1 christos MODE_SERVER, &testspkt, "UnitTest"));
405 1.1 christos }
406