OpenGrok

1.1  mrg In general, merging process should not be very difficult, but we need to
1.1  mrg track various ABI changes and GCC-specific patches carefully.  Here is a
1.1  mrg general list of actions required to perform the merge:
1.1  mrg
1.1  mrg * Checkout recent GCC tree.
1.4  mrg * Run merge.sh script from libsanitizer directory.  The script accepts one
1.4  mrg   argument that is control version system (svn or git).
1.1  mrg * Modify Makefile.am files into asan/tsan/lsan/ubsan/sanitizer_common/interception
1.1  mrg   directories if needed.  In particular, you may need to add new source files
1.1  mrg   and remove old ones in source files list, add new flags to {C, CXX}FLAGS if
1.1  mrg   needed and update DEFS with new defined variables.  You can find these changes
1.1  mrg   in corresponding CMakeLists.txt and config-ix.cmake files from compiler-rt source
1.1  mrg   directory.
1.1  mrg * Apply all needed GCC-specific patches to libsanitizer (note that some of
1.3  mrg   them might be already included to upstream).  The list of these patches is stored
1.3  mrg   into LOCAL_PATCHES file.
1.1  mrg * Apply all necessary compiler changes.  Be especially careful here, you must
1.1  mrg   not break ABI between compiler and library.  You can reveal these changes by
1.1  mrg   inspecting the history of AddressSanitizer.cpp and ThreadSanitizer.cpp files
1.1  mrg   from LLVM source tree.
1.1  mrg * Update ASan testsuite with corresponding tests from lib/asan/tests directory.
1.1  mrg   Not all tests can be migrated easily, so you don't need them all to be adapted.
1.1  mrg * Modify configure.ac file if needed (e.g. if you need to add link against new
1.4  mrg   library for sanitizer libs).
1.1  mrg * Add new target platforms in configure.tgt script if needed.
1.1  mrg * Bump SONAME for sanitizer libraries in asan/tsan/ubsan libtool-version files
1.1  mrg   if ABI has changed.
1.1  mrg * Regenerate configure script and all Makefiles by autoreconf.  You should use
1.1  mrg   exactly the same autoconf and automake versions as for other GCC directories (current
1.1  mrg   versions are written in Makefile.in and configure files).
1.1  mrg * Run regression testing on at least three platforms (e.g. x86-linux-gnu, x86_64-linux-gnu,
1.1  mrg   aarch64-linux-gnu, arm-linux-gnueabi).
1.1  mrg * Run {A, UB}San bootstrap on at least three platforms.
1.4  mrg * Compare ABI of corresponding libclang_rt.asan and newly build libasan libraries.
1.4  mrg   Similarly you can compare latest GCC release with the newly built libraries
1.4  mrg   (libasan.so.*, libubsan.so.*, libtsan.so*).
1.1  mrg   You can use a pretty good libabigail tool (https://sourceware.org/libabigail/index.html)
1.1  mrg   to perform such a comparision.  Note, that the list of exported symbols may differ,
1.1  mrg   e.g. because libasan currently does not include UBSan runtime.
1.1  mrg * Split your changes into logical parts (e.g. raw merge, compiler changes, GCC-specific changes
1.1  mrg   in libasan, configure/Makefile changes). The review process has O(N^2) complexity, so you
1.1  mrg   would simplify and probably speed up the review process by doing this.
1.1  mrg * Send your patches for review to GCC Patches Mailing List (gcc-patches (a] gcc.gnu.org).
1.3  mrg * Update LOCAL_PATCHES file when you've committed the whole patch set with new revisions numbers.