Home | History | Annotate | Line # | Download | only in asan
asan_thread.cpp revision 1.3
      1 //===-- asan_thread.cpp ---------------------------------------------------===//
      2 //
      3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
      4 // See https://llvm.org/LICENSE.txt for license information.
      5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
      6 //
      7 //===----------------------------------------------------------------------===//
      8 //
      9 // This file is a part of AddressSanitizer, an address sanity checker.
     10 //
     11 // Thread-related code.
     12 //===----------------------------------------------------------------------===//
     13 #include "asan_allocator.h"
     14 #include "asan_interceptors.h"
     15 #include "asan_poisoning.h"
     16 #include "asan_stack.h"
     17 #include "asan_thread.h"
     18 #include "asan_mapping.h"
     19 #include "sanitizer_common/sanitizer_common.h"
     20 #include "sanitizer_common/sanitizer_placement_new.h"
     21 #include "sanitizer_common/sanitizer_stackdepot.h"
     22 #include "sanitizer_common/sanitizer_tls_get_addr.h"
     23 #include "lsan/lsan_common.h"
     24 
     25 namespace __asan {
     26 
     27 // AsanThreadContext implementation.
     28 
     29 void AsanThreadContext::OnCreated(void *arg) {
     30   CreateThreadContextArgs *args = static_cast<CreateThreadContextArgs*>(arg);
     31   if (args->stack)
     32     stack_id = StackDepotPut(*args->stack);
     33   thread = args->thread;
     34   thread->set_context(this);
     35 }
     36 
     37 void AsanThreadContext::OnFinished() {
     38   // Drop the link to the AsanThread object.
     39   thread = nullptr;
     40 }
     41 
     42 // MIPS requires aligned address
     43 static ALIGNED(16) char thread_registry_placeholder[sizeof(ThreadRegistry)];
     44 static ThreadRegistry *asan_thread_registry;
     45 
     46 static Mutex mu_for_thread_context;
     47 static LowLevelAllocator allocator_for_thread_context;
     48 
     49 static ThreadContextBase *GetAsanThreadContext(u32 tid) {
     50   Lock lock(&mu_for_thread_context);
     51   return new(allocator_for_thread_context) AsanThreadContext(tid);
     52 }
     53 
     54 ThreadRegistry &asanThreadRegistry() {
     55   static bool initialized;
     56   // Don't worry about thread_safety - this should be called when there is
     57   // a single thread.
     58   if (!initialized) {
     59     // Never reuse ASan threads: we store pointer to AsanThreadContext
     60     // in TSD and can't reliably tell when no more TSD destructors will
     61     // be called. It would be wrong to reuse AsanThreadContext for another
     62     // thread before all TSD destructors will be called for it.
     63     asan_thread_registry =
     64         new (thread_registry_placeholder) ThreadRegistry(GetAsanThreadContext);
     65     initialized = true;
     66   }
     67   return *asan_thread_registry;
     68 }
     69 
     70 AsanThreadContext *GetThreadContextByTidLocked(u32 tid) {
     71   return static_cast<AsanThreadContext *>(
     72       asanThreadRegistry().GetThreadLocked(tid));
     73 }
     74 
     75 // AsanThread implementation.
     76 
     77 AsanThread *AsanThread::Create(thread_callback_t start_routine, void *arg,
     78                                u32 parent_tid, StackTrace *stack,
     79                                bool detached) {
     80   uptr PageSize = GetPageSizeCached();
     81   uptr size = RoundUpTo(sizeof(AsanThread), PageSize);
     82   AsanThread *thread = (AsanThread*)MmapOrDie(size, __func__);
     83   thread->start_routine_ = start_routine;
     84   thread->arg_ = arg;
     85   AsanThreadContext::CreateThreadContextArgs args = {thread, stack};
     86   asanThreadRegistry().CreateThread(*reinterpret_cast<uptr *>(thread), detached,
     87                                     parent_tid, &args);
     88 
     89   return thread;
     90 }
     91 
     92 void AsanThread::TSDDtor(void *tsd) {
     93   AsanThreadContext *context = (AsanThreadContext*)tsd;
     94   VReport(1, "T%d TSDDtor\n", context->tid);
     95   if (context->thread)
     96     context->thread->Destroy();
     97 }
     98 
     99 void AsanThread::Destroy() {
    100   int tid = this->tid();
    101   VReport(1, "T%d exited\n", tid);
    102 
    103   bool was_running =
    104       (asanThreadRegistry().FinishThread(tid) == ThreadStatusRunning);
    105   if (was_running) {
    106     if (AsanThread *thread = GetCurrentThread())
    107       CHECK_EQ(this, thread);
    108     malloc_storage().CommitBack();
    109     if (common_flags()->use_sigaltstack)
    110       UnsetAlternateSignalStack();
    111     FlushToDeadThreadStats(&stats_);
    112     // We also clear the shadow on thread destruction because
    113     // some code may still be executing in later TSD destructors
    114     // and we don't want it to have any poisoned stack.
    115     ClearShadowForThreadStackAndTLS();
    116     DeleteFakeStack(tid);
    117   } else {
    118     CHECK_NE(this, GetCurrentThread());
    119   }
    120   uptr size = RoundUpTo(sizeof(AsanThread), GetPageSizeCached());
    121   UnmapOrDie(this, size);
    122   if (was_running)
    123     DTLS_Destroy();
    124 }
    125 
    126 void AsanThread::StartSwitchFiber(FakeStack **fake_stack_save, uptr bottom,
    127                                   uptr size) {
    128   if (atomic_load(&stack_switching_, memory_order_relaxed)) {
    129     Report("ERROR: starting fiber switch while in fiber switch\n");
    130     Die();
    131   }
    132 
    133   next_stack_bottom_ = bottom;
    134   next_stack_top_ = bottom + size;
    135   atomic_store(&stack_switching_, 1, memory_order_release);
    136 
    137   FakeStack *current_fake_stack = fake_stack_;
    138   if (fake_stack_save)
    139     *fake_stack_save = fake_stack_;
    140   fake_stack_ = nullptr;
    141   SetTLSFakeStack(nullptr);
    142   // if fake_stack_save is null, the fiber will die, delete the fakestack
    143   if (!fake_stack_save && current_fake_stack)
    144     current_fake_stack->Destroy(this->tid());
    145 }
    146 
    147 void AsanThread::FinishSwitchFiber(FakeStack *fake_stack_save,
    148                                    uptr *bottom_old,
    149                                    uptr *size_old) {
    150   if (!atomic_load(&stack_switching_, memory_order_relaxed)) {
    151     Report("ERROR: finishing a fiber switch that has not started\n");
    152     Die();
    153   }
    154 
    155   if (fake_stack_save) {
    156     SetTLSFakeStack(fake_stack_save);
    157     fake_stack_ = fake_stack_save;
    158   }
    159 
    160   if (bottom_old)
    161     *bottom_old = stack_bottom_;
    162   if (size_old)
    163     *size_old = stack_top_ - stack_bottom_;
    164   stack_bottom_ = next_stack_bottom_;
    165   stack_top_ = next_stack_top_;
    166   atomic_store(&stack_switching_, 0, memory_order_release);
    167   next_stack_top_ = 0;
    168   next_stack_bottom_ = 0;
    169 }
    170 
    171 inline AsanThread::StackBounds AsanThread::GetStackBounds() const {
    172   if (!atomic_load(&stack_switching_, memory_order_acquire)) {
    173     // Make sure the stack bounds are fully initialized.
    174     if (stack_bottom_ >= stack_top_) return {0, 0};
    175     return {stack_bottom_, stack_top_};
    176   }
    177   char local;
    178   const uptr cur_stack = (uptr)&local;
    179   // Note: need to check next stack first, because FinishSwitchFiber
    180   // may be in process of overwriting stack_top_/bottom_. But in such case
    181   // we are already on the next stack.
    182   if (cur_stack >= next_stack_bottom_ && cur_stack < next_stack_top_)
    183     return {next_stack_bottom_, next_stack_top_};
    184   return {stack_bottom_, stack_top_};
    185 }
    186 
    187 uptr AsanThread::stack_top() {
    188   return GetStackBounds().top;
    189 }
    190 
    191 uptr AsanThread::stack_bottom() {
    192   return GetStackBounds().bottom;
    193 }
    194 
    195 uptr AsanThread::stack_size() {
    196   const auto bounds = GetStackBounds();
    197   return bounds.top - bounds.bottom;
    198 }
    199 
    200 // We want to create the FakeStack lazily on the first use, but not earlier
    201 // than the stack size is known and the procedure has to be async-signal safe.
    202 FakeStack *AsanThread::AsyncSignalSafeLazyInitFakeStack() {
    203   uptr stack_size = this->stack_size();
    204   if (stack_size == 0)  // stack_size is not yet available, don't use FakeStack.
    205     return nullptr;
    206   uptr old_val = 0;
    207   // fake_stack_ has 3 states:
    208   // 0   -- not initialized
    209   // 1   -- being initialized
    210   // ptr -- initialized
    211   // This CAS checks if the state was 0 and if so changes it to state 1,
    212   // if that was successful, it initializes the pointer.
    213   if (atomic_compare_exchange_strong(
    214       reinterpret_cast<atomic_uintptr_t *>(&fake_stack_), &old_val, 1UL,
    215       memory_order_relaxed)) {
    216     uptr stack_size_log = Log2(RoundUpToPowerOfTwo(stack_size));
    217     CHECK_LE(flags()->min_uar_stack_size_log, flags()->max_uar_stack_size_log);
    218     stack_size_log =
    219         Min(stack_size_log, static_cast<uptr>(flags()->max_uar_stack_size_log));
    220     stack_size_log =
    221         Max(stack_size_log, static_cast<uptr>(flags()->min_uar_stack_size_log));
    222     fake_stack_ = FakeStack::Create(stack_size_log);
    223     DCHECK_EQ(GetCurrentThread(), this);
    224     SetTLSFakeStack(fake_stack_);
    225     return fake_stack_;
    226   }
    227   return nullptr;
    228 }
    229 
    230 void AsanThread::Init(const InitOptions *options) {
    231   DCHECK_NE(tid(), kInvalidTid);
    232   next_stack_top_ = next_stack_bottom_ = 0;
    233   atomic_store(&stack_switching_, false, memory_order_release);
    234   CHECK_EQ(this->stack_size(), 0U);
    235   SetThreadStackAndTls(options);
    236   if (stack_top_ != stack_bottom_) {
    237     CHECK_GT(this->stack_size(), 0U);
    238     CHECK(AddrIsInMem(stack_bottom_));
    239     CHECK(AddrIsInMem(stack_top_ - 1));
    240   }
    241   ClearShadowForThreadStackAndTLS();
    242   fake_stack_ = nullptr;
    243   if (__asan_option_detect_stack_use_after_return &&
    244       tid() == GetCurrentTidOrInvalid()) {
    245     // AsyncSignalSafeLazyInitFakeStack makes use of threadlocals and must be
    246     // called from the context of the thread it is initializing, not its parent.
    247     // Most platforms call AsanThread::Init on the newly-spawned thread, but
    248     // Fuchsia calls this function from the parent thread.  To support that
    249     // approach, we avoid calling AsyncSignalSafeLazyInitFakeStack here; it will
    250     // be called by the new thread when it first attempts to access the fake
    251     // stack.
    252     AsyncSignalSafeLazyInitFakeStack();
    253   }
    254   int local = 0;
    255   VReport(1, "T%d: stack [%p,%p) size 0x%zx; local=%p\n", tid(),
    256           (void *)stack_bottom_, (void *)stack_top_, stack_top_ - stack_bottom_,
    257           (void *)&local);
    258 }
    259 
    260 // Fuchsia doesn't use ThreadStart.
    261 // asan_fuchsia.c definies CreateMainThread and SetThreadStackAndTls.
    262 #if !SANITIZER_FUCHSIA
    263 
    264 thread_return_t AsanThread::ThreadStart(tid_t os_id) {
    265   Init();
    266   asanThreadRegistry().StartThread(tid(), os_id, ThreadType::Regular, nullptr);
    267 
    268   if (common_flags()->use_sigaltstack) SetAlternateSignalStack();
    269 
    270   if (!start_routine_) {
    271     // start_routine_ == 0 if we're on the main thread or on one of the
    272     // OS X libdispatch worker threads. But nobody is supposed to call
    273     // ThreadStart() for the worker threads.
    274     CHECK_EQ(tid(), 0);
    275     return 0;
    276   }
    277 
    278   thread_return_t res = start_routine_(arg_);
    279 
    280   // On POSIX systems we defer this to the TSD destructor. LSan will consider
    281   // the thread's memory as non-live from the moment we call Destroy(), even
    282   // though that memory might contain pointers to heap objects which will be
    283   // cleaned up by a user-defined TSD destructor. Thus, calling Destroy() before
    284   // the TSD destructors have run might cause false positives in LSan.
    285   if (!SANITIZER_POSIX)
    286     this->Destroy();
    287 
    288   return res;
    289 }
    290 
    291 AsanThread *CreateMainThread() {
    292   AsanThread *main_thread = AsanThread::Create(
    293       /* start_routine */ nullptr, /* arg */ nullptr, /* parent_tid */ kMainTid,
    294       /* stack */ nullptr, /* detached */ true);
    295   SetCurrentThread(main_thread);
    296   main_thread->ThreadStart(internal_getpid());
    297   return main_thread;
    298 }
    299 
    300 // This implementation doesn't use the argument, which is just passed down
    301 // from the caller of Init (which see, above).  It's only there to support
    302 // OS-specific implementations that need more information passed through.
    303 void AsanThread::SetThreadStackAndTls(const InitOptions *options) {
    304   DCHECK_EQ(options, nullptr);
    305   uptr tls_size = 0;
    306   uptr stack_size = 0;
    307   GetThreadStackAndTls(tid() == kMainTid, &stack_bottom_, &stack_size,
    308                        &tls_begin_, &tls_size);
    309   stack_top_ = RoundDownTo(stack_bottom_ + stack_size, SHADOW_GRANULARITY);
    310   tls_end_ = tls_begin_ + tls_size;
    311   dtls_ = DTLS_Get();
    312 
    313   if (stack_top_ != stack_bottom_) {
    314     int local;
    315     CHECK(AddrIsInStack((uptr)&local));
    316   }
    317 }
    318 
    319 #endif  // !SANITIZER_FUCHSIA
    320 
    321 void AsanThread::ClearShadowForThreadStackAndTLS() {
    322   if (stack_top_ != stack_bottom_)
    323     PoisonShadow(stack_bottom_, stack_top_ - stack_bottom_, 0);
    324   if (tls_begin_ != tls_end_) {
    325     uptr tls_begin_aligned = RoundDownTo(tls_begin_, SHADOW_GRANULARITY);
    326     uptr tls_end_aligned = RoundUpTo(tls_end_, SHADOW_GRANULARITY);
    327     FastPoisonShadowPartialRightRedzone(tls_begin_aligned,
    328                                         tls_end_ - tls_begin_aligned,
    329                                         tls_end_aligned - tls_end_, 0);
    330   }
    331 }
    332 
    333 bool AsanThread::GetStackFrameAccessByAddr(uptr addr,
    334                                            StackFrameAccess *access) {
    335   if (stack_top_ == stack_bottom_)
    336     return false;
    337 
    338   uptr bottom = 0;
    339   if (AddrIsInStack(addr)) {
    340     bottom = stack_bottom();
    341   } else if (FakeStack *fake_stack = get_fake_stack()) {
    342     bottom = fake_stack->AddrIsInFakeStack(addr);
    343     CHECK(bottom);
    344     access->offset = addr - bottom;
    345     access->frame_pc = ((uptr*)bottom)[2];
    346     access->frame_descr = (const char *)((uptr*)bottom)[1];
    347     return true;
    348   }
    349   uptr aligned_addr = RoundDownTo(addr, SANITIZER_WORDSIZE / 8);  // align addr.
    350   uptr mem_ptr = RoundDownTo(aligned_addr, SHADOW_GRANULARITY);
    351   u8 *shadow_ptr = (u8*)MemToShadow(aligned_addr);
    352   u8 *shadow_bottom = (u8*)MemToShadow(bottom);
    353 
    354   while (shadow_ptr >= shadow_bottom &&
    355          *shadow_ptr != kAsanStackLeftRedzoneMagic) {
    356     shadow_ptr--;
    357     mem_ptr -= SHADOW_GRANULARITY;
    358   }
    359 
    360   while (shadow_ptr >= shadow_bottom &&
    361          *shadow_ptr == kAsanStackLeftRedzoneMagic) {
    362     shadow_ptr--;
    363     mem_ptr -= SHADOW_GRANULARITY;
    364   }
    365 
    366   if (shadow_ptr < shadow_bottom) {
    367     return false;
    368   }
    369 
    370   uptr* ptr = (uptr*)(mem_ptr + SHADOW_GRANULARITY);
    371   CHECK(ptr[0] == kCurrentStackFrameMagic);
    372   access->offset = addr - (uptr)ptr;
    373   access->frame_pc = ptr[2];
    374   access->frame_descr = (const char*)ptr[1];
    375   return true;
    376 }
    377 
    378 uptr AsanThread::GetStackVariableShadowStart(uptr addr) {
    379   uptr bottom = 0;
    380   if (AddrIsInStack(addr)) {
    381     bottom = stack_bottom();
    382   } else if (FakeStack *fake_stack = get_fake_stack()) {
    383     bottom = fake_stack->AddrIsInFakeStack(addr);
    384     if (bottom == 0) {
    385       return 0;
    386     }
    387   } else {
    388     return 0;
    389   }
    390 
    391   uptr aligned_addr = RoundDownTo(addr, SANITIZER_WORDSIZE / 8);  // align addr.
    392   u8 *shadow_ptr = (u8*)MemToShadow(aligned_addr);
    393   u8 *shadow_bottom = (u8*)MemToShadow(bottom);
    394 
    395   while (shadow_ptr >= shadow_bottom &&
    396          (*shadow_ptr != kAsanStackLeftRedzoneMagic &&
    397           *shadow_ptr != kAsanStackMidRedzoneMagic &&
    398           *shadow_ptr != kAsanStackRightRedzoneMagic))
    399     shadow_ptr--;
    400 
    401   return (uptr)shadow_ptr + 1;
    402 }
    403 
    404 bool AsanThread::AddrIsInStack(uptr addr) {
    405   const auto bounds = GetStackBounds();
    406   return addr >= bounds.bottom && addr < bounds.top;
    407 }
    408 
    409 static bool ThreadStackContainsAddress(ThreadContextBase *tctx_base,
    410                                        void *addr) {
    411   AsanThreadContext *tctx = static_cast<AsanThreadContext *>(tctx_base);
    412   AsanThread *t = tctx->thread;
    413   if (!t)
    414     return false;
    415   if (t->AddrIsInStack((uptr)addr))
    416     return true;
    417   FakeStack *fake_stack = t->get_fake_stack();
    418   if (!fake_stack)
    419     return false;
    420   return fake_stack->AddrIsInFakeStack((uptr)addr);
    421 }
    422 
    423 AsanThread *GetCurrentThread() {
    424   AsanThreadContext *context =
    425       reinterpret_cast<AsanThreadContext *>(AsanTSDGet());
    426   if (!context) {
    427     if (SANITIZER_ANDROID) {
    428       // On Android, libc constructor is called _after_ asan_init, and cleans up
    429       // TSD. Try to figure out if this is still the main thread by the stack
    430       // address. We are not entirely sure that we have correct main thread
    431       // limits, so only do this magic on Android, and only if the found thread
    432       // is the main thread.
    433       AsanThreadContext *tctx = GetThreadContextByTidLocked(kMainTid);
    434       if (tctx && ThreadStackContainsAddress(tctx, &context)) {
    435         SetCurrentThread(tctx->thread);
    436         return tctx->thread;
    437       }
    438     }
    439     return nullptr;
    440   }
    441   return context->thread;
    442 }
    443 
    444 void SetCurrentThread(AsanThread *t) {
    445   CHECK(t->context());
    446   VReport(2, "SetCurrentThread: %p for thread %p\n", (void *)t->context(),
    447           (void *)GetThreadSelf());
    448   // Make sure we do not reset the current AsanThread.
    449   CHECK_EQ(0, AsanTSDGet());
    450   AsanTSDSet(t->context());
    451   CHECK_EQ(t->context(), AsanTSDGet());
    452 }
    453 
    454 u32 GetCurrentTidOrInvalid() {
    455   AsanThread *t = GetCurrentThread();
    456   return t ? t->tid() : kInvalidTid;
    457 }
    458 
    459 AsanThread *FindThreadByStackAddress(uptr addr) {
    460   asanThreadRegistry().CheckLocked();
    461   AsanThreadContext *tctx = static_cast<AsanThreadContext *>(
    462       asanThreadRegistry().FindThreadContextLocked(ThreadStackContainsAddress,
    463                                                    (void *)addr));
    464   return tctx ? tctx->thread : nullptr;
    465 }
    466 
    467 void EnsureMainThreadIDIsCorrect() {
    468   AsanThreadContext *context =
    469       reinterpret_cast<AsanThreadContext *>(AsanTSDGet());
    470   if (context && (context->tid == kMainTid))
    471     context->os_id = GetTid();
    472 }
    473 
    474 __asan::AsanThread *GetAsanThreadByOsIDLocked(tid_t os_id) {
    475   __asan::AsanThreadContext *context = static_cast<__asan::AsanThreadContext *>(
    476       __asan::asanThreadRegistry().FindThreadContextByOsIDLocked(os_id));
    477   if (!context) return nullptr;
    478   return context->thread;
    479 }
    480 } // namespace __asan
    481 
    482 // --- Implementation of LSan-specific functions --- {{{1
    483 namespace __lsan {
    484 bool GetThreadRangesLocked(tid_t os_id, uptr *stack_begin, uptr *stack_end,
    485                            uptr *tls_begin, uptr *tls_end, uptr *cache_begin,
    486                            uptr *cache_end, DTLS **dtls) {
    487   __asan::AsanThread *t = __asan::GetAsanThreadByOsIDLocked(os_id);
    488   if (!t) return false;
    489   *stack_begin = t->stack_bottom();
    490   *stack_end = t->stack_top();
    491   *tls_begin = t->tls_begin();
    492   *tls_end = t->tls_end();
    493   // ASan doesn't keep allocator caches in TLS, so these are unused.
    494   *cache_begin = 0;
    495   *cache_end = 0;
    496   *dtls = t->dtls();
    497   return true;
    498 }
    499 
    500 void GetAllThreadAllocatorCachesLocked(InternalMmapVector<uptr> *caches) {}
    501 
    502 void ForEachExtraStackRange(tid_t os_id, RangeIteratorCallback callback,
    503                             void *arg) {
    504   __asan::AsanThread *t = __asan::GetAsanThreadByOsIDLocked(os_id);
    505   if (!t)
    506     return;
    507   __asan::FakeStack *fake_stack = t->get_fake_stack();
    508   if (!fake_stack)
    509     return;
    510   fake_stack->ForEachFakeFrame(callback, arg);
    511 }
    512 
    513 void LockThreadRegistry() {
    514   __asan::asanThreadRegistry().Lock();
    515 }
    516 
    517 void UnlockThreadRegistry() {
    518   __asan::asanThreadRegistry().Unlock();
    519 }
    520 
    521 ThreadRegistry *GetThreadRegistryLocked() {
    522   __asan::asanThreadRegistry().CheckLocked();
    523   return &__asan::asanThreadRegistry();
    524 }
    525 
    526 void EnsureMainThreadIDIsCorrect() {
    527   __asan::EnsureMainThreadIDIsCorrect();
    528 }
    529 } // namespace __lsan
    530 
    531 // ---------------------- Interface ---------------- {{{1
    532 using namespace __asan;
    533 
    534 extern "C" {
    535 SANITIZER_INTERFACE_ATTRIBUTE
    536 void __sanitizer_start_switch_fiber(void **fakestacksave, const void *bottom,
    537                                     uptr size) {
    538   AsanThread *t = GetCurrentThread();
    539   if (!t) {
    540     VReport(1, "__asan_start_switch_fiber called from unknown thread\n");
    541     return;
    542   }
    543   t->StartSwitchFiber((FakeStack**)fakestacksave, (uptr)bottom, size);
    544 }
    545 
    546 SANITIZER_INTERFACE_ATTRIBUTE
    547 void __sanitizer_finish_switch_fiber(void* fakestack,
    548                                      const void **bottom_old,
    549                                      uptr *size_old) {
    550   AsanThread *t = GetCurrentThread();
    551   if (!t) {
    552     VReport(1, "__asan_finish_switch_fiber called from unknown thread\n");
    553     return;
    554   }
    555   t->FinishSwitchFiber((FakeStack*)fakestack,
    556                        (uptr*)bottom_old,
    557                        (uptr*)size_old);
    558 }
    559 }
    560