CONTRIBUTING revision 1.3 1 1.1 christos Contributing to the tz code and data
2 1.1 christos
3 1.1 christos The time zone database is by no means authoritative: governments
4 1.1 christos change timekeeping rules erratically and sometimes with little
5 1.1 christos warning, the data entries do not cover all of civil time before
6 1.1 christos 1970, and undoubtedly errors remain in the code and data. Feel
7 1.1 christos free to fill gaps or fix mistakes, and please email improvements
8 1.3 christos to tz (a] iana.org for use in the future. In your email, please give
9 1.3 christos reliable sources that reviewers can check.
10 1.3 christos
11 1.3 christos -----
12 1.3 christos
13 1.3 christos Developers can contribute technical changes to the source code and
14 1.3 christos data as follows.
15 1.1 christos
16 1.1 christos To email small changes, please run a POSIX shell command like
17 1.1 christos 'diff -u old/europe new/europe >myfix.patch', and attach
18 1.1 christos myfix.patch to the email.
19 1.1 christos
20 1.3 christos For more-elaborate changes, please read the theory.html file and browse
21 1.3 christos the mailing list archives <https://mm.icann.org/pipermail/tz/> for
22 1.3 christos examples of patches that tend to work well. Additions to
23 1.1 christos data should contain commentary citing reliable sources as
24 1.3 christos justification. Citations should use https: URLs if available.
25 1.1 christos
26 1.1 christos Please submit changes against either the latest release in
27 1.3 christos <https://www.iana.org/time-zones> or the master branch of the development
28 1.2 christos repository. If you use Git the following workflow may be helpful:
29 1.1 christos
30 1.2 christos * Copy the development repository.
31 1.1 christos
32 1.1 christos git clone https://github.com/eggert/tz.git
33 1.1 christos cd tz
34 1.1 christos
35 1.1 christos * Get current with the master branch.
36 1.1 christos
37 1.1 christos git checkout master
38 1.1 christos git pull
39 1.1 christos
40 1.1 christos * Switch to a new branch for the changes. Choose a different
41 1.1 christos branch name for each change set.
42 1.1 christos
43 1.1 christos git checkout -b mybranch
44 1.1 christos
45 1.1 christos * Edit source files. Include commentary that justifies the
46 1.1 christos changes by citing reliable sources.
47 1.1 christos
48 1.1 christos * Debug the changes, e.g.:
49 1.1 christos
50 1.1 christos make check
51 1.1 christos make install
52 1.1 christos ./zdump -v America/Los_Angeles
53 1.1 christos
54 1.1 christos * For each separable change, commit it in the new branch, e.g.:
55 1.1 christos
56 1.1 christos git add northamerica
57 1.1 christos git commit
58 1.1 christos
59 1.1 christos See recent 'git log' output for the commit-message style.
60 1.1 christos
61 1.1 christos * Create patch files 0001-*, 0002-*, ...
62 1.1 christos
63 1.1 christos git format-patch master
64 1.1 christos
65 1.1 christos * After reviewing the patch files, send the patches to tz (a] iana.org
66 1.1 christos for others to review.
67 1.1 christos
68 1.1 christos git send-email master
69 1.1 christos
70 1.1 christos * Start anew by getting current with the master branch again
71 1.1 christos (the second step above).
72 1.1 christos
73 1.1 christos Please do not create issues or pull requests on GitHub, as the
74 1.1 christos proper procedure for proposing and distributing patches is via
75 1.1 christos email as illustrated above.
76