bsd.lib.mk revision 1.124 1 1.124 jonathan # $NetBSD: bsd.lib.mk,v 1.124 1998/02/18 08:14:31 jonathan Exp $
2 1.92 mikel # @(#)bsd.lib.mk 8.3 (Berkeley) 4/22/94
3 1.1 cgd
4 1.117 mycroft .if !target(__initialized__)
5 1.117 mycroft __initialized__:
6 1.1 cgd .if exists(${.CURDIR}/../Makefile.inc)
7 1.1 cgd .include "${.CURDIR}/../Makefile.inc"
8 1.1 cgd .endif
9 1.97 mycroft .include <bsd.own.mk>
10 1.117 mycroft .include <bsd.obj.mk>
11 1.117 mycroft .MAIN: all
12 1.117 mycroft .endif
13 1.97 mycroft
14 1.96 mycroft .PHONY: cleanlib libinstall
15 1.103 mycroft realinstall: libinstall
16 1.98 mycroft clean cleandir: cleanlib
17 1.1 cgd
18 1.35 pk .if exists(${.CURDIR}/shlib_version)
19 1.37 cgd SHLIB_MAJOR != . ${.CURDIR}/shlib_version ; echo $$major
20 1.37 cgd SHLIB_MINOR != . ${.CURDIR}/shlib_version ; echo $$minor
21 1.35 pk .endif
22 1.1 cgd
23 1.101 mycroft # add additional suffixes not exported.
24 1.101 mycroft # .po is used for profiling object files.
25 1.101 mycroft # .so is used for PIC object files.
26 1.118 lukem .SUFFIXES: .out .a .ln .so .po .o .s .S .c .cc .C .m .F .f .r .y .l .cl .p .h
27 1.118 lukem .SUFFIXES: .sh .m4 .m
28 1.82 mikel
29 1.86 jonathan
30 1.86 jonathan # Set PICFLAGS to cc flags for producing position-independent code,
31 1.86 jonathan # if not already set. Includes -DPIC, if required.
32 1.86 jonathan
33 1.86 jonathan # Data-driven table using make variables to control how shared libraries
34 1.86 jonathan # are built for different platforms and object formats.
35 1.86 jonathan # SHLIB_TYPE: currently either "ELF" or "a.out".
36 1.86 jonathan # SHLIB_SOVERSION: version number to be compiled into a shared library
37 1.86 jonathan # via -soname. Usualy ${SHLIB_MAJOR} on ELF.
38 1.86 jonathan # NetBSD/pmax used to use ${SHLIB_MAJOR}.{SHLIB-MINOR}.
39 1.123 jonathan # SHLIB_SHFLAGS: Flags to tell ${LD} to emit shared library.
40 1.123 jonathan # with ELF, also set shared-lib version for ld.so.
41 1.123 jonathan # SHLIB_LDSTARTFILE: support .o file, call C++ file-level constructors
42 1.123 jonathan # SHLIB_LDENDFILE: support .o file, call C++ file-level destructors
43 1.123 jonathan # SHLIB_WHOLE: turn on whole-archive
44 1.123 jonathan # SHLIB_NOWHOLE: turn off whole-archive
45 1.107 jonathan # CPPICFLAGS: flags for ${CPP} to preprocess .[sS] files for ${AS}
46 1.107 jonathan # CPICFLAGS: flags for ${CC} to compile .[cC] files to .so objects.
47 1.107 jonathan # CAPICFLAGS flags for {$CC} to compiling .[Ss] files
48 1.107 jonathan # (usually just ${CPPPICFLAGS} ${CPICFLAGS})
49 1.107 jonathan # APICFLAGS: flags for ${AS} to assemble .[sS] to .so objects.
50 1.86 jonathan
51 1.86 jonathan .if (${MACHINE_ARCH} == "alpha")
52 1.123 jonathan # Alpha-specific shared library flags
53 1.86 jonathan SHLIB_TYPE=ELF
54 1.115 cjs SHLIB_LDSTARTFILE= ${DESTDIR}/usr/lib/crtbeginS.o
55 1.115 cjs SHLIB_LDENDFILE= ${DESTDIR}/usr/lib/crtendS.o
56 1.123 jonathan
57 1.86 jonathan CPICFLAGS ?= -fpic -DPIC
58 1.107 jonathan CPPPICFLAGS?= -DPIC
59 1.107 jonathan CAPICFLAGS?= ${CPPPICFLAGS} ${CPICFLAGS}
60 1.107 jonathan APICFLAGS ?=
61 1.86 jonathan .elif (${MACHINE_ARCH} == "mips")
62 1.123 jonathan # mips-specific shared library flags
63 1.86 jonathan SHLIB_TYPE=ELF
64 1.123 jonathan # Still use gnu-derived ld.so on pmax; don't have or need lib<>.so support.
65 1.86 jonathan SHLIB_LDSTARTFILE=
66 1.86 jonathan SHLIB_LDENDFILE=
67 1.86 jonathan
68 1.86 jonathan # On mips, all libs need to be compiled with ABIcalls, not just sharedlibs.
69 1.86 jonathan CPICFLAGS?=
70 1.86 jonathan APICFLAGS?=
71 1.86 jonathan #CPICFLAGS?= -fpic -DPIC
72 1.86 jonathan #APICFLAGS?= -DPIC
73 1.86 jonathan
74 1.86 jonathan # so turn shlib PIC flags on for ${CPP}, ${CC}, and ${AS} as follows:
75 1.86 jonathan AINC+=-DPIC -DABICALLS
76 1.86 jonathan COPTS+= -fPIC ${AINC}
77 1.86 jonathan AFLAGS+= -fPIC
78 1.86 jonathan AS+= -KPIC
79 1.86 jonathan
80 1.86 jonathan .else
81 1.86 jonathan
82 1.123 jonathan # Platform-independent flags for NetBSD a.out shared libraries
83 1.86 jonathan SHLIB_TYPE=a.out
84 1.88 cgd SHLIB_LDSTARTFILE=
85 1.88 cgd SHLIB_LDENDFILE=
86 1.123 jonathan SHLIB_SHFLAGS= -Bshareable -Bforcearchive
87 1.86 jonathan SHLIB_SOVERSION=${SHLIB_MAJOR}.${SHLIB_MINOR}
88 1.123 jonathan SHLIB_WHOLE=
89 1.123 jonathan SHLIB_NOWHOLE=
90 1.116 pk CPICFLAGS?= -fpic -DPIC
91 1.107 jonathan CPPPICFLAGS?= -DPIC
92 1.107 jonathan CAPICFLAGS?= ${CPPPICFLAGS} ${CPICFLAGS}
93 1.107 jonathan APICFLAGS?= -k
94 1.86 jonathan
95 1.86 jonathan .endif
96 1.86 jonathan
97 1.123 jonathan # Platform-independent linker flags for ELF shared libraries
98 1.123 jonathan .if (${SHLIB_TYPE} == "ELF")
99 1.124 jonathan SHLIB_WHOLE=--whole-archive
100 1.124 jonathan SHLIB_NOWHOLE=--no-whole-archive
101 1.123 jonathan SHLIB_SOVERSION=${SHLIB_MAJOR}
102 1.123 jonathan SHLIB_SHFLAGS=-shared -soname lib${LIB}.so.${SHLIB_SOVERSION}
103 1.123 jonathan .endif
104 1.86 jonathan
105 1.82 mikel CFLAGS+= ${COPTS}
106 1.1 cgd
107 1.1 cgd .c.o:
108 1.80 christos @echo ${COMPILE.c:Q} ${.IMPSRC}
109 1.122 cgd @${COMPILE.c} ${.IMPSRC} -o ${.TARGET}.o
110 1.62 christos @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
111 1.62 christos @rm -f ${.TARGET}.o
112 1.1 cgd
113 1.1 cgd .c.po:
114 1.80 christos @echo ${COMPILE.c:Q} -pg ${.IMPSRC} -o ${.TARGET}
115 1.68 cgd @${COMPILE.c} -pg ${.IMPSRC} -o ${.TARGET}.o
116 1.62 christos @${LD} -X -r ${.TARGET}.o -o ${.TARGET}
117 1.62 christos @rm -f ${.TARGET}.o
118 1.17 mycroft
119 1.27 pk .c.so:
120 1.86 jonathan @echo ${COMPILE.c:Q} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}
121 1.86 jonathan @${COMPILE.c} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}.o
122 1.62 christos @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
123 1.62 christos @rm -f ${.TARGET}.o
124 1.27 pk
125 1.58 cgd .c.ln:
126 1.121 thorpej ${LINT} ${LINTFLAGS} ${CPPFLAGS:M-[IDU]*} -i ${.IMPSRC}
127 1.58 cgd
128 1.18 mycroft .cc.o .C.o:
129 1.80 christos @echo ${COMPILE.cc:Q} ${.IMPSRC}
130 1.62 christos @${COMPILE.cc} ${.IMPSRC} -o ${.TARGET}.o
131 1.63 jtc @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
132 1.62 christos @rm -f ${.TARGET}.o
133 1.17 mycroft
134 1.18 mycroft .cc.po .C.po:
135 1.80 christos @echo ${COMPILE.cc:Q} -pg ${.IMPSRC} -o ${.TARGET}
136 1.68 cgd @${COMPILE.cc} -pg ${.IMPSRC} -o ${.TARGET}.o
137 1.62 christos @${LD} -X -r ${.TARGET}.o -o ${.TARGET}
138 1.62 christos @rm -f ${.TARGET}.o
139 1.28 cgd
140 1.28 cgd .cc.so .C.so:
141 1.86 jonathan @echo ${COMPILE.cc:Q} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}
142 1.86 jonathan @${COMPILE.cc} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}.o
143 1.62 christos @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
144 1.62 christos @rm -f ${.TARGET}.o
145 1.118 lukem
146 1.118 lukem .m.o:
147 1.118 lukem @echo ${COMPILE.m:Q} ${.IMPSRC}
148 1.122 cgd @${COMPILE.m} ${.IMPSRC} -o ${.TARGET}.o
149 1.118 lukem @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
150 1.118 lukem @rm -f ${.TARGET}.o
151 1.118 lukem
152 1.118 lukem .m.po:
153 1.118 lukem @echo ${COMPILE.m:Q} -pg ${.IMPSRC} -o ${.TARGET}
154 1.118 lukem @${COMPILE.m} -pg ${.IMPSRC} -o ${.TARGET}.o
155 1.118 lukem @${LD} -X -r ${.TARGET}.o -o ${.TARGET}
156 1.118 lukem @rm -f ${.TARGET}.o
157 1.118 lukem
158 1.118 lukem .m.so:
159 1.118 lukem @echo ${COMPILE.m:Q} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}
160 1.118 lukem @${COMPILE.m} ${CPICFLAGS} ${.IMPSRC} -o ${.TARGET}.o
161 1.118 lukem @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
162 1.118 lukem @rm -f ${.TARGET}.o
163 1.1 cgd
164 1.40 cgd .S.o .s.o:
165 1.80 christos @echo ${COMPILE.S:Q} ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC}
166 1.69 jtc @${COMPILE.S} ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC} -o ${.TARGET}.o
167 1.62 christos @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
168 1.62 christos @rm -f ${.TARGET}.o
169 1.1 cgd
170 1.40 cgd .S.po .s.po:
171 1.80 christos @echo ${COMPILE.S:Q} -DGPROF -DPROF ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC} -o ${.TARGET}
172 1.75 jtc @${COMPILE.S} -DGPROF -DPROF ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC} -o ${.TARGET}.o
173 1.62 christos @${LD} -X -r ${.TARGET}.o -o ${.TARGET}
174 1.62 christos @rm -f ${.TARGET}.o
175 1.1 cgd
176 1.40 cgd .S.so .s.so:
177 1.107 jonathan @echo ${COMPILE.S:Q} ${CAPICFLAGS} ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC} -o ${.TARGET}
178 1.107 jonathan @${COMPILE.S} ${CAPICFLAGS} ${CFLAGS:M-[ID]*} ${AINC} ${.IMPSRC} -o ${.TARGET}.o
179 1.62 christos @${LD} -x -r ${.TARGET}.o -o ${.TARGET}
180 1.62 christos @rm -f ${.TARGET}.o
181 1.27 pk
182 1.58 cgd
183 1.1 cgd .if !defined(NOPROFILE)
184 1.1 cgd _LIBS=lib${LIB}.a lib${LIB}_p.a
185 1.1 cgd .else
186 1.1 cgd _LIBS=lib${LIB}.a
187 1.1 cgd .endif
188 1.1 cgd
189 1.27 pk .if !defined(NOPIC)
190 1.27 pk _LIBS+=lib${LIB}_pic.a
191 1.37 cgd .if defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
192 1.37 cgd _LIBS+=lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
193 1.27 pk .endif
194 1.35 pk .endif
195 1.27 pk
196 1.58 cgd .if !defined(NOLINT)
197 1.58 cgd _LIBS+=llib-l${LIB}.ln
198 1.27 pk .endif
199 1.27 pk
200 1.102 mycroft all: ${SRCS} ${_LIBS}
201 1.1 cgd
202 1.90 christos __archivebuild: .USE
203 1.89 christos @rm -f ${.TARGET}
204 1.120 gwr @${AR} cq ${.TARGET} `NM=${NM} ${LORDER} ${.ALLSRC} | ${TSORT}`
205 1.89 christos ${RANLIB} ${.TARGET}
206 1.89 christos
207 1.89 christos __archiveinstall: .USE
208 1.89 christos ${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m 600 ${.ALLSRC} \
209 1.89 christos ${.TARGET}
210 1.89 christos ${RANLIB} -t ${.TARGET}
211 1.89 christos chmod ${LIBMODE} ${.TARGET}
212 1.89 christos
213 1.104 mycroft DPSRCS+= ${SRCS:M*.l:.l=.c} ${SRCS:M*.y:.y=.c}
214 1.103 mycroft CLEANFILES+= ${DPSRCS}
215 1.103 mycroft
216 1.103 mycroft OBJS+= ${SRCS:N*.h:N*.sh:R:S/$/.o/g}
217 1.89 christos lib${LIB}.a:: ${OBJS} __archivebuild
218 1.1 cgd @echo building standard ${LIB} library
219 1.1 cgd
220 1.103 mycroft POBJS+= ${OBJS:.o=.po}
221 1.89 christos lib${LIB}_p.a:: ${POBJS} __archivebuild
222 1.1 cgd @echo building profiled ${LIB} library
223 1.1 cgd
224 1.103 mycroft SOBJS+= ${OBJS:.o=.so}
225 1.89 christos lib${LIB}_pic.a:: ${SOBJS} __archivebuild
226 1.27 pk @echo building shared object ${LIB} library
227 1.27 pk
228 1.88 cgd lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}: lib${LIB}_pic.a ${DPADD} \
229 1.88 cgd ${SHLIB_LDSTARTFILE} ${SHLIB_LDENDFILE}
230 1.38 cgd @echo building shared ${LIB} library \(version ${SHLIB_MAJOR}.${SHLIB_MINOR}\)
231 1.37 cgd @rm -f lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
232 1.123 jonathan $(LD) -x ${SHLIB_SHFLAGS} -o ${.TARGET} \
233 1.123 jonathan ${SHLIB_LDSTARTFILE} \
234 1.123 jonathan ${SHLIB_WHOLE} lib${LIB}_pic.a ${SHLIB_NOWHOLE} ${LDADD} \
235 1.115 cjs ${SHLIB_LDENDFILE}
236 1.35 pk
237 1.103 mycroft LOBJS+= ${LSRCS:.c=.ln} ${SRCS:M*.c:.c=.ln}
238 1.103 mycroft LLIBS?= -lc
239 1.58 cgd llib-l${LIB}.ln: ${LOBJS}
240 1.58 cgd @echo building llib-l${LIB}.ln
241 1.58 cgd @rm -f llib-l${LIB}.ln
242 1.58 cgd @${LINT} -C${LIB} ${LOBJS} ${LLIBS}
243 1.1 cgd
244 1.81 cgd cleanlib:
245 1.48 mycroft rm -f a.out [Ee]rrs mklog core *.core ${CLEANFILES}
246 1.59 cgd rm -f lib${LIB}.a ${OBJS}
247 1.59 cgd rm -f lib${LIB}_p.a ${POBJS}
248 1.61 cgd rm -f lib${LIB}_pic.a lib${LIB}.so.*.* ${SOBJS}
249 1.59 cgd rm -f llib-l${LIB}.ln ${LOBJS}
250 1.1 cgd
251 1.26 mycroft .if defined(SRCS)
252 1.64 christos afterdepend: .depend
253 1.1 cgd @(TMP=/tmp/_depend$$$$; \
254 1.79 cgd sed -e 's/^\([^\.]*\).o[ ]*:/\1.o \1.po \1.so \1.ln:/' \
255 1.58 cgd < .depend > $$TMP; \
256 1.1 cgd mv $$TMP .depend)
257 1.26 mycroft .endif
258 1.1 cgd
259 1.97 mycroft .if !target(libinstall)
260 1.89 christos libinstall:: ${DESTDIR}${LIBDIR}/lib${LIB}.a
261 1.89 christos .if !defined(UPDATE)
262 1.89 christos .PHONY: ${DESTDIR}${LIBDIR}/lib${LIB}.a
263 1.89 christos .endif
264 1.89 christos .if !defined(BUILD)
265 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}.a: .MADE
266 1.89 christos .endif
267 1.89 christos
268 1.95 mycroft .PRECIOUS: ${DESTDIR}${LIBDIR}/lib${LIB}.a
269 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}.a: lib${LIB}.a __archiveinstall
270 1.89 christos
271 1.12 cgd .if !defined(NOPROFILE)
272 1.89 christos libinstall:: ${DESTDIR}${LIBDIR}/lib${LIB}_p.a
273 1.89 christos .if !defined(UPDATE)
274 1.89 christos .PHONY: ${DESTDIR}${LIBDIR}/lib${LIB}_p.a
275 1.32 pk .endif
276 1.89 christos .if !defined(BUILD)
277 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}_p.a: .MADE
278 1.89 christos .endif
279 1.89 christos
280 1.95 mycroft .PRECIOUS: ${DESTDIR}${LIBDIR}/lib${LIB}_p.a
281 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}_p.a: lib${LIB}_p.a __archiveinstall
282 1.89 christos .endif
283 1.89 christos
284 1.39 pk .if !defined(NOPIC)
285 1.89 christos libinstall:: ${DESTDIR}${LIBDIR}/lib${LIB}_pic.a
286 1.89 christos .if !defined(UPDATE)
287 1.89 christos .PHONY: ${DESTDIR}${LIBDIR}/lib${LIB}_pic.a
288 1.89 christos .endif
289 1.89 christos .if !defined(BUILD)
290 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}_pic.a: .MADE
291 1.33 pk .endif
292 1.89 christos
293 1.95 mycroft .PRECIOUS: ${DESTDIR}${LIBDIR}/lib${LIB}_pic.a
294 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}_pic.a: lib${LIB}_pic.a __archiveinstall
295 1.89 christos .endif
296 1.89 christos
297 1.37 cgd .if !defined(NOPIC) && defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
298 1.89 christos libinstall:: ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
299 1.89 christos .if !defined(UPDATE)
300 1.89 christos .PHONY: ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
301 1.89 christos .endif
302 1.89 christos .if !defined(BUILD)
303 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}: .MADE
304 1.89 christos .endif
305 1.92 mikel
306 1.95 mycroft .PRECIOUS: ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
307 1.89 christos ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}: lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR}
308 1.89 christos ${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} ${.ALLSRC} \
309 1.89 christos ${.TARGET}
310 1.86 jonathan .if (${SHLIB_TYPE} == "ELF")
311 1.83 cgd rm -f ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}
312 1.83 cgd ln -s lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
313 1.83 cgd ${DESTDIR}${LIBDIR}/lib${LIB}.so.${SHLIB_MAJOR}
314 1.83 cgd rm -f ${DESTDIR}${LIBDIR}/lib${LIB}.so
315 1.83 cgd ln -s lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
316 1.83 cgd ${DESTDIR}${LIBDIR}/lib${LIB}.so
317 1.83 cgd .endif
318 1.12 cgd .endif
319 1.89 christos
320 1.58 cgd .if !defined(NOLINT)
321 1.89 christos libinstall:: ${DESTDIR}${LINTLIBDIR}/llib-l${LIB}.ln
322 1.89 christos .if !defined(UPDATE)
323 1.89 christos .PHONY: ${DESTDIR}${LINTLIBDIR}/llib-l${LIB}.ln
324 1.89 christos .endif
325 1.89 christos .if !defined(BUILD)
326 1.89 christos ${DESTDIR}${LINTLIBDIR}/llib-l${LIB}.ln: .MADE
327 1.89 christos .endif
328 1.89 christos
329 1.95 mycroft .PRECIOUS: ${DESTDIR}${LINTLIBDIR}/llib-l${LIB}.ln
330 1.95 mycroft ${DESTDIR}${LINTLIBDIR}/llib-l${LIB}.ln: llib-l${LIB}.ln
331 1.73 thorpej ${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
332 1.58 cgd llib-l${LIB}.ln ${DESTDIR}${LINTLIBDIR}
333 1.58 cgd .endif
334 1.1 cgd .endif
335 1.1 cgd
336 1.1 cgd .include <bsd.man.mk>
337 1.57 jtc .include <bsd.nls.mk>
338 1.91 christos .include <bsd.files.mk>
339 1.89 christos .include <bsd.inc.mk>
340 1.109 cjs .include <bsd.links.mk>
341 1.24 mycroft .include <bsd.dep.mk>
342 1.66 christos .include <bsd.sys.mk>
343 1.117 mycroft
344 1.117 mycroft # Make sure all of the standard targets are defined, even if they do nothing.
345 1.117 mycroft lint regress:
346