Home | History | Annotate | Line # | Download | only in pci
mcpcia.c revision 1.29
      1  1.29      matt /* $NetBSD: mcpcia.c,v 1.29 2012/02/06 02:14:14 matt Exp $ */
      2   1.5   thorpej 
      3   1.5   thorpej /*-
      4   1.5   thorpej  * Copyright (c) 1999 The NetBSD Foundation, Inc.
      5   1.5   thorpej  * All rights reserved.
      6   1.5   thorpej  *
      7   1.5   thorpej  * This code is derived from software contributed to The NetBSD Foundation
      8   1.5   thorpej  * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility,
      9   1.5   thorpej  * NASA Ames Research Center.
     10   1.5   thorpej  *
     11   1.5   thorpej  * Redistribution and use in source and binary forms, with or without
     12   1.5   thorpej  * modification, are permitted provided that the following conditions
     13   1.5   thorpej  * are met:
     14   1.5   thorpej  * 1. Redistributions of source code must retain the above copyright
     15   1.5   thorpej  *    notice, this list of conditions and the following disclaimer.
     16   1.5   thorpej  * 2. Redistributions in binary form must reproduce the above copyright
     17   1.5   thorpej  *    notice, this list of conditions and the following disclaimer in the
     18   1.5   thorpej  *    documentation and/or other materials provided with the distribution.
     19   1.5   thorpej  *
     20   1.5   thorpej  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     21   1.5   thorpej  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     22   1.5   thorpej  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     23   1.5   thorpej  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     24   1.5   thorpej  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     25   1.5   thorpej  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     26   1.5   thorpej  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     27   1.5   thorpej  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     28   1.5   thorpej  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     29   1.5   thorpej  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     30   1.5   thorpej  * POSSIBILITY OF SUCH DAMAGE.
     31   1.5   thorpej  */
     32   1.1    mjacob 
     33   1.1    mjacob /*
     34   1.1    mjacob  * Copyright (c) 1998 by Matthew Jacob
     35   1.1    mjacob  * NASA AMES Research Center.
     36   1.1    mjacob  * All rights reserved.
     37   1.1    mjacob  *
     38   1.1    mjacob  * Redistribution and use in source and binary forms, with or without
     39   1.1    mjacob  * modification, are permitted provided that the following conditions
     40   1.1    mjacob  * are met:
     41   1.1    mjacob  * 1. Redistributions of source code must retain the above copyright
     42   1.1    mjacob  *    notice immediately at the beginning of the file, without modification,
     43   1.1    mjacob  *    this list of conditions, and the following disclaimer.
     44   1.1    mjacob  * 2. Redistributions in binary form must reproduce the above copyright
     45   1.1    mjacob  *    notice, this list of conditions and the following disclaimer in the
     46   1.1    mjacob  *    documentation and/or other materials provided with the distribution.
     47   1.1    mjacob  * 3. The name of the author may not be used to endorse or promote products
     48   1.1    mjacob  *    derived from this software without specific prior written permission.
     49   1.1    mjacob  *
     50   1.1    mjacob  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
     51   1.1    mjacob  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
     52   1.1    mjacob  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
     53   1.1    mjacob  * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
     54   1.1    mjacob  * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
     55   1.1    mjacob  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
     56   1.1    mjacob  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
     57   1.1    mjacob  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
     58   1.1    mjacob  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
     59   1.1    mjacob  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     60   1.1    mjacob  * SUCH DAMAGE.
     61   1.1    mjacob  */
     62   1.1    mjacob 
     63   1.1    mjacob /*
     64   1.1    mjacob  * MCPCIA mcbus to PCI bus adapter
     65   1.1    mjacob  * found on AlphaServer 4100 systems.
     66   1.1    mjacob  */
     67   1.1    mjacob 
     68   1.1    mjacob #include <sys/cdefs.h>			/* RCS ID & Copyright macro defns */
     69   1.1    mjacob 
     70  1.29      matt __KERNEL_RCSID(0, "$NetBSD: mcpcia.c,v 1.29 2012/02/06 02:14:14 matt Exp $");
     71   1.1    mjacob 
     72   1.1    mjacob #include <sys/param.h>
     73   1.1    mjacob #include <sys/systm.h>
     74   1.1    mjacob #include <sys/device.h>
     75   1.1    mjacob #include <sys/malloc.h>
     76   1.1    mjacob 
     77   1.1    mjacob #include <machine/autoconf.h>
     78   1.1    mjacob #include <machine/rpb.h>
     79  1.10   thorpej #include <machine/sysarch.h>
     80   1.1    mjacob 
     81   1.1    mjacob #include <alpha/mcbus/mcbusreg.h>
     82   1.1    mjacob #include <alpha/mcbus/mcbusvar.h>
     83   1.1    mjacob #include <alpha/pci/mcpciareg.h>
     84   1.1    mjacob #include <alpha/pci/mcpciavar.h>
     85   1.1    mjacob #include <alpha/pci/pci_kn300.h>
     86   1.1    mjacob 
     87  1.20  christos #define KV(_addr)	((void *)ALPHA_PHYS_TO_K0SEG((_addr)))
     88   1.5   thorpej #define	MCPCIA_SYSBASE(mc)	\
     89   1.5   thorpej 	((((unsigned long) (mc)->cc_gid) << MCBUS_GID_SHIFT) | \
     90   1.5   thorpej 	 (((unsigned long) (mc)->cc_mid) << MCBUS_MID_SHIFT) | \
     91   1.1    mjacob 	 (MCBUS_IOSPACE))
     92   1.1    mjacob 
     93   1.7    mjacob #define	MCPCIA_PROBE(mid, gid)	\
     94   1.7    mjacob 	badaddr((void *)KV(((((unsigned long) gid) << MCBUS_GID_SHIFT) | \
     95   1.7    mjacob 	 (((unsigned long) mid) << MCBUS_MID_SHIFT) | \
     96   1.7    mjacob 	 (MCBUS_IOSPACE) | MCPCIA_PCI_BRIDGE | _MCPCIA_PCI_REV)), \
     97  1.29      matt 	sizeof(uint32_t))
     98   1.7    mjacob 
     99  1.28      matt static int	mcpciamatch(device_t, cfdata_t, void *);
    100  1.28      matt static void	mcpciaattach(device_t, device_t, void *);
    101  1.28      matt 
    102  1.28      matt CFATTACH_DECL_NEW(mcpcia, sizeof(struct mcpcia_softc),
    103  1.15   thorpej     mcpciamatch, mcpciaattach, NULL, NULL);
    104   1.1    mjacob 
    105  1.23       dsl void	mcpcia_init0(struct mcpcia_config *, int);
    106   1.5   thorpej 
    107   1.5   thorpej /*
    108   1.5   thorpej  * We have one statically-allocated mcpcia_config structure; this is
    109   1.5   thorpej  * the one used for the console (which, coincidentally, is the only
    110   1.5   thorpej  * MCPCIA with an EISA adapter attached to it).
    111   1.5   thorpej  */
    112   1.5   thorpej struct mcpcia_config mcpcia_console_configuration;
    113   1.5   thorpej 
    114  1.23       dsl int	mcpcia_bus_get_window(int, int,
    115  1.23       dsl 	    struct alpha_bus_space_translation *abst);
    116  1.10   thorpej 
    117   1.1    mjacob static int
    118  1.28      matt mcpciamatch(device_t parent, cfdata_t cf, void *aux)
    119   1.1    mjacob {
    120   1.1    mjacob 	struct mcbus_dev_attach_args *ma = aux;
    121   1.1    mjacob 	if (ma->ma_type == MCBUS_TYPE_PCI)
    122   1.1    mjacob 		return (1);
    123   1.1    mjacob 	return (0);
    124   1.1    mjacob }
    125   1.1    mjacob 
    126   1.1    mjacob static void
    127  1.28      matt mcpciaattach(device_t parent, device_t self, void *aux)
    128   1.1    mjacob {
    129   1.1    mjacob 	static int first = 1;
    130   1.1    mjacob 	struct mcbus_dev_attach_args *ma = aux;
    131  1.28      matt 	struct mcpcia_softc *mcp = device_private(self);
    132   1.5   thorpej 	struct mcpcia_config *ccp;
    133   1.1    mjacob 	struct pcibus_attach_args pba;
    134  1.29      matt 	uint32_t ctl;
    135   1.1    mjacob 
    136   1.7    mjacob 	/*
    137   1.7    mjacob 	 * Make sure this MCPCIA exists...
    138   1.7    mjacob 	 */
    139   1.7    mjacob 	if (MCPCIA_PROBE(ma->ma_mid, ma->ma_gid)) {
    140   1.7    mjacob 		mcp->mcpcia_cc = NULL;
    141   1.7    mjacob 		printf(" (not present)\n");
    142   1.7    mjacob 		return;
    143   1.7    mjacob 	}
    144   1.1    mjacob 	printf("\n");
    145   1.1    mjacob 
    146   1.5   thorpej 	/*
    147   1.5   thorpej 	 * Determine if we're the console's MCPCIA.
    148   1.5   thorpej 	 */
    149   1.5   thorpej 	if (ma->ma_mid == mcpcia_console_configuration.cc_mid &&
    150   1.5   thorpej 	    ma->ma_gid == mcpcia_console_configuration.cc_gid)
    151   1.5   thorpej 		ccp = &mcpcia_console_configuration;
    152   1.5   thorpej 	else {
    153   1.5   thorpej 		ccp = malloc(sizeof(struct mcpcia_config), M_DEVBUF, M_WAITOK);
    154   1.5   thorpej 		memset(ccp, 0, sizeof(struct mcpcia_config));
    155   1.1    mjacob 
    156   1.5   thorpej 		ccp->cc_mid = ma->ma_mid;
    157   1.5   thorpej 		ccp->cc_gid = ma->ma_gid;
    158   1.1    mjacob 	}
    159   1.5   thorpej 
    160  1.28      matt 	mcp->mcpcia_dev = self;
    161   1.5   thorpej 	mcp->mcpcia_cc = ccp;
    162   1.5   thorpej 	ccp->cc_sc = mcp;
    163   1.5   thorpej 
    164   1.5   thorpej 	/* This initializes cc_sysbase so we can do register access. */
    165   1.5   thorpej 	mcpcia_init0(ccp, 1);
    166   1.5   thorpej 
    167   1.5   thorpej 	ctl = REGVAL(MCPCIA_PCI_REV(ccp));
    168  1.28      matt 	aprint_normal_dev(self,
    169  1.28      matt 	    "Horse Revision %d, %s Handed Saddle Revision %d,"
    170  1.28      matt 	    " CAP Revision %d\n", HORSE_REV(ctl),
    171   1.5   thorpej 	    (SADDLE_TYPE(ctl) & 1)? "Right": "Left", SADDLE_REV(ctl),
    172   1.5   thorpej 	    CAP_REV(ctl));
    173   1.5   thorpej 
    174   1.5   thorpej 	mcpcia_dma_init(ccp);
    175   1.1    mjacob 
    176   1.1    mjacob 	/*
    177   1.1    mjacob 	 * Set up interrupts
    178   1.1    mjacob 	 */
    179   1.5   thorpej 	pci_kn300_pickintr(ccp, first);
    180   1.1    mjacob 	first = 0;
    181   1.1    mjacob 
    182   1.1    mjacob 	/*
    183   1.1    mjacob 	 * Attach PCI bus
    184   1.1    mjacob 	 */
    185   1.5   thorpej 	pba.pba_iot = &ccp->cc_iot;
    186   1.5   thorpej 	pba.pba_memt = &ccp->cc_memt;
    187   1.1    mjacob 	pba.pba_dmat =	/* start with direct, may change... */
    188   1.5   thorpej 	    alphabus_dma_get_tag(&ccp->cc_dmat_direct, ALPHA_BUS_PCI);
    189  1.17      fvdl 	pba.pba_dmat64 = NULL;
    190   1.5   thorpej 	pba.pba_pc = &ccp->cc_pc;
    191   1.1    mjacob 	pba.pba_bus = 0;
    192  1.13   thorpej 	pba.pba_bridgetag = NULL;
    193  1.27    dyoung 	pba.pba_flags = PCI_FLAGS_IO_OKAY | PCI_FLAGS_MEM_OKAY |
    194   1.6   thorpej 	    PCI_FLAGS_MRL_OKAY | PCI_FLAGS_MRM_OKAY | PCI_FLAGS_MWI_OKAY;
    195  1.18  drochner 	(void) config_found_ia(self, "pcibus", &pba, pcibusprint);
    196   1.5   thorpej 
    197   1.5   thorpej 	/*
    198   1.5   thorpej 	 * Clear any errors that may have occurred during the probe
    199   1.5   thorpej 	 * sequence.
    200   1.5   thorpej 	 */
    201   1.5   thorpej 	REGVAL(MCPCIA_CAP_ERR(ccp)) = 0xFFFFFFFF;
    202   1.5   thorpej 	alpha_mb();
    203   1.5   thorpej }
    204   1.5   thorpej 
    205   1.5   thorpej void
    206  1.26    cegger mcpcia_init(void)
    207   1.5   thorpej {
    208   1.5   thorpej 	struct mcpcia_config *ccp = &mcpcia_console_configuration;
    209   1.5   thorpej 	int i;
    210   1.5   thorpej 
    211   1.5   thorpej 	/*
    212   1.5   thorpej 	 * Look for all of the MCPCIAs on the system.  One of them
    213   1.5   thorpej 	 * will have an EISA attached to it.  This MCPCIA is the
    214   1.5   thorpej 	 * only one that can be used for the console.  Once we find
    215   1.5   thorpej 	 * that one, initialize it.
    216   1.5   thorpej 	 */
    217   1.5   thorpej 
    218   1.5   thorpej 	for (i = 0; i < MCPCIA_PER_MCBUS; i++) {
    219   1.5   thorpej 		ccp->cc_mid = mcbus_mcpcia_probe_order[i];
    220   1.5   thorpej 		/*
    221   1.5   thorpej 		 * XXX If we ever support more than one MCBUS, we'll
    222   1.5   thorpej 		 * XXX have to probe for them, and map them to unit
    223   1.5   thorpej 		 * XXX numbers.
    224   1.5   thorpej 		 */
    225   1.5   thorpej 		ccp->cc_gid = MCBUS_GID_FROM_INSTANCE(0);
    226   1.5   thorpej 		ccp->cc_sysbase = MCPCIA_SYSBASE(ccp);
    227   1.5   thorpej 
    228   1.5   thorpej 		if (badaddr((void *)ALPHA_PHYS_TO_K0SEG(MCPCIA_PCI_REV(ccp)),
    229  1.29      matt 		    sizeof(uint32_t)))
    230   1.5   thorpej 			continue;
    231   1.5   thorpej 
    232   1.5   thorpej 		if (EISA_PRESENT(REGVAL(MCPCIA_PCI_REV(ccp)))) {
    233   1.5   thorpej 			mcpcia_init0(ccp, 0);
    234  1.10   thorpej 
    235  1.10   thorpej 			alpha_bus_window_count[ALPHA_BUS_TYPE_PCI_IO] = 2;
    236  1.10   thorpej 			alpha_bus_window_count[ALPHA_BUS_TYPE_PCI_MEM] = 3;
    237  1.10   thorpej 
    238  1.10   thorpej 			alpha_bus_get_window = mcpcia_bus_get_window;
    239   1.5   thorpej 			return;
    240   1.5   thorpej 		}
    241   1.5   thorpej 	}
    242   1.5   thorpej 
    243   1.5   thorpej 	panic("mcpcia_init: unable to find EISA bus");
    244   1.1    mjacob }
    245   1.1    mjacob 
    246   1.1    mjacob void
    247  1.24       dsl mcpcia_init0(struct mcpcia_config *ccp, int mallocsafe)
    248   1.1    mjacob {
    249  1.29      matt 	uint32_t ctl;
    250   1.1    mjacob 
    251   1.1    mjacob 	if (ccp->cc_initted == 0) {
    252   1.5   thorpej 		/* don't do these twice since they set up extents */
    253   1.1    mjacob 		mcpcia_bus_io_init(&ccp->cc_iot, ccp);
    254   1.1    mjacob 		mcpcia_bus_mem_init(&ccp->cc_memt, ccp);
    255   1.1    mjacob 	}
    256   1.5   thorpej 	ccp->cc_mallocsafe = mallocsafe;
    257   1.5   thorpej 
    258   1.1    mjacob 	mcpcia_pci_init(&ccp->cc_pc, ccp);
    259   1.1    mjacob 
    260   1.1    mjacob 	/*
    261   1.1    mjacob 	 * Establish a precalculated base for convenience's sake.
    262   1.1    mjacob 	 */
    263   1.5   thorpej 	ccp->cc_sysbase = MCPCIA_SYSBASE(ccp);
    264   1.1    mjacob 
    265   1.1    mjacob 	/*
    266   1.1    mjacob  	 * Disable interrupts and clear errors prior to probing
    267   1.1    mjacob 	 */
    268   1.5   thorpej 	REGVAL(MCPCIA_INT_MASK0(ccp)) = 0;
    269   1.5   thorpej 	REGVAL(MCPCIA_INT_MASK1(ccp)) = 0;
    270   1.5   thorpej 	REGVAL(MCPCIA_CAP_ERR(ccp)) = 0xFFFFFFFF;
    271   1.1    mjacob 	alpha_mb();
    272   1.1    mjacob 
    273  1.12   thorpej 	if (ccp == &mcpcia_console_configuration) {
    274  1.12   thorpej 		/*
    275  1.12   thorpej 		 * Use this opportunity to also find out the MID and CPU
    276  1.12   thorpej 		 * type of the currently running CPU (that's us, billybob....)
    277  1.12   thorpej 		 */
    278  1.12   thorpej 		ctl = REGVAL(MCPCIA_WHOAMI(ccp));
    279  1.12   thorpej 		mcbus_primary.mcbus_cpu_mid = MCBUS_CPU_MID(ctl);
    280  1.12   thorpej 		if ((MCBUS_CPU_INFO(ctl) & CPU_Fill_Err) == 0 &&
    281  1.12   thorpej 		    mcbus_primary.mcbus_valid == 0) {
    282  1.12   thorpej 			mcbus_primary.mcbus_bcache =
    283  1.12   thorpej 			    MCBUS_CPU_INFO(ctl) & CPU_BCacheMask;
    284  1.12   thorpej 			mcbus_primary.mcbus_valid = 1;
    285  1.12   thorpej 		}
    286  1.12   thorpej 		alpha_mb();
    287   1.1    mjacob 	}
    288   1.5   thorpej 
    289   1.1    mjacob 	ccp->cc_initted = 1;
    290   1.1    mjacob }
    291   1.1    mjacob 
    292   1.5   thorpej #ifdef TEST_PROBE_DEATH
    293   1.4    mjacob static void
    294  1.24       dsl die_heathen_dog(void *arg)
    295   1.4    mjacob {
    296   1.5   thorpej 	struct mcpcia_config *ccp = arg;
    297   1.5   thorpej 
    298   1.4    mjacob 	/* this causes a fatal machine check (0x670) */
    299   1.5   thorpej 	REGVAL(MCPCIA_CAP_DIAG(ccp)) |= CAP_DIAG_MC_ADRPE;
    300   1.4    mjacob }
    301   1.4    mjacob #endif
    302   1.4    mjacob 
    303   1.1    mjacob void
    304  1.26    cegger mcpcia_config_cleanup(void)
    305   1.1    mjacob {
    306  1.29      matt 	volatile uint32_t ctl;
    307   1.1    mjacob 	struct mcpcia_softc *mcp;
    308   1.5   thorpej 	struct mcpcia_config *ccp;
    309   1.5   thorpej 	int i;
    310   1.5   thorpej 	extern struct cfdriver mcpcia_cd;
    311   1.1    mjacob 
    312   1.1    mjacob 	/*
    313   1.1    mjacob 	 * Turn on Hard, Soft error interrupts. Maybe i2c too.
    314   1.1    mjacob 	 */
    315   1.5   thorpej 	for (i = 0; i < mcpcia_cd.cd_ndevs; i++) {
    316  1.22    dogcow 		if ((mcp = device_lookup_private(&mcpcia_cd, i)) == NULL)
    317   1.5   thorpej 			continue;
    318   1.5   thorpej 
    319   1.5   thorpej 		ccp = mcp->mcpcia_cc;
    320   1.7    mjacob 		if (ccp == NULL)
    321   1.7    mjacob 			continue;
    322   1.5   thorpej 
    323   1.5   thorpej 		ctl = REGVAL(MCPCIA_INT_MASK0(ccp));
    324   1.1    mjacob 		ctl |= MCPCIA_GEN_IENABL;
    325   1.5   thorpej 		REGVAL(MCPCIA_INT_MASK0(ccp)) = ctl;
    326   1.1    mjacob 		alpha_mb();
    327   1.5   thorpej 
    328   1.1    mjacob 		/* force stall while write completes */
    329   1.5   thorpej 		ctl = REGVAL(MCPCIA_INT_MASK0(ccp));
    330   1.4    mjacob 	}
    331   1.5   thorpej #ifdef TEST_PROBE_DEATH
    332   1.5   thorpej 	(void) timeout (die_heathen_dog, &mcpcia_console_configuration,
    333   1.5   thorpej 	    30 * hz);
    334   1.4    mjacob #endif
    335  1.10   thorpej }
    336  1.10   thorpej 
    337  1.10   thorpej int
    338  1.25       dsl mcpcia_bus_get_window(int type, int window, struct alpha_bus_space_translation *abst)
    339  1.10   thorpej {
    340  1.10   thorpej 	struct mcpcia_config *ccp = &mcpcia_console_configuration;
    341  1.10   thorpej 	bus_space_tag_t st;
    342  1.10   thorpej 
    343  1.10   thorpej 	switch (type) {
    344  1.10   thorpej 	case ALPHA_BUS_TYPE_PCI_IO:
    345  1.10   thorpej 		st = &ccp->cc_iot;
    346  1.10   thorpej 		break;
    347  1.10   thorpej 
    348  1.10   thorpej 	case ALPHA_BUS_TYPE_PCI_MEM:
    349  1.10   thorpej 		st = &ccp->cc_memt;
    350  1.10   thorpej 		break;
    351  1.10   thorpej 
    352  1.10   thorpej 	default:
    353  1.10   thorpej 		panic("mcpcia_bus_get_window");
    354  1.10   thorpej 	}
    355  1.10   thorpej 
    356  1.10   thorpej 	return (alpha_bus_space_get_window(st, window, abst));
    357   1.1    mjacob }
    358