Home | History | Annotate | Line # | Download | only in fdt
gic_fdt.c revision 1.14
      1  1.14  jmcneill /* $NetBSD: gic_fdt.c,v 1.14 2018/11/11 21:24:28 jmcneill Exp $ */
      2   1.1  jmcneill 
      3   1.1  jmcneill /*-
      4   1.3  jmcneill  * Copyright (c) 2015-2017 Jared McNeill <jmcneill (at) invisible.ca>
      5   1.1  jmcneill  * All rights reserved.
      6   1.1  jmcneill  *
      7   1.1  jmcneill  * Redistribution and use in source and binary forms, with or without
      8   1.1  jmcneill  * modification, are permitted provided that the following conditions
      9   1.1  jmcneill  * are met:
     10   1.1  jmcneill  * 1. Redistributions of source code must retain the above copyright
     11   1.1  jmcneill  *    notice, this list of conditions and the following disclaimer.
     12   1.1  jmcneill  * 2. Redistributions in binary form must reproduce the above copyright
     13   1.1  jmcneill  *    notice, this list of conditions and the following disclaimer in the
     14   1.1  jmcneill  *    documentation and/or other materials provided with the distribution.
     15   1.1  jmcneill  *
     16   1.1  jmcneill  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
     17   1.1  jmcneill  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
     18   1.1  jmcneill  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
     19   1.1  jmcneill  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
     20   1.1  jmcneill  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
     21   1.1  jmcneill  * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
     22   1.1  jmcneill  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
     23   1.1  jmcneill  * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
     24   1.1  jmcneill  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
     25   1.1  jmcneill  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     26   1.1  jmcneill  * SUCH DAMAGE.
     27   1.1  jmcneill  */
     28   1.1  jmcneill 
     29   1.1  jmcneill #include <sys/cdefs.h>
     30  1.14  jmcneill __KERNEL_RCSID(0, "$NetBSD: gic_fdt.c,v 1.14 2018/11/11 21:24:28 jmcneill Exp $");
     31   1.1  jmcneill 
     32   1.1  jmcneill #include <sys/param.h>
     33   1.1  jmcneill #include <sys/bus.h>
     34   1.1  jmcneill #include <sys/device.h>
     35   1.1  jmcneill #include <sys/intr.h>
     36   1.1  jmcneill #include <sys/systm.h>
     37   1.1  jmcneill #include <sys/kernel.h>
     38   1.5  jmcneill #include <sys/lwp.h>
     39   1.1  jmcneill #include <sys/kmem.h>
     40  1.12  jmcneill #include <sys/queue.h>
     41   1.1  jmcneill 
     42  1.14  jmcneill #include <dev/pci/pcivar.h>
     43  1.14  jmcneill 
     44   1.1  jmcneill #include <arm/cortex/gic_intr.h>
     45  1.14  jmcneill #include <arm/cortex/gic_reg.h>
     46  1.14  jmcneill #include <arm/cortex/gic_v2m.h>
     47   1.3  jmcneill #include <arm/cortex/mpcore_var.h>
     48   1.1  jmcneill 
     49   1.1  jmcneill #include <dev/fdt/fdtvar.h>
     50   1.1  jmcneill 
     51   1.5  jmcneill #define	GIC_MAXIRQ	1020
     52   1.5  jmcneill 
     53  1.14  jmcneill extern struct pic_softc *pic_list[];
     54  1.14  jmcneill 
     55  1.14  jmcneill struct gic_fdt_softc;
     56  1.14  jmcneill struct gic_fdt_irq;
     57  1.14  jmcneill 
     58   1.1  jmcneill static int	gic_fdt_match(device_t, cfdata_t, void *);
     59   1.1  jmcneill static void	gic_fdt_attach(device_t, device_t, void *);
     60  1.14  jmcneill static void	gic_fdt_attach_v2m(struct gic_fdt_softc *, bus_space_tag_t, int);
     61   1.1  jmcneill 
     62   1.5  jmcneill static int	gic_fdt_intr(void *);
     63   1.5  jmcneill 
     64   1.2     marty static void *	gic_fdt_establish(device_t, u_int *, int, int,
     65   1.1  jmcneill 		    int (*)(void *), void *);
     66   1.1  jmcneill static void	gic_fdt_disestablish(device_t, void *);
     67   1.2     marty static bool	gic_fdt_intrstr(device_t, u_int *, char *, size_t);
     68   1.1  jmcneill 
     69   1.1  jmcneill struct fdtbus_interrupt_controller_func gic_fdt_funcs = {
     70   1.1  jmcneill 	.establish = gic_fdt_establish,
     71   1.1  jmcneill 	.disestablish = gic_fdt_disestablish,
     72   1.1  jmcneill 	.intrstr = gic_fdt_intrstr
     73   1.1  jmcneill };
     74   1.1  jmcneill 
     75   1.5  jmcneill struct gic_fdt_irqhandler {
     76   1.5  jmcneill 	struct gic_fdt_irq	*ih_irq;
     77   1.5  jmcneill 	int			(*ih_fn)(void *);
     78   1.5  jmcneill 	void			*ih_arg;
     79   1.5  jmcneill 	bool			ih_mpsafe;
     80   1.5  jmcneill 	TAILQ_ENTRY(gic_fdt_irqhandler) ih_next;
     81   1.5  jmcneill };
     82   1.5  jmcneill 
     83   1.5  jmcneill struct gic_fdt_irq {
     84   1.5  jmcneill 	struct gic_fdt_softc	*intr_sc;
     85   1.5  jmcneill 	void			*intr_ih;
     86  1.11  jmcneill 	void			*intr_arg;
     87   1.5  jmcneill 	int			intr_refcnt;
     88   1.5  jmcneill 	int			intr_ipl;
     89   1.6  jmcneill 	int			intr_level;
     90   1.7  jmcneill 	int			intr_mpsafe;
     91   1.5  jmcneill 	TAILQ_HEAD(, gic_fdt_irqhandler) intr_handlers;
     92   1.9  jakllsch 	int			intr_irq;
     93   1.5  jmcneill };
     94   1.5  jmcneill 
     95   1.1  jmcneill struct gic_fdt_softc {
     96   1.1  jmcneill 	device_t		sc_dev;
     97  1.14  jmcneill 	device_t		sc_gicdev;
     98   1.1  jmcneill 	int			sc_phandle;
     99   1.5  jmcneill 
    100  1.14  jmcneill 	int			sc_v2m_count;
    101  1.14  jmcneill 
    102   1.5  jmcneill 	struct gic_fdt_irq	*sc_irq[GIC_MAXIRQ];
    103   1.1  jmcneill };
    104   1.1  jmcneill 
    105   1.1  jmcneill CFATTACH_DECL_NEW(gic_fdt, sizeof(struct gic_fdt_softc),
    106   1.1  jmcneill 	gic_fdt_match, gic_fdt_attach, NULL, NULL);
    107   1.1  jmcneill 
    108   1.1  jmcneill static int
    109   1.1  jmcneill gic_fdt_match(device_t parent, cfdata_t cf, void *aux)
    110   1.1  jmcneill {
    111   1.1  jmcneill 	const char * const compatible[] = {
    112   1.1  jmcneill 		"arm,gic-400",
    113   1.1  jmcneill 		"arm,cortex-a15-gic",
    114   1.1  jmcneill 		"arm,cortex-a9-gic",
    115   1.1  jmcneill 		"arm,cortex-a7-gic",
    116   1.1  jmcneill 		NULL
    117   1.1  jmcneill 	};
    118   1.1  jmcneill 	struct fdt_attach_args * const faa = aux;
    119   1.1  jmcneill 
    120  1.14  jmcneill 	return of_match_compatible(faa->faa_phandle, compatible);
    121   1.1  jmcneill }
    122   1.1  jmcneill 
    123   1.1  jmcneill static void
    124   1.1  jmcneill gic_fdt_attach(device_t parent, device_t self, void *aux)
    125   1.1  jmcneill {
    126   1.1  jmcneill 	struct gic_fdt_softc * const sc = device_private(self);
    127   1.1  jmcneill 	struct fdt_attach_args * const faa = aux;
    128  1.14  jmcneill 	const int phandle = faa->faa_phandle;
    129   1.3  jmcneill 	bus_addr_t addr_d, addr_c;
    130   1.3  jmcneill 	bus_size_t size_d, size_c;
    131   1.3  jmcneill 	bus_space_handle_t bsh;
    132  1.14  jmcneill 	int error, child;
    133   1.1  jmcneill 
    134   1.1  jmcneill 	sc->sc_dev = self;
    135  1.14  jmcneill 	sc->sc_phandle = phandle;
    136   1.1  jmcneill 
    137  1.14  jmcneill 	error = fdtbus_register_interrupt_controller(self, phandle,
    138   1.1  jmcneill 	    &gic_fdt_funcs);
    139   1.1  jmcneill 	if (error) {
    140   1.1  jmcneill 		aprint_error(": couldn't register with fdtbus: %d\n", error);
    141   1.1  jmcneill 		return;
    142   1.1  jmcneill 	}
    143   1.1  jmcneill 
    144   1.1  jmcneill 	aprint_naive("\n");
    145   1.1  jmcneill 	aprint_normal(": GIC\n");
    146   1.3  jmcneill 
    147   1.3  jmcneill 	if (fdtbus_get_reg(sc->sc_phandle, 0, &addr_d, &size_d) != 0) {
    148   1.3  jmcneill 		aprint_error(": couldn't get distributor address\n");
    149   1.3  jmcneill 		return;
    150   1.3  jmcneill 	}
    151   1.3  jmcneill 	if (fdtbus_get_reg(sc->sc_phandle, 1, &addr_c, &size_c) != 0) {
    152   1.3  jmcneill 		aprint_error(": couldn't get cpu interface address\n");
    153   1.3  jmcneill 		return;
    154   1.3  jmcneill 	}
    155   1.3  jmcneill 
    156  1.13  riastrad 	const bus_addr_t addr = uimin(addr_d, addr_c);
    157  1.13  riastrad 	const bus_size_t end = uimax(addr_d + size_d, addr_c + size_c);
    158  1.10   hkenken 	const bus_size_t size = end - addr;
    159   1.3  jmcneill 
    160   1.3  jmcneill 	error = bus_space_map(faa->faa_bst, addr, size, 0, &bsh);
    161   1.3  jmcneill 	if (error) {
    162   1.3  jmcneill 		aprint_error(": couldn't map registers: %d\n", error);
    163   1.3  jmcneill 		return;
    164   1.3  jmcneill 	}
    165   1.3  jmcneill 
    166   1.3  jmcneill 	struct mpcore_attach_args mpcaa = {
    167   1.3  jmcneill 		.mpcaa_name = "armgic",
    168   1.3  jmcneill 		.mpcaa_memt = faa->faa_bst,
    169   1.3  jmcneill 		.mpcaa_memh = bsh,
    170  1.10   hkenken 		.mpcaa_off1 = addr_d - addr,
    171  1.10   hkenken 		.mpcaa_off2 = addr_c - addr,
    172   1.3  jmcneill 	};
    173   1.3  jmcneill 
    174  1.14  jmcneill 	sc->sc_gicdev = config_found(self, &mpcaa, NULL);
    175   1.4  jmcneill 
    176   1.4  jmcneill 	arm_fdt_irq_set_handler(armgic_irq_handler);
    177  1.14  jmcneill 
    178  1.14  jmcneill 	for (child = OF_child(phandle); child; child = OF_peer(child)) {
    179  1.14  jmcneill 		if (!fdtbus_status_okay(child))
    180  1.14  jmcneill 			continue;
    181  1.14  jmcneill 		const char * const v2m_compat[] = { "arm,gic-v2m-frame", NULL };
    182  1.14  jmcneill 		if (of_match_compatible(child, v2m_compat))
    183  1.14  jmcneill 			gic_fdt_attach_v2m(sc, faa->faa_bst, child);
    184  1.14  jmcneill 	}
    185  1.14  jmcneill }
    186  1.14  jmcneill 
    187  1.14  jmcneill static void
    188  1.14  jmcneill gic_fdt_attach_v2m(struct gic_fdt_softc *sc, bus_space_tag_t bst, int phandle)
    189  1.14  jmcneill {
    190  1.14  jmcneill 	struct gic_v2m_frame *frame;
    191  1.14  jmcneill 	u_int base_spi, num_spis;
    192  1.14  jmcneill 	bus_space_handle_t bsh;
    193  1.14  jmcneill 	bus_addr_t addr;
    194  1.14  jmcneill 	bus_size_t size;
    195  1.14  jmcneill 
    196  1.14  jmcneill 	if (fdtbus_get_reg(phandle, 0, &addr, &size) != 0) {
    197  1.14  jmcneill 		aprint_error_dev(sc->sc_gicdev, "couldn't get V2M address\n");
    198  1.14  jmcneill 		return;
    199  1.14  jmcneill 	}
    200  1.14  jmcneill 
    201  1.14  jmcneill 	if (bus_space_map(bst, addr, size, 0, &bsh) != 0) {
    202  1.14  jmcneill 		aprint_error_dev(sc->sc_gicdev, "couldn't map V2M frame\n");
    203  1.14  jmcneill 		return;
    204  1.14  jmcneill 	}
    205  1.14  jmcneill 	const uint32_t typer = bus_space_read_4(bst, bsh, GIC_MSI_TYPER);
    206  1.14  jmcneill 	bus_space_unmap(bst, bsh, size);
    207  1.14  jmcneill 
    208  1.14  jmcneill 	if (of_getprop_uint32(phandle, "arm,msi-base-spi", &base_spi))
    209  1.14  jmcneill 		base_spi = __SHIFTOUT(typer, GIC_MSI_TYPER_BASE);
    210  1.14  jmcneill 	if (of_getprop_uint32(phandle, "arm,msi-num-spis", &num_spis))
    211  1.14  jmcneill 		num_spis = __SHIFTOUT(typer, GIC_MSI_TYPER_NUMBER);
    212  1.14  jmcneill 
    213  1.14  jmcneill 	frame = kmem_zalloc(sizeof(*frame), KM_SLEEP);
    214  1.14  jmcneill 	frame->frame_reg = addr;
    215  1.14  jmcneill 	frame->frame_pic = pic_list[0];
    216  1.14  jmcneill 	frame->frame_base = base_spi;
    217  1.14  jmcneill 	frame->frame_count = num_spis;
    218  1.14  jmcneill 
    219  1.14  jmcneill 	if (gic_v2m_init(frame, sc->sc_gicdev, sc->sc_v2m_count++) != 0) {
    220  1.14  jmcneill 		aprint_error_dev(sc->sc_gicdev, "failed to initialize GICv2m\n");
    221  1.14  jmcneill 	} else {
    222  1.14  jmcneill 		aprint_normal_dev(sc->sc_gicdev, "GICv2m @ %#" PRIx64 ", SPIs %u-%u\n",
    223  1.14  jmcneill 		    (uint64_t)frame->frame_reg, frame->frame_base,
    224  1.14  jmcneill 		    frame->frame_base + frame->frame_count);
    225  1.14  jmcneill 	}
    226   1.1  jmcneill }
    227   1.1  jmcneill 
    228   1.1  jmcneill static void *
    229   1.2     marty gic_fdt_establish(device_t dev, u_int *specifier, int ipl, int flags,
    230   1.1  jmcneill     int (*func)(void *), void *arg)
    231   1.1  jmcneill {
    232   1.5  jmcneill 	struct gic_fdt_softc * const sc = device_private(dev);
    233   1.5  jmcneill 	struct gic_fdt_irq *firq;
    234   1.5  jmcneill 	struct gic_fdt_irqhandler *firqh;
    235   1.1  jmcneill 
    236   1.1  jmcneill 	/* 1st cell is the interrupt type; 0 is SPI, 1 is PPI */
    237   1.1  jmcneill 	/* 2nd cell is the interrupt number */
    238   1.1  jmcneill 	/* 3rd cell is flags */
    239   1.1  jmcneill 
    240   1.2     marty 	const u_int type = be32toh(specifier[0]);
    241   1.2     marty 	const u_int intr = be32toh(specifier[1]);
    242   1.1  jmcneill 	const u_int irq = type == 0 ? IRQ_SPI(intr) : IRQ_PPI(intr);
    243   1.2     marty 	const u_int trig = be32toh(specifier[2]) & 0xf;
    244   1.1  jmcneill 	const u_int level = (trig & 0x3) ? IST_EDGE : IST_LEVEL;
    245   1.1  jmcneill 
    246   1.7  jmcneill 	const u_int mpsafe = (flags & FDT_INTR_MPSAFE) ? IST_MPSAFE : 0;
    247   1.7  jmcneill 
    248   1.5  jmcneill 	firq = sc->sc_irq[irq];
    249   1.5  jmcneill 	if (firq == NULL) {
    250   1.5  jmcneill 		firq = kmem_alloc(sizeof(*firq), KM_SLEEP);
    251   1.5  jmcneill 		firq->intr_sc = sc;
    252   1.5  jmcneill 		firq->intr_refcnt = 0;
    253  1.11  jmcneill 		firq->intr_arg = arg;
    254   1.5  jmcneill 		firq->intr_ipl = ipl;
    255   1.6  jmcneill 		firq->intr_level = level;
    256   1.7  jmcneill 		firq->intr_mpsafe = mpsafe;
    257   1.5  jmcneill 		TAILQ_INIT(&firq->intr_handlers);
    258   1.9  jakllsch 		firq->intr_irq = irq;
    259   1.8     skrll 		if (arg == NULL) {
    260   1.8     skrll 			firq->intr_ih = intr_establish(irq, ipl, level | mpsafe,
    261   1.8     skrll 			    func, NULL);
    262   1.8     skrll 		} else {
    263   1.8     skrll 			firq->intr_ih = intr_establish(irq, ipl, level | mpsafe,
    264   1.8     skrll 			    gic_fdt_intr, firq);
    265   1.8     skrll 		}
    266   1.5  jmcneill 		if (firq->intr_ih == NULL) {
    267   1.5  jmcneill 			kmem_free(firq, sizeof(*firq));
    268   1.5  jmcneill 			return NULL;
    269   1.5  jmcneill 		}
    270   1.5  jmcneill 		sc->sc_irq[irq] = firq;
    271   1.8     skrll 	} else {
    272  1.11  jmcneill 		if (firq->intr_arg == NULL && arg != NULL) {
    273   1.8     skrll 			device_printf(dev, "cannot share irq with NULL arg\n");
    274   1.8     skrll 			return NULL;
    275   1.8     skrll 		}
    276   1.8     skrll 		if (firq->intr_ipl != ipl) {
    277   1.8     skrll 			device_printf(dev, "cannot share irq with different "
    278   1.8     skrll 			    "ipl\n");
    279   1.8     skrll 			return NULL;
    280   1.8     skrll 		}
    281   1.8     skrll 		if (firq->intr_level != level) {
    282   1.8     skrll 			device_printf(dev, "cannot share edge and level "
    283   1.8     skrll 			    "interrupts\n");
    284   1.8     skrll 			return NULL;
    285   1.8     skrll 		}
    286   1.8     skrll 		if (firq->intr_mpsafe != mpsafe) {
    287   1.8     skrll 			device_printf(dev, "cannot share between "
    288   1.8     skrll 			    "mpsafe/non-mpsafe\n");
    289   1.8     skrll 			return NULL;
    290   1.8     skrll 		}
    291   1.7  jmcneill 	}
    292   1.5  jmcneill 
    293   1.5  jmcneill 	firq->intr_refcnt++;
    294   1.5  jmcneill 
    295   1.5  jmcneill 	firqh = kmem_alloc(sizeof(*firqh), KM_SLEEP);
    296   1.5  jmcneill 	firqh->ih_mpsafe = (flags & FDT_INTR_MPSAFE) != 0;
    297   1.5  jmcneill 	firqh->ih_irq = firq;
    298   1.5  jmcneill 	firqh->ih_fn = func;
    299   1.5  jmcneill 	firqh->ih_arg = arg;
    300   1.5  jmcneill 	TAILQ_INSERT_TAIL(&firq->intr_handlers, firqh, ih_next);
    301   1.5  jmcneill 
    302  1.12  jmcneill 	return firq->intr_ih;
    303   1.1  jmcneill }
    304   1.1  jmcneill 
    305   1.1  jmcneill static void
    306   1.1  jmcneill gic_fdt_disestablish(device_t dev, void *ih)
    307   1.1  jmcneill {
    308   1.9  jakllsch 	struct gic_fdt_softc * const sc = device_private(dev);
    309  1.12  jmcneill 	struct gic_fdt_irqhandler *firqh;
    310  1.12  jmcneill 	struct gic_fdt_irq *firq;
    311  1.12  jmcneill 	u_int n;
    312  1.12  jmcneill 
    313  1.12  jmcneill 	for (n = 0; n < GIC_MAXIRQ; n++) {
    314  1.12  jmcneill 		firq = sc->sc_irq[n];
    315  1.12  jmcneill 		if (firq->intr_ih != ih)
    316  1.12  jmcneill 			continue;
    317   1.5  jmcneill 
    318  1.12  jmcneill 		KASSERT(firq->intr_refcnt > 0);
    319   1.5  jmcneill 
    320  1.12  jmcneill 		if (firq->intr_refcnt > 1)
    321  1.12  jmcneill 			panic("%s: cannot disestablish shared irq", __func__);
    322   1.5  jmcneill 
    323  1.12  jmcneill 		firqh = TAILQ_FIRST(&firq->intr_handlers);
    324  1.12  jmcneill 		kmem_free(firqh, sizeof(*firqh));
    325   1.5  jmcneill 		intr_disestablish(firq->intr_ih);
    326   1.5  jmcneill 		kmem_free(firq, sizeof(*firq));
    327  1.12  jmcneill 		sc->sc_irq[n] = NULL;
    328  1.12  jmcneill 		return;
    329   1.5  jmcneill 	}
    330  1.12  jmcneill 
    331  1.12  jmcneill 	panic("%s: interrupt not established", __func__);
    332   1.5  jmcneill }
    333   1.5  jmcneill 
    334   1.5  jmcneill static int
    335   1.5  jmcneill gic_fdt_intr(void *priv)
    336   1.5  jmcneill {
    337   1.5  jmcneill 	struct gic_fdt_irq *firq = priv;
    338   1.5  jmcneill 	struct gic_fdt_irqhandler *firqh;
    339   1.5  jmcneill 	int handled = 0;
    340   1.5  jmcneill 
    341   1.7  jmcneill 	TAILQ_FOREACH(firqh, &firq->intr_handlers, ih_next)
    342   1.5  jmcneill 		handled += firqh->ih_fn(firqh->ih_arg);
    343   1.5  jmcneill 
    344   1.5  jmcneill 	return handled;
    345   1.1  jmcneill }
    346   1.1  jmcneill 
    347   1.1  jmcneill static bool
    348   1.2     marty gic_fdt_intrstr(device_t dev, u_int *specifier, char *buf, size_t buflen)
    349   1.1  jmcneill {
    350   1.1  jmcneill 	/* 1st cell is the interrupt type; 0 is SPI, 1 is PPI */
    351   1.1  jmcneill 	/* 2nd cell is the interrupt number */
    352   1.1  jmcneill 	/* 3rd cell is flags */
    353   1.1  jmcneill 
    354   1.2     marty 	if (!specifier)
    355   1.2     marty 		return false;
    356   1.2     marty 	const u_int type = be32toh(specifier[0]);
    357   1.2     marty 	const u_int intr = be32toh(specifier[1]);
    358   1.1  jmcneill 	const u_int irq = type == 0 ? IRQ_SPI(intr) : IRQ_PPI(intr);
    359   1.1  jmcneill 
    360   1.1  jmcneill 	snprintf(buf, buflen, "GIC irq %d", irq);
    361   1.1  jmcneill 
    362   1.1  jmcneill 	return true;
    363   1.1  jmcneill }
    364