Home | History | Annotate | Line # | Download | only in isa
mms.c revision 1.6.2.6
      1      1.1   andrew /*-
      2  1.6.2.1  mycroft  * Copyright (c) 1993 Charles Hannum
      3      1.1   andrew  * Copyright (c) 1992, 1993 Erik Forsberg.
      4      1.1   andrew  * All rights reserved.
      5      1.1   andrew  *
      6      1.1   andrew  * Redistribution and use in source and binary forms, with or without
      7      1.1   andrew  * modification, are permitted provided that the following conditions
      8      1.1   andrew  * are met:
      9      1.1   andrew  * 1. Redistributions of source code must retain the above copyright
     10      1.1   andrew  *    notice, this list of conditions and the following disclaimer.
     11      1.1   andrew  *
     12      1.1   andrew  * THIS SOFTWARE IS PROVIDED BY ``AS IS'' AND ANY EXPRESS OR IMPLIED
     13      1.1   andrew  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
     14      1.1   andrew  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN
     15      1.1   andrew  * NO EVENT SHALL I BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
     16      1.1   andrew  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
     17      1.1   andrew  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
     18      1.1   andrew  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
     19      1.1   andrew  * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
     20      1.1   andrew  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
     21      1.1   andrew  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     22      1.1   andrew  *
     23  1.6.2.6  mycroft  *	$Id: mms.c,v 1.6.2.6 1993/10/07 14:48:42 mycroft Exp $
     24      1.1   andrew  */
     25      1.1   andrew 
     26      1.1   andrew #include "param.h"
     27      1.1   andrew #include "kernel.h"
     28      1.1   andrew #include "systm.h"
     29      1.1   andrew #include "buf.h"
     30      1.1   andrew #include "malloc.h"
     31      1.1   andrew #include "ioctl.h"
     32      1.1   andrew #include "tty.h"
     33      1.1   andrew #include "file.h"
     34      1.1   andrew #include "select.h"
     35      1.1   andrew #include "proc.h"
     36      1.1   andrew #include "vnode.h"
     37  1.6.2.1  mycroft #include "sys/device.h"
     38  1.6.2.4  mycroft #include "machine/cpu.h"
     39      1.1   andrew 
     40  1.6.2.1  mycroft #include "i386/isa/isavar.h"
     41  1.6.2.3  mycroft #include "i386/isa/icu.h"
     42      1.1   andrew #include "i386/include/mouse.h"
     43  1.6.2.1  mycroft #include "i386/include/pio.h"
     44      1.1   andrew 
     45  1.6.2.1  mycroft #define MMS_ADDR	0	/* Offset for register select */
     46  1.6.2.1  mycroft #define MMS_DATA	1	/* Offset for InPort data */
     47  1.6.2.1  mycroft #define MMS_IDENT	2	/* Offset for identification register */
     48  1.6.2.1  mycroft #define	MMS_NPORTS	4
     49  1.6.2.1  mycroft 
     50  1.6.2.1  mycroft #define	MMS_CHUNK	128	/* chunk size for read */
     51  1.6.2.5  mycroft #define	MMS_BSIZE	1020	/* buffer size */
     52  1.6.2.1  mycroft 
     53  1.6.2.1  mycroft struct mms_softc {		/* Driver status information */
     54  1.6.2.2  mycroft 	struct	device sc_dev;
     55  1.6.2.2  mycroft 	struct	isadev sc_id;
     56  1.6.2.2  mycroft 	struct	intrhand sc_ih;
     57  1.6.2.2  mycroft 
     58  1.6.2.5  mycroft 	struct	clist sc_q;
     59  1.6.2.1  mycroft 	struct	selinfo sc_rsel;
     60  1.6.2.1  mycroft 	u_short	sc_iobase;	/* I/O port base */
     61  1.6.2.1  mycroft 	u_char	sc_state;	/* Mouse driver state */
     62  1.6.2.1  mycroft #define MMS_OPEN	0x01	/* Device is open */
     63  1.6.2.1  mycroft #define MMS_ASLP	0x02	/* Waiting for mouse data */
     64  1.6.2.1  mycroft 	u_char	sc_status;	/* Mouse button status */
     65  1.6.2.1  mycroft 	int	sc_x, sc_y;	/* accumulated motion in the X,Y axis */
     66      1.1   andrew };
     67      1.1   andrew 
     68  1.6.2.1  mycroft static int mmsprobe __P((struct device *, struct cfdata *, void *));
     69  1.6.2.1  mycroft static void mmsforceintr __P((void *));
     70  1.6.2.1  mycroft static void mmsattach __P((struct device *, struct device *, void *));
     71  1.6.2.1  mycroft static int mmsintr __P((void *));
     72      1.1   andrew 
     73  1.6.2.1  mycroft struct cfdriver mmscd =
     74  1.6.2.1  mycroft { NULL, "mms", mmsprobe, mmsattach, sizeof (struct mms_softc) };
     75      1.1   andrew 
     76  1.6.2.5  mycroft #define MMSUNIT(dev)	(minor(dev))
     77      1.1   andrew 
     78  1.6.2.1  mycroft static int
     79  1.6.2.1  mycroft mmsprobe(parent, cf, aux)
     80  1.6.2.1  mycroft 	struct device *parent;
     81  1.6.2.1  mycroft 	struct cfdata *cf;
     82  1.6.2.1  mycroft 	void *aux;
     83      1.1   andrew {
     84  1.6.2.1  mycroft 	struct	isa_attach_args *ia = aux;
     85  1.6.2.1  mycroft 	u_short	iobase = ia->ia_iobase;
     86      1.1   andrew 
     87  1.6.2.3  mycroft 	if (iobase == IOBASEUNK)
     88  1.6.2.3  mycroft 		return 0;
     89  1.6.2.3  mycroft 
     90      1.1   andrew 	/* Read identification register to see if present */
     91  1.6.2.1  mycroft 	if (inb(iobase + MMS_IDENT) != 0xde)
     92  1.6.2.1  mycroft 		return 0;
     93      1.1   andrew 
     94      1.1   andrew 	/* Seems it was there; reset */
     95  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x87);
     96      1.1   andrew 
     97  1.6.2.3  mycroft 	if (ia->ia_irq == IRQUNK) {
     98  1.6.2.3  mycroft 		ia->ia_irq = isa_discoverintr(mmsforceintr, aux);
     99  1.6.2.3  mycroft 		if (ia->ia_irq == IRQNONE)
    100  1.6.2.3  mycroft 			return 0;
    101  1.6.2.3  mycroft 	}
    102      1.1   andrew 
    103  1.6.2.1  mycroft 	/* reset again to disable interrupts */
    104  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x87);
    105      1.1   andrew 
    106  1.6.2.1  mycroft 	ia->ia_iosize = MMS_NPORTS;
    107  1.6.2.1  mycroft 	ia->ia_drq = DRQUNK;
    108  1.6.2.1  mycroft 	ia->ia_msize = 0;
    109  1.6.2.1  mycroft 	return 1;
    110      1.1   andrew }
    111      1.1   andrew 
    112  1.6.2.1  mycroft static void
    113  1.6.2.1  mycroft mmsforceintr(aux)
    114  1.6.2.1  mycroft 	void *aux;
    115      1.1   andrew {
    116  1.6.2.1  mycroft 	struct	isa_attach_args *ia = aux;
    117  1.6.2.1  mycroft 	u_short	iobase = ia->ia_iobase;
    118      1.1   andrew 
    119  1.6.2.1  mycroft 	/* enable interrupts; expect to get one in 1/60 second */
    120  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x07);
    121  1.6.2.1  mycroft 	outb(iobase + MMS_DATA, 0x09);
    122      1.1   andrew }
    123      1.1   andrew 
    124  1.6.2.1  mycroft static void
    125  1.6.2.1  mycroft mmsattach(parent, self, aux)
    126  1.6.2.1  mycroft 	struct device *parent, *self;
    127  1.6.2.1  mycroft 	void *aux;
    128      1.1   andrew {
    129  1.6.2.1  mycroft 	struct	mms_softc *sc = (struct mms_softc *)self;
    130  1.6.2.1  mycroft 	struct	isa_attach_args *ia = aux;
    131  1.6.2.1  mycroft 	u_short	iobase = ia->ia_iobase;
    132  1.6.2.1  mycroft 
    133  1.6.2.1  mycroft 	/* other initialization done by mmsprobe */
    134  1.6.2.1  mycroft 	sc->sc_iobase = iobase;
    135  1.6.2.1  mycroft 	sc->sc_state = 0;
    136      1.1   andrew 
    137  1.6.2.2  mycroft 	printf(": Microsoft mouse\n");
    138  1.6.2.3  mycroft 	isa_establish(&sc->sc_id, &sc->sc_dev);
    139  1.6.2.2  mycroft 
    140  1.6.2.3  mycroft 	sc->sc_ih.ih_fun = mmsintr;
    141  1.6.2.3  mycroft 	sc->sc_ih.ih_arg = sc;
    142  1.6.2.3  mycroft 	intr_establish(ia->ia_irq, &sc->sc_ih, DV_TTY);
    143  1.6.2.1  mycroft }
    144      1.1   andrew 
    145  1.6.2.1  mycroft int
    146  1.6.2.1  mycroft mmsopen(dev, flag)
    147  1.6.2.1  mycroft 	dev_t dev;
    148  1.6.2.1  mycroft 	int flag;
    149  1.6.2.1  mycroft {
    150  1.6.2.1  mycroft 	int	unit = MMSUNIT(dev);
    151  1.6.2.1  mycroft 	struct	mms_softc *sc;
    152  1.6.2.1  mycroft 	u_short	iobase;
    153  1.6.2.1  mycroft 
    154  1.6.2.1  mycroft 	if (unit >= mmscd.cd_ndevs)
    155  1.6.2.1  mycroft 		return ENXIO;
    156  1.6.2.2  mycroft 	sc = mmscd.cd_devs[unit];
    157  1.6.2.1  mycroft 	if (!sc)
    158  1.6.2.1  mycroft 		return ENXIO;
    159  1.6.2.1  mycroft 
    160  1.6.2.1  mycroft 	if (sc->sc_state & MMS_OPEN)
    161  1.6.2.1  mycroft 		return EBUSY;
    162  1.6.2.1  mycroft 
    163  1.6.2.5  mycroft 	if (clalloc(&sc->sc_q, MMS_BSIZE, 0) == -1)
    164  1.6.2.5  mycroft 		return ENOMEM;
    165  1.6.2.5  mycroft 
    166  1.6.2.1  mycroft 	sc->sc_state |= MMS_OPEN;
    167  1.6.2.1  mycroft 	sc->sc_status = 0;
    168  1.6.2.1  mycroft 	sc->sc_x = sc->sc_y = 0;
    169  1.6.2.1  mycroft 
    170  1.6.2.1  mycroft 	/* enable interrupts */
    171  1.6.2.1  mycroft 	iobase = sc->sc_iobase;
    172  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x07);
    173  1.6.2.1  mycroft 	outb(iobase + MMS_DATA, 0x09);
    174      1.1   andrew 
    175  1.6.2.1  mycroft 	return 0;
    176  1.6.2.1  mycroft }
    177      1.1   andrew 
    178  1.6.2.1  mycroft int
    179  1.6.2.1  mycroft mmsclose(dev, flag)
    180  1.6.2.1  mycroft 	dev_t dev;
    181  1.6.2.1  mycroft 	int flag;
    182  1.6.2.1  mycroft {
    183  1.6.2.1  mycroft 	int	unit = MMSUNIT(dev);
    184  1.6.2.2  mycroft 	struct	mms_softc *sc = mmscd.cd_devs[unit];
    185      1.1   andrew 
    186  1.6.2.1  mycroft 	/* disable interrupts */
    187  1.6.2.1  mycroft 	outb(sc->sc_iobase + MMS_ADDR, 0x87);
    188      1.1   andrew 
    189  1.6.2.1  mycroft 	sc->sc_state &= ~MMS_OPEN;
    190      1.1   andrew 
    191  1.6.2.5  mycroft 	clfree(&sc->sc_q);
    192  1.6.2.5  mycroft 
    193  1.6.2.1  mycroft 	return 0;
    194      1.1   andrew }
    195      1.1   andrew 
    196  1.6.2.1  mycroft int
    197  1.6.2.1  mycroft mmsread(dev, uio, flag)
    198  1.6.2.1  mycroft 	dev_t dev;
    199  1.6.2.1  mycroft 	struct uio *uio;
    200  1.6.2.1  mycroft 	int flag;
    201      1.1   andrew {
    202  1.6.2.1  mycroft 	int	unit = MMSUNIT(dev);
    203  1.6.2.2  mycroft 	struct	mms_softc *sc = mmscd.cd_devs[unit];
    204  1.6.2.1  mycroft 	int	s;
    205  1.6.2.1  mycroft 	int	error;
    206  1.6.2.1  mycroft 	size_t	length;
    207  1.6.2.1  mycroft 	u_char	buffer[MMS_CHUNK];
    208      1.1   andrew 
    209      1.1   andrew 	/* Block until mouse activity occured */
    210      1.1   andrew 
    211      1.1   andrew 	s = spltty();
    212  1.6.2.5  mycroft 	while (sc->sc_q.c_cc == 0) {
    213  1.6.2.5  mycroft 		if (flag & IO_NDELAY) {
    214      1.1   andrew 			splx(s);
    215  1.6.2.1  mycroft 			return EWOULDBLOCK;
    216      1.1   andrew 		}
    217  1.6.2.1  mycroft 		sc->sc_state |= MMS_ASLP;
    218  1.6.2.1  mycroft 		if (error = tsleep((caddr_t)sc, PZERO | PCATCH, "mmsrea", 0)) {
    219  1.6.2.1  mycroft 			sc->sc_state &= ~MMS_ASLP;
    220      1.1   andrew 			splx(s);
    221  1.6.2.1  mycroft 			return error;
    222      1.1   andrew 		}
    223      1.1   andrew 	}
    224      1.1   andrew 
    225      1.1   andrew 	/* Transfer as many chunks as possible */
    226      1.1   andrew 
    227  1.6.2.5  mycroft 	while (sc->sc_q.c_cc > 0 && uio->uio_resid > 0) {
    228  1.6.2.5  mycroft 		length = min(sc->sc_q.c_cc, uio->uio_resid);
    229      1.1   andrew 		if (length > sizeof(buffer))
    230      1.1   andrew 			length = sizeof(buffer);
    231      1.1   andrew 
    232  1.6.2.5  mycroft 		/* remove a small chunk from input queue */
    233  1.6.2.5  mycroft 		(void) q_to_b(&sc->sc_q, buffer, length);
    234      1.1   andrew 
    235  1.6.2.5  mycroft 		/* copy data to user process */
    236  1.6.2.1  mycroft 		if (error = uiomove(buffer, length, uio))
    237      1.1   andrew 			break;
    238      1.1   andrew 	}
    239      1.1   andrew 
    240  1.6.2.1  mycroft 	/* reset counters */
    241  1.6.2.1  mycroft 	sc->sc_x = sc->sc_y = 0;
    242      1.1   andrew 
    243      1.1   andrew 	splx(s);
    244  1.6.2.1  mycroft 	return error;
    245      1.1   andrew }
    246      1.1   andrew 
    247  1.6.2.1  mycroft int
    248  1.6.2.1  mycroft mmsioctl(dev, cmd, addr, flag)
    249  1.6.2.1  mycroft 	dev_t dev;
    250  1.6.2.1  mycroft 	int cmd;
    251  1.6.2.1  mycroft 	caddr_t addr;
    252  1.6.2.1  mycroft 	int flag;
    253      1.1   andrew {
    254  1.6.2.1  mycroft 	int	unit = MMSUNIT(dev);
    255  1.6.2.2  mycroft 	struct	mms_softc *sc = mmscd.cd_devs[unit];
    256  1.6.2.1  mycroft 	struct	mouseinfo info;
    257  1.6.2.1  mycroft 	int	s;
    258  1.6.2.1  mycroft 	int	error;
    259      1.1   andrew 
    260      1.1   andrew 	switch (cmd) {
    261  1.6.2.1  mycroft 	    case MOUSEIOCREAD:
    262      1.1   andrew 		s = spltty();
    263      1.1   andrew 
    264  1.6.2.1  mycroft 		info.status = sc->sc_status;
    265  1.6.2.1  mycroft 		if (sc->sc_x || sc->sc_y)
    266      1.1   andrew 			info.status |= MOVEMENT;
    267      1.1   andrew 
    268  1.6.2.1  mycroft 		if (sc->sc_x > 127)
    269      1.1   andrew 			info.xmotion = 127;
    270  1.6.2.1  mycroft 		else if (sc->sc_x < -127)
    271  1.6.2.1  mycroft 			/* bounding at -127 avoids a bug in XFree86 */
    272  1.6.2.1  mycroft 			info.xmotion = -127;
    273      1.1   andrew 		else
    274  1.6.2.1  mycroft 			info.xmotion = sc->sc_x;
    275      1.1   andrew 
    276  1.6.2.1  mycroft 		if (sc->sc_y > 127)
    277      1.1   andrew 			info.ymotion = 127;
    278  1.6.2.1  mycroft 		else if (sc->sc_y < -127)
    279  1.6.2.1  mycroft 			info.ymotion = -127;
    280      1.1   andrew 		else
    281  1.6.2.1  mycroft 			info.ymotion = sc->sc_y;
    282      1.1   andrew 
    283  1.6.2.5  mycroft 		/* reset historical information */
    284  1.6.2.1  mycroft 		sc->sc_x = 0;
    285  1.6.2.1  mycroft 		sc->sc_y = 0;
    286  1.6.2.1  mycroft 		sc->sc_status &= ~BUTCHNGMASK;
    287  1.6.2.5  mycroft 		flushq(&sc->sc_q);
    288      1.1   andrew 
    289      1.1   andrew 		splx(s);
    290      1.1   andrew 		error = copyout(&info, addr, sizeof(struct mouseinfo));
    291      1.1   andrew 		break;
    292      1.1   andrew 
    293  1.6.2.1  mycroft 	    default:
    294      1.1   andrew 		error = EINVAL;
    295      1.1   andrew 		break;
    296  1.6.2.1  mycroft 	}
    297      1.1   andrew 
    298  1.6.2.1  mycroft 	return error;
    299      1.1   andrew }
    300      1.1   andrew 
    301  1.6.2.1  mycroft int
    302  1.6.2.1  mycroft mmsintr(arg)
    303  1.6.2.1  mycroft 	void *arg;
    304      1.1   andrew {
    305  1.6.2.1  mycroft 	struct	mms_softc *sc = (struct mms_softc *)arg;
    306  1.6.2.1  mycroft 	u_short	iobase = sc->sc_iobase;
    307  1.6.2.1  mycroft 	u_char	buttons, changed, status;
    308  1.6.2.1  mycroft 	char	dx, dy;
    309  1.6.2.5  mycroft 	u_char	buffer[5];
    310  1.6.2.1  mycroft 
    311  1.6.2.1  mycroft 	if ((sc->sc_state & MMS_OPEN) == 0)
    312  1.6.2.1  mycroft 		/* interrupts not expected */
    313  1.6.2.1  mycroft 		return 0;
    314      1.1   andrew 
    315      1.1   andrew 	/* Freeze InPort registers (disabling interrupts) */
    316  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x07);
    317  1.6.2.1  mycroft 	outb(iobase + MMS_DATA, 0x29);
    318      1.1   andrew 
    319  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0);
    320  1.6.2.1  mycroft 	status = inb(iobase + MMS_DATA);
    321      1.1   andrew 
    322      1.1   andrew 	if (status & 0x40) {
    323  1.6.2.1  mycroft 		outb(iobase + MMS_ADDR, 1);
    324  1.6.2.1  mycroft 		dx = inb(iobase + MMS_DATA);
    325  1.6.2.1  mycroft 		dx = (dx == -128) ? -127 : dx;
    326  1.6.2.1  mycroft 		outb(iobase + MMS_ADDR, 2);
    327  1.6.2.1  mycroft 		dy = inb(iobase + MMS_DATA);
    328      1.1   andrew 		dy = (dy == -128) ? 127 : -dy;
    329  1.6.2.1  mycroft 	} else
    330      1.1   andrew 		dx = dy = 0;
    331      1.1   andrew 
    332      1.1   andrew 	/* Unfreeze InPort Registers (re-enables interrupts) */
    333  1.6.2.1  mycroft 	outb(iobase + MMS_ADDR, 0x07);
    334  1.6.2.1  mycroft 	outb(iobase + MMS_DATA, 0x09);
    335      1.1   andrew 
    336  1.6.2.1  mycroft 	buttons = status & BUTSTATMASK;
    337  1.6.2.1  mycroft 	changed = status & BUTCHNGMASK;
    338  1.6.2.1  mycroft 	sc->sc_status = buttons | (sc->sc_status & ~BUTSTATMASK) | changed;
    339  1.6.2.1  mycroft 
    340  1.6.2.1  mycroft 	if (dx || dy || changed) {
    341  1.6.2.5  mycroft 		/* update accumulated movements */
    342  1.6.2.1  mycroft 		sc->sc_x += dx;
    343  1.6.2.1  mycroft 		sc->sc_y += dy;
    344  1.6.2.1  mycroft 
    345  1.6.2.5  mycroft 		buffer[0] = 0x80 | (~status & BUTSTATMASK);
    346  1.6.2.5  mycroft 		buffer[1] = dx;
    347  1.6.2.5  mycroft 		buffer[2] = dy;
    348  1.6.2.5  mycroft 		buffer[3] = buffer[4] = 0;
    349  1.6.2.5  mycroft 		(void) b_to_q(buffer, sizeof buffer, &sc->sc_q);
    350      1.1   andrew 
    351  1.6.2.1  mycroft 		if (sc->sc_state & MMS_ASLP) {
    352  1.6.2.1  mycroft 			sc->sc_state &= ~MMS_ASLP;
    353      1.5   andrew 			wakeup((caddr_t)sc);
    354      1.1   andrew 		}
    355  1.6.2.1  mycroft 		selwakeup(&sc->sc_rsel);
    356  1.6.2.1  mycroft 	}
    357  1.6.2.1  mycroft 
    358  1.6.2.1  mycroft 	return 1;
    359      1.1   andrew }
    360      1.1   andrew 
    361  1.6.2.1  mycroft int
    362  1.6.2.1  mycroft mmsselect(dev, rw, p)
    363  1.6.2.1  mycroft 	dev_t dev;
    364  1.6.2.1  mycroft 	int rw;
    365  1.6.2.1  mycroft 	struct proc *p;
    366      1.1   andrew {
    367  1.6.2.1  mycroft 	int	unit = MMSUNIT(dev);
    368  1.6.2.2  mycroft 	struct	mms_softc *sc = mmscd.cd_devs[unit];
    369  1.6.2.1  mycroft 	int	s;
    370  1.6.2.1  mycroft 	int	ret;
    371      1.1   andrew 
    372      1.1   andrew 	if (rw == FWRITE)
    373  1.6.2.1  mycroft 		return 0;
    374      1.1   andrew 
    375      1.1   andrew 	s = spltty();
    376  1.6.2.5  mycroft 	if (sc->sc_q.c_cc)
    377      1.1   andrew 		ret = 1;
    378      1.1   andrew 	else {
    379  1.6.2.1  mycroft 		selrecord(p, &sc->sc_rsel);
    380      1.1   andrew 		ret = 0;
    381      1.1   andrew 	}
    382      1.1   andrew 	splx(s);
    383      1.1   andrew 
    384  1.6.2.1  mycroft 	return ret;
    385      1.1   andrew }
    386