ki2c.c revision 1.23 1 1.23 macallan /* $NetBSD: ki2c.c,v 1.23 2017/09/27 22:10:19 macallan Exp $ */
2 1.1 grant /* Id: ki2c.c,v 1.7 2002/10/05 09:56:05 tsubai Exp */
3 1.1 grant
4 1.1 grant /*-
5 1.1 grant * Copyright (c) 2001 Tsubai Masanari. All rights reserved.
6 1.1 grant *
7 1.1 grant * Redistribution and use in source and binary forms, with or without
8 1.1 grant * modification, are permitted provided that the following conditions
9 1.1 grant * are met:
10 1.1 grant * 1. Redistributions of source code must retain the above copyright
11 1.1 grant * notice, this list of conditions and the following disclaimer.
12 1.1 grant * 2. Redistributions in binary form must reproduce the above copyright
13 1.1 grant * notice, this list of conditions and the following disclaimer in the
14 1.1 grant * documentation and/or other materials provided with the distribution.
15 1.1 grant * 3. The name of the author may not be used to endorse or promote products
16 1.1 grant * derived from this software without specific prior written permission.
17 1.1 grant *
18 1.1 grant * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
19 1.1 grant * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
20 1.1 grant * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
21 1.1 grant * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
22 1.1 grant * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
23 1.1 grant * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 1.1 grant * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 1.1 grant * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 1.1 grant * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 1.1 grant * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 1.1 grant */
29 1.1 grant
30 1.1 grant #include <sys/param.h>
31 1.1 grant #include <sys/device.h>
32 1.1 grant #include <sys/systm.h>
33 1.11 ad #include <sys/mutex.h>
34 1.1 grant
35 1.1 grant #include <dev/ofw/openfirm.h>
36 1.1 grant #include <machine/autoconf.h>
37 1.1 grant
38 1.3 macallan #include <macppc/dev/ki2cvar.h>
39 1.1 grant
40 1.20 macallan #ifdef KI2C_DEBUG
41 1.20 macallan #define DPRINTF printf
42 1.20 macallan #else
43 1.20 macallan #define DPRINTF while (0) printf
44 1.20 macallan #endif
45 1.20 macallan
46 1.17 matt int ki2c_match(device_t, cfdata_t, void *);
47 1.17 matt void ki2c_attach(device_t, device_t, void *);
48 1.21 macallan inline uint8_t ki2c_readreg(struct ki2c_softc *, int);
49 1.21 macallan inline void ki2c_writereg(struct ki2c_softc *, int, uint8_t);
50 1.1 grant u_int ki2c_getmode(struct ki2c_softc *);
51 1.1 grant void ki2c_setmode(struct ki2c_softc *, u_int);
52 1.1 grant u_int ki2c_getspeed(struct ki2c_softc *);
53 1.1 grant void ki2c_setspeed(struct ki2c_softc *, u_int);
54 1.1 grant int ki2c_intr(struct ki2c_softc *);
55 1.1 grant int ki2c_poll(struct ki2c_softc *, int);
56 1.1 grant int ki2c_start(struct ki2c_softc *, int, int, void *, int);
57 1.1 grant int ki2c_read(struct ki2c_softc *, int, int, void *, int);
58 1.3 macallan int ki2c_write(struct ki2c_softc *, int, int, void *, int);
59 1.3 macallan
60 1.3 macallan /* I2C glue */
61 1.3 macallan static int ki2c_i2c_acquire_bus(void *, int);
62 1.3 macallan static void ki2c_i2c_release_bus(void *, int);
63 1.3 macallan static int ki2c_i2c_exec(void *, i2c_op_t, i2c_addr_t, const void *, size_t,
64 1.3 macallan void *, size_t, int);
65 1.3 macallan
66 1.1 grant
67 1.18 macallan CFATTACH_DECL_NEW(ki2c, sizeof(struct ki2c_softc), ki2c_match, ki2c_attach,
68 1.9 dogcow NULL, NULL);
69 1.1 grant
70 1.1 grant int
71 1.17 matt ki2c_match(device_t parent, cfdata_t match, void *aux)
72 1.1 grant {
73 1.1 grant struct confargs *ca = aux;
74 1.1 grant
75 1.1 grant if (strcmp(ca->ca_name, "i2c") == 0)
76 1.1 grant return 1;
77 1.1 grant
78 1.1 grant return 0;
79 1.1 grant }
80 1.1 grant
81 1.1 grant void
82 1.17 matt ki2c_attach(device_t parent, device_t self, void *aux)
83 1.1 grant {
84 1.17 matt struct ki2c_softc *sc = device_private(self);
85 1.1 grant struct confargs *ca = aux;
86 1.1 grant int node = ca->ca_node;
87 1.20 macallan uint32_t addr;
88 1.22 macallan int rate, child, /*namelen,*/ i2cbus;
89 1.3 macallan struct i2cbus_attach_args iba;
90 1.20 macallan prop_dictionary_t dict = device_properties(self);
91 1.20 macallan prop_array_t cfg;
92 1.22 macallan int devs;
93 1.22 macallan char compat[256];
94 1.22 macallan prop_dictionary_t dev;
95 1.22 macallan prop_data_t data;
96 1.3 macallan char name[32];
97 1.18 macallan
98 1.18 macallan sc->sc_dev = self;
99 1.21 macallan sc->sc_tag = ca->ca_tag;
100 1.1 grant ca->ca_reg[0] += ca->ca_baseaddr;
101 1.1 grant
102 1.1 grant if (OF_getprop(node, "AAPL,i2c-rate", &rate, 4) != 4) {
103 1.20 macallan aprint_error(": cannot get i2c-rate\n");
104 1.1 grant return;
105 1.1 grant }
106 1.20 macallan if (OF_getprop(node, "AAPL,address", &addr, 4) != 4) {
107 1.20 macallan aprint_error(": unable to find i2c address\n");
108 1.1 grant return;
109 1.1 grant }
110 1.21 macallan if (bus_space_map(sc->sc_tag, addr, PAGE_SIZE, 0, &sc->sc_bh) != 0) {
111 1.21 macallan aprint_error_dev(sc->sc_dev, "failed to map registers\n");
112 1.21 macallan return;
113 1.21 macallan }
114 1.21 macallan
115 1.1 grant if (OF_getprop(node, "AAPL,address-step", &sc->sc_regstep, 4) != 4) {
116 1.20 macallan aprint_error(": unable to find i2c address step\n");
117 1.1 grant return;
118 1.1 grant }
119 1.1 grant
120 1.1 grant printf("\n");
121 1.1 grant
122 1.1 grant ki2c_writereg(sc, STATUS, 0);
123 1.1 grant ki2c_writereg(sc, ISR, 0);
124 1.1 grant ki2c_writereg(sc, IER, 0);
125 1.1 grant
126 1.1 grant ki2c_setmode(sc, I2C_STDSUBMODE);
127 1.1 grant ki2c_setspeed(sc, I2C_100kHz); /* XXX rate */
128 1.3 macallan
129 1.11 ad mutex_init(&sc->sc_buslock, MUTEX_DEFAULT, IPL_NONE);
130 1.3 macallan ki2c_writereg(sc, IER,I2C_INT_DATA|I2C_INT_ADDR|I2C_INT_STOP);
131 1.3 macallan
132 1.20 macallan cfg = prop_array_create();
133 1.20 macallan prop_dictionary_set(dict, "i2c-child-devices", cfg);
134 1.20 macallan prop_object_release(cfg);
135 1.20 macallan
136 1.4 macallan /*
137 1.4 macallan * newer OF puts I2C devices under 'i2c-bus' instead of attaching them
138 1.4 macallan * directly to the ki2c node so we just check if we have a child named
139 1.4 macallan * 'i2c-bus' and if so we attach its children, not ours
140 1.4 macallan */
141 1.4 macallan i2cbus = 0;
142 1.4 macallan child = OF_child(node);
143 1.4 macallan while ((child != 0) && (i2cbus == 0)) {
144 1.4 macallan OF_getprop(child, "name", name, sizeof(name));
145 1.4 macallan if (strcmp(name, "i2c-bus") == 0)
146 1.4 macallan i2cbus = child;
147 1.4 macallan child = OF_peer(child);
148 1.4 macallan }
149 1.4 macallan if (i2cbus == 0)
150 1.4 macallan i2cbus = node;
151 1.22 macallan
152 1.22 macallan devs = OF_child(i2cbus);
153 1.22 macallan while (devs != 0) {
154 1.22 macallan if (OF_getprop(devs, "name", name, 32) == 0)
155 1.22 macallan goto skip;
156 1.22 macallan if (OF_getprop(devs, "compatible", compat, 256) == 0) {
157 1.22 macallan /* some i2c device nodes don't have 'compatible' */
158 1.22 macallan memset(compat, 0, 256);
159 1.22 macallan strncpy(compat, name, 256);
160 1.10 garbled }
161 1.22 macallan if (OF_getprop(devs, "reg", &addr, 4) == 0)
162 1.22 macallan if (OF_getprop(devs, "i2c-address", &addr, 4) == 0)
163 1.22 macallan goto skip;
164 1.22 macallan addr = (addr & 0xff) >> 1;
165 1.22 macallan DPRINTF("-> %s@%x\n", name, addr);
166 1.22 macallan dev = prop_dictionary_create();
167 1.22 macallan prop_dictionary_set_cstring(dev, "name", name);
168 1.22 macallan data = prop_data_create_data(compat, strlen(compat)+1);
169 1.22 macallan prop_dictionary_set(dev, "compatible", data);
170 1.22 macallan prop_object_release(data);
171 1.22 macallan prop_dictionary_set_uint32(dev, "addr", addr);
172 1.23 macallan prop_dictionary_set_uint64(dev, "cookie", devs);
173 1.22 macallan prop_array_add(cfg, dev);
174 1.22 macallan prop_object_release(dev);
175 1.22 macallan skip:
176 1.22 macallan devs = OF_peer(devs);
177 1.3 macallan }
178 1.3 macallan
179 1.22 macallan /* fill in the i2c tag */
180 1.22 macallan sc->sc_i2c.ic_cookie = sc;
181 1.22 macallan sc->sc_i2c.ic_acquire_bus = ki2c_i2c_acquire_bus;
182 1.22 macallan sc->sc_i2c.ic_release_bus = ki2c_i2c_release_bus;
183 1.22 macallan sc->sc_i2c.ic_send_start = NULL;
184 1.22 macallan sc->sc_i2c.ic_send_stop = NULL;
185 1.22 macallan sc->sc_i2c.ic_initiate_xfer = NULL;
186 1.22 macallan sc->sc_i2c.ic_read_byte = NULL;
187 1.22 macallan sc->sc_i2c.ic_write_byte = NULL;
188 1.22 macallan sc->sc_i2c.ic_exec = ki2c_i2c_exec;
189 1.3 macallan
190 1.22 macallan memset(&iba, 0, sizeof(iba));
191 1.22 macallan iba.iba_tag = &sc->sc_i2c;
192 1.22 macallan (void) config_found_ia(sc->sc_dev, "i2cbus", &iba, iicbus_print);
193 1.22 macallan
194 1.1 grant }
195 1.1 grant
196 1.21 macallan uint8_t
197 1.14 dsl ki2c_readreg(struct ki2c_softc *sc, int reg)
198 1.1 grant {
199 1.1 grant
200 1.21 macallan return bus_space_read_1(sc->sc_tag, sc->sc_bh, sc->sc_regstep * reg);
201 1.1 grant }
202 1.1 grant
203 1.1 grant void
204 1.21 macallan ki2c_writereg(struct ki2c_softc *sc, int reg, uint8_t val)
205 1.1 grant {
206 1.21 macallan
207 1.21 macallan bus_space_write_1(sc->sc_tag, sc->sc_bh, reg * sc->sc_regstep, val);
208 1.1 grant delay(10);
209 1.1 grant }
210 1.1 grant
211 1.1 grant u_int
212 1.14 dsl ki2c_getmode(struct ki2c_softc *sc)
213 1.1 grant {
214 1.1 grant return ki2c_readreg(sc, MODE) & I2C_MODE;
215 1.1 grant }
216 1.1 grant
217 1.1 grant void
218 1.14 dsl ki2c_setmode(struct ki2c_softc *sc, u_int mode)
219 1.1 grant {
220 1.1 grant u_int x;
221 1.1 grant
222 1.1 grant KASSERT((mode & ~I2C_MODE) == 0);
223 1.1 grant x = ki2c_readreg(sc, MODE);
224 1.1 grant x &= ~I2C_MODE;
225 1.1 grant x |= mode;
226 1.1 grant ki2c_writereg(sc, MODE, x);
227 1.1 grant }
228 1.1 grant
229 1.1 grant u_int
230 1.14 dsl ki2c_getspeed(struct ki2c_softc *sc)
231 1.1 grant {
232 1.1 grant return ki2c_readreg(sc, MODE) & I2C_SPEED;
233 1.1 grant }
234 1.1 grant
235 1.1 grant void
236 1.14 dsl ki2c_setspeed(struct ki2c_softc *sc, u_int speed)
237 1.1 grant {
238 1.1 grant u_int x;
239 1.1 grant
240 1.1 grant KASSERT((speed & ~I2C_SPEED) == 0);
241 1.1 grant x = ki2c_readreg(sc, MODE);
242 1.1 grant x &= ~I2C_SPEED;
243 1.1 grant x |= speed;
244 1.1 grant ki2c_writereg(sc, MODE, x);
245 1.1 grant }
246 1.1 grant
247 1.1 grant int
248 1.14 dsl ki2c_intr(struct ki2c_softc *sc)
249 1.1 grant {
250 1.1 grant u_int isr, x;
251 1.1 grant
252 1.1 grant isr = ki2c_readreg(sc, ISR);
253 1.1 grant if (isr & I2C_INT_ADDR) {
254 1.1 grant #if 0
255 1.1 grant if ((ki2c_readreg(sc, STATUS) & I2C_ST_LASTAAK) == 0) {
256 1.1 grant /* No slave responded. */
257 1.1 grant sc->sc_flags |= I2C_ERROR;
258 1.1 grant goto out;
259 1.1 grant }
260 1.1 grant #endif
261 1.1 grant
262 1.1 grant if (sc->sc_flags & I2C_READING) {
263 1.1 grant if (sc->sc_resid > 1) {
264 1.1 grant x = ki2c_readreg(sc, CONTROL);
265 1.1 grant x |= I2C_CT_AAK;
266 1.1 grant ki2c_writereg(sc, CONTROL, x);
267 1.1 grant }
268 1.1 grant } else {
269 1.1 grant ki2c_writereg(sc, DATA, *sc->sc_data++);
270 1.1 grant sc->sc_resid--;
271 1.1 grant }
272 1.1 grant }
273 1.1 grant
274 1.1 grant if (isr & I2C_INT_DATA) {
275 1.1 grant if (sc->sc_flags & I2C_READING) {
276 1.1 grant *sc->sc_data++ = ki2c_readreg(sc, DATA);
277 1.1 grant sc->sc_resid--;
278 1.1 grant
279 1.1 grant if (sc->sc_resid == 0) { /* Completed */
280 1.1 grant ki2c_writereg(sc, CONTROL, 0);
281 1.1 grant goto out;
282 1.1 grant }
283 1.1 grant } else {
284 1.1 grant #if 0
285 1.1 grant if ((ki2c_readreg(sc, STATUS) & I2C_ST_LASTAAK) == 0) {
286 1.1 grant /* No slave responded. */
287 1.1 grant sc->sc_flags |= I2C_ERROR;
288 1.1 grant goto out;
289 1.1 grant }
290 1.1 grant #endif
291 1.1 grant
292 1.1 grant if (sc->sc_resid == 0) {
293 1.1 grant x = ki2c_readreg(sc, CONTROL) | I2C_CT_STOP;
294 1.1 grant ki2c_writereg(sc, CONTROL, x);
295 1.1 grant } else {
296 1.1 grant ki2c_writereg(sc, DATA, *sc->sc_data++);
297 1.1 grant sc->sc_resid--;
298 1.1 grant }
299 1.1 grant }
300 1.1 grant }
301 1.1 grant
302 1.1 grant out:
303 1.1 grant if (isr & I2C_INT_STOP) {
304 1.1 grant ki2c_writereg(sc, CONTROL, 0);
305 1.1 grant sc->sc_flags &= ~I2C_BUSY;
306 1.1 grant }
307 1.1 grant
308 1.1 grant ki2c_writereg(sc, ISR, isr);
309 1.1 grant
310 1.1 grant return 1;
311 1.1 grant }
312 1.1 grant
313 1.1 grant int
314 1.14 dsl ki2c_poll(struct ki2c_softc *sc, int timo)
315 1.1 grant {
316 1.1 grant while (sc->sc_flags & I2C_BUSY) {
317 1.1 grant if (ki2c_readreg(sc, ISR))
318 1.1 grant ki2c_intr(sc);
319 1.1 grant timo -= 100;
320 1.1 grant if (timo < 0) {
321 1.20 macallan DPRINTF("i2c_poll: timeout\n");
322 1.1 grant return -1;
323 1.1 grant }
324 1.1 grant delay(100);
325 1.1 grant }
326 1.1 grant return 0;
327 1.1 grant }
328 1.1 grant
329 1.1 grant int
330 1.15 dsl ki2c_start(struct ki2c_softc *sc, int addr, int subaddr, void *data, int len)
331 1.1 grant {
332 1.1 grant int rw = (sc->sc_flags & I2C_READING) ? 1 : 0;
333 1.1 grant int timo, x;
334 1.1 grant
335 1.1 grant KASSERT((addr & 1) == 0);
336 1.1 grant
337 1.1 grant sc->sc_data = data;
338 1.1 grant sc->sc_resid = len;
339 1.1 grant sc->sc_flags |= I2C_BUSY;
340 1.1 grant
341 1.1 grant timo = 1000 + len * 200;
342 1.1 grant
343 1.1 grant /* XXX TAS3001 sometimes takes 50ms to finish writing registers. */
344 1.1 grant /* if (addr == 0x68) */
345 1.1 grant timo += 100000;
346 1.1 grant
347 1.1 grant ki2c_writereg(sc, ADDR, addr | rw);
348 1.1 grant ki2c_writereg(sc, SUBADDR, subaddr);
349 1.1 grant
350 1.1 grant x = ki2c_readreg(sc, CONTROL) | I2C_CT_ADDR;
351 1.1 grant ki2c_writereg(sc, CONTROL, x);
352 1.1 grant
353 1.1 grant if (ki2c_poll(sc, timo))
354 1.1 grant return -1;
355 1.1 grant if (sc->sc_flags & I2C_ERROR) {
356 1.20 macallan DPRINTF("I2C_ERROR\n");
357 1.1 grant return -1;
358 1.1 grant }
359 1.1 grant return 0;
360 1.1 grant }
361 1.1 grant
362 1.1 grant int
363 1.15 dsl ki2c_read(struct ki2c_softc *sc, int addr, int subaddr, void *data, int len)
364 1.1 grant {
365 1.1 grant sc->sc_flags = I2C_READING;
366 1.20 macallan DPRINTF("ki2c_read: %02x %d\n", addr, len);
367 1.1 grant return ki2c_start(sc, addr, subaddr, data, len);
368 1.1 grant }
369 1.1 grant
370 1.1 grant int
371 1.15 dsl ki2c_write(struct ki2c_softc *sc, int addr, int subaddr, void *data, int len)
372 1.1 grant {
373 1.1 grant sc->sc_flags = 0;
374 1.20 macallan DPRINTF("ki2c_write: %02x %d\n",addr,len);
375 1.3 macallan return ki2c_start(sc, addr, subaddr, data, len);
376 1.3 macallan }
377 1.3 macallan
378 1.3 macallan static int
379 1.3 macallan ki2c_i2c_acquire_bus(void *cookie, int flags)
380 1.3 macallan {
381 1.3 macallan struct ki2c_softc *sc = cookie;
382 1.3 macallan
383 1.11 ad mutex_enter(&sc->sc_buslock);
384 1.11 ad return 0;
385 1.3 macallan }
386 1.3 macallan
387 1.3 macallan static void
388 1.3 macallan ki2c_i2c_release_bus(void *cookie, int flags)
389 1.3 macallan {
390 1.3 macallan struct ki2c_softc *sc = cookie;
391 1.3 macallan
392 1.11 ad mutex_exit(&sc->sc_buslock);
393 1.3 macallan }
394 1.3 macallan
395 1.3 macallan int
396 1.3 macallan ki2c_i2c_exec(void *cookie, i2c_op_t op, i2c_addr_t addr, const void *vcmd,
397 1.3 macallan size_t cmdlen, void *vbuf, size_t buflen, int flags)
398 1.3 macallan {
399 1.3 macallan struct ki2c_softc *sc = cookie;
400 1.12 pgoyette int i;
401 1.12 pgoyette size_t w_len;
402 1.12 pgoyette uint8_t *wp;
403 1.12 pgoyette uint8_t wrbuf[I2C_EXEC_MAX_CMDLEN + I2C_EXEC_MAX_CMDLEN];
404 1.12 pgoyette
405 1.12 pgoyette /*
406 1.12 pgoyette * We don't have any idea if the ki2c controller can execute
407 1.12 pgoyette * i2c quick_{read,write} operations, so if someone tries one,
408 1.12 pgoyette * return an error.
409 1.12 pgoyette */
410 1.12 pgoyette if (cmdlen == 0 && buflen == 0)
411 1.12 pgoyette return -1;
412 1.12 pgoyette
413 1.3 macallan /* we handle the subaddress stuff ourselves */
414 1.3 macallan ki2c_setmode(sc, I2C_STDMODE);
415 1.3 macallan
416 1.12 pgoyette /* Write-buffer defaults to vcmd */
417 1.12 pgoyette wp = (uint8_t *)(__UNCONST(vcmd));
418 1.12 pgoyette w_len = cmdlen;
419 1.12 pgoyette
420 1.12 pgoyette /*
421 1.12 pgoyette * Concatenate vcmd and vbuf for write operations
422 1.12 pgoyette *
423 1.12 pgoyette * Drivers written specifically for ki2c might already do this,
424 1.12 pgoyette * but "generic" i2c drivers still provide separate arguments
425 1.12 pgoyette * for the cmd and buf parts of iic_smbus_write_{byte,word}.
426 1.12 pgoyette */
427 1.12 pgoyette if (I2C_OP_WRITE_P(op) && buflen != 0) {
428 1.12 pgoyette if (cmdlen == 0) {
429 1.12 pgoyette wp = (uint8_t *)vbuf;
430 1.12 pgoyette w_len = buflen;
431 1.12 pgoyette } else {
432 1.12 pgoyette KASSERT((cmdlen + buflen) <= sizeof(wrbuf));
433 1.12 pgoyette wp = (uint8_t *)(__UNCONST(vcmd));
434 1.12 pgoyette w_len = 0;
435 1.12 pgoyette for (i = 0; i < cmdlen; i++)
436 1.12 pgoyette wrbuf[w_len++] = *wp++;
437 1.12 pgoyette wp = (uint8_t *)vbuf;
438 1.12 pgoyette for (i = 0; i < buflen; i++)
439 1.12 pgoyette wrbuf[w_len++] = *wp++;
440 1.12 pgoyette wp = wrbuf;
441 1.12 pgoyette }
442 1.12 pgoyette }
443 1.12 pgoyette
444 1.22 macallan if (w_len > 0)
445 1.22 macallan if (ki2c_write(sc, addr << 1, 0, wp, w_len) !=0 )
446 1.22 macallan return -1;
447 1.10 garbled
448 1.10 garbled if (I2C_OP_READ_P(op)) {
449 1.20 macallan if (ki2c_read(sc, addr << 1, 0, vbuf, buflen) !=0 )
450 1.3 macallan return -1;
451 1.3 macallan }
452 1.3 macallan return 0;
453 1.1 grant }
454