Home | History | Annotate | Line # | Download | only in i2c
gttwsi_core.c revision 1.7.2.2
      1  1.7.2.2    martin /*	$NetBSD: gttwsi_core.c,v 1.7.2.2 2020/04/08 14:08:05 martin Exp $	*/
      2      1.1      matt /*
      3      1.1      matt  * Copyright (c) 2008 Eiji Kawauchi.
      4      1.1      matt  * All rights reserved.
      5      1.1      matt  *
      6      1.1      matt  * Redistribution and use in source and binary forms, with or without
      7      1.1      matt  * modification, are permitted provided that the following conditions
      8      1.1      matt  * are met:
      9      1.1      matt  * 1. Redistributions of source code must retain the above copyright
     10      1.1      matt  *    notice, this list of conditions and the following disclaimer.
     11      1.1      matt  * 2. Redistributions in binary form must reproduce the above copyright
     12      1.1      matt  *    notice, this list of conditions and the following disclaimer in the
     13      1.1      matt  *    documentation and/or other materials provided with the distribution.
     14      1.1      matt  * 3. All advertising materials mentioning features or use of this software
     15      1.1      matt  *    must display the following acknowledgement:
     16      1.1      matt  *      This product includes software developed for the NetBSD Project by
     17      1.1      matt  *      Eiji Kawauchi.
     18      1.1      matt  * 4. The name of the author may not be used to endorse or promote products
     19      1.1      matt  *    derived from this software without specific prior written permission
     20      1.1      matt  *
     21      1.1      matt  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
     22      1.1      matt  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
     23      1.1      matt  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
     24      1.1      matt  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
     25      1.1      matt  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
     26      1.1      matt  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
     27      1.1      matt  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
     28      1.1      matt  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     29      1.1      matt  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
     30      1.1      matt  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     31      1.1      matt  */
     32      1.1      matt /*
     33      1.1      matt  * Copyright (c) 2005 Brocade Communcations, inc.
     34      1.1      matt  * All rights reserved.
     35      1.1      matt  *
     36      1.1      matt  * Written by Matt Thomas for Brocade Communcations, Inc.
     37      1.1      matt  *
     38      1.1      matt  * Redistribution and use in source and binary forms, with or without
     39      1.1      matt  * modification, are permitted provided that the following conditions
     40      1.1      matt  * are met:
     41      1.1      matt  * 1. Redistributions of source code must retain the above copyright
     42      1.1      matt  *    notice, this list of conditions and the following disclaimer.
     43      1.1      matt  * 2. Redistributions in binary form must reproduce the above copyright
     44      1.1      matt  *    notice, this list of conditions and the following disclaimer in the
     45      1.1      matt  *    documentation and/or other materials provided with the distribution.
     46      1.1      matt  * 3. The name of Brocade Communications, Inc. may not be used to endorse
     47      1.1      matt  *    or promote products derived from this software without specific prior
     48      1.1      matt  *    written permission.
     49      1.1      matt  *
     50      1.1      matt  * THIS SOFTWARE IS PROVIDED BY BROCADE COMMUNICATIONS, INC. ``AS IS'' AND
     51      1.1      matt  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
     52      1.1      matt  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
     53      1.1      matt  * ARE DISCLAIMED.  IN NO EVENT SHALL EITHER BROCADE COMMUNICATIONS, INC. BE
     54      1.1      matt  * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     55      1.1      matt  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     56      1.1      matt  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     57      1.1      matt  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     58      1.1      matt  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     59      1.1      matt  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
     60      1.1      matt  * OF THE POSSIBILITY OF SUCH DAMAGE.
     61      1.1      matt  */
     62      1.1      matt //#define TWSI_DEBUG
     63      1.1      matt 
     64      1.1      matt /*
     65      1.1      matt  * Marvell Two-Wire Serial Interface (aka I2C) master driver
     66      1.1      matt  */
     67      1.1      matt 
     68      1.1      matt #include <sys/cdefs.h>
     69  1.7.2.2    martin __KERNEL_RCSID(0, "$NetBSD: gttwsi_core.c,v 1.7.2.2 2020/04/08 14:08:05 martin Exp $");
     70      1.1      matt #include "locators.h"
     71      1.1      matt 
     72      1.1      matt #include <sys/param.h>
     73      1.1      matt #include <sys/bus.h>
     74      1.1      matt #include <sys/condvar.h>
     75      1.1      matt #include <sys/device.h>
     76      1.1      matt #include <sys/errno.h>
     77      1.1      matt #include <sys/kernel.h>
     78      1.1      matt #include <sys/mutex.h>
     79      1.1      matt #include <sys/systm.h>
     80      1.1      matt 
     81      1.1      matt #include <dev/i2c/i2cvar.h>
     82      1.1      matt 
     83      1.1      matt #include <dev/i2c/gttwsireg.h>
     84      1.1      matt #include <dev/i2c/gttwsivar.h>
     85      1.1      matt 
     86      1.1      matt static int	gttwsi_send_start(void *v, int flags);
     87      1.1      matt static int	gttwsi_send_stop(void *v, int flags);
     88      1.1      matt static int	gttwsi_initiate_xfer(void *v, i2c_addr_t addr, int flags);
     89      1.1      matt static int	gttwsi_read_byte(void *v, uint8_t *valp, int flags);
     90      1.1      matt static int	gttwsi_write_byte(void *v, uint8_t val, int flags);
     91      1.1      matt 
     92      1.6   thorpej static int	gttwsi_wait(struct gttwsi_softc *, uint32_t, uint32_t,
     93  1.7.2.2    martin 			    uint32_t, int, const char *);
     94      1.1      matt 
     95  1.7.2.2    martin uint32_t
     96  1.7.2.2    martin gttwsi_read_4(struct gttwsi_softc *sc, uint32_t reg)
     97      1.1      matt {
     98  1.7.2.2    martin 	const uint32_t val = bus_space_read_4(sc->sc_bust, sc->sc_bush,
     99  1.7.2.2    martin 					      sc->sc_regmap[reg]);
    100      1.1      matt #ifdef TWSI_DEBUG
    101  1.7.2.2    martin 	printf("I2C:R:[%" PRIu32 "]%02" PRIxBUSSIZE ":%02" PRIx32 "\n", reg, sc->sc_regmap[reg], val);
    102      1.1      matt #else
    103      1.1      matt 	DELAY(TWSI_READ_DELAY);
    104      1.1      matt #endif
    105      1.1      matt 	return val;
    106      1.1      matt }
    107      1.1      matt 
    108  1.7.2.2    martin void
    109  1.7.2.2    martin gttwsi_write_4(struct gttwsi_softc *sc, uint32_t reg, uint32_t val)
    110      1.1      matt {
    111  1.7.2.2    martin 
    112  1.7.2.2    martin 	bus_space_write_4(sc->sc_bust, sc->sc_bush, sc->sc_regmap[reg], val);
    113      1.1      matt #ifdef TWSI_DEBUG
    114  1.7.2.2    martin 	printf("I2C:W:[%" PRIu32 "]%02" PRIxBUSSIZE ":%02" PRIx32 "\n", reg, sc->sc_regmap[reg], val);
    115      1.1      matt #else
    116      1.1      matt 	DELAY(TWSI_WRITE_DELAY);
    117      1.1      matt #endif
    118      1.3  jmcneill }
    119      1.1      matt 
    120      1.1      matt /* ARGSUSED */
    121      1.1      matt void
    122  1.7.2.2    martin gttwsi_attach_subr(device_t self, bus_space_tag_t iot, bus_space_handle_t ioh,
    123  1.7.2.2    martin 		   const bus_size_t *regmap)
    124      1.1      matt {
    125      1.1      matt 	struct gttwsi_softc * const sc = device_private(self);
    126      1.2  jmcneill 	prop_dictionary_t cfg = device_properties(self);
    127      1.1      matt 
    128      1.1      matt 	aprint_naive("\n");
    129      1.1      matt 	aprint_normal(": Marvell TWSI controller\n");
    130      1.1      matt 
    131      1.1      matt 	sc->sc_dev = self;
    132      1.1      matt 	sc->sc_bust = iot;
    133      1.1      matt 	sc->sc_bush = ioh;
    134  1.7.2.2    martin 	sc->sc_regmap = regmap;
    135      1.1      matt 
    136      1.1      matt 	mutex_init(&sc->sc_mtx, MUTEX_DEFAULT, IPL_BIO);
    137      1.1      matt 	cv_init(&sc->sc_cv, device_xname(self));
    138      1.1      matt 
    139      1.2  jmcneill 	prop_dictionary_get_bool(cfg, "iflg-rwc", &sc->sc_iflg_rwc);
    140      1.2  jmcneill 
    141      1.1      matt 	sc->sc_started = false;
    142  1.7.2.2    martin 	iic_tag_init(&sc->sc_i2c);
    143      1.1      matt 	sc->sc_i2c.ic_cookie = sc;
    144      1.1      matt 	sc->sc_i2c.ic_send_start = gttwsi_send_start;
    145      1.1      matt 	sc->sc_i2c.ic_send_stop = gttwsi_send_stop;
    146      1.1      matt 	sc->sc_i2c.ic_initiate_xfer = gttwsi_initiate_xfer;
    147      1.1      matt 	sc->sc_i2c.ic_read_byte = gttwsi_read_byte;
    148      1.1      matt 	sc->sc_i2c.ic_write_byte = gttwsi_write_byte;
    149      1.1      matt 
    150      1.1      matt 	/*
    151      1.1      matt 	 * Put the controller into Soft Reset.
    152      1.1      matt 	 */
    153      1.1      matt 	/* reset */
    154      1.1      matt 	gttwsi_write_4(sc, TWSI_SOFTRESET, SOFTRESET_VAL);
    155      1.1      matt }
    156      1.1      matt 
    157      1.1      matt void
    158      1.1      matt gttwsi_config_children(device_t self)
    159      1.1      matt {
    160      1.1      matt 	struct gttwsi_softc * const sc = device_private(self);
    161      1.1      matt 	struct i2cbus_attach_args iba;
    162      1.1      matt 
    163      1.1      matt 	memset(&iba, 0, sizeof(iba));
    164      1.1      matt 	iba.iba_tag = &sc->sc_i2c;
    165      1.1      matt 
    166      1.1      matt 	(void) config_found_ia(sc->sc_dev, "i2cbus", &iba, iicbus_print);
    167      1.1      matt }
    168      1.1      matt 
    169      1.1      matt int
    170      1.1      matt gttwsi_intr(void *arg)
    171      1.1      matt {
    172      1.1      matt 	struct gttwsi_softc *sc = arg;
    173      1.1      matt 	uint32_t val;
    174      1.1      matt 
    175  1.7.2.1  christos 	mutex_enter(&sc->sc_mtx);
    176      1.1      matt 	val = gttwsi_read_4(sc, TWSI_CONTROL);
    177      1.1      matt 	if (val & CONTROL_IFLG) {
    178      1.1      matt 		gttwsi_write_4(sc, TWSI_CONTROL, val & ~CONTROL_INTEN);
    179      1.5  jmcneill 		cv_broadcast(&sc->sc_cv);
    180      1.1      matt 		mutex_exit(&sc->sc_mtx);
    181      1.1      matt 		return 1;	/* handled */
    182      1.1      matt 	}
    183  1.7.2.1  christos 	mutex_exit(&sc->sc_mtx);
    184      1.1      matt 	return 0;
    185      1.1      matt }
    186      1.1      matt 
    187      1.1      matt static int
    188      1.1      matt gttwsi_send_start(void *v, int flags)
    189      1.1      matt {
    190      1.1      matt 	struct gttwsi_softc *sc = v;
    191      1.1      matt 	int expect;
    192      1.1      matt 
    193      1.1      matt 	if (sc->sc_started)
    194      1.1      matt 		expect = STAT_RSCT;
    195      1.1      matt 	else
    196      1.1      matt 		expect = STAT_SCT;
    197      1.1      matt 	sc->sc_started = true;
    198  1.7.2.2    martin 	return gttwsi_wait(sc, CONTROL_START, expect, 0, flags, "send-start");
    199      1.1      matt }
    200      1.1      matt 
    201      1.1      matt static int
    202      1.1      matt gttwsi_send_stop(void *v, int flags)
    203      1.1      matt {
    204      1.1      matt 	struct gttwsi_softc *sc = v;
    205      1.1      matt 	int retry = TWSI_RETRY_COUNT;
    206  1.7.2.2    martin 	uint32_t control, status;
    207      1.3  jmcneill 
    208      1.1      matt 	sc->sc_started = false;
    209      1.1      matt 
    210      1.1      matt 	/* Interrupt is not generated for STAT_NRS. */
    211      1.2  jmcneill 	control = CONTROL_STOP | CONTROL_TWSIEN;
    212      1.2  jmcneill 	if (sc->sc_iflg_rwc)
    213      1.2  jmcneill 		control |= CONTROL_IFLG;
    214      1.2  jmcneill 	gttwsi_write_4(sc, TWSI_CONTROL, control);
    215      1.1      matt 	while (retry > 0) {
    216  1.7.2.2    martin 		if ((status = gttwsi_read_4(sc, TWSI_STATUS)) == STAT_NRS)
    217      1.1      matt 			return 0;
    218      1.1      matt 		retry--;
    219      1.1      matt 		DELAY(TWSI_STAT_DELAY);
    220      1.1      matt 	}
    221      1.1      matt 
    222  1.7.2.2    martin 	aprint_error_dev(sc->sc_dev, "send STOP failed, status=0x%02x\n",
    223  1.7.2.2    martin 			 status);
    224  1.7.2.2    martin 	return EWOULDBLOCK;
    225      1.1      matt }
    226      1.1      matt 
    227      1.1      matt static int
    228      1.1      matt gttwsi_initiate_xfer(void *v, i2c_addr_t addr, int flags)
    229      1.1      matt {
    230      1.1      matt 	struct gttwsi_softc *sc = v;
    231      1.6   thorpej 	uint32_t data, expect, alt;
    232      1.1      matt 	int error, read;
    233      1.1      matt 
    234      1.7  jakllsch 	error = gttwsi_send_start(v, flags);
    235      1.7  jakllsch 	if (error)
    236      1.7  jakllsch 		return error;
    237      1.1      matt 
    238      1.1      matt 	read = (flags & I2C_F_READ) != 0;
    239      1.6   thorpej 	if (read) {
    240      1.1      matt 		expect = STAT_ARBT_AR;
    241      1.6   thorpej 		alt    = STAT_ARBT_ANR;
    242      1.6   thorpej 	} else {
    243      1.1      matt 		expect = STAT_AWBT_AR;
    244      1.6   thorpej 		alt    = STAT_AWBT_ANR;
    245      1.6   thorpej 	}
    246      1.1      matt 
    247      1.1      matt 	/*
    248      1.1      matt 	 * First byte contains whether this xfer is a read or write.
    249      1.1      matt 	 */
    250      1.1      matt 	data = read;
    251      1.1      matt 	if (addr > 0x7f) {
    252      1.1      matt 		/*
    253      1.1      matt 		 * If this is a 10bit request, the first address byte is
    254      1.1      matt 		 * 0b11110<b9><b8><r/w>.
    255      1.1      matt 		 */
    256      1.1      matt 		data |= 0xf0 | ((addr & 0x300) >> 7);
    257      1.1      matt 		gttwsi_write_4(sc, TWSI_DATA, data);
    258  1.7.2.2    martin 		error = gttwsi_wait(sc, 0, expect, alt, flags, "send-addr-10");
    259      1.1      matt 		if (error)
    260      1.1      matt 			return error;
    261      1.1      matt 		/*
    262      1.1      matt 		 * The first address byte has been sent, now to send
    263      1.1      matt 		 * the second one.
    264      1.1      matt 		 */
    265      1.6   thorpej 		if (read) {
    266      1.1      matt 			expect = STAT_SARBT_AR;
    267      1.6   thorpej 			alt    = STAT_SARBT_ANR;
    268      1.6   thorpej 		} else {
    269      1.1      matt 			expect = STAT_SAWBT_AR;
    270      1.6   thorpej 			alt    = STAT_SAWBT_ANR;
    271      1.6   thorpej 		}
    272      1.1      matt 		data = (uint8_t)addr;
    273      1.1      matt 	} else
    274      1.1      matt 		data |= (addr << 1);
    275      1.1      matt 
    276      1.1      matt 	gttwsi_write_4(sc, TWSI_DATA, data);
    277  1.7.2.2    martin 	return gttwsi_wait(sc, 0, expect, alt, flags, "send-addr");
    278      1.1      matt }
    279      1.1      matt 
    280      1.1      matt static int
    281      1.1      matt gttwsi_read_byte(void *v, uint8_t *valp, int flags)
    282      1.1      matt {
    283      1.1      matt 	struct gttwsi_softc *sc = v;
    284      1.1      matt 	int error;
    285      1.1      matt 
    286  1.7.2.2    martin 	if (flags & I2C_F_LAST) {
    287  1.7.2.2    martin 		error = gttwsi_wait(sc, 0, STAT_MRRD_ANT, 0, flags,
    288  1.7.2.2    martin 				    "read-last-byte");
    289  1.7.2.2    martin 	} else {
    290  1.7.2.2    martin 		error = gttwsi_wait(sc, CONTROL_ACK, STAT_MRRD_AT, 0, flags,
    291  1.7.2.2    martin 				    "read-byte");
    292  1.7.2.2    martin 	}
    293      1.1      matt 	if (!error)
    294      1.1      matt 		*valp = gttwsi_read_4(sc, TWSI_DATA);
    295      1.1      matt 	if ((flags & (I2C_F_LAST | I2C_F_STOP)) == (I2C_F_LAST | I2C_F_STOP))
    296      1.1      matt 		error = gttwsi_send_stop(sc, flags);
    297      1.1      matt 	return error;
    298      1.1      matt }
    299      1.1      matt 
    300      1.1      matt static int
    301      1.1      matt gttwsi_write_byte(void *v, uint8_t val, int flags)
    302      1.1      matt {
    303      1.1      matt 	struct gttwsi_softc *sc = v;
    304      1.1      matt 	int error;
    305      1.1      matt 
    306      1.1      matt 	gttwsi_write_4(sc, TWSI_DATA, val);
    307  1.7.2.2    martin 	error = gttwsi_wait(sc, 0, STAT_MTDB_AR, 0, flags, "write-byte");
    308      1.1      matt 	if (flags & I2C_F_STOP)
    309      1.1      matt 		gttwsi_send_stop(sc, flags);
    310      1.1      matt 	return error;
    311      1.1      matt }
    312      1.1      matt 
    313      1.1      matt static int
    314      1.1      matt gttwsi_wait(struct gttwsi_softc *sc, uint32_t control, uint32_t expect,
    315  1.7.2.2    martin 	    uint32_t alt, int flags, const char *what)
    316      1.1      matt {
    317      1.1      matt 	uint32_t status;
    318      1.1      matt 	int timo, error = 0;
    319      1.1      matt 
    320  1.7.2.2    martin 	/*
    321  1.7.2.2    martin 	 * XXX Interrupt-driven mode seems to be horribly broken,
    322  1.7.2.2    martin 	 * XXX at least on AllWinner implementations.  Force polled
    323  1.7.2.2    martin 	 * XXX mode for now.
    324  1.7.2.2    martin 	 */
    325  1.7.2.2    martin 	flags |= I2C_F_POLL;
    326      1.3  jmcneill 
    327      1.1      matt 	DELAY(5);
    328      1.1      matt 	if (!(flags & I2C_F_POLL))
    329      1.1      matt 		control |= CONTROL_INTEN;
    330      1.2  jmcneill 	if (sc->sc_iflg_rwc)
    331      1.2  jmcneill 		control |= CONTROL_IFLG;
    332  1.7.2.1  christos 	mutex_enter(&sc->sc_mtx);
    333      1.1      matt 	gttwsi_write_4(sc, TWSI_CONTROL, control | CONTROL_TWSIEN);
    334      1.1      matt 
    335      1.1      matt 	timo = 0;
    336      1.1      matt 	for (;;) {
    337      1.1      matt 		control = gttwsi_read_4(sc, TWSI_CONTROL);
    338      1.1      matt 		if (control & CONTROL_IFLG)
    339      1.1      matt 			break;
    340      1.1      matt 		if (!(flags & I2C_F_POLL)) {
    341  1.7.2.2    martin 			error = cv_timedwait(&sc->sc_cv, &sc->sc_mtx, hz);
    342  1.7.2.2    martin 			if (error) {
    343  1.7.2.1  christos 				break;
    344  1.7.2.2    martin 			}
    345  1.7.2.1  christos 		} else {
    346  1.7.2.1  christos 			DELAY(TWSI_RETRY_DELAY);
    347  1.7.2.1  christos 			if (timo++ > 1000000)	/* 1sec */
    348  1.7.2.1  christos 				break;
    349      1.1      matt 		}
    350      1.1      matt 	}
    351  1.7.2.1  christos 	if ((control & CONTROL_IFLG) == 0) {
    352  1.7.2.2    martin 		/*
    353  1.7.2.2    martin 		 * error is set by the cv_timedwait() call above in the
    354  1.7.2.2    martin 		 * non-polled case.
    355  1.7.2.2    martin 		 */
    356  1.7.2.2    martin 		if (flags & I2C_F_POLL) {
    357  1.7.2.2    martin 			error = EWOULDBLOCK;
    358  1.7.2.2    martin 		} else {
    359  1.7.2.2    martin 			KASSERT(error != 0);
    360  1.7.2.2    martin 		}
    361  1.7.2.1  christos 		aprint_error_dev(sc->sc_dev,
    362  1.7.2.2    martin 		    "gttwsi_wait(): %s timeout%s, control=0x%x, error=%d\n",
    363  1.7.2.2    martin 		    what, (flags & I2C_F_POLL) ? " (polled)" : "",
    364  1.7.2.2    martin 		    control, error);
    365  1.7.2.1  christos 		goto end;
    366  1.7.2.1  christos 	}
    367      1.1      matt 	status = gttwsi_read_4(sc, TWSI_STATUS);
    368      1.1      matt 	if (status != expect) {
    369      1.6   thorpej 		/*
    370      1.6   thorpej 		 * In the case of probing for a device, we are expecting
    371      1.6   thorpej 		 * 2 different status codes: the ACK case (device exists),
    372      1.6   thorpej 		 * or the NACK case (device does not exist).  We don't
    373      1.6   thorpej 		 * need to report an error in the later case.
    374      1.6   thorpej 		 */
    375      1.6   thorpej 		if (alt != 0 && status != alt)
    376      1.6   thorpej 			aprint_error_dev(sc->sc_dev,
    377      1.6   thorpej 			    "unexpected status 0x%x: expect 0x%x\n", status,
    378      1.6   thorpej 			    expect);
    379  1.7.2.1  christos 		error = EIO;
    380      1.1      matt 	}
    381  1.7.2.2    martin  end:
    382  1.7.2.1  christos 	mutex_exit(&sc->sc_mtx);
    383      1.1      matt 	return error;
    384      1.1      matt }
    385