Home | History | Annotate | Line # | Download | only in i2c
tda19988.c revision 1.5
      1 /* $NetBSD: tda19988.c,v 1.5 2021/01/17 21:42:35 thorpej Exp $ */
      2 
      3 /*-
      4  * Copyright (c) 2015 Oleksandr Tymoshenko <gonzo (at) freebsd.org>
      5  * All rights reserved.
      6  *
      7  * Redistribution and use in source and binary forms, with or without
      8  * modification, are permitted provided that the following conditions
      9  * are met:
     10  * 1. Redistributions of source code must retain the above copyright
     11  *    notice, this list of conditions and the following disclaimer.
     12  * 2. Redistributions in binary form must reproduce the above copyright
     13  *    notice, this list of conditions and the following disclaimer in the
     14  *    documentation and/or other materials provided with the distribution.
     15  *
     16  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
     17  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
     18  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
     19  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
     20  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
     21  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
     22  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
     23  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
     24  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
     25  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     26  * SUCH DAMAGE.
     27  */
     28 
     29 #include <sys/cdefs.h>
     30 __KERNEL_RCSID(0, "$NetBSD: tda19988.c,v 1.5 2021/01/17 21:42:35 thorpej Exp $");
     31 
     32 /*
     33 * NXP TDA19988 HDMI encoder
     34 */
     35 #include <sys/param.h>
     36 #include <sys/systm.h>
     37 #include <sys/kernel.h>
     38 #include <sys/time.h>
     39 #include <sys/bus.h>
     40 #include <sys/types.h>
     41 
     42 #include <dev/i2c/i2cvar.h>
     43 #include <dev/i2c/ddcvar.h>
     44 #include <dev/i2c/ddcreg.h>
     45 
     46 #include <dev/fdt/fdtvar.h>
     47 #include <dev/fdt/fdt_port.h>
     48 
     49 #include <dev/videomode/videomode.h>
     50 #include <dev/videomode/edidvar.h>
     51 
     52 #include <drm/drmP.h>
     53 #include <drm/drm_crtc.h>
     54 #include <drm/drm_crtc_helper.h>
     55 #include <drm/drm_edid.h>
     56 
     57 enum {
     58 	TDA19988_PORT_INPUT = 0
     59 };
     60 
     61 #define	MKREG(page, addr)	(((page) << 8) | (addr))
     62 
     63 #define	REGPAGE(reg)		(((reg) >> 8) & 0xff)
     64 #define	REGADDR(reg)		((reg) & 0xff)
     65 
     66 #define TDA_VERSION		MKREG(0x00, 0x00)
     67 #define TDA_MAIN_CNTRL0		MKREG(0x00, 0x01)
     68 #define 	MAIN_CNTRL0_SR		(1 << 0)
     69 #define TDA_VERSION_MSB		MKREG(0x00, 0x02)
     70 #define	TDA_SOFTRESET		MKREG(0x00, 0x0a)
     71 #define		SOFTRESET_I2C		(1 << 1)
     72 #define		SOFTRESET_AUDIO		(1 << 0)
     73 #define	TDA_DDC_CTRL		MKREG(0x00, 0x0b)
     74 #define		DDC_ENABLE		0
     75 #define	TDA_CCLK		MKREG(0x00, 0x0c)
     76 #define		CCLK_ENABLE		1
     77 #define	TDA_INT_FLAGS_2		MKREG(0x00, 0x11)
     78 #define		INT_FLAGS_2_EDID_BLK_RD	(1 << 1)
     79 
     80 #define	TDA_VIP_CNTRL_0		MKREG(0x00, 0x20)
     81 #define	TDA_VIP_CNTRL_1		MKREG(0x00, 0x21)
     82 #define	TDA_VIP_CNTRL_2		MKREG(0x00, 0x22)
     83 #define	TDA_VIP_CNTRL_3		MKREG(0x00, 0x23)
     84 #define		VIP_CNTRL_3_SYNC_HS	(2 << 4)
     85 #define		VIP_CNTRL_3_V_TGL	(1 << 2)
     86 #define		VIP_CNTRL_3_H_TGL	(1 << 1)
     87 
     88 #define	TDA_VIP_CNTRL_4		MKREG(0x00, 0x24)
     89 #define		VIP_CNTRL_4_BLANKIT_NDE		(0 << 2)
     90 #define		VIP_CNTRL_4_BLANKIT_HS_VS	(1 << 2)
     91 #define		VIP_CNTRL_4_BLANKIT_NHS_VS	(2 << 2)
     92 #define		VIP_CNTRL_4_BLANKIT_HE_VE	(3 << 2)
     93 #define		VIP_CNTRL_4_BLC_NONE		(0 << 0)
     94 #define		VIP_CNTRL_4_BLC_RGB444		(1 << 0)
     95 #define		VIP_CNTRL_4_BLC_YUV444		(2 << 0)
     96 #define		VIP_CNTRL_4_BLC_YUV422		(3 << 0)
     97 #define	TDA_VIP_CNTRL_5		MKREG(0x00, 0x25)
     98 #define		VIP_CNTRL_5_SP_CNT(n)	(((n) & 3) << 1)
     99 #define	TDA_MUX_VP_VIP_OUT	MKREG(0x00, 0x27)
    100 #define TDA_MAT_CONTRL		MKREG(0x00, 0x80)
    101 #define		MAT_CONTRL_MAT_BP	(1 << 2)
    102 #define	TDA_VIDFORMAT		MKREG(0x00, 0xa0)
    103 #define	TDA_REFPIX_MSB		MKREG(0x00, 0xa1)
    104 #define	TDA_REFPIX_LSB		MKREG(0x00, 0xa2)
    105 #define	TDA_REFLINE_MSB		MKREG(0x00, 0xa3)
    106 #define	TDA_REFLINE_LSB		MKREG(0x00, 0xa4)
    107 #define	TDA_NPIX_MSB		MKREG(0x00, 0xa5)
    108 #define	TDA_NPIX_LSB		MKREG(0x00, 0xa6)
    109 #define	TDA_NLINE_MSB		MKREG(0x00, 0xa7)
    110 #define	TDA_NLINE_LSB		MKREG(0x00, 0xa8)
    111 #define	TDA_VS_LINE_STRT_1_MSB	MKREG(0x00, 0xa9)
    112 #define	TDA_VS_LINE_STRT_1_LSB	MKREG(0x00, 0xaa)
    113 #define	TDA_VS_PIX_STRT_1_MSB	MKREG(0x00, 0xab)
    114 #define	TDA_VS_PIX_STRT_1_LSB	MKREG(0x00, 0xac)
    115 #define	TDA_VS_LINE_END_1_MSB	MKREG(0x00, 0xad)
    116 #define	TDA_VS_LINE_END_1_LSB	MKREG(0x00, 0xae)
    117 #define	TDA_VS_PIX_END_1_MSB	MKREG(0x00, 0xaf)
    118 #define	TDA_VS_PIX_END_1_LSB	MKREG(0x00, 0xb0)
    119 #define	TDA_VS_LINE_STRT_2_MSB	MKREG(0x00, 0xb1)
    120 #define	TDA_VS_LINE_STRT_2_LSB	MKREG(0x00, 0xb2)
    121 #define	TDA_VS_PIX_STRT_2_MSB	MKREG(0x00, 0xb3)
    122 #define	TDA_VS_PIX_STRT_2_LSB	MKREG(0x00, 0xb4)
    123 #define	TDA_VS_LINE_END_2_MSB	MKREG(0x00, 0xb5)
    124 #define	TDA_VS_LINE_END_2_LSB	MKREG(0x00, 0xb6)
    125 #define	TDA_VS_PIX_END_2_MSB	MKREG(0x00, 0xb7)
    126 #define	TDA_VS_PIX_END_2_LSB	MKREG(0x00, 0xb8)
    127 #define	TDA_HS_PIX_START_MSB	MKREG(0x00, 0xb9)
    128 #define	TDA_HS_PIX_START_LSB	MKREG(0x00, 0xba)
    129 #define	TDA_HS_PIX_STOP_MSB	MKREG(0x00, 0xbb)
    130 #define	TDA_HS_PIX_STOP_LSB	MKREG(0x00, 0xbc)
    131 #define	TDA_VWIN_START_1_MSB	MKREG(0x00, 0xbd)
    132 #define	TDA_VWIN_START_1_LSB	MKREG(0x00, 0xbe)
    133 #define	TDA_VWIN_END_1_MSB	MKREG(0x00, 0xbf)
    134 #define	TDA_VWIN_END_1_LSB	MKREG(0x00, 0xc0)
    135 #define	TDA_VWIN_START_2_MSB	MKREG(0x00, 0xc1)
    136 #define	TDA_VWIN_START_2_LSB	MKREG(0x00, 0xc2)
    137 #define	TDA_VWIN_END_2_MSB	MKREG(0x00, 0xc3)
    138 #define	TDA_VWIN_END_2_LSB	MKREG(0x00, 0xc4)
    139 #define	TDA_DE_START_MSB	MKREG(0x00, 0xc5)
    140 #define	TDA_DE_START_LSB	MKREG(0x00, 0xc6)
    141 #define	TDA_DE_STOP_MSB		MKREG(0x00, 0xc7)
    142 #define	TDA_DE_STOP_LSB		MKREG(0x00, 0xc8)
    143 
    144 #define	TDA_TBG_CNTRL_0		MKREG(0x00, 0xca)
    145 #define		TBG_CNTRL_0_SYNC_ONCE	(1 << 7)
    146 #define		TBG_CNTRL_0_SYNC_MTHD	(1 << 6)
    147 
    148 #define	TDA_TBG_CNTRL_1		MKREG(0x00, 0xcb)
    149 #define		TBG_CNTRL_1_DWIN_DIS	(1 << 6)
    150 #define		TBG_CNTRL_1_TGL_EN	(1 << 2)
    151 #define		TBG_CNTRL_1_V_TGL	(1 << 1)
    152 #define		TBG_CNTRL_1_H_TGL	(1 << 0)
    153 
    154 #define	TDA_HVF_CNTRL_0		MKREG(0x00, 0xe4)
    155 #define		HVF_CNTRL_0_PREFIL_NONE		(0 << 2)
    156 #define		HVF_CNTRL_0_INTPOL_BYPASS	(0 << 0)
    157 #define	TDA_HVF_CNTRL_1		MKREG(0x00, 0xe5)
    158 #define		HVF_CNTRL_1_VQR(x)	(((x) & 3) << 2)
    159 #define		HVF_CNTRL_1_VQR_FULL	HVF_CNTRL_1_VQR(0)
    160 #define	TDA_ENABLE_SPACE	MKREG(0x00, 0xd6)
    161 #define	TDA_RPT_CNTRL		MKREG(0x00, 0xf0)
    162 
    163 #define	TDA_PLL_SERIAL_1	MKREG(0x02, 0x00)
    164 #define		PLL_SERIAL_1_SRL_MAN_IP	(1 << 6)
    165 #define	TDA_PLL_SERIAL_2	MKREG(0x02, 0x01)
    166 #define		PLL_SERIAL_2_SRL_PR(x)		(((x) & 0xf) << 4)
    167 #define		PLL_SERIAL_2_SRL_NOSC(x)	(((x) & 0x3) << 0)
    168 #define	TDA_PLL_SERIAL_3	MKREG(0x02, 0x02)
    169 #define		PLL_SERIAL_3_SRL_PXIN_SEL	(1 << 4)
    170 #define		PLL_SERIAL_3_SRL_DE		(1 << 2)
    171 #define		PLL_SERIAL_3_SRL_CCIR		(1 << 0)
    172 #define	TDA_SERIALIZER		MKREG(0x02, 0x03)
    173 #define	TDA_BUFFER_OUT		MKREG(0x02, 0x04)
    174 #define	TDA_PLL_SCG1		MKREG(0x02, 0x05)
    175 #define	TDA_PLL_SCG2		MKREG(0x02, 0x06)
    176 #define	TDA_PLL_SCGN1		MKREG(0x02, 0x07)
    177 #define	TDA_PLL_SCGN2		MKREG(0x02, 0x08)
    178 #define	TDA_PLL_SCGR1		MKREG(0x02, 0x09)
    179 #define	TDA_PLL_SCGR2		MKREG(0x02, 0x0a)
    180 
    181 #define	TDA_SEL_CLK		MKREG(0x02, 0x11)
    182 #define		SEL_CLK_ENA_SC_CLK	(1 << 3)
    183 #define		SEL_CLK_SEL_VRF_CLK(x)	(((x) & 3) << 1)
    184 #define		SEL_CLK_SEL_CLK1	(1 << 0)
    185 #define	TDA_ANA_GENERAL		MKREG(0x02, 0x12)
    186 
    187 #define	TDA_EDID_DATA0		MKREG(0x09, 0x00)
    188 #define	TDA_EDID_CTRL		MKREG(0x09, 0xfa)
    189 #define	TDA_DDC_ADDR		MKREG(0x09, 0xfb)
    190 #define	TDA_DDC_OFFS		MKREG(0x09, 0xfc)
    191 #define	TDA_DDC_SEGM_ADDR	MKREG(0x09, 0xfd)
    192 #define	TDA_DDC_SEGM		MKREG(0x09, 0xfe)
    193 
    194 #define	TDA_IF_VSP		MKREG(0x10, 0x20)
    195 #define	TDA_IF_AVI		MKREG(0x10, 0x40)
    196 #define	TDA_IF_SPD		MKREG(0x10, 0x60)
    197 #define	TDA_IF_AUD		MKREG(0x10, 0x80)
    198 #define	TDA_IF_MPS		MKREG(0x10, 0xa0)
    199 
    200 #define	TDA_ENC_CNTRL		MKREG(0x11, 0x0d)
    201 #define		ENC_CNTRL_DVI_MODE	(0 << 2)
    202 #define		ENC_CNTRL_HDMI_MODE	(1 << 2)
    203 #define	TDA_DIP_IF_FLAGS	MKREG(0x11, 0x0f)
    204 #define		DIP_IF_FLAGS_IF5	(1 << 5)
    205 #define		DIP_IF_FLAGS_IF4	(1 << 4)
    206 #define		DIP_IF_FLAGS_IF3	(1 << 3)
    207 #define		DIP_IF_FLAGS_IF2	(1 << 2) /* AVI IF on page 10h */
    208 #define		DIP_IF_FLAGS_IF1	(1 << 1)
    209 
    210 #define	TDA_TX3			MKREG(0x12, 0x9a)
    211 #define	TDA_TX4			MKREG(0x12, 0x9b)
    212 #define		TX4_PD_RAM		(1 << 1)
    213 #define	TDA_HDCP_TX33		MKREG(0x12, 0xb8)
    214 #define		HDCP_TX33_HDMI		(1 << 1)
    215 
    216 #define	TDA_CURPAGE_ADDR	0xff
    217 
    218 #define	TDA_CEC_RXSHPDLEV	0xfe
    219 #define		RXSHPDLEV_HPD	__BIT(1)
    220 
    221 #define	TDA_CEC_ENAMODS		0xff
    222 #define		ENAMODS_RXSENS		(1 << 2)
    223 #define		ENAMODS_HDMI		(1 << 1)
    224 #define	TDA_CEC_FRO_IM_CLK_CTRL	0xfb
    225 #define		CEC_FRO_IM_CLK_CTRL_GHOST_DIS	(1 << 7)
    226 #define		CEC_FRO_IM_CLK_CTRL_IMCLK_SEL	(1 << 1)
    227 
    228 /* EDID reading */
    229 #define	MAX_READ_ATTEMPTS	100
    230 
    231 /* EDID fields */
    232 #define	EDID_MODES0		35
    233 #define	EDID_MODES1		36
    234 #define	EDID_TIMING_START	38
    235 #define	EDID_TIMING_END		54
    236 #define	EDID_TIMING_X(v)	(((v) + 31) * 8)
    237 #define	EDID_FREQ(v)		(((v) & 0x3f) + 60)
    238 #define	EDID_RATIO(v)		(((v) >> 6) & 0x3)
    239 #define	EDID_RATIO_10x16	0
    240 #define	EDID_RATIO_3x4		1
    241 #define	EDID_RATIO_4x5		2
    242 #define	EDID_RATIO_9x16		3
    243 
    244 #define	TDA19988		0x0301
    245 
    246 static const struct device_compatible_entry compat_data[] = {
    247 	{ .compat = "nxp,tda998x" },
    248 
    249 	{ 0 }
    250 };
    251 
    252 struct tda19988_softc;
    253 
    254 struct tda19988_connector {
    255 	struct drm_connector	base;
    256 	struct tda19988_softc	*sc;
    257 };
    258 
    259 struct tda19988_softc {
    260 	device_t		sc_dev;
    261 	int			sc_phandle;
    262 	i2c_tag_t		sc_i2c;
    263 	i2c_addr_t		sc_addr;
    264 	uint32_t		sc_cec_addr;
    265 	uint16_t		sc_version;
    266 	int			sc_current_page;
    267 	uint8_t			*sc_edid;
    268 	uint32_t		sc_edid_len;
    269 	bool			sc_edid_valid;
    270 
    271 	struct drm_bridge	sc_bridge;
    272 	struct tda19988_connector sc_connector;
    273 
    274 	struct fdt_device_ports	sc_ports;
    275 
    276 	enum drm_connector_status sc_last_status;
    277 };
    278 
    279 #define	to_tda_connector(x)	container_of(x, struct tda19988_connector, base)
    280 
    281 static int
    282 tda19988_set_page(struct tda19988_softc *sc, uint8_t page)
    283 {
    284 	uint8_t buf[2] = { TDA_CURPAGE_ADDR, page };
    285 	int result;
    286 
    287 	result = iic_exec(sc->sc_i2c, I2C_OP_WRITE_WITH_STOP, sc->sc_addr, buf, 2, NULL, 0, 0);
    288 	if (result == 0)
    289 		sc->sc_current_page = page;
    290 
    291 	return result;
    292 }
    293 
    294 static int
    295 tda19988_cec_read(struct tda19988_softc *sc, uint8_t addr, uint8_t *data)
    296 {
    297 	return iic_exec(sc->sc_i2c, I2C_OP_READ_WITH_STOP, sc->sc_cec_addr, &addr, 1, data, 1, 0);
    298 }
    299 
    300 static int
    301 tda19988_cec_write(struct tda19988_softc *sc, uint8_t addr, uint8_t data)
    302 {
    303 	uint8_t buf[2] = { addr, data };
    304 
    305 	return iic_exec(sc->sc_i2c, I2C_OP_WRITE_WITH_STOP, sc->sc_cec_addr, buf, 2, NULL, 0, 0);
    306 }
    307 
    308 static int
    309 tda19988_block_read(struct tda19988_softc *sc, uint16_t addr, uint8_t *data, int len)
    310 {
    311 	uint8_t reg;
    312 
    313 	reg = REGADDR(addr);
    314 
    315 	if (sc->sc_current_page != REGPAGE(addr))
    316 		tda19988_set_page(sc, REGPAGE(addr));
    317 
    318 	return iic_exec(sc->sc_i2c, I2C_OP_READ_WITH_STOP, sc->sc_addr, &reg, 1, data, len, 0);
    319 }
    320 
    321 static int
    322 tda19988_reg_read(struct tda19988_softc *sc, uint16_t addr, uint8_t *data)
    323 {
    324 	uint8_t reg;
    325 
    326 	reg = REGADDR(addr);
    327 
    328 	if (sc->sc_current_page != REGPAGE(addr))
    329 		tda19988_set_page(sc, REGPAGE(addr));
    330 
    331 	return iic_exec(sc->sc_i2c, I2C_OP_READ_WITH_STOP, sc->sc_addr, &reg, 1, data, 1, 0);
    332 }
    333 
    334 static int
    335 tda19988_reg_write(struct tda19988_softc *sc, uint16_t addr, uint8_t data)
    336 {
    337 	uint8_t buf[2] = { REGADDR(addr), data };
    338 
    339 	if (sc->sc_current_page != REGPAGE(addr))
    340 		tda19988_set_page(sc, REGPAGE(addr));
    341 
    342 	return iic_exec(sc->sc_i2c, I2C_OP_WRITE_WITH_STOP, sc->sc_addr, buf, 2, NULL, 0, 0);
    343 }
    344 
    345 static int
    346 tda19988_reg_write2(struct tda19988_softc *sc, uint16_t address, uint16_t data)
    347 {
    348 	uint8_t buf[3];
    349 
    350 	buf[0] = REGADDR(address);
    351 	buf[1] = (data >> 8);
    352 	buf[2] = (data & 0xff);
    353 
    354 	if (sc->sc_current_page != REGPAGE(address))
    355 		tda19988_set_page(sc, REGPAGE(address));
    356 
    357 	return iic_exec(sc->sc_i2c, I2C_OP_READ_WITH_STOP, sc->sc_addr, buf, 3, NULL, 0, 0);
    358 }
    359 
    360 static void
    361 tda19988_reg_set(struct tda19988_softc *sc, uint16_t addr, uint8_t flags)
    362 {
    363 	uint8_t data;
    364 
    365 	tda19988_reg_read(sc, addr, &data);
    366 	data |= flags;
    367 	tda19988_reg_write(sc, addr, data);
    368 }
    369 
    370 static void
    371 tda19988_reg_clear(struct tda19988_softc *sc, uint16_t addr, uint8_t flags)
    372 {
    373 	uint8_t data;
    374 
    375 	tda19988_reg_read(sc, addr, &data);
    376 	data &= ~flags;
    377 	tda19988_reg_write(sc, addr, data);
    378 }
    379 
    380 static int
    381 tda19988_match(device_t parent, cfdata_t match, void *aux)
    382 {
    383 	struct i2c_attach_args * const ia = aux;
    384 	int match_result;
    385 
    386 	if (iic_use_direct_match(ia, match, compat_data, &match_result))
    387 		return match_result;
    388 
    389 	return 0;
    390 }
    391 
    392 static void
    393 tda19988_init_encoder(struct tda19988_softc *sc, const struct drm_display_mode *mode)
    394 {
    395 	uint16_t ref_pix, ref_line, n_pix, n_line;
    396 	uint16_t hs_pix_start, hs_pix_stop;
    397 	uint16_t vs1_pix_start, vs1_pix_stop;
    398 	uint16_t vs1_line_start, vs1_line_end;
    399 	uint16_t vs2_pix_start, vs2_pix_stop;
    400 	uint16_t vs2_line_start, vs2_line_end;
    401 	uint16_t vwin1_line_start, vwin1_line_end;
    402 	uint16_t vwin2_line_start, vwin2_line_end;
    403 	uint16_t de_start, de_stop;
    404 	uint8_t reg, div;
    405 
    406 	n_pix = mode->crtc_htotal;
    407 	n_line = mode->crtc_vtotal;
    408 
    409 	hs_pix_stop = mode->crtc_hsync_end - mode->crtc_hdisplay;
    410 	hs_pix_start = mode->crtc_hsync_start - mode->crtc_hdisplay;
    411 
    412 	de_stop = mode->crtc_htotal;
    413 	de_start = mode->crtc_htotal - mode->crtc_hdisplay;
    414 	ref_pix = hs_pix_start + 3;
    415 
    416 	if (mode->flags & DRM_MODE_FLAG_HSKEW)
    417 		ref_pix += mode->crtc_hskew;
    418 
    419 	if ((mode->flags & DRM_MODE_FLAG_INTERLACE) == 0) {
    420 		ref_line = 1 + mode->crtc_vsync_start - mode->crtc_vdisplay;
    421 		vwin1_line_start = mode->crtc_vtotal - mode->crtc_vdisplay - 1;
    422 		vwin1_line_end = vwin1_line_start + mode->crtc_vdisplay;
    423 
    424 		vs1_pix_start = vs1_pix_stop = hs_pix_start;
    425 		vs1_line_start = mode->crtc_vsync_start - mode->crtc_vdisplay;
    426 		vs1_line_end = vs1_line_start + mode->crtc_vsync_end - mode->crtc_vsync_start;
    427 
    428 		vwin2_line_start = vwin2_line_end = 0;
    429 		vs2_pix_start = vs2_pix_stop = 0;
    430 		vs2_line_start = vs2_line_end = 0;
    431 	} else {
    432 		ref_line = 1 + (mode->crtc_vsync_start - mode->crtc_vdisplay)/2;
    433 		vwin1_line_start = (mode->crtc_vtotal - mode->crtc_vdisplay)/2;
    434 		vwin1_line_end = vwin1_line_start + mode->crtc_vdisplay/2;
    435 
    436 		vs1_pix_start = vs1_pix_stop = hs_pix_start;
    437 		vs1_line_start = (mode->crtc_vsync_start - mode->crtc_vdisplay)/2;
    438 		vs1_line_end = vs1_line_start + (mode->crtc_vsync_end - mode->crtc_vsync_start)/2;
    439 
    440 		vwin2_line_start = vwin1_line_start + mode->crtc_vtotal/2;
    441 		vwin2_line_end = vwin2_line_start + mode->crtc_vdisplay/2;
    442 
    443 		vs2_pix_start = vs2_pix_stop = hs_pix_start + mode->crtc_htotal/2;
    444 		vs2_line_start = vs1_line_start + mode->crtc_vtotal/2 ;
    445 		vs2_line_end = vs2_line_start + (mode->crtc_vsync_end - mode->crtc_vsync_start)/2;
    446 	}
    447 
    448 	div = 148500 / mode->crtc_clock;
    449 	if (div != 0) {
    450 		div--;
    451 		if (div > 3)
    452 			div = 3;
    453 	}
    454 
    455 	/* set HDMI HDCP mode off */
    456 	tda19988_reg_set(sc, TDA_TBG_CNTRL_1, TBG_CNTRL_1_DWIN_DIS);
    457 	tda19988_reg_clear(sc, TDA_HDCP_TX33, HDCP_TX33_HDMI);
    458 	tda19988_reg_write(sc, TDA_ENC_CNTRL, ENC_CNTRL_DVI_MODE);
    459 
    460 	/* no pre-filter or interpolator */
    461 	tda19988_reg_write(sc, TDA_HVF_CNTRL_0,
    462 	    HVF_CNTRL_0_INTPOL_BYPASS | HVF_CNTRL_0_PREFIL_NONE);
    463 	tda19988_reg_write(sc, TDA_VIP_CNTRL_5, VIP_CNTRL_5_SP_CNT(0));
    464 	tda19988_reg_write(sc, TDA_VIP_CNTRL_4,
    465 	    VIP_CNTRL_4_BLANKIT_NDE | VIP_CNTRL_4_BLC_NONE);
    466 
    467 	tda19988_reg_clear(sc, TDA_PLL_SERIAL_3, PLL_SERIAL_3_SRL_CCIR);
    468 	tda19988_reg_clear(sc, TDA_PLL_SERIAL_1, PLL_SERIAL_1_SRL_MAN_IP);
    469 	tda19988_reg_clear(sc, TDA_PLL_SERIAL_3, PLL_SERIAL_3_SRL_DE);
    470 	tda19988_reg_write(sc, TDA_SERIALIZER, 0);
    471 	tda19988_reg_write(sc, TDA_HVF_CNTRL_1, HVF_CNTRL_1_VQR_FULL);
    472 
    473 	tda19988_reg_write(sc, TDA_RPT_CNTRL, 0);
    474 	tda19988_reg_write(sc, TDA_SEL_CLK, SEL_CLK_SEL_VRF_CLK(0) |
    475 			SEL_CLK_SEL_CLK1 | SEL_CLK_ENA_SC_CLK);
    476 
    477 	tda19988_reg_write(sc, TDA_PLL_SERIAL_2, PLL_SERIAL_2_SRL_NOSC(div) |
    478 			PLL_SERIAL_2_SRL_PR(0));
    479 
    480 	tda19988_reg_set(sc, TDA_MAT_CONTRL, MAT_CONTRL_MAT_BP);
    481 
    482 	tda19988_reg_write(sc, TDA_ANA_GENERAL, 0x09);
    483 
    484 	tda19988_reg_clear(sc, TDA_TBG_CNTRL_0, TBG_CNTRL_0_SYNC_MTHD);
    485 
    486 	/*
    487 	 * Sync on rising HSYNC/VSYNC
    488 	 */
    489 	reg = VIP_CNTRL_3_SYNC_HS;
    490 	if (mode->flags & DRM_MODE_FLAG_NHSYNC)
    491 		reg |= VIP_CNTRL_3_H_TGL;
    492 	if (mode->flags & DRM_MODE_FLAG_NVSYNC)
    493 		reg |= VIP_CNTRL_3_V_TGL;
    494 	tda19988_reg_write(sc, TDA_VIP_CNTRL_3, reg);
    495 
    496 	reg = TBG_CNTRL_1_TGL_EN;
    497 	if (mode->flags & DRM_MODE_FLAG_NHSYNC)
    498 		reg |= TBG_CNTRL_1_H_TGL;
    499 	if (mode->flags & DRM_MODE_FLAG_NVSYNC)
    500 		reg |= TBG_CNTRL_1_V_TGL;
    501 	tda19988_reg_write(sc, TDA_TBG_CNTRL_1, reg);
    502 
    503 	/* Program timing */
    504 	tda19988_reg_write(sc, TDA_VIDFORMAT, 0x00);
    505 
    506 	tda19988_reg_write2(sc, TDA_REFPIX_MSB, ref_pix);
    507 	tda19988_reg_write2(sc, TDA_REFLINE_MSB, ref_line);
    508 	tda19988_reg_write2(sc, TDA_NPIX_MSB, n_pix);
    509 	tda19988_reg_write2(sc, TDA_NLINE_MSB, n_line);
    510 
    511 	tda19988_reg_write2(sc, TDA_VS_LINE_STRT_1_MSB, vs1_line_start);
    512 	tda19988_reg_write2(sc, TDA_VS_PIX_STRT_1_MSB, vs1_pix_start);
    513 	tda19988_reg_write2(sc, TDA_VS_LINE_END_1_MSB, vs1_line_end);
    514 	tda19988_reg_write2(sc, TDA_VS_PIX_END_1_MSB, vs1_pix_stop);
    515 	tda19988_reg_write2(sc, TDA_VS_LINE_STRT_2_MSB, vs2_line_start);
    516 	tda19988_reg_write2(sc, TDA_VS_PIX_STRT_2_MSB, vs2_pix_start);
    517 	tda19988_reg_write2(sc, TDA_VS_LINE_END_2_MSB, vs2_line_end);
    518 	tda19988_reg_write2(sc, TDA_VS_PIX_END_2_MSB, vs2_pix_stop);
    519 	tda19988_reg_write2(sc, TDA_HS_PIX_START_MSB, hs_pix_start);
    520 	tda19988_reg_write2(sc, TDA_HS_PIX_STOP_MSB, hs_pix_stop);
    521 	tda19988_reg_write2(sc, TDA_VWIN_START_1_MSB, vwin1_line_start);
    522 	tda19988_reg_write2(sc, TDA_VWIN_END_1_MSB, vwin1_line_end);
    523 	tda19988_reg_write2(sc, TDA_VWIN_START_2_MSB, vwin2_line_start);
    524 	tda19988_reg_write2(sc, TDA_VWIN_END_2_MSB, vwin2_line_end);
    525 	tda19988_reg_write2(sc, TDA_DE_START_MSB, de_start);
    526 	tda19988_reg_write2(sc, TDA_DE_STOP_MSB, de_stop);
    527 
    528 	if (sc->sc_version == TDA19988)
    529 		tda19988_reg_write(sc, TDA_ENABLE_SPACE, 0x00);
    530 
    531 	/* must be last register set */
    532 	tda19988_reg_clear(sc, TDA_TBG_CNTRL_0, TBG_CNTRL_0_SYNC_ONCE);
    533 }
    534 
    535 static int
    536 tda19988_read_edid_block(struct tda19988_softc *sc, uint8_t *buf, int block)
    537 {
    538 	int attempt, err;
    539 	uint8_t data;
    540 
    541 	err = 0;
    542 
    543 	tda19988_reg_set(sc, TDA_INT_FLAGS_2, INT_FLAGS_2_EDID_BLK_RD);
    544 
    545 	/* Block 0 */
    546 	tda19988_reg_write(sc, TDA_DDC_ADDR, 0xa0);
    547 	tda19988_reg_write(sc, TDA_DDC_OFFS, (block % 2) ? 128 : 0);
    548 	tda19988_reg_write(sc, TDA_DDC_SEGM_ADDR, 0x60);
    549 	tda19988_reg_write(sc, TDA_DDC_SEGM, block / 2);
    550 
    551 	tda19988_reg_write(sc, TDA_EDID_CTRL, 1);
    552 	tda19988_reg_write(sc, TDA_EDID_CTRL, 0);
    553 
    554 	data = 0;
    555 	for (attempt = 0; attempt < MAX_READ_ATTEMPTS; attempt++) {
    556 		tda19988_reg_read(sc, TDA_INT_FLAGS_2, &data);
    557 		if (data & INT_FLAGS_2_EDID_BLK_RD)
    558 			break;
    559 		delay(1000);
    560 	}
    561 
    562 	if (attempt == MAX_READ_ATTEMPTS) {
    563 		err = -1;
    564 		goto done;
    565 	}
    566 
    567 	if (tda19988_block_read(sc, TDA_EDID_DATA0, buf, EDID_LENGTH) != 0) {
    568 		err = -1;
    569 		goto done;
    570 	}
    571 
    572 done:
    573 	tda19988_reg_clear(sc, TDA_INT_FLAGS_2, INT_FLAGS_2_EDID_BLK_RD);
    574 
    575 	return (err);
    576 }
    577 
    578 static int
    579 tda19988_read_edid(struct tda19988_softc *sc)
    580 {
    581 	int err;
    582 	int blocks, i;
    583 	uint8_t *buf, *edid;
    584 
    585 	err = 0;
    586 	if (sc->sc_version == TDA19988)
    587 		tda19988_reg_clear(sc, TDA_TX4, TX4_PD_RAM);
    588 
    589 	err = tda19988_read_edid_block(sc, sc->sc_edid, 0);
    590 	if (err)
    591 		goto done;
    592 
    593 	blocks = sc->sc_edid[0x7e];
    594 	if (blocks > 0) {
    595 		if (sc->sc_edid_len != EDID_LENGTH*(blocks+1)) {
    596 			edid = kmem_zalloc(EDID_LENGTH*(blocks+1), KM_SLEEP);
    597 			memcpy(edid, sc->sc_edid, EDID_LENGTH);
    598 			kmem_free(sc->sc_edid, sc->sc_edid_len);
    599 			sc->sc_edid = edid;
    600 			sc->sc_edid_len = EDID_LENGTH*(blocks+1);
    601 		}
    602 		for (i = 0; i < blocks; i++) {
    603 			/* TODO: check validity */
    604 			buf = sc->sc_edid + EDID_LENGTH*(i+1);
    605 			err = tda19988_read_edid_block(sc, buf, i);
    606 			if (err)
    607 				goto done;
    608 		}
    609 	}
    610 
    611 done:
    612 	if (sc->sc_version == TDA19988)
    613 		tda19988_reg_set(sc, TDA_TX4, TX4_PD_RAM);
    614 
    615 	return (err);
    616 }
    617 
    618 static void
    619 tda19988_start(struct tda19988_softc *sc)
    620 {
    621 	device_t dev;
    622 	uint8_t data;
    623 	uint16_t ver;
    624 
    625 	dev = sc->sc_dev;
    626 
    627 	tda19988_cec_write(sc, TDA_CEC_ENAMODS, ENAMODS_RXSENS | ENAMODS_HDMI);
    628 	DELAY(1000);
    629 	tda19988_cec_read(sc, TDA_CEC_RXSHPDLEV, &data);
    630 
    631 	/* Reset core */
    632 	tda19988_reg_set(sc, TDA_SOFTRESET, 3);
    633 	DELAY(100);
    634 	tda19988_reg_clear(sc, TDA_SOFTRESET, 3);
    635 	DELAY(100);
    636 
    637 	/* reset transmitter: */
    638 	tda19988_reg_set(sc, TDA_MAIN_CNTRL0, MAIN_CNTRL0_SR);
    639 	tda19988_reg_clear(sc, TDA_MAIN_CNTRL0, MAIN_CNTRL0_SR);
    640 
    641 	/* PLL registers common configuration */
    642 	tda19988_reg_write(sc, TDA_PLL_SERIAL_1, 0x00);
    643 	tda19988_reg_write(sc, TDA_PLL_SERIAL_2, PLL_SERIAL_2_SRL_NOSC(1));
    644 	tda19988_reg_write(sc, TDA_PLL_SERIAL_3, 0x00);
    645 	tda19988_reg_write(sc, TDA_SERIALIZER, 0x00);
    646 	tda19988_reg_write(sc, TDA_BUFFER_OUT, 0x00);
    647 	tda19988_reg_write(sc, TDA_PLL_SCG1, 0x00);
    648 	tda19988_reg_write(sc, TDA_SEL_CLK, SEL_CLK_SEL_CLK1 | SEL_CLK_ENA_SC_CLK);
    649 	tda19988_reg_write(sc, TDA_PLL_SCGN1, 0xfa);
    650 	tda19988_reg_write(sc, TDA_PLL_SCGN2, 0x00);
    651 	tda19988_reg_write(sc, TDA_PLL_SCGR1, 0x5b);
    652 	tda19988_reg_write(sc, TDA_PLL_SCGR2, 0x00);
    653 	tda19988_reg_write(sc, TDA_PLL_SCG2, 0x10);
    654 
    655 	/* Write the default value MUX register */
    656 	tda19988_reg_write(sc, TDA_MUX_VP_VIP_OUT, 0x24);
    657 
    658 	ver = 0;
    659 	tda19988_reg_read(sc, TDA_VERSION, &data);
    660 	ver |= data;
    661 	tda19988_reg_read(sc, TDA_VERSION_MSB, &data);
    662 	ver |= (data << 8);
    663 
    664 	/* Clear feature bits */
    665 	sc->sc_version = ver & ~0x30;
    666 	switch (sc->sc_version) {
    667 		case TDA19988:
    668 			device_printf(dev, "TDA19988\n");
    669 			break;
    670 		default:
    671 			device_printf(dev, "Unknown device: %04x\n", sc->sc_version);
    672 			return;
    673 	}
    674 
    675 	tda19988_reg_write(sc, TDA_DDC_CTRL, DDC_ENABLE);
    676 	tda19988_reg_write(sc, TDA_TX3, 39);
    677 
    678     	tda19988_cec_write(sc, TDA_CEC_FRO_IM_CLK_CTRL,
    679             CEC_FRO_IM_CLK_CTRL_GHOST_DIS | CEC_FRO_IM_CLK_CTRL_IMCLK_SEL);
    680 
    681 	/* Default values for RGB 4:4:4 mapping */
    682 	tda19988_reg_write(sc, TDA_VIP_CNTRL_0, 0x23);
    683 	tda19988_reg_write(sc, TDA_VIP_CNTRL_1, 0x01);
    684 	tda19988_reg_write(sc, TDA_VIP_CNTRL_2, 0x45);
    685 }
    686 
    687 static enum drm_connector_status
    688 tda19988_connector_detect(struct drm_connector *connector, bool force)
    689 {
    690 	struct tda19988_connector *tda_connector = to_tda_connector(connector);
    691 	struct tda19988_softc * const sc = tda_connector->sc;
    692 	enum drm_connector_status status;
    693 	uint8_t data = 0;
    694 
    695 	iic_acquire_bus(sc->sc_i2c, 0);
    696 	tda19988_cec_read(sc, TDA_CEC_RXSHPDLEV, &data);
    697 	iic_release_bus(sc->sc_i2c, 0);
    698 
    699 	status = (data & RXSHPDLEV_HPD) ?
    700 	    connector_status_connected :
    701 	    connector_status_disconnected;
    702 
    703 	/* On connect, invalidate the last EDID */
    704 	if (status == connector_status_connected &&
    705 	    sc->sc_last_status != connector_status_connected)
    706 		sc->sc_edid_valid = false;
    707 
    708 	sc->sc_last_status = status;
    709 
    710 	return status;
    711 }
    712 
    713 static void
    714 tda19988_connector_destroy(struct drm_connector *connector)
    715 {
    716 	drm_connector_unregister(connector);
    717 	drm_connector_cleanup(connector);
    718 }
    719 
    720 static const struct drm_connector_funcs tda19988_connector_funcs = {
    721 	.dpms = drm_helper_connector_dpms,
    722 	.detect = tda19988_connector_detect,
    723 	.fill_modes = drm_helper_probe_single_connector_modes,
    724 	.destroy = tda19988_connector_destroy,
    725 };
    726 
    727 static int
    728 tda19988_connector_get_modes(struct drm_connector *connector)
    729 {
    730 	struct tda19988_connector *tda_connector = to_tda_connector(connector);
    731 	struct tda19988_softc * const sc = tda_connector->sc;
    732 	struct edid *pedid = NULL;
    733 	int error;
    734 
    735 	if (sc->sc_edid_valid) {
    736 		pedid = (struct edid *)sc->sc_edid;
    737 	} else {
    738 		iic_acquire_bus(sc->sc_i2c, 0);
    739 		if (tda19988_read_edid(sc) == 0)
    740 			pedid = (struct edid *)sc->sc_edid;
    741 		iic_release_bus(sc->sc_i2c, 0);
    742 		sc->sc_edid_valid = true;
    743 	}
    744 
    745 	drm_mode_connector_update_edid_property(connector, pedid);
    746 	if (pedid == NULL)
    747 		return 0;
    748 
    749 	error = drm_add_edid_modes(connector, pedid);
    750 	drm_edid_to_eld(connector, pedid);
    751 
    752 	return error;
    753 }
    754 
    755 static struct drm_encoder *
    756 tda19988_connector_best_encoder(struct drm_connector *connector)
    757 {
    758 	int enc_id = connector->encoder_ids[0];
    759 	struct drm_mode_object *obj;
    760 	struct drm_encoder *encoder = NULL;
    761 
    762 	if (enc_id) {
    763 		obj = drm_mode_object_find(connector->dev, enc_id,
    764 		    DRM_MODE_OBJECT_ENCODER);
    765 		if (obj == NULL)
    766 			return NULL;
    767 		encoder = obj_to_encoder(obj);
    768 	}
    769 
    770 	return encoder;
    771 }
    772 
    773 static const struct drm_connector_helper_funcs tda19988_connector_helper_funcs = {
    774 	.get_modes = tda19988_connector_get_modes,
    775 	.best_encoder = tda19988_connector_best_encoder,
    776 };
    777 
    778 static int
    779 tda19988_bridge_attach(struct drm_bridge *bridge)
    780 {
    781 	struct tda19988_softc *sc = bridge->driver_private;
    782 	struct tda19988_connector *tda_connector = &sc->sc_connector;
    783 	struct drm_connector *connector = &tda_connector->base;
    784 	int error;
    785 
    786 	tda_connector->sc = sc;
    787 
    788 	connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
    789 	connector->interlace_allowed = 1;
    790 	connector->doublescan_allowed = 0;
    791 
    792 	drm_connector_init(bridge->dev, connector, &tda19988_connector_funcs,
    793 	    DRM_MODE_CONNECTOR_HDMIA);
    794 	drm_connector_helper_add(connector, &tda19988_connector_helper_funcs);
    795 
    796 	error = drm_mode_connector_attach_encoder(connector, bridge->encoder);
    797 	if (error != 0)
    798 		return error;
    799 
    800 	return drm_connector_register(connector);
    801 }
    802 
    803 static void
    804 tda19988_bridge_enable(struct drm_bridge *bridge)
    805 {
    806 	struct tda19988_softc * const sc = bridge->driver_private;
    807 
    808 	fdtbus_pinctrl_set_config(sc->sc_phandle, "default");
    809 }
    810 
    811 static void
    812 tda19988_bridge_pre_enable(struct drm_bridge *bridge)
    813 {
    814 }
    815 
    816 static void
    817 tda19988_bridge_disable(struct drm_bridge *bridge)
    818 {
    819 	struct tda19988_softc * const sc = bridge->driver_private;
    820 
    821 	fdtbus_pinctrl_set_config(sc->sc_phandle, "off");
    822 }
    823 
    824 static void
    825 tda19988_bridge_post_disable(struct drm_bridge *bridge)
    826 {
    827 }
    828 
    829 static void
    830 tda19988_bridge_mode_set(struct drm_bridge *bridge,
    831     struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode)
    832 {
    833 	struct tda19988_softc * const sc = bridge->driver_private;
    834 
    835 	iic_acquire_bus(sc->sc_i2c, 0);
    836 	tda19988_init_encoder(sc, adjusted_mode);
    837 	iic_release_bus(sc->sc_i2c, 0);
    838 }
    839 
    840 static bool
    841 tda19988_bridge_mode_fixup(struct drm_bridge *bridge,
    842     const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode)
    843 {
    844 	return true;
    845 }
    846 
    847 static const struct drm_bridge_funcs tda19988_bridge_funcs = {
    848 	.attach = tda19988_bridge_attach,
    849 	.enable = tda19988_bridge_enable,
    850 	.pre_enable = tda19988_bridge_pre_enable,
    851 	.disable = tda19988_bridge_disable,
    852 	.post_disable = tda19988_bridge_post_disable,
    853 	.mode_set = tda19988_bridge_mode_set,
    854 	.mode_fixup = tda19988_bridge_mode_fixup,
    855 };
    856 
    857 static int
    858 tda19988_ep_activate(device_t dev, struct fdt_endpoint *ep, bool activate)
    859 {
    860 	struct tda19988_softc *sc = device_private(dev);
    861 	struct fdt_endpoint *in_ep = fdt_endpoint_remote(ep);
    862 	struct drm_encoder *encoder;
    863 	int error;
    864 
    865 	if (!activate)
    866 		return EINVAL;
    867 
    868 	if (fdt_endpoint_port_index(ep) != TDA19988_PORT_INPUT)
    869 		return EINVAL;
    870 
    871 	switch (fdt_endpoint_type(in_ep)) {
    872 	case EP_DRM_ENCODER:
    873 		encoder = fdt_endpoint_get_data(in_ep);
    874 		break;
    875 	default:
    876 		encoder = NULL;
    877 		break;
    878 	}
    879 
    880 	if (encoder == NULL)
    881 		return EINVAL;
    882 
    883 	sc->sc_bridge.driver_private = sc;
    884 	sc->sc_bridge.funcs = &tda19988_bridge_funcs;
    885 	sc->sc_bridge.encoder = encoder;
    886 	error = drm_bridge_attach(encoder->dev, &sc->sc_bridge);
    887 	if (error != 0)
    888 		return EIO;
    889 
    890 	encoder->bridge = &sc->sc_bridge;
    891 
    892 	return 0;
    893 }
    894 
    895 static void *
    896 tda19988_ep_get_data(device_t dev, struct fdt_endpoint *ep)
    897 {
    898 	struct tda19988_softc *sc = device_private(dev);
    899 
    900 	return &sc->sc_bridge;
    901 }
    902 
    903 static void
    904 tda19988_attach(device_t parent, device_t self, void *aux)
    905 {
    906 	struct tda19988_softc *sc = device_private(self);
    907 	struct i2c_attach_args * const ia = aux;
    908 	const int phandle = ia->ia_cookie;
    909 
    910 	sc->sc_dev = self;
    911 	sc->sc_phandle = phandle;
    912 	sc->sc_i2c = ia->ia_tag;
    913 	sc->sc_addr = ia->ia_addr;
    914 	sc->sc_cec_addr = 0x34; /* hardcoded */
    915 	sc->sc_current_page = 0xff;
    916 	sc->sc_edid = kmem_zalloc(EDID_LENGTH, KM_SLEEP);
    917 	sc->sc_edid_len = EDID_LENGTH;
    918 	sc->sc_edid_valid = false;
    919 	sc->sc_last_status = connector_status_unknown;
    920 
    921 	aprint_naive("\n");
    922 	aprint_normal(": NXP TDA19988 HDMI transmitter\n");
    923 
    924 	iic_acquire_bus(sc->sc_i2c, 0);
    925 	tda19988_start(sc);
    926 	iic_release_bus(sc->sc_i2c, 0);
    927 
    928 	sc->sc_ports.dp_ep_activate = tda19988_ep_activate;
    929 	sc->sc_ports.dp_ep_get_data = tda19988_ep_get_data;
    930 	fdt_ports_register(&sc->sc_ports, self, phandle, EP_DRM_ENCODER);
    931 }
    932 
    933 CFATTACH_DECL_NEW(tdahdmi, sizeof(struct tda19988_softc),
    934     tda19988_match, tda19988_attach, NULL, NULL);
    935