ld.c revision 1.4 1 /* $NetBSD: ld.c,v 1.4 2001/01/07 18:09:01 fvdl Exp $ */
2
3 /*-
4 * Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
5 * All rights reserved.
6 *
7 * This code is derived from software contributed to The NetBSD Foundation
8 * by Andrew Doran and Charles M. Hannum.
9 *
10 * Redistribution and use in source and binary forms, with or without
11 * modification, are permitted provided that the following conditions
12 * are met:
13 * 1. Redistributions of source code must retain the above copyright
14 * notice, this list of conditions and the following disclaimer.
15 * 2. Redistributions in binary form must reproduce the above copyright
16 * notice, this list of conditions and the following disclaimer in the
17 * documentation and/or other materials provided with the distribution.
18 * 3. All advertising materials mentioning features or use of this software
19 * must display the following acknowledgement:
20 * This product includes software developed by the NetBSD
21 * Foundation, Inc. and its contributors.
22 * 4. Neither the name of The NetBSD Foundation nor the names of its
23 * contributors may be used to endorse or promote products derived
24 * from this software without specific prior written permission.
25 *
26 * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
27 * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
28 * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
29 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
30 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
31 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
32 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
33 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
34 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
35 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
36 * POSSIBILITY OF SUCH DAMAGE.
37 */
38
39 /*
40 * Disk driver for use by RAID controllers.
41 */
42
43 #include "rnd.h"
44
45 #include <sys/param.h>
46 #include <sys/systm.h>
47 #include <sys/kernel.h>
48 #include <sys/device.h>
49 #include <sys/queue.h>
50 #include <sys/proc.h>
51 #include <sys/buf.h>
52 #include <sys/endian.h>
53 #include <sys/disklabel.h>
54 #include <sys/disk.h>
55 #include <sys/dkio.h>
56 #include <sys/stat.h>
57 #include <sys/lock.h>
58 #include <sys/conf.h>
59 #include <sys/fcntl.h>
60 #include <sys/vnode.h>
61 #include <sys/syslog.h>
62 #if NRND > 0
63 #include <sys/rnd.h>
64 #endif
65
66 #include <dev/ldvar.h>
67
68 static void ldgetdefaultlabel(struct ld_softc *, struct disklabel *);
69 static void ldgetdisklabel(struct ld_softc *);
70 static int ldlock(struct ld_softc *);
71 static void ldminphys(struct buf *bp);
72 static void ldshutdown(void *);
73 static int ldstart(struct ld_softc *, struct buf *);
74 static void ldunlock(struct ld_softc *);
75
76 extern struct cfdriver ld_cd;
77
78 static struct dkdriver lddkdriver = { ldstrategy };
79 static void *ld_sdh;
80
81 void
82 ldattach(struct ld_softc *sc)
83 {
84 char buf[9];
85
86 /* Initialise and attach the disk structure. */
87 sc->sc_dk.dk_driver = &lddkdriver;
88 sc->sc_dk.dk_name = sc->sc_dv.dv_xname;
89 disk_attach(&sc->sc_dk);
90
91 if ((sc->sc_flags & LDF_ENABLED) == 0) {
92 printf("%s: disabled\n", sc->sc_dv.dv_xname);
93 return;
94 }
95 if (sc->sc_maxxfer > MAXPHYS)
96 sc->sc_maxxfer = MAXPHYS;
97
98 format_bytes(buf, sizeof(buf), (u_int64_t)sc->sc_secperunit *
99 sc->sc_secsize);
100 printf("%s: %s, %d cyl, %d head, %d sec, %d bytes/sect x %d sectors\n",
101 sc->sc_dv.dv_xname, buf, sc->sc_ncylinders, sc->sc_nheads,
102 sc->sc_nsectors, sc->sc_secsize, sc->sc_secperunit);
103
104 #if NRND > 0
105 /* Attach the device into the rnd source list. */
106 rnd_attach_source(&sc->sc_rnd_source, sc->sc_dv.dv_xname,
107 RND_TYPE_DISK, 0);
108 #endif
109
110 /* Set the `shutdownhook'. */
111 if (ld_sdh == NULL)
112 ld_sdh = shutdownhook_establish(ldshutdown, NULL);
113 BUFQ_INIT(&sc->sc_bufq);
114 }
115
116 int
117 lddrain(struct ld_softc *sc, int flags)
118 {
119 int s;
120
121 if ((flags & DETACH_FORCE) == 0 && sc->sc_dk.dk_openmask != 0)
122 return (EBUSY);
123
124 s = splbio();
125 sc->sc_flags |= LDF_DRAIN;
126 splx(s);
127 return (0);
128 }
129
130 void
131 lddetach(struct ld_softc *sc)
132 {
133 struct buf *bp;
134 int s, bmaj, cmaj, mn;
135
136 /* Wait for commands queued with the hardware to complete. */
137 if (sc->sc_queuecnt != 0)
138 tsleep(&sc->sc_queuecnt, PRIBIO, "lddrn", 30 * hz);
139
140 /* Locate the major numbers. */
141 for (bmaj = 0; bmaj <= nblkdev; bmaj++)
142 if (bdevsw[bmaj].d_open == sdopen)
143 break;
144 for (cmaj = 0; cmaj <= nchrdev; cmaj++)
145 if (cdevsw[cmaj].d_open == sdopen)
146 break;
147
148 /* Kill off any queued buffers. */
149 s = splbio();
150 while ((bp = BUFQ_FIRST(&sc->sc_bufq)) != NULL) {
151 BUFQ_REMOVE(&sc->sc_bufq, bp);
152 bp->b_error = EIO;
153 bp->b_flags |= B_ERROR;
154 bp->b_resid = bp->b_bcount;
155 biodone(bp);
156 }
157 splx(s);
158
159 /* Nuke the vnodes for any open instances. */
160 mn = DISKUNIT(sc->sc_dv.dv_unit);
161 vdevgone(bmaj, mn, mn + (MAXPARTITIONS - 1), VBLK);
162 vdevgone(cmaj, mn, mn + (MAXPARTITIONS - 1), VCHR);
163
164 /* Detach from the disk list. */
165 disk_detach(&sc->sc_dk);
166
167 #if NRND > 0
168 /* Unhook the entropy source. */
169 rnd_detach_source(&sc->sc_rnd_source);
170 #endif
171
172 /* Flush the device's cache. */
173 if (sc->sc_flush != NULL)
174 if ((*sc->sc_flush)(sc) != 0)
175 printf("%s: unable to flush cache\n",
176 sc->sc_dv.dv_xname);
177 }
178
179 static void
180 ldshutdown(void *cookie)
181 {
182 struct ld_softc *sc;
183 int i;
184
185 for (i = 0; i < ld_cd.cd_ndevs; i++) {
186 if ((sc = device_lookup(&ld_cd, i)) == NULL)
187 continue;
188 if (sc->sc_flush != NULL && (*sc->sc_flush)(sc) != 0)
189 printf("%s: unable to flush cache\n",
190 sc->sc_dv.dv_xname);
191 }
192 }
193
194 int
195 ldopen(dev_t dev, int flags, int fmt, struct proc *p)
196 {
197 struct ld_softc *sc;
198 int unit, part;
199
200 unit = DISKUNIT(dev);
201 if ((sc = device_lookup(&ld_cd, unit))== NULL)
202 return (ENXIO);
203 if ((sc->sc_flags & LDF_ENABLED) == 0)
204 return (ENODEV);
205 part = DISKPART(dev);
206 ldlock(sc);
207
208 if (sc->sc_dk.dk_openmask == 0)
209 ldgetdisklabel(sc);
210
211 /* Check that the partition exists. */
212 if (part != RAW_PART && (part >= sc->sc_dk.dk_label->d_npartitions ||
213 sc->sc_dk.dk_label->d_partitions[part].p_fstype == FS_UNUSED)) {
214 ldunlock(sc);
215 return (ENXIO);
216 }
217
218 /* Ensure only one open at a time. */
219 switch (fmt) {
220 case S_IFCHR:
221 sc->sc_dk.dk_copenmask |= (1 << part);
222 break;
223 case S_IFBLK:
224 sc->sc_dk.dk_bopenmask |= (1 << part);
225 break;
226 }
227 sc->sc_dk.dk_openmask =
228 sc->sc_dk.dk_copenmask | sc->sc_dk.dk_bopenmask;
229
230 ldunlock(sc);
231 return (0);
232 }
233
234 int
235 ldclose(dev_t dev, int flags, int fmt, struct proc *p)
236 {
237 struct ld_softc *sc;
238 int part, unit;
239
240 unit = DISKUNIT(dev);
241 part = DISKPART(dev);
242 sc = device_lookup(&ld_cd, unit);
243 ldlock(sc);
244
245 switch (fmt) {
246 case S_IFCHR:
247 sc->sc_dk.dk_copenmask &= ~(1 << part);
248 break;
249 case S_IFBLK:
250 sc->sc_dk.dk_bopenmask &= ~(1 << part);
251 break;
252 }
253 sc->sc_dk.dk_openmask =
254 sc->sc_dk.dk_copenmask | sc->sc_dk.dk_bopenmask;
255
256 if (sc->sc_dk.dk_openmask == 0 && sc->sc_flush != NULL)
257 if ((*sc->sc_flush)(sc) != 0)
258 printf("%s: unable to flush cache\n",
259 sc->sc_dv.dv_xname);
260
261 ldunlock(sc);
262 return (0);
263 }
264
265 int
266 ldread(dev_t dev, struct uio *uio, int ioflag)
267 {
268
269 return (physio(ldstrategy, NULL, dev, B_READ, ldminphys, uio));
270 }
271
272 int
273 ldwrite(dev_t dev, struct uio *uio, int ioflag)
274 {
275
276 return (physio(ldstrategy, NULL, dev, B_WRITE, ldminphys, uio));
277 }
278
279 int
280 ldioctl(dev_t dev, u_long cmd, caddr_t addr, int32_t flag, struct proc *p)
281 {
282 struct ld_softc *sc;
283 int part, unit, error;
284 #ifdef __HAVE_OLD_DISKLABEL
285 struct disklabel newlabel, *lp;
286 #endif
287
288 unit = DISKUNIT(dev);
289 part = DISKPART(dev);
290 sc = device_lookup(&ld_cd, unit);
291 error = 0;
292
293 switch (cmd) {
294 case DIOCGDINFO:
295 memcpy(addr, sc->sc_dk.dk_label, sizeof(struct disklabel));
296 return (0);
297
298 #ifdef __HAVE_OLD_DISKLABEL
299 case ODIOCGDINFO:
300 newlabel = *(sc->sc_dk.dk_label);
301 if (newlabel.d_npartitions > OLDMAXPARTITIONS)
302 newlabel.d_npartitions = OLDMAXPARTITIONS;
303 memcpy(addr, &newlabel, sizeof(struct olddisklabel));
304 return (0);
305 #endif
306
307 case DIOCGPART:
308 ((struct partinfo *)addr)->disklab = sc->sc_dk.dk_label;
309 ((struct partinfo *)addr)->part =
310 &sc->sc_dk.dk_label->d_partitions[part];
311 break;
312
313 case DIOCWDINFO:
314 case DIOCSDINFO:
315 #ifdef __HAVE_OLD_DISKLABEL
316 case ODIOCWDINFO:
317 case ODIOCSDINFO:
318
319 if (cmd == ODIOCSDINFO || cmd == ODIOCWDINFO) {
320 memset(&newlabel, 0, sizeof newlabel);
321 memcpy(&newlabel, addr, sizeof (struct olddisklabel));
322 lp = &newlabel;
323 } else
324 #endif
325 lp = (struct disklabel *)addr;
326
327 if ((flag & FWRITE) == 0)
328 return (EBADF);
329
330 if ((error = ldlock(sc)) != 0)
331 return (error);
332 sc->sc_flags |= LDF_LABELLING;
333
334 error = setdisklabel(sc->sc_dk.dk_label,
335 lp, /*sc->sc_dk.dk_openmask : */0,
336 sc->sc_dk.dk_cpulabel);
337 if (error == 0 && (cmd == DIOCWDINFO
338 #ifdef __HAVE_OLD_DISKLABEL
339 || cmd == ODIOCWDINFO
340 #endif
341 ))
342 error = writedisklabel(
343 MAKEDISKDEV(major(dev), DISKUNIT(dev), RAW_PART),
344 ldstrategy, sc->sc_dk.dk_label,
345 sc->sc_dk.dk_cpulabel);
346
347 sc->sc_flags &= ~LDF_LABELLING;
348 ldunlock(sc);
349 break;
350
351 case DIOCWLABEL:
352 if ((flag & FWRITE) == 0)
353 return (EBADF);
354 if (*(int *)addr)
355 sc->sc_flags |= LDF_WLABEL;
356 else
357 sc->sc_flags &= ~LDF_WLABEL;
358 break;
359
360 case DIOCGDEFLABEL:
361 ldgetdefaultlabel(sc, (struct disklabel *)addr);
362 break;
363
364 #ifdef __HAVE_OLD_DISKLABEL
365 case ODIOCGDEFLABEL:
366 ldgetdefaultlabel(sc, &newlabel);
367 if (newlabel.d_npartitions > OLDMAXPARTITIONS)
368 newlabel.d_npartitions = OLDMAXPARTITIONS;
369 memcpy(addr, &newlabel, sizeof (struct olddisklabel));
370 break;
371 #endif
372
373 default:
374 error = ENOTTY;
375 break;
376 }
377
378 return (error);
379 }
380
381 void
382 ldstrategy(struct buf *bp)
383 {
384 struct ld_softc *sc;
385 int s;
386
387 sc = device_lookup(&ld_cd, DISKUNIT(bp->b_dev));
388
389 s = splbio();
390 if (sc->sc_queuecnt == sc->sc_maxqueuecnt) {
391 BUFQ_INSERT_TAIL(&sc->sc_bufq, bp);
392 splx(s);
393 return;
394 }
395 splx(s);
396 ldstart(sc, bp);
397 }
398
399 static int
400 ldstart(struct ld_softc *sc, struct buf *bp)
401 {
402 struct disklabel *lp;
403 int part, s, rv;
404
405 if ((sc->sc_flags & LDF_DRAIN) != 0) {
406 bp->b_error = EIO;
407 bp->b_flags |= B_ERROR;
408 bp->b_resid = bp->b_bcount;
409 biodone(bp);
410 return (-1);
411 }
412
413 part = DISKPART(bp->b_dev);
414 lp = sc->sc_dk.dk_label;
415
416 /*
417 * The transfer must be a whole number of blocks and the offset must
418 * not be negative.
419 */
420 if ((bp->b_bcount % lp->d_secsize) != 0 || bp->b_blkno < 0) {
421 bp->b_flags |= B_ERROR;
422 biodone(bp);
423 return (-1);
424 }
425
426 /*
427 * If it's a null transfer, return.
428 */
429 if (bp->b_bcount == 0) {
430 bp->b_resid = bp->b_bcount;
431 biodone(bp);
432 return (-1);
433 }
434
435 /*
436 * Do bounds checking and adjust the transfer. If error, process.
437 * If past the end of partition, just return.
438 */
439 if (part != RAW_PART &&
440 bounds_check_with_label(bp, lp,
441 (sc->sc_flags & (LDF_WLABEL | LDF_LABELLING)) != 0) <= 0) {
442 bp->b_resid = bp->b_bcount;
443 biodone(bp);
444 return (-1);
445 }
446
447 /*
448 * Convert the logical block number to a physical one and put it in
449 * terms of the device's logical block size.
450 */
451 if (lp->d_secsize >= DEV_BSIZE)
452 bp->b_rawblkno = bp->b_blkno / (lp->d_secsize / DEV_BSIZE);
453 else
454 bp->b_rawblkno = bp->b_blkno * (DEV_BSIZE / lp->d_secsize);
455
456 if (bp->b_dev != RAW_PART)
457 bp->b_rawblkno += lp->d_partitions[part].p_offset;
458
459 s = splbio();
460 disk_busy(&sc->sc_dk);
461 sc->sc_queuecnt++;
462 splx(s);
463
464 if ((rv = (*sc->sc_start)(sc, bp)) != 0) {
465 bp->b_error = rv;
466 bp->b_flags |= B_ERROR;
467 bp->b_resid = bp->b_bcount;
468 s = splbio();
469 lddone(sc, bp);
470 splx(s);
471 }
472
473 return (0);
474 }
475
476 void
477 lddone(struct ld_softc *sc, struct buf *bp)
478 {
479
480 if ((bp->b_flags & B_ERROR) != 0) {
481 diskerr(bp, "ld", "error", LOG_PRINTF, 0, sc->sc_dk.dk_label);
482 printf("\n");
483 }
484
485 disk_unbusy(&sc->sc_dk, bp->b_bcount - bp->b_resid);
486 #if NRND > 0
487 rnd_add_uint32(&sc->sc_rnd_source, bp->b_rawblkno);
488 #endif
489 biodone(bp);
490 if (--sc->sc_queuecnt == 0 && (sc->sc_flags & LDF_DRAIN) != 0)
491 wakeup(&sc->sc_queuecnt);
492
493 while ((bp = BUFQ_FIRST(&sc->sc_bufq)) != NULL) {
494 BUFQ_REMOVE(&sc->sc_bufq, bp);
495 if (!ldstart(sc, bp))
496 break;
497 }
498 }
499
500 int
501 ldsize(dev_t dev)
502 {
503 struct ld_softc *sc;
504 int part, unit, omask, size;
505
506 unit = DISKUNIT(dev);
507 if ((sc = device_lookup(&ld_cd, unit)) == NULL)
508 return (ENODEV);
509 if ((sc->sc_flags & LDF_ENABLED) == 0)
510 return (ENODEV);
511 part = DISKPART(dev);
512
513 omask = sc->sc_dk.dk_openmask & (1 << part);
514
515 if (omask == 0 && ldopen(dev, 0, S_IFBLK, NULL) != 0)
516 return (-1);
517 else if (sc->sc_dk.dk_label->d_partitions[part].p_fstype != FS_SWAP)
518 size = -1;
519 else
520 size = sc->sc_dk.dk_label->d_partitions[part].p_size *
521 (sc->sc_dk.dk_label->d_secsize / DEV_BSIZE);
522 if (omask == 0 && ldclose(dev, 0, S_IFBLK, NULL) != 0)
523 return (-1);
524
525 return (size);
526 }
527
528 /*
529 * Load the label information from the specified device.
530 */
531 static void
532 ldgetdisklabel(struct ld_softc *sc)
533 {
534 const char *errstring;
535
536 ldgetdefaultlabel(sc, sc->sc_dk.dk_label);
537
538 /* Call the generic disklabel extraction routine. */
539 errstring = readdisklabel(MAKEDISKDEV(0, sc->sc_dv.dv_unit, RAW_PART),
540 ldstrategy, sc->sc_dk.dk_label, sc->sc_dk.dk_cpulabel);
541 if (errstring != NULL)
542 printf("%s: %s\n", sc->sc_dv.dv_xname, errstring);
543 }
544
545 /*
546 * Construct a ficticious label.
547 */
548 static void
549 ldgetdefaultlabel(struct ld_softc *sc, struct disklabel *lp)
550 {
551
552 memset(lp, 0, sizeof(struct disklabel));
553
554 lp->d_secsize = sc->sc_secsize;
555 lp->d_ntracks = sc->sc_nheads;
556 lp->d_nsectors = sc->sc_nsectors;
557 lp->d_ncylinders = sc->sc_ncylinders;
558 lp->d_secpercyl = lp->d_ntracks * lp->d_nsectors;
559 lp->d_type = DTYPE_LD;
560 strcpy(lp->d_typename, "unknown");
561 strcpy(lp->d_packname, "fictitious");
562 lp->d_secperunit = sc->sc_secperunit;
563 lp->d_rpm = 7200;
564 lp->d_interleave = 1;
565 lp->d_flags = 0;
566
567 lp->d_partitions[RAW_PART].p_offset = 0;
568 lp->d_partitions[RAW_PART].p_size =
569 lp->d_secperunit * (lp->d_secsize / DEV_BSIZE);
570 lp->d_partitions[RAW_PART].p_fstype = FS_UNUSED;
571 lp->d_npartitions = RAW_PART + 1;
572
573 lp->d_magic = DISKMAGIC;
574 lp->d_magic2 = DISKMAGIC;
575 lp->d_checksum = dkcksum(lp);
576 }
577
578 /*
579 * Wait interruptibly for an exclusive lock.
580 *
581 * XXX Several drivers do this; it should be abstracted and made MP-safe.
582 */
583 static int
584 ldlock(struct ld_softc *sc)
585 {
586 int error;
587
588 while ((sc->sc_flags & LDF_LKHELD) != 0) {
589 sc->sc_flags |= LDF_LKWANTED;
590 if ((error = tsleep(sc, PRIBIO | PCATCH, "ldlck", 0)) != 0)
591 return (error);
592 }
593 sc->sc_flags |= LDF_LKHELD;
594 return (0);
595 }
596
597 /*
598 * Unlock and wake up any waiters.
599 */
600 static void
601 ldunlock(struct ld_softc *sc)
602 {
603
604 sc->sc_flags &= ~LDF_LKHELD;
605 if ((sc->sc_flags & LDF_LKWANTED) != 0) {
606 sc->sc_flags &= ~LDF_LKWANTED;
607 wakeup(sc);
608 }
609 }
610
611 /*
612 * Take a dump.
613 */
614 int
615 lddump(dev_t dev, daddr_t blkno, caddr_t va, size_t size)
616 {
617 struct ld_softc *sc;
618 struct disklabel *lp;
619 int unit, part, nsects, sectoff, towrt, nblk, maxblkcnt, rv;
620 static int dumping;
621
622 unit = DISKUNIT(dev);
623 if ((sc = device_lookup(&ld_cd, unit)) == NULL)
624 return (ENXIO);
625 if ((sc->sc_flags & LDF_ENABLED) == 0)
626 return (ENODEV);
627 if (sc->sc_dump == NULL)
628 return (ENXIO);
629
630 /* Check if recursive dump; if so, punt. */
631 if (dumping)
632 return (EFAULT);
633 dumping = 1;
634
635 /* Convert to disk sectors. Request must be a multiple of size. */
636 part = DISKPART(dev);
637 lp = sc->sc_dk.dk_label;
638 if ((size % lp->d_secsize) != 0)
639 return (EFAULT);
640 towrt = size / lp->d_secsize;
641 blkno = dbtob(blkno) / lp->d_secsize; /* blkno in DEV_BSIZE units */
642
643 nsects = lp->d_partitions[part].p_size;
644 sectoff = lp->d_partitions[part].p_offset;
645
646 /* Check transfer bounds against partition size. */
647 if ((blkno < 0) || ((blkno + towrt) > nsects))
648 return (EINVAL);
649
650 /* Offset block number to start of partition. */
651 blkno += sectoff;
652
653 /* Start dumping and return when done. */
654 maxblkcnt = sc->sc_maxxfer / sc->sc_secsize - 1;
655 while (towrt > 0) {
656 nblk = min(maxblkcnt, towrt);
657
658 if ((rv = (*sc->sc_dump)(sc, va, blkno, nblk)) != 0)
659 return (rv);
660
661 towrt -= nblk;
662 blkno += nblk;
663 va += nblk * sc->sc_secsize;
664 }
665
666 dumping = 0;
667 return (0);
668 }
669
670 /*
671 * Adjust the size of a transfer.
672 */
673 static void
674 ldminphys(struct buf *bp)
675 {
676 struct ld_softc *sc;
677
678 sc = device_lookup(&ld_cd, DISKUNIT(bp->b_dev));
679
680 if (bp->b_bcount > sc->sc_maxxfer)
681 bp->b_bcount = sc->sc_maxxfer;
682 minphys(bp);
683 }
684