agp_intel.c revision 1.38 1 1.38 mrg /* $NetBSD: agp_intel.c,v 1.38 2019/02/05 11:20:21 mrg Exp $ */
2 1.1 fvdl
3 1.1 fvdl /*-
4 1.1 fvdl * Copyright (c) 2000 Doug Rabson
5 1.1 fvdl * All rights reserved.
6 1.1 fvdl *
7 1.1 fvdl * Redistribution and use in source and binary forms, with or without
8 1.1 fvdl * modification, are permitted provided that the following conditions
9 1.1 fvdl * are met:
10 1.1 fvdl * 1. Redistributions of source code must retain the above copyright
11 1.1 fvdl * notice, this list of conditions and the following disclaimer.
12 1.1 fvdl * 2. Redistributions in binary form must reproduce the above copyright
13 1.1 fvdl * notice, this list of conditions and the following disclaimer in the
14 1.1 fvdl * documentation and/or other materials provided with the distribution.
15 1.1 fvdl *
16 1.1 fvdl * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
17 1.1 fvdl * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
18 1.1 fvdl * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
19 1.1 fvdl * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
20 1.1 fvdl * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
21 1.1 fvdl * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
22 1.1 fvdl * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
23 1.1 fvdl * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
24 1.1 fvdl * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
25 1.1 fvdl * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
26 1.1 fvdl * SUCH DAMAGE.
27 1.1 fvdl *
28 1.1 fvdl * $FreeBSD: src/sys/pci/agp_intel.c,v 1.4 2001/07/05 21:28:47 jhb Exp $
29 1.1 fvdl */
30 1.4 lukem
31 1.4 lukem #include <sys/cdefs.h>
32 1.38 mrg __KERNEL_RCSID(0, "$NetBSD: agp_intel.c,v 1.38 2019/02/05 11:20:21 mrg Exp $");
33 1.1 fvdl
34 1.1 fvdl #include <sys/param.h>
35 1.1 fvdl #include <sys/systm.h>
36 1.1 fvdl #include <sys/malloc.h>
37 1.1 fvdl #include <sys/kernel.h>
38 1.1 fvdl #include <sys/proc.h>
39 1.1 fvdl #include <sys/agpio.h>
40 1.1 fvdl #include <sys/device.h>
41 1.1 fvdl
42 1.1 fvdl #include <dev/pci/pcivar.h>
43 1.1 fvdl #include <dev/pci/pcireg.h>
44 1.7 ichiro #include <dev/pci/pcidevs.h>
45 1.1 fvdl #include <dev/pci/agpvar.h>
46 1.1 fvdl #include <dev/pci/agpreg.h>
47 1.1 fvdl
48 1.23 ad #include <sys/bus.h>
49 1.1 fvdl
50 1.1 fvdl struct agp_intel_softc {
51 1.7 ichiro u_int32_t initial_aperture;
52 1.7 ichiro /* aperture size at startup */
53 1.7 ichiro struct agp_gatt *gatt;
54 1.10 ichiro struct pci_attach_args vga_pa;
55 1.10 ichiro u_int aperture_mask;
56 1.10 ichiro int chiptype; /* Chip type */
57 1.8 ichiro #define CHIP_INTEL 0x0
58 1.8 ichiro #define CHIP_I443 0x1
59 1.8 ichiro #define CHIP_I840 0x2
60 1.8 ichiro #define CHIP_I845 0x3
61 1.8 ichiro #define CHIP_I850 0x4
62 1.14 tron #define CHIP_I865 0x5
63 1.18 jmcneill
64 1.1 fvdl };
65 1.1 fvdl
66 1.1 fvdl static u_int32_t agp_intel_get_aperture(struct agp_softc *);
67 1.1 fvdl static int agp_intel_set_aperture(struct agp_softc *, u_int32_t);
68 1.1 fvdl static int agp_intel_bind_page(struct agp_softc *, off_t, bus_addr_t);
69 1.1 fvdl static int agp_intel_unbind_page(struct agp_softc *, off_t);
70 1.1 fvdl static void agp_intel_flush_tlb(struct agp_softc *);
71 1.24 joerg static int agp_intel_init(struct agp_softc *);
72 1.34 dyoung static bool agp_intel_resume(device_t, const pmf_qual_t *);
73 1.1 fvdl
74 1.15 thorpej static struct agp_methods agp_intel_methods = {
75 1.1 fvdl agp_intel_get_aperture,
76 1.1 fvdl agp_intel_set_aperture,
77 1.1 fvdl agp_intel_bind_page,
78 1.1 fvdl agp_intel_unbind_page,
79 1.1 fvdl agp_intel_flush_tlb,
80 1.1 fvdl agp_generic_enable,
81 1.1 fvdl agp_generic_alloc_memory,
82 1.1 fvdl agp_generic_free_memory,
83 1.1 fvdl agp_generic_bind_memory,
84 1.1 fvdl agp_generic_unbind_memory,
85 1.1 fvdl };
86 1.1 fvdl
87 1.7 ichiro static int
88 1.37 dyoung agp_intel_vgamatch(const struct pci_attach_args *pa)
89 1.7 ichiro {
90 1.7 ichiro switch (PCI_PRODUCT(pa->pa_id)) {
91 1.35 jakllsch case PCI_PRODUCT_INTEL_82855GM_AGP:
92 1.7 ichiro case PCI_PRODUCT_INTEL_82855PM_AGP:
93 1.7 ichiro case PCI_PRODUCT_INTEL_82443LX_AGP:
94 1.7 ichiro case PCI_PRODUCT_INTEL_82443BX_AGP:
95 1.7 ichiro case PCI_PRODUCT_INTEL_82443GX_AGP:
96 1.10 ichiro case PCI_PRODUCT_INTEL_82850_AGP: /* i850/i860 */
97 1.7 ichiro case PCI_PRODUCT_INTEL_82845_AGP:
98 1.7 ichiro case PCI_PRODUCT_INTEL_82840_AGP:
99 1.11 tron case PCI_PRODUCT_INTEL_82865_AGP:
100 1.11 tron case PCI_PRODUCT_INTEL_82875P_AGP:
101 1.7 ichiro return (1);
102 1.7 ichiro }
103 1.7 ichiro
104 1.7 ichiro return (0);
105 1.7 ichiro }
106 1.7 ichiro
107 1.1 fvdl int
108 1.32 freza agp_intel_attach(device_t parent, device_t self, void *aux)
109 1.1 fvdl {
110 1.32 freza struct agp_softc *sc = device_private(self);
111 1.32 freza struct pci_attach_args *pa = aux;
112 1.1 fvdl struct agp_intel_softc *isc;
113 1.1 fvdl struct agp_gatt *gatt;
114 1.10 ichiro u_int32_t value;
115 1.1 fvdl
116 1.5 tsutsui isc = malloc(sizeof *isc, M_AGP, M_NOWAIT|M_ZERO);
117 1.1 fvdl if (isc == NULL) {
118 1.6 thorpej aprint_error(": can't allocate chipset-specific softc\n");
119 1.1 fvdl return ENOMEM;
120 1.1 fvdl }
121 1.2 fvdl
122 1.1 fvdl sc->as_methods = &agp_intel_methods;
123 1.2 fvdl sc->as_chipc = isc;
124 1.2 fvdl
125 1.7 ichiro if (pci_find_device(&isc->vga_pa, agp_intel_vgamatch) == 0) {
126 1.10 ichiro aprint_normal(": using generic initialization for Intel AGP\n");
127 1.32 freza aprint_normal_dev(sc->as_dev, "");
128 1.10 ichiro isc->chiptype = CHIP_INTEL;
129 1.7 ichiro }
130 1.7 ichiro
131 1.1 fvdl pci_get_capability(pa->pa_pc, pa->pa_tag, PCI_CAP_AGP, &sc->as_capoff,
132 1.1 fvdl NULL);
133 1.1 fvdl
134 1.17 christos if (agp_map_aperture(pa, sc, AGP_APBASE) != 0) {
135 1.6 thorpej aprint_error(": can't map aperture\n");
136 1.1 fvdl free(isc, M_AGP);
137 1.2 fvdl sc->as_chipc = NULL;
138 1.1 fvdl return ENXIO;
139 1.1 fvdl }
140 1.1 fvdl
141 1.7 ichiro switch (PCI_PRODUCT(isc->vga_pa.pa_id)) {
142 1.14 tron case PCI_PRODUCT_INTEL_82443LX_AGP:
143 1.14 tron case PCI_PRODUCT_INTEL_82443BX_AGP:
144 1.14 tron case PCI_PRODUCT_INTEL_82443GX_AGP:
145 1.14 tron isc->chiptype = CHIP_I443;
146 1.14 tron break;
147 1.14 tron case PCI_PRODUCT_INTEL_82840_AGP:
148 1.14 tron isc->chiptype = CHIP_I840;
149 1.14 tron break;
150 1.35 jakllsch case PCI_PRODUCT_INTEL_82855GM_AGP:
151 1.7 ichiro case PCI_PRODUCT_INTEL_82855PM_AGP:
152 1.7 ichiro case PCI_PRODUCT_INTEL_82845_AGP:
153 1.7 ichiro isc->chiptype = CHIP_I845;
154 1.7 ichiro break;
155 1.7 ichiro case PCI_PRODUCT_INTEL_82850_AGP:
156 1.8 ichiro isc->chiptype = CHIP_I850;
157 1.7 ichiro break;
158 1.14 tron case PCI_PRODUCT_INTEL_82865_AGP:
159 1.14 tron case PCI_PRODUCT_INTEL_82875P_AGP:
160 1.14 tron isc->chiptype = CHIP_I865;
161 1.7 ichiro break;
162 1.7 ichiro }
163 1.7 ichiro
164 1.10 ichiro /* Determine maximum supported aperture size. */
165 1.10 ichiro value = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_APSIZE);
166 1.10 ichiro pci_conf_write(sc->as_pc, sc->as_tag,
167 1.10 ichiro AGP_INTEL_APSIZE, APSIZE_MASK);
168 1.10 ichiro isc->aperture_mask = pci_conf_read(sc->as_pc, sc->as_tag,
169 1.10 ichiro AGP_INTEL_APSIZE) & APSIZE_MASK;
170 1.10 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_APSIZE, value);
171 1.1 fvdl isc->initial_aperture = AGP_GET_APERTURE(sc);
172 1.1 fvdl
173 1.1 fvdl for (;;) {
174 1.1 fvdl gatt = agp_alloc_gatt(sc);
175 1.1 fvdl if (gatt)
176 1.1 fvdl break;
177 1.1 fvdl
178 1.1 fvdl /*
179 1.1 fvdl * Probably contigmalloc failure. Try reducing the
180 1.1 fvdl * aperture so that the gatt size reduces.
181 1.1 fvdl */
182 1.1 fvdl if (AGP_SET_APERTURE(sc, AGP_GET_APERTURE(sc) / 2)) {
183 1.1 fvdl agp_generic_detach(sc);
184 1.6 thorpej aprint_error(": failed to set aperture\n");
185 1.1 fvdl return ENOMEM;
186 1.1 fvdl }
187 1.1 fvdl }
188 1.1 fvdl isc->gatt = gatt;
189 1.1 fvdl
190 1.25 jmcneill if (!pmf_device_register(self, NULL, agp_intel_resume))
191 1.25 jmcneill aprint_error_dev(self, "couldn't establish power handler\n");
192 1.25 jmcneill
193 1.24 joerg return agp_intel_init(sc);
194 1.24 joerg }
195 1.24 joerg
196 1.24 joerg static int
197 1.24 joerg agp_intel_init(struct agp_softc *sc)
198 1.24 joerg {
199 1.24 joerg struct agp_intel_softc *isc = sc->as_chipc;
200 1.24 joerg struct agp_gatt *gatt = isc->gatt;
201 1.24 joerg pcireg_t reg;
202 1.24 joerg
203 1.1 fvdl /* Install the gatt. */
204 1.1 fvdl pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_ATTBASE,
205 1.1 fvdl gatt->ag_physical);
206 1.8 ichiro
207 1.8 ichiro /* Enable the GLTB and setup the control register. */
208 1.8 ichiro switch (isc->chiptype) {
209 1.8 ichiro case CHIP_I443:
210 1.8 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
211 1.8 ichiro AGPCTRL_AGPRSE | AGPCTRL_GTLB);
212 1.38 mrg break;
213 1.8 ichiro
214 1.8 ichiro default:
215 1.8 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
216 1.9 ichiro pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL)
217 1.9 ichiro | AGPCTRL_GTLB);
218 1.8 ichiro }
219 1.10 ichiro
220 1.1 fvdl /* Enable things, clear errors etc. */
221 1.7 ichiro switch (isc->chiptype) {
222 1.7 ichiro case CHIP_I845:
223 1.14 tron case CHIP_I865:
224 1.7 ichiro {
225 1.14 tron reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_I840_MCHCFG);
226 1.14 tron reg |= MCHCFG_AAGN;
227 1.14 tron pci_conf_write(sc->as_pc, sc->as_tag, AGP_I840_MCHCFG, reg);
228 1.7 ichiro break;
229 1.7 ichiro }
230 1.7 ichiro case CHIP_I840:
231 1.8 ichiro case CHIP_I850:
232 1.7 ichiro {
233 1.10 ichiro reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCMD);
234 1.10 ichiro reg |= AGPCMD_AGPEN;
235 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCMD,
236 1.10 ichiro reg);
237 1.10 ichiro reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_I840_MCHCFG);
238 1.10 ichiro reg |= MCHCFG_AAGN;
239 1.8 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_I840_MCHCFG,
240 1.10 ichiro reg);
241 1.7 ichiro break;
242 1.7 ichiro }
243 1.8 ichiro default:
244 1.7 ichiro {
245 1.7 ichiro reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_NBXCFG);
246 1.7 ichiro reg &= ~NBXCFG_APAE;
247 1.7 ichiro reg |= NBXCFG_AAGN;
248 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_NBXCFG, reg);
249 1.8 ichiro }
250 1.8 ichiro }
251 1.7 ichiro
252 1.8 ichiro /* Clear Error status */
253 1.9 ichiro switch (isc->chiptype) {
254 1.8 ichiro case CHIP_I840:
255 1.9 ichiro pci_conf_write(sc->as_pc, sc->as_tag,
256 1.9 ichiro AGP_INTEL_I8XX_ERRSTS, 0xc000);
257 1.8 ichiro break;
258 1.1 fvdl
259 1.14 tron case CHIP_I845:
260 1.10 ichiro case CHIP_I850:
261 1.14 tron case CHIP_I865:
262 1.9 ichiro pci_conf_write(sc->as_pc, sc->as_tag,
263 1.9 ichiro AGP_INTEL_I8XX_ERRSTS, 0x00ff);
264 1.7 ichiro break;
265 1.8 ichiro
266 1.8 ichiro default:
267 1.28 gson {
268 1.29 drochner reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_ERRSTS);
269 1.29 drochner /* clear error bits (write-one-to-clear) - just write back */
270 1.29 drochner pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_ERRSTS, reg);
271 1.28 gson }
272 1.7 ichiro }
273 1.1 fvdl
274 1.10 ichiro return (0);
275 1.1 fvdl }
276 1.1 fvdl
277 1.1 fvdl #if 0
278 1.1 fvdl static int
279 1.1 fvdl agp_intel_detach(struct agp_softc *sc)
280 1.1 fvdl {
281 1.1 fvdl int error;
282 1.1 fvdl pcireg_t reg;
283 1.1 fvdl struct agp_intel_softc *isc = sc->as_chipc;
284 1.1 fvdl
285 1.1 fvdl error = agp_generic_detach(sc);
286 1.1 fvdl if (error)
287 1.1 fvdl return error;
288 1.1 fvdl
289 1.7 ichiro /* XXX i845/i855PM/i840/i850E */
290 1.1 fvdl reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_NBXCFG);
291 1.1 fvdl reg &= ~(1 << 9);
292 1.26 perry printf("%s: set NBXCFG to %x\n", __func__, reg);
293 1.1 fvdl pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_NBXCFG, reg);
294 1.1 fvdl pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_ATTBASE, 0);
295 1.1 fvdl AGP_SET_APERTURE(sc, isc->initial_aperture);
296 1.1 fvdl agp_free_gatt(sc, isc->gatt);
297 1.1 fvdl
298 1.1 fvdl return 0;
299 1.1 fvdl }
300 1.1 fvdl #endif
301 1.1 fvdl
302 1.1 fvdl static u_int32_t
303 1.1 fvdl agp_intel_get_aperture(struct agp_softc *sc)
304 1.1 fvdl {
305 1.10 ichiro struct agp_intel_softc *isc = sc->as_chipc;
306 1.1 fvdl u_int32_t apsize;
307 1.1 fvdl
308 1.7 ichiro apsize = pci_conf_read(sc->as_pc, sc->as_tag,
309 1.10 ichiro AGP_INTEL_APSIZE) & isc->aperture_mask;
310 1.1 fvdl
311 1.1 fvdl /*
312 1.1 fvdl * The size is determined by the number of low bits of
313 1.1 fvdl * register APBASE which are forced to zero. The low 22 bits
314 1.1 fvdl * are always forced to zero and each zero bit in the apsize
315 1.1 fvdl * field just read forces the corresponding bit in the 27:22
316 1.1 fvdl * to be zero. We calculate the aperture size accordingly.
317 1.1 fvdl */
318 1.10 ichiro return (((apsize ^ isc->aperture_mask) << 22) | ((1 << 22) - 1)) + 1;
319 1.1 fvdl }
320 1.1 fvdl
321 1.1 fvdl static int
322 1.1 fvdl agp_intel_set_aperture(struct agp_softc *sc, u_int32_t aperture)
323 1.1 fvdl {
324 1.10 ichiro struct agp_intel_softc *isc = sc->as_chipc;
325 1.1 fvdl u_int32_t apsize;
326 1.1 fvdl
327 1.1 fvdl /*
328 1.1 fvdl * Reverse the magic from get_aperture.
329 1.1 fvdl */
330 1.10 ichiro apsize = ((aperture - 1) >> 22) ^ isc->aperture_mask;
331 1.1 fvdl
332 1.1 fvdl /*
333 1.1 fvdl * Double check for sanity.
334 1.1 fvdl */
335 1.10 ichiro if ((((apsize ^ isc->aperture_mask) << 22) |
336 1.7 ichiro ((1 << 22) - 1)) + 1 != aperture)
337 1.1 fvdl return EINVAL;
338 1.1 fvdl
339 1.10 ichiro pci_conf_write(sc->as_pc, sc->as_tag,
340 1.10 ichiro AGP_INTEL_APSIZE, apsize);
341 1.1 fvdl
342 1.1 fvdl return 0;
343 1.1 fvdl }
344 1.1 fvdl
345 1.1 fvdl static int
346 1.1 fvdl agp_intel_bind_page(struct agp_softc *sc, off_t offset, bus_addr_t physical)
347 1.1 fvdl {
348 1.1 fvdl struct agp_intel_softc *isc = sc->as_chipc;
349 1.1 fvdl
350 1.1 fvdl if (offset < 0 || offset >= (isc->gatt->ag_entries << AGP_PAGE_SHIFT))
351 1.1 fvdl return EINVAL;
352 1.1 fvdl
353 1.1 fvdl isc->gatt->ag_virtual[offset >> AGP_PAGE_SHIFT] = physical | 0x17;
354 1.1 fvdl return 0;
355 1.1 fvdl }
356 1.1 fvdl
357 1.1 fvdl static int
358 1.1 fvdl agp_intel_unbind_page(struct agp_softc *sc, off_t offset)
359 1.1 fvdl {
360 1.1 fvdl struct agp_intel_softc *isc = sc->as_chipc;
361 1.1 fvdl
362 1.1 fvdl if (offset < 0 || offset >= (isc->gatt->ag_entries << AGP_PAGE_SHIFT))
363 1.1 fvdl return EINVAL;
364 1.1 fvdl
365 1.1 fvdl isc->gatt->ag_virtual[offset >> AGP_PAGE_SHIFT] = 0;
366 1.1 fvdl return 0;
367 1.1 fvdl }
368 1.1 fvdl
369 1.1 fvdl static void
370 1.1 fvdl agp_intel_flush_tlb(struct agp_softc *sc)
371 1.1 fvdl {
372 1.7 ichiro struct agp_intel_softc *isc = sc->as_chipc;
373 1.10 ichiro pcireg_t reg;
374 1.7 ichiro
375 1.7 ichiro switch (isc->chiptype) {
376 1.14 tron case CHIP_I865:
377 1.13 tron case CHIP_I850:
378 1.13 tron case CHIP_I845:
379 1.13 tron case CHIP_I840:
380 1.10 ichiro case CHIP_I443:
381 1.10 ichiro {
382 1.10 ichiro reg = pci_conf_read(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL);
383 1.13 tron reg &= ~AGPCTRL_GTLB;
384 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
385 1.10 ichiro reg);
386 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
387 1.10 ichiro reg | AGPCTRL_GTLB);
388 1.7 ichiro break;
389 1.10 ichiro }
390 1.10 ichiro default: /* XXX */
391 1.10 ichiro {
392 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
393 1.10 ichiro 0x2200);
394 1.7 ichiro pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
395 1.10 ichiro 0x2280);
396 1.10 ichiro }
397 1.7 ichiro }
398 1.1 fvdl }
399 1.18 jmcneill
400 1.25 jmcneill static bool
401 1.34 dyoung agp_intel_resume(device_t dv, const pmf_qual_t *qual)
402 1.18 jmcneill {
403 1.25 jmcneill struct agp_softc *sc = device_private(dv);
404 1.18 jmcneill
405 1.25 jmcneill agp_intel_init(sc);
406 1.25 jmcneill agp_flush_cache();
407 1.18 jmcneill
408 1.25 jmcneill return true;
409 1.18 jmcneill }
410