Home | History | Annotate | Line # | Download | only in pci
pdcide.c revision 1.7
      1  1.7   bouyer /*	$NetBSD: pdcide.c,v 1.7 2003/11/15 16:40:46 bouyer Exp $	*/
      2  1.1   bouyer 
      3  1.1   bouyer /*
      4  1.1   bouyer  * Copyright (c) 1999, 2000, 2001 Manuel Bouyer.
      5  1.1   bouyer  *
      6  1.1   bouyer  * Redistribution and use in source and binary forms, with or without
      7  1.1   bouyer  * modification, are permitted provided that the following conditions
      8  1.1   bouyer  * are met:
      9  1.1   bouyer  * 1. Redistributions of source code must retain the above copyright
     10  1.1   bouyer  *    notice, this list of conditions and the following disclaimer.
     11  1.1   bouyer  * 2. Redistributions in binary form must reproduce the above copyright
     12  1.1   bouyer  *    notice, this list of conditions and the following disclaimer in the
     13  1.1   bouyer  *    documentation and/or other materials provided with the distribution.
     14  1.1   bouyer  * 3. All advertising materials mentioning features or use of this software
     15  1.1   bouyer  *    must display the following acknowledgement:
     16  1.1   bouyer  *	This product includes software developed by Manuel Bouyer.
     17  1.1   bouyer  * 4. The name of the author may not be used to endorse or promote products
     18  1.1   bouyer  *    derived from this software without specific prior written permission.
     19  1.1   bouyer  *
     20  1.1   bouyer  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
     21  1.1   bouyer  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
     22  1.1   bouyer  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
     23  1.1   bouyer  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
     24  1.1   bouyer  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
     25  1.1   bouyer  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
     26  1.1   bouyer  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
     27  1.1   bouyer  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     28  1.1   bouyer  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
     29  1.1   bouyer  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     30  1.1   bouyer  */
     31  1.1   bouyer 
     32  1.1   bouyer #include <sys/param.h>
     33  1.1   bouyer #include <sys/systm.h>
     34  1.1   bouyer 
     35  1.1   bouyer #include <dev/pci/pcivar.h>
     36  1.1   bouyer #include <dev/pci/pcidevs.h>
     37  1.1   bouyer #include <dev/pci/pciidereg.h>
     38  1.1   bouyer #include <dev/pci/pciidevar.h>
     39  1.1   bouyer #include <dev/pci/pciide_pdc202xx_reg.h>
     40  1.1   bouyer 
     41  1.2  thorpej static void pdc202xx_chip_map(struct pciide_softc *, struct pci_attach_args *);
     42  1.2  thorpej static void pdc202xx_setup_channel(struct channel_softc *);
     43  1.2  thorpej static void pdc20268_setup_channel(struct channel_softc *);
     44  1.2  thorpej static int  pdc202xx_pci_intr(void *);
     45  1.2  thorpej static int  pdc20265_pci_intr(void *);
     46  1.2  thorpej static void pdc20262_dma_start(void *, int, int);
     47  1.2  thorpej static int  pdc20262_dma_finish(void *, int, int, int);
     48  1.1   bouyer 
     49  1.2  thorpej static int  pdcide_match(struct device *, struct cfdata *, void *);
     50  1.2  thorpej static void pdcide_attach(struct device *, struct device *, void *);
     51  1.1   bouyer 
     52  1.1   bouyer CFATTACH_DECL(pdcide, sizeof(struct pciide_softc),
     53  1.1   bouyer     pdcide_match, pdcide_attach, NULL, NULL);
     54  1.1   bouyer 
     55  1.2  thorpej static const struct pciide_product_desc pciide_promise_products[] =  {
     56  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA33,
     57  1.4  mycroft 	  0,
     58  1.1   bouyer 	  "Promise Ultra33/ATA Bus Master IDE Accelerator",
     59  1.1   bouyer 	  pdc202xx_chip_map,
     60  1.1   bouyer 	},
     61  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA66,
     62  1.4  mycroft 	  0,
     63  1.1   bouyer 	  "Promise Ultra66/ATA Bus Master IDE Accelerator",
     64  1.1   bouyer 	  pdc202xx_chip_map,
     65  1.1   bouyer 	},
     66  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA100,
     67  1.4  mycroft 	  0,
     68  1.1   bouyer 	  "Promise Ultra100/ATA Bus Master IDE Accelerator",
     69  1.1   bouyer 	  pdc202xx_chip_map,
     70  1.1   bouyer 	},
     71  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA100X,
     72  1.4  mycroft 	  0,
     73  1.1   bouyer 	  "Promise Ultra100/ATA Bus Master IDE Accelerator",
     74  1.1   bouyer 	  pdc202xx_chip_map,
     75  1.1   bouyer 	},
     76  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA100TX2,
     77  1.4  mycroft 	  0,
     78  1.1   bouyer 	  "Promise Ultra100TX2/ATA Bus Master IDE Accelerator",
     79  1.1   bouyer 	  pdc202xx_chip_map,
     80  1.1   bouyer 	},
     81  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA100TX2v2,
     82  1.4  mycroft 	  0,
     83  1.1   bouyer 	  "Promise Ultra100TX2v2/ATA Bus Master IDE Accelerator",
     84  1.1   bouyer 	  pdc202xx_chip_map,
     85  1.1   bouyer 	},
     86  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA133,
     87  1.4  mycroft 	  0,
     88  1.1   bouyer 	  "Promise Ultra133/ATA Bus Master IDE Accelerator",
     89  1.1   bouyer 	  pdc202xx_chip_map,
     90  1.1   bouyer 	},
     91  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA133TX2,
     92  1.4  mycroft 	  0,
     93  1.1   bouyer 	  "Promise Ultra133TX2/ATA Bus Master IDE Accelerator",
     94  1.1   bouyer 	  pdc202xx_chip_map,
     95  1.1   bouyer 	},
     96  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_MBULTRA133,
     97  1.4  mycroft 	  0,
     98  1.1   bouyer 	  "Promise Ultra133/ATA Bus Master IDE Accelerator (MB)",
     99  1.1   bouyer 	  pdc202xx_chip_map,
    100  1.1   bouyer 	},
    101  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_ULTRA133TX2v2,
    102  1.4  mycroft 	  0,
    103  1.1   bouyer 	  "Promise Ultra133TX2v2/ATA Bus Master IDE Accelerator",
    104  1.1   bouyer 	  pdc202xx_chip_map,
    105  1.1   bouyer 	},
    106  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_FASTTRAK133LITE,
    107  1.4  mycroft 	  0,
    108  1.1   bouyer 	  "Promise Fasttrak133 Lite Bus Master IDE Accelerator",
    109  1.1   bouyer 	  pdc202xx_chip_map,
    110  1.1   bouyer 	},
    111  1.1   bouyer 	{ PCI_PRODUCT_PROMISE_SATA150TX2PLUS,
    112  1.4  mycroft 	  0,
    113  1.1   bouyer 	  "Promise Serial ATA/150 TX2plus Bus Master IDE Accelerator",
    114  1.3     fvdl 	  pdc202xx_chip_map,
    115  1.3     fvdl 	},
    116  1.3     fvdl 	{ PCI_PRODUCT_PROMISE_SATA150FT378,
    117  1.4  mycroft 	  0,
    118  1.3     fvdl 	  "Promise FastTrak 378 Serial ATA/150 Bus Master IDE Controller",
    119  1.1   bouyer 	  pdc202xx_chip_map,
    120  1.1   bouyer 	},
    121  1.1   bouyer 	{ 0,
    122  1.1   bouyer 	  0,
    123  1.1   bouyer 	  NULL,
    124  1.1   bouyer 	  NULL
    125  1.1   bouyer 	}
    126  1.1   bouyer };
    127  1.1   bouyer 
    128  1.2  thorpej static int
    129  1.2  thorpej pdcide_match(struct device *parent, struct cfdata *match, void *aux)
    130  1.1   bouyer {
    131  1.1   bouyer 	struct pci_attach_args *pa = aux;
    132  1.1   bouyer 
    133  1.1   bouyer 	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_PROMISE) {
    134  1.1   bouyer 		if (pciide_lookup_product(pa->pa_id, pciide_promise_products))
    135  1.1   bouyer 			return (2);
    136  1.1   bouyer 	}
    137  1.1   bouyer 	return (0);
    138  1.1   bouyer }
    139  1.1   bouyer 
    140  1.2  thorpej static void
    141  1.2  thorpej pdcide_attach(struct device *parent, struct device *self, void *aux)
    142  1.1   bouyer {
    143  1.1   bouyer 	struct pci_attach_args *pa = aux;
    144  1.1   bouyer 	struct pciide_softc *sc = (struct pciide_softc *)self;
    145  1.1   bouyer 
    146  1.1   bouyer 	pciide_common_attach(sc, pa,
    147  1.1   bouyer 	    pciide_lookup_product(pa->pa_id, pciide_promise_products));
    148  1.1   bouyer 
    149  1.1   bouyer }
    150  1.1   bouyer 
    151  1.1   bouyer /* Macros to test product */
    152  1.1   bouyer #define PDC_IS_262(sc)							\
    153  1.1   bouyer 	((sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA66 ||	\
    154  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100 ||	\
    155  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100X ||	\
    156  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2 ||	\
    157  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2v2 || \
    158  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133 ||	\
    159  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2 ||	\
    160  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_MBULTRA133 || \
    161  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2v2 || \
    162  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_FASTTRAK133LITE)
    163  1.1   bouyer #define PDC_IS_265(sc)							\
    164  1.1   bouyer 	((sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100 ||	\
    165  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100X ||	\
    166  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2 ||	\
    167  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2v2 || \
    168  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133 ||	\
    169  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2 ||	\
    170  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_MBULTRA133 || \
    171  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2v2 || \
    172  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_FASTTRAK133LITE)
    173  1.1   bouyer #define PDC_IS_268(sc)							\
    174  1.1   bouyer 	((sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2 ||	\
    175  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100TX2v2 || \
    176  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133 ||	\
    177  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2 ||	\
    178  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_MBULTRA133 || \
    179  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2v2 || \
    180  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_FASTTRAK133LITE)
    181  1.1   bouyer #define PDC_IS_276(sc)							\
    182  1.1   bouyer 	((sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133 ||	\
    183  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2 ||	\
    184  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_MBULTRA133 || \
    185  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA133TX2v2 || \
    186  1.1   bouyer 	(sc)->sc_pp->ide_product == PCI_PRODUCT_PROMISE_FASTTRAK133LITE)
    187  1.1   bouyer 
    188  1.2  thorpej static void
    189  1.2  thorpej pdc202xx_chip_map(struct pciide_softc *sc, struct pci_attach_args *pa)
    190  1.1   bouyer {
    191  1.1   bouyer 	struct pciide_channel *cp;
    192  1.1   bouyer 	int channel;
    193  1.6  mycroft 	pcireg_t interface, st, mode;
    194  1.1   bouyer 	bus_size_t cmdsize, ctlsize;
    195  1.1   bouyer 
    196  1.1   bouyer 	if (!PDC_IS_268(sc)) {
    197  1.1   bouyer 		st = pci_conf_read(sc->sc_pc, sc->sc_tag, PDC2xx_STATE);
    198  1.1   bouyer 		WDCDEBUG_PRINT(("pdc202xx_setup_chip: controller state 0x%x\n",
    199  1.1   bouyer 		    st), DEBUG_PROBE);
    200  1.6  mycroft 		/* turn off  RAID mode */
    201  1.6  mycroft 		if (st & PDC2xx_STATE_IDERAID) {
    202  1.6  mycroft 			WDCDEBUG_PRINT(("pdc202xx_setup_chip: turning off RAID mode\n"), DEBUG_PROBE);
    203  1.6  mycroft 			st &= ~PDC2xx_STATE_IDERAID;
    204  1.6  mycroft 			pci_conf_write(sc->sc_pc, sc->sc_tag, PDC2xx_STATE, st);
    205  1.6  mycroft 		}
    206  1.6  mycroft 	} else
    207  1.6  mycroft 		st = PDC2xx_STATE_NATIVE | PDC262_STATE_EN(0) | PDC262_STATE_EN(1);
    208  1.6  mycroft 
    209  1.1   bouyer 	if (pciide_chipen(sc, pa) == 0)
    210  1.1   bouyer 		return;
    211  1.1   bouyer 
    212  1.1   bouyer 	/*
    213  1.1   bouyer 	 * can't rely on the PCI_CLASS_REG content if the chip was in raid
    214  1.1   bouyer 	 * mode. We have to fake interface
    215  1.1   bouyer 	 */
    216  1.1   bouyer 	interface = PCIIDE_INTERFACE_SETTABLE(0) | PCIIDE_INTERFACE_SETTABLE(1);
    217  1.6  mycroft 	if (st & PDC2xx_STATE_NATIVE)
    218  1.1   bouyer 		interface |= PCIIDE_INTERFACE_PCI(0) | PCIIDE_INTERFACE_PCI(1);
    219  1.1   bouyer 
    220  1.1   bouyer 	aprint_normal("%s: bus-master DMA support present",
    221  1.1   bouyer 	    sc->sc_wdcdev.sc_dev.dv_xname);
    222  1.1   bouyer 	pciide_mapreg_dma(sc, pa);
    223  1.1   bouyer 	aprint_normal("\n");
    224  1.1   bouyer 	sc->sc_wdcdev.cap = WDC_CAPABILITY_DATA16 | WDC_CAPABILITY_DATA32 |
    225  1.1   bouyer 	    WDC_CAPABILITY_MODE;
    226  1.1   bouyer 	if (sc->sc_dma_ok) {
    227  1.1   bouyer 		sc->sc_wdcdev.cap |= WDC_CAPABILITY_DMA | WDC_CAPABILITY_UDMA;
    228  1.1   bouyer 		sc->sc_wdcdev.cap |= WDC_CAPABILITY_IRQACK;
    229  1.1   bouyer 		sc->sc_wdcdev.irqack = pciide_irqack;
    230  1.1   bouyer 	}
    231  1.1   bouyer 	if (PCI_CLASS(pa->pa_class) == PCI_CLASS_MASS_STORAGE &&
    232  1.1   bouyer 	    PCI_SUBCLASS(pa->pa_class) == PCI_SUBCLASS_MASS_STORAGE_RAID)
    233  1.1   bouyer 		sc->sc_wdcdev.cap |= WDC_CAPABILITY_RAID;
    234  1.1   bouyer 	sc->sc_wdcdev.PIO_cap = 4;
    235  1.1   bouyer 	sc->sc_wdcdev.DMA_cap = 2;
    236  1.1   bouyer 	if (PDC_IS_276(sc))
    237  1.1   bouyer 		sc->sc_wdcdev.UDMA_cap = 6;
    238  1.1   bouyer 	else if (PDC_IS_265(sc))
    239  1.1   bouyer 		sc->sc_wdcdev.UDMA_cap = 5;
    240  1.1   bouyer 	else if (PDC_IS_262(sc))
    241  1.1   bouyer 		sc->sc_wdcdev.UDMA_cap = 4;
    242  1.1   bouyer 	else
    243  1.1   bouyer 		sc->sc_wdcdev.UDMA_cap = 2;
    244  1.1   bouyer 	sc->sc_wdcdev.set_modes = PDC_IS_268(sc) ?
    245  1.1   bouyer 			pdc20268_setup_channel : pdc202xx_setup_channel;
    246  1.1   bouyer 	sc->sc_wdcdev.channels = sc->wdc_chanarray;
    247  1.1   bouyer 	sc->sc_wdcdev.nchannels = PCIIDE_NUM_CHANNELS;
    248  1.1   bouyer 
    249  1.1   bouyer 	if (sc->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA66 ||
    250  1.1   bouyer 	    sc->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100 ||
    251  1.1   bouyer 	    sc->sc_pp->ide_product == PCI_PRODUCT_PROMISE_ULTRA100X) {
    252  1.1   bouyer 		sc->sc_wdcdev.dma_start = pdc20262_dma_start;
    253  1.1   bouyer 		sc->sc_wdcdev.dma_finish = pdc20262_dma_finish;
    254  1.1   bouyer 	}
    255  1.1   bouyer 
    256  1.1   bouyer 	if (!PDC_IS_268(sc)) {
    257  1.1   bouyer 		/* setup failsafe defaults */
    258  1.1   bouyer 		mode = 0;
    259  1.1   bouyer 		mode = PDC2xx_TIM_SET_PA(mode, pdc2xx_pa[0]);
    260  1.1   bouyer 		mode = PDC2xx_TIM_SET_PB(mode, pdc2xx_pb[0]);
    261  1.1   bouyer 		mode = PDC2xx_TIM_SET_MB(mode, pdc2xx_dma_mb[0]);
    262  1.1   bouyer 		mode = PDC2xx_TIM_SET_MC(mode, pdc2xx_dma_mc[0]);
    263  1.1   bouyer 		for (channel = 0;
    264  1.1   bouyer 		     channel < sc->sc_wdcdev.nchannels;
    265  1.1   bouyer 		     channel++) {
    266  1.1   bouyer 			WDCDEBUG_PRINT(("pdc202xx_setup_chip: channel %d "
    267  1.1   bouyer 			    "drive 0 initial timings  0x%x, now 0x%x\n",
    268  1.1   bouyer 			    channel, pci_conf_read(sc->sc_pc, sc->sc_tag,
    269  1.1   bouyer 			    PDC2xx_TIM(channel, 0)), mode | PDC2xx_TIM_IORDYp),
    270  1.1   bouyer 			    DEBUG_PROBE);
    271  1.1   bouyer 			pci_conf_write(sc->sc_pc, sc->sc_tag,
    272  1.1   bouyer 			    PDC2xx_TIM(channel, 0), mode | PDC2xx_TIM_IORDYp);
    273  1.1   bouyer 			WDCDEBUG_PRINT(("pdc202xx_setup_chip: channel %d "
    274  1.1   bouyer 			    "drive 1 initial timings  0x%x, now 0x%x\n",
    275  1.1   bouyer 			    channel, pci_conf_read(sc->sc_pc, sc->sc_tag,
    276  1.1   bouyer 			    PDC2xx_TIM(channel, 1)), mode), DEBUG_PROBE);
    277  1.1   bouyer 			pci_conf_write(sc->sc_pc, sc->sc_tag,
    278  1.1   bouyer 			    PDC2xx_TIM(channel, 1), mode);
    279  1.1   bouyer 		}
    280  1.1   bouyer 
    281  1.1   bouyer 		mode = PDC2xx_SCR_DMA;
    282  1.1   bouyer 		if (PDC_IS_265(sc)) {
    283  1.1   bouyer 			mode = PDC2xx_SCR_SET_GEN(mode, PDC265_SCR_GEN_LAT);
    284  1.1   bouyer 		} else if (PDC_IS_262(sc)) {
    285  1.1   bouyer 			mode = PDC2xx_SCR_SET_GEN(mode, PDC262_SCR_GEN_LAT);
    286  1.1   bouyer 		} else {
    287  1.1   bouyer 			/* the BIOS set it up this way */
    288  1.1   bouyer 			mode = PDC2xx_SCR_SET_GEN(mode, 0x1);
    289  1.1   bouyer 		}
    290  1.1   bouyer 		mode = PDC2xx_SCR_SET_I2C(mode, 0x3); /* ditto */
    291  1.1   bouyer 		mode = PDC2xx_SCR_SET_POLL(mode, 0x1); /* ditto */
    292  1.1   bouyer 		WDCDEBUG_PRINT(("pdc202xx_setup_chip: initial SCR  0x%x, "
    293  1.1   bouyer 		    "now 0x%x\n",
    294  1.1   bouyer 		    bus_space_read_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    295  1.1   bouyer 			PDC2xx_SCR),
    296  1.1   bouyer 		    mode), DEBUG_PROBE);
    297  1.1   bouyer 		bus_space_write_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    298  1.1   bouyer 		    PDC2xx_SCR, mode);
    299  1.1   bouyer 
    300  1.1   bouyer 		/* controller initial state register is OK even without BIOS */
    301  1.1   bouyer 		/* Set DMA mode to IDE DMA compatibility */
    302  1.1   bouyer 		mode =
    303  1.1   bouyer 		    bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh, PDC2xx_PM);
    304  1.1   bouyer 		WDCDEBUG_PRINT(("pdc202xx_setup_chip: primary mode 0x%x", mode),
    305  1.1   bouyer 		    DEBUG_PROBE);
    306  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh, PDC2xx_PM,
    307  1.1   bouyer 		    mode | 0x1);
    308  1.1   bouyer 		mode =
    309  1.1   bouyer 		    bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh, PDC2xx_SM);
    310  1.1   bouyer 		WDCDEBUG_PRINT((", secondary mode 0x%x\n", mode ), DEBUG_PROBE);
    311  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh, PDC2xx_SM,
    312  1.1   bouyer 		    mode | 0x1);
    313  1.1   bouyer 	}
    314  1.1   bouyer 
    315  1.1   bouyer 	for (channel = 0; channel < sc->sc_wdcdev.nchannels; channel++) {
    316  1.1   bouyer 		cp = &sc->pciide_channels[channel];
    317  1.1   bouyer 		if (pciide_chansetup(sc, channel, interface) == 0)
    318  1.1   bouyer 			continue;
    319  1.6  mycroft 		if ((st & (PDC_IS_262(sc) ?
    320  1.1   bouyer 		    PDC262_STATE_EN(channel):PDC246_STATE_EN(channel))) == 0) {
    321  1.1   bouyer 			aprint_normal("%s: %s channel ignored (disabled)\n",
    322  1.1   bouyer 			    sc->sc_wdcdev.sc_dev.dv_xname, cp->name);
    323  1.1   bouyer 			cp->wdc_channel.ch_flags |= WDCF_DISABLED;
    324  1.1   bouyer 			continue;
    325  1.1   bouyer 		}
    326  1.1   bouyer 		pciide_mapchan(pa, cp, interface, &cmdsize, &ctlsize,
    327  1.1   bouyer 		    PDC_IS_265(sc) ? pdc20265_pci_intr : pdc202xx_pci_intr);
    328  1.7   bouyer 		/* clear interrupt, in case there is one pending */
    329  1.7   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    330  1.7   bouyer 		    IDEDMA_CTL + IDEDMA_SCH_OFFSET * channel, IDEDMA_CTL_INTR);
    331  1.1   bouyer 	}
    332  1.1   bouyer 	return;
    333  1.1   bouyer }
    334  1.1   bouyer 
    335  1.2  thorpej static void
    336  1.2  thorpej pdc202xx_setup_channel(struct channel_softc *chp)
    337  1.1   bouyer {
    338  1.1   bouyer 	struct ata_drive_datas *drvp;
    339  1.1   bouyer 	int drive;
    340  1.1   bouyer 	pcireg_t mode, st;
    341  1.1   bouyer 	u_int32_t idedma_ctl, scr, atapi;
    342  1.1   bouyer 	struct pciide_channel *cp = (struct pciide_channel*)chp;
    343  1.1   bouyer 	struct pciide_softc *sc = (struct pciide_softc *)cp->wdc_channel.wdc;
    344  1.1   bouyer 	int channel = chp->channel;
    345  1.1   bouyer 
    346  1.1   bouyer 	/* setup DMA if needed */
    347  1.1   bouyer 	pciide_channel_dma_setup(cp);
    348  1.1   bouyer 
    349  1.1   bouyer 	idedma_ctl = 0;
    350  1.1   bouyer 	WDCDEBUG_PRINT(("pdc202xx_setup_channel %s: scr 0x%x\n",
    351  1.1   bouyer 	    sc->sc_wdcdev.sc_dev.dv_xname,
    352  1.1   bouyer 	    bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh, PDC262_U66)),
    353  1.1   bouyer 	    DEBUG_PROBE);
    354  1.1   bouyer 
    355  1.1   bouyer 	/* Per channel settings */
    356  1.1   bouyer 	if (PDC_IS_262(sc)) {
    357  1.1   bouyer 		scr = bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    358  1.1   bouyer 		    PDC262_U66);
    359  1.1   bouyer 		st = pci_conf_read(sc->sc_pc, sc->sc_tag, PDC2xx_STATE);
    360  1.1   bouyer 		/* Trim UDMA mode */
    361  1.1   bouyer 		if ((st & PDC262_STATE_80P(channel)) != 0 ||
    362  1.1   bouyer 		    (chp->ch_drive[0].drive_flags & DRIVE_UDMA &&
    363  1.1   bouyer 		    chp->ch_drive[0].UDMA_mode <= 2) ||
    364  1.1   bouyer 		    (chp->ch_drive[1].drive_flags & DRIVE_UDMA &&
    365  1.1   bouyer 		    chp->ch_drive[1].UDMA_mode <= 2)) {
    366  1.1   bouyer 			if (chp->ch_drive[0].UDMA_mode > 2)
    367  1.1   bouyer 				chp->ch_drive[0].UDMA_mode = 2;
    368  1.1   bouyer 			if (chp->ch_drive[1].UDMA_mode > 2)
    369  1.1   bouyer 				chp->ch_drive[1].UDMA_mode = 2;
    370  1.1   bouyer 		}
    371  1.1   bouyer 		/* Set U66 if needed */
    372  1.1   bouyer 		if ((chp->ch_drive[0].drive_flags & DRIVE_UDMA &&
    373  1.1   bouyer 		    chp->ch_drive[0].UDMA_mode > 2) ||
    374  1.1   bouyer 		    (chp->ch_drive[1].drive_flags & DRIVE_UDMA &&
    375  1.1   bouyer 		    chp->ch_drive[1].UDMA_mode > 2))
    376  1.1   bouyer 			scr |= PDC262_U66_EN(channel);
    377  1.1   bouyer 		else
    378  1.1   bouyer 			scr &= ~PDC262_U66_EN(channel);
    379  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    380  1.1   bouyer 		    PDC262_U66, scr);
    381  1.1   bouyer 		WDCDEBUG_PRINT(("pdc202xx_setup_channel %s:%d: ATAPI 0x%x\n",
    382  1.1   bouyer 		    sc->sc_wdcdev.sc_dev.dv_xname, channel,
    383  1.1   bouyer 		    bus_space_read_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    384  1.1   bouyer 		    PDC262_ATAPI(channel))), DEBUG_PROBE);
    385  1.1   bouyer 		if (chp->ch_drive[0].drive_flags & DRIVE_ATAPI ||
    386  1.1   bouyer 			chp->ch_drive[1].drive_flags & DRIVE_ATAPI) {
    387  1.1   bouyer 			if (((chp->ch_drive[0].drive_flags & DRIVE_UDMA) &&
    388  1.1   bouyer 			    !(chp->ch_drive[1].drive_flags & DRIVE_UDMA) &&
    389  1.1   bouyer 			    (chp->ch_drive[1].drive_flags & DRIVE_DMA)) ||
    390  1.1   bouyer 			    ((chp->ch_drive[1].drive_flags & DRIVE_UDMA) &&
    391  1.1   bouyer 			    !(chp->ch_drive[0].drive_flags & DRIVE_UDMA) &&
    392  1.1   bouyer 			    (chp->ch_drive[0].drive_flags & DRIVE_DMA)))
    393  1.1   bouyer 				atapi = 0;
    394  1.1   bouyer 			else
    395  1.1   bouyer 				atapi = PDC262_ATAPI_UDMA;
    396  1.1   bouyer 			bus_space_write_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    397  1.1   bouyer 			    PDC262_ATAPI(channel), atapi);
    398  1.1   bouyer 		}
    399  1.1   bouyer 	}
    400  1.1   bouyer 	for (drive = 0; drive < 2; drive++) {
    401  1.1   bouyer 		drvp = &chp->ch_drive[drive];
    402  1.1   bouyer 		/* If no drive, skip */
    403  1.1   bouyer 		if ((drvp->drive_flags & DRIVE) == 0)
    404  1.1   bouyer 			continue;
    405  1.1   bouyer 		mode = 0;
    406  1.1   bouyer 		if (drvp->drive_flags & DRIVE_UDMA) {
    407  1.1   bouyer 			/* use Ultra/DMA */
    408  1.1   bouyer 			drvp->drive_flags &= ~DRIVE_DMA;
    409  1.1   bouyer 			mode = PDC2xx_TIM_SET_MB(mode,
    410  1.1   bouyer 			    pdc2xx_udma_mb[drvp->UDMA_mode]);
    411  1.1   bouyer 			mode = PDC2xx_TIM_SET_MC(mode,
    412  1.1   bouyer 			    pdc2xx_udma_mc[drvp->UDMA_mode]);
    413  1.1   bouyer 			idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
    414  1.1   bouyer 		} else if (drvp->drive_flags & DRIVE_DMA) {
    415  1.1   bouyer 			mode = PDC2xx_TIM_SET_MB(mode,
    416  1.1   bouyer 			    pdc2xx_dma_mb[drvp->DMA_mode]);
    417  1.1   bouyer 			mode = PDC2xx_TIM_SET_MC(mode,
    418  1.1   bouyer 			    pdc2xx_dma_mc[drvp->DMA_mode]);
    419  1.1   bouyer 			idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
    420  1.1   bouyer 		} else {
    421  1.1   bouyer 			mode = PDC2xx_TIM_SET_MB(mode,
    422  1.1   bouyer 			    pdc2xx_dma_mb[0]);
    423  1.1   bouyer 			mode = PDC2xx_TIM_SET_MC(mode,
    424  1.1   bouyer 			    pdc2xx_dma_mc[0]);
    425  1.1   bouyer 		}
    426  1.1   bouyer 		mode = PDC2xx_TIM_SET_PA(mode, pdc2xx_pa[drvp->PIO_mode]);
    427  1.1   bouyer 		mode = PDC2xx_TIM_SET_PB(mode, pdc2xx_pb[drvp->PIO_mode]);
    428  1.1   bouyer 		if (drvp->drive_flags & DRIVE_ATA)
    429  1.1   bouyer 			mode |= PDC2xx_TIM_PRE;
    430  1.1   bouyer 		mode |= PDC2xx_TIM_SYNC | PDC2xx_TIM_ERRDY;
    431  1.1   bouyer 		if (drvp->PIO_mode >= 3) {
    432  1.1   bouyer 			mode |= PDC2xx_TIM_IORDY;
    433  1.1   bouyer 			if (drive == 0)
    434  1.1   bouyer 				mode |= PDC2xx_TIM_IORDYp;
    435  1.1   bouyer 		}
    436  1.1   bouyer 		WDCDEBUG_PRINT(("pdc202xx_setup_channel: %s:%d:%d "
    437  1.1   bouyer 		    "timings 0x%x\n",
    438  1.1   bouyer 		    sc->sc_wdcdev.sc_dev.dv_xname,
    439  1.1   bouyer 		    chp->channel, drive, mode), DEBUG_PROBE);
    440  1.1   bouyer 		pci_conf_write(sc->sc_pc, sc->sc_tag,
    441  1.1   bouyer 		    PDC2xx_TIM(chp->channel, drive), mode);
    442  1.1   bouyer 	}
    443  1.1   bouyer 	if (idedma_ctl != 0) {
    444  1.1   bouyer 		/* Add software bits in status register */
    445  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    446  1.1   bouyer 		    IDEDMA_CTL + (IDEDMA_SCH_OFFSET * chp->channel),
    447  1.1   bouyer 		    idedma_ctl);
    448  1.1   bouyer 	}
    449  1.1   bouyer }
    450  1.1   bouyer 
    451  1.2  thorpej static void
    452  1.2  thorpej pdc20268_setup_channel(struct channel_softc *chp)
    453  1.1   bouyer {
    454  1.1   bouyer 	struct ata_drive_datas *drvp;
    455  1.1   bouyer 	int drive;
    456  1.1   bouyer 	u_int32_t idedma_ctl;
    457  1.1   bouyer 	struct pciide_channel *cp = (struct pciide_channel*)chp;
    458  1.1   bouyer 	struct pciide_softc *sc = (struct pciide_softc *)cp->wdc_channel.wdc;
    459  1.1   bouyer 	int u100;
    460  1.1   bouyer 
    461  1.1   bouyer 	/* setup DMA if needed */
    462  1.1   bouyer 	pciide_channel_dma_setup(cp);
    463  1.1   bouyer 
    464  1.1   bouyer 	idedma_ctl = 0;
    465  1.1   bouyer 
    466  1.1   bouyer 	/* I don't know what this is for, FreeBSD does it ... */
    467  1.1   bouyer 	bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    468  1.1   bouyer 	    IDEDMA_CMD + 0x1 + IDEDMA_SCH_OFFSET * chp->channel, 0x0b);
    469  1.1   bouyer 
    470  1.1   bouyer 	/*
    471  1.1   bouyer 	 * cable type detect, from FreeBSD
    472  1.1   bouyer 	 */
    473  1.1   bouyer 	u100 = (bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    474  1.1   bouyer 	    IDEDMA_CMD + 0x3 + IDEDMA_SCH_OFFSET * chp->channel) & 0x04) ?
    475  1.1   bouyer 	    0 : 1;
    476  1.1   bouyer 
    477  1.1   bouyer 	for (drive = 0; drive < 2; drive++) {
    478  1.1   bouyer 		drvp = &chp->ch_drive[drive];
    479  1.1   bouyer 		/* If no drive, skip */
    480  1.1   bouyer 		if ((drvp->drive_flags & DRIVE) == 0)
    481  1.1   bouyer 			continue;
    482  1.1   bouyer 		if (drvp->drive_flags & DRIVE_UDMA) {
    483  1.1   bouyer 			/* use Ultra/DMA */
    484  1.1   bouyer 			drvp->drive_flags &= ~DRIVE_DMA;
    485  1.1   bouyer 			idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
    486  1.1   bouyer 			if (drvp->UDMA_mode > 2 && u100 == 0)
    487  1.1   bouyer 				drvp->UDMA_mode = 2;
    488  1.1   bouyer 		} else if (drvp->drive_flags & DRIVE_DMA) {
    489  1.1   bouyer 			idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
    490  1.1   bouyer 		}
    491  1.1   bouyer 	}
    492  1.1   bouyer 	/* nothing to do to setup modes, the controller snoop SET_FEATURE cmd */
    493  1.1   bouyer 	if (idedma_ctl != 0) {
    494  1.1   bouyer 		/* Add software bits in status register */
    495  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh,
    496  1.1   bouyer 		    IDEDMA_CTL + (IDEDMA_SCH_OFFSET * chp->channel),
    497  1.1   bouyer 		    idedma_ctl);
    498  1.1   bouyer 	}
    499  1.1   bouyer }
    500  1.1   bouyer 
    501  1.2  thorpej static int
    502  1.2  thorpej pdc202xx_pci_intr(void *arg)
    503  1.1   bouyer {
    504  1.1   bouyer 	struct pciide_softc *sc = arg;
    505  1.1   bouyer 	struct pciide_channel *cp;
    506  1.1   bouyer 	struct channel_softc *wdc_cp;
    507  1.1   bouyer 	int i, rv, crv;
    508  1.1   bouyer 	u_int32_t scr;
    509  1.1   bouyer 
    510  1.1   bouyer 	rv = 0;
    511  1.1   bouyer 	scr = bus_space_read_4(sc->sc_dma_iot, sc->sc_dma_ioh, PDC2xx_SCR);
    512  1.1   bouyer 	for (i = 0; i < sc->sc_wdcdev.nchannels; i++) {
    513  1.1   bouyer 		cp = &sc->pciide_channels[i];
    514  1.1   bouyer 		wdc_cp = &cp->wdc_channel;
    515  1.1   bouyer 		/* If a compat channel skip. */
    516  1.1   bouyer 		if (cp->compat)
    517  1.1   bouyer 			continue;
    518  1.1   bouyer 		if (scr & PDC2xx_SCR_INT(i)) {
    519  1.1   bouyer 			crv = wdcintr(wdc_cp);
    520  1.1   bouyer 			if (crv == 0)
    521  1.1   bouyer 				printf("%s:%d: bogus intr (reg 0x%x)\n",
    522  1.1   bouyer 				    sc->sc_wdcdev.sc_dev.dv_xname, i, scr);
    523  1.1   bouyer 			else
    524  1.1   bouyer 				rv = 1;
    525  1.1   bouyer 		}
    526  1.1   bouyer 	}
    527  1.1   bouyer 	return rv;
    528  1.1   bouyer }
    529  1.1   bouyer 
    530  1.2  thorpej static int
    531  1.2  thorpej pdc20265_pci_intr(void *arg)
    532  1.1   bouyer {
    533  1.1   bouyer 	struct pciide_softc *sc = arg;
    534  1.1   bouyer 	struct pciide_channel *cp;
    535  1.1   bouyer 	struct channel_softc *wdc_cp;
    536  1.1   bouyer 	int i, rv, crv;
    537  1.1   bouyer 	u_int32_t dmastat;
    538  1.1   bouyer 
    539  1.1   bouyer 	rv = 0;
    540  1.1   bouyer 	for (i = 0; i < sc->sc_wdcdev.nchannels; i++) {
    541  1.1   bouyer 		cp = &sc->pciide_channels[i];
    542  1.1   bouyer 		wdc_cp = &cp->wdc_channel;
    543  1.1   bouyer 		/* If a compat channel skip. */
    544  1.1   bouyer 		if (cp->compat)
    545  1.1   bouyer 			continue;
    546  1.1   bouyer #if 0
    547  1.1   bouyer 		bus_space_write_1(sc->sc_dma_iot, sc->sc_dma_ioh, IDEDMA_CMD + 0x1 + IDEDMA_SCH_OFFSET * i, 0x0b);
    548  1.1   bouyer 		if ((bus_space_read_1(sc->sc_dma_iot, sc->sc_dma_ioh, IDEDMA_CMD + 0x3 + IDEDMA_SCH_OFFSET * i) & 0x20) == 0)
    549  1.1   bouyer 			continue;
    550  1.1   bouyer #endif
    551  1.1   bouyer 		/*
    552  1.1   bouyer 		 * The Ultra/100 seems to assert PDC2xx_SCR_INT * spuriously,
    553  1.1   bouyer 		 * however it asserts INT in IDEDMA_CTL even for non-DMA ops.
    554  1.1   bouyer 		 * So use it instead (requires 2 reg reads instead of 1,
    555  1.1   bouyer 		 * but we can't do it another way).
    556  1.1   bouyer 		 */
    557  1.1   bouyer 		dmastat = bus_space_read_1(sc->sc_dma_iot,
    558  1.1   bouyer 		    sc->sc_dma_ioh, IDEDMA_CTL + IDEDMA_SCH_OFFSET * i);
    559  1.1   bouyer 		if((dmastat & IDEDMA_CTL_INTR) == 0)
    560  1.1   bouyer 			continue;
    561  1.1   bouyer 		crv = wdcintr(wdc_cp);
    562  1.1   bouyer 		if (crv == 0)
    563  1.1   bouyer 			printf("%s:%d: bogus intr\n",
    564  1.1   bouyer 			    sc->sc_wdcdev.sc_dev.dv_xname, i);
    565  1.1   bouyer 		else
    566  1.1   bouyer 			rv = 1;
    567  1.1   bouyer 	}
    568  1.1   bouyer 	return rv;
    569  1.1   bouyer }
    570  1.1   bouyer 
    571  1.1   bouyer static void
    572  1.2  thorpej pdc20262_dma_start(void *v, int channel, int drive)
    573  1.1   bouyer {
    574  1.1   bouyer 	struct pciide_softc *sc = v;
    575  1.1   bouyer 	struct pciide_dma_maps *dma_maps =
    576  1.1   bouyer 	    &sc->pciide_channels[channel].dma_maps[drive];
    577  1.1   bouyer 	int atapi;
    578  1.1   bouyer 
    579  1.1   bouyer 	if (dma_maps->dma_flags & WDC_DMA_LBA48) {
    580  1.1   bouyer 		atapi = (dma_maps->dma_flags & WDC_DMA_READ) ?
    581  1.1   bouyer 		    PDC262_ATAPI_LBA48_READ : PDC262_ATAPI_LBA48_WRITE;
    582  1.1   bouyer 		atapi |= dma_maps->dmamap_xfer->dm_mapsize >> 1;
    583  1.1   bouyer 		bus_space_write_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    584  1.1   bouyer 		    PDC262_ATAPI(channel), atapi);
    585  1.1   bouyer 	}
    586  1.1   bouyer 
    587  1.1   bouyer 	pciide_dma_start(v, channel, drive);
    588  1.1   bouyer }
    589  1.1   bouyer 
    590  1.2  thorpej static int
    591  1.2  thorpej pdc20262_dma_finish(void *v, int channel, int drive, int force)
    592  1.1   bouyer {
    593  1.1   bouyer 	struct pciide_softc *sc = v;
    594  1.1   bouyer 	struct pciide_dma_maps *dma_maps =
    595  1.1   bouyer 	    &sc->pciide_channels[channel].dma_maps[drive];
    596  1.1   bouyer 	struct channel_softc *chp;
    597  1.1   bouyer 	int atapi, error;
    598  1.1   bouyer 
    599  1.1   bouyer 	error = pciide_dma_finish(v, channel, drive, force);
    600  1.1   bouyer 
    601  1.1   bouyer 	if (dma_maps->dma_flags & WDC_DMA_LBA48) {
    602  1.1   bouyer 		chp = sc->wdc_chanarray[channel];
    603  1.1   bouyer 		atapi = 0;
    604  1.1   bouyer 		if (chp->ch_drive[0].drive_flags & DRIVE_ATAPI ||
    605  1.1   bouyer 		    chp->ch_drive[1].drive_flags & DRIVE_ATAPI) {
    606  1.1   bouyer 			if ((!(chp->ch_drive[0].drive_flags & DRIVE_UDMA) ||
    607  1.1   bouyer 			    (chp->ch_drive[1].drive_flags & DRIVE_UDMA) ||
    608  1.1   bouyer 			    !(chp->ch_drive[1].drive_flags & DRIVE_DMA)) &&
    609  1.1   bouyer 			    (!(chp->ch_drive[1].drive_flags & DRIVE_UDMA) ||
    610  1.1   bouyer 			    (chp->ch_drive[0].drive_flags & DRIVE_UDMA) ||
    611  1.1   bouyer 			    !(chp->ch_drive[0].drive_flags & DRIVE_DMA)))
    612  1.1   bouyer 				atapi = PDC262_ATAPI_UDMA;
    613  1.1   bouyer 		}
    614  1.1   bouyer 		bus_space_write_4(sc->sc_dma_iot, sc->sc_dma_ioh,
    615  1.1   bouyer 		    PDC262_ATAPI(channel), atapi);
    616  1.1   bouyer 	}
    617  1.1   bouyer 
    618  1.1   bouyer 	return error;
    619  1.1   bouyer }
    620