rf_map.c revision 1.25 1 1.25 oster /* $NetBSD: rf_map.c,v 1.25 2003/12/29 17:13:36 oster Exp $ */
2 1.1 oster /*
3 1.1 oster * Copyright (c) 1995 Carnegie-Mellon University.
4 1.1 oster * All rights reserved.
5 1.1 oster *
6 1.1 oster * Author: Mark Holland
7 1.1 oster *
8 1.1 oster * Permission to use, copy, modify and distribute this software and
9 1.1 oster * its documentation is hereby granted, provided that both the copyright
10 1.1 oster * notice and this permission notice appear in all copies of the
11 1.1 oster * software, derivative works or modified versions, and any portions
12 1.1 oster * thereof, and that both notices appear in supporting documentation.
13 1.1 oster *
14 1.1 oster * CARNEGIE MELLON ALLOWS FREE USE OF THIS SOFTWARE IN ITS "AS IS"
15 1.1 oster * CONDITION. CARNEGIE MELLON DISCLAIMS ANY LIABILITY OF ANY KIND
16 1.1 oster * FOR ANY DAMAGES WHATSOEVER RESULTING FROM THE USE OF THIS SOFTWARE.
17 1.1 oster *
18 1.1 oster * Carnegie Mellon requests users of this software to return to
19 1.1 oster *
20 1.1 oster * Software Distribution Coordinator or Software.Distribution (at) CS.CMU.EDU
21 1.1 oster * School of Computer Science
22 1.1 oster * Carnegie Mellon University
23 1.1 oster * Pittsburgh PA 15213-3890
24 1.1 oster *
25 1.1 oster * any improvements or extensions that they make and grant Carnegie the
26 1.1 oster * rights to redistribute these changes.
27 1.1 oster */
28 1.1 oster
29 1.1 oster /**************************************************************************
30 1.1 oster *
31 1.1 oster * map.c -- main code for mapping RAID addresses to physical disk addresses
32 1.1 oster *
33 1.1 oster **************************************************************************/
34 1.9 lukem
35 1.9 lukem #include <sys/cdefs.h>
36 1.25 oster __KERNEL_RCSID(0, "$NetBSD: rf_map.c,v 1.25 2003/12/29 17:13:36 oster Exp $");
37 1.1 oster
38 1.7 oster #include <dev/raidframe/raidframevar.h>
39 1.7 oster
40 1.1 oster #include "rf_threadstuff.h"
41 1.1 oster #include "rf_raid.h"
42 1.1 oster #include "rf_general.h"
43 1.1 oster #include "rf_map.h"
44 1.1 oster #include "rf_shutdown.h"
45 1.1 oster
46 1.25 oster static void rf_FreePDAList(RF_PhysDiskAddr_t * start, RF_PhysDiskAddr_t * end,
47 1.25 oster int count);
48 1.25 oster static void rf_FreeASMList(RF_AccessStripeMap_t * start,
49 1.25 oster RF_AccessStripeMap_t * end, int count);
50 1.1 oster
51 1.21 oster /***************************************************************************
52 1.1 oster *
53 1.21 oster * MapAccess -- main 1st order mapping routine. Maps an access in the
54 1.21 oster * RAID address space to the corresponding set of physical disk
55 1.21 oster * addresses. The result is returned as a list of AccessStripeMap
56 1.21 oster * structures, one per stripe accessed. Each ASM structure contains a
57 1.21 oster * pointer to a list of PhysDiskAddr structures, which describe the
58 1.25 oster * physical locations touched by the user access. Note that this
59 1.25 oster * routine returns only static mapping information, i.e. the list of
60 1.25 oster * physical addresses returned does not necessarily identify the set
61 1.25 oster * of physical locations that will actually be read or written. The
62 1.25 oster * routine also maps the parity. The physical disk location returned
63 1.25 oster * always indicates the entire parity unit, even when only a subset of
64 1.25 oster * it is being accessed. This is because an access that is not stripe
65 1.25 oster * unit aligned but that spans a stripe unit boundary may require
66 1.25 oster * access two distinct portions of the parity unit, and we can't yet
67 1.25 oster * tell which portion(s) we'll actually need. We leave it up to the
68 1.25 oster * algorithm selection code to decide what subset of the parity unit
69 1.25 oster * to access. Note that addresses in the RAID address space must
70 1.25 oster * always be maintained as longs, instead of ints.
71 1.21 oster *
72 1.1 oster * This routine returns NULL if numBlocks is 0
73 1.1 oster *
74 1.21 oster ***************************************************************************/
75 1.1 oster
76 1.3 oster RF_AccessStripeMapHeader_t *
77 1.3 oster rf_MapAccess(raidPtr, raidAddress, numBlocks, buffer, remap)
78 1.3 oster RF_Raid_t *raidPtr;
79 1.3 oster RF_RaidAddr_t raidAddress; /* starting address in RAID address
80 1.3 oster * space */
81 1.3 oster RF_SectorCount_t numBlocks; /* number of blocks in RAID address
82 1.3 oster * space to access */
83 1.3 oster caddr_t buffer; /* buffer to supply/receive data */
84 1.3 oster int remap; /* 1 => remap addresses to spare space */
85 1.3 oster {
86 1.3 oster RF_RaidLayout_t *layoutPtr = &(raidPtr->Layout);
87 1.3 oster RF_AccessStripeMapHeader_t *asm_hdr = NULL;
88 1.3 oster RF_AccessStripeMap_t *asm_list = NULL, *asm_p = NULL;
89 1.3 oster int faultsTolerated = layoutPtr->map->faultsTolerated;
90 1.25 oster /* we'll change raidAddress along the way */
91 1.25 oster RF_RaidAddr_t startAddress = raidAddress;
92 1.3 oster RF_RaidAddr_t endAddress = raidAddress + numBlocks;
93 1.23 oster RF_RaidDisk_t *disks = raidPtr->Disks;
94 1.3 oster
95 1.3 oster RF_PhysDiskAddr_t *pda_p, *pda_q;
96 1.3 oster RF_StripeCount_t numStripes = 0;
97 1.25 oster RF_RaidAddr_t stripeRealEndAddress, stripeEndAddress,
98 1.25 oster nextStripeUnitAddress;
99 1.3 oster RF_RaidAddr_t startAddrWithinStripe, lastRaidAddr;
100 1.3 oster RF_StripeCount_t totStripes;
101 1.3 oster RF_StripeNum_t stripeID, lastSID, SUID, lastSUID;
102 1.3 oster RF_AccessStripeMap_t *asmList, *t_asm;
103 1.3 oster RF_PhysDiskAddr_t *pdaList, *t_pda;
104 1.3 oster
105 1.3 oster /* allocate all the ASMs and PDAs up front */
106 1.3 oster lastRaidAddr = raidAddress + numBlocks - 1;
107 1.3 oster stripeID = rf_RaidAddressToStripeID(layoutPtr, raidAddress);
108 1.3 oster lastSID = rf_RaidAddressToStripeID(layoutPtr, lastRaidAddr);
109 1.3 oster totStripes = lastSID - stripeID + 1;
110 1.3 oster SUID = rf_RaidAddressToStripeUnitID(layoutPtr, raidAddress);
111 1.3 oster lastSUID = rf_RaidAddressToStripeUnitID(layoutPtr, lastRaidAddr);
112 1.3 oster
113 1.3 oster asmList = rf_AllocASMList(totStripes);
114 1.25 oster
115 1.25 oster /* may also need pda(s) per stripe for parity */
116 1.25 oster pdaList = rf_AllocPDAList(lastSUID - SUID + 1 +
117 1.25 oster faultsTolerated * totStripes);
118 1.25 oster
119 1.3 oster
120 1.3 oster if (raidAddress + numBlocks > raidPtr->totalSectors) {
121 1.3 oster RF_ERRORMSG1("Unable to map access because offset (%d) was invalid\n",
122 1.3 oster (int) raidAddress);
123 1.3 oster return (NULL);
124 1.3 oster }
125 1.15 oster #if RF_DEBUG_MAP
126 1.3 oster if (rf_mapDebug)
127 1.3 oster rf_PrintRaidAddressInfo(raidPtr, raidAddress, numBlocks);
128 1.15 oster #endif
129 1.3 oster for (; raidAddress < endAddress;) {
130 1.3 oster /* make the next stripe structure */
131 1.3 oster RF_ASSERT(asmList);
132 1.3 oster t_asm = asmList;
133 1.3 oster asmList = asmList->next;
134 1.6 thorpej memset((char *) t_asm, 0, sizeof(RF_AccessStripeMap_t));
135 1.3 oster if (!asm_p)
136 1.3 oster asm_list = asm_p = t_asm;
137 1.3 oster else {
138 1.3 oster asm_p->next = t_asm;
139 1.3 oster asm_p = asm_p->next;
140 1.3 oster }
141 1.3 oster numStripes++;
142 1.3 oster
143 1.3 oster /* map SUs from current location to the end of the stripe */
144 1.3 oster asm_p->stripeID = /* rf_RaidAddressToStripeID(layoutPtr,
145 1.3 oster raidAddress) */ stripeID++;
146 1.3 oster stripeRealEndAddress = rf_RaidAddressOfNextStripeBoundary(layoutPtr, raidAddress);
147 1.3 oster stripeEndAddress = RF_MIN(endAddress, stripeRealEndAddress);
148 1.3 oster asm_p->raidAddress = raidAddress;
149 1.3 oster asm_p->endRaidAddress = stripeEndAddress;
150 1.3 oster
151 1.3 oster /* map each stripe unit in the stripe */
152 1.3 oster pda_p = NULL;
153 1.25 oster
154 1.25 oster /* Raid addr of start of portion of access that is
155 1.25 oster within this stripe */
156 1.25 oster startAddrWithinStripe = raidAddress;
157 1.25 oster
158 1.3 oster for (; raidAddress < stripeEndAddress;) {
159 1.3 oster RF_ASSERT(pdaList);
160 1.3 oster t_pda = pdaList;
161 1.3 oster pdaList = pdaList->next;
162 1.6 thorpej memset((char *) t_pda, 0, sizeof(RF_PhysDiskAddr_t));
163 1.3 oster if (!pda_p)
164 1.3 oster asm_p->physInfo = pda_p = t_pda;
165 1.3 oster else {
166 1.3 oster pda_p->next = t_pda;
167 1.3 oster pda_p = pda_p->next;
168 1.3 oster }
169 1.3 oster
170 1.3 oster pda_p->type = RF_PDA_TYPE_DATA;
171 1.25 oster (layoutPtr->map->MapSector) (raidPtr, raidAddress,
172 1.25 oster &(pda_p->col),
173 1.25 oster &(pda_p->startSector),
174 1.25 oster remap);
175 1.25 oster
176 1.25 oster /* mark any failures we find. failedPDA is
177 1.25 oster * don't-care if there is more than one
178 1.25 oster * failure */
179 1.25 oster
180 1.25 oster /* the RAID address corresponding to this
181 1.25 oster physical diskaddress */
182 1.25 oster pda_p->raidAddress = raidAddress;
183 1.3 oster nextStripeUnitAddress = rf_RaidAddressOfNextStripeUnitBoundary(layoutPtr, raidAddress);
184 1.3 oster pda_p->numSector = RF_MIN(endAddress, nextStripeUnitAddress) - raidAddress;
185 1.3 oster RF_ASSERT(pda_p->numSector != 0);
186 1.3 oster rf_ASMCheckStatus(raidPtr, pda_p, asm_p, disks, 0);
187 1.3 oster pda_p->bufPtr = buffer + rf_RaidAddressToByte(raidPtr, (raidAddress - startAddress));
188 1.3 oster asm_p->totalSectorsAccessed += pda_p->numSector;
189 1.3 oster asm_p->numStripeUnitsAccessed++;
190 1.3 oster
191 1.3 oster raidAddress = RF_MIN(endAddress, nextStripeUnitAddress);
192 1.3 oster }
193 1.3 oster
194 1.3 oster /* Map the parity. At this stage, the startSector and
195 1.25 oster * numSector fields for the parity unit are always set
196 1.25 oster * to indicate the entire parity unit. We may modify
197 1.25 oster * this after mapping the data portion. */
198 1.3 oster switch (faultsTolerated) {
199 1.3 oster case 0:
200 1.3 oster break;
201 1.3 oster case 1: /* single fault tolerant */
202 1.3 oster RF_ASSERT(pdaList);
203 1.3 oster t_pda = pdaList;
204 1.3 oster pdaList = pdaList->next;
205 1.6 thorpej memset((char *) t_pda, 0, sizeof(RF_PhysDiskAddr_t));
206 1.3 oster pda_p = asm_p->parityInfo = t_pda;
207 1.3 oster pda_p->type = RF_PDA_TYPE_PARITY;
208 1.3 oster (layoutPtr->map->MapParity) (raidPtr, rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe),
209 1.23 oster &(pda_p->col), &(pda_p->startSector), remap);
210 1.3 oster pda_p->numSector = layoutPtr->sectorsPerStripeUnit;
211 1.3 oster /* raidAddr may be needed to find unit to redirect to */
212 1.3 oster pda_p->raidAddress = rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe);
213 1.3 oster rf_ASMCheckStatus(raidPtr, pda_p, asm_p, disks, 1);
214 1.3 oster rf_ASMParityAdjust(asm_p->parityInfo, startAddrWithinStripe, endAddress, layoutPtr, asm_p);
215 1.3 oster
216 1.3 oster break;
217 1.3 oster case 2: /* two fault tolerant */
218 1.3 oster RF_ASSERT(pdaList && pdaList->next);
219 1.3 oster t_pda = pdaList;
220 1.3 oster pdaList = pdaList->next;
221 1.6 thorpej memset((char *) t_pda, 0, sizeof(RF_PhysDiskAddr_t));
222 1.3 oster pda_p = asm_p->parityInfo = t_pda;
223 1.3 oster pda_p->type = RF_PDA_TYPE_PARITY;
224 1.3 oster t_pda = pdaList;
225 1.3 oster pdaList = pdaList->next;
226 1.6 thorpej memset((char *) t_pda, 0, sizeof(RF_PhysDiskAddr_t));
227 1.3 oster pda_q = asm_p->qInfo = t_pda;
228 1.3 oster pda_q->type = RF_PDA_TYPE_Q;
229 1.3 oster (layoutPtr->map->MapParity) (raidPtr, rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe),
230 1.23 oster &(pda_p->col), &(pda_p->startSector), remap);
231 1.3 oster (layoutPtr->map->MapQ) (raidPtr, rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe),
232 1.23 oster &(pda_q->col), &(pda_q->startSector), remap);
233 1.3 oster pda_q->numSector = pda_p->numSector = layoutPtr->sectorsPerStripeUnit;
234 1.3 oster /* raidAddr may be needed to find unit to redirect to */
235 1.3 oster pda_p->raidAddress = rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe);
236 1.3 oster pda_q->raidAddress = rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, startAddrWithinStripe);
237 1.3 oster /* failure mode stuff */
238 1.3 oster rf_ASMCheckStatus(raidPtr, pda_p, asm_p, disks, 1);
239 1.3 oster rf_ASMCheckStatus(raidPtr, pda_q, asm_p, disks, 1);
240 1.3 oster rf_ASMParityAdjust(asm_p->parityInfo, startAddrWithinStripe, endAddress, layoutPtr, asm_p);
241 1.3 oster rf_ASMParityAdjust(asm_p->qInfo, startAddrWithinStripe, endAddress, layoutPtr, asm_p);
242 1.3 oster break;
243 1.3 oster }
244 1.3 oster }
245 1.3 oster RF_ASSERT(asmList == NULL && pdaList == NULL);
246 1.3 oster /* make the header structure */
247 1.3 oster asm_hdr = rf_AllocAccessStripeMapHeader();
248 1.3 oster RF_ASSERT(numStripes == totStripes);
249 1.3 oster asm_hdr->numStripes = numStripes;
250 1.3 oster asm_hdr->stripeMap = asm_list;
251 1.3 oster
252 1.15 oster #if RF_DEBUG_MAP
253 1.3 oster if (rf_mapDebug)
254 1.3 oster rf_PrintAccessStripeMap(asm_hdr);
255 1.15 oster #endif
256 1.3 oster return (asm_hdr);
257 1.1 oster }
258 1.21 oster
259 1.21 oster /***************************************************************************
260 1.21 oster * This routine walks through an ASM list and marks the PDAs that have
261 1.21 oster * failed. It's called only when a disk failure causes an in-flight
262 1.21 oster * DAG to fail. The parity may consist of two components, but we want
263 1.21 oster * to use only one failedPDA pointer. Thus we set failedPDA to point
264 1.21 oster * to the first parity component, and rely on the rest of the code to
265 1.21 oster * do the right thing with this.
266 1.21 oster ***************************************************************************/
267 1.1 oster
268 1.3 oster void
269 1.3 oster rf_MarkFailuresInASMList(raidPtr, asm_h)
270 1.3 oster RF_Raid_t *raidPtr;
271 1.3 oster RF_AccessStripeMapHeader_t *asm_h;
272 1.3 oster {
273 1.23 oster RF_RaidDisk_t *disks = raidPtr->Disks;
274 1.3 oster RF_AccessStripeMap_t *asmap;
275 1.3 oster RF_PhysDiskAddr_t *pda;
276 1.3 oster
277 1.3 oster for (asmap = asm_h->stripeMap; asmap; asmap = asmap->next) {
278 1.25 oster asmap->numDataFailed = 0;
279 1.25 oster asmap->numParityFailed = 0;
280 1.25 oster asmap->numQFailed = 0;
281 1.3 oster asmap->numFailedPDAs = 0;
282 1.6 thorpej memset((char *) asmap->failedPDAs, 0,
283 1.3 oster RF_MAX_FAILED_PDA * sizeof(RF_PhysDiskAddr_t *));
284 1.3 oster for (pda = asmap->physInfo; pda; pda = pda->next) {
285 1.23 oster if (RF_DEAD_DISK(disks[pda->col].status)) {
286 1.3 oster asmap->numDataFailed++;
287 1.3 oster asmap->failedPDAs[asmap->numFailedPDAs] = pda;
288 1.3 oster asmap->numFailedPDAs++;
289 1.3 oster }
290 1.3 oster }
291 1.3 oster pda = asmap->parityInfo;
292 1.23 oster if (pda && RF_DEAD_DISK(disks[pda->col].status)) {
293 1.3 oster asmap->numParityFailed++;
294 1.3 oster asmap->failedPDAs[asmap->numFailedPDAs] = pda;
295 1.3 oster asmap->numFailedPDAs++;
296 1.3 oster }
297 1.3 oster pda = asmap->qInfo;
298 1.23 oster if (pda && RF_DEAD_DISK(disks[pda->col].status)) {
299 1.3 oster asmap->numQFailed++;
300 1.3 oster asmap->failedPDAs[asmap->numFailedPDAs] = pda;
301 1.3 oster asmap->numFailedPDAs++;
302 1.3 oster }
303 1.3 oster }
304 1.1 oster }
305 1.3 oster
306 1.21 oster /***************************************************************************
307 1.1 oster *
308 1.21 oster * routines to allocate and free list elements. All allocation
309 1.21 oster * routines zero the structure before returning it.
310 1.1 oster *
311 1.21 oster * FreePhysDiskAddr is static. It should never be called directly,
312 1.21 oster * because FreeAccessStripeMap takes care of freeing the PhysDiskAddr
313 1.21 oster * list.
314 1.1 oster *
315 1.21 oster ***************************************************************************/
316 1.1 oster
317 1.24 oster static struct pool rf_asmhdr_pool;
318 1.1 oster #define RF_MAX_FREE_ASMHDR 128
319 1.1 oster #define RF_ASMHDR_INC 16
320 1.1 oster #define RF_ASMHDR_INITIAL 32
321 1.1 oster
322 1.24 oster static struct pool rf_asm_pool;
323 1.1 oster #define RF_MAX_FREE_ASM 192
324 1.1 oster #define RF_ASM_INC 24
325 1.1 oster #define RF_ASM_INITIAL 64
326 1.1 oster
327 1.24 oster static struct pool rf_pda_pool; /* may need to be visible for
328 1.24 oster rf_dagdegrd.c and rf_dagdegwr.c,
329 1.24 oster if they can be convinced to free
330 1.24 oster the space easily */
331 1.1 oster #define RF_MAX_FREE_PDA 192
332 1.1 oster #define RF_PDA_INC 24
333 1.1 oster #define RF_PDA_INITIAL 64
334 1.1 oster
335 1.25 oster /* called at shutdown time. So far, all that is necessary is to
336 1.25 oster release all the free lists */
337 1.1 oster static void rf_ShutdownMapModule(void *);
338 1.3 oster static void
339 1.3 oster rf_ShutdownMapModule(ignored)
340 1.3 oster void *ignored;
341 1.1 oster {
342 1.24 oster pool_destroy(&rf_asmhdr_pool);
343 1.24 oster pool_destroy(&rf_asm_pool);
344 1.24 oster pool_destroy(&rf_pda_pool);
345 1.1 oster }
346 1.1 oster
347 1.3 oster int
348 1.3 oster rf_ConfigureMapModule(listp)
349 1.3 oster RF_ShutdownList_t **listp;
350 1.1 oster {
351 1.3 oster int rc;
352 1.1 oster
353 1.24 oster pool_init(&rf_asmhdr_pool, sizeof(RF_AccessStripeMapHeader_t),
354 1.24 oster 0, 0, 0, "rf_asmhdr_pl", NULL);
355 1.24 oster pool_sethiwat(&rf_asmhdr_pool, RF_MAX_FREE_ASMHDR);
356 1.24 oster pool_prime(&rf_asmhdr_pool, RF_ASMHDR_INITIAL);
357 1.24 oster
358 1.24 oster pool_init(&rf_asm_pool, sizeof(RF_AccessStripeMap_t),
359 1.24 oster 0, 0, 0, "rf_asm_pl", NULL);
360 1.24 oster pool_sethiwat(&rf_asm_pool, RF_MAX_FREE_ASM);
361 1.24 oster pool_prime(&rf_asm_pool, RF_ASM_INITIAL);
362 1.24 oster
363 1.24 oster pool_init(&rf_pda_pool, sizeof(RF_PhysDiskAddr_t),
364 1.24 oster 0, 0, 0, "rf_pda_pl", NULL);
365 1.24 oster pool_sethiwat(&rf_pda_pool, RF_MAX_FREE_PDA);
366 1.24 oster pool_prime(&rf_pda_pool, RF_PDA_INITIAL);
367 1.24 oster
368 1.1 oster rc = rf_ShutdownCreate(listp, rf_ShutdownMapModule, NULL);
369 1.1 oster if (rc) {
370 1.14 oster rf_print_unable_to_add_shutdown(__FILE__, __LINE__, rc);
371 1.1 oster rf_ShutdownMapModule(NULL);
372 1.3 oster return (rc);
373 1.1 oster }
374 1.3 oster return (0);
375 1.1 oster }
376 1.1 oster
377 1.3 oster RF_AccessStripeMapHeader_t *
378 1.3 oster rf_AllocAccessStripeMapHeader()
379 1.1 oster {
380 1.1 oster RF_AccessStripeMapHeader_t *p;
381 1.1 oster
382 1.24 oster p = pool_get(&rf_asmhdr_pool, PR_WAITOK);
383 1.6 thorpej memset((char *) p, 0, sizeof(RF_AccessStripeMapHeader_t));
384 1.1 oster
385 1.3 oster return (p);
386 1.1 oster }
387 1.1 oster
388 1.3 oster void
389 1.3 oster rf_FreeAccessStripeMapHeader(p)
390 1.3 oster RF_AccessStripeMapHeader_t *p;
391 1.1 oster {
392 1.24 oster pool_put(&rf_asmhdr_pool, p);
393 1.1 oster }
394 1.1 oster
395 1.3 oster RF_PhysDiskAddr_t *
396 1.3 oster rf_AllocPhysDiskAddr()
397 1.1 oster {
398 1.1 oster RF_PhysDiskAddr_t *p;
399 1.1 oster
400 1.24 oster p = pool_get(&rf_pda_pool, PR_WAITOK);
401 1.6 thorpej memset((char *) p, 0, sizeof(RF_PhysDiskAddr_t));
402 1.1 oster
403 1.3 oster return (p);
404 1.1 oster }
405 1.25 oster /* allocates a list of PDAs, locking the free list only once when we
406 1.25 oster * have to call calloc, we do it one component at a time to simplify
407 1.25 oster * the process of freeing the list at program shutdown. This should
408 1.25 oster * not be much of a performance hit, because it should be very
409 1.25 oster * infrequently executed. */
410 1.3 oster RF_PhysDiskAddr_t *
411 1.3 oster rf_AllocPDAList(count)
412 1.3 oster int count;
413 1.1 oster {
414 1.24 oster RF_PhysDiskAddr_t *p, *prev;
415 1.24 oster int i;
416 1.24 oster
417 1.24 oster p = NULL;
418 1.24 oster prev = NULL;
419 1.24 oster for (i = 0; i < count; i++) {
420 1.24 oster p = pool_get(&rf_pda_pool, PR_WAITOK);
421 1.24 oster p->next = prev;
422 1.24 oster prev = p;
423 1.24 oster }
424 1.1 oster
425 1.3 oster return (p);
426 1.1 oster }
427 1.1 oster
428 1.18 oster #if RF_INCLUDE_PARITYLOGGING > 0
429 1.3 oster void
430 1.3 oster rf_FreePhysDiskAddr(p)
431 1.3 oster RF_PhysDiskAddr_t *p;
432 1.1 oster {
433 1.24 oster pool_put(&rf_pda_pool, p);
434 1.1 oster }
435 1.18 oster #endif
436 1.1 oster
437 1.3 oster static void
438 1.3 oster rf_FreePDAList(l_start, l_end, count)
439 1.3 oster RF_PhysDiskAddr_t *l_start, *l_end; /* pointers to start and end
440 1.3 oster * of list */
441 1.3 oster int count; /* number of elements in list */
442 1.1 oster {
443 1.24 oster RF_PhysDiskAddr_t *p, *tmp;
444 1.24 oster
445 1.24 oster p=l_start;
446 1.24 oster while (p) {
447 1.24 oster tmp = p->next;
448 1.24 oster pool_put(&rf_pda_pool, p);
449 1.24 oster p = tmp;
450 1.24 oster }
451 1.1 oster }
452 1.1 oster
453 1.25 oster /* this is essentially identical to AllocPDAList. I should combine
454 1.25 oster * the two. when we have to call calloc, we do it one component at a
455 1.25 oster * time to simplify the process of freeing the list at program
456 1.25 oster * shutdown. This should not be much of a performance hit, because it
457 1.25 oster * should be very infrequently executed. */
458 1.3 oster RF_AccessStripeMap_t *
459 1.3 oster rf_AllocASMList(count)
460 1.3 oster int count;
461 1.1 oster {
462 1.24 oster RF_AccessStripeMap_t *p, *prev;
463 1.24 oster int i;
464 1.1 oster
465 1.24 oster p = NULL;
466 1.24 oster prev = NULL;
467 1.24 oster for (i = 0; i < count; i++) {
468 1.24 oster p = pool_get(&rf_asm_pool, PR_WAITOK);
469 1.24 oster p->next = prev;
470 1.24 oster prev = p;
471 1.24 oster }
472 1.3 oster return (p);
473 1.1 oster }
474 1.1 oster
475 1.3 oster static void
476 1.3 oster rf_FreeASMList(l_start, l_end, count)
477 1.3 oster RF_AccessStripeMap_t *l_start, *l_end;
478 1.3 oster int count;
479 1.3 oster {
480 1.24 oster RF_AccessStripeMap_t *p, *tmp;
481 1.24 oster
482 1.24 oster p=l_start;
483 1.24 oster while (p) {
484 1.24 oster tmp = p->next;
485 1.24 oster pool_put(&rf_asm_pool, p);
486 1.24 oster p = tmp;
487 1.24 oster }
488 1.3 oster }
489 1.3 oster
490 1.3 oster void
491 1.3 oster rf_FreeAccessStripeMap(hdr)
492 1.3 oster RF_AccessStripeMapHeader_t *hdr;
493 1.3 oster {
494 1.3 oster RF_AccessStripeMap_t *p, *pt = NULL;
495 1.3 oster RF_PhysDiskAddr_t *pdp, *trailer, *pdaList = NULL, *pdaEnd = NULL;
496 1.3 oster int count = 0, t, asm_count = 0;
497 1.3 oster
498 1.3 oster for (p = hdr->stripeMap; p; p = p->next) {
499 1.3 oster
500 1.3 oster /* link the 3 pda lists into the accumulating pda list */
501 1.3 oster
502 1.3 oster if (!pdaList)
503 1.3 oster pdaList = p->qInfo;
504 1.3 oster else
505 1.3 oster pdaEnd->next = p->qInfo;
506 1.3 oster for (trailer = NULL, pdp = p->qInfo; pdp;) {
507 1.3 oster trailer = pdp;
508 1.3 oster pdp = pdp->next;
509 1.3 oster count++;
510 1.3 oster }
511 1.3 oster if (trailer)
512 1.3 oster pdaEnd = trailer;
513 1.3 oster
514 1.3 oster if (!pdaList)
515 1.3 oster pdaList = p->parityInfo;
516 1.3 oster else
517 1.3 oster pdaEnd->next = p->parityInfo;
518 1.3 oster for (trailer = NULL, pdp = p->parityInfo; pdp;) {
519 1.3 oster trailer = pdp;
520 1.3 oster pdp = pdp->next;
521 1.3 oster count++;
522 1.3 oster }
523 1.3 oster if (trailer)
524 1.3 oster pdaEnd = trailer;
525 1.3 oster
526 1.3 oster if (!pdaList)
527 1.3 oster pdaList = p->physInfo;
528 1.3 oster else
529 1.3 oster pdaEnd->next = p->physInfo;
530 1.3 oster for (trailer = NULL, pdp = p->physInfo; pdp;) {
531 1.3 oster trailer = pdp;
532 1.3 oster pdp = pdp->next;
533 1.3 oster count++;
534 1.3 oster }
535 1.3 oster if (trailer)
536 1.3 oster pdaEnd = trailer;
537 1.3 oster
538 1.3 oster pt = p;
539 1.3 oster asm_count++;
540 1.3 oster }
541 1.3 oster
542 1.3 oster /* debug only */
543 1.3 oster for (t = 0, pdp = pdaList; pdp; pdp = pdp->next)
544 1.3 oster t++;
545 1.3 oster RF_ASSERT(t == count);
546 1.3 oster
547 1.3 oster if (pdaList)
548 1.3 oster rf_FreePDAList(pdaList, pdaEnd, count);
549 1.3 oster rf_FreeASMList(hdr->stripeMap, pt, asm_count);
550 1.3 oster rf_FreeAccessStripeMapHeader(hdr);
551 1.1 oster }
552 1.21 oster /* We can't use the large write optimization if there are any failures
553 1.21 oster * in the stripe. In the declustered layout, there is no way to
554 1.21 oster * immediately determine what disks constitute a stripe, so we
555 1.21 oster * actually have to hunt through the stripe looking for failures. The
556 1.21 oster * reason we map the parity instead of just using asm->parityInfo->col
557 1.21 oster * is because the latter may have been already redirected to a spare
558 1.21 oster * drive, which would mess up the computation of the stripe offset.
559 1.1 oster *
560 1.21 oster * ASSUMES AT MOST ONE FAILURE IN THE STRIPE. */
561 1.3 oster int
562 1.3 oster rf_CheckStripeForFailures(raidPtr, asmap)
563 1.3 oster RF_Raid_t *raidPtr;
564 1.3 oster RF_AccessStripeMap_t *asmap;
565 1.3 oster {
566 1.23 oster RF_RowCol_t tcol, pcol, *diskids, i;
567 1.3 oster RF_RaidLayout_t *layoutPtr = &raidPtr->Layout;
568 1.3 oster RF_StripeCount_t stripeOffset;
569 1.3 oster int numFailures;
570 1.3 oster RF_RaidAddr_t sosAddr;
571 1.3 oster RF_SectorNum_t diskOffset, poffset;
572 1.3 oster
573 1.3 oster /* quick out in the fault-free case. */
574 1.3 oster RF_LOCK_MUTEX(raidPtr->mutex);
575 1.3 oster numFailures = raidPtr->numFailures;
576 1.3 oster RF_UNLOCK_MUTEX(raidPtr->mutex);
577 1.3 oster if (numFailures == 0)
578 1.3 oster return (0);
579 1.3 oster
580 1.25 oster sosAddr = rf_RaidAddressOfPrevStripeBoundary(layoutPtr,
581 1.25 oster asmap->raidAddress);
582 1.25 oster (layoutPtr->map->IdentifyStripe) (raidPtr, asmap->raidAddress,
583 1.25 oster &diskids);
584 1.25 oster (layoutPtr->map->MapParity) (raidPtr, asmap->raidAddress,
585 1.25 oster &pcol, &poffset, 0); /* get pcol */
586 1.3 oster
587 1.25 oster /* this need not be true if we've redirected the access to a
588 1.25 oster * spare in another row RF_ASSERT(row == testrow); */
589 1.3 oster stripeOffset = 0;
590 1.3 oster for (i = 0; i < layoutPtr->numDataCol + layoutPtr->numParityCol; i++) {
591 1.3 oster if (diskids[i] != pcol) {
592 1.23 oster if (RF_DEAD_DISK(raidPtr->Disks[diskids[i]].status)) {
593 1.23 oster if (raidPtr->status != rf_rs_reconstructing)
594 1.3 oster return (1);
595 1.23 oster RF_ASSERT(raidPtr->reconControl->fcol == diskids[i]);
596 1.3 oster layoutPtr->map->MapSector(raidPtr,
597 1.3 oster sosAddr + stripeOffset * layoutPtr->sectorsPerStripeUnit,
598 1.23 oster &tcol, &diskOffset, 0);
599 1.23 oster RF_ASSERT(tcol == diskids[i]);
600 1.23 oster if (!rf_CheckRUReconstructed(raidPtr->reconControl->reconMap, diskOffset))
601 1.3 oster return (1);
602 1.3 oster asmap->flags |= RF_ASM_REDIR_LARGE_WRITE;
603 1.3 oster return (0);
604 1.3 oster }
605 1.3 oster stripeOffset++;
606 1.3 oster }
607 1.3 oster }
608 1.3 oster return (0);
609 1.1 oster }
610 1.18 oster #if (RF_INCLUDE_DECL_PQ > 0) || (RF_INCLUDE_RAID6 > 0) || (RF_INCLUDE_EVENODD >0)
611 1.1 oster /*
612 1.1 oster return the number of failed data units in the stripe.
613 1.1 oster */
614 1.1 oster
615 1.3 oster int
616 1.3 oster rf_NumFailedDataUnitsInStripe(raidPtr, asmap)
617 1.3 oster RF_Raid_t *raidPtr;
618 1.3 oster RF_AccessStripeMap_t *asmap;
619 1.3 oster {
620 1.3 oster RF_RaidLayout_t *layoutPtr = &raidPtr->Layout;
621 1.23 oster RF_RowCol_t tcol, i;
622 1.3 oster RF_SectorNum_t diskOffset;
623 1.3 oster RF_RaidAddr_t sosAddr;
624 1.3 oster int numFailures;
625 1.3 oster
626 1.3 oster /* quick out in the fault-free case. */
627 1.3 oster RF_LOCK_MUTEX(raidPtr->mutex);
628 1.3 oster numFailures = raidPtr->numFailures;
629 1.3 oster RF_UNLOCK_MUTEX(raidPtr->mutex);
630 1.3 oster if (numFailures == 0)
631 1.3 oster return (0);
632 1.3 oster numFailures = 0;
633 1.3 oster
634 1.25 oster sosAddr = rf_RaidAddressOfPrevStripeBoundary(layoutPtr,
635 1.25 oster asmap->raidAddress);
636 1.3 oster for (i = 0; i < layoutPtr->numDataCol; i++) {
637 1.3 oster (layoutPtr->map->MapSector) (raidPtr, sosAddr + i * layoutPtr->sectorsPerStripeUnit,
638 1.3 oster &trow, &tcol, &diskOffset, 0);
639 1.23 oster if (RF_DEAD_DISK(raidPtr->Disks[tcol].status))
640 1.3 oster numFailures++;
641 1.3 oster }
642 1.1 oster
643 1.3 oster return numFailures;
644 1.1 oster }
645 1.18 oster #endif
646 1.1 oster
647 1.25 oster /****************************************************************************
648 1.1 oster *
649 1.1 oster * debug routines
650 1.1 oster *
651 1.25 oster ***************************************************************************/
652 1.18 oster #if RF_DEBUG_MAP
653 1.3 oster void
654 1.3 oster rf_PrintAccessStripeMap(asm_h)
655 1.3 oster RF_AccessStripeMapHeader_t *asm_h;
656 1.1 oster {
657 1.3 oster rf_PrintFullAccessStripeMap(asm_h, 0);
658 1.1 oster }
659 1.18 oster #endif
660 1.1 oster
661 1.3 oster void
662 1.3 oster rf_PrintFullAccessStripeMap(asm_h, prbuf)
663 1.3 oster RF_AccessStripeMapHeader_t *asm_h;
664 1.3 oster int prbuf; /* flag to print buffer pointers */
665 1.3 oster {
666 1.3 oster int i;
667 1.3 oster RF_AccessStripeMap_t *asmap = asm_h->stripeMap;
668 1.3 oster RF_PhysDiskAddr_t *p;
669 1.3 oster printf("%d stripes total\n", (int) asm_h->numStripes);
670 1.3 oster for (; asmap; asmap = asmap->next) {
671 1.3 oster /* printf("Num failures: %d\n",asmap->numDataFailed); */
672 1.3 oster /* printf("Num sectors:
673 1.3 oster * %d\n",(int)asmap->totalSectorsAccessed); */
674 1.3 oster printf("Stripe %d (%d sectors), failures: %d data, %d parity: ",
675 1.3 oster (int) asmap->stripeID,
676 1.3 oster (int) asmap->totalSectorsAccessed,
677 1.3 oster (int) asmap->numDataFailed,
678 1.3 oster (int) asmap->numParityFailed);
679 1.3 oster if (asmap->parityInfo) {
680 1.23 oster printf("Parity [c%d s%d-%d", asmap->parityInfo->col,
681 1.3 oster (int) asmap->parityInfo->startSector,
682 1.3 oster (int) (asmap->parityInfo->startSector +
683 1.3 oster asmap->parityInfo->numSector - 1));
684 1.3 oster if (prbuf)
685 1.3 oster printf(" b0x%lx", (unsigned long) asmap->parityInfo->bufPtr);
686 1.3 oster if (asmap->parityInfo->next) {
687 1.23 oster printf(", c%d s%d-%d", asmap->parityInfo->next->col,
688 1.3 oster (int) asmap->parityInfo->next->startSector,
689 1.3 oster (int) (asmap->parityInfo->next->startSector +
690 1.3 oster asmap->parityInfo->next->numSector - 1));
691 1.3 oster if (prbuf)
692 1.3 oster printf(" b0x%lx", (unsigned long) asmap->parityInfo->next->bufPtr);
693 1.3 oster RF_ASSERT(asmap->parityInfo->next->next == NULL);
694 1.3 oster }
695 1.3 oster printf("]\n\t");
696 1.3 oster }
697 1.3 oster for (i = 0, p = asmap->physInfo; p; p = p->next, i++) {
698 1.23 oster printf("SU c%d s%d-%d ", p->col, (int) p->startSector,
699 1.3 oster (int) (p->startSector + p->numSector - 1));
700 1.3 oster if (prbuf)
701 1.3 oster printf("b0x%lx ", (unsigned long) p->bufPtr);
702 1.3 oster if (i && !(i & 1))
703 1.3 oster printf("\n\t");
704 1.3 oster }
705 1.3 oster printf("\n");
706 1.3 oster p = asm_h->stripeMap->failedPDAs[0];
707 1.3 oster if (asm_h->stripeMap->numDataFailed + asm_h->stripeMap->numParityFailed > 1)
708 1.3 oster printf("[multiple failures]\n");
709 1.3 oster else
710 1.3 oster if (asm_h->stripeMap->numDataFailed + asm_h->stripeMap->numParityFailed > 0)
711 1.23 oster printf("\t[Failed PDA: c%d s%d-%d]\n", p->col,
712 1.3 oster (int) p->startSector, (int) (p->startSector + p->numSector - 1));
713 1.3 oster }
714 1.1 oster }
715 1.1 oster
716 1.15 oster #if RF_MAP_DEBUG
717 1.3 oster void
718 1.3 oster rf_PrintRaidAddressInfo(raidPtr, raidAddr, numBlocks)
719 1.3 oster RF_Raid_t *raidPtr;
720 1.3 oster RF_RaidAddr_t raidAddr;
721 1.3 oster RF_SectorCount_t numBlocks;
722 1.3 oster {
723 1.3 oster RF_RaidLayout_t *layoutPtr = &raidPtr->Layout;
724 1.3 oster RF_RaidAddr_t ra, sosAddr = rf_RaidAddressOfPrevStripeBoundary(layoutPtr, raidAddr);
725 1.3 oster
726 1.3 oster printf("Raid addrs of SU boundaries from start of stripe to end of access:\n\t");
727 1.3 oster for (ra = sosAddr; ra <= raidAddr + numBlocks; ra += layoutPtr->sectorsPerStripeUnit) {
728 1.3 oster printf("%d (0x%x), ", (int) ra, (int) ra);
729 1.3 oster }
730 1.3 oster printf("\n");
731 1.3 oster printf("Offset into stripe unit: %d (0x%x)\n",
732 1.3 oster (int) (raidAddr % layoutPtr->sectorsPerStripeUnit),
733 1.3 oster (int) (raidAddr % layoutPtr->sectorsPerStripeUnit));
734 1.3 oster }
735 1.15 oster #endif
736 1.25 oster /* given a parity descriptor and the starting address within a stripe,
737 1.25 oster * range restrict the parity descriptor to touch only the correct
738 1.25 oster * stuff. */
739 1.3 oster void
740 1.3 oster rf_ASMParityAdjust(
741 1.3 oster RF_PhysDiskAddr_t * toAdjust,
742 1.3 oster RF_StripeNum_t startAddrWithinStripe,
743 1.3 oster RF_SectorNum_t endAddress,
744 1.3 oster RF_RaidLayout_t * layoutPtr,
745 1.3 oster RF_AccessStripeMap_t * asm_p)
746 1.3 oster {
747 1.3 oster RF_PhysDiskAddr_t *new_pda;
748 1.3 oster
749 1.25 oster /* when we're accessing only a portion of one stripe unit, we
750 1.25 oster * want the parity descriptor to identify only the chunk of
751 1.25 oster * parity associated with the data. When the access spans
752 1.25 oster * exactly one stripe unit boundary and is less than a stripe
753 1.25 oster * unit in size, it uses two disjoint regions of the parity
754 1.25 oster * unit. When an access spans more than one stripe unit
755 1.25 oster * boundary, it uses all of the parity unit.
756 1.3 oster *
757 1.25 oster * To better handle the case where stripe units are small, we
758 1.25 oster * may eventually want to change the 2nd case so that if the
759 1.25 oster * SU size is below some threshold, we just read/write the
760 1.25 oster * whole thing instead of breaking it up into two accesses. */
761 1.3 oster if (asm_p->numStripeUnitsAccessed == 1) {
762 1.3 oster int x = (startAddrWithinStripe % layoutPtr->sectorsPerStripeUnit);
763 1.3 oster toAdjust->startSector += x;
764 1.3 oster toAdjust->raidAddress += x;
765 1.3 oster toAdjust->numSector = asm_p->physInfo->numSector;
766 1.3 oster RF_ASSERT(toAdjust->numSector != 0);
767 1.3 oster } else
768 1.3 oster if (asm_p->numStripeUnitsAccessed == 2 && asm_p->totalSectorsAccessed < layoutPtr->sectorsPerStripeUnit) {
769 1.3 oster int x = (startAddrWithinStripe % layoutPtr->sectorsPerStripeUnit);
770 1.3 oster
771 1.3 oster /* create a second pda and copy the parity map info
772 1.3 oster * into it */
773 1.3 oster RF_ASSERT(toAdjust->next == NULL);
774 1.3 oster new_pda = toAdjust->next = rf_AllocPhysDiskAddr();
775 1.3 oster *new_pda = *toAdjust; /* structure assignment */
776 1.3 oster new_pda->next = NULL;
777 1.3 oster
778 1.3 oster /* adjust the start sector & number of blocks for the
779 1.3 oster * first parity pda */
780 1.3 oster toAdjust->startSector += x;
781 1.3 oster toAdjust->raidAddress += x;
782 1.3 oster toAdjust->numSector = rf_RaidAddressOfNextStripeUnitBoundary(layoutPtr, startAddrWithinStripe) - startAddrWithinStripe;
783 1.3 oster RF_ASSERT(toAdjust->numSector != 0);
784 1.3 oster
785 1.3 oster /* adjust the second pda */
786 1.3 oster new_pda->numSector = endAddress - rf_RaidAddressOfPrevStripeUnitBoundary(layoutPtr, endAddress);
787 1.3 oster /* new_pda->raidAddress =
788 1.3 oster * rf_RaidAddressOfNextStripeUnitBoundary(layoutPtr,
789 1.3 oster * toAdjust->raidAddress); */
790 1.3 oster RF_ASSERT(new_pda->numSector != 0);
791 1.3 oster }
792 1.1 oster }
793 1.11 oster
794 1.25 oster /* Check if a disk has been spared or failed. If spared, redirect the
795 1.25 oster * I/O. If it has been failed, record it in the asm pointer. Fourth
796 1.25 oster * arg is whether data or parity. */
797 1.3 oster void
798 1.3 oster rf_ASMCheckStatus(
799 1.3 oster RF_Raid_t * raidPtr,
800 1.3 oster RF_PhysDiskAddr_t * pda_p,
801 1.3 oster RF_AccessStripeMap_t * asm_p,
802 1.23 oster RF_RaidDisk_t * disks,
803 1.3 oster int parity)
804 1.3 oster {
805 1.3 oster RF_DiskStatus_t dstatus;
806 1.23 oster RF_RowCol_t fcol;
807 1.3 oster
808 1.23 oster dstatus = disks[pda_p->col].status;
809 1.3 oster
810 1.3 oster if (dstatus == rf_ds_spared) {
811 1.3 oster /* if the disk has been spared, redirect access to the spare */
812 1.3 oster fcol = pda_p->col;
813 1.23 oster pda_p->col = disks[fcol].spareCol;
814 1.3 oster } else
815 1.3 oster if (dstatus == rf_ds_dist_spared) {
816 1.3 oster /* ditto if disk has been spared to dist spare space */
817 1.15 oster #if RF_DEBUG_MAP
818 1.23 oster RF_RowCol_t oc = pda_p->col;
819 1.3 oster RF_SectorNum_t oo = pda_p->startSector;
820 1.15 oster #endif
821 1.3 oster if (pda_p->type == RF_PDA_TYPE_DATA)
822 1.23 oster raidPtr->Layout.map->MapSector(raidPtr, pda_p->raidAddress, &pda_p->col, &pda_p->startSector, RF_REMAP);
823 1.3 oster else
824 1.23 oster raidPtr->Layout.map->MapParity(raidPtr, pda_p->raidAddress, &pda_p->col, &pda_p->startSector, RF_REMAP);
825 1.3 oster
826 1.15 oster #if RF_DEBUG_MAP
827 1.3 oster if (rf_mapDebug) {
828 1.23 oster printf("Redirected c %d o %d -> c %d o %d\n", oc, (int) oo,
829 1.23 oster pda_p->col, (int) pda_p->startSector);
830 1.3 oster }
831 1.15 oster #endif
832 1.3 oster } else
833 1.3 oster if (RF_DEAD_DISK(dstatus)) {
834 1.3 oster /* if the disk is inaccessible, mark the
835 1.3 oster * failure */
836 1.3 oster if (parity)
837 1.3 oster asm_p->numParityFailed++;
838 1.3 oster else {
839 1.3 oster asm_p->numDataFailed++;
840 1.3 oster }
841 1.3 oster asm_p->failedPDAs[asm_p->numFailedPDAs] = pda_p;
842 1.3 oster asm_p->numFailedPDAs++;
843 1.1 oster #if 0
844 1.3 oster switch (asm_p->numParityFailed + asm_p->numDataFailed) {
845 1.3 oster case 1:
846 1.3 oster asm_p->failedPDAs[0] = pda_p;
847 1.3 oster break;
848 1.3 oster case 2:
849 1.3 oster asm_p->failedPDAs[1] = pda_p;
850 1.3 oster default:
851 1.3 oster break;
852 1.3 oster }
853 1.1 oster #endif
854 1.3 oster }
855 1.3 oster /* the redirected access should never span a stripe unit boundary */
856 1.3 oster RF_ASSERT(rf_RaidAddressToStripeUnitID(&raidPtr->Layout, pda_p->raidAddress) ==
857 1.3 oster rf_RaidAddressToStripeUnitID(&raidPtr->Layout, pda_p->raidAddress + pda_p->numSector - 1));
858 1.3 oster RF_ASSERT(pda_p->col != -1);
859 1.1 oster }
860