Home | History | Annotate | Line # | Download | only in nouveau
nouveau_pci.c revision 1.37
      1  1.37  riastrad /*	$NetBSD: nouveau_pci.c,v 1.37 2023/03/01 08:42:34 riastradh Exp $	*/
      2   1.1  riastrad 
      3   1.1  riastrad /*-
      4   1.1  riastrad  * Copyright (c) 2015 The NetBSD Foundation, Inc.
      5   1.1  riastrad  * All rights reserved.
      6   1.1  riastrad  *
      7   1.1  riastrad  * This code is derived from software contributed to The NetBSD Foundation
      8   1.1  riastrad  * by Taylor R. Campbell.
      9   1.1  riastrad  *
     10   1.1  riastrad  * Redistribution and use in source and binary forms, with or without
     11   1.1  riastrad  * modification, are permitted provided that the following conditions
     12   1.1  riastrad  * are met:
     13   1.1  riastrad  * 1. Redistributions of source code must retain the above copyright
     14   1.1  riastrad  *    notice, this list of conditions and the following disclaimer.
     15   1.1  riastrad  * 2. Redistributions in binary form must reproduce the above copyright
     16   1.1  riastrad  *    notice, this list of conditions and the following disclaimer in the
     17   1.1  riastrad  *    documentation and/or other materials provided with the distribution.
     18   1.1  riastrad  *
     19   1.1  riastrad  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     20   1.1  riastrad  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     21   1.1  riastrad  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     22   1.1  riastrad  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     23   1.1  riastrad  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     24   1.1  riastrad  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     25   1.1  riastrad  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     26   1.1  riastrad  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     27   1.1  riastrad  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     28   1.1  riastrad  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     29   1.1  riastrad  * POSSIBILITY OF SUCH DAMAGE.
     30   1.1  riastrad  */
     31   1.1  riastrad 
     32   1.1  riastrad #include <sys/cdefs.h>
     33  1.37  riastrad __KERNEL_RCSID(0, "$NetBSD: nouveau_pci.c,v 1.37 2023/03/01 08:42:34 riastradh Exp $");
     34  1.26  jmcneill 
     35  1.26  jmcneill #ifdef _KERNEL_OPT
     36  1.37  riastrad #include "genfb.h"
     37  1.26  jmcneill #if defined(__arm__) || defined(__aarch64__)
     38  1.26  jmcneill #include "opt_fdt.h"
     39  1.26  jmcneill #endif
     40  1.26  jmcneill #endif
     41   1.1  riastrad 
     42   1.1  riastrad #include <sys/types.h>
     43  1.34  riastrad #include <sys/atomic.h>
     44   1.1  riastrad #include <sys/device.h>
     45   1.1  riastrad #include <sys/queue.h>
     46   1.1  riastrad #include <sys/workqueue.h>
     47   1.4  jmcneill #include <sys/module.h>
     48   1.1  riastrad 
     49  1.26  jmcneill #ifdef FDT
     50  1.26  jmcneill #include <dev/fdt/fdtvar.h>
     51  1.26  jmcneill #endif
     52  1.26  jmcneill 
     53  1.37  riastrad #if NGENFB > 0
     54  1.37  riastrad #include <dev/wscons/wsdisplayvar.h>
     55  1.37  riastrad #include <dev/wsfb/genfbvar.h>
     56  1.37  riastrad #endif
     57  1.37  riastrad 
     58  1.29  riastrad #include <drm/drm_pci.h>
     59  1.29  riastrad 
     60  1.29  riastrad #include <core/device.h>
     61  1.29  riastrad #include <core/pci.h>
     62  1.29  riastrad 
     63  1.27  riastrad #include "nouveau_drv.h"
     64   1.1  riastrad #include "nouveau_pci.h"
     65   1.1  riastrad 
     66  1.28  riastrad struct drm_device;
     67  1.28  riastrad 
     68   1.4  jmcneill MODULE(MODULE_CLASS_DRIVER, nouveau_pci, "nouveau,drmkms_pci");
     69   1.1  riastrad 
     70   1.4  jmcneill SIMPLEQ_HEAD(nouveau_pci_task_head, nouveau_pci_task);
     71   1.4  jmcneill 
     72   1.4  jmcneill struct nouveau_pci_softc {
     73   1.1  riastrad 	device_t		sc_dev;
     74  1.24       wiz 	struct pci_attach_args	sc_pa;
     75  1.34  riastrad 	struct lwp		*sc_task_thread;
     76  1.34  riastrad 	struct nouveau_pci_task_head sc_tasks;
     77  1.34  riastrad 	struct workqueue	*sc_task_wq;
     78   1.1  riastrad 	struct drm_device	*sc_drm_dev;
     79   1.1  riastrad 	struct pci_dev		sc_pci_dev;
     80  1.12  riastrad 	struct nvkm_device	*sc_nv_dev;
     81  1.30  riastrad 	bool			sc_pci_attached;
     82  1.34  riastrad 	bool			sc_nvdev_inited;
     83  1.30  riastrad 	bool			sc_dev_registered;
     84   1.1  riastrad };
     85   1.1  riastrad 
     86   1.4  jmcneill static int	nouveau_pci_match(device_t, cfdata_t, void *);
     87   1.4  jmcneill static void	nouveau_pci_attach(device_t, device_t, void *);
     88  1.24       wiz static void	nouveau_pci_attach_real(device_t);
     89   1.4  jmcneill static int	nouveau_pci_detach(device_t, int);
     90   1.1  riastrad 
     91   1.4  jmcneill static bool	nouveau_pci_suspend(device_t, const pmf_qual_t *);
     92   1.4  jmcneill static bool	nouveau_pci_resume(device_t, const pmf_qual_t *);
     93   1.1  riastrad 
     94   1.4  jmcneill static void	nouveau_pci_task_work(struct work *, void *);
     95   1.1  riastrad 
     96   1.4  jmcneill CFATTACH_DECL_NEW(nouveau_pci, sizeof(struct nouveau_pci_softc),
     97   1.4  jmcneill     nouveau_pci_match, nouveau_pci_attach, nouveau_pci_detach, NULL);
     98   1.1  riastrad 
     99   1.1  riastrad /* Kludge to get this from nouveau_drm.c.  */
    100  1.14  riastrad extern struct drm_driver *const nouveau_drm_driver_pci;
    101   1.1  riastrad 
    102   1.1  riastrad static int
    103   1.4  jmcneill nouveau_pci_match(device_t parent, cfdata_t match, void *aux)
    104   1.1  riastrad {
    105   1.1  riastrad 	const struct pci_attach_args *const pa = aux;
    106  1.19  riastrad 	struct pci_dev pdev;
    107  1.19  riastrad 	struct nvkm_device *device;
    108  1.19  riastrad 	int ret;
    109   1.1  riastrad 
    110   1.1  riastrad 	if (PCI_VENDOR(pa->pa_id) != PCI_VENDOR_NVIDIA &&
    111   1.1  riastrad 	    PCI_VENDOR(pa->pa_id) != PCI_VENDOR_NVIDIA_SGS)
    112   1.1  riastrad 		return 0;
    113   1.1  riastrad 
    114   1.1  riastrad 	if (PCI_CLASS(pa->pa_class) != PCI_CLASS_DISPLAY)
    115   1.1  riastrad 		return 0;
    116   1.1  riastrad 
    117  1.10       mrg 	/*
    118  1.35  riastrad 	 * NetBSD drm2/5.6 doesn't support Ampere (GTX 30 series) based cards:
    119  1.35  riastrad 	 *   0x2080-0x20ff 	GA100
    120  1.35  riastrad 	 *   0x2200-0x227f 	GA102
    121  1.35  riastrad 	 *   0x2300-0x237f 	GA103
    122  1.35  riastrad 	 *   0x2480-0x24ff 	GA104
    123  1.35  riastrad 	 *   0x2500-0x257f 	GA106
    124  1.35  riastrad 	 *   0x2580-0x25ff 	GA107
    125  1.25       mrg 	 *
    126  1.35  riastrad 	 * TU116 (GTX 16xx) occupies the space from 0x2180-0x21ff.
    127  1.10       mrg 	 */
    128  1.35  riastrad 	if (PCI_PRODUCT(pa->pa_id) >= 0x1fff && PCI_PRODUCT(pa->pa_id) < 0x2180)
    129  1.35  riastrad 		return 0;
    130  1.35  riastrad 	if (PCI_PRODUCT(pa->pa_id) >= 0x21ff)
    131  1.10       mrg 		return 0;
    132  1.10       mrg 
    133  1.20  riastrad 	linux_pci_dev_init(&pdev, parent /* XXX bogus */, parent, pa, 0);
    134  1.20  riastrad 	ret = nvkm_device_pci_new(&pdev, NULL, "error",
    135  1.20  riastrad 	    /* detect */ true, /* mmio */ false, /* subdev_mask */ 0, &device);
    136  1.19  riastrad 	if (ret == 0)		/* don't want to hang onto it */
    137  1.19  riastrad 		nvkm_device_del(&device);
    138  1.19  riastrad 	linux_pci_dev_destroy(&pdev);
    139  1.19  riastrad 	if (ret)		/* failure */
    140  1.19  riastrad 		return 0;
    141  1.19  riastrad 
    142   1.1  riastrad 	return 6;		/* XXX Beat genfb_pci...  */
    143   1.1  riastrad }
    144   1.1  riastrad 
    145   1.3  riastrad extern char *nouveau_config;
    146   1.3  riastrad extern char *nouveau_debug;
    147   1.3  riastrad 
    148   1.1  riastrad static void
    149   1.4  jmcneill nouveau_pci_attach(device_t parent, device_t self, void *aux)
    150   1.1  riastrad {
    151   1.4  jmcneill 	struct nouveau_pci_softc *const sc = device_private(self);
    152   1.1  riastrad 	const struct pci_attach_args *const pa = aux;
    153  1.34  riastrad 	int error;
    154   1.1  riastrad 
    155   1.1  riastrad 	pci_aprint_devinfo(pa, NULL);
    156   1.1  riastrad 
    157  1.34  riastrad 	/* Initialize the Linux PCI device descriptor.  */
    158  1.34  riastrad 	linux_pci_dev_init(&sc->sc_pci_dev, self, device_parent(self), pa, 0);
    159  1.24       wiz 
    160  1.34  riastrad 	sc->sc_dev = self;
    161  1.24       wiz 	sc->sc_pa = *pa;
    162  1.34  riastrad 	sc->sc_task_thread = NULL;
    163  1.34  riastrad 	SIMPLEQ_INIT(&sc->sc_tasks);
    164  1.34  riastrad 	error = workqueue_create(&sc->sc_task_wq, "nouveau_pci",
    165  1.34  riastrad 	    &nouveau_pci_task_work, NULL, PRI_NONE, IPL_NONE, WQ_MPSAFE);
    166  1.34  riastrad 	if (error) {
    167  1.34  riastrad 		aprint_error_dev(self, "unable to create workqueue: %d\n",
    168  1.34  riastrad 		    error);
    169  1.34  riastrad 		sc->sc_task_wq = NULL;
    170  1.34  riastrad 		return;
    171  1.34  riastrad 	}
    172   1.1  riastrad 
    173  1.26  jmcneill #ifdef FDT
    174  1.26  jmcneill 	/*
    175  1.26  jmcneill 	 * XXX Remove the simple framebuffer, assuming that this device
    176  1.26  jmcneill 	 * will take over.
    177  1.26  jmcneill 	 */
    178  1.26  jmcneill 	const char *fb_compatible[] = { "simple-framebuffer", NULL };
    179  1.26  jmcneill 	fdt_remove_bycompat(fb_compatible);
    180  1.26  jmcneill #endif
    181  1.26  jmcneill 
    182  1.34  riastrad 	/*
    183  1.34  riastrad 	 * Defer the remainder of initialization until we have mounted
    184  1.34  riastrad 	 * the root file system and can load firmware images.
    185  1.34  riastrad 	 */
    186  1.24       wiz 	config_mountroot(self, &nouveau_pci_attach_real);
    187  1.24       wiz }
    188  1.16  riastrad 
    189  1.24       wiz static void
    190  1.24       wiz nouveau_pci_attach_real(device_t self)
    191  1.24       wiz {
    192  1.24       wiz 	struct nouveau_pci_softc *const sc = device_private(self);
    193  1.24       wiz 	int error;
    194   1.1  riastrad 
    195  1.34  riastrad 	/*
    196  1.34  riastrad 	 * Cause any tasks issued synchronously during attach to be
    197  1.34  riastrad 	 * processed at the end of this function.
    198  1.34  riastrad 	 */
    199  1.34  riastrad 	sc->sc_task_thread = curlwp;
    200  1.24       wiz 
    201   1.3  riastrad 	/* XXX errno Linux->NetBSD */
    202  1.12  riastrad 	error = -nvkm_device_pci_new(&sc->sc_pci_dev,
    203  1.20  riastrad 	    nouveau_config, nouveau_debug,
    204  1.20  riastrad 	    /* detect */ true, /* mmio */ true, /* subdev_mask */ ~0ULL,
    205   1.3  riastrad 	    &sc->sc_nv_dev);
    206   1.3  riastrad 	if (error) {
    207   1.3  riastrad 		aprint_error_dev(self, "unable to create nouveau device: %d\n",
    208   1.3  riastrad 		    error);
    209  1.30  riastrad 		sc->sc_nv_dev = NULL;
    210  1.34  riastrad 		goto out;
    211  1.30  riastrad 	}
    212  1.30  riastrad 
    213  1.30  riastrad 	sc->sc_drm_dev = drm_dev_alloc(nouveau_drm_driver_pci, self);
    214  1.30  riastrad 	if (IS_ERR(sc->sc_drm_dev)) {
    215  1.30  riastrad 		aprint_error_dev(self, "unable to create drm device: %ld\n",
    216  1.30  riastrad 		    PTR_ERR(sc->sc_drm_dev));
    217  1.30  riastrad 		sc->sc_drm_dev = NULL;
    218  1.34  riastrad 		goto out;
    219   1.3  riastrad 	}
    220   1.3  riastrad 
    221   1.1  riastrad 	/* XXX errno Linux->NetBSD */
    222  1.33  riastrad 	error = -drm_pci_attach(sc->sc_drm_dev, &sc->sc_pci_dev);
    223   1.1  riastrad 	if (error) {
    224   1.1  riastrad 		aprint_error_dev(self, "unable to attach drm: %d\n", error);
    225  1.34  riastrad 		goto out;
    226   1.1  riastrad 	}
    227  1.30  riastrad 	sc->sc_pci_attached = true;
    228  1.30  riastrad 
    229  1.37  riastrad #if NGENFB > 0
    230  1.37  riastrad 	/*
    231  1.37  riastrad 	 * If MD initialization has selected this as the console device
    232  1.37  riastrad 	 * with a firmware-provided framebuffer address, we may have to
    233  1.37  riastrad 	 * turn it off early, before we are ready to switch the console
    234  1.37  riastrad 	 * over -- something goes wrong if we're still writing to the
    235  1.37  riastrad 	 * firmware-provided framebuffer during nouveau initialization.
    236  1.37  riastrad 	 */
    237  1.37  riastrad     {
    238  1.37  riastrad 	bool is_console;
    239  1.37  riastrad 	if (prop_dictionary_get_bool(device_properties(self), "is_console",
    240  1.37  riastrad 		&is_console) &&
    241  1.37  riastrad 	    is_console &&
    242  1.37  riastrad 	    genfb_is_console())
    243  1.37  riastrad 		wsdisplay_predetach();
    244  1.37  riastrad     }
    245  1.37  riastrad #endif
    246  1.37  riastrad 
    247  1.30  riastrad 	/* XXX errno Linux->NetBSD */
    248  1.31  riastrad 	error = -nouveau_drm_device_init(sc->sc_drm_dev);
    249  1.31  riastrad 	if (error) {
    250  1.31  riastrad 		aprint_error_dev(self, "unable to init nouveau: %d\n", error);
    251  1.34  riastrad 		goto out;
    252  1.31  riastrad 	}
    253  1.34  riastrad 	sc->sc_nvdev_inited = true;
    254  1.31  riastrad 
    255  1.31  riastrad 	/* XXX errno Linux->NetBSD */
    256  1.30  riastrad 	error = -drm_dev_register(sc->sc_drm_dev, 0);
    257  1.30  riastrad 	if (error) {
    258  1.30  riastrad 		aprint_error_dev(self, "unable to register drm: %d\n", error);
    259  1.34  riastrad 		goto out;
    260  1.30  riastrad 	}
    261  1.30  riastrad 	sc->sc_dev_registered = true;
    262   1.1  riastrad 
    263  1.34  riastrad 	if (!pmf_device_register(self, &nouveau_pci_suspend,
    264  1.34  riastrad 		&nouveau_pci_resume))
    265  1.34  riastrad 		aprint_error_dev(self, "unable to establish power handler\n");
    266  1.34  riastrad 
    267  1.34  riastrad 	while (!SIMPLEQ_EMPTY(&sc->sc_tasks)) {
    268   1.4  jmcneill 		struct nouveau_pci_task *const task =
    269  1.34  riastrad 		    SIMPLEQ_FIRST(&sc->sc_tasks);
    270   1.1  riastrad 
    271  1.34  riastrad 		SIMPLEQ_REMOVE_HEAD(&sc->sc_tasks, nt_u.queue);
    272   1.1  riastrad 		(*task->nt_fn)(task);
    273   1.1  riastrad 	}
    274   1.1  riastrad 
    275  1.34  riastrad out:	/* Cause any subesquent tasks to be processed by the workqueue.  */
    276  1.34  riastrad 	atomic_store_relaxed(&sc->sc_task_thread, NULL);
    277   1.1  riastrad }
    278   1.1  riastrad 
    279   1.1  riastrad static int
    280   1.4  jmcneill nouveau_pci_detach(device_t self, int flags)
    281   1.1  riastrad {
    282   1.4  jmcneill 	struct nouveau_pci_softc *const sc = device_private(self);
    283   1.1  riastrad 	int error;
    284   1.1  riastrad 
    285   1.1  riastrad 	/* XXX Check for in-use before tearing it all down...  */
    286   1.1  riastrad 	error = config_detach_children(self, flags);
    287   1.1  riastrad 	if (error)
    288   1.1  riastrad 		return error;
    289   1.1  riastrad 
    290  1.34  riastrad 	pmf_device_deregister(self);
    291  1.34  riastrad 	if (sc->sc_dev_registered)
    292  1.34  riastrad 		drm_dev_unregister(sc->sc_drm_dev);
    293  1.34  riastrad 	if (sc->sc_nvdev_inited)
    294  1.34  riastrad 		nouveau_drm_device_fini(sc->sc_drm_dev);
    295  1.34  riastrad 	if (sc->sc_pci_attached)
    296  1.34  riastrad 		drm_pci_detach(sc->sc_drm_dev);
    297  1.34  riastrad 	if (sc->sc_drm_dev) {
    298  1.34  riastrad 		drm_dev_put(sc->sc_drm_dev);
    299  1.34  riastrad 		sc->sc_drm_dev = NULL;
    300   1.1  riastrad 	}
    301  1.34  riastrad 	if (sc->sc_nv_dev)
    302  1.34  riastrad 		nvkm_device_del(&sc->sc_nv_dev);
    303  1.34  riastrad 	if (sc->sc_task_wq) {
    304  1.34  riastrad 		workqueue_destroy(sc->sc_task_wq);
    305  1.34  riastrad 		sc->sc_task_wq = NULL;
    306  1.34  riastrad 	}
    307  1.34  riastrad 	linux_pci_dev_destroy(&sc->sc_pci_dev);
    308   1.1  riastrad 
    309   1.1  riastrad 	return 0;
    310   1.1  riastrad }
    311   1.1  riastrad 
    312   1.1  riastrad /*
    313   1.1  riastrad  * XXX Synchronize with nouveau_do_suspend in nouveau_drm.c.
    314   1.1  riastrad  */
    315   1.1  riastrad static bool
    316   1.4  jmcneill nouveau_pci_suspend(device_t self, const pmf_qual_t *qual __unused)
    317   1.1  riastrad {
    318   1.7  riastrad 	struct nouveau_pci_softc *const sc = device_private(self);
    319   1.1  riastrad 
    320   1.7  riastrad 	return nouveau_pmops_suspend(sc->sc_drm_dev) == 0;
    321   1.1  riastrad }
    322   1.1  riastrad 
    323   1.1  riastrad static bool
    324   1.4  jmcneill nouveau_pci_resume(device_t self, const pmf_qual_t *qual)
    325   1.1  riastrad {
    326   1.7  riastrad 	struct nouveau_pci_softc *const sc = device_private(self);
    327   1.1  riastrad 
    328   1.7  riastrad 	return nouveau_pmops_resume(sc->sc_drm_dev) == 0;
    329   1.1  riastrad }
    330   1.1  riastrad 
    331   1.1  riastrad static void
    332   1.4  jmcneill nouveau_pci_task_work(struct work *work, void *cookie __unused)
    333   1.1  riastrad {
    334   1.4  jmcneill 	struct nouveau_pci_task *const task = container_of(work,
    335   1.4  jmcneill 	    struct nouveau_pci_task, nt_u.work);
    336   1.1  riastrad 
    337   1.1  riastrad 	(*task->nt_fn)(task);
    338   1.1  riastrad }
    339   1.1  riastrad 
    340  1.36  riastrad void
    341   1.4  jmcneill nouveau_pci_task_schedule(device_t self, struct nouveau_pci_task *task)
    342   1.1  riastrad {
    343   1.4  jmcneill 	struct nouveau_pci_softc *const sc = device_private(self);
    344   1.1  riastrad 
    345  1.34  riastrad 	if (atomic_load_relaxed(&sc->sc_task_thread) == curlwp)
    346  1.34  riastrad 		SIMPLEQ_INSERT_TAIL(&sc->sc_tasks, task, nt_u.queue);
    347  1.34  riastrad 	else
    348  1.34  riastrad 		workqueue_enqueue(sc->sc_task_wq, &task->nt_u.work, NULL);
    349   1.1  riastrad }
    350   1.4  jmcneill 
    351  1.21  riastrad extern struct drm_driver *const nouveau_drm_driver_stub; /* XXX */
    352  1.21  riastrad extern struct drm_driver *const nouveau_drm_driver_pci;	 /* XXX */
    353  1.21  riastrad 
    354   1.4  jmcneill static int
    355   1.4  jmcneill nouveau_pci_modcmd(modcmd_t cmd, void *arg __unused)
    356   1.4  jmcneill {
    357   1.4  jmcneill 
    358   1.4  jmcneill 	switch (cmd) {
    359   1.4  jmcneill 	case MODULE_CMD_INIT:
    360  1.21  riastrad 		*nouveau_drm_driver_pci = *nouveau_drm_driver_stub;
    361  1.21  riastrad 		nouveau_drm_driver_pci->request_irq = drm_pci_request_irq;
    362  1.21  riastrad 		nouveau_drm_driver_pci->free_irq = drm_pci_free_irq;
    363   1.4  jmcneill #if 0		/* XXX nouveau acpi */
    364   1.4  jmcneill 		nouveau_register_dsm_handler();
    365   1.4  jmcneill #endif
    366   1.4  jmcneill 		break;
    367   1.4  jmcneill 	case MODULE_CMD_FINI:
    368   1.4  jmcneill #if 0		/* XXX nouveau acpi */
    369   1.4  jmcneill 		nouveau_unregister_dsm_handler();
    370   1.4  jmcneill #endif
    371   1.4  jmcneill 		break;
    372   1.4  jmcneill 	default:
    373   1.4  jmcneill 		return ENOTTY;
    374   1.4  jmcneill 	}
    375   1.4  jmcneill 
    376   1.4  jmcneill 	return 0;
    377   1.4  jmcneill }
    378