Home | History | Annotate | Line # | Download | only in kern
subr_cprng.c revision 1.28
      1 /*	$NetBSD: subr_cprng.c,v 1.28 2017/10/25 08:12:39 maya Exp $ */
      2 
      3 /*-
      4  * Copyright (c) 2011-2013 The NetBSD Foundation, Inc.
      5  * All rights reserved.
      6  *
      7  * This code is derived from software contributed to The NetBSD Foundation
      8  * by Thor Lancelot Simon and Taylor R. Campbell.
      9  *
     10  * Redistribution and use in source and binary forms, with or without
     11  * modification, are permitted provided that the following conditions
     12  * are met:
     13  * 1. Redistributions of source code must retain the above copyright
     14  *    notice, this list of conditions and the following disclaimer.
     15  * 2. Redistributions in binary form must reproduce the above copyright
     16  *    notice, this list of conditions and the following disclaimer in the
     17  *    documentation and/or other materials provided with the distribution.
     18  *
     19  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     20  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     21  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     22  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     23  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     24  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     25  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     26  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     27  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     28  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     29  * POSSIBILITY OF SUCH DAMAGE.
     30  */
     31 
     32 #include <sys/cdefs.h>
     33 __KERNEL_RCSID(0, "$NetBSD: subr_cprng.c,v 1.28 2017/10/25 08:12:39 maya Exp $");
     34 
     35 #include <sys/param.h>
     36 #include <sys/types.h>
     37 #include <sys/condvar.h>
     38 #include <sys/cprng.h>
     39 #include <sys/errno.h>
     40 #include <sys/event.h>		/* XXX struct knote */
     41 #include <sys/fcntl.h>		/* XXX FNONBLOCK */
     42 #include <sys/kernel.h>
     43 #include <sys/kmem.h>
     44 #include <sys/lwp.h>
     45 #include <sys/once.h>
     46 #include <sys/percpu.h>
     47 #include <sys/poll.h>		/* XXX POLLIN/POLLOUT/&c. */
     48 #include <sys/select.h>
     49 #include <sys/systm.h>
     50 #include <sys/sysctl.h>
     51 #include <sys/rndsink.h>
     52 #if DIAGNOSTIC
     53 #include <sys/rngtest.h>
     54 #endif
     55 
     56 #include <crypto/nist_ctr_drbg/nist_ctr_drbg.h>
     57 
     58 #if defined(__HAVE_CPU_COUNTER)
     59 #include <machine/cpu_counter.h>
     60 #endif
     61 
     62 static int sysctl_kern_urnd(SYSCTLFN_PROTO);
     63 static int sysctl_kern_arnd(SYSCTLFN_PROTO);
     64 
     65 static void	cprng_strong_generate(struct cprng_strong *, void *, size_t);
     66 static void	cprng_strong_reseed(struct cprng_strong *);
     67 static void	cprng_strong_reseed_from(struct cprng_strong *, const void *,
     68 		    size_t, bool);
     69 #if DIAGNOSTIC
     70 static void	cprng_strong_rngtest(struct cprng_strong *);
     71 #endif
     72 
     73 static rndsink_callback_t	cprng_strong_rndsink_callback;
     74 
     75 void
     76 cprng_init(void)
     77 {
     78 	static struct sysctllog *random_sysctllog;
     79 
     80 	nist_ctr_initialize();
     81 
     82 	sysctl_createv(&random_sysctllog, 0, NULL, NULL,
     83 		       CTLFLAG_PERMANENT,
     84 		       CTLTYPE_INT, "urandom",
     85 		       SYSCTL_DESCR("Random integer value"),
     86 		       sysctl_kern_urnd, 0, NULL, 0,
     87 		       CTL_KERN, KERN_URND, CTL_EOL);
     88 	sysctl_createv(&random_sysctllog, 0, NULL, NULL,
     89 		       CTLFLAG_PERMANENT,
     90 		       CTLTYPE_INT, "arandom",
     91 		       SYSCTL_DESCR("n bytes of random data"),
     92 		       sysctl_kern_arnd, 0, NULL, 0,
     93 		       CTL_KERN, KERN_ARND, CTL_EOL);
     94 }
     95 
     96 static inline uint32_t
     97 cprng_counter(void)
     98 {
     99 	struct timeval tv;
    100 
    101 #if defined(__HAVE_CPU_COUNTER)
    102 	if (cpu_hascounter())
    103 		return cpu_counter32();
    104 #endif
    105 	if (__predict_false(cold)) {
    106 		static int ctr;
    107 		/* microtime unsafe if clock not running yet */
    108 		return ctr++;
    109 	}
    110 	getmicrotime(&tv);
    111 	return (tv.tv_sec * 1000000 + tv.tv_usec);
    112 }
    113 
    114 struct cprng_strong {
    115 	char		cs_name[16];
    116 	int		cs_flags;
    117 	kmutex_t	cs_lock;
    118 	percpu_t	*cs_percpu;
    119 	kcondvar_t	cs_cv;
    120 	struct selinfo	cs_selq;
    121 	struct rndsink	*cs_rndsink;
    122 	bool		cs_ready;
    123 	NIST_CTR_DRBG	cs_drbg;
    124 
    125 	/* XXX Kludge for /dev/random `information-theoretic' properties.   */
    126 	unsigned int	cs_remaining;
    127 };
    128 
    129 struct cprng_strong *
    130 cprng_strong_create(const char *name, int ipl, int flags)
    131 {
    132 	const uint32_t cc = cprng_counter();
    133 	struct cprng_strong *const cprng = kmem_alloc(sizeof(*cprng),
    134 	    KM_SLEEP);
    135 
    136 	/*
    137 	 * rndsink_request takes a spin lock at IPL_VM, so we can be no
    138 	 * higher than that.
    139 	 */
    140 	KASSERT(ipl != IPL_SCHED && ipl != IPL_HIGH);
    141 
    142 	/* Initialize the easy fields.  */
    143 	(void)strlcpy(cprng->cs_name, name, sizeof(cprng->cs_name));
    144 	cprng->cs_flags = flags;
    145 	mutex_init(&cprng->cs_lock, MUTEX_DEFAULT, ipl);
    146 	cv_init(&cprng->cs_cv, cprng->cs_name);
    147 	selinit(&cprng->cs_selq);
    148 	cprng->cs_rndsink = rndsink_create(NIST_BLOCK_KEYLEN_BYTES,
    149 	    &cprng_strong_rndsink_callback, cprng);
    150 
    151 	/* Get some initial entropy.  Record whether it is full entropy.  */
    152 	uint8_t seed[NIST_BLOCK_KEYLEN_BYTES];
    153 	mutex_enter(&cprng->cs_lock);
    154 	cprng->cs_ready = rndsink_request(cprng->cs_rndsink, seed,
    155 	    sizeof(seed));
    156 	if (nist_ctr_drbg_instantiate(&cprng->cs_drbg, seed, sizeof(seed),
    157 		&cc, sizeof(cc), cprng->cs_name, sizeof(cprng->cs_name)))
    158 		/* XXX Fix nist_ctr_drbg API so this can't happen.  */
    159 		panic("cprng %s: NIST CTR_DRBG instantiation failed",
    160 		    cprng->cs_name);
    161 	explicit_memset(seed, 0, sizeof(seed));
    162 
    163 	if (ISSET(flags, CPRNG_HARD))
    164 		cprng->cs_remaining = NIST_BLOCK_KEYLEN_BYTES;
    165 	else
    166 		cprng->cs_remaining = 0;
    167 
    168 	if (!cprng->cs_ready && !ISSET(flags, CPRNG_INIT_ANY))
    169 		printf("cprng %s: creating with partial entropy\n",
    170 		    cprng->cs_name);
    171 	mutex_exit(&cprng->cs_lock);
    172 
    173 	return cprng;
    174 }
    175 
    176 void
    177 cprng_strong_destroy(struct cprng_strong *cprng)
    178 {
    179 
    180 	/*
    181 	 * Destroy the rndsink first to prevent calls to the callback.
    182 	 */
    183 	rndsink_destroy(cprng->cs_rndsink);
    184 
    185 	KASSERT(!cv_has_waiters(&cprng->cs_cv));
    186 #if 0
    187 	KASSERT(!select_has_waiters(&cprng->cs_selq)) /* XXX ? */
    188 #endif
    189 
    190 	nist_ctr_drbg_destroy(&cprng->cs_drbg);
    191 	seldestroy(&cprng->cs_selq);
    192 	cv_destroy(&cprng->cs_cv);
    193 	mutex_destroy(&cprng->cs_lock);
    194 
    195 	explicit_memset(cprng, 0, sizeof(*cprng)); /* paranoia */
    196 	kmem_free(cprng, sizeof(*cprng));
    197 }
    198 
    199 /*
    200  * Generate some data from cprng.  Block or return zero bytes,
    201  * depending on flags & FNONBLOCK, if cprng was created without
    202  * CPRNG_REKEY_ANY.
    203  */
    204 size_t
    205 cprng_strong(struct cprng_strong *cprng, void *buffer, size_t bytes, int flags)
    206 {
    207 	size_t result;
    208 
    209 	/* Caller must loop for more than CPRNG_MAX_LEN bytes.  */
    210 	bytes = MIN(bytes, CPRNG_MAX_LEN);
    211 
    212 	mutex_enter(&cprng->cs_lock);
    213 
    214 	if (ISSET(cprng->cs_flags, CPRNG_REKEY_ANY)) {
    215 		if (!cprng->cs_ready)
    216 			cprng_strong_reseed(cprng);
    217 	} else {
    218 		while (!cprng->cs_ready) {
    219 			if (ISSET(flags, FNONBLOCK) ||
    220 			    !ISSET(cprng->cs_flags, CPRNG_USE_CV) ||
    221 			    cv_wait_sig(&cprng->cs_cv, &cprng->cs_lock)) {
    222 				result = 0;
    223 				goto out;
    224 			}
    225 		}
    226 	}
    227 
    228 	/*
    229 	 * Debit the entropy if requested.
    230 	 *
    231 	 * XXX Kludge for /dev/random `information-theoretic' properties.
    232 	 */
    233 	if (__predict_false(ISSET(cprng->cs_flags, CPRNG_HARD))) {
    234 		KASSERT(0 < cprng->cs_remaining);
    235 		KASSERT(cprng->cs_remaining <= NIST_BLOCK_KEYLEN_BYTES);
    236 		if (bytes < cprng->cs_remaining) {
    237 			cprng->cs_remaining -= bytes;
    238 		} else {
    239 			bytes = cprng->cs_remaining;
    240 			cprng->cs_remaining = NIST_BLOCK_KEYLEN_BYTES;
    241 			cprng->cs_ready = false;
    242 			rndsink_schedule(cprng->cs_rndsink);
    243 		}
    244 		KASSERT(bytes <= NIST_BLOCK_KEYLEN_BYTES);
    245 		KASSERT(0 < cprng->cs_remaining);
    246 		KASSERT(cprng->cs_remaining <= NIST_BLOCK_KEYLEN_BYTES);
    247 	}
    248 
    249 	cprng_strong_generate(cprng, buffer, bytes);
    250 	result = bytes;
    251 
    252 out:	mutex_exit(&cprng->cs_lock);
    253 	return result;
    254 }
    255 
    256 static void	filt_cprng_detach(struct knote *);
    257 static int	filt_cprng_event(struct knote *, long);
    258 
    259 static const struct filterops cprng_filtops = {
    260 	.f_isfd = 1,
    261 	.f_attach = NULL,
    262 	.f_detach = filt_cprng_detach,
    263 	.f_event = filt_cprng_event,
    264 };
    265 
    266 int
    267 cprng_strong_kqfilter(struct cprng_strong *cprng, struct knote *kn)
    268 {
    269 
    270 	switch (kn->kn_filter) {
    271 	case EVFILT_READ:
    272 		kn->kn_fop = &cprng_filtops;
    273 		kn->kn_hook = cprng;
    274 		mutex_enter(&cprng->cs_lock);
    275 		SLIST_INSERT_HEAD(&cprng->cs_selq.sel_klist, kn, kn_selnext);
    276 		mutex_exit(&cprng->cs_lock);
    277 		return 0;
    278 
    279 	case EVFILT_WRITE:
    280 	default:
    281 		return EINVAL;
    282 	}
    283 }
    284 
    285 static void
    286 filt_cprng_detach(struct knote *kn)
    287 {
    288 	struct cprng_strong *const cprng = kn->kn_hook;
    289 
    290 	mutex_enter(&cprng->cs_lock);
    291 	SLIST_REMOVE(&cprng->cs_selq.sel_klist, kn, knote, kn_selnext);
    292 	mutex_exit(&cprng->cs_lock);
    293 }
    294 
    295 static int
    296 filt_cprng_event(struct knote *kn, long hint)
    297 {
    298 	struct cprng_strong *const cprng = kn->kn_hook;
    299 	int ret;
    300 
    301 	if (hint == NOTE_SUBMIT)
    302 		KASSERT(mutex_owned(&cprng->cs_lock));
    303 	else
    304 		mutex_enter(&cprng->cs_lock);
    305 	if (cprng->cs_ready) {
    306 		kn->kn_data = CPRNG_MAX_LEN; /* XXX Too large?  */
    307 		ret = 1;
    308 	} else {
    309 		ret = 0;
    310 	}
    311 	if (hint == NOTE_SUBMIT)
    312 		KASSERT(mutex_owned(&cprng->cs_lock));
    313 	else
    314 		mutex_exit(&cprng->cs_lock);
    315 
    316 	return ret;
    317 }
    318 
    319 int
    320 cprng_strong_poll(struct cprng_strong *cprng, int events)
    321 {
    322 	int revents;
    323 
    324 	if (!ISSET(events, (POLLIN | POLLRDNORM)))
    325 		return 0;
    326 
    327 	mutex_enter(&cprng->cs_lock);
    328 	if (cprng->cs_ready) {
    329 		revents = (events & (POLLIN | POLLRDNORM));
    330 	} else {
    331 		selrecord(curlwp, &cprng->cs_selq);
    332 		revents = 0;
    333 	}
    334 	mutex_exit(&cprng->cs_lock);
    335 
    336 	return revents;
    337 }
    338 
    339 /*
    340  * XXX Move nist_ctr_drbg_reseed_advised_p and
    341  * nist_ctr_drbg_reseed_needed_p into the nist_ctr_drbg API and make
    342  * the NIST_CTR_DRBG structure opaque.
    343  */
    344 static bool
    345 nist_ctr_drbg_reseed_advised_p(NIST_CTR_DRBG *drbg)
    346 {
    347 
    348 	return (drbg->reseed_counter > (NIST_CTR_DRBG_RESEED_INTERVAL / 2));
    349 }
    350 
    351 static bool
    352 nist_ctr_drbg_reseed_needed_p(NIST_CTR_DRBG *drbg)
    353 {
    354 
    355 	return (drbg->reseed_counter >= NIST_CTR_DRBG_RESEED_INTERVAL);
    356 }
    357 
    358 /*
    359  * Generate some data from the underlying generator.
    360  */
    361 static void
    362 cprng_strong_generate(struct cprng_strong *cprng, void *buffer, size_t bytes)
    363 {
    364 	const uint32_t cc = cprng_counter();
    365 
    366 	KASSERT(bytes <= CPRNG_MAX_LEN);
    367 	KASSERT(mutex_owned(&cprng->cs_lock));
    368 
    369 	/*
    370 	 * Generate some data from the NIST CTR_DRBG.  Caller
    371 	 * guarantees reseed if we're not ready, and if we exhaust the
    372 	 * generator, we mark ourselves not ready.  Consequently, this
    373 	 * call to the CTR_DRBG should not fail.
    374 	 */
    375 	if (__predict_false(nist_ctr_drbg_generate(&cprng->cs_drbg, buffer,
    376 		    bytes, &cc, sizeof(cc))))
    377 		panic("cprng %s: NIST CTR_DRBG failed", cprng->cs_name);
    378 
    379 	/*
    380 	 * If we've been seeing a lot of use, ask for some fresh
    381 	 * entropy soon.
    382 	 */
    383 	if (__predict_false(nist_ctr_drbg_reseed_advised_p(&cprng->cs_drbg)))
    384 		rndsink_schedule(cprng->cs_rndsink);
    385 
    386 	/*
    387 	 * If we just exhausted the generator, inform the next user
    388 	 * that we need a reseed.
    389 	 */
    390 	if (__predict_false(nist_ctr_drbg_reseed_needed_p(&cprng->cs_drbg))) {
    391 		cprng->cs_ready = false;
    392 		rndsink_schedule(cprng->cs_rndsink); /* paranoia */
    393 	}
    394 }
    395 
    396 /*
    397  * Reseed with whatever we can get from the system entropy pool right now.
    398  */
    399 static void
    400 cprng_strong_reseed(struct cprng_strong *cprng)
    401 {
    402 	uint8_t seed[NIST_BLOCK_KEYLEN_BYTES];
    403 
    404 	KASSERT(mutex_owned(&cprng->cs_lock));
    405 
    406 	const bool full_entropy = rndsink_request(cprng->cs_rndsink, seed,
    407 	    sizeof(seed));
    408 	cprng_strong_reseed_from(cprng, seed, sizeof(seed), full_entropy);
    409 	explicit_memset(seed, 0, sizeof(seed));
    410 }
    411 
    412 /*
    413  * Reseed with the given seed.  If we now have full entropy, notify waiters.
    414  */
    415 static void
    416 cprng_strong_reseed_from(struct cprng_strong *cprng,
    417     const void *seed, size_t bytes, bool full_entropy)
    418 {
    419 	const uint32_t cc = cprng_counter();
    420 
    421 	KASSERT(bytes == NIST_BLOCK_KEYLEN_BYTES);
    422 	KASSERT(mutex_owned(&cprng->cs_lock));
    423 
    424 	/*
    425 	 * Notify anyone interested in the partiality of entropy in our
    426 	 * seed -- anyone waiting for full entropy, or any system
    427 	 * operators interested in knowing when the entropy pool is
    428 	 * running on fumes.
    429 	 */
    430 	if (full_entropy) {
    431 		if (!cprng->cs_ready) {
    432 			cprng->cs_ready = true;
    433 			cv_broadcast(&cprng->cs_cv);
    434 			selnotify(&cprng->cs_selq, (POLLIN | POLLRDNORM),
    435 			    NOTE_SUBMIT);
    436 		}
    437 	} else {
    438 		/*
    439 		 * XXX Is there is any harm in reseeding with partial
    440 		 * entropy when we had full entropy before?  If so,
    441 		 * remove the conditional on this message.
    442 		 */
    443 		if (!cprng->cs_ready &&
    444 		    !ISSET(cprng->cs_flags, CPRNG_REKEY_ANY))
    445 			printf("cprng %s: reseeding with partial entropy\n",
    446 			    cprng->cs_name);
    447 	}
    448 
    449 	if (nist_ctr_drbg_reseed(&cprng->cs_drbg, seed, bytes, &cc, sizeof(cc)))
    450 		/* XXX Fix nist_ctr_drbg API so this can't happen.  */
    451 		panic("cprng %s: NIST CTR_DRBG reseed failed", cprng->cs_name);
    452 
    453 #if DIAGNOSTIC
    454 	cprng_strong_rngtest(cprng);
    455 #endif
    456 }
    457 
    458 #if DIAGNOSTIC
    459 /*
    460  * Generate some output and apply a statistical RNG test to it.
    461  */
    462 static void
    463 cprng_strong_rngtest(struct cprng_strong *cprng)
    464 {
    465 
    466 	KASSERT(mutex_owned(&cprng->cs_lock));
    467 
    468 	/* XXX Switch to a pool cache instead?  */
    469 	rngtest_t *const rt = kmem_intr_alloc(sizeof(*rt), KM_NOSLEEP);
    470 	if (rt == NULL)
    471 		/* XXX Warn?  */
    472 		return;
    473 
    474 	(void)strlcpy(rt->rt_name, cprng->cs_name, sizeof(rt->rt_name));
    475 
    476 	if (nist_ctr_drbg_generate(&cprng->cs_drbg, rt->rt_b, sizeof(rt->rt_b),
    477 		NULL, 0))
    478 		panic("cprng %s: NIST CTR_DRBG failed after reseed",
    479 		    cprng->cs_name);
    480 
    481 	if (rngtest(rt)) {
    482 		printf("cprng %s: failed statistical RNG test\n",
    483 		    cprng->cs_name);
    484 		/* XXX Not clear that this does any good...  */
    485 		cprng->cs_ready = false;
    486 		rndsink_schedule(cprng->cs_rndsink);
    487 	}
    488 
    489 	explicit_memset(rt, 0, sizeof(*rt)); /* paranoia */
    490 	kmem_intr_free(rt, sizeof(*rt));
    491 }
    492 #endif
    493 
    494 /*
    495  * Feed entropy from an rndsink request into the CPRNG for which the
    496  * request was issued.
    497  */
    498 static void
    499 cprng_strong_rndsink_callback(void *context, const void *seed, size_t bytes)
    500 {
    501 	struct cprng_strong *const cprng = context;
    502 
    503 	mutex_enter(&cprng->cs_lock);
    504 	/* Assume that rndsinks provide only full-entropy output.  */
    505 	cprng_strong_reseed_from(cprng, seed, bytes, true);
    506 	mutex_exit(&cprng->cs_lock);
    507 }
    508 
    509 static cprng_strong_t *sysctl_prng;
    510 
    511 static int
    512 makeprng(void)
    513 {
    514 
    515 	/* can't create in cprng_init(), too early */
    516 	sysctl_prng = cprng_strong_create("sysctl", IPL_NONE,
    517 					  CPRNG_INIT_ANY|CPRNG_REKEY_ANY);
    518 	return 0;
    519 }
    520 
    521 /*
    522  * sysctl helper routine for kern.urandom node. Picks a random number
    523  * for you.
    524  */
    525 static int
    526 sysctl_kern_urnd(SYSCTLFN_ARGS)
    527 {
    528 	static ONCE_DECL(control);
    529 	int v, rv;
    530 
    531 	RUN_ONCE(&control, makeprng);
    532 	rv = cprng_strong(sysctl_prng, &v, sizeof(v), 0);
    533 	if (rv == sizeof(v)) {
    534 		struct sysctlnode node = *rnode;
    535 		node.sysctl_data = &v;
    536 		return (sysctl_lookup(SYSCTLFN_CALL(&node)));
    537 	}
    538 	else
    539 		return (EIO);	/*XXX*/
    540 }
    541 
    542 /*
    543  * sysctl helper routine for kern.arandom node.  Fills the supplied
    544  * structure with random data for you.
    545  *
    546  * This node was originally declared as type "int" but its implementation
    547  * in OpenBSD, whence it came, would happily return up to 8K of data if
    548  * requested.  Evidently this was used to key RC4 in userspace.
    549  *
    550  * In NetBSD, the libc stack-smash-protection code reads 64 bytes
    551  * from here at every program startup.  So though it would be nice
    552  * to make this node return only 32 or 64 bits, we can't.  Too bad!
    553  */
    554 static int
    555 sysctl_kern_arnd(SYSCTLFN_ARGS)
    556 {
    557 	int error;
    558 	void *v;
    559 	struct sysctlnode node = *rnode;
    560 
    561 	switch (*oldlenp) {
    562 	    case 0:
    563 		return 0;
    564 	    default:
    565 		if (*oldlenp > 256) {
    566 			return E2BIG;
    567 		}
    568 		v = kmem_alloc(*oldlenp, KM_SLEEP);
    569 		cprng_fast(v, *oldlenp);
    570 		node.sysctl_data = v;
    571 		node.sysctl_size = *oldlenp;
    572 		error = sysctl_lookup(SYSCTLFN_CALL(&node));
    573 		kmem_free(v, *oldlenp);
    574 		return error;
    575 	}
    576 }
    577