Home | History | Annotate | Line # | Download | only in libsockin
sockin.c revision 1.9
      1  1.9    pooka /*	$NetBSD: sockin.c,v 1.9 2009/01/26 10:43:21 pooka Exp $	*/
      2  1.1    pooka 
      3  1.1    pooka /*
      4  1.9    pooka  * Copyright (c) 2008, 2009 Antti Kantee.  All Rights Reserved.
      5  1.1    pooka  *
      6  1.1    pooka  * Redistribution and use in source and binary forms, with or without
      7  1.1    pooka  * modification, are permitted provided that the following conditions
      8  1.1    pooka  * are met:
      9  1.1    pooka  * 1. Redistributions of source code must retain the above copyright
     10  1.1    pooka  *    notice, this list of conditions and the following disclaimer.
     11  1.1    pooka  * 2. Redistributions in binary form must reproduce the above copyright
     12  1.1    pooka  *    notice, this list of conditions and the following disclaimer in the
     13  1.1    pooka  *    documentation and/or other materials provided with the distribution.
     14  1.1    pooka  *
     15  1.1    pooka  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS
     16  1.1    pooka  * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
     17  1.1    pooka  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
     18  1.1    pooka  * DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
     19  1.1    pooka  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
     20  1.1    pooka  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
     21  1.1    pooka  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
     22  1.1    pooka  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
     23  1.1    pooka  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
     24  1.1    pooka  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     25  1.1    pooka  * SUCH DAMAGE.
     26  1.1    pooka  */
     27  1.1    pooka 
     28  1.8    pooka #include <sys/cdefs.h>
     29  1.9    pooka __KERNEL_RCSID(0, "$NetBSD: sockin.c,v 1.9 2009/01/26 10:43:21 pooka Exp $");
     30  1.8    pooka 
     31  1.1    pooka #include <sys/param.h>
     32  1.1    pooka #include <sys/condvar.h>
     33  1.1    pooka #include <sys/domain.h>
     34  1.1    pooka #include <sys/kmem.h>
     35  1.1    pooka #include <sys/kthread.h>
     36  1.1    pooka #include <sys/mbuf.h>
     37  1.1    pooka #include <sys/mutex.h>
     38  1.1    pooka #include <sys/poll.h>
     39  1.1    pooka #include <sys/protosw.h>
     40  1.1    pooka #include <sys/queue.h>
     41  1.1    pooka #include <sys/socket.h>
     42  1.1    pooka #include <sys/socketvar.h>
     43  1.1    pooka #include <sys/time.h>
     44  1.1    pooka 
     45  1.6    pooka #include <net/radix.h>
     46  1.6    pooka 
     47  1.1    pooka #include <netinet/in.h>
     48  1.1    pooka #include <netinet/in_systm.h>
     49  1.1    pooka #include <netinet/ip.h>
     50  1.1    pooka 
     51  1.1    pooka #include <rump/rumpuser.h>
     52  1.1    pooka 
     53  1.9    pooka #include "rump_private.h"
     54  1.9    pooka 
     55  1.1    pooka /*
     56  1.1    pooka  * An inet communication domain which uses the socket interface.
     57  1.1    pooka  * Currently supports only IPv4 UDP, but could easily be extended to
     58  1.1    pooka  * support IPv6 and TCP by adding more stuff to the protosw.
     59  1.1    pooka  */
     60  1.1    pooka 
     61  1.1    pooka DOMAIN_DEFINE(sockindomain);
     62  1.1    pooka 
     63  1.1    pooka static void	sockin_init(void);
     64  1.1    pooka static int	sockin_usrreq(struct socket *, int, struct mbuf *,
     65  1.1    pooka 			      struct mbuf *, struct mbuf *, struct lwp *);
     66  1.7    pooka static int	sockin_ctloutput(int op, struct socket *, struct sockopt *);
     67  1.1    pooka 
     68  1.1    pooka const struct protosw sockinsw[] = {
     69  1.2    pooka {
     70  1.2    pooka 	.pr_type = SOCK_DGRAM,
     71  1.1    pooka 	.pr_domain = &sockindomain,
     72  1.1    pooka 	.pr_protocol = IPPROTO_UDP,
     73  1.1    pooka 	.pr_flags = PR_ATOMIC|PR_ADDR,
     74  1.1    pooka 	.pr_usrreq = sockin_usrreq,
     75  1.7    pooka 	.pr_ctloutput = sockin_ctloutput,
     76  1.2    pooka },
     77  1.2    pooka {
     78  1.2    pooka 	.pr_type = SOCK_STREAM,
     79  1.2    pooka 	.pr_domain = &sockindomain,
     80  1.2    pooka 	.pr_protocol = IPPROTO_TCP,
     81  1.2    pooka 	.pr_flags = PR_CONNREQUIRED|PR_WANTRCVD|PR_LISTEN|PR_ABRTACPTDIS,
     82  1.2    pooka 	.pr_usrreq = sockin_usrreq,
     83  1.7    pooka 	.pr_ctloutput = sockin_ctloutput,
     84  1.1    pooka }};
     85  1.1    pooka 
     86  1.1    pooka struct domain sockindomain = {
     87  1.1    pooka 	.dom_family = PF_INET,
     88  1.1    pooka 	.dom_name = "socket_inet",
     89  1.2    pooka 	.dom_init = sockin_init,
     90  1.1    pooka 	.dom_externalize = NULL,
     91  1.1    pooka 	.dom_dispose = NULL,
     92  1.1    pooka 	.dom_protosw = sockinsw,
     93  1.4  minskim 	.dom_protoswNPROTOSW = &sockinsw[__arraycount(sockinsw)],
     94  1.6    pooka 	.dom_rtattach = rn_inithead,
     95  1.6    pooka 	.dom_rtoffset = 32,
     96  1.6    pooka 	.dom_maxrtkey = sizeof(struct sockaddr_in),
     97  1.1    pooka 	.dom_ifattach = NULL,
     98  1.1    pooka 	.dom_ifdetach = NULL,
     99  1.1    pooka 	.dom_ifqueues = { NULL },
    100  1.1    pooka 	.dom_link = { NULL },
    101  1.1    pooka 	.dom_mowner = MOWNER_INIT("",""),
    102  1.1    pooka 	.dom_rtcache = { NULL },
    103  1.1    pooka 	.dom_sockaddr_cmp = NULL
    104  1.1    pooka };
    105  1.1    pooka 
    106  1.3    pooka #define SO2S(so) ((intptr_t)(so->so_internal))
    107  1.2    pooka #define SOCKIN_SBSIZE 65536
    108  1.1    pooka 
    109  1.5    pooka struct sockin_unit {
    110  1.5    pooka 	struct socket *su_so;
    111  1.5    pooka 
    112  1.5    pooka 	LIST_ENTRY(sockin_unit) su_entries;
    113  1.5    pooka };
    114  1.5    pooka static LIST_HEAD(, sockin_unit) su_ent = LIST_HEAD_INITIALIZER(su_ent);
    115  1.5    pooka static kmutex_t su_mtx;
    116  1.5    pooka static bool rebuild;
    117  1.5    pooka static int nsock;
    118  1.5    pooka 
    119  1.5    pooka static int
    120  1.5    pooka registersock(struct socket *so, int news)
    121  1.5    pooka {
    122  1.5    pooka 	struct sockin_unit *su;
    123  1.5    pooka 
    124  1.5    pooka 	su = kmem_alloc(sizeof(*su), KM_NOSLEEP);
    125  1.5    pooka 	if (!su)
    126  1.5    pooka 		return ENOMEM;
    127  1.5    pooka 
    128  1.5    pooka 	so->so_internal = (void *)(intptr_t)news;
    129  1.5    pooka 	su->su_so = so;
    130  1.5    pooka 
    131  1.5    pooka 	mutex_enter(&su_mtx);
    132  1.5    pooka 	LIST_INSERT_HEAD(&su_ent, su, su_entries);
    133  1.5    pooka 	nsock++;
    134  1.5    pooka 	rebuild = true;
    135  1.5    pooka 	mutex_exit(&su_mtx);
    136  1.5    pooka 
    137  1.5    pooka 	return 0;
    138  1.5    pooka }
    139  1.5    pooka 
    140  1.1    pooka static void
    141  1.1    pooka sockin_process(struct socket *so)
    142  1.1    pooka {
    143  1.1    pooka 	struct sockaddr_in from;
    144  1.1    pooka 	struct iovec io;
    145  1.1    pooka 	struct msghdr rmsg;
    146  1.1    pooka 	struct mbuf *m;
    147  1.1    pooka 	ssize_t n;
    148  1.1    pooka 	size_t plen;
    149  1.1    pooka 	int error;
    150  1.1    pooka 
    151  1.1    pooka 	plen = IP_MAXPACKET;
    152  1.1    pooka 	m = m_gethdr(M_WAIT, MT_DATA);
    153  1.1    pooka 	MEXTMALLOC(m, plen, M_WAIT);
    154  1.1    pooka 
    155  1.1    pooka 	memset(&rmsg, 0, sizeof(rmsg));
    156  1.1    pooka 	io.iov_base = mtod(m, void *);
    157  1.1    pooka 	io.iov_len = plen;
    158  1.1    pooka 	rmsg.msg_iov = &io;
    159  1.1    pooka 	rmsg.msg_iovlen = 1;
    160  1.1    pooka 	rmsg.msg_name = (struct sockaddr *)&from;
    161  1.1    pooka 	rmsg.msg_namelen = sizeof(from);
    162  1.1    pooka 
    163  1.1    pooka 	n = rumpuser_net_recvmsg(SO2S(so), &rmsg, 0, &error);
    164  1.1    pooka 	if (n <= 0) {
    165  1.1    pooka 		m_freem(m);
    166  1.1    pooka 		return;
    167  1.1    pooka 	}
    168  1.1    pooka 	m->m_len = m->m_pkthdr.len = n;
    169  1.1    pooka 
    170  1.2    pooka 	if (so->so_proto->pr_type == SOCK_DGRAM) {
    171  1.2    pooka 		if (!sbappendaddr(&so->so_rcv, rmsg.msg_name, m, NULL)) {
    172  1.2    pooka 			m_freem(m);
    173  1.2    pooka 		}
    174  1.2    pooka 	} else {
    175  1.2    pooka 		sbappendstream(&so->so_rcv, m);
    176  1.1    pooka 	}
    177  1.2    pooka 
    178  1.1    pooka 	sorwakeup(so);
    179  1.1    pooka }
    180  1.1    pooka 
    181  1.5    pooka static void
    182  1.5    pooka sockin_accept(struct socket *so)
    183  1.5    pooka {
    184  1.5    pooka 	struct socket *nso;
    185  1.5    pooka 	struct sockaddr_in sin;
    186  1.5    pooka 	int news, error, slen;
    187  1.5    pooka 
    188  1.5    pooka 	slen = sizeof(sin);
    189  1.5    pooka 	news = rumpuser_net_accept(SO2S(so), (struct sockaddr *)&sin,
    190  1.5    pooka 	    &slen, &error);
    191  1.5    pooka 	if (news == -1)
    192  1.5    pooka 		return;
    193  1.1    pooka 
    194  1.5    pooka 	if ((nso = sonewconn(so, SS_ISCONNECTED)) == NULL)
    195  1.5    pooka 		goto errout;
    196  1.5    pooka 	if (registersock(nso, news) != 0)
    197  1.5    pooka 		goto errout;
    198  1.5    pooka 	return;
    199  1.5    pooka 
    200  1.5    pooka  errout:
    201  1.5    pooka 	rumpuser_close(news, &error);
    202  1.5    pooka 	if (nso)
    203  1.5    pooka 		soclose(nso);
    204  1.5    pooka }
    205  1.1    pooka 
    206  1.1    pooka #define POLLTIMEOUT 100	/* check for new entries every 100ms */
    207  1.1    pooka 
    208  1.1    pooka /* XXX: doesn't handle socket (kernel) locking properly? */
    209  1.1    pooka static void
    210  1.1    pooka sockinworker(void *arg)
    211  1.1    pooka {
    212  1.1    pooka 	struct pollfd *pfds = NULL, *npfds;
    213  1.1    pooka 	struct sockin_unit *su_iter;
    214  1.5    pooka 	struct socket *so;
    215  1.1    pooka 	int cursock = 0, i, rv, error;
    216  1.1    pooka 
    217  1.1    pooka 	/*
    218  1.1    pooka 	 * Loop reading requests.  Check for new sockets periodically
    219  1.1    pooka 	 * (could be smarter, but I'm lazy).
    220  1.1    pooka 	 */
    221  1.1    pooka 	for (;;) {
    222  1.1    pooka 		if (rebuild) {
    223  1.1    pooka 			npfds = NULL;
    224  1.1    pooka 			mutex_enter(&su_mtx);
    225  1.1    pooka 			if (nsock)
    226  1.1    pooka 				npfds = kmem_alloc(nsock * sizeof(*npfds),
    227  1.1    pooka 				    KM_NOSLEEP);
    228  1.1    pooka 			if (npfds || nsock == 0) {
    229  1.1    pooka 				if (pfds)
    230  1.1    pooka 					kmem_free(pfds, cursock*sizeof(*pfds));
    231  1.1    pooka 				pfds = npfds;
    232  1.1    pooka 				cursock = nsock;
    233  1.1    pooka 				rebuild = false;
    234  1.1    pooka 
    235  1.1    pooka 				i = 0;
    236  1.1    pooka 				LIST_FOREACH(su_iter, &su_ent, su_entries) {
    237  1.1    pooka 					pfds[i].fd = SO2S(su_iter->su_so);
    238  1.1    pooka 					pfds[i].events = POLLIN;
    239  1.1    pooka 					pfds[i].revents = 0;
    240  1.1    pooka 					i++;
    241  1.1    pooka 				}
    242  1.1    pooka 				KASSERT(i == nsock);
    243  1.1    pooka 			}
    244  1.1    pooka 			mutex_exit(&su_mtx);
    245  1.1    pooka 		}
    246  1.1    pooka 
    247  1.1    pooka 		/* find affected sockets & process */
    248  1.1    pooka 		rv = rumpuser_poll(pfds, cursock, POLLTIMEOUT, &error);
    249  1.1    pooka 		for (i = 0; i < cursock && rv > 0; i++) {
    250  1.1    pooka 			if (pfds[i].revents & POLLIN) {
    251  1.1    pooka 				mutex_enter(&su_mtx);
    252  1.1    pooka 				LIST_FOREACH(su_iter, &su_ent, su_entries) {
    253  1.1    pooka 					if (SO2S(su_iter->su_so)==pfds[i].fd) {
    254  1.5    pooka 						so = su_iter->su_so;
    255  1.5    pooka 						mutex_exit(&su_mtx);
    256  1.1    pooka 						mutex_enter(softnet_lock);
    257  1.5    pooka 						if(so->so_options&SO_ACCEPTCONN)
    258  1.5    pooka 							sockin_accept(so);
    259  1.5    pooka 						else
    260  1.5    pooka 							sockin_process(so);
    261  1.1    pooka 						mutex_exit(softnet_lock);
    262  1.5    pooka 						mutex_enter(&su_mtx);
    263  1.1    pooka 						break;
    264  1.1    pooka 					}
    265  1.1    pooka 				}
    266  1.1    pooka 				/* if we can't find it, just wing it */
    267  1.1    pooka 				KASSERT(rebuild || su_iter);
    268  1.1    pooka 				mutex_exit(&su_mtx);
    269  1.1    pooka 				pfds[i].revents = 0;
    270  1.1    pooka 				rv--;
    271  1.1    pooka 				i = -1;
    272  1.1    pooka 				continue;
    273  1.1    pooka 			}
    274  1.1    pooka 
    275  1.1    pooka 			/* something else?  ignore */
    276  1.1    pooka 			if (pfds[i].revents) {
    277  1.1    pooka 				pfds[i].revents = 0;
    278  1.1    pooka 				rv--;
    279  1.1    pooka 			}
    280  1.1    pooka 		}
    281  1.1    pooka 		KASSERT(rv <= 0);
    282  1.1    pooka 	}
    283  1.1    pooka 
    284  1.1    pooka }
    285  1.1    pooka 
    286  1.1    pooka static void
    287  1.1    pooka sockin_init()
    288  1.1    pooka {
    289  1.1    pooka 	int rv;
    290  1.1    pooka 
    291  1.9    pooka 	if (rump_threads) {
    292  1.9    pooka 		if ((rv = kthread_create(PRI_NONE, 0, NULL, sockinworker,
    293  1.9    pooka 		    NULL, NULL, "sockwork")) != 0)
    294  1.9    pooka 			panic("sockin_init: could not create worker thread\n");
    295  1.9    pooka 	} else {
    296  1.9    pooka 		printf("sockin_init: no threads => no worker thread\n");
    297  1.9    pooka 	}
    298  1.1    pooka 	mutex_init(&su_mtx, MUTEX_DEFAULT, IPL_NONE);
    299  1.1    pooka }
    300  1.1    pooka 
    301  1.1    pooka static int
    302  1.1    pooka sockin_usrreq(struct socket *so, int req, struct mbuf *m, struct mbuf *nam,
    303  1.1    pooka 	struct mbuf *control, struct lwp *l)
    304  1.1    pooka {
    305  1.2    pooka 	int error = 0, rv;
    306  1.1    pooka 
    307  1.1    pooka 	switch (req) {
    308  1.1    pooka 	case PRU_ATTACH:
    309  1.1    pooka 	{
    310  1.1    pooka 		int news;
    311  1.1    pooka 
    312  1.1    pooka 		sosetlock(so);
    313  1.2    pooka 		if (so->so_snd.sb_hiwat == 0 || so->so_rcv.sb_hiwat == 0) {
    314  1.2    pooka 			error = soreserve(so, SOCKIN_SBSIZE, SOCKIN_SBSIZE);
    315  1.2    pooka 			if (error)
    316  1.2    pooka 				break;
    317  1.2    pooka 		}
    318  1.1    pooka 
    319  1.2    pooka 		news = rumpuser_net_socket(PF_INET, so->so_proto->pr_type,
    320  1.2    pooka 		    0, &error);
    321  1.5    pooka 		if (news == -1)
    322  1.1    pooka 			break;
    323  1.1    pooka 
    324  1.5    pooka 		if ((error = registersock(so, news)) != 0)
    325  1.5    pooka 			rumpuser_close(news, &error);
    326  1.5    pooka 
    327  1.1    pooka 		break;
    328  1.1    pooka 	}
    329  1.1    pooka 
    330  1.5    pooka 	case PRU_ACCEPT:
    331  1.5    pooka 		/* we do all the work in the worker thread */
    332  1.5    pooka 		break;
    333  1.5    pooka 
    334  1.5    pooka 	case PRU_BIND:
    335  1.5    pooka 		rumpuser_net_bind(SO2S(so), mtod(nam, const struct sockaddr *),
    336  1.5    pooka 		    sizeof(struct sockaddr_in), &error);
    337  1.5    pooka 		break;
    338  1.5    pooka 
    339  1.1    pooka 	case PRU_CONNECT:
    340  1.2    pooka 		/* don't bother to connect udp sockets, always sendmsg */
    341  1.2    pooka 		if (so->so_proto->pr_type == SOCK_DGRAM)
    342  1.2    pooka 			break;
    343  1.2    pooka 
    344  1.3    pooka 		rv = rumpuser_net_connect(SO2S(so),
    345  1.2    pooka 		    mtod(nam, struct sockaddr *), sizeof(struct sockaddr_in),
    346  1.2    pooka 		    &error);
    347  1.2    pooka 		if (rv == 0)
    348  1.2    pooka 		soisconnected(so);
    349  1.1    pooka 		break;
    350  1.1    pooka 
    351  1.5    pooka 	case PRU_LISTEN:
    352  1.5    pooka 		rumpuser_net_listen(SO2S(so), so->so_qlimit, &error);
    353  1.5    pooka 		break;
    354  1.5    pooka 
    355  1.1    pooka 	case PRU_SEND:
    356  1.1    pooka 	{
    357  1.1    pooka 		struct sockaddr *saddr;
    358  1.1    pooka 		struct msghdr mhdr;
    359  1.1    pooka 		struct iovec iov[16];
    360  1.1    pooka 		struct mbuf *m2;
    361  1.1    pooka 		size_t tot;
    362  1.1    pooka 		int i, s;
    363  1.1    pooka 
    364  1.1    pooka 		memset(&mhdr, 0, sizeof(mhdr));
    365  1.1    pooka 
    366  1.1    pooka 		tot = 0;
    367  1.1    pooka 		for (i = 0, m2 = m; m2; m2 = m2->m_next, i++) {
    368  1.1    pooka 			if (i > 16)
    369  1.1    pooka 				panic("lazy bum");
    370  1.1    pooka 			iov[i].iov_base = m2->m_data;
    371  1.1    pooka 			iov[i].iov_len = m2->m_len;
    372  1.1    pooka 			tot += m2->m_len;
    373  1.1    pooka 
    374  1.1    pooka 		}
    375  1.1    pooka 		mhdr.msg_iov = iov;
    376  1.1    pooka 		mhdr.msg_iovlen = i;
    377  1.3    pooka 		s = SO2S(so);
    378  1.2    pooka 
    379  1.2    pooka 		if (so->so_proto->pr_type == SOCK_DGRAM) {
    380  1.2    pooka 			saddr = mtod(nam, struct sockaddr *);
    381  1.2    pooka 			mhdr.msg_name = saddr;
    382  1.2    pooka 			mhdr.msg_namelen = saddr->sa_len;
    383  1.2    pooka 		}
    384  1.1    pooka 
    385  1.1    pooka 		rumpuser_net_sendmsg(s, &mhdr, 0, &error);
    386  1.2    pooka 
    387  1.1    pooka 		m_freem(m);
    388  1.1    pooka 		m_freem(control);
    389  1.9    pooka 
    390  1.1    pooka 		/* this assumes too many things to list.. buthey, testing */
    391  1.9    pooka 		if (!rump_threads)
    392  1.9    pooka 			sockin_process(so);
    393  1.1    pooka 	}
    394  1.1    pooka 		break;
    395  1.1    pooka 
    396  1.1    pooka 	case PRU_SHUTDOWN:
    397  1.1    pooka 	{
    398  1.1    pooka 		struct sockin_unit *su_iter;
    399  1.1    pooka 
    400  1.1    pooka 		mutex_enter(&su_mtx);
    401  1.1    pooka 		LIST_FOREACH(su_iter, &su_ent, su_entries) {
    402  1.1    pooka 			if (su_iter->su_so == so)
    403  1.1    pooka 				break;
    404  1.1    pooka 		}
    405  1.1    pooka 		if (!su_iter)
    406  1.1    pooka 			panic("no such socket");
    407  1.1    pooka 
    408  1.1    pooka 		LIST_REMOVE(su_iter, su_entries);
    409  1.1    pooka 		nsock--;
    410  1.1    pooka 		rebuild = true;
    411  1.1    pooka 		mutex_exit(&su_mtx);
    412  1.1    pooka 
    413  1.1    pooka 		rumpuser_close(SO2S(su_iter->su_so), &error);
    414  1.1    pooka 		kmem_free(su_iter, sizeof(*su_iter));
    415  1.1    pooka 	}
    416  1.1    pooka 		break;
    417  1.1    pooka 
    418  1.1    pooka 	default:
    419  1.1    pooka 		panic("sockin_usrreq: IMPLEMENT ME, req %d not supported", req);
    420  1.1    pooka 	}
    421  1.1    pooka 
    422  1.1    pooka 	return error;
    423  1.1    pooka }
    424  1.7    pooka 
    425  1.7    pooka static int
    426  1.7    pooka sockin_ctloutput(int op, struct socket *so, struct sockopt *sopt)
    427  1.7    pooka {
    428  1.7    pooka 
    429  1.7    pooka 	/* XXX: we should also do something here */
    430  1.7    pooka 	return 0;
    431  1.7    pooka }
    432