Home | History | Annotate | Line # | Download | only in overlay
secmodel_overlay.c revision 1.12
      1  1.12   jym /* $NetBSD: secmodel_overlay.c,v 1.12 2011/12/04 19:25:00 jym Exp $ */
      2   1.1  elad /*-
      3   1.1  elad  * Copyright (c) 2006 Elad Efrat <elad (at) NetBSD.org>
      4   1.1  elad  * All rights reserved.
      5   1.1  elad  *
      6   1.1  elad  * Redistribution and use in source and binary forms, with or without
      7   1.1  elad  * modification, are permitted provided that the following conditions
      8   1.1  elad  * are met:
      9   1.1  elad  * 1. Redistributions of source code must retain the above copyright
     10   1.1  elad  *    notice, this list of conditions and the following disclaimer.
     11   1.1  elad  * 2. Redistributions in binary form must reproduce the above copyright
     12   1.1  elad  *    notice, this list of conditions and the following disclaimer in the
     13   1.1  elad  *    documentation and/or other materials provided with the distribution.
     14   1.5  elad  * 3. The name of the author may not be used to endorse or promote products
     15   1.1  elad  *    derived from this software without specific prior written permission.
     16   1.1  elad  *
     17   1.1  elad  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
     18   1.1  elad  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
     19   1.1  elad  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
     20   1.1  elad  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
     21   1.1  elad  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
     22   1.1  elad  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
     23   1.1  elad  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
     24   1.1  elad  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     25   1.1  elad  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
     26   1.1  elad  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     27   1.1  elad  */
     28   1.1  elad 
     29   1.2  elad #include <sys/cdefs.h>
     30  1.12   jym __KERNEL_RCSID(0, "$NetBSD: secmodel_overlay.c,v 1.12 2011/12/04 19:25:00 jym Exp $");
     31   1.2  elad 
     32   1.1  elad #include <sys/types.h>
     33   1.1  elad #include <sys/param.h>
     34   1.1  elad #include <sys/kauth.h>
     35  1.10  elad #include <sys/module.h>
     36   1.1  elad 
     37   1.1  elad #include <sys/sysctl.h>
     38   1.1  elad 
     39  1.12   jym #include <secmodel/secmodel.h>
     40  1.12   jym 
     41   1.1  elad #include <secmodel/overlay/overlay.h>
     42   1.1  elad #include <secmodel/bsd44/bsd44.h>
     43  1.10  elad #include <secmodel/suser/suser.h>
     44  1.10  elad #include <secmodel/securelevel/securelevel.h>
     45   1.9  elad 
     46  1.10  elad MODULE(MODULE_CLASS_SECMODEL, secmodel_overlay, "secmodel_bsd44");
     47   1.1  elad 
     48   1.1  elad /*
     49   1.1  elad  * Fall-back settings.
     50   1.1  elad  */
     51   1.1  elad #define	OVERLAY_ISCOPE_GENERIC	"org.netbsd.kauth.overlay.generic"
     52   1.1  elad #define	OVERLAY_ISCOPE_SYSTEM	"org.netbsd.kauth.overlay.system"
     53   1.1  elad #define	OVERLAY_ISCOPE_PROCESS	"org.netbsd.kauth.overlay.process"
     54   1.1  elad #define	OVERLAY_ISCOPE_NETWORK	"org.netbsd.kauth.overlay.network"
     55   1.1  elad #define	OVERLAY_ISCOPE_MACHDEP	"org.netbsd.kauth.overlay.machdep"
     56   1.4  elad #define	OVERLAY_ISCOPE_DEVICE	"org.netbsd.kauth.overlay.device"
     57  1.10  elad #define	OVERLAY_ISCOPE_VNODE	"org.netbsd.kauth.overlay.vnode"
     58   1.1  elad 
     59   1.1  elad static kauth_scope_t secmodel_overlay_iscope_generic;
     60   1.1  elad static kauth_scope_t secmodel_overlay_iscope_system;
     61   1.1  elad static kauth_scope_t secmodel_overlay_iscope_process;
     62   1.1  elad static kauth_scope_t secmodel_overlay_iscope_network;
     63   1.1  elad static kauth_scope_t secmodel_overlay_iscope_machdep;
     64   1.4  elad static kauth_scope_t secmodel_overlay_iscope_device;
     65  1.10  elad static kauth_scope_t secmodel_overlay_iscope_vnode;
     66   1.1  elad 
     67  1.10  elad static kauth_listener_t l_generic, l_system, l_process, l_network, l_machdep,
     68  1.10  elad     l_device, l_vnode;
     69  1.10  elad 
     70  1.12   jym static secmodel_t overlay_sm;
     71  1.10  elad static struct sysctllog *sysctl_overlay_log;
     72   1.1  elad 
     73   1.1  elad /*
     74   1.1  elad  * Initialize the overlay security model.
     75   1.1  elad  */
     76   1.1  elad void
     77   1.1  elad secmodel_overlay_init(void)
     78   1.1  elad {
     79   1.1  elad 	/*
     80   1.1  elad 	 * Register internal fall-back scopes.
     81   1.1  elad 	 */
     82   1.1  elad 	secmodel_overlay_iscope_generic = kauth_register_scope(
     83   1.1  elad 	    OVERLAY_ISCOPE_GENERIC, NULL, NULL);
     84   1.1  elad 	secmodel_overlay_iscope_system = kauth_register_scope(
     85   1.1  elad 	    OVERLAY_ISCOPE_SYSTEM, NULL, NULL);
     86   1.1  elad 	secmodel_overlay_iscope_process = kauth_register_scope(
     87   1.1  elad 	    OVERLAY_ISCOPE_PROCESS, NULL, NULL);
     88   1.1  elad 	secmodel_overlay_iscope_network = kauth_register_scope(
     89   1.1  elad 	    OVERLAY_ISCOPE_NETWORK, NULL, NULL);
     90   1.1  elad 	secmodel_overlay_iscope_machdep = kauth_register_scope(
     91   1.1  elad 	    OVERLAY_ISCOPE_MACHDEP, NULL, NULL);
     92   1.4  elad 	secmodel_overlay_iscope_device = kauth_register_scope(
     93   1.4  elad 	    OVERLAY_ISCOPE_DEVICE, NULL, NULL);
     94  1.10  elad 	secmodel_overlay_iscope_vnode = kauth_register_scope(
     95  1.10  elad 	    OVERLAY_ISCOPE_VNODE, NULL, NULL);
     96   1.1  elad 
     97   1.1  elad 	/*
     98  1.10  elad 	 * Register fall-back listeners, from suser and securelevel, to each
     99  1.10  elad 	 * internal scope.
    100   1.1  elad 	 */
    101   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_GENERIC,
    102  1.10  elad 	    secmodel_suser_generic_cb, NULL);
    103   1.1  elad 
    104   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_SYSTEM,
    105  1.10  elad 	    secmodel_suser_system_cb, NULL);
    106   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_SYSTEM,
    107   1.9  elad 	    secmodel_securelevel_system_cb, NULL);
    108   1.1  elad 
    109   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_PROCESS,
    110  1.10  elad 	    secmodel_suser_process_cb, NULL);
    111   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_PROCESS,
    112   1.9  elad 	    secmodel_securelevel_process_cb, NULL);
    113   1.1  elad 
    114   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_NETWORK,
    115  1.10  elad 	    secmodel_suser_network_cb, NULL);
    116   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_NETWORK,
    117   1.9  elad 	    secmodel_securelevel_network_cb, NULL);
    118   1.1  elad 
    119   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_MACHDEP,
    120  1.10  elad 	    secmodel_suser_machdep_cb, NULL);
    121   1.1  elad 	kauth_listen_scope(OVERLAY_ISCOPE_MACHDEP,
    122   1.9  elad 	    secmodel_securelevel_machdep_cb, NULL);
    123   1.1  elad 
    124   1.4  elad 	kauth_listen_scope(OVERLAY_ISCOPE_DEVICE,
    125  1.10  elad 	    secmodel_suser_device_cb, NULL);
    126   1.4  elad 	kauth_listen_scope(OVERLAY_ISCOPE_DEVICE,
    127   1.9  elad 	    secmodel_securelevel_device_cb, NULL);
    128   1.1  elad }
    129   1.1  elad 
    130  1.10  elad void
    131  1.10  elad sysctl_security_overlay_setup(struct sysctllog **clog)
    132   1.1  elad {
    133   1.1  elad 	const struct sysctlnode *rnode;
    134   1.1  elad 
    135   1.1  elad 	sysctl_createv(clog, 0, NULL, &rnode,
    136   1.1  elad 		       CTLFLAG_PERMANENT,
    137   1.1  elad 		       CTLTYPE_NODE, "security", NULL,
    138   1.1  elad 		       NULL, 0, NULL, 0,
    139   1.3  elad 		       CTL_SECURITY, CTL_EOL);
    140   1.1  elad 
    141   1.1  elad 	sysctl_createv(clog, 0, &rnode, &rnode,
    142   1.1  elad 		       CTLFLAG_PERMANENT,
    143   1.1  elad 		       CTLTYPE_NODE, "models", NULL,
    144   1.1  elad 		       NULL, 0, NULL, 0,
    145   1.1  elad 		       CTL_CREATE, CTL_EOL);
    146   1.1  elad 
    147   1.1  elad 	sysctl_createv(clog, 0, &rnode, &rnode,
    148   1.1  elad 		       CTLFLAG_PERMANENT,
    149   1.1  elad 		       CTLTYPE_NODE, "overlay",
    150  1.12   jym 		       SYSCTL_DESCR("Overlay security model on-top of bsd44"),
    151   1.1  elad 		       NULL, 0, NULL, 0,
    152   1.1  elad 		       CTL_CREATE, CTL_EOL);
    153   1.1  elad 
    154   1.1  elad 	sysctl_createv(clog, 0, &rnode, NULL,
    155   1.1  elad 		       CTLFLAG_PERMANENT,
    156   1.1  elad 		       CTLTYPE_STRING, "name", NULL,
    157  1.12   jym 		       NULL, 0, __UNCONST(SECMODEL_OVERLAY_NAME), 0,
    158   1.1  elad 		       CTL_CREATE, CTL_EOL);
    159   1.1  elad }
    160   1.1  elad 
    161   1.1  elad /*
    162   1.1  elad  * Start the overlay security model.
    163   1.1  elad  */
    164   1.1  elad void
    165   1.7  elad secmodel_overlay_start(void)
    166   1.1  elad {
    167  1.10  elad 	l_generic = kauth_listen_scope(KAUTH_SCOPE_GENERIC,
    168   1.1  elad 	    secmodel_overlay_generic_cb, NULL);
    169  1.10  elad 	l_system = kauth_listen_scope(KAUTH_SCOPE_SYSTEM,
    170   1.1  elad 	    secmodel_overlay_system_cb, NULL);
    171  1.10  elad 	l_process = kauth_listen_scope(KAUTH_SCOPE_PROCESS,
    172   1.1  elad 	    secmodel_overlay_process_cb, NULL);
    173  1.10  elad 	l_network = kauth_listen_scope(KAUTH_SCOPE_NETWORK,
    174   1.1  elad 	    secmodel_overlay_network_cb, NULL);
    175  1.10  elad 	l_machdep = kauth_listen_scope(KAUTH_SCOPE_MACHDEP,
    176   1.1  elad 	    secmodel_overlay_machdep_cb, NULL);
    177  1.10  elad 	l_device = kauth_listen_scope(KAUTH_SCOPE_DEVICE,
    178   1.4  elad 	    secmodel_overlay_device_cb, NULL);
    179  1.10  elad 	l_vnode = kauth_listen_scope(KAUTH_SCOPE_VNODE,
    180  1.10  elad 	    secmodel_overlay_vnode_cb, NULL);
    181   1.1  elad }
    182   1.1  elad 
    183  1.10  elad /*
    184  1.10  elad  * Stop the overlay security model.
    185  1.10  elad  */
    186   1.7  elad void
    187  1.10  elad secmodel_overlay_stop(void)
    188   1.7  elad {
    189  1.10  elad 	kauth_unlisten_scope(l_generic);
    190  1.10  elad 	kauth_unlisten_scope(l_system);
    191  1.10  elad 	kauth_unlisten_scope(l_process);
    192  1.10  elad 	kauth_unlisten_scope(l_network);
    193  1.10  elad 	kauth_unlisten_scope(l_machdep);
    194  1.10  elad 	kauth_unlisten_scope(l_device);
    195  1.10  elad 	kauth_unlisten_scope(l_vnode);
    196  1.10  elad }
    197  1.10  elad 
    198  1.10  elad static int
    199  1.10  elad secmodel_overlay_modcmd(modcmd_t cmd, void *arg)
    200  1.10  elad {
    201  1.10  elad 	int error = 0;
    202  1.10  elad 
    203  1.10  elad 	switch (cmd) {
    204  1.10  elad 	case MODULE_CMD_INIT:
    205  1.12   jym 		error = secmodel_register(&overlay_sm,
    206  1.12   jym 		    SECMODEL_OVERLAY_ID, SECMODEL_OVERLAY_NAME,
    207  1.12   jym 		    NULL, NULL, NULL);
    208  1.12   jym 		if (error != 0)
    209  1.12   jym 			printf("secmodel_overlay_modcmd::init: "
    210  1.12   jym 			    "secmodel_register returned %d\n", error);
    211  1.12   jym 
    212  1.10  elad 		secmodel_overlay_init();
    213  1.11   jym 		secmodel_suser_stop();
    214  1.11   jym 		secmodel_securelevel_stop();
    215  1.10  elad 		secmodel_overlay_start();
    216  1.10  elad 		sysctl_security_overlay_setup(&sysctl_overlay_log);
    217  1.10  elad 		break;
    218  1.10  elad 
    219  1.10  elad 	case MODULE_CMD_FINI:
    220  1.10  elad 		sysctl_teardown(&sysctl_overlay_log);
    221  1.10  elad 		secmodel_overlay_stop();
    222  1.12   jym 
    223  1.12   jym 		error = secmodel_deregister(overlay_sm);
    224  1.12   jym 		if (error != 0)
    225  1.12   jym 			printf("secmodel_overlay_modcmd::fini: "
    226  1.12   jym 			    "secmodel_deregister returned %d\n", error);
    227  1.10  elad 		break;
    228  1.10  elad 
    229  1.10  elad 	case MODULE_CMD_AUTOUNLOAD:
    230  1.10  elad 		error = EPERM;
    231  1.10  elad 		break;
    232  1.10  elad 
    233  1.10  elad 	default:
    234  1.10  elad 		error = ENOTTY;
    235  1.10  elad 		break;
    236  1.10  elad 	}
    237  1.10  elad 
    238  1.10  elad 	return error;
    239   1.7  elad }
    240   1.7  elad 
    241   1.1  elad /*
    242   1.1  elad  * Overlay listener for the generic scope.
    243   1.1  elad  */
    244   1.1  elad int
    245   1.1  elad secmodel_overlay_generic_cb(kauth_cred_t cred, kauth_action_t action,
    246   1.1  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    247   1.1  elad {
    248   1.1  elad 	int result;
    249   1.1  elad 
    250   1.1  elad 	result = KAUTH_RESULT_DEFER;
    251   1.1  elad 
    252   1.1  elad 	switch (action) {
    253   1.1  elad 	default:
    254   1.1  elad 		result = KAUTH_RESULT_DEFER;
    255   1.1  elad 		break;
    256   1.1  elad 	}
    257   1.1  elad 
    258   1.1  elad 	if (result == KAUTH_RESULT_DEFER) {
    259   1.1  elad 		result = kauth_authorize_action(
    260   1.1  elad 		    secmodel_overlay_iscope_generic, cred, action,
    261   1.1  elad 		    arg0, arg1, arg2, arg3);
    262   1.1  elad 	}
    263   1.1  elad 
    264   1.1  elad 	return (result);
    265   1.1  elad }
    266   1.1  elad 
    267   1.1  elad /*
    268   1.1  elad  * Overlay listener for the system scope.
    269   1.1  elad  */
    270   1.1  elad int
    271   1.1  elad secmodel_overlay_system_cb(kauth_cred_t cred, kauth_action_t action,
    272   1.1  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    273   1.1  elad {
    274   1.1  elad 	int result;
    275   1.1  elad 
    276   1.1  elad 	result = KAUTH_RESULT_DEFER;
    277   1.1  elad 
    278   1.1  elad 	switch (action) {
    279   1.1  elad 	default:
    280   1.1  elad 		result = KAUTH_RESULT_DEFER;
    281   1.1  elad 		break;
    282   1.1  elad 	}
    283   1.1  elad 
    284   1.1  elad 	if (result == KAUTH_RESULT_DEFER) {
    285   1.1  elad 		result = kauth_authorize_action(
    286   1.1  elad 		    secmodel_overlay_iscope_system, cred, action,
    287   1.1  elad 		    arg0, arg1, arg2, arg3);
    288   1.1  elad 	}
    289   1.1  elad 
    290   1.1  elad 	return (result);
    291   1.1  elad }
    292   1.1  elad 
    293   1.1  elad /*
    294   1.1  elad  * Overlay listener for the process scope.
    295   1.1  elad  */
    296   1.1  elad int
    297   1.1  elad secmodel_overlay_process_cb(kauth_cred_t cred, kauth_action_t action,
    298   1.1  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    299   1.1  elad {
    300   1.1  elad 	int result;
    301   1.1  elad 
    302   1.1  elad 	result = KAUTH_RESULT_DEFER;
    303   1.1  elad 
    304   1.1  elad 	switch (action) {
    305   1.1  elad 	default:
    306   1.1  elad 		result = KAUTH_RESULT_DEFER;
    307   1.1  elad 		break;
    308   1.1  elad 	}
    309   1.1  elad 
    310   1.1  elad 	if (result == KAUTH_RESULT_DEFER) {
    311   1.1  elad 		result = kauth_authorize_action(
    312   1.1  elad 		    secmodel_overlay_iscope_process, cred, action,
    313   1.1  elad 		    arg0, arg1, arg2, arg3);
    314   1.1  elad 	}
    315   1.1  elad 
    316   1.1  elad 	return (result);
    317   1.1  elad }
    318   1.1  elad 
    319   1.1  elad /*
    320   1.1  elad  * Overlay listener for the network scope.
    321   1.1  elad  */
    322   1.1  elad int
    323   1.1  elad secmodel_overlay_network_cb(kauth_cred_t cred, kauth_action_t action,
    324   1.1  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    325   1.1  elad {
    326   1.1  elad 	int result;
    327   1.1  elad 
    328   1.1  elad 	result = KAUTH_RESULT_DEFER;
    329   1.1  elad 
    330   1.1  elad 	switch (action) {
    331   1.1  elad 	default:
    332   1.1  elad 		result = KAUTH_RESULT_DEFER;
    333   1.1  elad 		break;
    334   1.1  elad 	}
    335   1.1  elad 
    336   1.1  elad 	if (result == KAUTH_RESULT_DEFER) {
    337   1.1  elad 		result = kauth_authorize_action(
    338   1.1  elad 		    secmodel_overlay_iscope_network, cred, action,
    339   1.1  elad 		    arg0, arg1, arg2, arg3);
    340   1.1  elad 	}
    341   1.1  elad 
    342   1.1  elad 	return (result);
    343   1.1  elad }
    344   1.1  elad 
    345   1.1  elad /*
    346   1.1  elad  * Overlay listener for the machdep scope.
    347   1.1  elad  */
    348   1.1  elad int
    349   1.1  elad secmodel_overlay_machdep_cb(kauth_cred_t cred, kauth_action_t action,
    350   1.1  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    351   1.1  elad {
    352   1.1  elad 	int result;
    353   1.1  elad 
    354   1.1  elad 	result = KAUTH_RESULT_DEFER;
    355   1.1  elad 
    356   1.1  elad 	switch (action) {
    357   1.1  elad 	default:
    358   1.1  elad 		result = KAUTH_RESULT_DEFER;
    359   1.1  elad 		break;
    360   1.1  elad 	}
    361   1.1  elad 
    362   1.1  elad 	if (result == KAUTH_RESULT_DEFER) {
    363   1.1  elad 		result = kauth_authorize_action(
    364   1.1  elad 		    secmodel_overlay_iscope_machdep, cred, action,
    365   1.1  elad 		    arg0, arg1, arg2, arg3);
    366   1.1  elad 	}
    367   1.1  elad 
    368   1.1  elad 	return (result);
    369   1.1  elad }
    370   1.4  elad 
    371   1.4  elad /*
    372   1.4  elad  * Overlay listener for the device scope.
    373   1.4  elad  */
    374   1.4  elad int
    375   1.4  elad secmodel_overlay_device_cb(kauth_cred_t cred, kauth_action_t action,
    376   1.4  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    377   1.4  elad {
    378   1.4  elad 	int result;
    379   1.4  elad 
    380   1.4  elad 	result = KAUTH_RESULT_DEFER;
    381   1.4  elad 
    382   1.4  elad 	switch (action) {
    383   1.4  elad 	default:
    384   1.4  elad 		result = KAUTH_RESULT_DEFER;
    385   1.4  elad 		break;
    386   1.4  elad 	}
    387   1.4  elad 
    388   1.4  elad 	if (result == KAUTH_RESULT_DEFER) {
    389   1.4  elad 		result = kauth_authorize_action(
    390   1.4  elad 		    secmodel_overlay_iscope_device, cred, action,
    391   1.4  elad 		    arg0, arg1, arg2, arg3);
    392   1.4  elad 	}
    393   1.4  elad 
    394   1.4  elad 	return (result);
    395   1.4  elad }
    396  1.10  elad 
    397  1.10  elad /*
    398  1.10  elad  * Overlay listener for the vnode scope.
    399  1.10  elad  */
    400  1.10  elad int
    401  1.10  elad secmodel_overlay_vnode_cb(kauth_cred_t cred, kauth_action_t action,
    402  1.10  elad     void *cookie, void *arg0, void *arg1, void *arg2, void *arg3)
    403  1.10  elad {
    404  1.10  elad 	int result;
    405  1.10  elad 
    406  1.10  elad 	result = KAUTH_RESULT_DEFER;
    407  1.10  elad 
    408  1.10  elad 	switch (action) {
    409  1.10  elad 	default:
    410  1.10  elad 		result = KAUTH_RESULT_DEFER;
    411  1.10  elad 		break;
    412  1.10  elad 	}
    413  1.10  elad 
    414  1.10  elad 	if (result == KAUTH_RESULT_DEFER) {
    415  1.10  elad 		result = kauth_authorize_action(
    416  1.10  elad 		    secmodel_overlay_iscope_vnode, cred, action,
    417  1.10  elad 		    arg0, arg1, arg2, arg3);
    418  1.10  elad 	}
    419  1.10  elad 
    420  1.10  elad 	return (result);
    421  1.10  elad }
    422