Home | History | Annotate | Line # | Download | only in lfs
lfs_rename.c revision 1.11
      1 /*	$NetBSD: lfs_rename.c,v 1.11 2015/09/15 15:00:32 dholland Exp $	*/
      2 /*  from NetBSD: ufs_rename.c,v 1.6 2013/01/22 09:39:18 dholland Exp  */
      3 
      4 /*-
      5  * Copyright (c) 2012 The NetBSD Foundation, Inc.
      6  * All rights reserved.
      7  *
      8  * This code is derived from software contributed to The NetBSD Foundation
      9  * by Taylor R Campbell.
     10  *
     11  * Redistribution and use in source and binary forms, with or without
     12  * modification, are permitted provided that the following conditions
     13  * are met:
     14  * 1. Redistributions of source code must retain the above copyright
     15  *    notice, this list of conditions and the following disclaimer.
     16  * 2. Redistributions in binary form must reproduce the above copyright
     17  *    notice, this list of conditions and the following disclaimer in the
     18  *    documentation and/or other materials provided with the distribution.
     19  *
     20  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     21  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     22  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     23  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     24  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     25  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     26  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     27  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     28  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     29  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     30  * POSSIBILITY OF SUCH DAMAGE.
     31  */
     32 /*-
     33  * Copyright (c) 1999, 2000, 2001, 2002, 2003 The NetBSD Foundation, Inc.
     34  * All rights reserved.
     35  *
     36  * This code is derived from software contributed to The NetBSD Foundation
     37  * by Konrad E. Schroder <perseant (at) hhhh.org>.
     38  *
     39  * Redistribution and use in source and binary forms, with or without
     40  * modification, are permitted provided that the following conditions
     41  * are met:
     42  * 1. Redistributions of source code must retain the above copyright
     43  *    notice, this list of conditions and the following disclaimer.
     44  * 2. Redistributions in binary form must reproduce the above copyright
     45  *    notice, this list of conditions and the following disclaimer in the
     46  *    documentation and/or other materials provided with the distribution.
     47  *
     48  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     49  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     50  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     51  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     52  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     53  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     54  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     55  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     56  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     57  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     58  * POSSIBILITY OF SUCH DAMAGE.
     59  */
     60 /*
     61  * Copyright (c) 1986, 1989, 1991, 1993, 1995
     62  *	The Regents of the University of California.  All rights reserved.
     63  *
     64  * Redistribution and use in source and binary forms, with or without
     65  * modification, are permitted provided that the following conditions
     66  * are met:
     67  * 1. Redistributions of source code must retain the above copyright
     68  *    notice, this list of conditions and the following disclaimer.
     69  * 2. Redistributions in binary form must reproduce the above copyright
     70  *    notice, this list of conditions and the following disclaimer in the
     71  *    documentation and/or other materials provided with the distribution.
     72  * 3. Neither the name of the University nor the names of its contributors
     73  *    may be used to endorse or promote products derived from this software
     74  *    without specific prior written permission.
     75  *
     76  * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
     77  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
     78  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
     79  * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
     80  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
     81  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
     82  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
     83  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
     84  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
     85  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     86  * SUCH DAMAGE.
     87  *
     88  *	@(#)lfs_vnops.c	8.13 (Berkeley) 6/10/95
     89  */
     90 
     91 #include <sys/cdefs.h>
     92 __KERNEL_RCSID(0, "$NetBSD: lfs_rename.c,v 1.11 2015/09/15 15:00:32 dholland Exp $");
     93 
     94 #include <sys/param.h>
     95 #include <sys/systm.h>
     96 #include <sys/errno.h>
     97 #include <sys/namei.h>
     98 #include <sys/resourcevar.h>
     99 #include <sys/kernel.h>
    100 #include <sys/file.h>
    101 #include <sys/stat.h>
    102 #include <sys/buf.h>
    103 #include <sys/proc.h>
    104 #include <sys/mount.h>
    105 #include <sys/vnode.h>
    106 #include <sys/vnode_if.h>
    107 #include <sys/pool.h>
    108 #include <sys/signalvar.h>
    109 #include <sys/kauth.h>
    110 #include <sys/syslog.h>
    111 
    112 #include <uvm/uvm.h>
    113 #include <uvm/uvm_pmap.h>
    114 #include <uvm/uvm_stat.h>
    115 #include <uvm/uvm_pager.h>
    116 
    117 #include <miscfs/fifofs/fifo.h>
    118 #include <miscfs/genfs/genfs.h>
    119 #include <miscfs/specfs/specdev.h>
    120 
    121 #include <ufs/lfs/ulfs_inode.h>
    122 #include <ufs/lfs/ulfsmount.h>
    123 #include <ufs/lfs/ulfs_bswap.h>
    124 #include <ufs/lfs/ulfs_extern.h>
    125 
    126 #include <ufs/lfs/lfs.h>
    127 #include <ufs/lfs/lfs_accessors.h>
    128 #include <ufs/lfs/lfs_extern.h>
    129 
    130 /*
    131  * A virgin directory (no blushing please).
    132  *
    133  * XXX Copypasta from ulfs_vnops.c.  Kill!
    134  */
    135 static const struct lfs_dirtemplate mastertemplate = {
    136 	0,	12,			LFS_DT_DIR,	1,	".",
    137 	0,	LFS_DIRBLKSIZ - 12,	LFS_DT_DIR,	2,	".."
    138 };
    139 
    140 /*
    141  * ulfs_gro_directory_empty_p: Return true if the directory vp is
    142  * empty.  dvp is its parent.
    143  *
    144  * vp and dvp must be locked and referenced.
    145  */
    146 static bool
    147 ulfs_gro_directory_empty_p(struct mount *mp, kauth_cred_t cred,
    148     struct vnode *vp, struct vnode *dvp)
    149 {
    150 
    151 	(void)mp;
    152 	KASSERT(mp != NULL);
    153 	KASSERT(vp != NULL);
    154 	KASSERT(dvp != NULL);
    155 	KASSERT(vp != dvp);
    156 	KASSERT(vp->v_mount == mp);
    157 	KASSERT(dvp->v_mount == mp);
    158 	KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    159 	KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    160 
    161 	return ulfs_dirempty(VTOI(vp), VTOI(dvp)->i_number, cred);
    162 }
    163 
    164 /*
    165  * ulfs_gro_rename_check_possible: Check whether a rename is possible
    166  * independent of credentials.
    167  */
    168 static int
    169 ulfs_gro_rename_check_possible(struct mount *mp,
    170     struct vnode *fdvp, struct vnode *fvp,
    171     struct vnode *tdvp, struct vnode *tvp)
    172 {
    173 
    174 	(void)mp;
    175 	KASSERT(mp != NULL);
    176 	KASSERT(fdvp != NULL);
    177 	KASSERT(fvp != NULL);
    178 	KASSERT(tdvp != NULL);
    179 	KASSERT(fdvp != fvp);
    180 	KASSERT(fdvp != tvp);
    181 	KASSERT(tdvp != fvp);
    182 	KASSERT(tdvp != tvp);
    183 	KASSERT(fvp != tvp);
    184 	KASSERT(fdvp->v_type == VDIR);
    185 	KASSERT(tdvp->v_type == VDIR);
    186 	KASSERT(fdvp->v_mount == mp);
    187 	KASSERT(fvp->v_mount == mp);
    188 	KASSERT(tdvp->v_mount == mp);
    189 	KASSERT((tvp == NULL) || (tvp->v_mount == mp));
    190 	KASSERT(VOP_ISLOCKED(fdvp) == LK_EXCLUSIVE);
    191 	KASSERT(VOP_ISLOCKED(fvp) == LK_EXCLUSIVE);
    192 	KASSERT(VOP_ISLOCKED(tdvp) == LK_EXCLUSIVE);
    193 	KASSERT((tvp == NULL) || (VOP_ISLOCKED(tvp) == LK_EXCLUSIVE));
    194 
    195 	return genfs_ufslike_rename_check_possible(
    196 	    VTOI(fdvp)->i_flags, VTOI(fvp)->i_flags,
    197 	    VTOI(tdvp)->i_flags, (tvp? VTOI(tvp)->i_flags : 0),
    198 	    (tvp != NULL),
    199 	    IMMUTABLE, APPEND);
    200 }
    201 
    202 /*
    203  * ulfs_gro_rename_check_permitted: Check whether a rename is permitted
    204  * given our credentials.
    205  */
    206 static int
    207 ulfs_gro_rename_check_permitted(struct mount *mp, kauth_cred_t cred,
    208     struct vnode *fdvp, struct vnode *fvp,
    209     struct vnode *tdvp, struct vnode *tvp)
    210 {
    211 
    212 	(void)mp;
    213 	KASSERT(mp != NULL);
    214 	KASSERT(fdvp != NULL);
    215 	KASSERT(fvp != NULL);
    216 	KASSERT(tdvp != NULL);
    217 	KASSERT(fdvp != fvp);
    218 	KASSERT(fdvp != tvp);
    219 	KASSERT(tdvp != fvp);
    220 	KASSERT(tdvp != tvp);
    221 	KASSERT(fvp != tvp);
    222 	KASSERT(fdvp->v_type == VDIR);
    223 	KASSERT(tdvp->v_type == VDIR);
    224 	KASSERT(fdvp->v_mount == mp);
    225 	KASSERT(fvp->v_mount == mp);
    226 	KASSERT(tdvp->v_mount == mp);
    227 	KASSERT((tvp == NULL) || (tvp->v_mount == mp));
    228 	KASSERT(VOP_ISLOCKED(fdvp) == LK_EXCLUSIVE);
    229 	KASSERT(VOP_ISLOCKED(fvp) == LK_EXCLUSIVE);
    230 	KASSERT(VOP_ISLOCKED(tdvp) == LK_EXCLUSIVE);
    231 	KASSERT((tvp == NULL) || (VOP_ISLOCKED(tvp) == LK_EXCLUSIVE));
    232 
    233 	return genfs_ufslike_rename_check_permitted(cred,
    234 	    fdvp, VTOI(fdvp)->i_mode, VTOI(fdvp)->i_uid,
    235 	    fvp, VTOI(fvp)->i_uid,
    236 	    tdvp, VTOI(tdvp)->i_mode, VTOI(tdvp)->i_uid,
    237 	    tvp, (tvp? VTOI(tvp)->i_uid : 0));
    238 }
    239 
    240 /*
    241  * ulfs_gro_remove_check_possible: Check whether a remove is possible
    242  * independent of credentials.
    243  */
    244 static int
    245 ulfs_gro_remove_check_possible(struct mount *mp,
    246     struct vnode *dvp, struct vnode *vp)
    247 {
    248 
    249 	(void)mp;
    250 	KASSERT(mp != NULL);
    251 	KASSERT(dvp != NULL);
    252 	KASSERT(vp != NULL);
    253 	KASSERT(dvp != vp);
    254 	KASSERT(dvp->v_type == VDIR);
    255 	KASSERT(vp->v_type != VDIR);
    256 	KASSERT(dvp->v_mount == mp);
    257 	KASSERT(vp->v_mount == mp);
    258 	KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    259 	KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    260 
    261 	return genfs_ufslike_remove_check_possible(
    262 	    VTOI(dvp)->i_flags, VTOI(vp)->i_flags,
    263 	    IMMUTABLE, APPEND);
    264 }
    265 
    266 /*
    267  * ulfs_gro_remove_check_permitted: Check whether a remove is permitted
    268  * given our credentials.
    269  */
    270 static int
    271 ulfs_gro_remove_check_permitted(struct mount *mp, kauth_cred_t cred,
    272     struct vnode *dvp, struct vnode *vp)
    273 {
    274 
    275 	(void)mp;
    276 	KASSERT(mp != NULL);
    277 	KASSERT(dvp != NULL);
    278 	KASSERT(vp != NULL);
    279 	KASSERT(dvp != vp);
    280 	KASSERT(dvp->v_type == VDIR);
    281 	KASSERT(vp->v_type != VDIR);
    282 	KASSERT(dvp->v_mount == mp);
    283 	KASSERT(vp->v_mount == mp);
    284 	KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    285 	KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    286 
    287 	return genfs_ufslike_remove_check_permitted(cred,
    288 	    dvp, VTOI(dvp)->i_mode, VTOI(dvp)->i_uid, vp, VTOI(vp)->i_uid);
    289 }
    290 
    291 /*
    292  * ulfs_rename_ulr_overlap_p: True iff tulr overlaps with fulr so that
    293  * entering a directory entry at tulr may move fulr.
    294  */
    295 static bool
    296 ulfs_rename_ulr_overlap_p(const struct ulfs_lookup_results *fulr,
    297     const struct ulfs_lookup_results *tulr)
    298 {
    299 	doff_t from_prev_start, from_prev_end, to_start, to_end;
    300 
    301 	KASSERT(fulr != NULL);
    302 	KASSERT(tulr != NULL);
    303 	KASSERT(fulr != tulr);
    304 
    305 	/*
    306 	 * fulr is from a DELETE lookup, so fulr->ulr_count is the size
    307 	 * of the preceding entry (d_reclen).
    308 	 */
    309 	from_prev_end = fulr->ulr_offset;
    310 	KASSERT(fulr->ulr_count <= from_prev_end);
    311 	from_prev_start = (from_prev_end - fulr->ulr_count);
    312 
    313 	/*
    314 	 * tulr is from a RENAME lookup, so tulr->ulr_count is the size
    315 	 * of the free space for an entry that we are about to fill.
    316 	 */
    317 	to_start = tulr->ulr_offset;
    318 	KASSERT(tulr->ulr_count < (LFS_MAXDIRSIZE - to_start));
    319 	to_end = (to_start + tulr->ulr_count);
    320 
    321 	return
    322 	    (((to_start <= from_prev_start) && (from_prev_start < to_end)) ||
    323 		((to_start <= from_prev_end) && (from_prev_end < to_end)));
    324 }
    325 
    326 /*
    327  * ulfs_direct_namlen: Return the namlen of the directory entry ep from
    328  * the directory vp.
    329  */
    330 static int			/* XXX int?  uint8_t?  */
    331 ulfs_direct_namlen(const struct lfs_direct *ep, const struct vnode *vp)
    332 {
    333 	struct lfs *fs;
    334 
    335 	KASSERT(ep != NULL);
    336 	KASSERT(vp != NULL);
    337 	KASSERT(VTOI(vp) != NULL);
    338 	KASSERT(VTOI(vp)->i_ump != NULL);
    339 	KASSERT(VTOI(vp)->i_lfs != NULL);
    340 	fs = VTOI(vp)->i_lfs;
    341 
    342 	return lfs_dir_getnamlen(fs, ep);
    343 }
    344 
    345 /*
    346  * ulfs_rename_recalculate_fulr: If we have just entered a directory into
    347  * dvp at tulr, and we were about to remove one at fulr for an entry
    348  * named fcnp, fulr may be invalid.  So, if necessary, recalculate it.
    349  */
    350 static int
    351 ulfs_rename_recalculate_fulr(struct vnode *dvp,
    352     struct ulfs_lookup_results *fulr, const struct ulfs_lookup_results *tulr,
    353     const struct componentname *fcnp)
    354 {
    355 	struct mount *mp;
    356 	struct lfs *fs;
    357 	struct ulfsmount *ump;
    358 	/* XXX int is a silly type for this; blame ulfsmount::um_dirblksiz.  */
    359 	int dirblksiz;
    360 	doff_t search_start, search_end;
    361 	doff_t offset;		/* Offset of entry we're examining.  */
    362 	struct buf *bp;		/* I/O block we're examining.  */
    363 	char *dirbuf;		/* Pointer into directory at search_start.  */
    364 	struct lfs_direct *ep;	/* Pointer to the entry we're examining.  */
    365 	/* XXX direct::d_reclen is 16-bit;
    366 	 * ulfs_lookup_results::ulr_reclen is 32-bit.  Blah.  */
    367 	uint32_t reclen;	/* Length of the entry we're examining.  */
    368 	uint32_t prev_reclen;	/* Length of the preceding entry.  */
    369 	int error;
    370 
    371 	KASSERT(dvp != NULL);
    372 	KASSERT(dvp->v_mount != NULL);
    373 	KASSERT(VTOI(dvp) != NULL);
    374 	KASSERT(fulr != NULL);
    375 	KASSERT(tulr != NULL);
    376 	KASSERT(fulr != tulr);
    377 	KASSERT(ulfs_rename_ulr_overlap_p(fulr, tulr));
    378 
    379 	mp = dvp->v_mount;
    380 	ump = VFSTOULFS(mp);
    381 	fs = ump->um_lfs;
    382 	KASSERT(ump != NULL);
    383 	KASSERT(ump == VTOI(dvp)->i_ump);
    384 	KASSERT(fs == VTOI(dvp)->i_lfs);
    385 
    386 	dirblksiz = fs->um_dirblksiz;
    387 	KASSERT(0 < dirblksiz);
    388 	KASSERT((dirblksiz & (dirblksiz - 1)) == 0);
    389 
    390 	/* A directory block may not span across multiple I/O blocks.  */
    391 	KASSERT(dirblksiz <= mp->mnt_stat.f_iosize);
    392 
    393 	/* Find the bounds of the search.  */
    394 	search_start = tulr->ulr_offset;
    395 	KASSERT(fulr->ulr_reclen < (LFS_MAXDIRSIZE - fulr->ulr_offset));
    396 	search_end = (fulr->ulr_offset + fulr->ulr_reclen);
    397 
    398 	/* Compaction must happen only within a directory block. (*)  */
    399 	KASSERT(search_start <= search_end);
    400 	KASSERT((search_end - (search_start &~ (dirblksiz - 1))) <= dirblksiz);
    401 
    402 	dirbuf = NULL;
    403 	bp = NULL;
    404 	error = ulfs_blkatoff(dvp, (off_t)search_start, &dirbuf, &bp, false);
    405 	if (error)
    406 		return error;
    407 	KASSERT(dirbuf != NULL);
    408 	KASSERT(bp != NULL);
    409 
    410 	/*
    411 	 * Guarantee we sha'n't go past the end of the buffer we got.
    412 	 * dirbuf is bp->b_data + (search_start & (iosize - 1)), and
    413 	 * the valid range is [bp->b_data, bp->b_data + bp->b_bcount).
    414 	 */
    415 	KASSERT((search_end - search_start) <=
    416 	    (bp->b_bcount - (search_start & (mp->mnt_stat.f_iosize - 1))));
    417 
    418 	prev_reclen = fulr->ulr_count;
    419 	offset = search_start;
    420 
    421 	/*
    422 	 * Search from search_start to search_end for the entry matching
    423 	 * fcnp, which must be there because we found it before and it
    424 	 * should only at most have moved earlier.
    425 	 */
    426 	for (;;) {
    427 		KASSERT(search_start <= offset);
    428 		KASSERT(offset < search_end);
    429 
    430 		/*
    431 		 * Examine the directory entry at offset.
    432 		 */
    433 		ep = (struct lfs_direct *)(dirbuf + (offset - search_start));
    434 		reclen = lfs_dir_getreclen(fs, ep);
    435 
    436 		if (lfs_dir_getino(fs, ep) == 0)
    437 			goto next;	/* Entry is unused.  */
    438 
    439 		if (lfs_dir_getino(fs, ep) == ULFS_WINO)
    440 			goto next;	/* Entry is whiteout.  */
    441 
    442 		if (fcnp->cn_namelen != ulfs_direct_namlen(ep, dvp))
    443 			goto next;	/* Wrong name length.  */
    444 
    445 		if (memcmp(ep->d_name, fcnp->cn_nameptr, fcnp->cn_namelen))
    446 			goto next;	/* Wrong name.  */
    447 
    448 		/* Got it!  */
    449 		break;
    450 
    451 next:
    452 		if (! ((reclen < search_end) &&
    453 			(offset < (search_end - reclen)))) {
    454 			brelse(bp, 0);
    455 			return EIO;	/* XXX Panic?  What?  */
    456 		}
    457 
    458 		/* We may not move past the search end.  */
    459 		KASSERT(reclen < search_end);
    460 		KASSERT(offset < (search_end - reclen));
    461 
    462 		/*
    463 		 * We may not move across a directory block boundary;
    464 		 * see (*) above.
    465 		 */
    466 		KASSERT((offset &~ (dirblksiz - 1)) ==
    467 		    ((offset + reclen) &~ (dirblksiz - 1)));
    468 
    469 		prev_reclen = reclen;
    470 		offset += reclen;
    471 	}
    472 
    473 	/*
    474 	 * Found the entry.  Record where.
    475 	 */
    476 	fulr->ulr_offset = offset;
    477 	fulr->ulr_reclen = reclen;
    478 
    479 	/*
    480 	 * Record the preceding record length, but not if we're at the
    481 	 * start of a directory block.
    482 	 */
    483 	fulr->ulr_count = ((offset & (dirblksiz - 1))? prev_reclen : 0);
    484 
    485 	brelse(bp, 0);
    486 	return 0;
    487 }
    488 
    489 /*
    490  * ulfs_gro_remove: Rename an object over another link to itself,
    491  * effectively removing just the original link.
    492  */
    493 static int
    494 ulfs_gro_remove(struct mount *mp, kauth_cred_t cred,
    495     struct vnode *dvp, struct componentname *cnp, void *de, struct vnode *vp)
    496 {
    497 	struct ulfs_lookup_results *ulr = de;
    498 	int error;
    499 
    500 	KASSERT(mp != NULL);
    501 	KASSERT(dvp != NULL);
    502 	KASSERT(cnp != NULL);
    503 	KASSERT(ulr != NULL);
    504 	KASSERT(vp != NULL);
    505 	KASSERT(dvp != vp);
    506 	KASSERT(dvp->v_mount == mp);
    507 	KASSERT(vp->v_mount == mp);
    508 	KASSERT(dvp->v_type == VDIR);
    509 	KASSERT(vp->v_type != VDIR);
    510 	KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    511 	KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    512 	KASSERT(cnp->cn_nameiop == DELETE);
    513 
    514 	/* XXX ulfs_dirremove decrements vp's link count for us.  */
    515 	error = ulfs_dirremove(dvp, ulr, VTOI(vp), cnp->cn_flags, 0);
    516 	if (error)
    517 		goto out1;
    518 
    519 	VN_KNOTE(dvp, NOTE_WRITE);
    520 	VN_KNOTE(vp, (VTOI(vp)->i_nlink? NOTE_LINK : NOTE_DELETE));
    521 
    522 out1:
    523 	return error;
    524 }
    525 
    526 /*
    527  * ulfs_gro_lookup: Look up and save the lookup results.
    528  */
    529 static int
    530 ulfs_gro_lookup(struct mount *mp, struct vnode *dvp,
    531     struct componentname *cnp, void *de_ret, struct vnode **vp_ret)
    532 {
    533 	struct ulfs_lookup_results *ulr_ret = de_ret;
    534 	struct vnode *vp = NULL;
    535 	int error;
    536 
    537 	(void)mp;
    538 	KASSERT(mp != NULL);
    539 	KASSERT(dvp != NULL);
    540 	KASSERT(cnp != NULL);
    541 	KASSERT(ulr_ret != NULL);
    542 	KASSERT(vp_ret != NULL);
    543 	KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    544 
    545 	/* Kludge cargo-culted from dholland's ulfs_rename.  */
    546 	cnp->cn_flags &=~ MODMASK;
    547 	cnp->cn_flags |= (LOCKPARENT | LOCKLEAF);
    548 
    549 	error = relookup(dvp, &vp, cnp, 0 /* dummy */);
    550 	if ((error == 0) && (vp == NULL)) {
    551 		error = ENOENT;
    552 		goto out;
    553 	} else if (error) {
    554 		return error;
    555 	}
    556 
    557 	/*
    558 	 * Thanks to VFS insanity, relookup locks vp, which screws us
    559 	 * in various ways.
    560 	 */
    561 	KASSERT(vp != NULL);
    562 	VOP_UNLOCK(vp);
    563 
    564 out:	*ulr_ret = VTOI(dvp)->i_crap;
    565 	*vp_ret = vp;
    566 	return error;
    567 }
    568 
    569 /*
    570  * ulfs_rmdired_p: Check whether the directory vp has been rmdired.
    571  *
    572  * vp must be locked and referenced.
    573  */
    574 static bool
    575 ulfs_rmdired_p(struct vnode *vp)
    576 {
    577 
    578 	KASSERT(vp != NULL);
    579 	KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    580 	KASSERT(vp->v_type == VDIR);
    581 
    582 	/* XXX Is this correct?  */
    583 	return (VTOI(vp)->i_size == 0);
    584 }
    585 
    586 /*
    587  * ulfs_dirbuf_dotdot_namlen: Return the namlen of the directory buffer
    588  * dirbuf that came from the directory vp.  Swap byte order if
    589  * necessary.
    590  */
    591 static int			/* XXX int?  uint8_t?  */
    592 ulfs_dirbuf_dotdot_namlen(const struct lfs_dirtemplate *dirbuf,
    593     const struct vnode *vp)
    594 {
    595 	struct lfs *fs;
    596 
    597 	KASSERT(dirbuf != NULL);
    598 	KASSERT(vp != NULL);
    599 	KASSERT(VTOI(vp) != NULL);
    600 	KASSERT(VTOI(vp)->i_ump != NULL);
    601 	KASSERT(VTOI(vp)->i_lfs != NULL);
    602 	fs = VTOI(vp)->i_lfs;
    603 
    604 	return lfs_dirt_getdotdotnamlen(fs, dirbuf);
    605 }
    606 
    607 /*
    608  * ulfs_read_dotdot: Store in *ino_ret the inode number of the parent
    609  * of the directory vp.
    610  */
    611 static int
    612 ulfs_read_dotdot(struct vnode *vp, kauth_cred_t cred, ino_t *ino_ret)
    613 {
    614 	struct lfs_dirtemplate dirbuf;
    615 	int error;
    616 
    617 	KASSERT(vp != NULL);
    618 	KASSERT(ino_ret != NULL);
    619 	KASSERT(vp->v_type == VDIR);
    620 
    621 	error = ulfs_bufio(UIO_READ, vp, &dirbuf, sizeof dirbuf, (off_t)0,
    622 	    IO_NODELOCKED, cred, NULL, NULL);
    623 	if (error)
    624 		return error;
    625 
    626 	if (ulfs_dirbuf_dotdot_namlen(&dirbuf, vp) != 2 ||
    627 	    dirbuf.dotdot_name[0] != '.' ||
    628 	    dirbuf.dotdot_name[1] != '.')
    629 		/* XXX Panic?  Print warning?  */
    630 		return ENOTDIR;
    631 
    632 	*ino_ret = ulfs_rw32(dirbuf.dotdot_ino,
    633 	    ULFS_IPNEEDSWAP(VTOI(vp)));
    634 	return 0;
    635 }
    636 
    637 /*
    638  * ulfs_gro_lock_directory: Lock the directory vp, but fail if it has
    639  * been rmdir'd.
    640  */
    641 static int
    642 ulfs_gro_lock_directory(struct mount *mp, struct vnode *vp)
    643 {
    644 
    645 	(void)mp;
    646 	KASSERT(mp != NULL);
    647 	KASSERT(vp != NULL);
    648 	KASSERT(vp->v_mount == mp);
    649 
    650 	vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
    651 
    652 	if (ulfs_rmdired_p(vp)) {
    653 		VOP_UNLOCK(vp);
    654 		return ENOENT;
    655 	}
    656 
    657 	return 0;
    658 }
    659 
    660 /*
    661  * ulfs_gro_genealogy: Analyze the genealogy of the source and target
    662  * directories.
    663  */
    664 static int
    665 ulfs_gro_genealogy(struct mount *mp, kauth_cred_t cred,
    666     struct vnode *fdvp, struct vnode *tdvp,
    667     struct vnode **intermediate_node_ret)
    668 {
    669 	struct vnode *vp, *dvp;
    670 	ino_t dotdot_ino = -1;	/* XXX  gcc 4.8: maybe-uninitialized */
    671 	int error;
    672 
    673 	KASSERT(mp != NULL);
    674 	KASSERT(fdvp != NULL);
    675 	KASSERT(tdvp != NULL);
    676 	KASSERT(fdvp != tdvp);
    677 	KASSERT(intermediate_node_ret != NULL);
    678 	KASSERT(fdvp->v_mount == mp);
    679 	KASSERT(tdvp->v_mount == mp);
    680 	KASSERT(fdvp->v_type == VDIR);
    681 	KASSERT(tdvp->v_type == VDIR);
    682 
    683 	/*
    684 	 * We need to provisionally lock tdvp to keep rmdir from
    685 	 * deleting it -- or any ancestor -- at an inopportune moment.
    686 	 */
    687 	error = ulfs_gro_lock_directory(mp, tdvp);
    688 	if (error)
    689 		return error;
    690 
    691 	vp = tdvp;
    692 	vref(vp);
    693 
    694 	for (;;) {
    695 		KASSERT(vp != NULL);
    696 		KASSERT(VOP_ISLOCKED(vp) == LK_EXCLUSIVE);
    697 		KASSERT(vp->v_mount == mp);
    698 		KASSERT(vp->v_type == VDIR);
    699 		KASSERT(!ulfs_rmdired_p(vp));
    700 
    701 		/* Did we hit the root without finding fdvp?  */
    702 		if (VTOI(vp)->i_number == ULFS_ROOTINO) {
    703 			vput(vp);
    704 			*intermediate_node_ret = NULL;
    705 			return 0;
    706 		}
    707 
    708 		error = ulfs_read_dotdot(vp, cred, &dotdot_ino);
    709 		if (error) {
    710 			vput(vp);
    711 			return error;
    712 		}
    713 
    714 		/* Did we find that fdvp is an ancestor of tdvp?  */
    715 		if (VTOI(fdvp)->i_number == dotdot_ino) {
    716 			/* Unlock vp, but keep it referenced.  */
    717 			VOP_UNLOCK(vp);
    718 			*intermediate_node_ret = vp;
    719 			return 0;
    720 		}
    721 
    722 		/* Neither -- keep ascending the family tree.  */
    723 
    724 		/*
    725 		 * Unlock vp so that we can lock the parent, but keep
    726 		 * vp referenced until after we have found the parent,
    727 		 * so that dotdot_ino will not be recycled.
    728 		 *
    729 		 * XXX This guarantees that vp's inode number will not
    730 		 * be recycled, but why can't dotdot_ino be recycled?
    731 		 */
    732 		VOP_UNLOCK(vp);
    733 		error = VFS_VGET(mp, dotdot_ino, &dvp);
    734 		vrele(vp);
    735 		if (error)
    736 			return error;
    737 
    738 		KASSERT(dvp != NULL);
    739 		KASSERT(VOP_ISLOCKED(dvp) == LK_EXCLUSIVE);
    740 		vp = dvp;
    741 
    742 		if (vp->v_type != VDIR) {
    743 			/*
    744 			 * XXX Panic?  Print a warning?  Can this
    745 			 * happen if we lose the race I suspect to
    746 			 * exist above, and the `..' inode number has
    747 			 * been recycled?
    748 			 */
    749 			vput(vp);
    750 			return ENOTDIR;
    751 		}
    752 
    753 		if (ulfs_rmdired_p(vp)) {
    754 			vput(vp);
    755 			return ENOENT;
    756 		}
    757 	}
    758 }
    759 
    760 /*
    761  * ulfs_gro_rename: Actually perform the rename operation.
    762  */
    763 static int
    764 ulfs_gro_rename(struct mount *mp, kauth_cred_t cred,
    765     struct vnode *fdvp, struct componentname *fcnp,
    766     void *fde, struct vnode *fvp,
    767     struct vnode *tdvp, struct componentname *tcnp,
    768     void *tde, struct vnode *tvp)
    769 {
    770 	struct ulfs_lookup_results *fulr = fde;
    771 	struct ulfs_lookup_results *tulr = tde;
    772 	bool directory_p, reparent_p;
    773 	int error;
    774 
    775 	KASSERT(mp != NULL);
    776 	KASSERT(fdvp != NULL);
    777 	KASSERT(fcnp != NULL);
    778 	KASSERT(fulr != NULL);
    779 	KASSERT(fvp != NULL);
    780 	KASSERT(tdvp != NULL);
    781 	KASSERT(tcnp != NULL);
    782 	KASSERT(tulr != NULL);
    783 	KASSERT(fulr != tulr);
    784 	KASSERT(fdvp != fvp);
    785 	KASSERT(fdvp != tvp);
    786 	KASSERT(tdvp != fvp);
    787 	KASSERT(tdvp != tvp);
    788 	KASSERT(fvp != tvp);
    789 	KASSERT(fdvp->v_mount == mp);
    790 	KASSERT(fvp->v_mount == mp);
    791 	KASSERT(tdvp->v_mount == mp);
    792 	KASSERT((tvp == NULL) || (tvp->v_mount == mp));
    793 	KASSERT(VOP_ISLOCKED(fdvp) == LK_EXCLUSIVE);
    794 	KASSERT(VOP_ISLOCKED(fvp) == LK_EXCLUSIVE);
    795 	KASSERT(VOP_ISLOCKED(tdvp) == LK_EXCLUSIVE);
    796 	KASSERT((tvp == NULL) || (VOP_ISLOCKED(tvp) == LK_EXCLUSIVE));
    797 
    798 	/*
    799 	 * We shall need to temporarily bump the link count, so make
    800 	 * sure there is room to do so.
    801 	 */
    802 	if ((nlink_t)VTOI(fvp)->i_nlink >= LINK_MAX)
    803 		return EMLINK;
    804 
    805 	directory_p = (fvp->v_type == VDIR);
    806 	KASSERT(directory_p == ((VTOI(fvp)->i_mode & LFS_IFMT) == LFS_IFDIR));
    807 	KASSERT((tvp == NULL) || (directory_p == (tvp->v_type == VDIR)));
    808 	KASSERT((tvp == NULL) || (directory_p ==
    809 		((VTOI(tvp)->i_mode & LFS_IFMT) == LFS_IFDIR)));
    810 
    811 	reparent_p = (fdvp != tdvp);
    812 	KASSERT(reparent_p == (VTOI(fdvp)->i_number != VTOI(tdvp)->i_number));
    813 
    814 	/*
    815 	 * Commence hacking of the data on disk.
    816 	 */
    817 
    818 	error = 0;
    819 
    820 	/*
    821 	 * 1) Bump link count while we're moving stuff
    822 	 *    around.  If we crash somewhere before
    823 	 *    completing our work, the link count
    824 	 *    may be wrong, but correctable.
    825 	 */
    826 
    827 	KASSERT((nlink_t)VTOI(fvp)->i_nlink < LINK_MAX);
    828 	VTOI(fvp)->i_nlink++;
    829 	DIP_ASSIGN(VTOI(fvp), nlink, VTOI(fvp)->i_nlink);
    830 	VTOI(fvp)->i_flag |= IN_CHANGE;
    831 	error = lfs_update(fvp, NULL, NULL, UPDATE_DIROP);
    832 	if (error)
    833 		goto whymustithurtsomuch;
    834 
    835 	/*
    836 	 * 2) If target doesn't exist, link the target
    837 	 *    to the source and unlink the source.
    838 	 *    Otherwise, rewrite the target directory
    839 	 *    entry to reference the source inode and
    840 	 *    expunge the original entry's existence.
    841 	 */
    842 
    843 	if (tvp == NULL) {
    844 		/*
    845 		 * Account for ".." in new directory.
    846 		 * When source and destination have the same
    847 		 * parent we don't fool with the link count.
    848 		 */
    849 		if (directory_p && reparent_p) {
    850 			if ((nlink_t)VTOI(tdvp)->i_nlink >= LINK_MAX) {
    851 				error = EMLINK;
    852 				goto whymustithurtsomuch;
    853 			}
    854 			KASSERT((nlink_t)VTOI(tdvp)->i_nlink < LINK_MAX);
    855 			VTOI(tdvp)->i_nlink++;
    856 			DIP_ASSIGN(VTOI(tdvp), nlink, VTOI(tdvp)->i_nlink);
    857 			VTOI(tdvp)->i_flag |= IN_CHANGE;
    858 			error = lfs_update(tdvp, NULL, NULL, UPDATE_DIROP);
    859 			if (error) {
    860 				/*
    861 				 * Link count update didn't take --
    862 				 * back out the in-memory link count.
    863 				 */
    864 				KASSERT(0 < VTOI(tdvp)->i_nlink);
    865 				VTOI(tdvp)->i_nlink--;
    866 				DIP_ASSIGN(VTOI(tdvp), nlink,
    867 				    VTOI(tdvp)->i_nlink);
    868 				VTOI(tdvp)->i_flag |= IN_CHANGE;
    869 				goto whymustithurtsomuch;
    870 			}
    871 		}
    872 
    873 		error = ulfs_direnter(tdvp, tulr,
    874 		    NULL, tcnp, VTOI(fvp)->i_number, LFS_IFTODT(VTOI(fvp)->i_mode),
    875 		    NULL);
    876 		if (error) {
    877 			if (directory_p && reparent_p) {
    878 				/*
    879 				 * Directory update didn't take, but
    880 				 * the link count update did -- back
    881 				 * out the in-memory link count and the
    882 				 * on-disk link count.
    883 				 */
    884 				KASSERT(0 < VTOI(tdvp)->i_nlink);
    885 				VTOI(tdvp)->i_nlink--;
    886 				DIP_ASSIGN(VTOI(tdvp), nlink,
    887 				    VTOI(tdvp)->i_nlink);
    888 				VTOI(tdvp)->i_flag |= IN_CHANGE;
    889 				(void)lfs_update(tdvp, NULL, NULL,
    890 				    UPDATE_WAIT | UPDATE_DIROP);
    891 			}
    892 			goto whymustithurtsomuch;
    893 		}
    894 	} else {
    895 		if (directory_p)
    896 			/* XXX WTF?  Why purge here?  Why not purge others?  */
    897 			cache_purge(tdvp);
    898 
    899 		/*
    900 		 * Make the target directory's entry for tcnp point at
    901 		 * the source node.
    902 		 *
    903 		 * XXX ulfs_dirrewrite decrements tvp's link count, but
    904 		 * doesn't touch the link count of the new inode.  Go
    905 		 * figure.
    906 		 */
    907 		error = ulfs_dirrewrite(VTOI(tdvp), tulr->ulr_offset,
    908 		    VTOI(tvp), VTOI(fvp)->i_number, LFS_IFTODT(VTOI(fvp)->i_mode),
    909 		    ((directory_p && reparent_p) ? reparent_p : directory_p),
    910 		    IN_CHANGE | IN_UPDATE);
    911 		if (error)
    912 			goto whymustithurtsomuch;
    913 
    914 		/*
    915 		 * If the source and target are directories, and the
    916 		 * target is in the same directory as the source,
    917 		 * decrement the link count of the common parent
    918 		 * directory, since we are removing the target from
    919 		 * that directory.
    920 		 */
    921 		if (directory_p && !reparent_p) {
    922 			KASSERT(fdvp == tdvp);
    923 			/* XXX check, don't kassert */
    924 			KASSERT(0 < VTOI(tdvp)->i_nlink);
    925 			VTOI(tdvp)->i_nlink--;
    926 			DIP_ASSIGN(VTOI(tdvp), nlink, VTOI(tdvp)->i_nlink);
    927 			VTOI(tdvp)->i_flag |= IN_CHANGE;
    928 		}
    929 
    930 		if (directory_p) {
    931 			/*
    932 			 * XXX I don't understand the following comment
    933 			 * from ulfs_rename -- in particular, the part
    934 			 * about `there may be other hard links'.
    935 			 *
    936 			 * Truncate inode. The only stuff left in the directory
    937 			 * is "." and "..". The "." reference is inconsequential
    938 			 * since we are quashing it. We have removed the "."
    939 			 * reference and the reference in the parent directory,
    940 			 * but there may be other hard links.
    941 			 *
    942 			 * XXX The ulfs_dirempty call earlier does
    943 			 * not guarantee anything about nlink.
    944 			 */
    945 			if (VTOI(tvp)->i_nlink != 1)
    946 				ulfs_dirbad(VTOI(tvp), (doff_t)0,
    947 				    "hard-linked directory");
    948 			VTOI(tvp)->i_nlink = 0;
    949 			DIP_ASSIGN(VTOI(tvp), nlink, 0);
    950 			error = lfs_truncate(tvp, (off_t)0, IO_SYNC, cred);
    951 			if (error)
    952 				goto whymustithurtsomuch;
    953 		}
    954 	}
    955 
    956 	/*
    957 	 * If the source is a directory with a new parent, the link
    958 	 * count of the old parent directory must be decremented and
    959 	 * ".." set to point to the new parent.
    960 	 *
    961 	 * XXX ulfs_dirrewrite updates the link count of fdvp, but not
    962 	 * the link count of fvp or the link count of tdvp.  Go figure.
    963 	 */
    964 	if (directory_p && reparent_p) {
    965 		error = ulfs_dirrewrite(VTOI(fvp), mastertemplate.dot_reclen,
    966 		    VTOI(fdvp), VTOI(tdvp)->i_number, LFS_DT_DIR, 0, IN_CHANGE);
    967 #if 0		/* XXX This branch was not in ulfs_rename! */
    968 		if (error)
    969 			goto whymustithurtsomuch;
    970 #endif
    971 
    972 		/* XXX WTF?  Why purge here?  Why not purge others?  */
    973 		cache_purge(fdvp);
    974 	}
    975 
    976 	/*
    977 	 * 3) Unlink the source.
    978 	 */
    979 
    980 	/*
    981 	 * ulfs_direnter may compact the directory in the process of
    982 	 * inserting a new entry.  That may invalidate fulr, which we
    983 	 * need in order to remove the old entry.  In that case, we
    984 	 * need to recalculate what fulr should be.
    985 	 */
    986 	if (!reparent_p && (tvp == NULL) &&
    987 	    ulfs_rename_ulr_overlap_p(fulr, tulr)) {
    988 		error = ulfs_rename_recalculate_fulr(fdvp, fulr, tulr, fcnp);
    989 #if 0				/* XXX */
    990 		if (error)	/* XXX Try to back out changes?  */
    991 			goto whymustithurtsomuch;
    992 #endif
    993 	}
    994 
    995 	/*
    996 	 * XXX 0 means !isrmdir.  But can't this be an rmdir?
    997 	 * XXX Well, turns out that argument to ulfs_dirremove is ignored...
    998 	 * XXX And it turns out ulfs_dirremove updates the link count of fvp.
    999 	 * XXX But it doesn't update the link count of fdvp.  Go figure.
   1000 	 * XXX fdvp's link count is updated in ulfs_dirrewrite instead.
   1001 	 * XXX Actually, sometimes it doesn't update fvp's link count.
   1002 	 * XXX I hate the world.
   1003 	 */
   1004 	error = ulfs_dirremove(fdvp, fulr, VTOI(fvp), fcnp->cn_flags, 0);
   1005 	if (error)
   1006 #if 0				/* XXX */
   1007 		goto whymustithurtsomuch;
   1008 #endif
   1009 		goto arghmybrainhurts;
   1010 
   1011 	/*
   1012 	 * XXX Perhaps this should go at the top, in case the file
   1013 	 * system is modified but incompletely so because of an
   1014 	 * intermediate error.
   1015 	 */
   1016 	genfs_rename_knote(fdvp, fvp, tdvp, tvp,
   1017 	    ((tvp != NULL) && (VTOI(tvp)->i_nlink == 0)));
   1018 #if 0				/* XXX */
   1019 	genfs_rename_cache_purge(fdvp, fvp, tdvp, tvp);
   1020 #endif
   1021 	goto arghmybrainhurts;
   1022 
   1023 whymustithurtsomuch:
   1024 	KASSERT(0 < VTOI(fvp)->i_nlink);
   1025 	VTOI(fvp)->i_nlink--;
   1026 	DIP_ASSIGN(VTOI(fvp), nlink, VTOI(fvp)->i_nlink);
   1027 	VTOI(fvp)->i_flag |= IN_CHANGE;
   1028 
   1029 arghmybrainhurts:
   1030 /*ihateyou:*/
   1031 	return error;
   1032 }
   1033 
   1034 /*
   1035  * lfs_gro_rename: Actually perform the rename operation.  Do a little
   1036  * LFS bookkeeping and then defer to ulfs_gro_rename.
   1037  */
   1038 static int
   1039 lfs_gro_rename(struct mount *mp, kauth_cred_t cred,
   1040     struct vnode *fdvp, struct componentname *fcnp,
   1041     void *fde, struct vnode *fvp,
   1042     struct vnode *tdvp, struct componentname *tcnp,
   1043     void *tde, struct vnode *tvp)
   1044 {
   1045 	int error;
   1046 
   1047 	KASSERT(mp != NULL);
   1048 	KASSERT(fdvp != NULL);
   1049 	KASSERT(fcnp != NULL);
   1050 	KASSERT(fde != NULL);
   1051 	KASSERT(fvp != NULL);
   1052 	KASSERT(tdvp != NULL);
   1053 	KASSERT(tcnp != NULL);
   1054 	KASSERT(tde != NULL);
   1055 	KASSERT(fdvp != fvp);
   1056 	KASSERT(fdvp != tvp);
   1057 	KASSERT(tdvp != fvp);
   1058 	KASSERT(tdvp != tvp);
   1059 	KASSERT(fvp != tvp);
   1060 	KASSERT(fdvp->v_mount == mp);
   1061 	KASSERT(fvp->v_mount == mp);
   1062 	KASSERT(tdvp->v_mount == mp);
   1063 	KASSERT((tvp == NULL) || (tvp->v_mount == mp));
   1064 	KASSERT(VOP_ISLOCKED(fdvp) == LK_EXCLUSIVE);
   1065 	KASSERT(VOP_ISLOCKED(fvp) == LK_EXCLUSIVE);
   1066 	KASSERT(VOP_ISLOCKED(tdvp) == LK_EXCLUSIVE);
   1067 	KASSERT((tvp == NULL) || (VOP_ISLOCKED(tvp) == LK_EXCLUSIVE));
   1068 
   1069 	error = lfs_set_dirop(tdvp, tvp);
   1070 	if (error != 0)
   1071 		return error;
   1072 
   1073 	MARK_VNODE(fdvp);
   1074 	MARK_VNODE(fvp);
   1075 
   1076 	error = ulfs_gro_rename(mp, cred,
   1077 	    fdvp, fcnp, fde, fvp,
   1078 	    tdvp, tcnp, tde, tvp);
   1079 
   1080 	UNMARK_VNODE(fdvp);
   1081 	UNMARK_VNODE(fvp);
   1082 	UNMARK_VNODE(tdvp);
   1083 	if (tvp) {
   1084 		UNMARK_VNODE(tvp);
   1085 	}
   1086 	lfs_unset_dirop(VFSTOULFS(mp)->um_lfs, tdvp, "rename");
   1087 	vrele(tdvp);
   1088 	if (tvp) {
   1089 		vrele(tvp);
   1090 	}
   1091 
   1092 	return error;
   1093 }
   1094 
   1095 static const struct genfs_rename_ops lfs_genfs_rename_ops = {
   1096 	.gro_directory_empty_p		= ulfs_gro_directory_empty_p,
   1097 	.gro_rename_check_possible	= ulfs_gro_rename_check_possible,
   1098 	.gro_rename_check_permitted	= ulfs_gro_rename_check_permitted,
   1099 	.gro_remove_check_possible	= ulfs_gro_remove_check_possible,
   1100 	.gro_remove_check_permitted	= ulfs_gro_remove_check_permitted,
   1101 	.gro_rename			= lfs_gro_rename,
   1102 	.gro_remove			= ulfs_gro_remove,
   1103 	.gro_lookup			= ulfs_gro_lookup,
   1104 	.gro_genealogy			= ulfs_gro_genealogy,
   1105 	.gro_lock_directory		= ulfs_gro_lock_directory,
   1106 };
   1107 
   1108 /*
   1109  * lfs_sane_rename: The hairiest vop, with the saner API.
   1110  *
   1111  * Arguments:
   1112  *
   1113  * . fdvp (from directory vnode),
   1114  * . fcnp (from component name),
   1115  * . tdvp (to directory vnode),
   1116  * . tcnp (to component name),
   1117  * . cred (credentials structure), and
   1118  * . posixly_correct (flag for behaviour if target & source link same file).
   1119  *
   1120  * fdvp and tdvp may be the same, and must be referenced and unlocked.
   1121  */
   1122 static int
   1123 lfs_sane_rename(
   1124     struct vnode *fdvp, struct componentname *fcnp,
   1125     struct vnode *tdvp, struct componentname *tcnp,
   1126     kauth_cred_t cred, bool posixly_correct)
   1127 {
   1128 	struct ulfs_lookup_results fulr, tulr;
   1129 
   1130 	/*
   1131 	 * XXX Provisional kludge -- ulfs_lookup does not reject rename
   1132 	 * of . or .. (from or to), so we hack it here.  This is not
   1133 	 * the right place: it should be caller's responsibility to
   1134 	 * reject this case.
   1135 	 */
   1136 	KASSERT(fcnp != NULL);
   1137 	KASSERT(tcnp != NULL);
   1138 	KASSERT(fcnp != tcnp);
   1139 	KASSERT(fcnp->cn_nameptr != NULL);
   1140 	KASSERT(tcnp->cn_nameptr != NULL);
   1141 
   1142 	if ((fcnp->cn_flags | tcnp->cn_flags) & ISDOTDOT)
   1143 		return EINVAL;	/* XXX EISDIR?  */
   1144 	if ((fcnp->cn_namelen == 1) && (fcnp->cn_nameptr[0] == '.'))
   1145 		return EINVAL;
   1146 	if ((tcnp->cn_namelen == 1) && (tcnp->cn_nameptr[0] == '.'))
   1147 		return EINVAL;
   1148 
   1149 	return genfs_sane_rename(&lfs_genfs_rename_ops,
   1150 	    fdvp, fcnp, &fulr, tdvp, tcnp, &tulr,
   1151 	    cred, posixly_correct);
   1152 }
   1153 
   1154 /*
   1155  * lfs_rename: The hairiest vop, with the insanest API.  Defer to
   1156  * genfs_insane_rename immediately.
   1157  */
   1158 int
   1159 lfs_rename(void *v)
   1160 {
   1161 
   1162 	return genfs_insane_rename(v, &lfs_sane_rename);
   1163 }
   1164