Home | History | Annotate | Line # | Download | only in libnvmm
h_io_assist.c revision 1.1
      1  1.1  maxv /*
      2  1.1  maxv  * Copyright (c) 2018 The NetBSD Foundation, Inc.
      3  1.1  maxv  * All rights reserved.
      4  1.1  maxv  *
      5  1.1  maxv  * This code is derived from software contributed to The NetBSD Foundation
      6  1.1  maxv  * by Maxime Villard.
      7  1.1  maxv  *
      8  1.1  maxv  * Redistribution and use in source and binary forms, with or without
      9  1.1  maxv  * modification, are permitted provided that the following conditions
     10  1.1  maxv  * are met:
     11  1.1  maxv  * 1. Redistributions of source code must retain the above copyright
     12  1.1  maxv  *    notice, this list of conditions and the following disclaimer.
     13  1.1  maxv  * 2. Redistributions in binary form must reproduce the above copyright
     14  1.1  maxv  *    notice, this list of conditions and the following disclaimer in the
     15  1.1  maxv  *    documentation and/or other materials provided with the distribution.
     16  1.1  maxv  *
     17  1.1  maxv  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     18  1.1  maxv  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     19  1.1  maxv  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     20  1.1  maxv  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     21  1.1  maxv  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     22  1.1  maxv  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     23  1.1  maxv  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     24  1.1  maxv  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     25  1.1  maxv  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     26  1.1  maxv  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     27  1.1  maxv  * POSSIBILITY OF SUCH DAMAGE.
     28  1.1  maxv  */
     29  1.1  maxv 
     30  1.1  maxv #include <stdio.h>
     31  1.1  maxv #include <stdlib.h>
     32  1.1  maxv #include <stdint.h>
     33  1.1  maxv #include <stdbool.h>
     34  1.1  maxv #include <unistd.h>
     35  1.1  maxv #include <string.h>
     36  1.1  maxv #include <err.h>
     37  1.1  maxv #include <errno.h>
     38  1.1  maxv #include <sys/types.h>
     39  1.1  maxv #include <sys/mman.h>
     40  1.1  maxv #include <machine/segments.h>
     41  1.1  maxv #include <machine/psl.h>
     42  1.1  maxv #include <machine/pte.h>
     43  1.1  maxv #include <x86/specialreg.h>
     44  1.1  maxv 
     45  1.1  maxv #include <nvmm.h>
     46  1.1  maxv 
     47  1.1  maxv #define PAGE_SIZE 4096
     48  1.1  maxv #define IO_SIZE	128
     49  1.1  maxv 
     50  1.1  maxv static char iobuf[IO_SIZE];
     51  1.1  maxv 
     52  1.1  maxv static uint8_t *databuf;
     53  1.1  maxv static uint8_t *instbuf;
     54  1.1  maxv 
     55  1.1  maxv static void
     56  1.1  maxv init_seg(struct nvmm_x64_state_seg *seg, int type, int sel)
     57  1.1  maxv {
     58  1.1  maxv 	seg->selector = sel;
     59  1.1  maxv 	seg->attrib.type = type;
     60  1.1  maxv 	seg->attrib.dpl = 0;
     61  1.1  maxv 	seg->attrib.p = 1;
     62  1.1  maxv 	seg->attrib.avl = 1;
     63  1.1  maxv 	seg->attrib.lng = 1;
     64  1.1  maxv 	seg->attrib.def32 = 0;
     65  1.1  maxv 	seg->attrib.gran = 1;
     66  1.1  maxv 	seg->limit = 0x0000FFFF;
     67  1.1  maxv 	seg->base = 0x00000000;
     68  1.1  maxv }
     69  1.1  maxv 
     70  1.1  maxv static void
     71  1.1  maxv reset_machine(struct nvmm_machine *mach)
     72  1.1  maxv {
     73  1.1  maxv 	struct nvmm_x64_state state;
     74  1.1  maxv 
     75  1.1  maxv 	memset(&state, 0, sizeof(state));
     76  1.1  maxv 
     77  1.1  maxv 	/* Default. */
     78  1.1  maxv 	state.gprs[NVMM_X64_GPR_RFLAGS] = PSL_MBO;
     79  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_CS], SDT_MEMERA, GSEL(GCODE_SEL, SEL_KPL));
     80  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_SS], SDT_MEMRWA, GSEL(GDATA_SEL, SEL_KPL));
     81  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_DS], SDT_MEMRWA, GSEL(GDATA_SEL, SEL_KPL));
     82  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_ES], SDT_MEMRWA, GSEL(GDATA_SEL, SEL_KPL));
     83  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_FS], SDT_MEMRWA, GSEL(GDATA_SEL, SEL_KPL));
     84  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_GS], SDT_MEMRWA, GSEL(GDATA_SEL, SEL_KPL));
     85  1.1  maxv 
     86  1.1  maxv 	/* Blank. */
     87  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_GDT], 0, 0);
     88  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_IDT], 0, 0);
     89  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_LDT], SDT_SYSLDT, 0);
     90  1.1  maxv 	init_seg(&state.segs[NVMM_X64_SEG_TR], SDT_SYS386BSY, 0);
     91  1.1  maxv 
     92  1.1  maxv 	/* Protected mode enabled. */
     93  1.1  maxv 	state.crs[NVMM_X64_CR_CR0] = CR0_PG|CR0_PE|CR0_NE|CR0_TS|CR0_MP|CR0_WP|CR0_AM;
     94  1.1  maxv 
     95  1.1  maxv 	/* 64bit mode enabled. */
     96  1.1  maxv 	state.crs[NVMM_X64_CR_CR4] = CR4_PAE;
     97  1.1  maxv 	state.msrs[NVMM_X64_MSR_EFER] = EFER_LME | EFER_SCE | EFER_LMA;
     98  1.1  maxv 
     99  1.1  maxv 	/* Stolen from x86/pmap.c */
    100  1.1  maxv #define	PATENTRY(n, type)	(type << ((n) * 8))
    101  1.1  maxv #define	PAT_UC		0x0ULL
    102  1.1  maxv #define	PAT_WC		0x1ULL
    103  1.1  maxv #define	PAT_WT		0x4ULL
    104  1.1  maxv #define	PAT_WP		0x5ULL
    105  1.1  maxv #define	PAT_WB		0x6ULL
    106  1.1  maxv #define	PAT_UCMINUS	0x7ULL
    107  1.1  maxv 	state.msrs[NVMM_X64_MSR_PAT] =
    108  1.1  maxv 	    PATENTRY(0, PAT_WB) | PATENTRY(1, PAT_WT) |
    109  1.1  maxv 	    PATENTRY(2, PAT_UCMINUS) | PATENTRY(3, PAT_UC) |
    110  1.1  maxv 	    PATENTRY(4, PAT_WB) | PATENTRY(5, PAT_WT) |
    111  1.1  maxv 	    PATENTRY(6, PAT_UCMINUS) | PATENTRY(7, PAT_UC);
    112  1.1  maxv 
    113  1.1  maxv 	/* Page tables. */
    114  1.1  maxv 	state.crs[NVMM_X64_CR_CR3] = 0x3000;
    115  1.1  maxv 
    116  1.1  maxv 	state.gprs[NVMM_X64_GPR_RIP] = 0x2000;
    117  1.1  maxv 
    118  1.1  maxv 	if (nvmm_vcpu_setstate(mach, 0, &state, NVMM_X64_STATE_ALL) == -1)
    119  1.1  maxv 		err(errno, "nvmm_vcpu_setstate");
    120  1.1  maxv }
    121  1.1  maxv 
    122  1.1  maxv static void
    123  1.1  maxv map_pages(struct nvmm_machine *mach)
    124  1.1  maxv {
    125  1.1  maxv 	pt_entry_t *L4, *L3, *L2, *L1;
    126  1.1  maxv 
    127  1.1  maxv 	instbuf = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    128  1.1  maxv 	    -1, 0);
    129  1.1  maxv 	if (instbuf == MAP_FAILED)
    130  1.1  maxv 		err(errno, "mmap");
    131  1.1  maxv 	databuf = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    132  1.1  maxv 	    -1, 0);
    133  1.1  maxv 	if (databuf == MAP_FAILED)
    134  1.1  maxv 		err(errno, "mmap");
    135  1.1  maxv 
    136  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)instbuf, PAGE_SIZE) == -1)
    137  1.1  maxv 		err(errno, "nvmm_hva_map");
    138  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)databuf, PAGE_SIZE) == -1)
    139  1.1  maxv 		err(errno, "nvmm_hva_map");
    140  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)instbuf, 0x2000, PAGE_SIZE, 0) == -1)
    141  1.1  maxv 		err(errno, "nvmm_gpa_map");
    142  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)databuf, 0x1000, PAGE_SIZE, 0) == -1)
    143  1.1  maxv 		err(errno, "nvmm_gpa_map");
    144  1.1  maxv 
    145  1.1  maxv 	L4 = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    146  1.1  maxv 	    -1, 0);
    147  1.1  maxv 	if (L4 == MAP_FAILED)
    148  1.1  maxv 		err(errno, "mmap");
    149  1.1  maxv 	L3 = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    150  1.1  maxv 	    -1, 0);
    151  1.1  maxv 	if (L3 == MAP_FAILED)
    152  1.1  maxv 		err(errno, "mmap");
    153  1.1  maxv 	L2 = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    154  1.1  maxv 	    -1, 0);
    155  1.1  maxv 	if (L2 == MAP_FAILED)
    156  1.1  maxv 		err(errno, "mmap");
    157  1.1  maxv 	L1 = mmap(NULL, PAGE_SIZE, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE,
    158  1.1  maxv 	    -1, 0);
    159  1.1  maxv 	if (L1 == MAP_FAILED)
    160  1.1  maxv 		err(errno, "mmap");
    161  1.1  maxv 
    162  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)L4, PAGE_SIZE) == -1)
    163  1.1  maxv 		err(errno, "nvmm_hva_map");
    164  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)L3, PAGE_SIZE) == -1)
    165  1.1  maxv 		err(errno, "nvmm_hva_map");
    166  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)L2, PAGE_SIZE) == -1)
    167  1.1  maxv 		err(errno, "nvmm_hva_map");
    168  1.1  maxv 	if (nvmm_hva_map(mach, (uintptr_t)L1, PAGE_SIZE) == -1)
    169  1.1  maxv 		err(errno, "nvmm_hva_map");
    170  1.1  maxv 
    171  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)L4, 0x3000, PAGE_SIZE, 0) == -1)
    172  1.1  maxv 		err(errno, "nvmm_gpa_map");
    173  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)L3, 0x4000, PAGE_SIZE, 0) == -1)
    174  1.1  maxv 		err(errno, "nvmm_gpa_map");
    175  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)L2, 0x5000, PAGE_SIZE, 0) == -1)
    176  1.1  maxv 		err(errno, "nvmm_gpa_map");
    177  1.1  maxv 	if (nvmm_gpa_map(mach, (uintptr_t)L1, 0x6000, PAGE_SIZE, 0) == -1)
    178  1.1  maxv 		err(errno, "nvmm_gpa_map");
    179  1.1  maxv 
    180  1.1  maxv 	memset(L4, 0, PAGE_SIZE);
    181  1.1  maxv 	memset(L3, 0, PAGE_SIZE);
    182  1.1  maxv 	memset(L2, 0, PAGE_SIZE);
    183  1.1  maxv 	memset(L1, 0, PAGE_SIZE);
    184  1.1  maxv 
    185  1.1  maxv 	L4[0] = PG_V | PG_RW | 0x4000;
    186  1.1  maxv 	L3[0] = PG_V | PG_RW | 0x5000;
    187  1.1  maxv 	L2[0] = PG_V | PG_RW | 0x6000;
    188  1.1  maxv 	L1[0x2000 / PAGE_SIZE] = PG_V | PG_RW | 0x2000;
    189  1.1  maxv 	L1[0x1000 / PAGE_SIZE] = PG_V | PG_RW | 0x1000;
    190  1.1  maxv }
    191  1.1  maxv 
    192  1.1  maxv /* -------------------------------------------------------------------------- */
    193  1.1  maxv 
    194  1.1  maxv static size_t iobuf_off = 0;
    195  1.1  maxv 
    196  1.1  maxv static void
    197  1.1  maxv io_callback(struct nvmm_io *io)
    198  1.1  maxv {
    199  1.1  maxv 	if (io->port != 123) {
    200  1.1  maxv 		printf("Wrong port\n");
    201  1.1  maxv 		exit(-1);
    202  1.1  maxv 	}
    203  1.1  maxv 
    204  1.1  maxv 	if (io->in) {
    205  1.1  maxv 		memcpy(io->data, iobuf + iobuf_off, io->size);
    206  1.1  maxv 	} else {
    207  1.1  maxv 		memcpy(iobuf + iobuf_off, io->data, io->size);
    208  1.1  maxv 	}
    209  1.1  maxv 	iobuf_off += io->size;
    210  1.1  maxv 
    211  1.1  maxv }
    212  1.1  maxv 
    213  1.1  maxv static int
    214  1.1  maxv handle_io(struct nvmm_machine *mach, struct nvmm_exit *exit)
    215  1.1  maxv {
    216  1.1  maxv 	int ret;
    217  1.1  maxv 
    218  1.1  maxv 	ret = nvmm_assist_io(mach, 0, exit);
    219  1.1  maxv 	if (ret == -1) {
    220  1.1  maxv 		err(errno, "nvmm_assist_io");
    221  1.1  maxv 	}
    222  1.1  maxv 
    223  1.1  maxv 	return 0;
    224  1.1  maxv }
    225  1.1  maxv 
    226  1.1  maxv static void
    227  1.1  maxv run_machine(struct nvmm_machine *mach)
    228  1.1  maxv {
    229  1.1  maxv 	struct nvmm_exit exit;
    230  1.1  maxv 
    231  1.1  maxv 	while (1) {
    232  1.1  maxv 		if (nvmm_vcpu_run(mach, 0, &exit) == -1)
    233  1.1  maxv 			err(errno, "nvmm_vcpu_run");
    234  1.1  maxv 
    235  1.1  maxv 		switch (exit.reason) {
    236  1.1  maxv 		case NVMM_EXIT_NONE:
    237  1.1  maxv 			break;
    238  1.1  maxv 
    239  1.1  maxv 		case NVMM_EXIT_MSR:
    240  1.1  maxv 			/* Stop here. */
    241  1.1  maxv 			return;
    242  1.1  maxv 
    243  1.1  maxv 		case NVMM_EXIT_IO:
    244  1.1  maxv 			handle_io(mach, &exit);
    245  1.1  maxv 			break;
    246  1.1  maxv 
    247  1.1  maxv 		case NVMM_EXIT_SHUTDOWN:
    248  1.1  maxv 			printf("Shutting down!\n");
    249  1.1  maxv 			return;
    250  1.1  maxv 
    251  1.1  maxv 		default:
    252  1.1  maxv 			printf("Invalid!\n");
    253  1.1  maxv 			return;
    254  1.1  maxv 		}
    255  1.1  maxv 	}
    256  1.1  maxv }
    257  1.1  maxv 
    258  1.1  maxv /* -------------------------------------------------------------------------- */
    259  1.1  maxv 
    260  1.1  maxv struct test {
    261  1.1  maxv 	const char *name;
    262  1.1  maxv 	uint8_t *code_begin;
    263  1.1  maxv 	uint8_t *code_end;
    264  1.1  maxv 	const char *wanted;
    265  1.1  maxv 	bool in;
    266  1.1  maxv };
    267  1.1  maxv 
    268  1.1  maxv static void
    269  1.1  maxv run_test(struct nvmm_machine *mach, const struct test *test)
    270  1.1  maxv {
    271  1.1  maxv 	size_t size;
    272  1.1  maxv 	char *res;
    273  1.1  maxv 
    274  1.1  maxv 	size = (size_t)test->code_end - (size_t)test->code_begin;
    275  1.1  maxv 
    276  1.1  maxv 	reset_machine(mach);
    277  1.1  maxv 
    278  1.1  maxv 	iobuf_off = 0;
    279  1.1  maxv 	memset(iobuf, 0, IO_SIZE);
    280  1.1  maxv 	memset(databuf, 0, PAGE_SIZE);
    281  1.1  maxv 	memcpy(instbuf, test->code_begin, size);
    282  1.1  maxv 
    283  1.1  maxv 	if (test->in) {
    284  1.1  maxv 		strcpy(iobuf, test->wanted);
    285  1.1  maxv 	} else {
    286  1.1  maxv 		strcpy(databuf, test->wanted);
    287  1.1  maxv 	}
    288  1.1  maxv 
    289  1.1  maxv 	run_machine(mach);
    290  1.1  maxv 
    291  1.1  maxv 	if (test->in) {
    292  1.1  maxv 		res = databuf;
    293  1.1  maxv 	} else {
    294  1.1  maxv 		res = iobuf;
    295  1.1  maxv 	}
    296  1.1  maxv 
    297  1.1  maxv 	if (!strcmp(res, test->wanted)) {
    298  1.1  maxv 		printf("Test '%s' passed\n", test->name);
    299  1.1  maxv 	} else {
    300  1.1  maxv 		printf("Test '%s' failed, wanted '%s', got '%s'\n", test->name,
    301  1.1  maxv 		    test->wanted, res);
    302  1.1  maxv 	}
    303  1.1  maxv }
    304  1.1  maxv 
    305  1.1  maxv /* -------------------------------------------------------------------------- */
    306  1.1  maxv 
    307  1.1  maxv extern uint8_t test1_begin, test1_end;
    308  1.1  maxv extern uint8_t test2_begin, test2_end;
    309  1.1  maxv extern uint8_t test3_begin, test3_end;
    310  1.1  maxv extern uint8_t test4_begin, test4_end;
    311  1.1  maxv extern uint8_t test5_begin, test5_end;
    312  1.1  maxv extern uint8_t test6_begin, test6_end;
    313  1.1  maxv extern uint8_t test7_begin, test7_end;
    314  1.1  maxv extern uint8_t test8_begin, test8_end;
    315  1.1  maxv extern uint8_t test9_begin, test9_end;
    316  1.1  maxv extern uint8_t test10_begin, test10_end;
    317  1.1  maxv extern uint8_t test11_begin, test11_end;
    318  1.1  maxv extern uint8_t test12_begin, test12_end;
    319  1.1  maxv 
    320  1.1  maxv static const struct test tests[] = {
    321  1.1  maxv 	{ "test1 - INB", &test1_begin, &test1_end, "12", true },
    322  1.1  maxv 	{ "test2 - INW", &test2_begin, &test2_end, "1234", true },
    323  1.1  maxv 	{ "test3 - INL", &test3_begin, &test3_end, "12345678", true },
    324  1.1  maxv 	{ "test4 - INSB+REP", &test4_begin, &test4_end, "12345", true },
    325  1.1  maxv 	{ "test5 - INSW+REP", &test5_begin, &test5_end,
    326  1.1  maxv 	  "Comment est votre blanquette", true },
    327  1.1  maxv 	{ "test6 - INSL+REP", &test6_begin, &test6_end,
    328  1.1  maxv 	  "123456789abcdefghijklmnopqrs", true },
    329  1.1  maxv 	{ "test7 - OUTB", &test7_begin, &test7_end, "12", false },
    330  1.1  maxv 	{ "test8 - OUTW", &test8_begin, &test8_end, "1234", false },
    331  1.1  maxv 	{ "test9 - OUTL", &test9_begin, &test9_end, "12345678", false },
    332  1.1  maxv 	{ "test10 - OUTSB+REP", &test10_begin, &test10_end, "12345", false },
    333  1.1  maxv 	{ "test11 - OUTSW+REP", &test11_begin, &test11_end,
    334  1.1  maxv 	  "Ah, Herr Bramard", false },
    335  1.1  maxv 	{ "test12 - OUTSL+REP", &test12_begin, &test12_end,
    336  1.1  maxv 	  "123456789abcdefghijklmnopqrs", false },
    337  1.1  maxv 	{ NULL, NULL, NULL, NULL, false }
    338  1.1  maxv };
    339  1.1  maxv 
    340  1.1  maxv static const struct nvmm_callbacks callbacks = {
    341  1.1  maxv 	.io = io_callback,
    342  1.1  maxv 	.mem = NULL
    343  1.1  maxv };
    344  1.1  maxv 
    345  1.1  maxv /*
    346  1.1  maxv  * 0x1000: Data, mapped
    347  1.1  maxv  * 0x2000: Instructions, mapped
    348  1.1  maxv  * 0x3000: L4
    349  1.1  maxv  * 0x4000: L3
    350  1.1  maxv  * 0x5000: L2
    351  1.1  maxv  * 0x6000: L1
    352  1.1  maxv  */
    353  1.1  maxv int main(int argc, char *argv[])
    354  1.1  maxv {
    355  1.1  maxv 	struct nvmm_machine mach;
    356  1.1  maxv 	size_t i;
    357  1.1  maxv 
    358  1.1  maxv 	if (nvmm_machine_create(&mach) == -1)
    359  1.1  maxv 		err(errno, "nvmm_machine_create");
    360  1.1  maxv 	if (nvmm_vcpu_create(&mach, 0) == -1)
    361  1.1  maxv 		err(errno, "nvmm_vcpu_create");
    362  1.1  maxv 	nvmm_callbacks_register(&callbacks);
    363  1.1  maxv 	map_pages(&mach);
    364  1.1  maxv 
    365  1.1  maxv 	for (i = 0; tests[i].name != NULL; i++) {
    366  1.1  maxv 		run_test(&mach, &tests[i]);
    367  1.1  maxv 	}
    368  1.1  maxv 
    369  1.1  maxv 	return 0;
    370  1.1  maxv }
    371