queries.c revision 1.4 1 1.4 rillig /* $NetBSD: queries.c,v 1.4 2022/08/28 08:41:06 rillig Exp $ */
2 1.1 rillig # 3 "queries.c"
3 1.1 rillig
4 1.1 rillig /*
5 1.1 rillig * Demonstrate the case-by-case queries. Unlike warnings, queries do not
6 1.1 rillig * point to questionable code but rather to code that may be interesting to
7 1.1 rillig * inspect manually on a case-by-case basis.
8 1.1 rillig *
9 1.1 rillig * Possible use cases are:
10 1.1 rillig *
11 1.1 rillig * Understanding how C works internally, by making the usual arithmetic
12 1.1 rillig * conversions visible.
13 1.1 rillig *
14 1.1 rillig * Finding code that intentionally suppresses a regular lint warning,
15 1.1 rillig * such as casts between arithmetic types.
16 1.1 rillig */
17 1.1 rillig
18 1.1 rillig /* lint1-extra-flags: -q 1,2,3,4,5,6,7 */
19 1.1 rillig
20 1.2 rillig typedef unsigned char u8_t;
21 1.2 rillig typedef unsigned short u16_t;
22 1.2 rillig typedef unsigned int u32_t;
23 1.2 rillig typedef unsigned long long u64_t;
24 1.2 rillig typedef signed char s8_t;
25 1.2 rillig typedef signed short s16_t;
26 1.2 rillig typedef signed int s32_t;
27 1.2 rillig typedef signed long long s64_t;
28 1.2 rillig
29 1.2 rillig typedef float f32_t;
30 1.2 rillig typedef double f64_t;
31 1.2 rillig typedef float _Complex c32_t;
32 1.2 rillig typedef double _Complex c64_t;
33 1.2 rillig
34 1.3 rillig typedef char *str_t;
35 1.3 rillig typedef const char *cstr_t;
36 1.3 rillig typedef volatile char *vstr_t;
37 1.3 rillig
38 1.3 rillig _Bool cond;
39 1.3 rillig
40 1.2 rillig u8_t u8;
41 1.2 rillig u16_t u16;
42 1.2 rillig u32_t u32;
43 1.2 rillig u64_t u64;
44 1.2 rillig
45 1.2 rillig s8_t s8;
46 1.2 rillig s16_t s16;
47 1.2 rillig s32_t s32;
48 1.2 rillig s64_t s64;
49 1.2 rillig
50 1.2 rillig struct {
51 1.2 rillig unsigned u8:8;
52 1.2 rillig unsigned u9:9;
53 1.2 rillig unsigned u10:10;
54 1.2 rillig unsigned u32:32;
55 1.2 rillig int s8:8;
56 1.2 rillig int s9:9;
57 1.2 rillig int s10:10;
58 1.2 rillig int s32:32;
59 1.2 rillig } bits;
60 1.2 rillig
61 1.2 rillig f32_t f32;
62 1.2 rillig f64_t f64;
63 1.2 rillig
64 1.2 rillig c32_t c32;
65 1.2 rillig c64_t c64;
66 1.2 rillig
67 1.2 rillig char *str;
68 1.2 rillig const char *cstr;
69 1.3 rillig volatile char *vstr;
70 1.2 rillig
71 1.1 rillig int
72 1.1 rillig Q1(double dbl)
73 1.1 rillig {
74 1.1 rillig /* expect+1: implicit conversion from floating point 'double' to integer 'int' [Q1] */
75 1.1 rillig return dbl;
76 1.1 rillig }
77 1.1 rillig
78 1.1 rillig int
79 1.1 rillig Q2(double dbl)
80 1.1 rillig {
81 1.2 rillig /* expect+1: cast from floating point 'double' to integer 'int' [Q2] */
82 1.1 rillig return (int)dbl;
83 1.1 rillig }
84 1.1 rillig
85 1.1 rillig void
86 1.1 rillig Q3(int i, unsigned u)
87 1.1 rillig {
88 1.1 rillig /* expect+1: implicit conversion changes sign from 'int' to 'unsigned int' [Q3] */
89 1.1 rillig u = i;
90 1.1 rillig
91 1.1 rillig /* expect+1: implicit conversion changes sign from 'unsigned int' to 'int' [Q3] */
92 1.1 rillig i = u;
93 1.1 rillig }
94 1.1 rillig
95 1.1 rillig unsigned long long
96 1.1 rillig Q4(char *ptr, int i, unsigned long long ull)
97 1.1 rillig {
98 1.1 rillig /*
99 1.1 rillig * The conversion from 'char' to 'int' is done by the integer
100 1.1 rillig * promotions (C11 6.3.1.1p2), not by the usual arithmetic
101 1.1 rillig * conversions (C11 6.3.1.8p1).
102 1.1 rillig */
103 1.1 rillig /* expect+2: usual arithmetic conversion for '+' from 'int' to 'unsigned long long' [Q4] */
104 1.1 rillig /* expect+1: implicit conversion changes sign from 'int' to 'unsigned long long' [Q3] */
105 1.1 rillig return ptr[0] + ptr[1] + i + ull;
106 1.1 rillig }
107 1.1 rillig
108 1.1 rillig void
109 1.1 rillig Q5(char *ptr, int i)
110 1.1 rillig {
111 1.1 rillig if (ptr + i > ptr)
112 1.1 rillig return;
113 1.1 rillig
114 1.1 rillig /* expect+1: pointer addition has integer on the left-hand side [Q5] */
115 1.1 rillig if (i + ptr > ptr)
116 1.1 rillig return;
117 1.1 rillig
118 1.1 rillig if (ptr[i] != '\0')
119 1.1 rillig return;
120 1.1 rillig
121 1.1 rillig /* expect+1: pointer addition has integer on the left-hand side [Q5] */
122 1.1 rillig if (i[ptr] != '\0')
123 1.1 rillig return;
124 1.1 rillig }
125 1.1 rillig
126 1.1 rillig void
127 1.1 rillig Q6(int i)
128 1.1 rillig {
129 1.1 rillig /* expect+1: no-op cast from 'int' to 'int' [Q6] */
130 1.1 rillig i = (int)4;
131 1.1 rillig
132 1.1 rillig /* expect+1: no-op cast from 'int' to 'int' [Q6] */
133 1.1 rillig i = (int)i + 1;
134 1.1 rillig }
135 1.1 rillig
136 1.2 rillig extern void *allocate(void);
137 1.1 rillig
138 1.2 rillig void
139 1.1 rillig Q7(void)
140 1.1 rillig {
141 1.1 rillig
142 1.3 rillig /* expect+2: no-op cast from '_Bool' to '_Bool' [Q6] */
143 1.3 rillig /* expect+1: redundant cast from '_Bool' to '_Bool' before assignment [Q7] */
144 1.3 rillig cond = (_Bool)cond;
145 1.3 rillig cond = (_Bool)u8;
146 1.3 rillig u8 = (u8_t)cond;
147 1.3 rillig
148 1.2 rillig /* expect+2: no-op cast from 'unsigned char' to 'unsigned char' [Q6] */
149 1.2 rillig /* expect+1: redundant cast from 'unsigned char' to 'unsigned char' before assignment [Q7] */
150 1.2 rillig u8 = (u8_t)u8;
151 1.2 rillig u8 = (u8_t)u16;
152 1.2 rillig u8 = (u16_t)u8;
153 1.2 rillig /* expect+1: no-op cast from 'unsigned short' to 'unsigned short' [Q6] */
154 1.2 rillig u8 = (u16_t)u16;
155 1.2 rillig /* expect+1: no-op cast from 'unsigned char' to 'unsigned char' [Q6] */
156 1.2 rillig u16 = (u8_t)u8;
157 1.2 rillig u16 = (u8_t)u16;
158 1.2 rillig /* expect+1: redundant cast from 'unsigned char' to 'unsigned short' before assignment [Q7] */
159 1.2 rillig u16 = (u16_t)u8;
160 1.2 rillig /* expect+2: no-op cast from 'unsigned short' to 'unsigned short' [Q6] */
161 1.2 rillig /* expect+1: redundant cast from 'unsigned short' to 'unsigned short' before assignment [Q7] */
162 1.2 rillig u16 = (u16_t)u16;
163 1.2 rillig
164 1.2 rillig /* Mixing signed and unsigned types. */
165 1.2 rillig u8 = (u8_t)s8;
166 1.2 rillig s8 = (s8_t)u8;
167 1.2 rillig /* expect+1: redundant cast from 'unsigned char' to 'short' before assignment [Q7] */
168 1.2 rillig s16 = (s16_t)u8;
169 1.2 rillig /* expect+1: redundant cast from 'signed char' to 'short' before assignment [Q7] */
170 1.2 rillig s16 = (s16_t)s8;
171 1.2 rillig
172 1.2 rillig
173 1.2 rillig /*
174 1.2 rillig * Neither GCC nor Clang accept typeof(bit-field), as that would add
175 1.2 rillig * unnecessary complexity. Lint accepts it but silently discards the
176 1.4 rillig * bit-field portion from the type; see dcs_add_type.
177 1.2 rillig */
178 1.2 rillig /* expect+1: redundant cast from 'unsigned char' to 'unsigned int' before assignment [Q7] */
179 1.2 rillig bits.u9 = (typeof(bits.u9))u8;
180 1.2 rillig
181 1.2 rillig
182 1.2 rillig /* expect+2: no-op cast from 'float' to 'float' [Q6] */
183 1.2 rillig /* expect+1: redundant cast from 'float' to 'float' before assignment [Q7] */
184 1.2 rillig f32 = (f32_t)f32;
185 1.2 rillig f32 = (f32_t)f64;
186 1.2 rillig f32 = (f64_t)f32;
187 1.2 rillig /* expect+1: no-op cast from 'double' to 'double' [Q6] */
188 1.2 rillig f32 = (f64_t)f64;
189 1.2 rillig /* expect+1: no-op cast from 'float' to 'float' [Q6] */
190 1.2 rillig f64 = (f32_t)f32;
191 1.2 rillig f64 = (f32_t)f64;
192 1.2 rillig /* expect+1: redundant cast from 'float' to 'double' before assignment [Q7] */
193 1.2 rillig f64 = (f64_t)f32;
194 1.2 rillig /* expect+2: no-op cast from 'double' to 'double' [Q6] */
195 1.2 rillig /* expect+1: redundant cast from 'double' to 'double' before assignment [Q7] */
196 1.2 rillig f64 = (f64_t)f64;
197 1.2 rillig
198 1.2 rillig
199 1.2 rillig /* expect+2: no-op cast from 'float _Complex' to 'float _Complex' [Q6] */
200 1.2 rillig /* expect+1: redundant cast from 'float _Complex' to 'float _Complex' before assignment [Q7] */
201 1.2 rillig c32 = (c32_t)c32;
202 1.2 rillig c32 = (c32_t)c64;
203 1.2 rillig c32 = (c64_t)c32;
204 1.2 rillig /* expect+1: no-op cast from 'double _Complex' to 'double _Complex' [Q6] */
205 1.2 rillig c32 = (c64_t)c64;
206 1.2 rillig /* expect+1: no-op cast from 'float _Complex' to 'float _Complex' [Q6] */
207 1.2 rillig c64 = (c32_t)c32;
208 1.2 rillig c64 = (c32_t)c64;
209 1.2 rillig /* expect+1: redundant cast from 'float _Complex' to 'double _Complex' before assignment [Q7] */
210 1.2 rillig c64 = (c64_t)c32;
211 1.2 rillig /* expect+2: no-op cast from 'double _Complex' to 'double _Complex' [Q6] */
212 1.2 rillig /* expect+1: redundant cast from 'double _Complex' to 'double _Complex' before assignment [Q7] */
213 1.2 rillig c64 = (c64_t)c64;
214 1.2 rillig
215 1.1 rillig
216 1.3 rillig /* Mixing real and complex floating point types. */
217 1.3 rillig /* expect+1: no-op cast from 'float' to 'float' [Q6] */
218 1.3 rillig c32 = (f32_t)f32;
219 1.3 rillig c32 = (c32_t)f32;
220 1.3 rillig /* expect+1: no-op cast from 'float' to 'float' [Q6] */
221 1.3 rillig c64 = (f32_t)f32;
222 1.3 rillig c64 = (f64_t)f32;
223 1.3 rillig c64 = (c32_t)f32;
224 1.3 rillig c64 = (c64_t)f32;
225 1.3 rillig
226 1.3 rillig
227 1.2 rillig /* expect+1: redundant cast from 'pointer to void' to 'pointer to char' before assignment [Q7] */
228 1.2 rillig str = (char *)allocate();
229 1.2 rillig /* expect+1: redundant cast from 'pointer to void' to 'pointer to const char' before assignment [Q7] */
230 1.2 rillig cstr = (const char *)allocate();
231 1.2 rillig cstr = (char *)allocate();
232 1.3 rillig
233 1.3 rillig /* expect+2: no-op cast from 'pointer to char' to 'pointer to char' [Q6] */
234 1.3 rillig /* expect+1: redundant cast from 'pointer to char' to 'pointer to char' before assignment [Q7] */
235 1.3 rillig str = (str_t)str;
236 1.3 rillig str = (str_t)cstr;
237 1.3 rillig /* expect+1: warning: operands of '=' have incompatible pointer types to 'char' and 'const char' [128] */
238 1.3 rillig str = (cstr_t)str;
239 1.3 rillig /* expect+2: no-op cast from 'pointer to const char' to 'pointer to const char' [Q6] */
240 1.3 rillig /* expect+1: warning: operands of '=' have incompatible pointer types to 'char' and 'const char' [128] */
241 1.3 rillig str = (cstr_t)cstr;
242 1.3 rillig /* expect+1: no-op cast from 'pointer to char' to 'pointer to char' [Q6] */
243 1.3 rillig cstr = (str_t)str;
244 1.3 rillig cstr = (str_t)cstr;
245 1.3 rillig cstr = (cstr_t)str;
246 1.3 rillig /* expect+2: no-op cast from 'pointer to const char' to 'pointer to const char' [Q6] */
247 1.3 rillig /* expect+1: redundant cast from 'pointer to const char' to 'pointer to const char' before assignment [Q7] */
248 1.3 rillig cstr = (cstr_t)cstr;
249 1.3 rillig
250 1.3 rillig /* expect+2: no-op cast from 'pointer to char' to 'pointer to char' [Q6] */
251 1.3 rillig /* expect+1: redundant cast from 'pointer to char' to 'pointer to char' before assignment [Q7] */
252 1.3 rillig str = (str_t)str;
253 1.3 rillig str = (str_t)vstr;
254 1.3 rillig /* expect+1: warning: operands of '=' have incompatible pointer types to 'char' and 'volatile char' [128] */
255 1.3 rillig str = (vstr_t)str;
256 1.3 rillig /* expect+2: no-op cast from 'pointer to volatile char' to 'pointer to volatile char' [Q6] */
257 1.3 rillig /* expect+1: warning: operands of '=' have incompatible pointer types to 'char' and 'volatile char' [128] */
258 1.3 rillig str = (vstr_t)vstr;
259 1.3 rillig /* expect+1: no-op cast from 'pointer to char' to 'pointer to char' [Q6] */
260 1.3 rillig vstr = (str_t)str;
261 1.3 rillig vstr = (str_t)vstr;
262 1.3 rillig vstr = (vstr_t)str;
263 1.3 rillig /* expect+2: no-op cast from 'pointer to volatile char' to 'pointer to volatile char' [Q6] */
264 1.3 rillig /* expect+1: redundant cast from 'pointer to volatile char' to 'pointer to volatile char' before assignment [Q7] */
265 1.3 rillig vstr = (vstr_t)vstr;
266 1.1 rillig }
267 1.1 rillig
268 1.1 rillig
269 1.1 rillig /*
270 1.1 rillig * Since queries do not affect the exit status, force a warning to make this
271 1.1 rillig * test conform to the general expectation that a test that produces output
272 1.1 rillig * exits non-successfully.
273 1.1 rillig */
274 1.1 rillig /* expect+1: warning: static variable 'unused' unused [226] */
275 1.1 rillig static int unused;
276