Home | History | Annotate | Line # | Download | only in systat
bufcache.c revision 1.17
      1  1.17    martin /*	$NetBSD: bufcache.c,v 1.17 2004/05/11 21:56:20 martin Exp $	*/
      2   1.1    simonb 
      3   1.1    simonb /*-
      4   1.1    simonb  * Copyright (c) 1999 The NetBSD Foundation, Inc.
      5   1.1    simonb  * All rights reserved.
      6   1.1    simonb  *
      7   1.1    simonb  * This code is derived from software contributed to The NetBSD Foundation
      8   1.1    simonb  * by Simon Burge.
      9   1.1    simonb  *
     10   1.1    simonb  * Redistribution and use in source and binary forms, with or without
     11   1.1    simonb  * modification, are permitted provided that the following conditions
     12   1.1    simonb  * are met:
     13   1.1    simonb  * 1. Redistributions of source code must retain the above copyright
     14   1.1    simonb  *    notice, this list of conditions and the following disclaimer.
     15   1.1    simonb  * 2. Redistributions in binary form must reproduce the above copyright
     16   1.1    simonb  *    notice, this list of conditions and the following disclaimer in the
     17   1.1    simonb  *    documentation and/or other materials provided with the distribution.
     18   1.1    simonb  * 3. All advertising materials mentioning features or use of this software
     19   1.1    simonb  *    must display the following acknowledgement:
     20   1.1    simonb  *        This product includes software developed by the NetBSD
     21   1.1    simonb  *        Foundation, Inc. and its contributors.
     22   1.1    simonb  * 4. Neither the name of The NetBSD Foundation nor the names of its
     23   1.1    simonb  *    contributors may be used to endorse or promote products derived
     24   1.1    simonb  *    from this software without specific prior written permission.
     25   1.1    simonb  *
     26   1.1    simonb  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
     27   1.1    simonb  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
     28   1.1    simonb  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
     29   1.1    simonb  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
     30   1.1    simonb  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
     31   1.1    simonb  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
     32   1.1    simonb  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
     33   1.1    simonb  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
     34   1.1    simonb  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
     35   1.1    simonb  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
     36   1.1    simonb  * POSSIBILITY OF SUCH DAMAGE.
     37   1.1    simonb  */
     38   1.1    simonb 
     39   1.1    simonb #include <sys/cdefs.h>
     40   1.1    simonb #ifndef lint
     41  1.17    martin __RCSID("$NetBSD: bufcache.c,v 1.17 2004/05/11 21:56:20 martin Exp $");
     42   1.1    simonb #endif /* not lint */
     43   1.1    simonb 
     44   1.1    simonb #include <sys/param.h>
     45   1.1    simonb #include <sys/buf.h>
     46   1.1    simonb #include <sys/mount.h>
     47   1.9    simonb #include <sys/sysctl.h>
     48   1.1    simonb #include <sys/vnode.h>
     49   1.1    simonb 
     50   1.9    simonb #include <uvm/uvm_extern.h>
     51   1.9    simonb 
     52   1.1    simonb #include <err.h>
     53   1.9    simonb #include <errno.h>
     54   1.1    simonb #include <kvm.h>
     55  1.11    simonb #include <math.h>
     56   1.1    simonb #include <nlist.h>
     57   1.1    simonb #include <stdlib.h>
     58   1.9    simonb #include <string.h>
     59   1.2       mrg #include <unistd.h>
     60   1.1    simonb 
     61  1.15        pk #include <miscfs/specfs/specdev.h>
     62  1.15        pk 
     63   1.1    simonb #include "systat.h"
     64   1.1    simonb #include "extern.h"
     65   1.1    simonb 
     66   1.1    simonb #define VCACHE_SIZE	50
     67   1.1    simonb 
     68   1.1    simonb struct vcache {
     69   1.1    simonb 	int vc_age;
     70   1.1    simonb 	struct vnode *vc_addr;
     71   1.1    simonb 	struct vnode vc_node;
     72   1.1    simonb };
     73   1.1    simonb 
     74   1.1    simonb struct ml_entry {
     75  1.15        pk 	u_int ml_count;
     76  1.15        pk 	u_long ml_size;
     77  1.15        pk 	u_long ml_valid;
     78   1.1    simonb 	struct mount *ml_addr;
     79  1.15        pk 	LIST_ENTRY(ml_entry) ml_entries;
     80   1.1    simonb 	struct mount ml_mount;
     81   1.1    simonb };
     82   1.1    simonb 
     83   1.1    simonb static struct nlist namelist[] = {
     84  1.15        pk #define	X_BUFMEM	0
     85  1.15        pk 	{ "_bufmem" },
     86   1.1    simonb 	{ "" },
     87   1.1    simonb };
     88   1.1    simonb 
     89   1.1    simonb static struct vcache vcache[VCACHE_SIZE];
     90   1.1    simonb static LIST_HEAD(mount_list, ml_entry) mount_list;
     91   1.1    simonb 
     92  1.17    martin static u_long bufmem;
     93  1.17    martin static u_int nbuf, pgwidth, kbwidth;
     94   1.9    simonb static struct uvmexp_sysctl uvmexp;
     95   1.1    simonb 
     96   1.8        ad static void	vc_init(void);
     97   1.8        ad static void	ml_init(void);
     98   1.8        ad static struct 	vnode *vc_lookup(struct vnode *);
     99   1.8        ad static struct 	mount *ml_lookup(struct mount *, int, int);
    100  1.11    simonb static void	fetchuvmexp(void);
    101   1.1    simonb 
    102   1.1    simonb 
    103   1.1    simonb WINDOW *
    104   1.8        ad openbufcache(void)
    105   1.1    simonb {
    106   1.1    simonb 
    107  1.13       dsl 	return (subwin(stdscr, -1, 0, 5, 0));
    108   1.1    simonb }
    109   1.1    simonb 
    110   1.1    simonb void
    111   1.8        ad closebufcache(WINDOW *w)
    112   1.1    simonb {
    113   1.1    simonb 
    114   1.1    simonb 	if (w == NULL)
    115   1.1    simonb 		return;
    116   1.1    simonb 	wclear(w);
    117   1.1    simonb 	wrefresh(w);
    118   1.1    simonb 	delwin(w);
    119   1.1    simonb 	ml_init();		/* Clear out mount list */
    120   1.1    simonb }
    121   1.1    simonb 
    122   1.1    simonb void
    123   1.8        ad labelbufcache(void)
    124   1.1    simonb {
    125   1.1    simonb 	wmove(wnd, 1, 0);
    126  1.11    simonb 	wclrtoeol(wnd);
    127   1.9    simonb 	wmove(wnd, 2, 0);
    128   1.1    simonb 	wclrtoeol(wnd);
    129  1.11    simonb 	wmove(wnd, 3, 0);
    130  1.11    simonb 	wclrtoeol(wnd);
    131  1.11    simonb 	mvwaddstr(wnd, 4, 0,
    132   1.4       mrg "File System          Bufs used   %   kB in use   %  Bufsize kB   %  Util %");
    133   1.1    simonb 	wclrtoeol(wnd);
    134   1.1    simonb }
    135   1.1    simonb 
    136   1.1    simonb void
    137   1.8        ad showbufcache(void)
    138   1.1    simonb {
    139   1.1    simonb 	int tbuf, i, lastrow;
    140  1.15        pk 	double tvalid, tsize;
    141   1.1    simonb 	struct ml_entry *ml;
    142   1.1    simonb 
    143  1.15        pk 	NREAD(X_BUFMEM, &bufmem, sizeof(bufmem));
    144  1.15        pk 
    145  1.15        pk 	mvwprintw(wnd, 0, 0,
    146  1.17    martin 	    "There are %*d metadata buffers using           %*ld kBytes of memory.",
    147  1.15        pk 	    pgwidth, nbuf, kbwidth, bufmem/1024);
    148  1.15        pk 	wclrtoeol(wnd);
    149   1.9    simonb 	mvwprintw(wnd, 1, 0,
    150  1.12       chs 	    "There are %*llu pages for cached file data using %*llu kBytes of memory.",
    151  1.12       chs 	    pgwidth, (long long)uvmexp.filepages,
    152  1.12       chs 	    kbwidth, (long long) uvmexp.filepages * getpagesize() / 1024);
    153  1.11    simonb 	wclrtoeol(wnd);
    154  1.11    simonb 	mvwprintw(wnd, 2, 0,
    155  1.11    simonb 	    "There are %*llu pages for executables using      %*llu kBytes of memory.",
    156  1.12       chs 	    pgwidth, (long long)uvmexp.execpages,
    157  1.12       chs 	    kbwidth, (long long) uvmexp.execpages * getpagesize() / 1024);
    158   1.9    simonb 	wclrtoeol(wnd);
    159   1.9    simonb 
    160  1.15        pk 	if (nbuf == 0 || bufmem == 0) {
    161  1.15        pk 		wclrtobot(wnd);
    162  1.15        pk 		return;
    163  1.15        pk 	}
    164  1.15        pk 
    165  1.15        pk 	tbuf = 0;
    166  1.15        pk 	tvalid = tsize = 0;
    167  1.11    simonb 	lastrow = 5;	/* Leave room for header. */
    168   1.1    simonb 	for (i = lastrow, ml = LIST_FIRST(&mount_list); ml != NULL;
    169   1.1    simonb 	    i++, ml = LIST_NEXT(ml, ml_entries)) {
    170   1.1    simonb 
    171  1.15        pk 		int c = ml->ml_count;
    172  1.15        pk 		double v = ml->ml_valid;
    173  1.15        pk 		double s = ml->ml_size;
    174  1.15        pk 
    175   1.1    simonb 		/* Display in window if enough room. */
    176   1.1    simonb 		if (i < getmaxy(wnd) - 2) {
    177   1.1    simonb 			mvwprintw(wnd, i, 0, "%-20.20s", ml->ml_addr == NULL ?
    178   1.1    simonb 			    "NULL" : ml->ml_mount.mnt_stat.f_mntonname);
    179   1.4       mrg 			wprintw(wnd,
    180  1.15        pk 			    "    %6d %3d    %8ld %3.0f    %8ld %3.0f     %3.0f",
    181  1.15        pk 			    c, (100 * c) / nbuf,
    182  1.15        pk 			    (long)(v/1024), 100 * v / bufmem,
    183  1.15        pk 			    (long)(s/1024), 100 * s / bufmem,
    184  1.15        pk 			    100 * v / s);
    185   1.1    simonb 			wclrtoeol(wnd);
    186   1.1    simonb 			lastrow = i;
    187   1.1    simonb 		}
    188   1.1    simonb 
    189   1.1    simonb 		/* Update statistics. */
    190  1.15        pk 		tbuf += c;
    191  1.15        pk 		tvalid += v;
    192  1.15        pk 		tsize += s;
    193   1.1    simonb 	}
    194   1.1    simonb 
    195   1.1    simonb 	wclrtobot(wnd);
    196   1.4       mrg 	mvwprintw(wnd, lastrow + 2, 0,
    197  1.15        pk 	    "%-20s    %6d %3d    %8ld %3.0f    %8ld %3.0f     %3.0f",
    198   1.4       mrg 	    "Total:", tbuf, (100 * tbuf) / nbuf,
    199  1.15        pk 	    (long)(tvalid/1024), 100 * tvalid / bufmem,
    200  1.15        pk 	    (long)(tsize/1024), 100 * tsize / bufmem,
    201  1.15        pk 	    tsize != 0 ? ((100 * tvalid) / tsize) : 0);
    202   1.1    simonb }
    203   1.1    simonb 
    204   1.1    simonb int
    205   1.8        ad initbufcache(void)
    206   1.1    simonb {
    207  1.15        pk 	if (namelist[0].n_type == 0) {
    208   1.1    simonb 		if (kvm_nlist(kd, namelist)) {
    209   1.1    simonb 			nlisterr(namelist);
    210   1.1    simonb 			return(0);
    211   1.1    simonb 		}
    212   1.5     jwise 	}
    213   1.1    simonb 
    214  1.11    simonb 	fetchuvmexp();
    215  1.11    simonb 	pgwidth = (int)(floor(log10((double)uvmexp.npages)) + 1);
    216  1.11    simonb 	kbwidth = (int)(floor(log10(uvmexp.npages * getpagesize() / 1024.0)) + 1);
    217  1.11    simonb 
    218   1.1    simonb 	return(1);
    219   1.1    simonb }
    220   1.1    simonb 
    221  1.11    simonb static void
    222  1.11    simonb fetchuvmexp(void)
    223   1.1    simonb {
    224  1.11    simonb 	int mib[2];
    225   1.9    simonb 	size_t size;
    226   1.9    simonb 
    227  1.11    simonb 	/* Re-read pages used for vnodes & executables */
    228   1.9    simonb 	size = sizeof(uvmexp);
    229   1.9    simonb 	mib[0] = CTL_VM;
    230   1.9    simonb 	mib[1] = VM_UVMEXP2;
    231   1.9    simonb 	if (sysctl(mib, 2, &uvmexp, &size, NULL, 0) < 0) {
    232   1.9    simonb 		error("can't get uvmexp: %s\n", strerror(errno));
    233   1.9    simonb 		memset(&uvmexp, 0, sizeof(uvmexp));
    234   1.9    simonb 	}
    235  1.11    simonb }
    236  1.11    simonb 
    237  1.11    simonb void
    238  1.11    simonb fetchbufcache(void)
    239  1.11    simonb {
    240  1.15        pk 	int count;
    241  1.16    atatat 	struct buf_sysctl *bp, *buffers;
    242  1.11    simonb 	struct vnode *vn;
    243  1.11    simonb 	struct mount *mt;
    244  1.11    simonb 	struct ml_entry *ml;
    245  1.16    atatat 	int mib[6];
    246  1.15        pk 	size_t size;
    247  1.15        pk 	int extraslop = 0;
    248   1.1    simonb 
    249  1.15        pk 	/* Re-read pages used for vnodes & executables */
    250  1.11    simonb 	fetchuvmexp();
    251   1.1    simonb 
    252   1.1    simonb 	/* Initialise vnode cache and mount list. */
    253   1.1    simonb 	vc_init();
    254   1.1    simonb 	ml_init();
    255  1.15        pk 
    256  1.15        pk 	/* Get metadata buffers */
    257  1.15        pk 	size = 0;
    258  1.15        pk 	buffers = NULL;
    259  1.15        pk 	mib[0] = CTL_KERN;
    260  1.15        pk 	mib[1] = KERN_BUF;
    261  1.16    atatat 	mib[2] = KERN_BUF_ALL;
    262  1.16    atatat 	mib[3] = KERN_BUF_ALL;
    263  1.16    atatat 	mib[4] = (int)sizeof(struct buf_sysctl);
    264  1.16    atatat 	mib[5] = INT_MAX; /* we want them all */
    265  1.16    atatat again:
    266  1.16    atatat 	if (sysctl(mib, 6, NULL, &size, NULL, 0) < 0) {
    267  1.15        pk 		error("can't get buffers size: %s\n", strerror(errno));
    268  1.15        pk 		return;
    269  1.15        pk 	}
    270  1.15        pk 	if (size == 0)
    271  1.15        pk 		return;
    272  1.15        pk 
    273  1.16    atatat 	size += extraslop * sizeof(struct buf_sysctl);
    274  1.15        pk 	buffers = malloc(size);
    275  1.15        pk 	if (buffers == NULL) {
    276  1.15        pk 		error("can't allocate buffers: %s\n", strerror(errno));
    277  1.15        pk 		return;
    278  1.15        pk 	}
    279  1.16    atatat 	if (sysctl(mib, 6, buffers, &size, NULL, 0) < 0) {
    280  1.15        pk 		free(buffers);
    281  1.15        pk 		if (extraslop == 0) {
    282  1.15        pk 			extraslop = 100;
    283  1.15        pk 			goto again;
    284  1.15        pk 		}
    285  1.15        pk 		error("can't get buffers: %s\n", strerror(errno));
    286  1.15        pk 		return;
    287  1.15        pk 	}
    288  1.15        pk 
    289  1.16    atatat 	nbuf = size / sizeof(struct buf_sysctl);
    290  1.15        pk 	for (bp = buffers; bp < buffers + nbuf; bp++) {
    291  1.16    atatat 		if (UINT64TOPTR(bp->b_vp) != NULL) {
    292  1.15        pk 			struct mount *mp;
    293  1.16    atatat 			vn = vc_lookup(UINT64TOPTR(bp->b_vp));
    294  1.15        pk 			if (vn == NULL)
    295  1.15        pk 				break;
    296  1.15        pk 
    297  1.15        pk 			mp = vn->v_mount;
    298  1.15        pk 			/*
    299  1.15        pk 			 * References to mounted-on vnodes should be
    300  1.15        pk 			 * counted towards the mounted filesystem.
    301  1.15        pk 			 */
    302  1.15        pk 			if (vn->v_type == VBLK && vn->v_specinfo != NULL) {
    303  1.15        pk 				struct specinfo sp;
    304  1.15        pk 				if (!KREAD(vn->v_specinfo, &sp, sizeof(sp)))
    305  1.15        pk 					continue;
    306  1.15        pk 				if (sp.si_mountpoint)
    307  1.15        pk 					mp = sp.si_mountpoint;
    308   1.1    simonb 			}
    309  1.15        pk 			if (mp != NULL)
    310  1.15        pk 				mt = ml_lookup(mp,
    311  1.15        pk 				    bp->b_bufsize,
    312  1.15        pk 				    bp->b_bcount);
    313   1.1    simonb 		}
    314   1.1    simonb 	}
    315   1.1    simonb 
    316   1.1    simonb 	/* simple sort - there's not that many entries */
    317   1.1    simonb 	do {
    318   1.1    simonb 		if ((ml = LIST_FIRST(&mount_list)) == NULL ||
    319   1.1    simonb 		    LIST_NEXT(ml, ml_entries) == NULL)
    320   1.1    simonb 			break;
    321   1.1    simonb 
    322   1.1    simonb 		count = 0;
    323   1.1    simonb 		for (ml = LIST_FIRST(&mount_list); ml != NULL;
    324   1.1    simonb 		    ml = LIST_NEXT(ml, ml_entries)) {
    325   1.1    simonb 			if (LIST_NEXT(ml, ml_entries) == NULL)
    326   1.1    simonb 				break;
    327   1.1    simonb 			if (ml->ml_count < LIST_NEXT(ml, ml_entries)->ml_count) {
    328   1.1    simonb 				ml = LIST_NEXT(ml, ml_entries);
    329   1.1    simonb 				LIST_REMOVE(ml, ml_entries);
    330   1.1    simonb 				LIST_INSERT_HEAD(&mount_list, ml, ml_entries);
    331   1.1    simonb 				count++;
    332   1.1    simonb 			}
    333   1.1    simonb 		}
    334   1.1    simonb 	} while (count != 0);
    335  1.15        pk 
    336  1.15        pk 	free(buffers);
    337   1.1    simonb }
    338   1.1    simonb 
    339   1.1    simonb static void
    340   1.8        ad vc_init(void)
    341   1.1    simonb {
    342   1.1    simonb 	int i;
    343   1.1    simonb 
    344   1.1    simonb 	/* vc_addr == NULL for unused cache entry. */
    345   1.1    simonb 	for (i = 0; i < VCACHE_SIZE; i++)
    346   1.1    simonb 		vcache[i].vc_addr = NULL;
    347   1.1    simonb }
    348   1.1    simonb 
    349   1.1    simonb static void
    350   1.8        ad ml_init(void)
    351   1.1    simonb {
    352   1.1    simonb 	struct ml_entry *ml;
    353   1.1    simonb 
    354   1.1    simonb 	/* Throw out the current mount list and start again. */
    355   1.1    simonb 	while ((ml = LIST_FIRST(&mount_list)) != NULL) {
    356   1.1    simonb 		LIST_REMOVE(ml, ml_entries);
    357   1.1    simonb 		free(ml);
    358   1.1    simonb 	}
    359   1.1    simonb }
    360   1.1    simonb 
    361   1.1    simonb 
    362   1.1    simonb static struct vnode *
    363   1.8        ad vc_lookup(struct vnode *vaddr)
    364   1.1    simonb {
    365   1.1    simonb 	struct vnode *ret;
    366  1.14  christos 	size_t i, oldest;
    367   1.1    simonb 
    368   1.1    simonb 	ret = NULL;
    369  1.14  christos 	oldest = 0;
    370  1.17    martin 	for (i = 0; i < VCACHE_SIZE; i++) {
    371   1.1    simonb 		if (vcache[i].vc_addr == NULL)
    372   1.1    simonb 			break;
    373  1.17    martin 		vcache[i].vc_age++;
    374   1.1    simonb 		if (vcache[i].vc_age < vcache[oldest].vc_age)
    375   1.1    simonb 			oldest = i;
    376   1.1    simonb 		if (vcache[i].vc_addr == vaddr) {
    377   1.1    simonb 			vcache[i].vc_age = 0;
    378   1.1    simonb 			ret = &vcache[i].vc_node;
    379   1.1    simonb 		}
    380   1.1    simonb 	}
    381   1.1    simonb 
    382   1.1    simonb 	/* Find an entry in the cache? */
    383   1.1    simonb 	if (ret != NULL)
    384   1.1    simonb 		return(ret);
    385   1.1    simonb 
    386   1.1    simonb 	/* Go past the end of the cache? */
    387   1.1    simonb 	if  (i >= VCACHE_SIZE)
    388   1.1    simonb 		i = oldest;
    389   1.1    simonb 
    390   1.1    simonb 	/* Read in new vnode and reset age counter. */
    391  1.14  christos 	if (KREAD(vaddr, &vcache[i].vc_node, sizeof(struct vnode)) == 0)
    392  1.14  christos 		return NULL;
    393   1.1    simonb 	vcache[i].vc_addr = vaddr;
    394   1.1    simonb 	vcache[i].vc_age = 0;
    395   1.1    simonb 
    396   1.1    simonb 	return(&vcache[i].vc_node);
    397   1.1    simonb }
    398   1.1    simonb 
    399   1.1    simonb static struct mount *
    400   1.8        ad ml_lookup(struct mount *maddr, int size, int valid)
    401   1.1    simonb {
    402   1.1    simonb 	struct ml_entry *ml;
    403   1.1    simonb 
    404   1.1    simonb 	for (ml = LIST_FIRST(&mount_list); ml != NULL;
    405   1.1    simonb 	    ml = LIST_NEXT(ml, ml_entries))
    406   1.1    simonb 		if (ml->ml_addr == maddr) {
    407   1.1    simonb 			ml->ml_count++;
    408  1.15        pk 			ml->ml_size += size;
    409  1.15        pk 			ml->ml_valid += valid;
    410   1.1    simonb 			if (ml->ml_addr == NULL)
    411   1.1    simonb 				return(NULL);
    412   1.1    simonb 			else
    413   1.1    simonb 				return(&ml->ml_mount);
    414   1.1    simonb 		}
    415   1.1    simonb 
    416   1.5     jwise 	if ((ml = malloc(sizeof(struct ml_entry))) == NULL) {
    417   1.5     jwise 		error("out of memory");
    418   1.5     jwise 		die(0);
    419   1.5     jwise 	}
    420   1.1    simonb 	LIST_INSERT_HEAD(&mount_list, ml, ml_entries);
    421   1.1    simonb 	ml->ml_count = 1;
    422  1.15        pk 	ml->ml_size = size;
    423  1.15        pk 	ml->ml_valid = valid;
    424   1.1    simonb 	ml->ml_addr = maddr;
    425   1.1    simonb 	if (maddr == NULL)
    426   1.1    simonb 		return(NULL);
    427   1.1    simonb 
    428   1.1    simonb 	KREAD(maddr, &ml->ml_mount, sizeof(struct mount));
    429   1.1    simonb 	return(&ml->ml_mount);
    430   1.1    simonb }
    431