Home | History | Annotate | Download | only in pci
History log of /src/sys/dev/pci/if_iwi.c
RevisionDateAuthorComments
 1.121  05-Jul-2024  rin sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@
 1.120  22-Aug-2022  thorpej branches: 1.120.10;
iwi_start(): Replace "IFQ_DEQUEUE() -> IF_PREPEND() on failure" with
"IFQ_POLL() -> IFQ_DEQUEUE() on success (or fatal error)".
 1.119  22-Aug-2022  thorpej We come into our if_start routine via ether_output(), therefore there is
no need to check-and-pullup to sizeof(struct ether_header). Instead, we
can simply assert it.
 1.118  23-May-2022  rin Audit unload/unmap v.s. free against DMA buffer for sys/dev/pci;
make sure that bus_dmamap_unload(9) [or bus_dmamap_destroy(9)] or
bus_dmamem_unmap(9) are preceding to freeing DMA buffer, if it is
loaded or mapped, respectively.

This is mandatory for some archs. See, e.g.:

http://www.nerv.org/netbsd/?q=id:20210511T013030Z.013443cc790088147e4beed43f53dedabeaf9312
http://www.nerv.org/netbsd/?q=id:20220511T172220Z.561179f0b6fcc5b9cd73e274f69d74e2ce9e4c93

XXX XXX XXX
Compile test only (for amd64/ALL).

Thanks riastradh@ for double check.
 1.117  09-Sep-2021  riastradh sys/dev: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.

I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
 1.116  16-Jun-2021  riastradh if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.
 1.115  08-May-2021  thorpej Use pci_compatible_match().
 1.114  20-Mar-2020  thorpej branches: 1.114.8;
This driver sleeps during iwi_media_change(), and thus requires an
adaptive mutex for the media lock.
 1.113  30-Jan-2020  thorpej Adopt <net/if_stats.h>.
 1.112  10-Nov-2019  chs branches: 1.112.2;
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.
 1.111  03-Feb-2019  mrg branches: 1.111.4;
- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily
 1.110  22-Dec-2018  maxv Replace: M_COPY_PKTHDR -> m_copy_pkthdr. No functional change, since the
former is a macro to the latter.
 1.109  09-Dec-2018  jdolecek use pci_intr_establish_xname() everywhere
 1.108  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.107  26-Jun-2018  msaitoh branches: 1.107.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.
 1.106  01-May-2018  maya GC private 802.11 rateset declarations, use the standard ones.

Build tested only.
 1.105  16-Jan-2018  maxv branches: 1.105.2;
Fix overflow.
 1.104  23-Oct-2017  msaitoh - If if_initialize() failed in the attach function, free resources and return.
- ifp is always not NULL in iwi_detach(). Check correctly with ifp->if_softc.
 1.103  23-May-2017  ozaki-r branches: 1.103.2;
Apply deferred if_start to more drivers

And annotate some XXX_start as it runs in softint to clarify that
it doesn't need deferred if_start.
 1.102  02-Feb-2017  nonaka wlan interfaces make interrupt routine running on softint context.

see http://mail-index.netbsd.org/tech-kern/2016/12/06/msg021281.html

tested device:
* ath at pci: AR5212, AR5424
* athn at pci: AR9287
* ipw at pci: 2100BG
* iwi at pci: 2915ABG
* iwm at pci: 3165, 7260, 8260
* iwn at pci: 4945, 6235
* ral at pci: RT2560
* rtwn at pci: RTL8192CE
 1.101  08-Dec-2016  ozaki-r branches: 1.101.2;
Apply deferred if_start framework

if_schedule_deferred_start checks if the if_snd queue contains packets,
so drivers don't need to check it by themselves.
 1.100  03-Aug-2016  mlelstv be quiet about regular intermediate authentication states.
 1.99  10-Jun-2016  ozaki-r branches: 1.99.2;
Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.
 1.98  07-Jan-2015  ozaki-r Pass a correct firmware size (instead of 0) to firmware_free

firmware_free now uses kmem_free(9) instead of free(9),
so we need to pass a correct size to it.
 1.97  29-Mar-2014  christos branches: 1.97.6;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.
 1.96  25-Feb-2014  pooka Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.
 1.95  26-Nov-2013  roy iwi_newstate should work along with ieee80211_new_state, not always
override it.
 1.94  21-Nov-2013  riz Wrap debug code in {} because "a label can only be part of a statement and
a declaration is not a statement." I.e., make it a statement by making
it part of a block.
 1.93  17-Oct-2013  christos - remove unused variables
- move debugging code inside debugging sections
 1.92  30-Mar-2013  christos branches: 1.92.4;
remove trailing whitespace
 1.91  02-Jun-2012  dsl branches: 1.91.2;
Add some pre-processor magic to verify that the type of the data item
passed to sysctl_createv() actually matches the declared type for
the item itself.
In the places where the caller specifies a function and a structure
address (typically the 'softc') an explicit (void *) cast is now needed.
Fixes bugs in sys/dev/acpi/asus_acpi.c sys/dev/bluetooth/bcsp.c
sys/kern/vfs_bio.c sys/miscfs/syncfs/sync_subr.c and setting
AcpiGbl_EnableAmlDebugObject.
(mostly passing the address of a uint64_t when typed as CTLTYPE_INT).
I've test built quite a few kernels, but there may be some unfixed MD
fallout. Most likely passing &char[] to char *.
Also add CTLFLAG_UNSIGNED for unsiged decimals - not set yet.
 1.90  21-Mar-2012  nisimura Unbreak the endian issue in firmware header decoding. Comfirmed good and
running by a powerpc machine.
 1.89  30-Jan-2012  drochner branches: 1.89.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.
 1.88  19-Nov-2011  tls branches: 1.88.2;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.
 1.87  23-May-2011  drochner branches: 1.87.4;
-remove references to crypto/arc4/arc4.* -- the code isn't used
anywhere afaics
(The confusion comes probably from use of arc4random() at various places,
but this lives in libkern and doesn't share code with the former.)
-g/c non-implementation of arc4 encryption in swcrypto(4)
-remove special casing of ARC4 in crypto(4) -- the point is that it
doesn't use an IV, and this fact is made explicit by the new "ivsize"
property of xforms
 1.86  31-Jan-2011  christos clear register 0x41 as FreeBSD and OpenBSD do. Update copyright to the latest.
 1.85  15-Nov-2010  uebayasi branches: 1.85.2; 1.85.4;
tsleep needs sys/proc.h.
 1.84  05-Apr-2010  joerg Push the bpf_ops usage back into bpf.h. Push the common ifp->if_bpf
check into the inline functions as well the fourth argument for
bpf_attach.
 1.83  19-Jan-2010  pooka branches: 1.83.2; 1.83.4;
Redefine bpf linkage through an always present op vector, i.e.
#if NBPFILTER is no longer required in the client. This change
doesn't yet add support for loading bpf as a module, since drivers
can register before bpf is attached. However, callers of bpf can
now be modularized.

Dynamically loadable bpf could probably be done fairly easily with
coordination from the stub driver and the real driver by registering
attachments in the stub before the real driver is loaded and doing
a handoff. ... and I'm not going to ponder the depths of unload
here.

Tested with i386/MONOLITHIC, modified MONOLITHIC without bpf and rump.
 1.82  05-Sep-2009  tsutsui Invert logic around nested pmf(9) registrations for readability.
 1.81  06-May-2009  cegger struct cfdata * -> cfdata_t, no functional changes intended.
 1.80  13-Mar-2009  jym Fixes in the iwi(4) driver to better handle errors:
- bus_dmamap fixes, with checks against NULL
- move the rings' allocation code later in iwi_attach() to avoid NULL pointer
dereference if allocation fails
- avoid double free() in case of failure during attach. If an allocation fails,
do not free the ring directly, as it is handled by iwi_detach()
- only set ring->count for RX/TX rings when ring allocation is successful, or
else the for loop during detach will fail with a NULL dereference.
- call pci_intr_disestablish() if iwi_reset() fails during attach; driver is
in an incoherent state, interrupt handler should not be used.

Proposed by me on tech-net@, approved by christos@. Compiled and tested
with GENERIC and XEN3_DOM0 kernels.
 1.79  13-Feb-2009  bouyer make iwi_alloc_tx_ring() prototype match function declaration (shows up when
bus_addr_t != bus_size_t). Fix cast for 64bit paddr_t on i386.
 1.78  09-Jan-2009  jmcneill branches: 1.78.2;
Make the "EULA not accepted" message a bit more informative, now reads:

EULA not accepted; please see the <driver>(4) man page.
 1.77  10-Nov-2008  joerg Fix typo in fw name.
 1.76  07-Nov-2008  joerg Match image name with upstream distfiles.
 1.75  07-Nov-2008  dyoung *** Summary ***

When a link-layer address changes (e.g., ifconfig ex0 link
02:de:ad:be:ef:02 active), send a gratuitous ARP and/or a Neighbor
Advertisement to update the network-/link-layer address bindings
on our LAN peers.

Refuse a change of ethernet address to the address 00:00:00:00:00:00
or to any multicast/broadcast address. (Thanks matt@.)

Reorder ifnet ioctl operations so that driver ioctls may inherit
the functions of their "class"---ether_ioctl(), fddi_ioctl(), et
cetera---and the class ioctls may inherit from the generic ioctl,
ifioctl_common(), but both driver- and class-ioctls may override
the generic behavior. Make network drivers share more code.

Distinguish a "factory" link-layer address from others for the
purposes of both protecting that address from deletion and computing
EUI64.

Return consistent, appropriate error codes from network drivers.

Improve readability. KNF.

*** Details ***

In if_attach(), always initialize the interface ioctl routine,
ifnet->if_ioctl, if the driver has not already initialized it.
Delete if_ioctl == NULL tests everywhere else, because it cannot
happen.

In the ioctl routines of network interfaces, inherit common ioctl
behaviors by calling either ifioctl_common() or whichever ioctl
routine is appropriate for the class of interface---e.g., ether_ioctl()
for ethernets.

Stop (ab)using SIOCSIFADDR and start to use SIOCINITIFADDR. In
the user->kernel interface, SIOCSIFADDR's argument was an ifreq,
but on the protocol->ifnet interface, SIOCSIFADDR's argument was
an ifaddr. That was confusing, and it would work against me as I
make it possible for a network interface to overload most ioctls.
On the protocol->ifnet interface, replace SIOCSIFADDR with
SIOCINITIFADDR. In ifioctl(), return EPERM if userland tries to
invoke SIOCINITIFADDR.

In ifioctl(), give the interface the first shot at handling most
interface ioctls, and give the protocol the second shot, instead
of the other way around. Finally, let compatibility code (COMPAT_OSOCK)
take a shot.

Pull device initialization out of switch statements under
SIOCINITIFADDR. For example, pull ..._init() out of any switch
statement that looks like this:

switch (...->sa_family) {
case ...:
..._init();
...
break;
...
default:
..._init();
...
break;
}

Rewrite many if-else clauses that handle all permutations of IFF_UP
and IFF_RUNNING to use a switch statement,

switch (x & (IFF_UP|IFF_RUNNING)) {
case 0:
...
break;
case IFF_RUNNING:
...
break;
case IFF_UP:
...
break;
case IFF_UP|IFF_RUNNING:
...
break;
}

unifdef lots of code containing #ifdef FreeBSD, #ifdef NetBSD, and
#ifdef SIOCSIFMTU, especially in fwip(4) and in ndis(4).

In ipw(4), remove an if_set_sadl() call that is out of place.

In nfe(4), reuse the jumbo MTU logic in ether_ioctl().

Let ethernets register a callback for setting h/w state such as
promiscuous mode and the multicast filter in accord with a change
in the if_flags: ether_set_ifflags_cb() registers a callback that
returns ENETRESET if the caller should reset the ethernet by calling
if_init(), 0 on success, != 0 on failure. Pull common code from
ex(4), gem(4), nfe(4), sip(4), tlp(4), vge(4) into ether_ioctl(),
and register if_flags callbacks for those drivers.

Return ENOTTY instead of EINVAL for inappropriate ioctls. In
zyd(4), use ENXIO instead of ENOTTY to indicate that the device is
not any longer attached.

Add to if_set_sadl() a boolean 'factory' argument that indicates
whether a link-layer address was assigned by the factory or some
other source. In a comment, recommend using the factory address
for generating an EUI64, and update in6_get_hw_ifid() to prefer a
factory address to any other link-layer address.

Add a routing message, RTM_LLINFO_UPD, that tells protocols to
update the binding of network-layer addresses to link-layer addresses.
Implement this message in IPv4 and IPv6 by sending a gratuitous
ARP or a neighbor advertisement, respectively. Generate RTM_LLINFO_UPD
messages on a change of an interface's link-layer address.

In ether_ioctl(), do not let SIOCALIFADDR set a link-layer address
that is broadcast/multicast or equal to 00:00:00:00:00:00.

Make ether_ioctl() call ifioctl_common() to handle ioctls that it
does not understand.

In gif(4), initialize if_softc and use it, instead of assuming that
the gif_softc and ifp overlap.

Let ifioctl_common() handle SIOCGIFADDR.

Sprinkle rtcache_invariants(), which checks on DIAGNOSTIC kernels
that certain invariants on a struct route are satisfied.

In agr(4), rewrite agr_ioctl_filter() to be a bit more explicit
about the ioctls that we do not allow on an agr(4) member interface.

bzero -> memset. Delete unnecessary casts to void *. Use
sockaddr_in_init() and sockaddr_in6_init(). Compare pointers with
NULL instead of "testing truth". Replace some instances of (type
*)0 with NULL. Change some K&R prototypes to ANSI C, and join
lines.
 1.74  30-Oct-2008  joerg branches: 1.74.2;
Add glue to ship Intel firmware images. For ipw and iwi require user to
accept the EULA via sysctl as discussed with core@.
 1.73  16-Jun-2008  mlelstv branches: 1.73.2; 1.73.4;
Compute the correct number of pages spanned by the firmware.

The old code just uses the firmware size and rounds up to full
pages. However, if the firmware isn't loaded aligned to a page
boundary (which it isn't), then one more page (and thus DMA
segment) might be necessary.
 1.72  21-Mar-2008  dyoung branches: 1.72.2; 1.72.4; 1.72.6; 1.72.8;
pci_activate() expects for its void * argument to be a device_t,
so change the type of the argument to device_t. Update each use
of pci_activate().

Use device_t and accessors. Use aprint_*_dev().
 1.71  11-Mar-2008  dyoung Finish the job: pci_disable_retry() is now a no-op, so don't call
it any more.
 1.70  11-Mar-2008  dyoung pci_disable_retry() is now a no-op, so don't call it any more.
 1.69  29-Feb-2008  dyoung Use PMF_FN_ARGS, PMF_FN_PROTO.
 1.68  09-Dec-2007  jmcneill branches: 1.68.6; 1.68.10;
Merge jmcneill-pm branch.
 1.67  22-Oct-2007  joerg branches: 1.67.4; 1.67.6;
Also convert detach function.
 1.66  22-Oct-2007  joerg Convert to device_t/softc split and aprint usage.
 1.65  19-Oct-2007  ad machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h
 1.64  01-Sep-2007  dyoung branches: 1.64.4;
Change a bazillion occurrences of code resembling this,

error = (cmd == SIOCADDMULTI) ?
ether_addmulti(ifr, &sc->sc_ec) :
ether_delmulti(ifr, &sc->sc_ec);

if (error == ENETRESET) {

to this,

if ((error = ether_ioctl(ifp, cmd, data)) == ENETRESET) {

which does the same thing.

(A bazillion is a very large number. This seems to make the i386
ALL kernel smaller by 3kB to 4kB.)

Use ifreq_getaddr() twice in es(4).

Whitespace nits.
 1.63  26-Aug-2007  dyoung branches: 1.63.2;
Constify: LLADDR -> CLLADDR. I'm aiming here to make it easier to
identify sockaddr_dl abuse that remains in the kernel, especially
the potential for overwriting memory past the end of a sockaddr_dl
with, e.g., memcpy(LLADDR(), ...).
 1.62  04-Mar-2007  sketch branches: 1.62.2; 1.62.10; 1.62.14;
Put unformatted firmware version output behind IWI_DEBUG
 1.61  04-Mar-2007  christos Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
 1.60  23-Jan-2007  skrll branches: 1.60.2;
Pass the right pointer to firmware_free.

Fixes the DIAGNOSTIC panic reported by Sverre Froyen on current-users.
 1.59  20-Dec-2006  skrll - Upgrade to the latest firmware and as a result remove the error log dump.
- Mostly sync with OpenBSD
- Serialise sending commands to the firmware
- Remove redundant calls to bpfdetach.
- use bus_size_t where appropriate and not fetch iobase as it's not
used.
- improve 802.11 radiotap support (correct rx rate)
- add short preamble flag
- add short slot time support
- ignore parity errors (as per the Linux driver)
- Set Tx power for all channels.
- disable bluetooth co-existance
- Check that ni->ni_rates.rs_nrates is not greater than the maximum
handled by the firmware.
- Begin syncing with the FreeBSD driver by renaming a few things.
 1.58  16-Nov-2006  christos branches: 1.58.2;
__unused removal on arguments; approved by core.
 1.57  12-Oct-2006  christos - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
 1.56  24-Sep-2006  jmcneill Add "name" parameter to powerhook_establish, to aid debugging. No objections
on tech-kern@
 1.55  30-Aug-2006  christos branches: 1.55.2; 1.55.4;
fix initializers.
 1.54  19-Aug-2006  skrll Add some sysctl knobs to bring us closer to the FreeBSD driver.

Also sysctl enable the debug message printing (if IWI_DEBUG) is defined.
 1.53  09-Aug-2006  skrll s/printf/aprint_error/ for one message.
 1.52  09-Aug-2006  skrll Adapt iwi(4) to use firmload(9) and remove firmware loading from
iwictl(8).
 1.51  21-Jul-2006  ad - Use the LWP cached credentials where sane.
- Minor cosmetic changes.
 1.50  17-Jun-2006  christos re-factor the pci powestate api. reviewed by gimpy
 1.49  28-May-2006  blymn branches: 1.49.2;
Clean up bogus whitespace
 1.48  14-May-2006  elad branches: 1.48.2;
integrate kauth.
 1.47  11-Apr-2006  rpaulo Coverity ID 2442: check if one can dereference ifp before calling
iwi_stop() in iwi_detach().
 1.46  09-Mar-2006  jmcneill branches: 1.46.2;
Save and restore PCI configuration state on suspend/resume.
 1.45  21-Feb-2006  skrll branches: 1.45.2; 1.45.4;
Fix from Sam Leffler "correct check for whether wpa is enabled".
wpa_supplicant and static WEP doesn't crash the firmware now. YAY!
 1.44  24-Dec-2005  perry branches: 1.44.2; 1.44.4; 1.44.6;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
 1.43  05-Dec-2005  skrll Finally (I hope) fix iwi_ioctl:

- handle SIOCADDMULTI/SIOCDELMULTI properly, i.e. no need to reset
anything as we don't do multicast filters (yet)
- restructure some code and use an IS_RUNNING macro

Fix iwi_init to set if_flags before the net80211 state machine is kicked
and init to IEEE80211_S_INIT.
 1.42  29-Nov-2005  rpaulo Add support for software controlled LEDs as found on some
boards. Currently, only the associated LED is being used because
that's the only LED my card has. The other two LEDs (OFDM and
activity) can later be set by someone, easily, who owns some board
with that LEDs.

Reviewed by Nick Hudson.
 1.41  26-Nov-2005  skrll Fixes from Steve Woodford:

- add some missing bus_dmamap_sync operations.
- don't process other interrupts if we get an error/radio off
interrupt.
- improve command handling - sleep against the descriptor instead
of the descriptor set.
 1.40  23-Nov-2005  skrll Fix the handling of ENETRESET in iwi_ioctl.

This fixes PR 32143
 1.39  23-Nov-2005  skrll Correct a bpf tap.
 1.38  18-Nov-2005  skrll Resolve conflicts. Changelog to follow.
 1.37  14-Nov-2005  skrll branches: 1.37.2;
Don't use DPRINTF for previous. Doh!
 1.36  14-Nov-2005  skrll Dump the error log if we get an IWI_INTR_FATAL_ERROR interrupt.
 1.35  29-Oct-2005  scw Expunge an extraneous bus_dmamap_sync() call in iwi_frame_intr(). The entire
frame has already been sync'd by iwi_rx_intr().
 1.34  29-Oct-2005  scw - Use the DMA map size when calling bus_dmamap_sync(), instead of
blindly assuming MCLBYTES will DTRT.
- Use bus_dmamap_load_mbuf() instead of bus_dmamap_load() where
appropriate.
- If we have to coalesce a Tx mbuf chain comprised of more than IWI_MAX_NSEG
segments, allocate a cluster iff the payload won't fit in the header.
 1.33  29-Oct-2005  skrll Don't byte swap unnecessarily in iwi_read_prom_word. Fix the user instead.
 1.32  29-Oct-2005  scw Support big-endian hosts:
- Always byte-swap data read from EEPROM.
- Byte-swap firmware image when host is big-endian.

In iwi_tx_start():
- Fix descriptor initialisation bogon (only problematic on big-endian hosts).
- Fix bus_dmamap_sync() 'len' parameter..
 1.31  19-Oct-2005  joerg Fix a kernel segfault when a RX interrupt can't allocate a new mbuf.
The change adopts the idea of fxp to drop the incoming packet and panic
if the old mbuf cannot be reloaded. Since the bus_dmamap is allocated
during attach, this is not supposed to happen. Since a lot of code moves
anyway, factor out the allocation of RX ring elements, which is shared
between the init path and the RX interrupt path.

XXX A better fix might be to borrow the mbuf from the logic end of the
XXX ring buffer, but that needs more involved driver changes.

Reviewed by dyoung@ and nick@
 1.30  08-Oct-2005  skrll branches: 1.30.2;
Use the new scan command for monitor mode as well.
 1.29  29-Sep-2005  skrll Improve interrupt handling:

- don't disable/enable as we're already at splnet()
- ack the interrupts early

Fixes my "lost interrupt" problem.

Thanks to dyoung and scw for the suggestions.
 1.28  25-Sep-2005  skrll Whitespace and change a comment slightly.
 1.27  25-Sep-2005  skrll Don't try to bus_dmamem_alloc everytime we want to load the firmware as
it can fail all too easily. Instead bus_dmamap_load the cached copy and
create the command blocks for the device to load it accordingly.

Thanks to scw and mrg for reviewing this.

Closes PR 29892 (I hope).
 1.26  25-Sep-2005  skrll Support hidden ESSID APs.

Use the newer scan command as this one doesn't crash the firmware when
scanning 802.11a channels.

Thanks to scw and blymn for testing.

Closes PR 31295.
 1.25  25-Sep-2005  skrll Resolve conflicts.
 1.24  17-Sep-2005  skrll KNF. That is change u_intN_t to uintN_t.
 1.23  15-Sep-2005  skrll Correct a debug message.
 1.22  12-Sep-2005  skrll Fix spello.
 1.21  12-Sep-2005  skrll Use the correct length parameter when capturing rx packets.
 1.20  04-Sep-2005  skrll Re-organise a bit to reduce diff to FreeBSD.
 1.19  30-Aug-2005  skrll Let the net80211 layer handle the transition to INIT as well.

Testing by salo and me suggests that PR 31010 is fixed.
 1.18  30-Aug-2005  skrll Disestablish the power and shutdown hooks when detaching.
 1.17  30-Aug-2005  skrll KNF (and reduced diff to FreeBSD)
 1.16  27-Aug-2005  skrll Be explicit about which cards to setup .11a rates for.

hi matt.
 1.15  19-Aug-2005  skrll Add shutdown and power hooks.
 1.14  19-Aug-2005  skrll More sync with the FreeBSD driver.
 1.13  01-Aug-2005  skrll - Match more product ids.
- Don't initialise ic_phytype twice and do initialise ic_state.
- announce available rates.
- mark interface down if firmware crashes for the radio transmitter
gets turned off.
 1.12  30-Jul-2005  christos Partially fix. Now it comes up, associates with wep, but something is wrong
with tcp since it crashes in wep encryption when I cvs update.
 1.11  07-Jul-2005  dyoung Cosmetic: use the idiom &ic->ic_nw_keys[0] instead of ic->ic_nw_keys,
just be a little more parallel to &ic->ic_nw_keys[IEEE80211_WEP_NKID]
on the same line.
 1.10  25-Jun-2005  dyoung branches: 1.10.2;
Let ieee80211_input do WEP-decapsulation.

Make iwi(4) provide a key-allocator that returns valid indices for
the four global keys. Now net80211 should let the h/w do WEP
encryption/decryption.
 1.9  22-Jun-2005  dyoung Resolve conflicts in importation of 18-May-2005 ath(4) / net80211(9)
from FreeBSD. Introduce compatibility shims (sys/dev/ic/ath_netbsd.[ch],
sys/net80211/ieee80211_netbsd.[ch]). Update drivers (an, atu, atw,
awi, ipw, iwi, rtw, wi) for the new net80211(9) API.
 1.8  20-Jun-2005  sekiya Implement monitor mode. From OpenBSD.
 1.7  07-Jun-2005  skrll Sync with pcidevs changes.
 1.6  13-Apr-2005  mrg fix an error message: could -> could not
 1.5  27-Feb-2005  perry nuke trailing whitespace
 1.4  15-Jan-2005  skrll branches: 1.4.2; 1.4.4; 1.4.6;
Remove local PCI_PRODUCT defines
 1.3  11-Jan-2005  skrll Disable the debug stuff
 1.2  11-Jan-2005  skrll NetBSD RCSID
 1.1  11-Jan-2005  skrll branches: 1.1.1;
Initial revision
 1.1.1.3  18-Nov-2005  skrll Import FreeBSD's iwi(4) of 1-nov-2005
 1.1.1.2  25-Sep-2005  skrll Import of the FreeBSD sources from just after the net80211 merge. There
are no major changes, but this will make future merging easier.
 1.1.1.1  11-Jan-2005  skrll iwi(4) - Intel PRO/Wireless 2200AG/2915ABG driver.
Written by Damien Bergamini, from http://damien.bergamini.free.fr/ipw/

Ad-hoc mode and roaming are not fully implemented yet.
 1.4.6.1  19-Mar-2005  yamt sync with head. xen and whitespace. xen part is not finished.
 1.4.4.5  11-Dec-2005  christos Sync with head.
 1.4.4.4  10-Nov-2005  skrll Sync with HEAD. Here we go again...
 1.4.4.3  04-Mar-2005  skrll Sync with HEAD.

Hi Perry!
 1.4.4.2  17-Jan-2005  skrll Sync with HEAD.
 1.4.4.1  15-Jan-2005  skrll file if_iwi.c was added on branch ktrace-lwp on 2005-01-17 19:31:24 +0000
 1.4.2.1  29-Apr-2005  kent sync with -current
 1.10.2.8  24-Mar-2008  yamt sync with head.
 1.10.2.7  17-Mar-2008  yamt sync with head.
 1.10.2.6  21-Jan-2008  yamt sync with head
 1.10.2.5  27-Oct-2007  yamt sync with head.
 1.10.2.4  03-Sep-2007  yamt sync with head.
 1.10.2.3  26-Feb-2007  yamt sync with head.
 1.10.2.2  30-Dec-2006  yamt sync with head.
 1.10.2.1  21-Jun-2006  yamt sync with head.
 1.30.2.2  02-Nov-2005  yamt sync with head.
 1.30.2.1  26-Oct-2005  yamt sync with head
 1.37.2.3  29-Nov-2005  yamt sync with head.
 1.37.2.2  22-Nov-2005  yamt sync with head.
 1.37.2.1  14-Nov-2005  yamt file if_iwi.c was added on branch yamt-readahead on 2005-11-22 16:08:11 +0000
 1.44.6.2  01-Jun-2006  kardel Sync with head.
 1.44.6.1  22-Apr-2006  simonb Sync with head.
 1.44.4.1  09-Sep-2006  rpaulo sync with head
 1.44.2.1  01-Mar-2006  yamt sync with head.
 1.45.4.4  06-May-2006  christos - Move kauth_cred_t declaration to <sys/types.h>
- Cleanup struct ucred; forward declarations that are unused.
- Don't include <sys/kauth.h> in any header, but include it in the c files
that need it.

Approved by core.
 1.45.4.3  19-Apr-2006  elad sync with head.
 1.45.4.2  10-Mar-2006  elad generic_authorize() -> kauth_authorize_generic().
 1.45.4.1  08-Mar-2006  elad Adapt to kernel authorization KPI.
 1.45.2.5  03-Sep-2006  yamt sync with head.
 1.45.2.4  11-Aug-2006  yamt sync with head
 1.45.2.3  26-Jun-2006  yamt sync with head.
 1.45.2.2  24-May-2006  yamt sync with head.
 1.45.2.1  13-Mar-2006  yamt sync with head.
 1.46.2.1  24-May-2006  tron Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.
 1.48.2.1  19-Jun-2006  chap Sync with head.
 1.49.2.1  13-Jul-2006  gdamore Merge from HEAD.
 1.55.4.3  21-Dec-2006  yamt sync with head.
 1.55.4.2  10-Dec-2006  yamt sync with head.
 1.55.4.1  22-Oct-2006  yamt sync with head
 1.55.2.3  01-Feb-2007  ad Sync with head.
 1.55.2.2  12-Jan-2007  ad Sync with head.
 1.55.2.1  18-Nov-2006  ad Sync with head.
 1.58.2.2  28-Jan-2007  tron Pull up following revision(s) (requested by skrll in ticket #385):
sys/dev/pci/if_iwi.c: revision 1.60
Pass the right pointer to firmware_free.
Fixes the DIAGNOSTIC panic reported by Sverre Froyen on current-users.
 1.58.2.1  29-Dec-2006  riz Pull up following revision(s) (requested by skrll in ticket #296):
sys/dev/pci/if_iwireg.h: revision 1.17
sys/dev/pci/if_iwi.c: revision 1.59
sys/dev/pci/if_iwivar.h: revision 1.13
- Upgrade to the latest firmware and as a result remove the error log dump.
- Mostly sync with OpenBSD
- Serialise sending commands to the firmware
- Remove redundant calls to bpfdetach.
- use bus_size_t where appropriate and not fetch iobase as it's not
used.
- improve 802.11 radiotap support (correct rx rate)
- add short preamble flag
- add short slot time support
- ignore parity errors (as per the Linux driver)
- Set Tx power for all channels.
- disable bluetooth co-existance
- Check that ni->ni_rates.rs_nrates is not greater than the maximum
handled by the firmware.
- Begin syncing with the FreeBSD driver by renaming a few things.
- Upgrade to the latest firmware and as a result remove the error log dump.
- Mostly sync with OpenBSD
- Serialise sending commands to the firmware
- Remove redundant calls to bpfdetach.
- use bus_size_t where appropriate and not fetch iobase as it's not
used.
- improve 802.11 radiotap support (correct rx rate)
- add short preamble flag
- add short slot time support
- ignore parity errors (as per the Linux driver)
- Set Tx power for all channels.
- disable bluetooth co-existance
- Check that ni->ni_rates.rs_nrates is not greater than the maximum
handled by the firmware.
- Begin syncing with the FreeBSD driver by renaming a few things.
 1.60.2.1  12-Mar-2007  rmind Sync with HEAD.
 1.62.14.7  08-Dec-2007  jmcneill Rename pnp(9) -> pmf(9), as requested by many.
 1.62.14.6  06-Nov-2007  joerg Refactor PNP API:
- Make suspend/resume directly a device functionality. It consists of
three layers (class logic, device logic, bus logic), all of them being
optional. This replaces D0/D3 transitions.
- device_is_active returns true if the device was not disabled and was
not suspended (even partially), device_is_enabled returns true if the
device was enabled.
- Change pnp_global_transition into pnp_system_suspend and
pnp_system_resume. Before running any suspend/resume handlers, check
that all currently attached devices support power management and bail
out otherwise. The latter is not done for the shutdown/panic case.
- Make the former bus-specific generic network handlers a class handler.
- Make PNP message like volume up/down/toogle PNP events. Each device
can register what events they are interested in and whether the handler
should be global or not.
- Introduce device_active API for devices to mark themselve in use from
either the system or the device. Use this to implement the idle handling
for audio and input devices. This is intended to replace most ad-hoc
watchdogs as well.
- Fix somes situations in which audio resume would lose mixer settings.
- Make USB host controllers better deal with suspend in the light of
shared interrupts.
- Flush filesystem cache on suspend.
- Flush disk caches on suspend. Put ATA disks into standby on suspend as
well.
- Adopt drivers to use the new PNP API.
- Fix a critical bug in the generic cardbus layer that made D0->D3
break.
- Fix ral(4) to set if_stop.
- Convert cbb(4) to the new PNP API.
- Apply the PCI Express SCI fix on resume again.
 1.62.14.5  26-Oct-2007  joerg Sync with HEAD.

Follow the merge of pmap.c on i386 and amd64 and move
pmap_init_tmp_pgtbl into arch/x86/x86/pmap.c. Modify the ACPI wakeup
code to restore CR4 before jumping back into kernel space as the large
page option might cover that.
 1.62.14.4  01-Oct-2007  joerg Extend device API by device_power_private and device_power_set_private.
The latter is a temporary mean until the pnp_register API itself is
overhault. This functions allow a generic power handler to store its
state independent of the driver.

Use this and revamp the PCI power handling. Pretty much all PCI devices
had power handlers that did the same thing, generalize this in
pci_generic_power_register/deregister and the handler. This interface
offers callbacks for the drivers to save and restore state on
transistions. After a long discussion with jmcneill@ it was considered
to be powerful enough until evidence is shown that devices can handle
D1/D2 with less code and higher speed than without the full
save/restore. The generic code is carefully written to handle device
without PCI-PM support and ensure that the correct registers are written
to when D3 loses all state.

Reimplement the generic PCI network device handling on
top of PCI generic power handling.

Introduce pci_disable_retry as used and implemented locally at least by
ath(4) and iwi(4). Use it in this drivers to restore behaviour from
before the introduction of generic PCI network handling.

Convert all PCI drivers that were using pnp_register to the new
framework. The only exception is vga(4) as it is commonly used as
console device. Add a note therein that this should be fixed later.
 1.62.14.3  03-Sep-2007  jmcneill Sync with HEAD.
 1.62.14.2  23-Aug-2007  joerg Introduce pci_net_generic_power, which should be enough for most
network drivers and be a good foundation for C&P for the rest.

For iwi(4), don't reset the PCI retry register again, pci_conf_restore
should take care of that already.

For bge(4), add a NetBSD style if_stop.
 1.62.14.1  21-Aug-2007  joerg Convert iwi(4) to pnp_register/pnp_deregister and drop explicit shutdown
hooks.
 1.62.10.1  03-Sep-2007  skrll Sync with HEAD.
 1.62.2.2  23-Oct-2007  ad Sync with head.
 1.62.2.1  09-Oct-2007  ad Sync with head.
 1.63.2.3  23-Mar-2008  matt sync with HEAD
 1.63.2.2  09-Jan-2008  matt sync with HEAD
 1.63.2.1  06-Nov-2007  matt sync with HEAD
 1.64.4.1  25-Oct-2007  bouyer Sync with HEAD.
 1.67.6.1  11-Dec-2007  yamt sync with head.
 1.67.4.1  26-Dec-2007  ad Sync with head.
 1.68.10.3  17-Jan-2009  mjf Sync with HEAD.
 1.68.10.2  29-Jun-2008  mjf Sync with HEAD.
 1.68.10.1  03-Apr-2008  mjf Sync with HEAD.
 1.68.6.1  24-Mar-2008  keiichi sync with head.
 1.72.8.1  18-Jun-2008  simonb Sync with head.
 1.72.6.1  23-Jun-2008  wrstuden Sync w/ -current. 34 merge conflicts to follow.
 1.72.4.5  11-Aug-2010  yamt sync with head.
 1.72.4.4  11-Mar-2010  yamt sync with head
 1.72.4.3  16-Sep-2009  yamt sync with head
 1.72.4.2  16-May-2009  yamt sync with head
 1.72.4.1  04-May-2009  yamt sync with head.
 1.72.2.1  17-Jun-2008  yamt sync with head.
 1.73.4.3  28-Apr-2009  skrll Sync with HEAD.
 1.73.4.2  03-Mar-2009  skrll Sync with HEAD.
 1.73.4.1  19-Jan-2009  skrll Sync with HEAD.
 1.73.2.1  13-Dec-2008  haad Update haad-dm branch to haad-dm-base2.
 1.74.2.4  29-Sep-2009  snj Pull up following revision(s) (requested by bouyer in ticket #1040):
sys/dev/pci/if_iwi.c: revision 1.79
make iwi_alloc_tx_ring() prototype match function declaration (shows up when
bus_addr_t != bus_size_t). Fix cast for 64bit paddr_t on i386.
 1.74.2.3  14-Jan-2009  snj branches: 1.74.2.3.4;
Pull up following revision(s) (requested by jmcneill in ticket #250):
sys/dev/pci/if_iwi.c: revision 1.78
sys/dev/pci/if_ipw.c: revision 1.45
Make the "EULA not accepted" message a bit more informative, now reads:
EULA not accepted; please see the <driver>(4) man page.
 1.74.2.2  10-Nov-2008  snj Pull up following revision(s) (requested by joerg in ticket #43):
sys/dev/pci/if_iwi.c: revision 1.77
Fix typo in fw name.
 1.74.2.1  09-Nov-2008  snj Pull up following revision(s) (requested by joerg in ticket #25):
sys/dev/pci/if_ipw.c: revision 1.44
sys/dev/pci/if_ipwvar.h: revision 1.14
sys/dev/pci/if_iwi.c: revision 1.76
sys/dev/pci/if_iwn.c: revision 1.26
Match image name with upstream distfiles.
 1.74.2.3.4.1  21-Apr-2010  matt sync to netbsd-5
 1.78.2.1  13-May-2009  jym Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.
 1.83.4.3  31-May-2011  rmind sync with head
 1.83.4.2  05-Mar-2011  rmind sync with head
 1.83.4.1  30-May-2010  rmind sync with head
 1.83.2.1  30-Apr-2010  uebayasi Sync with HEAD.
 1.85.4.1  08-Feb-2011  bouyer Sync with HEAD
 1.85.2.1  06-Jun-2011  jruoho Sync with HEAD.
 1.87.4.3  22-May-2014  yamt sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
 1.87.4.2  30-Oct-2012  yamt sync with head
 1.87.4.1  17-Apr-2012  yamt sync with head
 1.88.2.2  05-Apr-2012  mrg sync to latest -current.
 1.88.2.1  18-Feb-2012  mrg merge to -current.
 1.89.2.1  22-Mar-2012  riz Pull up following revision(s) (requested by nisimura in ticket #134):
sys/dev/pci/if_iwi.c: revision 1.90
Unbreak the endian issue in firmware header decoding. Comfirmed good and
running by a powerpc machine.
 1.91.2.3  03-Dec-2017  jdolecek update from HEAD
 1.91.2.2  20-Aug-2014  tls Rebase to HEAD as of a few days ago.
 1.91.2.1  23-Jun-2013  tls resync from head
 1.92.4.1  18-May-2014  rmind sync with head
 1.97.6.5  28-Aug-2017  skrll Sync with HEAD
 1.97.6.4  05-Feb-2017  skrll Sync with HEAD
 1.97.6.3  05-Oct-2016  skrll Sync with HEAD
 1.97.6.2  09-Jul-2016  skrll Sync with HEAD
 1.97.6.1  06-Apr-2015  skrll Sync with HEAD
 1.99.2.3  20-Mar-2017  pgoyette Sync with HEAD
 1.99.2.2  07-Jan-2017  pgoyette Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
 1.99.2.1  06-Aug-2016  pgoyette Sync with HEAD
 1.101.2.1  21-Apr-2017  bouyer Sync with HEAD
 1.103.2.2  21-Jun-2023  martin Pull up following revision(s) (requested by riastradh in ticket #1835):

sys/dev/pci/if_iwi.c: revision 1.117
sys/dev/raidframe/rf_netbsdkintf.c: revision 1.401
sys/dev/scsipi/ses.c: revision 1.52
sys/dev/isa/mcd.c: revision 1.121
(all via patch)

sys/dev: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.

I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
 1.103.2.1  10-Dec-2017  snj Pull up following revision(s) (requested by msaitoh in ticket #427):
sys/arch/amiga/dev/if_bah_zbus.c: 1.17
sys/arch/arm/broadcom/bcm53xx_eth.c: 1.30
sys/arch/powerpc/booke/dev/pq3etsec.c: 1.32
sys/arch/usermode/dev/if_veth.c: 1.9
sys/dev/ic/an.c: 1.66
sys/dev/ic/athn.c: 1.17
sys/dev/ic/atw.c: 1.162
sys/dev/ic/bwi.c: 1.33
sys/dev/ic/dwc_gmac.c: 1.41-1.42
sys/dev/ic/malo.c: 1.10
sys/dev/ic/rt2560.c: 1.31
sys/dev/ic/rt2661.c: 1.36
sys/dev/ic/rt2860.c: 1.29
sys/dev/ic/rtw.c: 1.127
sys/dev/ic/rtwvar.h: 1.46
sys/dev/ic/smc90cx6.c: 1.71
sys/dev/ic/smc90cx6var.h: 1.12
sys/dev/ic/wi.c: 1.244
sys/dev/pci/if_ipw.c: 1.66
sys/dev/pci/if_iwi.c: 1.104
sys/dev/pci/if_iwm.c: 1.76
sys/dev/pci/if_iwn.c: 1.86
sys/dev/pci/if_rtwn.c: 1.13
sys/dev/pci/if_wm.c: 1.541
sys/dev/pci/if_wpi.c: 1.79
sys/dev/pci/ixgbe/ixgbe.c: 1.106
sys/dev/pci/ixgbe/ixv.c: 1.73 via patch
sys/dev/pcmcia/if_malo_pcmcia.c: 1.15
sys/dev/scsipi/if_se.c: 1.95
sys/dev/usb/if_upl.c: 1.60
sys/net/if.c: 1.396
sys/net/if.h: 1.241
sys/net/if_arc.h: 1.23
sys/net/if_arcsubr.c: 1.78
sys/net/if_bridge.c: 1.136-1.137
sys/net/if_etherip.c: 1.39
sys/net/if_faith.c: 1.56
sys/net/if_gif.c: 1.131
sys/net/if_loop.c: 1.96
sys/net/if_mpls.c: 1.30
sys/net/if_pppoe.c: 1.129
sys/net/if_srt.c: 1.27
sys/net/if_stf.c: 1.102
sys/net/if_tap.c: 1.100
sys/net/if_vlan.c: 1.105
sys/netinet/ip_carp.c: 1.91
sys/rump/net/lib/libshmif/if_shmem.c: 1.73-1.74
sys/rump/net/lib/libvirtif/if_virt.c: 1.55-1.56
if_initalize() and if_attach() failed when resource allocation failed
(e.g. allocating softint). Without this change, it panics. It's bad because
resource shortage really occured when a lot of pseudo interface is created.
To avoid this problem, don't panic and change return value of if_initialize()
and if_attach() to int. Caller fanction will be recover from error cleanly by
checking the return value.
Return if bah_attach_subr() failed.
If if_attach() failed in the attach function, return.
- If if_initialize() failed in the attach function, free resources and return.
- Add some missing frees in bridge_clone_destroy().
- KNF
If error occured in bcmeth_ccb_attach(), free resources and return.
If error occured in pq3etsec_attach(), free resources and return.
If error occured in the attach function, free resources and return.
- If if_initialize() failed in athn_attach(), free resources and return.
- Add missing pmf_event_deregister() in athn_detach().
- Free resources correctly on some errors in atw_attach().
- Use apint*() insread of printf() in the attach function.
If if_initialize() failed in the attach function, return.
- If if_initialize() failed in the attach function, free resources and return.
- Add missing dwc_gmac_free_dma_rings() and mutex_destroy() when attach
failed.
- If if_initialize() failed in the attach function, free resources and return.
- ifp is always not NULL in iwi_detach(). Check correctly with ifp->if_softc.
- If if_initialize() failed in the attach function, free resources and return.
- Fix error path in the attach function correctly.
If if_initialize() failed in the attach function, free resources and return.
If if_attach() failed in the attach function, free resources and return.
- If if_initialize() failed in the attach function, free resources and return.
- KNF
- If if_attach() failed in the attach function, free resources and return.
- KNF
Fix compile error.
Fix compile error.
We don't need '&mii', but just 'mii' for mii_detach().
Don't free sc_rthash twice
 1.105.2.4  26-Dec-2018  pgoyette Sync with HEAD, resolve a few conflicts
 1.105.2.3  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)
 1.105.2.2  28-Jul-2018  pgoyette Sync with HEAD
 1.105.2.1  02-May-2018  pgoyette Synch with HEAD
 1.107.2.3  13-Apr-2020  martin Mostly merge changes from HEAD upto 20200411
 1.107.2.2  08-Apr-2020  martin Merge changes from current as of 20200406
 1.107.2.1  10-Jun-2019  christos Sync with HEAD
 1.111.4.1  03-Aug-2022  martin Pull up following revision(s) (requested by riastradh in ticket #1485):

sys/dev/pci/if_iwi.c: revision 1.117
sys/dev/raidframe/rf_netbsdkintf.c: revision 1.401
sys/dev/scsipi/ses.c: revision 1.52
sys/dev/isa/mcd.c: revision 1.121

sys/dev: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.

I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
 1.112.2.1  29-Feb-2020  ad Sync with head.
 1.114.8.2  17-Jun-2021  thorpej Sync w/ HEAD.
 1.114.8.1  13-May-2021  thorpej Sync with HEAD.
 1.120.10.1  02-Aug-2025  perseant Sync with HEAD

RSS XML Feed