History log of /src/sys/net80211/ieee80211_crypto_tkip.c |
Revision | | Date | Author | Comments |
1.18 |
| 24-Jun-2023 |
msaitoh | Fix typo in comment.
|
1.17 |
| 03-Nov-2020 |
mlelstv | Use kmem_* instead of malloc/free and use interrupt versions as the code can be called from interrupt.
|
1.16 |
| 19-Dec-2019 |
kamil | branches: 1.16.8; Avoid changing signedness bit with << 24 in ieee80211_crypto_tkip.c
Reported by <prlw1>
|
1.15 |
| 03-Sep-2018 |
riastradh | Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
|
1.14 |
| 19-Jan-2018 |
maxv | branches: 1.14.2; 1.14.4; Style, and check the return value of m_append.
|
1.13 |
| 17-Jan-2018 |
maxv | Style, and fix two pretty bad mistakes in the crypto functions:
* They call M_PREPEND, but don't pass the updated pointer back to the caller.
* They use memmove on the mbuf data, but they don't ensure that the area they touch is contiguous.
This fix is not complete, ieee80211_crypto_encap too needs to pass back the updated pointer. This will be done in another commit.
|
1.12 |
| 18-Oct-2014 |
snj | src is too big these days to tolerate superfluous apostrophes. It's "its", people!
|
1.11 |
| 03-Apr-2011 |
drochner | branches: 1.11.14; make michael_mic() robust against degenerate mbuf layouts like odd sizes in the middle of a chain
|
1.10 |
| 17-Dec-2008 |
cegger | branches: 1.10.6; 1.10.8; kill MALLOC and FREE macros.
|
1.9 |
| 26-Aug-2008 |
drochner | branches: 1.9.2; replace ths previous fix with a simpler one by Sam Leffler - it doesn't deal with odd lengths in the mbuf before the last one, but it is assumed that these don't occur in practice
|
1.8 |
| 19-Aug-2008 |
drochner | in michael_mic, handle the case where the last 4 bytes cross a mbuf boundary, fixes connection drops with WPA aka TKIP on dumb wireless adapters (tested with wpi)
|
1.7 |
| 16-Nov-2006 |
christos | branches: 1.7.46; 1.7.48; 1.7.52; 1.7.54; 1.7.58; __unused removal on arguments; approved by core.
|
1.6 |
| 12-Oct-2006 |
christos | - sprinkle __unused on function decls. - fix a couple of unused bugs - no more -Wno-unused for i386
|
1.5 |
| 16-Mar-2006 |
christos | branches: 1.5.10; 1.5.12; include if_ether.h if you want to use ether_sprintf()
|
1.4 |
| 18-Nov-2005 |
skrll | branches: 1.4.4; 1.4.6; 1.4.8; 1.4.10; Resolve conflicts and adapt to NetBSD.
Thanks to dyoung@, scw@, and perry@ for help testing.
2005-08-30 15:27 avatar
Properly set ic_curchan before calling back to device driver to do channel switching(ifconfig devX channel Y). This fix should make channel changing works again in monitor mode.
Submitted by: sam X-MFC-With: other ic_curchan changes
2005-08-13 18:50 sam
revert 1.64: we cannot use the channel characteristics to decide when to do 11g erp sta accounting because b/g channels show up as false positives when operating in 11b.
Noticed by: Michal Mertl
2005-08-13 18:31 sam
Extend acl support to pass ioctl requests through and use this to add support for getting the current policy setting and collecting the list of mac addresses in the acl table.
Submitted by: Michal Mertl (original version) MFC after: 2 weeks
2005-08-10 18:42 sam
Don't use ic_curmode to decide when to do 11g station accounting, use the station channel properties. Fixes assert failure/bogus operation when an ap is operating in 11a and has associated stations then switches to 11g.
Noticed by: Michal Mertl Reviewed by: avatar MFC after: 2 weeks
2005-08-10 17:22 sam
Clarify/fix handling of the current channel: o add ic_curchan and use it uniformly for specifying the current channel instead of overloading ic->ic_bss->ni_chan (or in some drivers ic_ibss_chan) o add ieee80211_scanparams structure to encapsulate scanning-related state captured for rx frames o move rx beacon+probe response frame handling into separate routines o change beacon+probe response handling to treat the scan table more like a scan cache--look for an existing entry before adding a new one; this combined with ic_curchan use corrects handling of stations that were previously found at a different channel o move adhoc neighbor discovery by beacon+probe response frames to a new ieee80211_add_neighbor routine
Reviewed by: avatar Tested by: avatar, Michal Mertl MFC after: 2 weeks
2005-08-09 11:19 rwatson
Propagate rename of IFF_OACTIVE and IFF_RUNNING to IFF_DRV_OACTIVE and IFF_DRV_RUNNING, as well as the move from ifnet.if_flags to ifnet.if_drv_flags. Device drivers are now responsible for synchronizing access to these flags, as they are in if_drv_flags. This helps prevent races between the network stack and device driver in maintaining the interface flags field.
Many __FreeBSD__ and __FreeBSD_version checks maintained and continued; some less so.
Reviewed by: pjd, bz MFC after: 7 days
2005-08-08 19:46 sam
Split crypto tx+rx key indices and add a key index -> node mapping table:
Crypto changes: o change driver/net80211 key_alloc api to return tx+rx key indices; a driver can leave the rx key index set to IEEE80211_KEYIX_NONE or set it to be the same as the tx key index (the former disables use of the key index in building the keyix->node mapping table and is the default setup for naive drivers by null_key_alloc) o add cs_max_keyid to crypto state to specify the max h/w key index a driver will return; this is used to allocate the key index mapping table and to bounds check table loookups o while here introduce ieee80211_keyix (finally) for the type of a h/w key index o change crypto notifiers for rx failures to pass the rx key index up as appropriate (michael failure, replay, etc.)
Node table changes: o optionally allocate a h/w key index to node mapping table for the station table using the max key index setting supplied by drivers (note the scan table does not get a map) o defer node table allocation to lateattach so the driver has a chance to set the max key id to size the key index map o while here also defer the aid bitmap allocation o add new ieee80211_find_rxnode_withkey api to find a sta/node entry on frame receive with an optional h/w key index to use in checking mapping table; also updates the map if it does a hash lookup and the found node has a rx key index set in the unicast key; note this work is separated from the old ieee80211_find_rxnode call so drivers do not need to be aware of the new mechanism o move some node table manipulation under the node table lock to close a race on node delete o add ieee80211_node_delucastkey to do the dirty work of deleting unicast key state for a node (deletes any key and handles key map references)
Ath driver: o nuke private sc_keyixmap mechansim in favor of net80211 support o update key alloc api
These changes close several race conditions for the ath driver operating in ap mode. Other drivers should see no change. Station mode operation for ath no longer uses the key index map but performance tests show no noticeable change and this will be fixed when the scan table is eliminated with the new scanning support.
Tested by: Michal Mertl, avatar, others Reviewed by: avatar, others MFC after: 2 weeks
2005-08-08 06:49 sam
use ieee80211_iterate_nodes to retrieve station data; the previous code walked the list w/o locking
MFC after: 1 week
2005-08-08 04:30 sam
Cleanup beacon/listen interval handling: o separate configured beacon interval from listen interval; this avoids potential use of one value for the other (e.g. setting powersavesleep to 0 clobbers the beacon interval used in hostap or ibss mode) o bounds check the beacon interval received in probe response and beacon frames and drop frames with bogus settings; not clear if we should instead clamp the value as any alteration would result in mismatched sta+ap configuration and probably be more confusing (don't want to log to the console but perhaps ok with rate limiting) o while here up max beacon interval to reflect WiFi standard
Noticed by: Martin <nakal@nurfuerspam.de> MFC after: 1 week
2005-08-06 05:57 sam
fix debug msg typo
MFC after: 3 days
2005-08-06 05:56 sam
Fix handling of frames sent prior to a station being authorized when operating in ap mode. Previously we allocated a node from the station table, sent the frame (using the node), then released the reference that "held the frame in the table". But while the frame was in flight the node might be reclaimed which could lead to problems. The solution is to add an ieee80211_tmp_node routine that crafts a node that does exist in a table and so isn't ever reclaimed; it exists only so long as the associated frame is in flight.
MFC after: 5 days
2005-07-31 07:12 sam
close a race between reclaiming a node when a station is inactive and sending the null data frame used to probe inactive stations
MFC after: 5 days
2005-07-27 05:41 sam
when bridging internally bypass the bss node as traffic to it must follow the normal input path
Submitted by: Michal Mertl MFC after: 5 days
2005-07-27 03:53 sam
bandaid ni_fails handling so ap's with association failures are reconsidered after a bit; a proper fix involves more changes to the scanning infrastructure
Reviewed by: avatar, David Young MFC after: 5 days
2005-07-23 01:16 sam
the AREF flag is only meaningful in ap mode; adhoc neighbors now are timed out of the sta/neighbor table
2005-07-23 00:25 sam
o move inactivity-related debug msgs under IEEE80211_MSG_INACT o probe inactive neighbors in adhoc mode (they don't have an association id so previously were being timed out)
MFC after: 3 days
2005-07-22 22:11 sam
split xmit of probe request frame out into a separate routine that takes explicit parameters; this will be needed when scanning is decoupled from the state machine to do bg scanning
MFC after: 3 days
2005-07-22 21:48 sam
split 802.11 frame xmit setup code into ieee80211_send_setup
MFC after: 3 days
2005-07-22 18:57 sam
simplify ic_newassoc callback
MFC after: 3 days
2005-07-22 18:54 sam
simplify ieee80211_ibss_merge api
MFC after: 3 days
2005-07-22 18:50 sam
add stats we know we'll need soon and some spare fields for future expansion
MFC after: 3 days
2005-07-22 18:45 sam
simplify tim callback api
MFC after: 3 days
2005-07-22 18:42 sam
don't include 802.3 header in min frame length calculation as it may not be present for a frag; fixes problem with small (fragmented) frames being dropped
Obtained from: Atheros MFC after: 3 days
2005-07-22 18:36 sam
simplify ieee80211_node_authorize and ieee80211_node_unauthorize api's
MFC after: 3 days
2005-07-22 18:31 sam
simplifiy ieee80211_send_nulldata api
MFC after: 3 days
2005-07-22 18:29 sam
simplify rate set api's by removing ic parameter (implicit in node reference)
MFC after: 3 days
2005-07-22 18:21 sam
reject association requests with a wpa/rsn ie when wpa/rsn is not configured on the ap; previously we either ignored the ie or (possibly) failed an assertion
Obtained from: Atheros MFC after: 3 days
2005-07-22 18:16 sam
missed one in last commit; add device name to discard msgs
2005-07-22 18:13 sam
include device name in discard msgs
2005-07-22 18:12 sam
add diag msgs for frames discarded because the direction field is wrong
2005-07-22 18:08 sam
split data frame delivery out to a new function ieee80211_deliver_data
2005-07-22 18:00 sam
o add IEEE80211_IOC_FRAGTHRESHOLD for getting+setting the tx fragmentation threshold o fix bounds checking on IEEE80211_IOC_RTSTHRESHOLD
MFC after: 3 days
2005-07-22 17:55 sam
o add IEEE80211_FRAG_DEFAULT o move default settings for RTS and frag thresholds to ieee80211_var.h
2005-07-22 17:50 sam
diff reduction against p4: define IEEE80211_FIXED_RATE_NONE and use it instead of -1
2005-07-22 17:37 sam
add flags missed in last merge
2005-07-22 17:36 sam
Diff reduction against p4: o add ic_flags_ext for eventual extention of ic_flags o define/reserve flag+capabilities bits for superg, bg scan, and roaming support o refactor debug msg macros
MFC after: 3 days
2005-07-22 06:17 sam
send a response when an auth request is denied due to an acl; might be better to silently ignore the frame but this way we give stations a chance of figuring out what's wrong
2005-07-22 06:15 sam
remove excess whitespace
2005-07-22 05:55 sam
use IF_HANDOFF when bridging frames internally so if_start gets called; fixes communication between associated sta's
MFC after: 3 days
2005-07-11 04:06 sam
Handle encrypt of arbitarily fragmented mbuf chains: previously we bailed if we couldn't collect the 16-bytes of data required for an aes block cipher in 2 mbufs; now we deal with it. While here make space accounting signed so a sanity check does the right thing for malformed mbuf chains.
Approved by: re (scottl)
2005-07-11 04:00 sam
nuke assert that duplicates real check
Reviewed by: avatar Approved by: re (scottl)
|
1.3 |
| 26-Jul-2005 |
dyoung | branches: 1.3.6; 1.3.8; Resolve conflicts.
|
1.2 |
| 22-Jun-2005 |
dyoung | branches: 1.2.2; Resolve conflicts in importation of 18-May-2005 ath(4) / net80211(9) from FreeBSD. Introduce compatibility shims (sys/dev/ic/ath_netbsd.[ch], sys/net80211/ieee80211_netbsd.[ch]). Update drivers (an, atu, atw, awi, ipw, iwi, rtw, wi) for the new net80211(9) API.
|
1.1 |
| 21-Jun-2005 |
dyoung | branches: 1.1.1; Initial revision
|
1.1.1.3 |
| 18-Nov-2005 |
skrll | Import FreeBSD's net80211(9) of 1-nov-2005
|
1.1.1.2 |
| 26-Jul-2005 |
dyoung | Import FreeBSD's net80211(9) of 2005-07-11
|
1.1.1.1 |
| 21-Jun-2005 |
dyoung | Import FreeBSD's net80211(9) of 2005-05-18
|
1.2.2.1 |
| 21-Jun-2006 |
yamt | sync with head.
|
1.3.8.1 |
| 22-Nov-2005 |
yamt | sync with head.
|
1.3.6.3 |
| 11-Dec-2005 |
christos | Sync with head.
|
1.3.6.2 |
| 10-Nov-2005 |
skrll | Sync with HEAD. Here we go again...
|
1.3.6.1 |
| 26-Jul-2005 |
skrll | file ieee80211_crypto_tkip.c was added on branch ktrace-lwp on 2005-11-10 14:10:51 +0000
|
1.4.10.1 |
| 19-Apr-2006 |
elad | sync with head.
|
1.4.8.1 |
| 01-Apr-2006 |
yamt | sync with head.
|
1.4.6.1 |
| 22-Apr-2006 |
simonb | Sync with head.
|
1.4.4.1 |
| 09-Sep-2006 |
rpaulo | sync with head
|
1.5.12.2 |
| 10-Dec-2006 |
yamt | sync with head.
|
1.5.12.1 |
| 22-Oct-2006 |
yamt | sync with head
|
1.5.10.1 |
| 18-Nov-2006 |
ad | Sync with head.
|
1.7.58.1 |
| 19-Oct-2008 |
haad | Sync with HEAD.
|
1.7.54.1 |
| 18-Sep-2008 |
wrstuden | Sync with wrstuden-revivesa-base-2.
|
1.7.52.1 |
| 04-May-2009 |
yamt | sync with head.
|
1.7.48.2 |
| 17-Jan-2009 |
mjf | Sync with HEAD.
|
1.7.48.1 |
| 28-Sep-2008 |
mjf | Sync with HEAD.
|
1.7.46.1 |
| 22-Feb-2008 |
skrll | Beginning of a sync with net80211 from FreeBSD. Lots to do.
Sources taken from 2008-02-22.
|
1.9.2.1 |
| 19-Jan-2009 |
skrll | Sync with HEAD.
|
1.10.8.1 |
| 06-Jun-2011 |
jruoho | Sync with HEAD.
|
1.10.6.1 |
| 21-Apr-2011 |
rmind | sync with head
|
1.11.14.1 |
| 03-Dec-2017 |
jdolecek | update from HEAD
|
1.14.4.5 |
| 08-Apr-2020 |
martin | Merge changes from current as of 20200406
|
1.14.4.4 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
1.14.4.3 |
| 16-Jul-2018 |
phil | State save. urtwn now can attach and shows up in the "ifconfig -a" list.
|
1.14.4.2 |
| 12-Jul-2018 |
phil | State save. New kernel config for this brach only. TESTWIFI does produce a kernel. It is not working. athn files not compiling yet and commented out of the TESTWIFI kernel, which only has urtwn 802.11 driver enabled. ieee80211_alq.c and ieee80211_ddb.c not compiling yet.
|
1.14.4.1 |
| 28-Jun-2018 |
phil | Start of WiFi refresh. Copy of FreeBSD net80211 directory with git mirror commit id of 09e3123164ec345822e00465039503686efde455, no changes yet. ieee80211_netbsd.[ch] from ieee80211_freebsd.[ch].
|
1.14.2.1 |
| 06-Sep-2018 |
pgoyette | Sync with HEAD
Resolve a couple of conflicts (result of the uimin/uimax changes)
|
1.16.8.1 |
| 14-Dec-2020 |
thorpej | Sync w/ HEAD.
|