cond-short.mk revision 1.12 1 1.12 rillig # $NetBSD: cond-short.mk,v 1.12 2020/11/15 14:58:14 rillig Exp $
2 1.1 rillig #
3 1.1 rillig # Demonstrates that in conditions, the right-hand side of an && or ||
4 1.2 rillig # is only evaluated if it can actually influence the result.
5 1.12 rillig # This is called 'short-circuit evaluation' and is the usual evaluation
6 1.12 rillig # mode in most programming languages. A notable exception is Ada, which
7 1.12 rillig # distinguishes between the operators 'And', 'And Then', 'Or', 'Or Else'.
8 1.1 rillig #
9 1.2 rillig # Between 2015-10-11 and 2020-06-28, the right-hand side of an && or ||
10 1.2 rillig # operator was always evaluated, which was wrong.
11 1.12 rillig # TODO: Had the evaluation been correct at some time before 2015-11-12?
12 1.2 rillig
13 1.2 rillig # The && operator.
14 1.1 rillig
15 1.1 rillig .if 0 && ${echo "unexpected and" 1>&2 :L:sh}
16 1.1 rillig .endif
17 1.1 rillig
18 1.1 rillig .if 1 && ${echo "expected and" 1>&2 :L:sh}
19 1.1 rillig .endif
20 1.1 rillig
21 1.2 rillig .if 0 && exists(nonexistent${echo "unexpected and exists" 1>&2 :L:sh})
22 1.2 rillig .endif
23 1.2 rillig
24 1.2 rillig .if 1 && exists(nonexistent${echo "expected and exists" 1>&2 :L:sh})
25 1.2 rillig .endif
26 1.2 rillig
27 1.2 rillig .if 0 && empty(${echo "unexpected and empty" 1>&2 :L:sh})
28 1.2 rillig .endif
29 1.2 rillig
30 1.2 rillig .if 1 && empty(${echo "expected and empty" 1>&2 :L:sh})
31 1.2 rillig .endif
32 1.2 rillig
33 1.4 rillig # "VAR U11" is not evaluated; it was evaluated before 2020-07-02.
34 1.4 rillig # The whole !empty condition is only parsed and then discarded.
35 1.3 rillig VAR= ${VAR${:U11${echo "unexpected VAR U11" 1>&2 :L:sh}}}
36 1.3 rillig VAR13= ${VAR${:U12${echo "unexpected VAR13" 1>&2 :L:sh}}}
37 1.3 rillig .if 0 && !empty(VAR${:U13${echo "unexpected U13 condition" 1>&2 :L:sh}})
38 1.3 rillig .endif
39 1.3 rillig
40 1.3 rillig VAR= ${VAR${:U21${echo "unexpected VAR U21" 1>&2 :L:sh}}}
41 1.3 rillig VAR23= ${VAR${:U22${echo "expected VAR23" 1>&2 :L:sh}}}
42 1.3 rillig .if 1 && !empty(VAR${:U23${echo "expected U23 condition" 1>&2 :L:sh}})
43 1.3 rillig .endif
44 1.5 rillig VAR= # empty again, for the following tests
45 1.3 rillig
46 1.5 rillig # The :M modifier is only parsed, not evaluated.
47 1.5 rillig # Before 2020-07-02, it was wrongly evaluated.
48 1.4 rillig .if 0 && !empty(VAR:M${:U${echo "unexpected M pattern" 1>&2 :L:sh}})
49 1.4 rillig .endif
50 1.4 rillig
51 1.5 rillig .if 1 && !empty(VAR:M${:U${echo "expected M pattern" 1>&2 :L:sh}})
52 1.5 rillig .endif
53 1.5 rillig
54 1.6 rillig .if 0 && !empty(VAR:S,from,${:U${echo "unexpected S modifier" 1>&2 :L:sh}},)
55 1.6 rillig .endif
56 1.6 rillig
57 1.6 rillig .if 0 && !empty(VAR:C,from,${:U${echo "unexpected C modifier" 1>&2 :L:sh}},)
58 1.6 rillig .endif
59 1.6 rillig
60 1.6 rillig .if 0 && !empty("" == "" :? ${:U${echo "unexpected ? modifier" 1>&2 :L:sh}} :)
61 1.6 rillig .endif
62 1.6 rillig
63 1.6 rillig .if 0 && !empty(VAR:old=${:U${echo "unexpected = modifier" 1>&2 :L:sh}})
64 1.6 rillig .endif
65 1.6 rillig
66 1.6 rillig .if 0 && !empty(1 2 3:L:@var@${:U${echo "unexpected @ modifier" 1>&2 :L:sh}}@)
67 1.6 rillig .endif
68 1.6 rillig
69 1.6 rillig .if 0 && !empty(:U${:!echo "unexpected exclam modifier" 1>&2 !})
70 1.6 rillig .endif
71 1.6 rillig
72 1.8 rillig # Irrelevant assignment modifiers are skipped as well.
73 1.8 rillig .if 0 && ${1 2 3:L:@i@${FIRST::?=$i}@}
74 1.8 rillig .endif
75 1.8 rillig .if 0 && ${1 2 3:L:@i@${LAST::=$i}@}
76 1.8 rillig .endif
77 1.8 rillig .if 0 && ${1 2 3:L:@i@${APPENDED::+=$i}@}
78 1.8 rillig .endif
79 1.8 rillig .if 0 && ${echo.1 echo.2 echo.3:L:@i@${RAN::!=${i:C,.*,&; & 1>\&2,:S,., ,g}}@}
80 1.8 rillig .endif
81 1.8 rillig .if defined(FIRST) || defined(LAST) || defined(APPENDED) || defined(RAN)
82 1.10 rillig . warning first=${FIRST} last=${LAST} appended=${APPENDED} ran=${RAN}
83 1.8 rillig .endif
84 1.8 rillig
85 1.2 rillig # The || operator.
86 1.2 rillig
87 1.1 rillig .if 1 || ${echo "unexpected or" 1>&2 :L:sh}
88 1.1 rillig .endif
89 1.1 rillig
90 1.1 rillig .if 0 || ${echo "expected or" 1>&2 :L:sh}
91 1.1 rillig .endif
92 1.1 rillig
93 1.2 rillig .if 1 || exists(nonexistent${echo "unexpected or exists" 1>&2 :L:sh})
94 1.2 rillig .endif
95 1.2 rillig
96 1.2 rillig .if 0 || exists(nonexistent${echo "expected or exists" 1>&2 :L:sh})
97 1.2 rillig .endif
98 1.2 rillig
99 1.2 rillig .if 1 || empty(${echo "unexpected or empty" 1>&2 :L:sh})
100 1.2 rillig .endif
101 1.2 rillig
102 1.2 rillig .if 0 || empty(${echo "expected or empty" 1>&2 :L:sh})
103 1.2 rillig .endif
104 1.2 rillig
105 1.2 rillig # Unreachable nested conditions are skipped completely as well.
106 1.1 rillig
107 1.1 rillig .if 0
108 1.1 rillig . if ${echo "unexpected nested and" 1>&2 :L:sh}
109 1.1 rillig . endif
110 1.1 rillig .endif
111 1.1 rillig
112 1.1 rillig .if 1
113 1.1 rillig .elif ${echo "unexpected nested or" 1>&2 :L:sh}
114 1.1 rillig .endif
115 1.1 rillig
116 1.7 sjg # make sure these do not cause complaint
117 1.7 sjg #.MAKEFLAGS: -dc
118 1.7 sjg
119 1.12 rillig # TODO: Rewrite this whole section and check all the conditions and variables.
120 1.12 rillig # Several of the assumptions are probably wrong here.
121 1.12 rillig # TODO: replace 'x=' with '.info' or '.error'.
122 1.11 rillig V42= 42
123 1.11 rillig iV1= ${V42}
124 1.11 rillig iV2= ${V66}
125 1.7 sjg
126 1.7 sjg .if defined(V42) && ${V42} > 0
127 1.11 rillig x= Ok
128 1.7 sjg .else
129 1.11 rillig x= Fail
130 1.7 sjg .endif
131 1.11 rillig x!= echo 'defined(V42) && ${V42} > 0: $x' >&2; echo
132 1.9 rillig
133 1.7 sjg # this one throws both String comparison operator and
134 1.7 sjg # Malformed conditional with cond.c 1.78
135 1.7 sjg # indirect iV2 would expand to "" and treated as 0
136 1.7 sjg .if defined(V66) && ( ${iV2} < ${V42} )
137 1.11 rillig x= Fail
138 1.7 sjg .else
139 1.11 rillig x= Ok
140 1.7 sjg .endif
141 1.11 rillig x!= echo 'defined(V66) && ( "${iV2}" < ${V42} ): $x' >&2; echo
142 1.9 rillig
143 1.7 sjg # next two thow String comparison operator with cond.c 1.78
144 1.7 sjg # indirect iV1 would expand to 42
145 1.7 sjg .if 1 || ${iV1} < ${V42}
146 1.11 rillig x= Ok
147 1.7 sjg .else
148 1.11 rillig x= Fail
149 1.7 sjg .endif
150 1.11 rillig x!= echo '1 || ${iV1} < ${V42}: $x' >&2; echo
151 1.9 rillig
152 1.7 sjg .if 1 || ${iV2:U2} < ${V42}
153 1.11 rillig x= Ok
154 1.7 sjg .else
155 1.11 rillig x= Fail
156 1.7 sjg .endif
157 1.11 rillig x!= echo '1 || ${iV2:U2} < ${V42}: $x' >&2; echo
158 1.9 rillig
159 1.7 sjg # the same expressions are fine when the lhs is expanded
160 1.7 sjg # ${iV1} expands to 42
161 1.7 sjg .if 0 || ${iV1} <= ${V42}
162 1.11 rillig x= Ok
163 1.7 sjg .else
164 1.11 rillig x= Fail
165 1.7 sjg .endif
166 1.11 rillig x!= echo '0 || ${iV1} <= ${V42}: $x' >&2; echo
167 1.9 rillig
168 1.7 sjg # ${iV2:U2} expands to 2
169 1.7 sjg .if 0 || ${iV2:U2} < ${V42}
170 1.11 rillig x= Ok
171 1.7 sjg .else
172 1.11 rillig x= Fail
173 1.7 sjg .endif
174 1.11 rillig x!= echo '0 || ${iV2:U2} < ${V42}: $x' >&2; echo
175 1.7 sjg
176 1.12 rillig # TODO: Has this always worked? There may have been a time, maybe around
177 1.12 rillig # 2000, when make would complain about the "Malformed conditional" because
178 1.12 rillig # UNDEF is not defined.
179 1.12 rillig .if defined(UNDEF) && ${UNDEF} != "undefined"
180 1.12 rillig . error
181 1.12 rillig .endif
182 1.12 rillig
183 1.12 rillig # TODO: Test each modifier to make sure it is skipped when it is irrelevant
184 1.12 rillig # for the result. Since this test is already quite long, do that in another
185 1.12 rillig # test.
186 1.12 rillig
187 1.1 rillig all:
188 1.1 rillig @:;:
189