1 commit adf389fc19aedbf1be077b05365d164cd6f463d8 2 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 3 Date: Fri Dec 13 13:31:30 2024 -0800 4 5 libICE 1.1.2 6 7 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 8 9 commit 6cea89b54964e756bc3fdebf3da42db2711785c7 10 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 11 Date: Sat Nov 16 16:40:31 2024 -0800 12 13 ProcessAuthReply: Handle -Wconditional-uninitialized warning 14 15 Clears warning from clang 13: 16 17 process.c:1612:21: warning: variable 'authDataLen' may be uninitialized 18 when used here [-Wconditional-uninitialized] 19 if (authData && authDataLen > 0) 20 ^~~~~~~~~~~ 21 process.c:1344:22: note: initialize the variable 'authDataLen' to 22 silence this warning 23 int authDataLen; 24 ^ 25 = 0 26 27 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 28 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/23> 29 30 commit 4f7f5b10fa5e328a6bfa83a0411cb6b8bf44b49d 31 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 32 Date: Sat Nov 16 16:17:12 2024 -0800 33 34 ICElibint.h: add do ... while (0) around macro definitions 35 36 Clears 71 warnings from clang 13 of the form: 37 38 connect.c:351:39: warning: empty expression statement has no effect; 39 remove unnecessary ';' to silence this warning [-Wextra-semi-stmt] 40 STORE_STRING (pData, IceVendorString); 41 ^ 42 43 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 44 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/23> 45 46 commit a767164a8e4467a5faa1265536f05a4bea8f8df0 47 Author: mahendra <mahendra.n (a] samsung.com> 48 Date: Tue Nov 10 14:01:39 2015 +0530 49 50 libICE : Dereferencing a possible NULL pointer in error.c 51 52 In function _IceErrorSetupFailed at line no 188, IceAllocScratch is used to 53 allocate memory for variable pStart and pBuf. 54 55 IceAllocScratch is using malloc for memory allocation, malloc can return 56 NULL on failure. So before dereferencing pStart and pBuf, NULL check must 57 apply. 58 59 v2 (by alanc): correct inverted tests for NULL from original patch 60 61 Closes: #5 62 Signed-off-by: mahendra <mahendra.n (a] samsung.com> 63 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 64 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/22> 65 66 commit 3ea01ff303843b13ffa18bc8207d4f41631ea66c 67 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 68 Date: Sat Nov 9 08:07:37 2024 -0800 69 70 write_counted_string: avoid undefined behavior in fwrite() call 71 72 In C23 and earlier, it is undefined behavior to call fwrite() with a 73 NULL pointer, even if the size to copy is zero bytes. 74 75 Closes: #11 76 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 77 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/21> 78 79 commit cea5bb04617449756994a999ff258884aac802d1 80 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 81 Date: Fri Nov 8 11:52:26 2024 -0800 82 83 AuthRequired: avoid undefined behavior in memcpy() call 84 85 In C23 and earlier, it is undefined behavior to call memcpy() with a 86 NULL pointer, even if the size to copy is zero bytes. 87 88 Closes: #10 89 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 90 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/20> 91 92 commit 296eff6b5f9ce0b2147c14ac96fea3bb2de37d70 93 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 94 Date: Sun Aug 25 10:50:47 2024 -0700 95 96 IceRegisterForProtocolSetup: return failure if malloc() failed 97 98 Clears warning from gcc 14.1: 99 100 register.c: In function IceRegisterForProtocolSetup: 101 register.c:92:15: warning: dereference of possibly-NULL p [CWE-690] 102 [-Wanalyzer-possible-null-dereference] 103 92 | p->vendor = strdup(vendor); 104 | ~~~~~~~~~~^~~~~~~~~~~~~~~~ 105 106 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 107 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 108 109 commit fafdde691754159c586d95c87d090afcf306ca4d 110 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 111 Date: Sun Aug 25 10:34:50 2024 -0700 112 113 IceProtocolSetup: return failure if malloc() failed for authIndices 114 115 Clears warning from gcc 14.1: 116 117 protosetup.c: In function IceProtocolSetup: 118 protosetup.c:178:24: warning: dereference of NULL authIndices [CWE-476] 119 [-Wanalyzer-null-dereference] 120 178 | authIndices[i]]); 121 | ~~~~~~~~~~~^~~ 122 ICElibint.h:179:36: note: in definition of macro STORE_STRING 123 179 | CARD16 _len = (CARD16) strlen (_string); \ 124 | ^~~~~~~ 125 IceProtocolSetup: events 1-8 126 127 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 128 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 129 130 commit b9c70bd2537bcb591135b8dc79ace7115c608ca7 131 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 132 Date: Sun Aug 25 10:24:21 2024 -0700 133 134 ProcessProtocolSetup: return failure if malloc() failed for ProtocolName 135 136 Clears warning from gcc 14.1: 137 138 process.c: In function ProcessProtocolSetup: 139 process.c:1956:56: warning: use of NULL protocolName where non-null 140 expected [CWE-476] [-Wanalyzer-null-argument] 141 1956 | if (iceConn->process_msg_info[i].in_use && strcmp (protocolName, 142 | ^~~~~~~~~~~~~~~~~~~~ 143 1957 | iceConn->process_msg_info[i].protocol->protocol_name) == 0) 144 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 145 146 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 147 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 148 149 commit b25db77dba416c6684b3130f007a13d762033ebd 150 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 151 Date: Sun Aug 25 10:12:47 2024 -0700 152 153 ProcessConnectionSetup: avoid writing to NULL pointer if malloc() failed 154 155 Clears warning from gcc 14.1: 156 157 process.c: In function ProcessConnectionSetup: 158 ICElibint.h:233:13: warning: dereference of possibly-NULL hisAuthNames 159 [CWE-690] [-Wanalyzer-possible-null-dereference] 160 233 | _string = malloc (_len + 1); \ 161 ICElibint.h:247:9: note: in expansion of macro EXTRACT_STRING 162 247 | EXTRACT_STRING (_pBuf, _swap, _strings[_i]); \ 163 | ^~~~~~~~~~~~~~ 164 process.c:947:9: note: in expansion of macro EXTRACT_LISTOF_STRING 165 947 | EXTRACT_LISTOF_STRING (pData, swap, hisAuthCount, hisAuthNames); 166 | ^~~~~~~~~~~~~~~~~~~~~ 167 168 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 169 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 170 171 commit 8adbc70b77c80b75c9b66dd56852a01f524df37a 172 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 173 Date: Sun Aug 25 09:41:35 2024 -0700 174 175 IceReadCompleteMessage: callers need to check if malloc() failed 176 177 The IceReadCompleteMessage() macro may try to malloc() a buffer and 178 assign it to the final argument. 179 180 Clears up 12 -Wanalyzer-null-dereference warnings from gcc 14.1 181 of the form: 182 183 process.c: In function ProcessError: 184 ICElibint.h:214:10: warning: dereference of NULL pStart [CWE-476] 185 [-Wanalyzer-null-dereference] 186 214 | _val = *((CARD16 *) _pBuf); \ 187 | ^ 188 ICElibint.h:232:5: note: in expansion of macro EXTRACT_CARD16 189 232 | EXTRACT_CARD16 (_pBuf, _swap, _len); \ 190 | ^~~~~~~~~~~~~~ 191 process.c:689:17: note: in expansion of macro EXTRACT_STRING 192 689 | EXTRACT_STRING (pData, swap, temp); 193 | ^~~~~~~~~~~~~~ 194 195 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 196 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 197 198 commit ac3458271b0edbce1e9c827a8e9dc83aa938f8a2 199 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 200 Date: Sat Aug 24 16:42:09 2024 -0700 201 202 Clear some -Wuseless-cast warnings from gcc 14.1 203 204 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 205 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 206 207 commit 9d9841da2deca16a5350ee813fd6b9d3dd3b1b02 208 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 209 Date: Sat Aug 24 16:04:42 2024 -0700 210 211 _IceAddOpcodeMapping: Avoid writing to NULL pointer if malloc fails 212 213 Clears warning from gcc 14.1: 214 215 misc.c: In function _IceAddOpcodeMapping: 216 misc.c:435:9: warning: use of possibly-NULL *iceConn.process_msg_info 217 where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument] 218 435 | memcpy (iceConn->process_msg_info, oldVec, 219 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 220 436 | oldsize * sizeof (_IceProcessMsgInfo)); 221 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 222 223 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 224 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 225 226 commit 4b8b12b432c86601e773dfccf8d17e87bb453f07 227 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 228 Date: Sat Aug 24 15:34:50 2024 -0700 229 230 EXTRACT_STRING: Avoid writing to NULL pointer if malloc fails 231 232 Fixes several warnings from gcc 14.1 of the form: 233 234 In file included from error.c:33: 235 error.c: In function _IceDefaultErrorHandler: 236 ICElibint.h:234:5: warning: use of possibly-NULL estr where non-null 237 expected [CWE-690] [-Wanalyzer-possible-null-argument] 238 234 | memcpy (_string, _pBuf, _len); \ 239 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 240 error.c:515:13: note: in expansion of macro EXTRACT_STRING 241 242 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 243 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 244 245 commit 00f59affb7e14fb25b40ba0a009cd8ff5dd3039a 246 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 247 Date: Sat Aug 24 15:21:07 2024 -0700 248 249 ConnectToPeer: return failure if malloc() fails 250 251 Fixes warning from gcc 14.1: 252 connect.c: In function ConnectToPeer: 253 connect.c:541:9: warning: use of possibly-NULL address where non-null 254 expected [CWE-690] [-Wanalyzer-possible-null-argument] 255 541 | strncpy (address, ptr, len); 256 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 257 258 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 259 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 260 261 commit 4b6f0759a8cbcd5cc1fc0a6ee0359f734194f365 262 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 263 Date: Sat Aug 24 15:13:26 2024 -0700 264 265 IceOpenConnection: stop processing messages if connection was closed 266 267 Fixes warning from gcc 14.1 in cases where the connection was closed 268 and iceConn set to NULL on a previous time through the loop. 269 270 connect.c: In function IceOpenConnection: 271 connect.c:439:51: warning: dereference of NULL iceConn [CWE-476] 272 [-Wanalyzer-null-dereference] 273 439 | iceConn->my_ice_version_index = 274 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ 275 440 | reply.connection_reply.version_index; 276 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 277 278 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 279 Part-of: <https://gitlab.freedesktop.org/xorg/lib/libice/-/merge_requests/19> 280 281 commit e8a561b500f7b783d84d81ba158fd28b007745ae 282 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 283 Date: Fri Oct 13 12:27:49 2023 -0700 284 285 gitlab CI: add xz-utils to container for "make distcheck" 286 287 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 288 289 commit 246bfdb00c1ec716caf4e91178bda8389d3ecf1d 290 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 291 Date: Fri Oct 13 12:13:34 2023 -0700 292 293 gitlab CI: Update to latest CI templates 294 295 Current template fails to rebuild the CI container with the current 296 Debian stable release (a new release since the last update) 297 298 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 299 300 commit 1e3fe79e3a5346bc2dbf8108afec1e69a42ff822 301 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 302 Date: Tue Mar 28 09:50:17 2023 -0700 303 304 Set close-on-exec when opening files 305 306 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 307 308 commit 5b9d4d27a2b8441e966d701bf337ace848c4e4fd 309 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 310 Date: Sat Mar 4 10:44:45 2023 -0800 311 312 configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL 313 314 AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, 315 so it's time to rely on it. 316 317 Clears autoconf warnings: 318 319 configure.ac:18: warning: The macro `AC_PROG_LIBTOOL' is obsolete. 320 configure.ac:18: You should run autoupdate. 321 aclocal.m4:3640: AC_PROG_LIBTOOL is expanded from... 322 configure.ac:18: the top level 323 324 libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, 325 libtoolize: and rerunning libtoolize and aclocal. 326 327 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 328 329 commit be1888a46e446dfcaa62ac0a97d96bb77b6816d4 330 Author: Matt Turner <mattst88 (a] gmail.com> 331 Date: Thu Dec 8 10:41:44 2022 -0500 332 333 libICE 1.1.1 334 335 Signed-off-by: Matt Turner <mattst88 (a] gmail.com> 336 337 commit e176b676cff17948d68299c00dddefe41638c752 338 Author: Arsen Arsenovi <arsen (a] aarsen.me> 339 Date: Sun Dec 4 22:19:20 2022 +0100 340 341 ICEmsg: Fix C++ interoperability error due to static_assert define 342 343 Commit 0269c687e954db7aca2a4344e32cb203315a00b6 added a static_assert helper 344 that gets defined to blank if left undefined by assert.h. As this is not a 345 macro in other languages that use this header, this can lead to a compile-time 346 error. 347 348 Bug: https://bugs.gentoo.org/884369 349 350 commit 6c057be0f0aef0aeabb9a00e6814548fed0c125a 351 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 352 Date: Sat Dec 3 16:48:25 2022 -0800 353 354 libICE 1.1.0 355 356 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 357 358 commit f032db0964e6d73b4f3c3264c1f8fbbb023fdf4c 359 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 360 Date: Wed Nov 23 10:29:44 2022 -0800 361 362 configure: Use AC_SYS_LARGEFILE to enable large file support 363 364 The only files libICE operates on are .ICEauthority files, which 365 it only uses internally and does not make available to other code, 366 so there is no concern about ABI mismatch here. 367 368 While .ICEauthority files should never be more than 2gb in size, 369 they may be stored on filesystems with large inodes. 370 371 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 372 373 commit dd207b23f8d8ffe36e6727c813372a7858aafd02 374 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 375 Date: Thu Nov 10 10:02:24 2022 -0800 376 377 ice.pc.in: "Libs.Private" should be "Libs.private" 378 379 Fixes: b9411f7 ("ice.pc.in: add -lbsd flags when required") 380 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 381 382 commit 0515b88aa55e6e55d7ab2808d245fdd64f7863ff 383 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 384 Date: Thu Oct 27 19:01:46 2022 -0700 385 386 Avoid -Wdeclaration-after-statement warnings from static_assert 387 388 Some implementations of static_assert() define a new variable. 389 Avoid warnings from those when calling static_assert() from a 390 macro that may not be at the top of a new code block. 391 392 ../../src/accept.c: In function 'IceAcceptConnection': 393 ../../src/accept.c:159:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 394 159 | IceGetHeader (iceConn, 0, ICE_ByteOrder, 395 | ^~~~~~~~~~~~ 396 ../../src/connect.c: In function 'IceOpenConnection': 397 ../../src/connect.c:254:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 398 254 | IceGetHeader (iceConn, 0, ICE_ByteOrder, 399 | ^~~~~~~~~~~~ 400 ../../src/connect.c:340:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 401 340 | IceGetHeaderExtra (iceConn, 0, ICE_ConnectionSetup, 402 | ^~~~~~~~~~~~~~~~~ 403 [...etc...] 404 405 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 406 407 commit 246cbc402aabe5e971c43d1a21b66ab4c602f1cf 408 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 409 Date: Thu Oct 27 18:42:47 2022 -0700 410 411 Only link with libbsd if needed for arc4random_buf() or getentropy() 412 413 Avoid unnecessary library dependency when using a libc with these 414 functions included 415 416 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 417 418 commit 81da58f39d274ab7f822fb22e56b5b2027597a51 419 Author: Guillem Jover <guillem (a] hadrons.org> 420 Date: Thu Oct 6 00:26:11 2022 +0000 421 422 Switch from libbsd to libbsd-overlay 423 424 This is the preferred usage form for libbsd, as it makes the code more 425 portable and requires no special includes for libbsd, by transparently 426 injects the needed standard headers that would be used on a BSD. 427 428 Signed-off-by: Guillem Jover <guillem (a] hadrons.org> 429 430 commit 96c84e563610d5c7846e601605f675f3d3840dd2 431 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 432 Date: Wed Sep 14 16:29:32 2022 -0700 433 434 Handle arrays too large to fit in iceConn buffers 435 436 Fixes numerous gcc warnings of the form: 437 438 connect.c: In function IceOpenConnection: 439 ICElibint.h:160:25: warning: potential null pointer dereference [-Wnull-dereference] 440 *((CARD16 *) _pBuf) = _val; \ 441 ^ 442 ICElibint.h:174:5: note: in expansion of macro STORE_CARD16 443 STORE_CARD16 (_pBuf, _len); \ 444 ^~~~~~~~~~~~ 445 connect.c:351:5: note: in expansion of macro STORE_STRING 446 STORE_STRING (pData, IceReleaseString); 447 ^~~~~~~~~~~~ 448 449 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 450 451 commit 0269c687e954db7aca2a4344e32cb203315a00b6 452 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 453 Date: Wed Sep 7 14:22:44 2022 -0700 454 455 ICEmsg.h: Add static asserts that message header length <= ICE_OUTBUFSIZE 456 457 A message header length larger than ICE_OUTBUFSIZE will cause 458 buffer overflows. 459 460 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 461 462 commit b399fc2b3c5c2cf5f0d36d98c372f353a8186d15 463 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 464 Date: Wed Sep 7 13:37:34 2022 -0700 465 466 IceFlush: signal fatal I/O error if bufptr is past end of buffer 467 468 It should never happen, but has been possible in the past when 469 we didn't handle buffer checks properly - this would help us 470 catch it if a similar mistake ever happens again (or the wrong 471 memory pointer gets corrupted by something else). 472 473 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 474 475 commit 918d58772595e7cd9907a7b08874196442fbf599 476 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 477 Date: Wed Sep 7 13:36:28 2022 -0700 478 479 Refactor Fatal I/O error handling into a common function 480 481 Reduce duplicated code in _IceRead() and _IceWrite() 482 483 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 484 485 commit 6ca1ea376c7c6c9dc719d607b7684d87bcf96712 486 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 487 Date: Wed Sep 7 11:33:13 2022 -0700 488 489 IceGetHeaderExtra: only include extra space in outbufptr if there's room 490 491 If there's not room for it in the buffer, we already set pData to 492 NULL, but still set the outbufptr to include the space, which could 493 lead to IceFlush() reading past the end of the buffer. 494 495 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 496 497 commit 76fd1cf6534358426cddaed045514d79270275b5 498 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 499 Date: Sat Aug 20 16:54:52 2022 -0700 500 501 Only link to libbsd for arc4random_buf if it is not found in libc 502 503 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 504 505 commit 0124a9ea65118ae70bcc155e2a9a36a6c4869310 506 Author: walter harms <wharms (a] bfs.de> 507 Date: Wed Oct 18 18:09:05 2017 +0200 508 509 make sure buffer is zero filled and report if allocation failed 510 511 Signed-off-by: Walter Harms <wharms (a] bfs.de> 512 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 513 514 commit 1e7787324a788fe84f7e438f4db9a47c8f6dd952 515 Author: walter harms <wharms (a] bfs.de> 516 Date: Wed Oct 18 18:03:47 2017 +0200 517 518 add check for malloc 519 520 fix a potential null pointer deference error 521 522 Signed-off-by: Walter Harms <wharms (a] bfs.de> 523 524 commit 7b439c788b94849d4f07cda77518bec43ebbd9a6 525 Author: walter harms <wharms (a] bfs.de> 526 Date: Thu Sep 7 18:46:39 2017 +0200 527 528 connect.c: FIX 'iceConn' shadows a previous local, [-Wshadow] 529 530 In function 'IceOpenConnection': gcc give the following warning: 531 connect.c:106:11: warning: declaration of 'iceConn' shadows a previous local [-Wshadow] 532 fixed by renaming 2. iceConn to iConn (and all its uses) 533 534 Signed-off-by: Walter Harms <wharms (a] bfs.de> 535 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 536 537 commit 348b9a46086ad72d6f29f2637036accff6630db4 538 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 539 Date: Sat Apr 30 15:17:40 2022 -0700 540 541 ProcessAuthReply: rename status variable to avoid shadowing 542 543 Fixes gcc complaint: 544 545 process.c: In function ProcessAuthReply: 546 process.c:1478:20: warning: declaration of status shadows a previous local [-Wshadow] 547 1478 | Status status = 1; 548 | ^~~~~~ 549 process.c:1426:25: note: shadowed declaration is here 550 1426 | IcePaAuthStatus status = 551 | ^~~~~~ 552 553 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 554 555 commit d70c666549a9ee17de7349904529cf41bf023926 556 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 557 Date: Sat Apr 30 15:04:53 2022 -0700 558 559 ConnectToPeer: be doubly sure that use-after-free doesn't happen 560 561 This resolves an issue reported by the Oracle Parfait static analyzer: 562 563 Error: Use after free 564 Use after free [use-after-free] (CWE 416): 565 Use after free of pointer trans_conn 566 at line 566 of lib/libICE/src/connect.c in function 'ConnectToPeer'. 567 trans_conn previously freed with _IceTransClose at line 532 568 trans_conn was allocated at line 525 with _IceTransOpenCOTSClient 569 570 even though I believe this is already handled by the 571 'if (madeConnection) { ... } else trans_conn = NULL;' 572 block, but the analyzer apparently doesn't follow that logic, 573 while this simple change makes it obvious. 574 575 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 576 577 commit 8d2cb9e7a897a070b2509f9de60961c9d154ee99 578 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 579 Date: Sat Apr 30 14:39:02 2022 -0700 580 581 configure: check for libbsd before libxtrans checks for strlcpy 582 583 If we're going to link to libbsd, might as well use it for strlcpy too 584 585 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 586 587 commit 9a3534b3e0808a5294f85f2402a2b4410a153b76 588 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 589 Date: Sat Apr 30 14:27:55 2022 -0700 590 591 gitlab CI: add a basic build test 592 593 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 594 595 commit 410d2005f5a1f11e8204d9bc3432e0b145ae3161 596 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 597 Date: Sat Apr 30 14:08:43 2022 -0700 598 599 Fix spelling/wording issues 600 601 Found by using: 602 codespell --builtin clear,rare,usage,informal,code,names 603 604 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 605 606 commit 08df47e4786d112a639915331702b4a27def6a56 607 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 608 Date: Sat Apr 30 13:58:58 2022 -0700 609 610 Build xz tarballs instead of bzip2 611 612 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 613 614 commit b9411f79f59b63d7d363234d795fa5c77cc738c9 615 Author: David Callu <callu.david (a] gmail.com> 616 Date: Tue Apr 7 10:20:49 2020 +0200 617 618 ice.pc.in: add -lbsd flags when required 619 620 commit 8e6a14c63d6b73cde87cb331439f2a4d19cba5b9 621 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 622 Date: Sun Jul 14 10:37:25 2019 -0700 623 624 libICE 1.0.10 625 626 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 627 628 commit b6aad584c1dc278364c295165512b5f5b98c173e 629 Author: Olivier Fourdan <ofourdan (a] redhat.com> 630 Date: Thu Apr 11 09:05:15 2019 +0200 631 632 cleanup: Separate variable assignment and test 633 634 Assigning and testing a value in a single statement hinders code clarity 635 and may confuses static code analyzers. 636 637 Separate the assignment and the test for clarity. 638 639 Signed-off-by: Olivier Fourdan <ofourdan (a] redhat.com> 640 641 commit 772e5b0fdfc9dbd8bec070bd0c4c7eb5565df2ee 642 Author: Olivier Fourdan <ofourdan (a] redhat.com> 643 Date: Wed Apr 10 11:15:11 2019 +0200 644 645 _IceRead: Avoid possible use-after-free 646 647 `_IceRead()` gets called from multiple places which do not expect the 648 connection to be freed. 649 650 Do not free the connection data in `_IceRead()` to avoid potential 651 use-after-free issue in the various callers. 652 653 The connection data will be freed eventually in `ProcessWantToClose()`, 654 so not freeing it in `_IceRead()` should not introduce an memory leak. 655 656 Signed-off-by: Olivier Fourdan <ofourdan (a] redhat.com> 657 658 commit 1493beba2aa03bdadeed8b4fa5d424df6e113071 659 Author: Olivier Fourdan <ofourdan (a] redhat.com> 660 Date: Wed Apr 10 11:01:31 2019 +0200 661 662 IceListenForWellKnownConnections: Fix memleak 663 664 The function `_IceTransMakeAllCOTSServerListeners` allocates memory for 665 `transConns` which is leaked in case of error. 666 667 Signed-off-by: Olivier Fourdan <ofourdan (a] redhat.com> 668 669 commit a67a477eefdc93c32fa82da6ff0b4e69dd4c2ccb 670 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 671 Date: Sun Mar 24 15:29:34 2019 -0700 672 673 IceWritePad: always use zero values for pad bytes 674 675 Previously it would just bump the pointer in the buffer leaving 676 whatever values were previously there in place. 677 678 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 679 680 commit 2318ace3340009c44e78eab094f159f0e0b4a197 681 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 682 Date: Sun Mar 24 14:36:10 2019 -0700 683 684 IceOpenConnection: check for malloc failure on connect_to_you too 685 686 Fixes: https://gitlab.freedesktop.org/xorg/lib/libice/issues/4 687 688 Reported-by: mahendra <mahendra.n (a] samsung.com> 689 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 690 691 commit b484311c929a1b64966d89da92fafce7263006e1 692 Author: Allison Lortie <desrt (a] desrt.ca> 693 Date: Tue Jun 14 16:09:46 2016 -0400 694 695 authutil: support $XDG_RUNTIME_DIR/ICEauthority 696 697 If we find that $XDG_RUNTIME_DIR is set (and $ICEAUTHORITY is not), then 698 the ICEauthority file is stored in the XDG_RUNTIME_DIR instead of the 699 home directory, and without a leading dot. 700 701 https://bugs.freedesktop.org/show_bug.cgi?id=49173 702 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 703 704 commit 48ed5e04b5a8ba64dcfeea090cf3a32d3087b749 705 Author: Allison Lortie <desrt (a] desrt.ca> 706 Date: Tue Jun 14 16:08:21 2016 -0400 707 708 authutil: fix an out-of-bounds access 709 710 There is a theoretical edge case where the $HOME environment variable 711 could be set to the empty string. IceAuthFileName() unconditionally 712 checks index 1 of this string, which is out of bounds. 713 714 Fix that up by rejecting empty strings in the same way as we reject 715 NULL. 716 717 https://bugs.freedesktop.org/show_bug.cgi?id=49173 718 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 719 720 commit 468b83ec4810b4ea2373182b5801f998f3dcd471 721 Author: Tobias Stoeckmann <tobias (a] stoeckmann.org> 722 Date: Mon Jul 30 20:50:58 2018 +0200 723 724 Always terminate strncpy results. 725 726 The function strncpy does not guarantee to append a terminating 727 NUL character to the destination. 728 729 This patch merges libSM's way of handling this issue into libICE. 730 731 Signed-off-by: Tobias Stoeckmann <tobias (a] stoeckmann.org> 732 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 733 734 commit 1cc4ae8648590f04557a20c8d88d39cef7fe8119 735 Author: walter harms <wharms (a] bfs.de> 736 Date: Thu Sep 7 18:52:13 2017 +0200 737 738 iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf' 739 740 commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if 741 causing a gcc warning: 742 743 In function 'arc4random_buf': 744 iceauth.c:89:13: warning: unused variable 'ret' [-Wunused-variable] 745 746 fixed by moving #if 1 up 747 748 Signed-off-by: Walter Harms <wharms (a] bfs.de> 749 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 750 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 751 752 commit ccbcae7d3409789bf346ca35963264d064f54cba 753 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 754 Date: Fri Dec 7 19:29:55 2018 -0800 755 756 Update configure.ac bug URL for gitlab migration 757 758 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 759 760 commit e72ca90879db149bbee6232dd78a565e630e917d 761 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 762 Date: Sun Nov 18 21:48:59 2018 -0800 763 764 Update README for gitlab migration 765 766 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 767 768 commit dc73ec034c9083b8c7d980e80eb6d4c88bcfaa51 769 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 770 Date: Sat Nov 10 13:13:45 2018 -0800 771 772 Remove obsolete B16 & B32 tags in struct definitions 773 774 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 775 776 commit f66955f7250d7c150dfb97862878acc2222781e5 777 Author: walter harms <wharms (a] bfs.de> 778 Date: Fri Sep 8 20:03:03 2017 +0200 779 780 make IceProtocolShutdown() more readable 781 782 I found IceProtocolShutdown() hard to read only to find that was 783 it does it aktually very simple. So i rearranged the code to make 784 it more readable. 785 786 Signed-off-by: Walter Harms <wharms (a] bfs.de> 787 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> 788 [Emil Velikov: whitespace fixes] 789 Signed-off-by: Emil Velikov <emil.velikov (a] collabora.com> 790 791 commit 936dcaac07f7db569ed91a34e0a4b5944aac205f 792 Author: walter harms <wharms (a] bfs.de> 793 Date: Fri Sep 8 19:59:17 2017 +0200 794 795 Drop NULL check prior to free() 796 797 free() can handle NULL just fine - remove the check. 798 799 Signed-off-by: Walter Harms <wharms (a] bfs.de> 800 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> 801 Reviewed-by: Emil Velikov <emil.velikov (a] collabora.com> 802 803 commit 43644931cb9cb5cc92391f6f5431535b9b7a3f24 804 Author: Eric Engestrom <eric.engestrom (a] imgtec.com> 805 Date: Fri Jul 7 11:23:48 2017 +0100 806 807 Make sure string is never NULL 808 809 `error_message` is passed in to strncpy() without any check, which 810 doesn't handle NULL itself, so let's make it a valid empty string in 811 cases where it was NULL. 812 813 Signed-off-by: Eric Engestrom <eric.engestrom (a] imgtec.com> 814 Acked-by: Walter Harms <wharms (a] bfs.de> 815 Reviewed-by: Emil Velikov <emil.velikov (a] collabora.com> 816 817 commit e8c21056134498c49733f6baf572ffbb051ed886 818 Author: Eric Engestrom <eric.engestrom (a] imgtec.com> 819 Date: Fri Jul 7 11:23:47 2017 +0100 820 821 Make sure error_message is a free-able string 822 823 Similar to the previous commit, assigning a static string would crash 824 upon freeing. 825 826 Signed-off-by: Eric Engestrom <eric.engestrom (a] imgtec.com> 827 Acked-by: Walter Harms <wharms (a] bfs.de> 828 Reviewed-by: Emil Velikov <emil.velikov (a] collabora.com> 829 830 commit 7a7844bf5ade915268fe7f9b292908c6cd75f3ba 831 Author: Eric Engestrom <eric.engestrom (a] imgtec.com> 832 Date: Fri Jul 7 11:23:46 2017 +0100 833 834 Make sure errorStr is a free-able string 835 836 If the `errorClass` isn't handled by the switch, `errorStr`'s initial 837 value would be a pointer to some static memory with an empty string, 838 and freeing it would most likely crash. 839 840 Let's set it to NULL instead, as is done in other similar places. 841 842 Signed-off-by: Eric Engestrom <eric.engestrom (a] imgtec.com> 843 Acked-by: Walter Harms <wharms (a] bfs.de> 844 Reviewed-by: Emil Velikov <emil.velikov (a] collabora.com> 845 846 commit 7ef9680caa8c223a09beb637e26fd3471128e6ba 847 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 848 Date: Sun May 8 09:19:36 2016 +0100 849 850 configure.ac: set TRANS_CLIENT/SERVER 851 852 Similar to ICE_t just set the define globally and remove the multiple 853 definitions throughout the tree 854 855 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 856 Reviewed-by: Adam Jackson <ajax (a] redhat.com> 857 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> (IRC) 858 859 commit ab64a947b5de5b778f31ede9cfce386566023a14 860 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 861 Date: Sun May 8 09:19:35 2016 +0100 862 863 Kill off local ICE_t definitions 864 865 Already defined at global scale in configure.ac 866 867 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 868 Reviewed-by: Adam Jackson <ajax (a] redhat.com> 869 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> (IRC) 870 871 commit f4c00d345edf3dad5893b50ff0ae7cd3e0cfd780 872 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 873 Date: Sun May 8 09:19:34 2016 +0100 874 875 Remove unneeded ^L symbols. 876 877 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 878 Reviewed-by: Adam Jackson <ajax (a] redhat.com> 879 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> (IRC) 880 881 commit d603d7d7d989c4ff1094810e9fcf2a29bc00bb0c 882 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 883 Date: Sun May 8 09:19:33 2016 +0100 884 885 Kill off Time_t macro 886 887 Analogous to previous commit, including the megacommit that removed the 888 need for it. 889 890 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 891 Reviewed-by: Adam Jackson <ajax (a] redhat.com> 892 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> (IRC) 893 894 commit 82250f26fc76d7b7574cfd472646a98e325d944a 895 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 896 Date: Sun May 8 09:19:32 2016 +0100 897 898 Kill off Strstr macro 899 900 Directly use the strstr function as opposed to wrapping it in a macro. 901 The latter is no longer needed as of 902 903 commit 72e353567f8927996a26e72848d86f692c3f0737 904 Author: Kaleb Keithley <kaleb (a] freedesktop.org> 905 Date: Fri Nov 14 16:48:46 2003 +0000 906 907 XFree86 4.3.0.1 908 909 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 910 Reviewed-by: Adam Jackson <ajax (a] redhat.com> 911 Reviewed-by: Eric Engestrom <eric.engestrom (a] imgtec.com> (IRC) 912 913 commit ff5e59f32255913bb1cdf51441b98c9107ae165b 914 Author: Benjamin Tissoires <benjamin.tissoires (a] gmail.com> 915 Date: Tue Apr 4 19:12:53 2017 +0200 916 917 Use getentropy() if arc4random_buf() is not available 918 919 This allows to fix CVE-2017-2626 on Linux platforms without pulling in 920 libbsd. 921 The libc getentropy() is available since glibc 2.25 but also on OpenBSD. 922 For Linux, we need at least a v3.17 kernel. If the recommended 923 arc4random_buf() function is not available, emulate it by first trying 924 to use getentropy() on a supported glibc and kernel. If the call fails, 925 fall back to the current (partly vulnerable) code. 926 927 Signed-off-by: Benjamin Tissoires <benjamin.tissoires (a] gmail.com> 928 Reviewed-by: Mark Kettenis <kettenis (a] openbsd.org> 929 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 930 Signed-off-by: Peter Hutterer <peter.hutterer (a] who-t.net> 931 932 commit 1746abbb1ae1c41ba29c14895c5bd3f1334faef5 933 Author: Mihail Konev <k.mvc (a] ya.ru> 934 Date: Thu Jan 26 13:52:49 2017 +1000 935 936 autogen: add default patch prefix 937 938 Signed-off-by: Mihail Konev <k.mvc (a] ya.ru> 939 940 commit 3aa14db63fefb7634b1bd4370e33ba14c4ea90ae 941 Author: Emil Velikov <emil.l.velikov (a] gmail.com> 942 Date: Mon Mar 9 12:00:52 2015 +0000 943 944 autogen.sh: use quoted string variables 945 946 Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent 947 fall-outs, when they contain space. 948 949 Signed-off-by: Emil Velikov <emil.l.velikov (a] gmail.com> 950 Reviewed-by: Peter Hutterer <peter.hutterer (a] who-t.net> 951 Signed-off-by: Peter Hutterer <peter.hutterer (a] who-t.net> 952 953 commit d41c57eaa0c1474acf0a6fb271f22106e3070016 954 Author: Peter Hutterer <peter.hutterer (a] who-t.net> 955 Date: Tue Jan 24 10:32:07 2017 +1000 956 957 autogen.sh: use exec instead of waiting for configure to finish 958 959 Syncs the invocation of configure with the one from the server. 960 961 Signed-off-by: Peter Hutterer <peter.hutterer (a] who-t.net> 962 Reviewed-by: Emil Velikov <emil.velikov (a] collabora.com> 963 964 commit ac4bb20e74e064b219de70e9b54516a921fdb7c3 965 Author: Tobias Stoeckmann <tobias (a] stoeckmann.org> 966 Date: Tue Nov 22 20:13:29 2016 +0100 967 968 Fix use after free on subsequent calls 969 970 The function IceAuthFileName is vulnerable to a use after free. The 971 flaw can be triggered by calling the function three times: 972 973 - First call succeeds and stores the path in buf, a dynamically 974 allocated buffer with size bsize. 975 - Second call fails due to out of memory. It frees buf, but keeps 976 the old size in bsize. 977 - Third call only checks if bsize is large enough. Then it uses 978 buf without allocating it again -- the use after free happens. 979 980 In order to exploit this, an attacker must change environment variables 981 between each call, namely ICEAUTHORITY or HOME. It also takes subsequent 982 calls. Due to these limitations, I don't consider this to be of high 983 priority. 984 985 Reviewed-by: Matthieu Herrb <matthieu (a] herrb.eu> 986 987 commit b1720edc9b9f3e7a05caa3fcd81761e5818ea255 988 Author: Remko van der Vossen <bugs (a] yuugen.jp> 989 Date: Sun Jul 19 08:34:11 2015 -0700 990 991 Bug 90616 - libICE build fails on array bounds check 992 993 https://bugs.freedesktop.org/show_bug.cgi?id=90616 994 995 Recent versions of gcc have array bounds checking turned on by default, 996 this leads to build failures of libICE. As the _IceVersionCount variable 997 in ICElibint.h is not declared const the compiler cannot assume that the 998 nested for loop in ProcessConnectionSetup stays within bounds. 999 1000 The simple fix is of course to change the declarations of _IceVersionCount, 1001 _IceVersions, and the local variable myVersionCount to const declarations. 1002 1003 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1004 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1005 1006 commit 8a511dad53774693ed818d54d7896e1663942b18 1007 Author: Jon TURNEY <jon.turney (a] dronecode.org.uk> 1008 Date: Sat Sep 13 17:13:44 2014 +0100 1009 1010 Include unistd.h for getpid() 1011 1012 Signed-off-by: Jon TURNEY <jon.turney (a] dronecode.org.uk> 1013 Reviewed-by: David Macek <david.macek.0 (a] gmail.com> 1014 1015 commit fd22b62ae6380ddb00fa4c750f5ce175d2a6e76f 1016 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1017 Date: Sun Sep 14 13:08:17 2014 -0700 1018 1019 spec: Convert troff \*Q..\*U to DocBook <quote>...</quote> 1020 1021 Reported-by: Jasper St. Pierre <jstpierre (a] mecheye.net> 1022 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1023 Reviewed-by: Jasper St. Pierre <jstpierre (a] mecheye.net> 1024 1025 commit 0dfab4253e26d5c6e5f058126eb5e9f7a7732ae8 1026 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1027 Date: Fri Jun 6 18:28:28 2014 -0700 1028 1029 libICE 1.0.9 1030 1031 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1032 1033 commit 9fb6ba03d7183ae06644f8a747fdb99b970d65fc 1034 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1035 Date: Tue Dec 24 09:35:02 2013 -0800 1036 1037 Delete unused name variable in register.c 1038 1039 Found by cppcheck 1.62: 1040 [src/register.c:84]: (style) Variable 'name' is assigned a value 1041 that is never used. 1042 [src/register.c:182]: (style) Variable 'name' is assigned a value 1043 that is never used. 1044 1045 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1046 1047 commit c5060918164168c0a4f737b76e92df3c03356dc6 1048 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1049 Date: Tue Dec 24 09:18:17 2013 -0800 1050 1051 Free iceConn->connection_string when unwinding after malloc fails 1052 1053 Found by cppcheck 1.62: 1054 [src/accept.c:113]: (error) Memory leak: iceConn.connection_string 1055 1056 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1057 1058 commit 80f62c54fbd50a3bbdf9c37258525098c9117830 1059 Author: Matthieu Herrb <matthieu.herrb (a] laas.fr> 1060 Date: Thu Aug 29 22:18:14 2013 +0200 1061 1062 Use arc4random when available to produce the auth cookie. 1063 1064 arc4random() and associated functions can be found in libbsd on 1065 GNU/Linux systems. 1066 1067 Signed-off-by: Matthieu Herrb <matthieu.herrb (a] laas.fr> 1068 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1069 1070 commit 2312ee00402088307e69589c3d12529b5232df66 1071 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1072 Date: Thu Aug 8 23:01:30 2013 -0700 1073 1074 Make STORE_STRING cast strlen result to CARD16 when storing in CARD16 1075 1076 Clears a number of clang warnings of the form: 1077 1078 connect.c:328:6: warning: implicit conversion loses integer precision: 1079 'size_t' (aka 'unsigned long') to 'CARD16' (aka 'unsigned short') 1080 [-Wconversion] 1081 STORE_STRING (pData, _IceAuthNames[i]); 1082 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1083 ./ICElibint.h:173:19: note: expanded from macro 'STORE_STRING' 1084 CARD16 _len = strlen (_string); \ 1085 ~~~~ ^~~~~~~~~~~~~~~~ 1086 1087 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1088 1089 commit 6d6aa84dc6acb2daa3ef7e20942c38a1416bf543 1090 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1091 Date: Thu Aug 8 22:58:46 2013 -0700 1092 1093 Cast assignments in IceErrorHeader() macro 1094 1095 Clears many clang warnings about implicit conversions losing 1096 integer precision, such as from storing ints into CARD8 or CARD16. 1097 1098 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1099 1100 commit 9450bb648ef98efd6f08ea7d14ab8b9ea6e7bb54 1101 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1102 Date: Thu Aug 8 22:47:41 2013 -0700 1103 1104 Make write_string call write_counted_string instead of copying it 1105 1106 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1107 1108 commit 84153eee4db318cd897c464e70cb9f8bc8e469f6 1109 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1110 Date: Thu Aug 8 22:37:09 2013 -0700 1111 1112 Mark input arguments to write_string functions as const 1113 1114 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1115 1116 commit 9a74512ffdc1628f1b87d2191439915c63b9104f 1117 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1118 Date: Thu Aug 8 22:31:41 2013 -0700 1119 1120 Stop casting return values from malloc 1121 1122 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1123 1124 commit 4033226105fa861ab5f0276850afc24c0fa45406 1125 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1126 Date: Thu Aug 8 22:17:27 2013 -0700 1127 1128 Get rid of casts to (char *) in calls to free() 1129 1130 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1131 1132 commit 10c30ae6a7df1a7c352a1d611a313dffcaa42082 1133 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1134 Date: Sat Jul 20 14:48:33 2013 -0700 1135 1136 Convert remaining sprintf() call to snprintf() 1137 1138 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1139 1140 commit 0a94633e3d805ca477fba6b7acb673d055a3f43d 1141 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1142 Date: Sat Jul 20 14:46:09 2013 -0700 1143 1144 Convert strcpy/strcat pairs to snprintf calls 1145 1146 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1147 1148 commit 0d276835222eeb57de56f56cd9e12611b1d30466 1149 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1150 Date: Sat Jul 20 14:35:11 2013 -0700 1151 1152 Fix some clang warnings about integer sign/size conversions 1153 1154 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1155 1156 commit bb3d8a7767cf260b97c7e019e4fec0ee7d7b65a8 1157 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1158 Date: Sat Jul 20 14:24:04 2013 -0700 1159 1160 unifdef WORD64 1161 1162 Remove leftover remnants of CRAY support, which still had some 1163 functions consisting solely of /* NOT IMPLEMENTED YET */ comments. 1164 1165 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1166 1167 commit 9561eca1ad28afee6dcd0aebea3dd20a154ec481 1168 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1169 Date: Thu Jul 18 00:36:28 2013 -0700 1170 1171 Constify filename argument to IceLockAuthFile & IceUnlockAuthFile 1172 1173 Needed to fix const string warnings in iceauth - functions already 1174 copy provided arguments to temporary local buffer for modifications. 1175 1176 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1177 Reviewed-by: Peter Hutterer <peter.hutterer (a] who-t.net> 1178 1179 commit 1b1cf8072b2559e15ac440d5484a29a81d6918c6 1180 Author: Colin Walters <walters (a] verbum.org> 1181 Date: Wed Jan 4 17:37:06 2012 -0500 1182 1183 autogen.sh: Implement GNOME Build API 1184 1185 http://people.gnome.org/~walters/docs/build-api.txt 1186 1187 Signed-off-by: Adam Jackson <ajax (a] redhat.com> 1188 1189 commit 5e784ca7f37823e62733765371c0b8ed1c58e5aa 1190 Author: Adam Jackson <ajax (a] redhat.com> 1191 Date: Tue Jan 15 14:28:48 2013 -0500 1192 1193 configure: Remove AM_MAINTAINER_MODE 1194 1195 Signed-off-by: Adam Jackson <ajax (a] redhat.com> 1196 1197 commit e1677ce019219ac164d99f1e04f17caf16fc785a 1198 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1199 Date: Fri Jan 4 19:32:08 2013 -0800 1200 1201 unifdef -U__UNIXOS2__ 1202 1203 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1204 1205 commit f166e8bbf16ec214fefdcf02ce81f80442899cb7 1206 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1207 Date: Fri Mar 2 19:59:50 2012 -0800 1208 1209 libICE 1.0.8 1210 1211 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1212 1213 commit c87ecd959d61ae97d8a2bd82efc761bb3e299061 1214 Author: Matt Dew <marcoz (a] osource.org> 1215 Date: Mon Jan 9 21:25:18 2012 -0700 1216 1217 informaltable cleanup 1218 1219 On certain tables, add top and bottom borders to table header 1220 and a bottom border to the table. This matches what those 1221 tables in the old pdfs looked like. 1222 1223 the <?dbfo keep-together='always'> prevents tables from 1224 splitting across pages. Useful for tiny tables. 1225 1226 Converting the colwidth to a floating point, IE, 1* -> 1.0* 1227 cleans up these build errors: 1228 WARNING: table-layout="fixed" and column-width unspecified => 1229 falling back to proportional-column-width(1) 1230 1231 Signed-off-by: Matt Dew <marcoz (a] osource.org> 1232 1233 commit 8b4321a37a9fa2ad24bf87afabba6b08dcfded12 1234 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1235 Date: Thu Nov 24 12:42:36 2011 -0800 1236 1237 Plug minor memory leak in unusual path through ProcessConnectionSetup 1238 1239 Error: Memory leak (CWE 401) 1240 Memory leak of pointer 'release' allocated with malloc((_len + 1)) 1241 at line 1100 of src/process.c in function 'ProcessConnectionSetup'. 1242 'release' allocated at line 920 with malloc((_len + 1)). 1243 release leaks when _i >= hisAuthCount at line 925 1244 and i >= _IceAuthCount at line 973 1245 and found != 0 at line 998 1246 and status != 0 at line 1053 1247 and status != 1 at line 1070 1248 and accept_setup_now == 0 at line 1082 1249 and i >= hisAuthCount at line 1093. 1250 Memory leak of pointer 'vendor' allocated with malloc((_len + 1)) 1251 at line 1100 of src/process.c in function 'ProcessConnectionSetup'. 1252 'vendor' allocated at line 919 with malloc((_len + 1)). 1253 vendor leaks when _i >= hisAuthCount at line 925 1254 and i >= _IceAuthCount at line 973 1255 and found != 0 at line 998 1256 and status != 0 at line 1053 1257 and status != 1 at line 1070 1258 and accept_setup_now == 0 at line 1082 1259 and i >= hisAuthCount at line 1093. 1260 1261 [ This bug was found by the Parfait 0.3.7 bug checking tool. 1262 For more information see http://labs.oracle.com/projects/parfait/ ] 1263 1264 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1265 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1266 1267 commit caf9e3393d5d517ea129392d001a2c46a7c1f325 1268 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1269 Date: Sat Nov 19 00:26:29 2011 -0800 1270 1271 Constify protocol, vendor & release string args to IceRegisterForProtocol* 1272 1273 Needed to resolve gcc -Wwrite-strings warnings in callers. 1274 These functions only pass the strings to strcmp before calling 1275 strdup to make their own private copy for storing away. 1276 1277 While fixing the API docs to match, also fix them to match the existing 1278 function prototypes, where there were several errors before (including 1279 just plain missing most of the args to IceRegisterForProtocolReply). 1280 1281 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1282 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1283 1284 commit 59c1555dff34804c78c7e7443ad13f27300927eb 1285 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1286 Date: Wed Nov 9 22:07:34 2011 -0800 1287 1288 Remove ancient workaround for System V/386 Release 4.2 compiler bug 1289 1290 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1291 Reviewed-by: Matthieu Herrb <matthieu.herrb (a] laas.fr> 1292 Reviewed-by: walter <wharms (a] bfs.de> 1293 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1294 1295 commit bec4e9c9089fa4cc5a50fc513a3544cf6fd59bf1 1296 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1297 Date: Wed Nov 9 22:06:36 2011 -0800 1298 1299 Fix gcc -Wwrite-strings warnings in process.c 1300 1301 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1302 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1303 1304 commit ffa659dd6dd1fb8847bfdcc5e1e2be353b6395b6 1305 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1306 Date: Wed Nov 9 21:37:48 2011 -0800 1307 1308 Fix gcc -Wwrite-strings warnings in AuthNames handling 1309 1310 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1311 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1312 1313 commit 902a52ea9d7b6e6f56f7023009859072854a0fc7 1314 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1315 Date: Wed Nov 9 21:55:17 2011 -0800 1316 1317 constify arguments to IceGetAuthFileEntry 1318 1319 Needed to clear gcc -Wwrite-strings warnings in callers 1320 1321 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1322 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1323 1324 commit 9ff1f97e46903f8f83363f07cf021989bfa6a9f0 1325 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1326 Date: Wed Nov 9 21:43:59 2011 -0800 1327 1328 Fix gcc -Wwrite-strings warnings in _IceError* functions 1329 1330 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1331 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1332 1333 commit e8a16534a9406d5096d9c0ea515d979c7c15e084 1334 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1335 Date: Wed Nov 9 21:23:33 2011 -0800 1336 1337 Fix gcc -Wwrite-strings warnings in _IceDefaultErrorHandler 1338 1339 Had to split char *str into two variables, const char *str for the 1340 string literals just being passed to fprintf etal. and char *estr 1341 for use by EXTRACT_STRING for the results of malloc calls that get 1342 written to and then freed. 1343 1344 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1345 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1346 1347 commit 4fbcba4ee19a49c05440861e1278bc97d29048e0 1348 Author: Matt Dew <marcoz (a] osource.org> 1349 Date: Tue Oct 4 23:32:02 2011 -0600 1350 1351 Cleanup IDs and links in doc 1352 1353 1 - fix the capitalization of the ID attributes to match either the 1354 <title> or <funcdef> string it goes with. 1355 2 - fix any <linkend>'s that were affected by 1. 1356 3 - any <function> in the docs that has an actual funcdef, 1357 will become an olink. 1358 1359 Signed-off-by: Matt Dew <marcoz (a] osource.org> 1360 1361 commit d4e161e35335df82f412d2d2bb1ef95ff3e88401 1362 Author: Gaetan Nadon <memsize (a] videotron.ca> 1363 Date: Mon Sep 19 15:34:47 2011 -0400 1364 1365 As of 1997, X Window System is a trademark of The Open Group. 1366 1367 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1368 1369 commit fc0fc948d25dfa0f6f445a3b55610ea5b864dd60 1370 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1371 Date: Fri Sep 16 22:09:18 2011 -0700 1372 1373 Strip trailing whitespace 1374 1375 Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' 1376 git diff -w & git diff -b show no diffs from this change 1377 1378 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1379 1380 commit 22601de3f38d035eb874d4bd9f649ddd2b3f0ae2 1381 Author: Gaetan Nadon <memsize (a] videotron.ca> 1382 Date: Sun Sep 11 17:20:20 2011 -0400 1383 1384 specs: remove <productnumber> which is not used by default 1385 1386 This element is not rendered by default on the title. A template 1387 customization is required to display it. 1388 X Window System does not have a product number. 1389 1390 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1391 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1392 1393 commit 7f330738f1f5862950b3baa35ff08446093bfd4e 1394 Author: Gaetan Nadon <memsize (a] videotron.ca> 1395 Date: Sun Sep 11 17:06:00 2011 -0400 1396 1397 specs: use DocBook suggested markup for Copyrights 1398 1399 Puts the statement on a single line, using commas to separate years 1400 --> Copyright 1993, 1994, 1996 X Consortium 1401 1402 As opposed to 3 double-spaced lines. 1403 1404 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1405 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1406 1407 commit d68d2d2031f623a969784e702c97a07b8cd99010 1408 Author: Gaetan Nadon <memsize (a] videotron.ca> 1409 Date: Sun Sep 11 16:56:21 2011 -0400 1410 1411 specs: remove orphan <corpname> 1412 1413 It does not display on the title page and is redundant. 1414 No visible change on the doc. 1415 1416 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1417 1418 commit 87c934b9b7973a814763670e2dfad0579a8dcc78 1419 Author: Gaetan Nadon <memsize (a] videotron.ca> 1420 Date: Sun Sep 11 16:27:09 2011 -0400 1421 1422 specs: use the &fullrelvers; entity to set X11 release information 1423 1424 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1425 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1426 1427 commit 41f04fd8673db5c2d8e587ab2c169a694bd7528f 1428 Author: Gaetan Nadon <memsize (a] videotron.ca> 1429 Date: Sun Sep 11 14:13:35 2011 -0400 1430 1431 ice.xml: version number is 1.1, not 1.0 1432 1433 This is what it was before the conversion from roff to docbook. 1434 1435 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1436 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1437 1438 commit 9e2a596b4ff06fc9c70dfcd94506e536e351ee0b 1439 Author: Gaetan Nadon <memsize (a] videotron.ca> 1440 Date: Sun Sep 11 14:11:28 2011 -0400 1441 1442 ice.xml: fix orphan affiliation 1443 1444 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1445 1446 commit 1309d477a061d165345b602e122990eaab71a0d4 1447 Author: Gaetan Nadon <memsize (a] videotron.ca> 1448 Date: Fri Sep 9 21:21:57 2011 -0400 1449 1450 ICElib doc: remove empty revision list and specify the doc version number 1451 1452 Revision histories are not used, only 3 docs out of 63 have one. 1453 1454 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1455 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1456 1457 commit e9d57773df26ad9440a49f58941b511e594605a4 1458 Author: Gaetan Nadon <memsize (a] videotron.ca> 1459 Date: Thu Sep 8 20:00:00 2011 -0400 1460 1461 docbook.am: embed css styles inside the HTML HEAD element 1462 1463 Rather than referring to the external xorg.css stylesheet, embed the content 1464 of the file in the html output produced. This is accomplished by using 1465 version 1.10 of xorg-xhtml.xsl. 1466 1467 This makes the whole html docs tree much more relocatable. 1468 In addition, it eliminates xorg.css as a runtime file which makes 1469 xorg-sgml-doctools a build time only package. 1470 1471 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1472 1473 commit b83cbed755315f6300133f2621cbe99bdc06345a 1474 Author: Gaetan Nadon <memsize (a] videotron.ca> 1475 Date: Wed Sep 7 10:31:04 2011 -0400 1476 1477 docbook.am: global maintenance update - entities, images and olinking 1478 1479 Adding support in libX11 for html chunking caused a reorg of docbook.am 1480 as well as the xorg-sgml-doctools masterdb for olinking. 1481 The parameter img.src.path is added for pdf images. 1482 A searchpath to the root builddir is added for local entities, if present. 1483 1484 The docbook.am makefile hides all the details and is identical for 1485 all 22 modules having DocBook documentation. It is included by a thin 1486 Makefile.am which requires no docbook knowledge. 1487 1488 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1489 1490 commit f35b8b8be16f1903beed34fe23fa53d102329342 1491 Author: Gaetan Nadon <memsize (a] videotron.ca> 1492 Date: Sun Jun 12 17:54:50 2011 -0400 1493 1494 Install xml versions of specs even if HAVE_XMLTO is false 1495 1496 DocBook/XML input source is also a usefull output format that can be viewed 1497 with an XML viewer or editor and by some O/S help system. 1498 1499 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1500 1501 commit 4c9cbdb1b40799121456c692d960135d741f13c7 1502 Author: Gaetan Nadon <memsize (a] videotron.ca> 1503 Date: Sun Jun 5 16:27:36 2011 -0400 1504 1505 Install target dbs alongside generated documents 1506 1507 This matches a change in xorg-sgml-docs whereby the masterdb will look for 1508 the target dbs into the same location as the generated documents. 1509 1510 The target dbs are now installed alongside the generated documents. 1511 Previously they are installed in $prefix/sgml/X11/dbs alongside masterdb which 1512 has the potential of installing outside the package prefix and cause 1513 distcheck to fail when user does not have write permission in this package. 1514 1515 Requires XORG_CHECK_SGML_DOCTOOLS(1.8) which was released 2011-06-11 1516 1517 commit 72d668dd2ec4db9b75973ba24f42ab49851dbc6d 1518 Author: Matt Dew <marcoz (a] osource.org> 1519 Date: Wed May 25 22:54:51 2011 -0600 1520 1521 add id attributes to funcsynopsis to allow other docs to olink to them 1522 1523 Signed-off-by: Matt Dew <marcoz (a] osource.org> 1524 Reviewed-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1525 Reviewed-by: Gaetan Nadon <memsize (a] videotron.ca> 1526 1527 commit dd7f2beaa753541aefba499813f25de38cbd17b7 1528 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1529 Date: Tue Apr 19 18:36:58 2011 -0700 1530 1531 IceWritePad: Zero fill pad bytes used when buffer is full 1532 1533 Should be rarely hit, since it's only in the case where most of the 1534 message fits in the buffer, but there's not room left for the padding 1535 bytes, but better than sending uninitialized bytes off the stack when 1536 it happens. 1537 1538 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1539 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1540 1541 commit 663782989be82e7893c99eaa7cbe98ec25a23c38 1542 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1543 Date: Tue Apr 19 18:19:19 2011 -0700 1544 1545 Fix reads outside array bounds in error handlers 1546 1547 Error: Buffer overrun 1548 Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &mOp, 8), (size(&mOp) < (unsigned) 8) 1549 Array size is 1 bytes 1550 at line 296 of src/error.c in function '_IceErrorMajorOpcodeDuplicate'. 1551 Error: Buffer overrun 1552 Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &maj, 8), (size(&maj) < (unsigned) 8) 1553 Array size is 1 bytes 1554 at line 346 of src/error.c in function '_IceErrorBadMajor'. 1555 1556 [ This bug was found by the Parfait 0.3.7 bug checking tool. 1557 For more information see http://labs.oracle.com/projects/parfait/ ] 1558 1559 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1560 Reviewed-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1561 1562 commit daf686b7639919289b07a575a0d88efcb91d9732 1563 Author: Gaetan Nadon <memsize (a] videotron.ca> 1564 Date: Wed Mar 30 20:15:07 2011 -0400 1565 1566 doc: xorg-sgml-doctools package at version 1.7 is required 1567 1568 This version contains support for external references 1569 1570 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1571 1572 commit fadb927532556adb471300c89de29d268aae9102 1573 Author: Gaetan Nadon <memsize (a] videotron.ca> 1574 Date: Sun Feb 27 15:06:18 2011 -0500 1575 1576 Documentation: add Docbook external references support 1577 1578 When writing technical documentation, it is often necessary to cross 1579 reference to other information. When that other information is not in the 1580 current document, additional support is needed, namely <olink>. 1581 1582 A new feature with version 1.7 of xorg-sgml-doctools adds references to 1583 other documents within or outside this package. 1584 1585 This patch adds technical support for this feature but does not change 1586 the content of the documentation as seen by the end user. 1587 1588 Each book or article must generate a database containing the href 1589 of sections that can be referred to from another document. This database 1590 is installed in DATAROOTDIR/sgml/X11/dbs. There is a requirement that 1591 the value of DATAROOTDIR for xorg-sgml-doctools and for the package 1592 documentation is the same. This forms a virtual document tree. 1593 1594 This database is consulted by other documents while they are being generated 1595 in order to fulfill the missing information for linking. 1596 Refer to the xorg-sgml-doctools for further technical information. 1597 1598 Co-authored-by: Matt Dew <marcoz (a] osource.org> 1599 1600 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1601 1602 commit 483d32621c06bcba0c7aa7794633b46b151fd5bf 1603 Author: Gaetan Nadon <memsize (a] videotron.ca> 1604 Date: Fri Feb 25 08:58:54 2011 -0500 1605 1606 Docbook: change the book id to match the xml file basename 1607 1608 This is required for the up-coming external references support. 1609 1610 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1611 1612 commit 4852c5bb1603fb6d401fe6895d9318555a8d4523 1613 Author: Gaetan Nadon <memsize (a] videotron.ca> 1614 Date: Wed Feb 2 19:13:54 2011 -0500 1615 1616 config: splitting ICE and XTRANS compiler options is not required 1617 1618 Simplify configuration by using a single PKG_CHECK_MODULES statement. 1619 1620 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1621 1622 commit 87d34a2f04c9d920da01802cd9707c8107746fa5 1623 Author: Gaetan Nadon <memsize (a] videotron.ca> 1624 Date: Wed Feb 2 11:43:40 2011 -0500 1625 1626 config: comment, minor upgrade, quote and layout configure.ac 1627 1628 Group statements per section as per Autoconf standard layout 1629 Quote statements where appropriate. 1630 Autoconf recommends not using dnl instead of # for comments 1631 1632 Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters. 1633 1634 This helps automated maintenance and release activities. 1635 Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines 1636 1637 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1638 1639 commit 548eded10385ccc336e66dac8bbabe05f3225ec2 1640 Author: Gaetan Nadon <memsize (a] videotron.ca> 1641 Date: Fri Jan 28 14:42:12 2011 -0500 1642 1643 config: remove unrequired AC_HEADER_STDC 1644 1645 Autoconf says: 1646 "This macro is obsolescent, as current systems have conforming 1647 header files. New programs need not use this macro". 1648 1649 commit 78b8e6b772685a2ed567ac2d30f96116f050dad5 1650 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1651 Date: Fri Jan 7 19:29:03 2011 -0800 1652 1653 Resync fallback asprintf with updated version put into xrdb 1654 1655 Fixes issues found during xrdb review on xorg-devel 1656 Also make sure <stdarg.h> is #included for varargs macros 1657 1658 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1659 1660 commit dc63c253e33b1012c08cd274e6e37bf0fa87c624 1661 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1662 Date: Tue Dec 21 18:28:36 2010 -0800 1663 1664 Add AC_USE_SYSTEM_EXTENSIONS to make asprintf() visible in GNU libc 1665 1666 asprintf is considered a GNU extension and thus one needs to define 1667 _GNU_SOURCE before including stdio.h. 1668 1669 Reported-by: Cyril Brulebois <kibi (a] debian.org> 1670 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1671 Reviewed-by: Mark Kettenis <kettenis (a] openbsd.org> 1672 Reviewed-by: Gaetan Nadon <memsize (a] videotron.ca> 1673 1674 commit 4b4ec3aeaa7cf5f5a6490ad2ddc2b07d090214cb 1675 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1676 Date: Sun Dec 19 09:57:05 2010 -0800 1677 1678 Use correct string pointer in asprintf() fallback 1679 1680 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1681 1682 commit 308c8d3d5fbf96c1d4f313def50d4b001ac0d685 1683 Author: Paulo Zanoni <przanoni (a] gmail.com> 1684 Date: Fri Dec 17 14:59:22 2010 -0200 1685 1686 Remove useless line from a table in specs/ice.xml 1687 1688 This seems to be a leftover from a manpage/groff conversion. 1689 1690 Signed-off-by: Paulo Zanoni <pzanoni (a] mandriva.com> 1691 Reviewed-by: Matt Dew 1692 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1693 1694 commit a72467b21662a63c81418731b540a8843d138750 1695 Author: Paulo Zanoni <pzanoni (a] mandriva.com> 1696 Date: Thu Dec 16 13:59:52 2010 -0200 1697 1698 Use docbookx.dtd version 4.3 for all docs 1699 1700 Signed-off-by: Paulo Zanoni <pzanoni (a] mandriva.com> 1701 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1702 1703 commit e0280caf7cc9d0e1c2df3ab7c5a4fbe4e42696a9 1704 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1705 Date: Sun Dec 5 01:15:42 2010 -0800 1706 1707 Convert src/process.c from malloc + sprintf to asprintf 1708 1709 Includes simple local implemenation of asprintf if configure doesn't 1710 find one in system libraries 1711 1712 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1713 Reviewed-by: Julien Cristau <jcristau (a] debian.org> 1714 1715 commit a5669dcb488db19b1ba4f1ef4d4565b6c3d1ea09 1716 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1717 Date: Sat Nov 20 19:47:53 2010 -0800 1718 1719 config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS 1720 1721 Regroup AC statements under the Autoconf initialization section. 1722 Regroup AM statements under the Automake initialization section. 1723 1724 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1725 1726 commit d902a9f27369fc8388774e73f4bee6ab0ad86ef5 1727 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1728 Date: Sat Nov 20 19:45:42 2010 -0800 1729 1730 config: Remove unnecessary calls from configure.ac 1731 1732 AC_PROG_CC is provided by XORG_DEFAULT_OPTIONS now 1733 PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables 1734 1735 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1736 1737 commit fd56c4e00a564d6385ccb2f8fadf10de201ae411 1738 Author: Gaetan Nadon <memsize (a] videotron.ca> 1739 Date: Tue Nov 9 11:28:48 2010 -0500 1740 1741 config: HTML file generation: use the installed copy of xorg.css 1742 1743 Currenlty the xorg.css file is copied in each location 1744 where a DocBook/XML file resides. This produces about 1745 70 copies in the $(docdir) install tree. 1746 1747 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1748 1749 commit 9856f5679b2b2d458cf830c1e8fdd206c724dfc5 1750 Author: Adam Jackson <ajax (a] redhat.com> 1751 Date: Tue Oct 19 11:19:08 2010 -0400 1752 1753 libICE 1.0.7 1754 1755 Signed-off-by: Adam Jackson <ajax (a] redhat.com> 1756 1757 commit 59a8d5609398824c81b72deb82735a55332ca239 1758 Author: Jeremy Huddleston <jeremyhu (a] apple.com> 1759 Date: Sun Oct 17 21:26:31 2010 -0700 1760 1761 Fix include ordering, so -I../include precedes $CPPFLAGS which could 1762 cause us to include installed rather than packaged headers. 1763 1764 Signed-off-by: Jeremy Huddleston <jeremyhu (a] apple.com> 1765 1766 commit 4a6f7a357222b2c1fa289d6e7b5fcc8c361e20e9 1767 Author: Jesse Adkins <jesserayadkins (a] gmail.com> 1768 Date: Tue Sep 28 13:30:01 2010 -0700 1769 1770 Purge cvs tags. 1771 1772 Signed-off-by: Jesse Adkins <jesserayadkins (a] gmail.com> 1773 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1774 1775 commit 5bb806a65bf23a507b135abe1e4a8b3cabc7b8aa 1776 Author: Matt Dew <matt (a] osource.org> 1777 Date: Wed Jun 30 16:52:22 2010 -0400 1778 1779 specs: convert ICE doc/specs from xorg-docs module to DocBook XML 1780 1781 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1782 1783 commit 9b54f509832c50c1fac0edc0cb78e1a3454a56dc 1784 Author: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1785 Date: Tue Jun 8 20:12:53 2010 -0700 1786 1787 Move ICE protocol & API specs from xorg-docs module 1788 1789 For now, just checked in and included in dist tarballs, not processed 1790 into a usable format - same as it was in xorg-docs 1791 1792 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] oracle.com> 1793 1794 commit 1967c04c021a4cfd7b3cdd4efdc13610b4385a65 1795 Author: Julien Cristau <jcristau (a] debian.org> 1796 Date: Tue May 11 16:36:20 2010 +0200 1797 1798 Set the close-on-exec flag for listening sockets 1799 1800 This prevents xsm from leaking file descriptors to the processes it 1801 starts. 1802 1803 X.Org bug#22932 <http://bugs.freedesktop.org/show_bug.cgi?id=22932> 1804 1805 Reported-by: Kalle Olavi Niemitalo <kon (a] iki.fi> 1806 Signed-off-by: Julien Cristau <jcristau (a] debian.org> 1807 1808 commit b6478dbedcca4d4cf44bd588c050bcc70c2f4963 1809 Author: Gaetan Nadon <memsize (a] videotron.ca> 1810 Date: Mon Apr 5 19:50:40 2010 -0400 1811 1812 config: update AC_PREREQ statement to 2.60 1813 1814 Unrelated to the previous patches, the new value simply reflects 1815 the reality that the minimum level for autoconf to configure 1816 all x.org modules is 2.60 dated June 2006. 1817 1818 ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz 1819 1820 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1821 1822 commit 8e175ff18649bd30e862b6a6a5f82a4ed4d5241a 1823 Author: Gaetan Nadon <memsize (a] videotron.ca> 1824 Date: Mon Mar 29 14:53:48 2010 -0400 1825 1826 config: remove the pkgconfig pc.in file from EXTRA_DIST 1827 1828 Automake always includes it in the tarball. 1829 1830 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1831 1832 commit 09d61dc024d9846525e4c97d33cdf03c9f06c151 1833 Author: Gaetan Nadon <memsize (a] videotron.ca> 1834 Date: Tue Feb 16 10:37:21 2010 -0500 1835 1836 config: move CWARNFLAGS from configure.ac to Makefile.am 1837 1838 Compiler warning flags should be explicitly set in the makefile 1839 rather than being merged with other packages compiler flags. 1840 1841 Signed-off-by: Gaetan Nadon <memsize (a] videotron.ca> 1842 1843 commit 72b8a2d39a57eb0640929b9bb9f276c6032f8213 1844 Author: Gaetan Nadon <memsize (a] videotron.ca> 1845 Date: Fri Nov 27 20:56:03 2009 -0500 1846 1847 Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES 1848 1849 Now that the INSTALL file is generated. 1850 Allows running make maintainer-clean. 1851 1852 commit 68231f8574e197a12eff1ddde37166d101567269 1853 Author: Gaetan Nadon <memsize (a] videotron.ca> 1854 Date: Wed Oct 28 14:09:10 2009 -0400 1855 1856 INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206 1857 1858 Add missing INSTALL file. Use standard GNU file on building tarball 1859 README may have been updated 1860 Remove AUTHORS file as it is empty and no content available yet. 1861 Remove NEWS file as it is empty and no content available yet. 1862 1863 commit b5cfc1cdd367c93660259a86b3b6683c57e5d76a 1864 Author: Gaetan Nadon <memsize (a] videotron.ca> 1865 Date: Tue Oct 27 15:07:25 2009 -0400 1866 1867 Deploy the new XORG_DEFAULT_OPTIONS #24242 1868 1869 This macro aggregate a number of existing macros that sets commmon 1870 X.Org components configuration options. It shields the configuration file from 1871 future changes. 1872 1873 commit 5524fa4d543932e4565b2235515fef9a5d9a501d 1874 Author: Gaetan Nadon <memsize (a] videotron.ca> 1875 Date: Mon Oct 26 22:08:41 2009 -0400 1876 1877 Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432 1878 1879 ChangeLog filename is known to Automake and requires no further 1880 coding in the makefile. 1881 1882 commit 82ad2d2053af2ad37697793b9718721aa3ff80a0 1883 Author: Gaetan Nadon <memsize (a] videotron.ca> 1884 Date: Thu Oct 22 12:34:18 2009 -0400 1885 1886 .gitignore: use common defaults with custom section # 24239 1887 1888 Using common defaults will reduce errors and maintenance. 1889 Only the very small or inexistent custom section need periodic maintenance 1890 when the structure of the component changes. Do not edit defaults. 1891 1892 commit 4b2289ad5481de7fa51941cf6c2ca7a2a3202690 1893 Author: Jeremy Huddleston <jeremyhu (a] freedesktop.org> 1894 Date: Wed Oct 21 12:47:23 2009 -0700 1895 1896 This is not a GNU project, so declare it foreign. 1897 1898 On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote: 1899 > On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote: 1900 > > I noticed an INSTALL file in xlsclients and libXvMC today, and it 1901 > > was quite annoying to work around since 'autoreconf -fvi' replaces 1902 > > it and git wants to commit it. Should these files even be in git? 1903 > > Can I nuke them for the betterment of humanity and since they get 1904 > > created by autoreconf anyways? 1905 > 1906 > See https://bugs.freedesktop.org/show_bug.cgi?id=24206 1907 1908 As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with 1909 AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation 1910 of the INSTALL file. It is also part of the 24206 solution. 1911 1912 Signed-off-by: Jeremy Huddleston <jeremyhu (a] freedesktop.org> 1913 1914 commit 94992c686a6850f2303aa78057a64a6369b64692 1915 Author: Peter Hutterer <peter.hutterer (a] who-t.net> 1916 Date: Fri Aug 28 14:17:50 2009 +1000 1917 1918 libICE 1.0.6 1919 1920 Signed-off-by: Peter Hutterer <peter.hutterer (a] who-t.net> 1921 1922 commit 7a8bb2a2c991919bcdef63359c74e239045a3f4c 1923 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 1924 Date: Mon Feb 2 20:34:30 2009 -0800 1925 1926 Add README with pointers to mailing list, bugzilla & git repos 1927 1928 Signed-off-by: Alan Coopersmith <alan.coopersmith (a] sun.com> 1929 1930 commit dbb950061f185e1ccf27bff9c71adc34ab4cfae0 1931 Author: Paulo Cesar Pereira de Andrade <pcpa (a] mandriva.com.br> 1932 Date: Wed Jan 28 16:55:37 2009 -0200 1933 1934 Janitor: Correct sparse warnings. 1935 1936 Also reorders some code in configure.ac and Makefile.am to 1937 match pattern used on other packages. 1938 1939 commit 2f41ddb3a917c4e71184452b68561a15593d33b8 1940 Author: Paulo Cesar Pereira de Andrade <pcpa (a] mandriva.com.br> 1941 Date: Tue Jan 6 17:25:25 2009 -0200 1942 1943 Update .gitignore. 1944 1945 Don't warn about files left after a build and/or make distcheck 1946 in 'git status -a'. 1947 1948 commit ab9dff549534c6d7b33f440bff7a841d60c1206c 1949 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1950 Date: Mon Dec 8 18:45:44 2008 +0100 1951 1952 bump to 1.0.5 1953 1954 commit 71695c4bf7ae07228605683f6cdeca0457c8495a 1955 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1956 Date: Mon Dec 8 18:44:26 2008 +0100 1957 1958 remove ChangeLog from EXTRA_DIST and CLEANFILES 1959 1960 commit 653f659fe65ae8c2a9fe5b1fdbfc78da43f2cf90 1961 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1962 Date: Mon Dec 8 18:41:34 2008 +0100 1963 1964 use memcmp instead of binaryEqual 1965 1966 suggested by Paulo Cesar Pereira de Andrade <pcpa (a] mandriva.com.br> 1967 http://lists.freedesktop.org/archives/xorg/2008-December/041222.html 1968 1969 commit bf138553afe6eecd0e6c218dc6ae4f63065e4196 1970 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1971 Date: Tue Dec 2 22:06:15 2008 +0100 1972 1973 Use NULL, not zero, for pointers 1974 1975 From Magnus Kessler <Magnus.Kessler (a] gmx.net> 1976 http://lists.freedesktop.org/archives/xorg/2008-October/039799.html 1977 http://lists.freedesktop.org/archives/xorg/attachments/20081030/b2ea5b1c/attachment-0001.bin 1978 1979 commit b01e82ce1deedb36c9696d4d27a3b9a5d5a52d08 1980 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1981 Date: Thu Oct 30 12:01:06 2008 +0100 1982 1983 ANSI C 1984 1985 convert all old style function declarations 1986 1987 see also: Paulo Cesar Pereira de Andrade <pcpa (a] mandriva.com.br> 1988 http://bugs.freedesktop.org/show_bug.cgi?id=14683 1989 http://bugs.freedesktop.org/attachment.cgi?id=14582 1990 1991 see also: Magnus Kessler <Magnus.Kessler (a] gmx.net> 1992 http://lists.freedesktop.org/archives/xorg/2008-October/039799.html 1993 http://lists.freedesktop.org/archives/xorg/attachments/20081030/b2ea5b1c/attachment-0001.bin 1994 1995 commit 2aba1bc0583aeb3ee6e26e3bfacd123abef744d9 1996 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 1997 Date: Mon Dec 1 23:06:22 2008 +0100 1998 1999 towards ANSI C 2000 2001 make _IceProcessCoreMessage and default error handlers static 2002 2003 commit 69a1b4b6d34291738dfbc3aa19d0ce3f2842ec8f 2004 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 2005 Date: Mon Dec 1 22:22:12 2008 +0100 2006 2007 Activate CWARNFLAGS with lots of gcc warnings 2008 2009 commit 898ed95cad1133940a83dcf428865c5d3fb2c939 2010 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 2011 Date: Mon Dec 1 22:18:45 2008 +0100 2012 2013 use xorg-macros-1.2.1 2014 2015 Use XORG_CHANGELOG for rule to generate ChangeLog from git log 2016 Use XORG_CWARNFLAGS for compiler warning flags, leave CFLAGS to user 2017 2018 commit a99fbad09ab850e65ddd57e4d4488e4726295e14 2019 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 2020 Date: Tue Oct 7 13:21:48 2008 -0700 2021 2022 Constify some arguments in libICE to clear warnings in libSM 2023 2024 This patch avoids the gcc (3.4.6) warnings: 2025 ../../libSM-1.0.3/src/sm_client.c:104: warning: passing arg 7 of `IceRegisterForProtocolSetup' from incompatible pointer type 2026 ../../libSM-1.0.3/src/sm_manager.c:168: warning: passing arg 7 of `IceRegisterForProtocolReply' from incompatible pointer type 2027 when compiling libSM 2028 2029 commit 3bceaeb3192ca75a14854d614e1621d28fb82274 2030 Author: Peter Breitenlohner <peb (a] mppmu.mpg.de> 2031 Date: Tue Oct 7 11:25:42 2008 -0700 2032 2033 define macros to 1 in icetrans.c to avoid redefined macro warnings 2034 2035 X.Org Bug #17947 <http://bugs.freedesktop.org/show_bug.cgi?id=17947> 2036 Patch #19444 <http://bugs.freedesktop.org/attachment.cgi?id=19444> 2037 2038 Define as 1 (one) as done by autoconf and the command line 2039 option, e.g. -DICE_t, not as empty. 2040 2041 This avoids the gcc (3.4.6) warnings: 2042 ../../libICE-1.0.4/src/icetrans.c:29:1: warning: "ICE_t" redefined 2043 ../config.h:38:1: warning: this is the location of the previous definition 2044 ../../libICE-1.0.4/src/icetrans.c:30:1: warning: "TRANS_CLIENT" redefined 2045 <command line>:6:1: warning: this is the location of the previous definition 2046 ../../libICE-1.0.4/src/icetrans.c:31:1: warning: "TRANS_SERVER" redefined 2047 <command line>:7:1: warning: this is the location of the previous definition 2048 2049 commit b707104f4dba0963ab17c1d6a29c1e3a848ea408 2050 Author: Alan Hourihane <alanh (a] tungstengraphics.com> 2051 Date: Tue Apr 29 00:41:40 2008 +0100 2052 2053 silence warning 2054 2055 commit e6b525aefc05b5203391699b00053ad52243cc6b 2056 Author: Colin Harrison <colin.harrison-at-virgin.net> 2057 Date: Tue Apr 29 00:40:48 2008 +0100 2058 2059 include for sleep() 2060 2061 commit ef58f37724b841ef2246757be27111775aa86559 2062 Author: Matthieu Herrb <matthieu.herrb (a] laas.fr> 2063 Date: Sun Mar 9 09:02:40 2008 +0100 2064 2065 nuke RCS Ids 2066 2067 commit 47d86e8343d3d0201166c4d75da2ec9c12638cc1 2068 Author: James Cloos <cloos (a] jhcloos.com> 2069 Date: Thu Dec 6 15:51:13 2007 -0500 2070 2071 Add missing PHONY line for automatic ChangeLog generation 2072 2073 commit f415da71dd26f128df7d550ecd7631f8888eb1d2 2074 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2075 Date: Mon Aug 20 13:21:07 2007 -0700 2076 2077 Version bump: 1.0.4 2078 2079 commit 8e08d3e4b8f00151b3a8b7eb88015dc15170e154 2080 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2081 Date: Mon Jun 4 15:40:22 2007 -0700 2082 2083 Add $(AM_CFLAGS) to lint flags to get correct Xtrans flags 2084 2085 commit cd900e40b5676874d076c35466fd7baa6a49b1f6 2086 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2087 Date: Thu Apr 5 15:05:52 2007 -0700 2088 2089 Replace many malloc(strlen()); strcpy() pairs with strdup() 2090 2091 commit 27f9a9324d58c9a7472c724c62f5b7ea0e1f4681 2092 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2093 Date: Thu Apr 5 14:43:05 2007 -0700 2094 2095 Provide ANSI C prototypes for more static functions 2096 2097 commit bb639803a779ceace05d183b653da88f010ab29c 2098 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2099 Date: Thu Apr 5 14:32:31 2007 -0700 2100 2101 Convert authutil.c static helpers to ANSI C prototypes to clear sparse warnings 2102 2103 commit 2179b2d467d69e45559b8e4f161a904a21f05321 2104 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2105 Date: Thu Apr 5 14:28:06 2007 -0700 2106 2107 Add hooks for checking source code with lint/sparse/etc. 2108 2109 commit 6b361c028b5ad931b61df86fae570f3ef9f41c15 2110 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2111 Date: Thu Apr 5 14:19:56 2007 -0700 2112 2113 Coverity #1086: Double free of pointer "*listenObjsRet" 2114 2115 Same bug, different function. 2116 2117 commit c9b3d016681d81aff32c74cdad75151bd538e6ab 2118 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2119 Date: Thu Apr 5 14:07:42 2007 -0700 2120 2121 Coverity #1085: Double free of pointer "*listenObjsRet" 2122 2123 If malloc failed in the loop in IceListenForConnections, the error path 2124 would free all previous allocations, then loop around and try again, and 2125 if it failed again, free the previous allocations again. On the other 2126 hand, if it succeeded on the later tries, then the memory would just be 2127 leaked, since the error would be returned and not the pointer to them. 2128 2129 commit 6039e865470af23948b0fe7d5dc0ea72da436b0e 2130 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2131 Date: Thu Apr 5 14:04:01 2007 -0700 2132 2133 Add *~ to .gitignore to skip emacs/patch droppings 2134 2135 commit bed718894bed98cbd45b02bd57fb7fc6fd5089aa 2136 Author: Daniel Stone <daniel (a] fooishbar.org> 2137 Date: Sat Dec 16 01:21:17 2006 +0200 2138 2139 bump to 1.0.3 2140 2141 commit cac788981906186442ddfb57a41f45911eb8223b 2142 Author: Daniel Stone <daniel (a] fooishbar.org> 2143 Date: Wed Dec 6 18:58:09 2006 +0200 2144 2145 Makefile.am: make ChangeLog hook safer 2146 Make ChangeLog hook as safe as possible. 2147 2148 commit 011d632e8ef3f738b9158e66d6da6876e3b53905 2149 Author: Adam Jackson <ajax (a] benzedrine.nwnk.net> 2150 Date: Fri Oct 13 15:49:52 2006 -0400 2151 2152 Bump to 1.0.2 2153 2154 commit 445661cd714685009ee9ba2358a274351381eabf 2155 Author: Adam Jackson <ajax (a] benzedrine.nwnk.net> 2156 Date: Thu Oct 12 18:37:57 2006 -0400 2157 2158 Fix ChangeLog hook to distcheck. 2159 2160 commit 5cba1c763ac9f79062523227b49a29f72e6069cf 2161 Author: Matthieu Herrb <matthieu.herrb (a] laas.fr> 2162 Date: Sun Jul 16 10:52:30 2006 +0200 2163 2164 set GIT_DIR=${srcdir}/.git for git-log 2165 2166 commit 86e0a93714a6ccdb8555fc2c48231d958cba383d 2167 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2168 Date: Thu Jul 13 14:58:44 2006 -0700 2169 2170 renamed: .cvsignore -> .gitignore 2171 2172 commit c87cb98979356fc55607c05a2b23207afc9beeb1 2173 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2174 Date: Tue Jul 11 13:48:08 2006 -0700 2175 2176 Replace static ChangeLog with rule copied from libX11 to generate from git log 2177 2178 commit 6066ab9b9914ec0cca3b8f36fa3f5ba323414621 2179 Author: Derek Wang <derek.wang (a] sun.com> 2180 Date: Tue Nov 23 12:00:32 2004 -0800 2181 2182 Sun bug #6193975: kde session manager core dumps in _IceWrite() 2183 2184 commit be25425ca38d23655a5a854c053e750e1cbd3dea 2185 Author: Alan Coopersmith <alan.coopersmith (a] sun.com> 2186 Date: Tue Jul 11 13:42:07 2006 -0700 2187 2188 renamed: .cvsignore -> .gitignore 2189 2190 commit 9b1bb5ab99bd386cc030cd456a576b37406da91c 2191 Author: Adam Jackson <ajax (a] nwnk.net> 2192 Date: Wed Apr 26 23:57:50 2006 +0000 2193 2194 Bump to 1.0.1 2195 2196 commit 96d7763487da6624ed85bee10b081e7138d2060d 2197 Author: Alan Coopersmith <Alan.Coopersmith (a] sun.com> 2198 Date: Mon Apr 10 16:44:40 2006 +0000 2199 2200 Coverity #664: Free memory allocated by EXTRACT_STRING in 2201 _IceDefaultErrorHandler after we're done fprintf()'ing it. 2202 2203 commit 2a30ec82f3bd2aa1f2566e97fee70403a8448de8 2204 Author: Kevin E Martin <kem (a] kem.org> 2205 Date: Thu Dec 15 00:24:27 2005 +0000 2206 2207 Update package version number for final X11R7 release candidate. 2208 2209 commit 881573d429c0a9ecfa2d6286d4eaece36ee50675 2210 Author: Kevin E Martin <kem (a] kem.org> 2211 Date: Sat Dec 3 05:49:42 2005 +0000 2212 2213 Update package version number for X11R7 RC3 release. 2214 2215 commit a15b179f2e8e359161d9133bac58dde57b7e78ae 2216 Author: Kevin E Martin <kem (a] kem.org> 2217 Date: Sat Nov 19 07:15:39 2005 +0000 2218 2219 Update pkgconfig files to separate library build-time dependencies from 2220 application build-time dependencies, and update package deps to work 2221 with separate build roots. 2222 2223 commit c386a08047582240adefafd3afc062e52fccae6f 2224 Author: Kevin E Martin <kem (a] kem.org> 2225 Date: Wed Nov 9 21:19:12 2005 +0000 2226 2227 Update package version number for X11R7 RC2 release. 2228 2229 commit c361e3919f2de3f4742904b04e73178edc76bf95 2230 Author: Adam Jackson <ajax (a] nwnk.net> 2231 Date: Sun Oct 23 20:12:19 2005 +0000 2232 2233 Bug #1893: Fix replies when peers use different major opcodes for the same 2234 subprotocol. (016_ICE_subprotocol_reply_fix.diff from Debian, by Jochen 2235 Voss) 2236 2237 commit 0b8ff6fbd8cd7f47ab9e6ccb6d4917564a2d13ee 2238 Author: Alan Coopersmith <Alan.Coopersmith (a] sun.com> 2239 Date: Sat Jul 30 19:15:15 2005 +0000 2240 2241 Add -D flags to clear various warnings (Stefan Dirsch) 2242 2243 commit 260d470a128c7eaa6d7484bb143aab353c4e98ec 2244 Author: Kevin E Martin <kem (a] kem.org> 2245 Date: Fri Jul 29 21:22:50 2005 +0000 2246 2247 Various changes preparing packages for RC0: 2248 - Verify and update package version numbers as needed 2249 - Implement versioning scheme 2250 - Change bug address to point to bugzilla bug entry form 2251 - Disable loadable i18n in libX11 by default (use --enable-loadable-i18n to 2252 reenable it) 2253 - Fix makedepend to use pkgconfig and pass distcheck 2254 - Update build script to build macros first 2255 - Update modular Xorg version 2256 2257 commit cf687b775f580a84a4a8e962814abe7bc47a3c52 2258 Author: Daniel Stone <daniel (a] fooishbar.org> 2259 Date: Sat Jul 16 06:22:34 2005 +0000 2260 2261 Set soversion to 6.3.0. 2262 2263 commit 6d1704defa0e57715bd22d30d6e789b36233dcf8 2264 Author: Keith Packard <keithp (a] keithp.com> 2265 Date: Sat Jul 9 05:59:01 2005 +0000 2266 2267 Add .cvsignore files 2268 2269 commit 2b6b8e40a63dd69a13f87c19dcf8dc2f477c304d 2270 Author: Daniel Stone <daniel (a] fooishbar.org> 2271 Date: Sun Jul 3 07:00:55 2005 +0000 2272 2273 Add Xtrans definitions (FONT_t, TRANS_CLIENT) to clean up warnings. 2274 Add XSERV_t, TRANS_SERVER, TRANS_REOPEN to quash warnings. 2275 Add #include <dix-config.h> or <xorg-config.h>, as appropriate, to all 2276 source files in the xserver/xorg tree, predicated on defines of 2277 HAVE_{DIX,XORG}_CONFIG_H. Change all Xfont includes to 2278 <X11/fonts/foo.h>. 2279 2280 commit 608ad35f102b188f554daf8c160a5edcf4e8031c 2281 Author: Daniel Stone <daniel (a] fooishbar.org> 2282 Date: Fri Jun 10 14:11:36 2005 +0000 2283 2284 Remove pointless include of Xlib.h. 2285 Fix #include path to bigreqstr.h. 2286 2287 commit 795460992b0dcd4aa2591be462a94942415c6028 2288 Author: Alexander Gottwald <alexander.gottwald (a] s1999.tu-chemnitz.de> 2289 Date: Thu Jun 9 15:54:47 2005 +0000 2290 2291 Replace <X11/transport.c> with <X11/Xtrans/transport.c> 2292 2293 commit ae7b4cca6bd5c1f4edea8cde80d7a3dfaaf2c4d3 2294 Author: Alexander Gottwald <alexander.gottwald (a] s1999.tu-chemnitz.de> 2295 Date: Thu Jun 9 15:52:02 2005 +0000 2296 2297 Replace <X11/Xtrans.h> with <X11/Xtrans/Xtrans.h> 2298 Copy Xtrans.h to exports/include/X11/Xtrans only 2299 2300 commit a0637be926e6da5db8d131e7914f1300f484c626 2301 Author: Alan Coopersmith <Alan.Coopersmith (a] sun.com> 2302 Date: Sat May 21 23:07:47 2005 +0000 2303 2304 xtrans: 2305 Create autoconf macro XTRANS_CONNECTION_FLAGS to provide standard set of 2306 --enable flags for which transports to support and common place to 2307 update for required libraries for platforms that need certain libs for 2308 certain transports 2309 ICE: 2310 Add ICE_t #define required by Xtrans headers. Replace static defines of 2311 LOCALCONN & UNIXCONN with new XTRANS_CONNECTION_FLAGS macro. 2312 X11: 2313 Moved transport type checks to new macro XTRANS_CONNECTION_FLAGS in 2314 xtrans.m4 in xtrans module so they can be shared by all modules using 2315 xtrans. 2316 2317 commit efdb2468119be0c62a379d91088a708ca8d37e1b 2318 Author: Adam Jackson <ajax (a] nwnk.net> 2319 Date: Thu May 19 00:22:32 2005 +0000 2320 2321 revert last change, didn't do right thing at all, sorry for the noise 2322 2323 commit ccf4efa5e204d4569b9b590f72baae807ec19903 2324 Author: Adam Jackson <ajax (a] nwnk.net> 2325 Date: Thu May 19 00:10:02 2005 +0000 2326 2327 Require automake 1.7 in AM_INIT_AUTOMAKE 2328 2329 commit 3458da101c943530861485c798538ce014eee6b0 2330 Author: Sren Sandmann Pedersen <sandmann (a] daimi.au.dk> 2331 Date: Tue May 17 21:25:15 2005 +0000 2332 2333 - Conditionally include config.h in xc/lib/SM 2334 - Add libSM to symlink.sh 2335 - Add SM build system 2336 2337 commit cae06ca0ce523eeb9a667ce3ae5bff066cf6ecd7 2338 Author: Sren Sandmann Pedersen <sandmann (a] daimi.au.dk> 2339 Date: Tue May 17 20:53:58 2005 +0000 2340 2341 - Conditionally include config.h in the ICE source. 2342 - Add ICE to symlink.sh 2343 2344 commit 9dd90f8f8e29bb1dd6fe84b4b1d2d75ef91bc336 2345 Author: Sren Sandmann Pedersen <sandmann (a] daimi.au.dk> 2346 Date: Tue May 17 20:52:35 2005 +0000 2347 2348 Add ICE directory + build system. 2349 2350 commit d1cfe2a6d4a392f64b6b9d9255ec329fb2a6a39a 2351 Author: Daniel Stone <daniel (a] fooishbar.org> 2352 Date: Fri Jan 28 19:15:39 2005 +0000 2353 2354 Move _IceGetPeerName into the ICE public API as IceGetPeerName; bump ICE 2355 soversion to 6.4 accordingly. Change SM's use to the public version. 2356 The old version will be retained for compatibility. 2357 2358 commit 8f0babf8450aa8097e063e13c95b1581843b2dd8 2359 Author: Egbert Eich <eich (a] suse.de> 2360 Date: Fri Apr 23 18:43:22 2004 +0000 2361 2362 Merging XORG-CURRENT into trunk 2363 2364 commit 111949a4a1d5b62e26016b555e12f8862c90ae44 2365 Author: Egbert Eich <eich (a] suse.de> 2366 Date: Sun Mar 14 08:31:52 2004 +0000 2367 2368 Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004 2369 2370 commit d4054eea34b2f4d345796ecadec8a96af93c4d0d 2371 Author: Egbert Eich <eich (a] suse.de> 2372 Date: Wed Mar 3 12:11:10 2004 +0000 2373 2374 Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004 2375 2376 commit 569bf16d182b043e7ab914202d4195baf4a8413a 2377 Author: Egbert Eich <eich (a] suse.de> 2378 Date: Thu Feb 26 13:35:18 2004 +0000 2379 2380 readding XFree86's cvs IDs 2381 2382 commit 14c9e41e551ab1b3a00807dbb8f2f215b96bcc81 2383 Author: Egbert Eich <eich (a] suse.de> 2384 Date: Thu Feb 26 09:22:34 2004 +0000 2385 2386 Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004 2387 2388 commit 45b73c360dc68b023194758bbb1cc59c021742a6 2389 Author: Kaleb Keithley <kaleb (a] freedesktop.org> 2390 Date: Thu Dec 4 22:02:52 2003 +0000 2391 2392 XFree86 4.3.99.901 (RC 1) 2393 2394 commit c919c3d0b355ef67dfa0b511eb1da488e5786d1b 2395 Author: Kaleb Keithley <kaleb (a] freedesktop.org> 2396 Date: Tue Nov 25 19:28:07 2003 +0000 2397 2398 XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folks 2399 2400 commit 72e353567f8927996a26e72848d86f692c3f0737 2401 Author: Kaleb Keithley <kaleb (a] freedesktop.org> 2402 Date: Fri Nov 14 16:48:46 2003 +0000 2403 2404 XFree86 4.3.0.1 2405 2406 commit ee452992357329f7af846eba8f5bbe61c5d27bfa 2407 Author: Kaleb Keithley <kaleb (a] freedesktop.org> 2408 Date: Fri Nov 14 15:54:36 2003 +0000 2409 2410 R6.6 is the Xorg base-line 2411
Indexes created Mon Oct 26 00:26:21 UTC 2026