ChangeLog revision 1009a292
1commit be1888a46e446dfcaa62ac0a97d96bb77b6816d4
2Author: Matt Turner <mattst88@gmail.com>
3Date:   Thu Dec 8 10:41:44 2022 -0500
4
5    libICE 1.1.1
6    
7    Signed-off-by: Matt Turner <mattst88@gmail.com>
8
9commit e176b676cff17948d68299c00dddefe41638c752
10Author: Arsen Arsenović <arsen@aarsen.me>
11Date:   Sun Dec 4 22:19:20 2022 +0100
12
13    ICEmsg: Fix C++ interoperability error due to static_assert define
14    
15    Commit 0269c687e954db7aca2a4344e32cb203315a00b6 added a static_assert helper
16    that gets defined to blank if left undefined by assert.h.  As this is not a
17    macro in other languages that use this header, this can lead to a compile-time
18    error.
19    
20    Bug: https://bugs.gentoo.org/884369
21
22commit 6c057be0f0aef0aeabb9a00e6814548fed0c125a
23Author: Alan Coopersmith <alan.coopersmith@oracle.com>
24Date:   Sat Dec 3 16:48:25 2022 -0800
25
26    libICE 1.1.0
27    
28    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
29
30commit f032db0964e6d73b4f3c3264c1f8fbbb023fdf4c
31Author: Alan Coopersmith <alan.coopersmith@oracle.com>
32Date:   Wed Nov 23 10:29:44 2022 -0800
33
34    configure: Use AC_SYS_LARGEFILE to enable large file support
35    
36    The only files libICE operates on are .ICEauthority files, which
37    it only uses internally and does not make available to other code,
38    so there is no concern about ABI mismatch here.
39    
40    While .ICEauthority files should never be more than 2gb in size,
41    they may be stored on filesystems with large inodes.
42    
43    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
44
45commit dd207b23f8d8ffe36e6727c813372a7858aafd02
46Author: Alan Coopersmith <alan.coopersmith@oracle.com>
47Date:   Thu Nov 10 10:02:24 2022 -0800
48
49    ice.pc.in: "Libs.Private" should be "Libs.private"
50    
51    Fixes: b9411f7 ("ice.pc.in: add -lbsd flags when required")
52    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
53
54commit 0515b88aa55e6e55d7ab2808d245fdd64f7863ff
55Author: Alan Coopersmith <alan.coopersmith@oracle.com>
56Date:   Thu Oct 27 19:01:46 2022 -0700
57
58    Avoid -Wdeclaration-after-statement warnings from static_assert
59    
60    Some implementations of static_assert() define a new variable.
61    Avoid warnings from those when calling static_assert() from a
62    macro that may not be at the top of a new code block.
63    
64    ../../src/accept.c: In function 'IceAcceptConnection':
65    ../../src/accept.c:159:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
66      159 |     IceGetHeader (iceConn, 0, ICE_ByteOrder,
67          |     ^~~~~~~~~~~~
68    ../../src/connect.c: In function 'IceOpenConnection':
69    ../../src/connect.c:254:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
70      254 |     IceGetHeader (iceConn, 0, ICE_ByteOrder,
71          |     ^~~~~~~~~~~~
72    ../../src/connect.c:340:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
73      340 |     IceGetHeaderExtra (iceConn, 0, ICE_ConnectionSetup,
74          |     ^~~~~~~~~~~~~~~~~
75    [...etc...]
76    
77    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
78
79commit 246cbc402aabe5e971c43d1a21b66ab4c602f1cf
80Author: Alan Coopersmith <alan.coopersmith@oracle.com>
81Date:   Thu Oct 27 18:42:47 2022 -0700
82
83    Only link with libbsd if needed for arc4random_buf() or getentropy()
84    
85    Avoid unnecessary library dependency when using a libc with these
86    functions included
87    
88    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
89
90commit 81da58f39d274ab7f822fb22e56b5b2027597a51
91Author: Guillem Jover <guillem@hadrons.org>
92Date:   Thu Oct 6 00:26:11 2022 +0000
93
94    Switch from libbsd to libbsd-overlay
95    
96    This is the preferred usage form for libbsd, as it makes the code more
97    portable and requires no special includes for libbsd, by transparently
98    injects the needed standard headers that would be used on a BSD.
99    
100    Signed-off-by: Guillem Jover <guillem@hadrons.org>
101
102commit 96c84e563610d5c7846e601605f675f3d3840dd2
103Author: Alan Coopersmith <alan.coopersmith@oracle.com>
104Date:   Wed Sep 14 16:29:32 2022 -0700
105
106    Handle arrays too large to fit in iceConn buffers
107    
108    Fixes numerous gcc warnings of the form:
109    
110    connect.c: In function ‘IceOpenConnection’:
111    ICElibint.h:160:25: warning: potential null pointer dereference [-Wnull-dereference]
112         *((CARD16 *) _pBuf) = _val; \
113                             ^
114    ICElibint.h:174:5: note: in expansion of macro ‘STORE_CARD16’
115         STORE_CARD16 (_pBuf, _len); \
116         ^~~~~~~~~~~~
117    connect.c:351:5: note: in expansion of macro ‘STORE_STRING’
118         STORE_STRING (pData, IceReleaseString);
119         ^~~~~~~~~~~~
120    
121    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
122
123commit 0269c687e954db7aca2a4344e32cb203315a00b6
124Author: Alan Coopersmith <alan.coopersmith@oracle.com>
125Date:   Wed Sep 7 14:22:44 2022 -0700
126
127    ICEmsg.h: Add static asserts that message header length <= ICE_OUTBUFSIZE
128    
129    A message header length larger than ICE_OUTBUFSIZE will cause
130    buffer overflows.
131    
132    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
133
134commit b399fc2b3c5c2cf5f0d36d98c372f353a8186d15
135Author: Alan Coopersmith <alan.coopersmith@oracle.com>
136Date:   Wed Sep 7 13:37:34 2022 -0700
137
138    IceFlush: signal fatal I/O error if bufptr is past end of buffer
139    
140    It should never happen, but has been possible in the past when
141    we didn't handle buffer checks properly - this would help us
142    catch it if a similar mistake ever happens again (or the wrong
143    memory pointer gets corrupted by something else).
144    
145    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
146
147commit 918d58772595e7cd9907a7b08874196442fbf599
148Author: Alan Coopersmith <alan.coopersmith@oracle.com>
149Date:   Wed Sep 7 13:36:28 2022 -0700
150
151    Refactor Fatal I/O error handling into a common function
152    
153    Reduce duplicated code in _IceRead() and _IceWrite()
154    
155    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
156
157commit 6ca1ea376c7c6c9dc719d607b7684d87bcf96712
158Author: Alan Coopersmith <alan.coopersmith@oracle.com>
159Date:   Wed Sep 7 11:33:13 2022 -0700
160
161    IceGetHeaderExtra: only include extra space in outbufptr if there's room
162    
163    If there's not room for it in the buffer, we already set pData to
164    NULL, but still set the outbufptr to include the space, which could
165    lead to IceFlush() reading past the end of the buffer.
166    
167    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
168
169commit 76fd1cf6534358426cddaed045514d79270275b5
170Author: Alan Coopersmith <alan.coopersmith@oracle.com>
171Date:   Sat Aug 20 16:54:52 2022 -0700
172
173    Only link to libbsd for arc4random_buf if it is not found in libc
174    
175    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
176
177commit 0124a9ea65118ae70bcc155e2a9a36a6c4869310
178Author: walter harms <wharms@bfs.de>
179Date:   Wed Oct 18 18:09:05 2017 +0200
180
181    make sure buffer is zero filled and report if allocation failed
182    
183    Signed-off-by: Walter Harms <wharms@bfs.de>
184    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
185
186commit 1e7787324a788fe84f7e438f4db9a47c8f6dd952
187Author: walter harms <wharms@bfs.de>
188Date:   Wed Oct 18 18:03:47 2017 +0200
189
190    add check for malloc
191    
192    fix a potential null pointer deference error
193    
194    Signed-off-by: Walter Harms <wharms@bfs.de>
195
196commit 7b439c788b94849d4f07cda77518bec43ebbd9a6
197Author: walter harms <wharms@bfs.de>
198Date:   Thu Sep 7 18:46:39 2017 +0200
199
200    connect.c: FIX 'iceConn' shadows a previous local, [-Wshadow]
201    
202    In function 'IceOpenConnection':  gcc give the following warning:
203     connect.c:106:11: warning: declaration of 'iceConn' shadows a previous local  [-Wshadow]
204    fixed by renaming 2. iceConn to iConn (and all its uses)
205    
206    Signed-off-by: Walter Harms <wharms@bfs.de>
207    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
208
209commit 348b9a46086ad72d6f29f2637036accff6630db4
210Author: Alan Coopersmith <alan.coopersmith@oracle.com>
211Date:   Sat Apr 30 15:17:40 2022 -0700
212
213    ProcessAuthReply: rename status variable to avoid shadowing
214    
215    Fixes gcc complaint:
216    
217    process.c: In function ‘ProcessAuthReply’:
218    process.c:1478:20: warning: declaration of ‘status’ shadows a previous local [-Wshadow]
219     1478 |             Status status = 1;
220          |                    ^~~~~~
221    process.c:1426:25: note: shadowed declaration is here
222     1426 |         IcePaAuthStatus status =
223          |                         ^~~~~~
224    
225    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
226
227commit d70c666549a9ee17de7349904529cf41bf023926
228Author: Alan Coopersmith <alan.coopersmith@oracle.com>
229Date:   Sat Apr 30 15:04:53 2022 -0700
230
231    ConnectToPeer: be doubly sure that use-after-free doesn't happen
232    
233    This resolves an issue reported by the Oracle Parfait static analyzer:
234    
235    Error: Use after free
236       Use after free [use-after-free] (CWE 416):
237          Use after free of pointer trans_conn
238            at line 566 of lib/libICE/src/connect.c in function 'ConnectToPeer'.
239              trans_conn previously freed with _IceTransClose at line 532
240              trans_conn was allocated at line 525 with _IceTransOpenCOTSClient
241    
242    even though I believe this is already handled by the
243    'if (madeConnection) { ... } else trans_conn = NULL;'
244    block, but the analyzer apparently doesn't follow that logic,
245    while this simple change makes it obvious.
246    
247    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
248
249commit 8d2cb9e7a897a070b2509f9de60961c9d154ee99
250Author: Alan Coopersmith <alan.coopersmith@oracle.com>
251Date:   Sat Apr 30 14:39:02 2022 -0700
252
253    configure: check for libbsd before libxtrans checks for strlcpy
254    
255    If we're going to link to libbsd, might as well use it for strlcpy too
256    
257    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
258
259commit 9a3534b3e0808a5294f85f2402a2b4410a153b76
260Author: Alan Coopersmith <alan.coopersmith@oracle.com>
261Date:   Sat Apr 30 14:27:55 2022 -0700
262
263    gitlab CI: add a basic build test
264    
265    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
266
267commit 410d2005f5a1f11e8204d9bc3432e0b145ae3161
268Author: Alan Coopersmith <alan.coopersmith@oracle.com>
269Date:   Sat Apr 30 14:08:43 2022 -0700
270
271    Fix spelling/wording issues
272    
273    Found by using:
274        codespell --builtin clear,rare,usage,informal,code,names
275    
276    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
277
278commit 08df47e4786d112a639915331702b4a27def6a56
279Author: Alan Coopersmith <alan.coopersmith@oracle.com>
280Date:   Sat Apr 30 13:58:58 2022 -0700
281
282    Build xz tarballs instead of bzip2
283    
284    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
285
286commit b9411f79f59b63d7d363234d795fa5c77cc738c9
287Author: David Callu <callu.david@gmail.com>
288Date:   Tue Apr 7 10:20:49 2020 +0200
289
290    ice.pc.in: add -lbsd flags when required
291
292commit 8e6a14c63d6b73cde87cb331439f2a4d19cba5b9
293Author: Alan Coopersmith <alan.coopersmith@oracle.com>
294Date:   Sun Jul 14 10:37:25 2019 -0700
295
296    libICE 1.0.10
297    
298    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
299
300commit b6aad584c1dc278364c295165512b5f5b98c173e
301Author: Olivier Fourdan <ofourdan@redhat.com>
302Date:   Thu Apr 11 09:05:15 2019 +0200
303
304    cleanup: Separate variable assignment and test
305    
306    Assigning and testing a value in a single statement hinders code clarity
307    and may confuses static code analyzers.
308    
309    Separate the assignment and the test for clarity.
310    
311    Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
312
313commit 772e5b0fdfc9dbd8bec070bd0c4c7eb5565df2ee
314Author: Olivier Fourdan <ofourdan@redhat.com>
315Date:   Wed Apr 10 11:15:11 2019 +0200
316
317    _IceRead: Avoid possible use-after-free
318    
319    `_IceRead()` gets called from multiple places which do not expect the
320    connection to be freed.
321    
322    Do not free the connection data in `_IceRead()` to avoid potential
323    use-after-free issue in the various callers.
324    
325    The connection data will be freed eventually in `ProcessWantToClose()`,
326    so not freeing it in `_IceRead()` should not introduce an memory leak.
327    
328    Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
329
330commit 1493beba2aa03bdadeed8b4fa5d424df6e113071
331Author: Olivier Fourdan <ofourdan@redhat.com>
332Date:   Wed Apr 10 11:01:31 2019 +0200
333
334    IceListenForWellKnownConnections: Fix memleak
335    
336    The function `_IceTransMakeAllCOTSServerListeners` allocates memory for
337    `transConns` which is leaked in case of error.
338    
339    Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
340
341commit a67a477eefdc93c32fa82da6ff0b4e69dd4c2ccb
342Author: Alan Coopersmith <alan.coopersmith@oracle.com>
343Date:   Sun Mar 24 15:29:34 2019 -0700
344
345    IceWritePad: always use zero values for pad bytes
346    
347    Previously it would just bump the pointer in the buffer leaving
348    whatever values were previously there in place.
349    
350    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
351
352commit 2318ace3340009c44e78eab094f159f0e0b4a197
353Author: Alan Coopersmith <alan.coopersmith@oracle.com>
354Date:   Sun Mar 24 14:36:10 2019 -0700
355
356    IceOpenConnection: check for malloc failure on connect_to_you too
357    
358    Fixes: https://gitlab.freedesktop.org/xorg/lib/libice/issues/4
359    
360    Reported-by: mahendra <mahendra.n@samsung.com>
361    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
362
363commit b484311c929a1b64966d89da92fafce7263006e1
364Author: Allison Lortie <desrt@desrt.ca>
365Date:   Tue Jun 14 16:09:46 2016 -0400
366
367    authutil: support $XDG_RUNTIME_DIR/ICEauthority
368    
369    If we find that $XDG_RUNTIME_DIR is set (and $ICEAUTHORITY is not), then
370    the ICEauthority file is stored in the XDG_RUNTIME_DIR instead of the
371    home directory, and without a leading dot.
372    
373    https://bugs.freedesktop.org/show_bug.cgi?id=49173
374    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
375
376commit 48ed5e04b5a8ba64dcfeea090cf3a32d3087b749
377Author: Allison Lortie <desrt@desrt.ca>
378Date:   Tue Jun 14 16:08:21 2016 -0400
379
380    authutil: fix an out-of-bounds access
381    
382    There is a theoretical edge case where the $HOME environment variable
383    could be set to the empty string.  IceAuthFileName() unconditionally
384    checks index 1 of this string, which is out of bounds.
385    
386    Fix that up by rejecting empty strings in the same way as we reject
387    NULL.
388    
389    https://bugs.freedesktop.org/show_bug.cgi?id=49173
390    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
391
392commit 468b83ec4810b4ea2373182b5801f998f3dcd471
393Author: Tobias Stoeckmann <tobias@stoeckmann.org>
394Date:   Mon Jul 30 20:50:58 2018 +0200
395
396    Always terminate strncpy results.
397    
398    The function strncpy does not guarantee to append a terminating
399    NUL character to the destination.
400    
401    This patch merges libSM's way of handling this issue into libICE.
402    
403    Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
404    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
405
406commit 1cc4ae8648590f04557a20c8d88d39cef7fe8119
407Author: walter harms <wharms@bfs.de>
408Date:   Thu Sep 7 18:52:13 2017 +0200
409
410    iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf'
411    
412    commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if
413    causing a gcc warning:
414    
415     In function 'arc4random_buf':
416     iceauth.c:89:13: warning: unused variable 'ret' [-Wunused-variable]
417    
418    fixed by moving  #if 1 up
419    
420    Signed-off-by:  Walter Harms <wharms@bfs.de>
421    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
422    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
423
424commit ccbcae7d3409789bf346ca35963264d064f54cba
425Author: Alan Coopersmith <alan.coopersmith@oracle.com>
426Date:   Fri Dec 7 19:29:55 2018 -0800
427
428    Update configure.ac bug URL for gitlab migration
429    
430    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
431
432commit e72ca90879db149bbee6232dd78a565e630e917d
433Author: Alan Coopersmith <alan.coopersmith@oracle.com>
434Date:   Sun Nov 18 21:48:59 2018 -0800
435
436    Update README for gitlab migration
437    
438    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
439
440commit dc73ec034c9083b8c7d980e80eb6d4c88bcfaa51
441Author: Alan Coopersmith <alan.coopersmith@oracle.com>
442Date:   Sat Nov 10 13:13:45 2018 -0800
443
444    Remove obsolete B16 & B32 tags in struct definitions
445    
446    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
447
448commit f66955f7250d7c150dfb97862878acc2222781e5
449Author: walter harms <wharms@bfs.de>
450Date:   Fri Sep 8 20:03:03 2017 +0200
451
452    make IceProtocolShutdown() more readable
453    
454    I found IceProtocolShutdown() hard to read only to find that was
455    it does it aktually very simple. So i rearranged the code to make
456    it more readable.
457    
458    Signed-off-by: Walter Harms <wharms@bfs.de>
459    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
460    [Emil Velikov: whitespace fixes]
461    Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
462
463commit 936dcaac07f7db569ed91a34e0a4b5944aac205f
464Author: walter harms <wharms@bfs.de>
465Date:   Fri Sep 8 19:59:17 2017 +0200
466
467    Drop NULL check prior to free()
468    
469    free() can handle NULL just fine - remove the check.
470    
471    Signed-off-by: Walter Harms <wharms@bfs.de>
472    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
473    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
474
475commit 43644931cb9cb5cc92391f6f5431535b9b7a3f24
476Author: Eric Engestrom <eric.engestrom@imgtec.com>
477Date:   Fri Jul 7 11:23:48 2017 +0100
478
479    Make sure string is never NULL
480    
481    `error_message` is passed in to strncpy() without any check, which
482    doesn't handle NULL itself, so let's make it a valid empty string in
483    cases where it was NULL.
484    
485    Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
486    Acked-by: Walter Harms <wharms@bfs.de>
487    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
488
489commit e8c21056134498c49733f6baf572ffbb051ed886
490Author: Eric Engestrom <eric.engestrom@imgtec.com>
491Date:   Fri Jul 7 11:23:47 2017 +0100
492
493    Make sure error_message is a free-able string
494    
495    Similar to the previous commit, assigning a static string would crash
496    upon freeing.
497    
498    Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
499    Acked-by: Walter Harms <wharms@bfs.de>
500    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
501
502commit 7a7844bf5ade915268fe7f9b292908c6cd75f3ba
503Author: Eric Engestrom <eric.engestrom@imgtec.com>
504Date:   Fri Jul 7 11:23:46 2017 +0100
505
506    Make sure errorStr is a free-able string
507    
508    If the `errorClass` isn't handled by the switch, `errorStr`'s initial
509    value would be a pointer to some static memory with an empty string,
510    and freeing it would most likely crash.
511    
512    Let's set it to NULL instead, as is done in other similar places.
513    
514    Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
515    Acked-by: Walter Harms <wharms@bfs.de>
516    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
517
518commit 7ef9680caa8c223a09beb637e26fd3471128e6ba
519Author: Emil Velikov <emil.l.velikov@gmail.com>
520Date:   Sun May 8 09:19:36 2016 +0100
521
522    configure.ac: set TRANS_CLIENT/SERVER
523    
524    Similar to ICE_t just set the define globally and remove the multiple
525    definitions throughout the tree
526    
527    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
528    Reviewed-by: Adam Jackson <ajax@redhat.com>
529    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)
530
531commit ab64a947b5de5b778f31ede9cfce386566023a14
532Author: Emil Velikov <emil.l.velikov@gmail.com>
533Date:   Sun May 8 09:19:35 2016 +0100
534
535    Kill off local ICE_t definitions
536    
537    Already defined at global scale in configure.ac
538    
539    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
540    Reviewed-by: Adam Jackson <ajax@redhat.com>
541    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)
542
543commit f4c00d345edf3dad5893b50ff0ae7cd3e0cfd780
544Author: Emil Velikov <emil.l.velikov@gmail.com>
545Date:   Sun May 8 09:19:34 2016 +0100
546
547    Remove unneeded ^L symbols.
548    
549    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
550    Reviewed-by: Adam Jackson <ajax@redhat.com>
551    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)
552
553commit d603d7d7d989c4ff1094810e9fcf2a29bc00bb0c
554Author: Emil Velikov <emil.l.velikov@gmail.com>
555Date:   Sun May 8 09:19:33 2016 +0100
556
557    Kill off Time_t macro
558    
559    Analogous to previous commit, including the megacommit that removed the
560    need for it.
561    
562    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
563    Reviewed-by: Adam Jackson <ajax@redhat.com>
564    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)
565
566commit 82250f26fc76d7b7574cfd472646a98e325d944a
567Author: Emil Velikov <emil.l.velikov@gmail.com>
568Date:   Sun May 8 09:19:32 2016 +0100
569
570    Kill off Strstr macro
571    
572    Directly use the strstr function as opposed to wrapping it in a macro.
573    The latter is no longer needed as of
574    
575    commit 72e353567f8927996a26e72848d86f692c3f0737
576    Author: Kaleb Keithley <kaleb@freedesktop.org>
577    Date:   Fri Nov 14 16:48:46 2003 +0000
578    
579        XFree86 4.3.0.1
580    
581    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
582    Reviewed-by: Adam Jackson <ajax@redhat.com>
583    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)
584
585commit ff5e59f32255913bb1cdf51441b98c9107ae165b
586Author: Benjamin Tissoires <benjamin.tissoires@gmail.com>
587Date:   Tue Apr 4 19:12:53 2017 +0200
588
589    Use getentropy() if arc4random_buf() is not available
590    
591    This allows to fix CVE-2017-2626 on Linux platforms without pulling in
592    libbsd.
593    The libc getentropy() is available since glibc 2.25 but also on OpenBSD.
594    For Linux, we need at least a v3.17 kernel. If the recommended
595    arc4random_buf() function is not available, emulate it by first trying
596    to use getentropy() on a supported glibc and kernel. If the call fails,
597    fall back to the current (partly vulnerable) code.
598    
599    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
600    Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
601    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
602    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
603
604commit 1746abbb1ae1c41ba29c14895c5bd3f1334faef5
605Author: Mihail Konev <k.mvc@ya.ru>
606Date:   Thu Jan 26 13:52:49 2017 +1000
607
608    autogen: add default patch prefix
609    
610    Signed-off-by: Mihail Konev <k.mvc@ya.ru>
611
612commit 3aa14db63fefb7634b1bd4370e33ba14c4ea90ae
613Author: Emil Velikov <emil.l.velikov@gmail.com>
614Date:   Mon Mar 9 12:00:52 2015 +0000
615
616    autogen.sh: use quoted string variables
617    
618    Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
619    fall-outs, when they contain space.
620    
621    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
622    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
623    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
624
625commit d41c57eaa0c1474acf0a6fb271f22106e3070016
626Author: Peter Hutterer <peter.hutterer@who-t.net>
627Date:   Tue Jan 24 10:32:07 2017 +1000
628
629    autogen.sh: use exec instead of waiting for configure to finish
630    
631    Syncs the invocation of configure with the one from the server.
632    
633    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
634    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
635
636commit ac4bb20e74e064b219de70e9b54516a921fdb7c3
637Author: Tobias Stoeckmann <tobias@stoeckmann.org>
638Date:   Tue Nov 22 20:13:29 2016 +0100
639
640    Fix use after free on subsequent calls
641    
642    The function IceAuthFileName is vulnerable to a use after free. The
643    flaw can be triggered by calling the function three times:
644    
645    - First call succeeds and stores the path in buf, a dynamically
646      allocated buffer with size bsize.
647    - Second call fails due to out of memory. It frees buf, but keeps
648      the old size in bsize.
649    - Third call only checks if bsize is large enough. Then it uses
650      buf without allocating it again -- the use after free happens.
651    
652    In order to exploit this, an attacker must change environment variables
653    between each call, namely ICEAUTHORITY or HOME. It also takes subsequent
654    calls. Due to these limitations, I don't consider this to be of high
655    priority.
656    
657    Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
658
659commit b1720edc9b9f3e7a05caa3fcd81761e5818ea255
660Author: Remko van der Vossen <bugs@yuugen.jp>
661Date:   Sun Jul 19 08:34:11 2015 -0700
662
663    Bug 90616 - libICE build fails on array bounds check
664    
665    https://bugs.freedesktop.org/show_bug.cgi?id=90616
666    
667    Recent versions of gcc have array bounds checking turned on by default,
668    this leads to build failures of libICE. As the _IceVersionCount variable
669    in ICElibint.h is not declared const the compiler cannot assume that the
670    nested for loop in ProcessConnectionSetup stays within bounds.
671    
672    The simple fix is of course to change the declarations of _IceVersionCount,
673    _IceVersions, and the local variable myVersionCount to const declarations.
674    
675    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
676    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
677
678commit 8a511dad53774693ed818d54d7896e1663942b18
679Author: Jon TURNEY <jon.turney@dronecode.org.uk>
680Date:   Sat Sep 13 17:13:44 2014 +0100
681
682    Include unistd.h for getpid()
683    
684    Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
685    Reviewed-by: David Macek <david.macek.0@gmail.com>
686
687commit fd22b62ae6380ddb00fa4c750f5ce175d2a6e76f
688Author: Alan Coopersmith <alan.coopersmith@oracle.com>
689Date:   Sun Sep 14 13:08:17 2014 -0700
690
691    spec: Convert troff \*Q..\*U to DocBook <quote>...</quote>
692    
693    Reported-by: Jasper St. Pierre <jstpierre@mecheye.net>
694    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
695    Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>
696
697commit 0dfab4253e26d5c6e5f058126eb5e9f7a7732ae8
698Author: Alan Coopersmith <alan.coopersmith@oracle.com>
699Date:   Fri Jun 6 18:28:28 2014 -0700
700
701    libICE 1.0.9
702    
703    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
704
705commit 9fb6ba03d7183ae06644f8a747fdb99b970d65fc
706Author: Alan Coopersmith <alan.coopersmith@oracle.com>
707Date:   Tue Dec 24 09:35:02 2013 -0800
708
709    Delete unused name variable in register.c
710    
711    Found by cppcheck 1.62:
712    [src/register.c:84]: (style) Variable 'name' is assigned a value
713     that is never used.
714    [src/register.c:182]: (style) Variable 'name' is assigned a value
715     that is never used.
716    
717    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
718
719commit c5060918164168c0a4f737b76e92df3c03356dc6
720Author: Alan Coopersmith <alan.coopersmith@oracle.com>
721Date:   Tue Dec 24 09:18:17 2013 -0800
722
723    Free iceConn->connection_string when unwinding after malloc fails
724    
725    Found by cppcheck 1.62:
726    [src/accept.c:113]: (error) Memory leak: iceConn.connection_string
727    
728    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
729
730commit 80f62c54fbd50a3bbdf9c37258525098c9117830
731Author: Matthieu Herrb <matthieu.herrb@laas.fr>
732Date:   Thu Aug 29 22:18:14 2013 +0200
733
734    Use arc4random when available to produce the auth cookie.
735    
736    arc4random() and associated functions can be found in libbsd on
737    GNU/Linux systems.
738    
739    Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
740    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
741
742commit 2312ee00402088307e69589c3d12529b5232df66
743Author: Alan Coopersmith <alan.coopersmith@oracle.com>
744Date:   Thu Aug 8 23:01:30 2013 -0700
745
746    Make STORE_STRING cast strlen result to CARD16 when storing in CARD16
747    
748    Clears a number of clang warnings of the form:
749    
750    connect.c:328:6: warning: implicit conversion loses integer precision:
751       'size_t' (aka 'unsigned long') to 'CARD16' (aka 'unsigned short')
752       [-Wconversion]
753                STORE_STRING (pData, _IceAuthNames[i]);
754                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
755    ./ICElibint.h:173:19: note: expanded from macro 'STORE_STRING'
756        CARD16 _len = strlen (_string); \
757               ~~~~   ^~~~~~~~~~~~~~~~
758    
759    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
760
761commit 6d6aa84dc6acb2daa3ef7e20942c38a1416bf543
762Author: Alan Coopersmith <alan.coopersmith@oracle.com>
763Date:   Thu Aug 8 22:58:46 2013 -0700
764
765    Cast assignments in IceErrorHeader() macro
766    
767    Clears many clang warnings about implicit conversions losing
768    integer precision, such as from storing ints into CARD8 or CARD16.
769    
770    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
771
772commit 9450bb648ef98efd6f08ea7d14ab8b9ea6e7bb54
773Author: Alan Coopersmith <alan.coopersmith@oracle.com>
774Date:   Thu Aug 8 22:47:41 2013 -0700
775
776    Make write_string call write_counted_string instead of copying it
777    
778    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
779
780commit 84153eee4db318cd897c464e70cb9f8bc8e469f6
781Author: Alan Coopersmith <alan.coopersmith@oracle.com>
782Date:   Thu Aug 8 22:37:09 2013 -0700
783
784    Mark input arguments to write_string functions as const
785    
786    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
787
788commit 9a74512ffdc1628f1b87d2191439915c63b9104f
789Author: Alan Coopersmith <alan.coopersmith@oracle.com>
790Date:   Thu Aug 8 22:31:41 2013 -0700
791
792    Stop casting return values from malloc
793    
794    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
795
796commit 4033226105fa861ab5f0276850afc24c0fa45406
797Author: Alan Coopersmith <alan.coopersmith@oracle.com>
798Date:   Thu Aug 8 22:17:27 2013 -0700
799
800    Get rid of casts to (char *) in calls to free()
801    
802    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
803
804commit 10c30ae6a7df1a7c352a1d611a313dffcaa42082
805Author: Alan Coopersmith <alan.coopersmith@oracle.com>
806Date:   Sat Jul 20 14:48:33 2013 -0700
807
808    Convert remaining sprintf() call to snprintf()
809    
810    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
811
812commit 0a94633e3d805ca477fba6b7acb673d055a3f43d
813Author: Alan Coopersmith <alan.coopersmith@oracle.com>
814Date:   Sat Jul 20 14:46:09 2013 -0700
815
816    Convert strcpy/strcat pairs to snprintf calls
817    
818    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
819
820commit 0d276835222eeb57de56f56cd9e12611b1d30466
821Author: Alan Coopersmith <alan.coopersmith@oracle.com>
822Date:   Sat Jul 20 14:35:11 2013 -0700
823
824    Fix some clang warnings about integer sign/size conversions
825    
826    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
827
828commit bb3d8a7767cf260b97c7e019e4fec0ee7d7b65a8
829Author: Alan Coopersmith <alan.coopersmith@oracle.com>
830Date:   Sat Jul 20 14:24:04 2013 -0700
831
832    unifdef WORD64
833    
834    Remove leftover remnants of CRAY support, which still had some
835    functions consisting solely of /* NOT IMPLEMENTED YET */ comments.
836    
837    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
838
839commit 9561eca1ad28afee6dcd0aebea3dd20a154ec481
840Author: Alan Coopersmith <alan.coopersmith@oracle.com>
841Date:   Thu Jul 18 00:36:28 2013 -0700
842
843    Constify filename argument to IceLockAuthFile & IceUnlockAuthFile
844    
845    Needed to fix const string warnings in iceauth - functions already
846    copy provided arguments to temporary local buffer for modifications.
847    
848    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
849    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
850
851commit 1b1cf8072b2559e15ac440d5484a29a81d6918c6
852Author: Colin Walters <walters@verbum.org>
853Date:   Wed Jan 4 17:37:06 2012 -0500
854
855    autogen.sh: Implement GNOME Build API
856    
857    http://people.gnome.org/~walters/docs/build-api.txt
858    
859    Signed-off-by: Adam Jackson <ajax@redhat.com>
860
861commit 5e784ca7f37823e62733765371c0b8ed1c58e5aa
862Author: Adam Jackson <ajax@redhat.com>
863Date:   Tue Jan 15 14:28:48 2013 -0500
864
865    configure: Remove AM_MAINTAINER_MODE
866    
867    Signed-off-by: Adam Jackson <ajax@redhat.com>
868
869commit e1677ce019219ac164d99f1e04f17caf16fc785a
870Author: Alan Coopersmith <alan.coopersmith@oracle.com>
871Date:   Fri Jan 4 19:32:08 2013 -0800
872
873    unifdef -U__UNIXOS2__
874    
875    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
876
877commit f166e8bbf16ec214fefdcf02ce81f80442899cb7
878Author: Alan Coopersmith <alan.coopersmith@oracle.com>
879Date:   Fri Mar 2 19:59:50 2012 -0800
880
881    libICE 1.0.8
882    
883    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
884
885commit c87ecd959d61ae97d8a2bd82efc761bb3e299061
886Author: Matt Dew <marcoz@osource.org>
887Date:   Mon Jan 9 21:25:18 2012 -0700
888
889    informaltable cleanup
890    
891    On certain tables, add top and bottom borders to table header
892    and a bottom border to the table. This matches what those
893    tables in the old pdfs looked like.
894    
895    the <?dbfo keep-together='always'> prevents tables from
896    splitting across pages. Useful for tiny tables.
897    
898    Converting the colwidth to a floating point, IE, 1* -> 1.0*
899    cleans up these build errors:
900    WARNING: table-layout="fixed" and column-width unspecified =>
901    falling back to proportional-column-width(1)
902    
903    Signed-off-by: Matt Dew <marcoz@osource.org>
904
905commit 8b4321a37a9fa2ad24bf87afabba6b08dcfded12
906Author: Alan Coopersmith <alan.coopersmith@oracle.com>
907Date:   Thu Nov 24 12:42:36 2011 -0800
908
909    Plug minor memory leak in unusual path through ProcessConnectionSetup
910    
911    Error: Memory leak (CWE 401)
912       Memory leak of pointer 'release' allocated with malloc((_len + 1))
913            at line 1100 of src/process.c in function 'ProcessConnectionSetup'.
914              'release' allocated at line 920 with malloc((_len + 1)).
915              release leaks when _i >= hisAuthCount at line 925
916                  and i >= _IceAuthCount at line 973
917                  and found != 0 at line 998
918                  and status != 0 at line 1053
919                  and status != 1 at line 1070
920                  and accept_setup_now == 0 at line 1082
921                  and i >= hisAuthCount at line 1093.
922       Memory leak of pointer 'vendor' allocated with malloc((_len + 1))
923            at line 1100 of src/process.c in function 'ProcessConnectionSetup'.
924              'vendor' allocated at line 919 with malloc((_len + 1)).
925              vendor leaks when _i >= hisAuthCount at line 925
926                  and i >= _IceAuthCount at line 973
927                  and found != 0 at line 998
928                  and status != 0 at line 1053
929                  and status != 1 at line 1070
930                  and accept_setup_now == 0 at line 1082
931                  and i >= hisAuthCount at line 1093.
932    
933    [ This bug was found by the Parfait 0.3.7 bug checking tool.
934      For more information see http://labs.oracle.com/projects/parfait/ ]
935    
936    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
937    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
938
939commit caf9e3393d5d517ea129392d001a2c46a7c1f325
940Author: Alan Coopersmith <alan.coopersmith@oracle.com>
941Date:   Sat Nov 19 00:26:29 2011 -0800
942
943    Constify protocol, vendor & release string args to IceRegisterForProtocol*
944    
945    Needed to resolve gcc -Wwrite-strings warnings in callers.
946    These functions only pass the strings to strcmp before calling
947    strdup to make their own private copy for storing away.
948    
949    While fixing the API docs to match, also fix them to match the existing
950    function prototypes, where there were several errors before (including
951    just plain missing most of the args to IceRegisterForProtocolReply).
952    
953    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
954    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
955
956commit 59c1555dff34804c78c7e7443ad13f27300927eb
957Author: Alan Coopersmith <alan.coopersmith@oracle.com>
958Date:   Wed Nov 9 22:07:34 2011 -0800
959
960    Remove ancient workaround for System V/386 Release 4.2 compiler bug
961    
962    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
963    Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
964    Reviewed-by: walter <wharms@bfs.de>
965    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
966
967commit bec4e9c9089fa4cc5a50fc513a3544cf6fd59bf1
968Author: Alan Coopersmith <alan.coopersmith@oracle.com>
969Date:   Wed Nov 9 22:06:36 2011 -0800
970
971    Fix gcc -Wwrite-strings warnings in process.c
972    
973    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
974    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
975
976commit ffa659dd6dd1fb8847bfdcc5e1e2be353b6395b6
977Author: Alan Coopersmith <alan.coopersmith@oracle.com>
978Date:   Wed Nov 9 21:37:48 2011 -0800
979
980    Fix gcc -Wwrite-strings warnings in AuthNames handling
981    
982    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
983    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
984
985commit 902a52ea9d7b6e6f56f7023009859072854a0fc7
986Author: Alan Coopersmith <alan.coopersmith@oracle.com>
987Date:   Wed Nov 9 21:55:17 2011 -0800
988
989    constify arguments to IceGetAuthFileEntry
990    
991    Needed to clear gcc -Wwrite-strings warnings in callers
992    
993    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
994    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
995
996commit 9ff1f97e46903f8f83363f07cf021989bfa6a9f0
997Author: Alan Coopersmith <alan.coopersmith@oracle.com>
998Date:   Wed Nov 9 21:43:59 2011 -0800
999
1000    Fix gcc -Wwrite-strings warnings in _IceError* functions
1001    
1002    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1003    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1004
1005commit e8a16534a9406d5096d9c0ea515d979c7c15e084
1006Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1007Date:   Wed Nov 9 21:23:33 2011 -0800
1008
1009    Fix gcc -Wwrite-strings warnings in _IceDefaultErrorHandler
1010    
1011    Had to split char *str into two variables, const char *str for the
1012    string literals just being passed to fprintf etal.  and char *estr
1013    for use by EXTRACT_STRING for the results of malloc calls that get
1014    written to and then freed.
1015    
1016    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1017    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1018
1019commit 4fbcba4ee19a49c05440861e1278bc97d29048e0
1020Author: Matt Dew <marcoz@osource.org>
1021Date:   Tue Oct 4 23:32:02 2011 -0600
1022
1023    Cleanup IDs and links in doc
1024    
1025    1 - fix the capitalization of the ID attributes to match either the
1026         <title> or <funcdef> string it goes with.
1027    2 - fix any <linkend>'s that were affected by 1.
1028    3 - any <function> in the docs that has an actual funcdef,
1029    will become an olink.
1030    
1031    Signed-off-by: Matt Dew <marcoz@osource.org>
1032
1033commit d4e161e35335df82f412d2d2bb1ef95ff3e88401
1034Author: Gaetan Nadon <memsize@videotron.ca>
1035Date:   Mon Sep 19 15:34:47 2011 -0400
1036
1037    As of 1997, X Window System is a trademark of The Open Group.
1038    
1039    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1040
1041commit fc0fc948d25dfa0f6f445a3b55610ea5b864dd60
1042Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1043Date:   Fri Sep 16 22:09:18 2011 -0700
1044
1045    Strip trailing whitespace
1046    
1047    Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
1048    git diff -w & git diff -b show no diffs from this change
1049    
1050    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1051
1052commit 22601de3f38d035eb874d4bd9f649ddd2b3f0ae2
1053Author: Gaetan Nadon <memsize@videotron.ca>
1054Date:   Sun Sep 11 17:20:20 2011 -0400
1055
1056    specs: remove <productnumber> which is not used by default
1057    
1058    This element is not rendered by default on the title. A template
1059    customization is required to display it.
1060    X Window System does not have a product number.
1061    
1062    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1063    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1064
1065commit 7f330738f1f5862950b3baa35ff08446093bfd4e
1066Author: Gaetan Nadon <memsize@videotron.ca>
1067Date:   Sun Sep 11 17:06:00 2011 -0400
1068
1069    specs: use DocBook suggested markup for Copyrights
1070    
1071    Puts the statement on a single line, using commas to separate years
1072       --> Copyright © 1993, 1994, 1996 X Consortium
1073    
1074    As opposed to 3 double-spaced lines.
1075    
1076    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1077    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1078
1079commit d68d2d2031f623a969784e702c97a07b8cd99010
1080Author: Gaetan Nadon <memsize@videotron.ca>
1081Date:   Sun Sep 11 16:56:21 2011 -0400
1082
1083    specs: remove orphan <corpname>
1084    
1085    It does not display on the title page and is redundant.
1086    No visible change on the doc.
1087    
1088    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1089
1090commit 87c934b9b7973a814763670e2dfad0579a8dcc78
1091Author: Gaetan Nadon <memsize@videotron.ca>
1092Date:   Sun Sep 11 16:27:09 2011 -0400
1093
1094    specs: use the &fullrelvers; entity to set X11 release information
1095    
1096    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1097    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1098
1099commit 41f04fd8673db5c2d8e587ab2c169a694bd7528f
1100Author: Gaetan Nadon <memsize@videotron.ca>
1101Date:   Sun Sep 11 14:13:35 2011 -0400
1102
1103    ice.xml: version number is 1.1, not 1.0
1104    
1105    This is what it was before the conversion from roff to docbook.
1106    
1107    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1108    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1109
1110commit 9e2a596b4ff06fc9c70dfcd94506e536e351ee0b
1111Author: Gaetan Nadon <memsize@videotron.ca>
1112Date:   Sun Sep 11 14:11:28 2011 -0400
1113
1114    ice.xml: fix orphan affiliation
1115    
1116    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1117
1118commit 1309d477a061d165345b602e122990eaab71a0d4
1119Author: Gaetan Nadon <memsize@videotron.ca>
1120Date:   Fri Sep 9 21:21:57 2011 -0400
1121
1122    ICElib doc: remove empty revision list and specify the doc version number
1123    
1124    Revision histories are not used, only 3 docs out of 63 have one.
1125    
1126    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1127    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1128
1129commit e9d57773df26ad9440a49f58941b511e594605a4
1130Author: Gaetan Nadon <memsize@videotron.ca>
1131Date:   Thu Sep 8 20:00:00 2011 -0400
1132
1133    docbook.am: embed css styles inside the HTML HEAD element
1134    
1135    Rather than referring to the external xorg.css stylesheet, embed the content
1136    of the file in the html output produced. This is accomplished by using
1137    version 1.10 of xorg-xhtml.xsl.
1138    
1139    This makes the whole html docs tree much more relocatable.
1140    In addition, it eliminates xorg.css as a runtime file which makes
1141    xorg-sgml-doctools a build time only package.
1142    
1143    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1144
1145commit b83cbed755315f6300133f2621cbe99bdc06345a
1146Author: Gaetan Nadon <memsize@videotron.ca>
1147Date:   Wed Sep 7 10:31:04 2011 -0400
1148
1149    docbook.am: global maintenance update - entities, images and olinking
1150    
1151    Adding support in libX11 for html chunking caused a reorg of docbook.am
1152    as well as the xorg-sgml-doctools masterdb for olinking.
1153    The parameter img.src.path is added for pdf images.
1154    A searchpath to the root builddir is added for local entities, if present.
1155    
1156    The docbook.am makefile hides all the details and is identical for
1157    all 22 modules having DocBook documentation. It is included by a thin
1158    Makefile.am which requires no docbook knowledge.
1159    
1160    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1161
1162commit f35b8b8be16f1903beed34fe23fa53d102329342
1163Author: Gaetan Nadon <memsize@videotron.ca>
1164Date:   Sun Jun 12 17:54:50 2011 -0400
1165
1166    Install xml versions of specs even if HAVE_XMLTO is false
1167    
1168    DocBook/XML input source is also a usefull output format that can be viewed
1169    with an XML viewer or editor and by some O/S help system.
1170    
1171    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1172
1173commit 4c9cbdb1b40799121456c692d960135d741f13c7
1174Author: Gaetan Nadon <memsize@videotron.ca>
1175Date:   Sun Jun 5 16:27:36 2011 -0400
1176
1177    Install target dbs alongside generated documents
1178    
1179    This matches a change in xorg-sgml-docs whereby the masterdb will look for
1180    the target dbs into the same location as the generated documents.
1181    
1182    The target dbs are now installed alongside the generated documents.
1183    Previously they are installed in $prefix/sgml/X11/dbs alongside masterdb which
1184    has the potential of installing outside the package prefix and cause
1185    distcheck to fail when user does not have write permission in this package.
1186    
1187    Requires XORG_CHECK_SGML_DOCTOOLS(1.8) which was released 2011-06-11
1188
1189commit 72d668dd2ec4db9b75973ba24f42ab49851dbc6d
1190Author: Matt Dew <marcoz@osource.org>
1191Date:   Wed May 25 22:54:51 2011 -0600
1192
1193    add id attributes to funcsynopsis to allow other docs to olink to them
1194    
1195    Signed-off-by: Matt Dew <marcoz@osource.org>
1196    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1197    Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
1198
1199commit dd7f2beaa753541aefba499813f25de38cbd17b7
1200Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1201Date:   Tue Apr 19 18:36:58 2011 -0700
1202
1203    IceWritePad: Zero fill pad bytes used when buffer is full
1204    
1205    Should be rarely hit, since it's only in the case where most of the
1206    message fits in the buffer, but there's not room left for the padding
1207    bytes, but better than sending uninitialized bytes off the stack when
1208    it happens.
1209    
1210    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1211    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1212
1213commit 663782989be82e7893c99eaa7cbe98ec25a23c38
1214Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1215Date:   Tue Apr 19 18:19:19 2011 -0700
1216
1217    Fix reads outside array bounds in error handlers
1218    
1219    Error: Buffer overrun
1220       Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &mOp, 8), (size(&mOp) < (unsigned) 8)
1221          Array size is 1 bytes
1222            at line 296 of src/error.c in function '_IceErrorMajorOpcodeDuplicate'.
1223    Error: Buffer overrun
1224       Read outside array bounds (CWE 125): In call to memcpy(<unknown>, &maj, 8), (size(&maj) < (unsigned) 8)
1225          Array size is 1 bytes
1226            at line 346 of src/error.c in function '_IceErrorBadMajor'.
1227    
1228    [ This bug was found by the Parfait 0.3.7 bug checking tool.
1229      For more information see http://labs.oracle.com/projects/parfait/ ]
1230    
1231    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1232    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
1233
1234commit daf686b7639919289b07a575a0d88efcb91d9732
1235Author: Gaetan Nadon <memsize@videotron.ca>
1236Date:   Wed Mar 30 20:15:07 2011 -0400
1237
1238    doc: xorg-sgml-doctools package at version 1.7 is required
1239    
1240    This version contains support for external references
1241    
1242    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1243
1244commit fadb927532556adb471300c89de29d268aae9102
1245Author: Gaetan Nadon <memsize@videotron.ca>
1246Date:   Sun Feb 27 15:06:18 2011 -0500
1247
1248    Documentation: add Docbook external references support
1249    
1250    When writing technical documentation, it is often necessary to cross
1251    reference to other information. When that other information is not in the
1252    current document, additional support is needed, namely <olink>.
1253    
1254    A new feature with version 1.7 of xorg-sgml-doctools adds references to
1255    other documents within or outside this package.
1256    
1257    This patch adds technical support for this feature but does not change
1258    the content of the documentation as seen by the end user.
1259    
1260    Each book or article must generate a database containing the href
1261    of sections that can be referred to from another document. This database
1262    is installed in DATAROOTDIR/sgml/X11/dbs. There is a requirement that
1263    the value of DATAROOTDIR for xorg-sgml-doctools and for the package
1264    documentation is the same. This forms a virtual document tree.
1265    
1266    This database is consulted by other documents while they are being generated
1267    in order to fulfill the missing information for linking.
1268    Refer to the xorg-sgml-doctools for further technical information.
1269    
1270    Co-authored-by: Matt Dew <marcoz@osource.org>
1271    
1272    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1273
1274commit 483d32621c06bcba0c7aa7794633b46b151fd5bf
1275Author: Gaetan Nadon <memsize@videotron.ca>
1276Date:   Fri Feb 25 08:58:54 2011 -0500
1277
1278    Docbook: change the book id to match the xml file basename
1279    
1280    This is required for the up-coming external references support.
1281    
1282    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1283
1284commit 4852c5bb1603fb6d401fe6895d9318555a8d4523
1285Author: Gaetan Nadon <memsize@videotron.ca>
1286Date:   Wed Feb 2 19:13:54 2011 -0500
1287
1288    config: splitting ICE and XTRANS compiler options is not required
1289    
1290    Simplify configuration by using a single PKG_CHECK_MODULES statement.
1291    
1292    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1293
1294commit 87d34a2f04c9d920da01802cd9707c8107746fa5
1295Author: Gaetan Nadon <memsize@videotron.ca>
1296Date:   Wed Feb 2 11:43:40 2011 -0500
1297
1298    config: comment, minor upgrade, quote and layout configure.ac
1299    
1300    Group statements per section as per Autoconf standard layout
1301    Quote statements where appropriate.
1302    Autoconf recommends not using dnl instead of # for comments
1303    
1304    Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters.
1305    
1306    This helps automated maintenance and release activities.
1307    Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines
1308    
1309    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1310
1311commit 548eded10385ccc336e66dac8bbabe05f3225ec2
1312Author: Gaetan Nadon <memsize@videotron.ca>
1313Date:   Fri Jan 28 14:42:12 2011 -0500
1314
1315    config: remove unrequired AC_HEADER_STDC
1316    
1317    Autoconf says:
1318    "This macro is obsolescent, as current systems have conforming
1319    header files. New programs need not use this macro".
1320
1321commit 78b8e6b772685a2ed567ac2d30f96116f050dad5
1322Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1323Date:   Fri Jan 7 19:29:03 2011 -0800
1324
1325    Resync fallback asprintf with updated version put into xrdb
1326    
1327    Fixes issues found during xrdb review on xorg-devel
1328    Also make sure <stdarg.h> is #included for varargs macros
1329    
1330    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1331
1332commit dc63c253e33b1012c08cd274e6e37bf0fa87c624
1333Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1334Date:   Tue Dec 21 18:28:36 2010 -0800
1335
1336    Add AC_USE_SYSTEM_EXTENSIONS to make asprintf() visible in GNU libc
1337    
1338    asprintf is considered a GNU extension and thus one needs to define
1339    _GNU_SOURCE before including stdio.h.
1340    
1341    Reported-by: Cyril Brulebois <kibi@debian.org>
1342    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1343    Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
1344    Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
1345
1346commit 4b4ec3aeaa7cf5f5a6490ad2ddc2b07d090214cb
1347Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1348Date:   Sun Dec 19 09:57:05 2010 -0800
1349
1350    Use correct string pointer in asprintf() fallback
1351    
1352    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1353
1354commit 308c8d3d5fbf96c1d4f313def50d4b001ac0d685
1355Author: Paulo Zanoni <przanoni@gmail.com>
1356Date:   Fri Dec 17 14:59:22 2010 -0200
1357
1358    Remove useless line from a table in specs/ice.xml
1359    
1360    This seems to be a leftover from a manpage/groff conversion.
1361    
1362    Signed-off-by: Paulo Zanoni <pzanoni@mandriva.com>
1363    Reviewed-by: Matt Dew
1364    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1365
1366commit a72467b21662a63c81418731b540a8843d138750
1367Author: Paulo Zanoni <pzanoni@mandriva.com>
1368Date:   Thu Dec 16 13:59:52 2010 -0200
1369
1370    Use docbookx.dtd version 4.3 for all docs
1371    
1372    Signed-off-by: Paulo Zanoni <pzanoni@mandriva.com>
1373    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1374
1375commit e0280caf7cc9d0e1c2df3ab7c5a4fbe4e42696a9
1376Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1377Date:   Sun Dec 5 01:15:42 2010 -0800
1378
1379    Convert src/process.c from malloc + sprintf to asprintf
1380    
1381    Includes simple local implemenation of asprintf if configure doesn't
1382    find one in system libraries
1383    
1384    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1385    Reviewed-by: Julien Cristau <jcristau@debian.org>
1386
1387commit a5669dcb488db19b1ba4f1ef4d4565b6c3d1ea09
1388Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1389Date:   Sat Nov 20 19:47:53 2010 -0800
1390
1391    config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS
1392    
1393    Regroup AC statements under the Autoconf initialization section.
1394    Regroup AM statements under the Automake initialization section.
1395    
1396    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1397
1398commit d902a9f27369fc8388774e73f4bee6ab0ad86ef5
1399Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1400Date:   Sat Nov 20 19:45:42 2010 -0800
1401
1402    config: Remove unnecessary calls from configure.ac
1403    
1404    AC_PROG_CC is provided by XORG_DEFAULT_OPTIONS now
1405    PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
1406    
1407    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1408
1409commit fd56c4e00a564d6385ccb2f8fadf10de201ae411
1410Author: Gaetan Nadon <memsize@videotron.ca>
1411Date:   Tue Nov 9 11:28:48 2010 -0500
1412
1413    config: HTML file generation: use the installed copy of xorg.css
1414    
1415    Currenlty the xorg.css file is copied in each location
1416    where a DocBook/XML file resides. This produces about
1417    70 copies in the $(docdir) install tree.
1418    
1419    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1420
1421commit 9856f5679b2b2d458cf830c1e8fdd206c724dfc5
1422Author: Adam Jackson <ajax@redhat.com>
1423Date:   Tue Oct 19 11:19:08 2010 -0400
1424
1425    libICE 1.0.7
1426    
1427    Signed-off-by: Adam Jackson <ajax@redhat.com>
1428
1429commit 59a8d5609398824c81b72deb82735a55332ca239
1430Author: Jeremy Huddleston <jeremyhu@apple.com>
1431Date:   Sun Oct 17 21:26:31 2010 -0700
1432
1433    Fix include ordering, so -I../include precedes $CPPFLAGS which could
1434    cause us to include installed rather than packaged headers.
1435    
1436    Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
1437
1438commit 4a6f7a357222b2c1fa289d6e7b5fcc8c361e20e9
1439Author: Jesse Adkins <jesserayadkins@gmail.com>
1440Date:   Tue Sep 28 13:30:01 2010 -0700
1441
1442    Purge cvs tags.
1443    
1444    Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
1445    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1446
1447commit 5bb806a65bf23a507b135abe1e4a8b3cabc7b8aa
1448Author: Matt Dew <matt@osource.org>
1449Date:   Wed Jun 30 16:52:22 2010 -0400
1450
1451    specs: convert ICE doc/specs from xorg-docs module to DocBook XML
1452    
1453    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1454
1455commit 9b54f509832c50c1fac0edc0cb78e1a3454a56dc
1456Author: Alan Coopersmith <alan.coopersmith@oracle.com>
1457Date:   Tue Jun 8 20:12:53 2010 -0700
1458
1459    Move ICE protocol & API specs from xorg-docs module
1460    
1461    For now, just checked in and included in dist tarballs, not processed
1462    into a usable format - same as it was in xorg-docs
1463    
1464    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
1465
1466commit 1967c04c021a4cfd7b3cdd4efdc13610b4385a65
1467Author: Julien Cristau <jcristau@debian.org>
1468Date:   Tue May 11 16:36:20 2010 +0200
1469
1470    Set the close-on-exec flag for listening sockets
1471    
1472    This prevents xsm from leaking file descriptors to the processes it
1473    starts.
1474    
1475    X.Org bug#22932 <http://bugs.freedesktop.org/show_bug.cgi?id=22932>
1476    
1477    Reported-by: Kalle Olavi Niemitalo <kon@iki.fi>
1478    Signed-off-by: Julien Cristau <jcristau@debian.org>
1479
1480commit b6478dbedcca4d4cf44bd588c050bcc70c2f4963
1481Author: Gaetan Nadon <memsize@videotron.ca>
1482Date:   Mon Apr 5 19:50:40 2010 -0400
1483
1484    config: update AC_PREREQ statement to 2.60
1485    
1486    Unrelated to the previous patches, the new value simply reflects
1487    the reality that the minimum level for autoconf to configure
1488    all x.org modules is 2.60 dated June 2006.
1489    
1490    ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
1491    
1492    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1493
1494commit 8e175ff18649bd30e862b6a6a5f82a4ed4d5241a
1495Author: Gaetan Nadon <memsize@videotron.ca>
1496Date:   Mon Mar 29 14:53:48 2010 -0400
1497
1498    config: remove the pkgconfig pc.in file from EXTRA_DIST
1499    
1500    Automake always includes it in the tarball.
1501    
1502    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1503
1504commit 09d61dc024d9846525e4c97d33cdf03c9f06c151
1505Author: Gaetan Nadon <memsize@videotron.ca>
1506Date:   Tue Feb 16 10:37:21 2010 -0500
1507
1508    config: move CWARNFLAGS from configure.ac to Makefile.am
1509    
1510    Compiler warning flags should be explicitly set in the makefile
1511    rather than being merged with other packages compiler flags.
1512    
1513    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
1514
1515commit 72b8a2d39a57eb0640929b9bb9f276c6032f8213
1516Author: Gaetan Nadon <memsize@videotron.ca>
1517Date:   Fri Nov 27 20:56:03 2009 -0500
1518
1519    Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES
1520    
1521    Now that the INSTALL file is generated.
1522    Allows running make maintainer-clean.
1523
1524commit 68231f8574e197a12eff1ddde37166d101567269
1525Author: Gaetan Nadon <memsize@videotron.ca>
1526Date:   Wed Oct 28 14:09:10 2009 -0400
1527
1528    INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206
1529    
1530    Add missing INSTALL file. Use standard GNU file on building tarball
1531    README may have been updated
1532    Remove AUTHORS file as it is empty and no content available yet.
1533    Remove NEWS file as it is empty and no content available yet.
1534
1535commit b5cfc1cdd367c93660259a86b3b6683c57e5d76a
1536Author: Gaetan Nadon <memsize@videotron.ca>
1537Date:   Tue Oct 27 15:07:25 2009 -0400
1538
1539    Deploy the new XORG_DEFAULT_OPTIONS #24242
1540    
1541    This macro aggregate a number of existing macros that sets commmon
1542    X.Org components configuration options. It shields the configuration file from
1543    future changes.
1544
1545commit 5524fa4d543932e4565b2235515fef9a5d9a501d
1546Author: Gaetan Nadon <memsize@videotron.ca>
1547Date:   Mon Oct 26 22:08:41 2009 -0400
1548
1549    Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432
1550    
1551    ChangeLog filename is known to Automake and requires no further
1552    coding in the makefile.
1553
1554commit 82ad2d2053af2ad37697793b9718721aa3ff80a0
1555Author: Gaetan Nadon <memsize@videotron.ca>
1556Date:   Thu Oct 22 12:34:18 2009 -0400
1557
1558    .gitignore: use common defaults with custom section # 24239
1559    
1560    Using common defaults will reduce errors and maintenance.
1561    Only the very small or inexistent custom section need periodic maintenance
1562    when the structure of the component changes. Do not edit defaults.
1563
1564commit 4b2289ad5481de7fa51941cf6c2ca7a2a3202690
1565Author: Jeremy Huddleston <jeremyhu@freedesktop.org>
1566Date:   Wed Oct 21 12:47:23 2009 -0700
1567
1568    This is not a GNU project, so declare it foreign.
1569    
1570    On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote:
1571    > On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote:
1572    > > I noticed an INSTALL file in xlsclients and libXvMC today, and it
1573    > > was quite annoying to work around since 'autoreconf -fvi' replaces
1574    > > it and git wants to commit it.  Should these files even be in git?
1575    > > Can I nuke them for the betterment of humanity and since they get
1576    > > created by autoreconf anyways?
1577    >
1578    > See https://bugs.freedesktop.org/show_bug.cgi?id=24206
1579    
1580    As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with
1581    AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation
1582    of the INSTALL file. It is also part of the 24206 solution.
1583    
1584    Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
1585
1586commit 94992c686a6850f2303aa78057a64a6369b64692
1587Author: Peter Hutterer <peter.hutterer@who-t.net>
1588Date:   Fri Aug 28 14:17:50 2009 +1000
1589
1590    libICE 1.0.6
1591    
1592    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
1593
1594commit 7a8bb2a2c991919bcdef63359c74e239045a3f4c
1595Author: Alan Coopersmith <alan.coopersmith@sun.com>
1596Date:   Mon Feb 2 20:34:30 2009 -0800
1597
1598    Add README with pointers to mailing list, bugzilla & git repos
1599    
1600    Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
1601
1602commit dbb950061f185e1ccf27bff9c71adc34ab4cfae0
1603Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
1604Date:   Wed Jan 28 16:55:37 2009 -0200
1605
1606    Janitor: Correct sparse warnings.
1607    
1608      Also reorders some code in configure.ac and Makefile.am to
1609    match pattern used on other packages.
1610
1611commit 2f41ddb3a917c4e71184452b68561a15593d33b8
1612Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
1613Date:   Tue Jan 6 17:25:25 2009 -0200
1614
1615    Update .gitignore.
1616    
1617      Don't warn about files left after a build and/or make distcheck
1618    in 'git status -a'.
1619
1620commit ab9dff549534c6d7b33f440bff7a841d60c1206c
1621Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1622Date:   Mon Dec 8 18:45:44 2008 +0100
1623
1624    bump to 1.0.5
1625
1626commit 71695c4bf7ae07228605683f6cdeca0457c8495a
1627Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1628Date:   Mon Dec 8 18:44:26 2008 +0100
1629
1630    remove ChangeLog from EXTRA_DIST and CLEANFILES
1631
1632commit 653f659fe65ae8c2a9fe5b1fdbfc78da43f2cf90
1633Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1634Date:   Mon Dec 8 18:41:34 2008 +0100
1635
1636    use memcmp instead of binaryEqual
1637    
1638    suggested by Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
1639    http://lists.freedesktop.org/archives/xorg/2008-December/041222.html
1640
1641commit bf138553afe6eecd0e6c218dc6ae4f63065e4196
1642Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1643Date:   Tue Dec 2 22:06:15 2008 +0100
1644
1645    Use NULL, not zero, for pointers
1646    
1647    From Magnus Kessler <Magnus.Kessler@gmx.net>
1648    http://lists.freedesktop.org/archives/xorg/2008-October/039799.html
1649    http://lists.freedesktop.org/archives/xorg/attachments/20081030/b2ea5b1c/attachment-0001.bin
1650
1651commit b01e82ce1deedb36c9696d4d27a3b9a5d5a52d08
1652Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1653Date:   Thu Oct 30 12:01:06 2008 +0100
1654
1655    ANSI C
1656    
1657    convert all old style function declarations
1658    
1659    see also: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
1660    http://bugs.freedesktop.org/show_bug.cgi?id=14683
1661    http://bugs.freedesktop.org/attachment.cgi?id=14582
1662    
1663    see also: Magnus Kessler <Magnus.Kessler@gmx.net>
1664    http://lists.freedesktop.org/archives/xorg/2008-October/039799.html
1665    http://lists.freedesktop.org/archives/xorg/attachments/20081030/b2ea5b1c/attachment-0001.bin
1666
1667commit 2aba1bc0583aeb3ee6e26e3bfacd123abef744d9
1668Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1669Date:   Mon Dec 1 23:06:22 2008 +0100
1670
1671    towards ANSI C
1672    
1673    make _IceProcessCoreMessage and default error handlers static
1674
1675commit 69a1b4b6d34291738dfbc3aa19d0ce3f2842ec8f
1676Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1677Date:   Mon Dec 1 22:22:12 2008 +0100
1678
1679    Activate CWARNFLAGS with lots of gcc warnings
1680
1681commit 898ed95cad1133940a83dcf428865c5d3fb2c939
1682Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1683Date:   Mon Dec 1 22:18:45 2008 +0100
1684
1685    use xorg-macros-1.2.1
1686    
1687    Use XORG_CHANGELOG for rule to generate ChangeLog from git log
1688    Use XORG_CWARNFLAGS for compiler warning flags, leave CFLAGS to user
1689
1690commit a99fbad09ab850e65ddd57e4d4488e4726295e14
1691Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1692Date:   Tue Oct 7 13:21:48 2008 -0700
1693
1694    Constify some arguments in libICE to clear warnings in libSM
1695    
1696    This patch avoids the gcc (3.4.6) warnings:
1697     ../../libSM-1.0.3/src/sm_client.c:104: warning: passing arg 7 of `IceRegisterForProtocolSetup' from incompatible pointer type
1698     ../../libSM-1.0.3/src/sm_manager.c:168: warning: passing arg 7 of `IceRegisterForProtocolReply' from incompatible pointer type
1699    when compiling libSM
1700
1701commit 3bceaeb3192ca75a14854d614e1621d28fb82274
1702Author: Peter Breitenlohner <peb@mppmu.mpg.de>
1703Date:   Tue Oct 7 11:25:42 2008 -0700
1704
1705    define macros to 1 in icetrans.c to avoid redefined macro warnings
1706    
1707    X.Org Bug #17947 <http://bugs.freedesktop.org/show_bug.cgi?id=17947>
1708    Patch #19444 <http://bugs.freedesktop.org/attachment.cgi?id=19444>
1709    
1710    Define as 1 (one) as done by autoconf and the command line
1711    option, e.g. -DICE_t, not as empty.
1712    
1713    This avoids the gcc (3.4.6) warnings:
1714     ../../libICE-1.0.4/src/icetrans.c:29:1: warning: "ICE_t" redefined
1715     ../config.h:38:1: warning: this is the location of the previous definition
1716     ../../libICE-1.0.4/src/icetrans.c:30:1: warning: "TRANS_CLIENT" redefined
1717     <command line>:6:1: warning: this is the location of the previous definition
1718     ../../libICE-1.0.4/src/icetrans.c:31:1: warning: "TRANS_SERVER" redefined
1719     <command line>:7:1: warning: this is the location of the previous definition
1720
1721commit b707104f4dba0963ab17c1d6a29c1e3a848ea408
1722Author: Alan Hourihane <alanh@tungstengraphics.com>
1723Date:   Tue Apr 29 00:41:40 2008 +0100
1724
1725    silence warning
1726
1727commit e6b525aefc05b5203391699b00053ad52243cc6b
1728Author: Colin Harrison <colin.harrison-at-virgin.net>
1729Date:   Tue Apr 29 00:40:48 2008 +0100
1730
1731    include for sleep()
1732
1733commit ef58f37724b841ef2246757be27111775aa86559
1734Author: Matthieu Herrb <matthieu.herrb@laas.fr>
1735Date:   Sun Mar 9 09:02:40 2008 +0100
1736
1737    nuke RCS Ids
1738
1739commit 47d86e8343d3d0201166c4d75da2ec9c12638cc1
1740Author: James Cloos <cloos@jhcloos.com>
1741Date:   Thu Dec 6 15:51:13 2007 -0500
1742
1743    Add missing PHONY line for automatic ChangeLog generation
1744
1745commit f415da71dd26f128df7d550ecd7631f8888eb1d2
1746Author: Alan Coopersmith <alan.coopersmith@sun.com>
1747Date:   Mon Aug 20 13:21:07 2007 -0700
1748
1749    Version bump: 1.0.4
1750
1751commit 8e08d3e4b8f00151b3a8b7eb88015dc15170e154
1752Author: Alan Coopersmith <alan.coopersmith@sun.com>
1753Date:   Mon Jun 4 15:40:22 2007 -0700
1754
1755    Add $(AM_CFLAGS) to lint flags to get correct Xtrans flags
1756
1757commit cd900e40b5676874d076c35466fd7baa6a49b1f6
1758Author: Alan Coopersmith <alan.coopersmith@sun.com>
1759Date:   Thu Apr 5 15:05:52 2007 -0700
1760
1761    Replace many malloc(strlen()); strcpy() pairs with strdup()
1762
1763commit 27f9a9324d58c9a7472c724c62f5b7ea0e1f4681
1764Author: Alan Coopersmith <alan.coopersmith@sun.com>
1765Date:   Thu Apr 5 14:43:05 2007 -0700
1766
1767    Provide ANSI C prototypes for more static functions
1768
1769commit bb639803a779ceace05d183b653da88f010ab29c
1770Author: Alan Coopersmith <alan.coopersmith@sun.com>
1771Date:   Thu Apr 5 14:32:31 2007 -0700
1772
1773    Convert authutil.c static helpers to ANSI C prototypes to clear sparse warnings
1774
1775commit 2179b2d467d69e45559b8e4f161a904a21f05321
1776Author: Alan Coopersmith <alan.coopersmith@sun.com>
1777Date:   Thu Apr 5 14:28:06 2007 -0700
1778
1779    Add hooks for checking source code with lint/sparse/etc.
1780
1781commit 6b361c028b5ad931b61df86fae570f3ef9f41c15
1782Author: Alan Coopersmith <alan.coopersmith@sun.com>
1783Date:   Thu Apr 5 14:19:56 2007 -0700
1784
1785    Coverity #1086: Double free of pointer "*listenObjsRet"
1786    
1787    Same bug, different function.
1788
1789commit c9b3d016681d81aff32c74cdad75151bd538e6ab
1790Author: Alan Coopersmith <alan.coopersmith@sun.com>
1791Date:   Thu Apr 5 14:07:42 2007 -0700
1792
1793    Coverity #1085: Double free of pointer "*listenObjsRet"
1794    
1795    If malloc failed in the loop in IceListenForConnections, the error path
1796    would free all previous allocations, then loop around and try again, and
1797    if it failed again, free the previous allocations again.   On the other
1798    hand, if it succeeded on the later tries, then the memory would just be
1799    leaked, since the error would be returned and not the pointer to them.
1800
1801commit 6039e865470af23948b0fe7d5dc0ea72da436b0e
1802Author: Alan Coopersmith <alan.coopersmith@sun.com>
1803Date:   Thu Apr 5 14:04:01 2007 -0700
1804
1805    Add *~ to .gitignore to skip emacs/patch droppings
1806
1807commit bed718894bed98cbd45b02bd57fb7fc6fd5089aa
1808Author: Daniel Stone <daniel@fooishbar.org>
1809Date:   Sat Dec 16 01:21:17 2006 +0200
1810
1811    bump to 1.0.3
1812
1813commit cac788981906186442ddfb57a41f45911eb8223b
1814Author: Daniel Stone <daniel@fooishbar.org>
1815Date:   Wed Dec 6 18:58:09 2006 +0200
1816
1817    Makefile.am: make ChangeLog hook safer
1818    Make ChangeLog hook as safe as possible.
1819
1820commit 011d632e8ef3f738b9158e66d6da6876e3b53905
1821Author: Adam Jackson <ajax@benzedrine.nwnk.net>
1822Date:   Fri Oct 13 15:49:52 2006 -0400
1823
1824    Bump to 1.0.2
1825
1826commit 445661cd714685009ee9ba2358a274351381eabf
1827Author: Adam Jackson <ajax@benzedrine.nwnk.net>
1828Date:   Thu Oct 12 18:37:57 2006 -0400
1829
1830    Fix ChangeLog hook to distcheck.
1831
1832commit 5cba1c763ac9f79062523227b49a29f72e6069cf
1833Author: Matthieu Herrb <matthieu.herrb@laas.fr>
1834Date:   Sun Jul 16 10:52:30 2006 +0200
1835
1836    set GIT_DIR=${srcdir}/.git for git-log
1837
1838commit 86e0a93714a6ccdb8555fc2c48231d958cba383d
1839Author: Alan Coopersmith <alan.coopersmith@sun.com>
1840Date:   Thu Jul 13 14:58:44 2006 -0700
1841
1842    renamed: .cvsignore -> .gitignore
1843
1844commit c87cb98979356fc55607c05a2b23207afc9beeb1
1845Author: Alan Coopersmith <alan.coopersmith@sun.com>
1846Date:   Tue Jul 11 13:48:08 2006 -0700
1847
1848    Replace static ChangeLog with rule copied from libX11 to generate from git log
1849
1850commit 6066ab9b9914ec0cca3b8f36fa3f5ba323414621
1851Author: Derek Wang <derek.wang@sun.com>
1852Date:   Tue Nov 23 12:00:32 2004 -0800
1853
1854    Sun bug #6193975: kde session manager core dumps in _IceWrite()
1855
1856commit be25425ca38d23655a5a854c053e750e1cbd3dea
1857Author: Alan Coopersmith <alan.coopersmith@sun.com>
1858Date:   Tue Jul 11 13:42:07 2006 -0700
1859
1860    renamed: .cvsignore -> .gitignore
1861
1862commit 9b1bb5ab99bd386cc030cd456a576b37406da91c
1863Author: Adam Jackson <ajax@nwnk.net>
1864Date:   Wed Apr 26 23:57:50 2006 +0000
1865
1866    Bump to 1.0.1
1867
1868commit 96d7763487da6624ed85bee10b081e7138d2060d
1869Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
1870Date:   Mon Apr 10 16:44:40 2006 +0000
1871
1872    Coverity #664: Free memory allocated by EXTRACT_STRING in
1873        _IceDefaultErrorHandler after we're done fprintf()'ing it.
1874
1875commit 2a30ec82f3bd2aa1f2566e97fee70403a8448de8
1876Author: Kevin E Martin <kem@kem.org>
1877Date:   Thu Dec 15 00:24:27 2005 +0000
1878
1879    Update package version number for final X11R7 release candidate.
1880
1881commit 881573d429c0a9ecfa2d6286d4eaece36ee50675
1882Author: Kevin E Martin <kem@kem.org>
1883Date:   Sat Dec 3 05:49:42 2005 +0000
1884
1885    Update package version number for X11R7 RC3 release.
1886
1887commit a15b179f2e8e359161d9133bac58dde57b7e78ae
1888Author: Kevin E Martin <kem@kem.org>
1889Date:   Sat Nov 19 07:15:39 2005 +0000
1890
1891    Update pkgconfig files to separate library build-time dependencies from
1892        application build-time dependencies, and update package deps to work
1893        with separate build roots.
1894
1895commit c386a08047582240adefafd3afc062e52fccae6f
1896Author: Kevin E Martin <kem@kem.org>
1897Date:   Wed Nov 9 21:19:12 2005 +0000
1898
1899    Update package version number for X11R7 RC2 release.
1900
1901commit c361e3919f2de3f4742904b04e73178edc76bf95
1902Author: Adam Jackson <ajax@nwnk.net>
1903Date:   Sun Oct 23 20:12:19 2005 +0000
1904
1905    Bug #1893: Fix replies when peers use different major opcodes for the same
1906        subprotocol. (016_ICE_subprotocol_reply_fix.diff from Debian, by Jochen
1907        Voss)
1908
1909commit 0b8ff6fbd8cd7f47ab9e6ccb6d4917564a2d13ee
1910Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
1911Date:   Sat Jul 30 19:15:15 2005 +0000
1912
1913    Add -D flags to clear various warnings (Stefan Dirsch)
1914
1915commit 260d470a128c7eaa6d7484bb143aab353c4e98ec
1916Author: Kevin E Martin <kem@kem.org>
1917Date:   Fri Jul 29 21:22:50 2005 +0000
1918
1919    Various changes preparing packages for RC0:
1920    - Verify and update package version numbers as needed
1921    - Implement versioning scheme
1922    - Change bug address to point to bugzilla bug entry form
1923    - Disable loadable i18n in libX11 by default (use --enable-loadable-i18n to
1924        reenable it)
1925    - Fix makedepend to use pkgconfig and pass distcheck
1926    - Update build script to build macros first
1927    - Update modular Xorg version
1928
1929commit cf687b775f580a84a4a8e962814abe7bc47a3c52
1930Author: Daniel Stone <daniel@fooishbar.org>
1931Date:   Sat Jul 16 06:22:34 2005 +0000
1932
1933    Set soversion to 6.3.0.
1934
1935commit 6d1704defa0e57715bd22d30d6e789b36233dcf8
1936Author: Keith Packard <keithp@keithp.com>
1937Date:   Sat Jul 9 05:59:01 2005 +0000
1938
1939    Add .cvsignore files
1940
1941commit 2b6b8e40a63dd69a13f87c19dcf8dc2f477c304d
1942Author: Daniel Stone <daniel@fooishbar.org>
1943Date:   Sun Jul 3 07:00:55 2005 +0000
1944
1945    Add Xtrans definitions (FONT_t, TRANS_CLIENT) to clean up warnings.
1946    Add XSERV_t, TRANS_SERVER, TRANS_REOPEN to quash warnings.
1947    Add #include <dix-config.h> or <xorg-config.h>, as appropriate, to all
1948        source files in the xserver/xorg tree, predicated on defines of
1949        HAVE_{DIX,XORG}_CONFIG_H. Change all Xfont includes to
1950        <X11/fonts/foo.h>.
1951
1952commit 608ad35f102b188f554daf8c160a5edcf4e8031c
1953Author: Daniel Stone <daniel@fooishbar.org>
1954Date:   Fri Jun 10 14:11:36 2005 +0000
1955
1956    Remove pointless include of Xlib.h.
1957    Fix #include path to bigreqstr.h.
1958
1959commit 795460992b0dcd4aa2591be462a94942415c6028
1960Author: Alexander Gottwald <alexander.gottwald@s1999.tu-chemnitz.de>
1961Date:   Thu Jun 9 15:54:47 2005 +0000
1962
1963    Replace <X11/transport.c> with <X11/Xtrans/transport.c>
1964
1965commit ae7b4cca6bd5c1f4edea8cde80d7a3dfaaf2c4d3
1966Author: Alexander Gottwald <alexander.gottwald@s1999.tu-chemnitz.de>
1967Date:   Thu Jun 9 15:52:02 2005 +0000
1968
1969    Replace <X11/Xtrans.h> with <X11/Xtrans/Xtrans.h>
1970    Copy Xtrans.h to exports/include/X11/Xtrans only
1971
1972commit a0637be926e6da5db8d131e7914f1300f484c626
1973Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
1974Date:   Sat May 21 23:07:47 2005 +0000
1975
1976    xtrans:
1977    Create autoconf macro XTRANS_CONNECTION_FLAGS to provide standard set of
1978        --enable flags for which transports to support and common place to
1979        update for required libraries for platforms that need certain libs for
1980        certain transports
1981    ICE:
1982    Add ICE_t #define required by Xtrans headers. Replace static defines of
1983        LOCALCONN & UNIXCONN with new XTRANS_CONNECTION_FLAGS macro.
1984    X11:
1985    Moved transport type checks to new macro XTRANS_CONNECTION_FLAGS in
1986        xtrans.m4 in xtrans module so they can be shared by all modules using
1987        xtrans.
1988
1989commit efdb2468119be0c62a379d91088a708ca8d37e1b
1990Author: Adam Jackson <ajax@nwnk.net>
1991Date:   Thu May 19 00:22:32 2005 +0000
1992
1993    revert last change, didn't do right thing at all, sorry for the noise
1994
1995commit ccf4efa5e204d4569b9b590f72baae807ec19903
1996Author: Adam Jackson <ajax@nwnk.net>
1997Date:   Thu May 19 00:10:02 2005 +0000
1998
1999    Require automake 1.7 in AM_INIT_AUTOMAKE
2000
2001commit 3458da101c943530861485c798538ce014eee6b0
2002Author: Søren Sandmann Pedersen <sandmann@daimi.au.dk>
2003Date:   Tue May 17 21:25:15 2005 +0000
2004
2005    - Conditionally include config.h in xc/lib/SM
2006    - Add libSM to symlink.sh
2007    - Add SM build system
2008
2009commit cae06ca0ce523eeb9a667ce3ae5bff066cf6ecd7
2010Author: Søren Sandmann Pedersen <sandmann@daimi.au.dk>
2011Date:   Tue May 17 20:53:58 2005 +0000
2012
2013    - Conditionally include config.h in the ICE source.
2014    - Add ICE to symlink.sh
2015
2016commit 9dd90f8f8e29bb1dd6fe84b4b1d2d75ef91bc336
2017Author: Søren Sandmann Pedersen <sandmann@daimi.au.dk>
2018Date:   Tue May 17 20:52:35 2005 +0000
2019
2020    Add ICE directory + build system.
2021
2022commit d1cfe2a6d4a392f64b6b9d9255ec329fb2a6a39a
2023Author: Daniel Stone <daniel@fooishbar.org>
2024Date:   Fri Jan 28 19:15:39 2005 +0000
2025
2026    Move _IceGetPeerName into the ICE public API as IceGetPeerName; bump ICE
2027        soversion to 6.4 accordingly. Change SM's use to the public version.
2028        The old version will be retained for compatibility.
2029
2030commit 8f0babf8450aa8097e063e13c95b1581843b2dd8
2031Author: Egbert Eich <eich@suse.de>
2032Date:   Fri Apr 23 18:43:22 2004 +0000
2033
2034    Merging XORG-CURRENT into trunk
2035
2036commit 111949a4a1d5b62e26016b555e12f8862c90ae44
2037Author: Egbert Eich <eich@suse.de>
2038Date:   Sun Mar 14 08:31:52 2004 +0000
2039
2040    Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004
2041
2042commit d4054eea34b2f4d345796ecadec8a96af93c4d0d
2043Author: Egbert Eich <eich@suse.de>
2044Date:   Wed Mar 3 12:11:10 2004 +0000
2045
2046    Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004
2047
2048commit 569bf16d182b043e7ab914202d4195baf4a8413a
2049Author: Egbert Eich <eich@suse.de>
2050Date:   Thu Feb 26 13:35:18 2004 +0000
2051
2052    readding XFree86's cvs IDs
2053
2054commit 14c9e41e551ab1b3a00807dbb8f2f215b96bcc81
2055Author: Egbert Eich <eich@suse.de>
2056Date:   Thu Feb 26 09:22:34 2004 +0000
2057
2058    Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004
2059
2060commit 45b73c360dc68b023194758bbb1cc59c021742a6
2061Author: Kaleb Keithley <kaleb@freedesktop.org>
2062Date:   Thu Dec 4 22:02:52 2003 +0000
2063
2064    XFree86 4.3.99.901 (RC 1)
2065
2066commit c919c3d0b355ef67dfa0b511eb1da488e5786d1b
2067Author: Kaleb Keithley <kaleb@freedesktop.org>
2068Date:   Tue Nov 25 19:28:07 2003 +0000
2069
2070    XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folks
2071
2072commit 72e353567f8927996a26e72848d86f692c3f0737
2073Author: Kaleb Keithley <kaleb@freedesktop.org>
2074Date:   Fri Nov 14 16:48:46 2003 +0000
2075
2076    XFree86 4.3.0.1
2077
2078commit ee452992357329f7af846eba8f5bbe61c5d27bfa
2079Author: Kaleb Keithley <kaleb@freedesktop.org>
2080Date:   Fri Nov 14 15:54:36 2003 +0000
2081
2082    R6.6 is the Xorg base-line
2083