Home | History | Annotate | Download | only in pic
History log of /src/sys/arch/powerpc/pic/pic_distopenpic.c
RevisionDateAuthorComments
 1.14  23-Feb-2022  andvar fix various typos in comments, mainly immediatly/immediately/,
as well shared and recently fixed typos in OpenBSD code by Jonathan Grey.
 1.13  06-Jul-2020  rin Drop unused opt_interrupt.h.
 1.12  06-Jul-2020  rin Style and cosmetic changes. No binary changes intended.
 1.11  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.10  01-Jun-2017  chs branches: 1.10.8; 1.10.10;
remove checks for failure after memory allocation calls that cannot fail:

kmem_alloc() with KM_SLEEP
kmem_zalloc() with KM_SLEEP
percpu_alloc()
pserialize_create()
psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.
 1.9  01-Feb-2012  matt branches: 1.9.6; 1.9.24;
Use kmem instead of malloc. Remove unneeded <sys/malloc.h> includes.
 1.8  14-Jan-2012  phx Some PICs have the capability to define the interrupt's polarity (OpenPIC
for example). So the accepted interrupt types have been extended to:
- IST_EDGE_FALLING (which is the same as IST_EDGE)
- IST_EDGE_RISING (new)
- IST_LEVEL_LOW (is the same as IST_LEVEL)
- IST_LEVEL_HIGH (new)
Old code will continue to work without modification.
 1.7  02-Jul-2011  mrg branches: 1.7.2; 1.7.6;
avoid some uninitialised variable warnings from GCC 4.5. i'm pretty
sure they can't happen in practise, but i can see why GCC isn't sure.
 1.6  20-Jun-2011  matt <arch/powerpc/... -> <powerpc/...
 1.5  05-Jun-2011  matt Remove <machine/atomic.h>; use <sys/atomic.h> instead.
Add <powerpc/cpuset.h> (for mpc85xx pmap).
Add some initial MP code for mpc85xx
Rework ipi code to be common across all ppcs
Change PPC to keep curlwp in %r13 while in the kernel.
Move astpending from cpu_info to mdlwp
Improve cpu_need_resched to be more MP friendly.
 1.4  10-May-2008  martin branches: 1.4.20; 1.4.26; 1.4.30;
Backout previous: the license sweep touched these files in error, so
restore the old license.
 1.3  29-Apr-2008  martin branches: 1.3.2;
Convert to new 2 clause license
 1.2  08-Apr-2008  garbled SMP support for ofppc. (finally) Much thanks to Matt Thomas for help in
figuring out all the crazy nuances of getting this working, and to
Michael Lorenz for testing/fixing my changes on macppc. Tested with a
quad-proc 7044-270.
Summary of changes:

Bumped CPU_MAXNUM to 16 on ofppc.
Added md_* routines to ofppc/cpu.c, to sync the timebase, and awaken the CPUs.
Fixed a bug in the test for a 64bit bridge cpu early in locore.S
Added code to set the interrupt priority for all CPUs with an openpic.
Change rtas to probe before cpus, to allow use of the rtas freeze/thaw
timebase code routines.
Fix CPU_INFO_FOREACH macro to iterate through detected cpus, not CPU_MAXNUM.
Change most uses of ci_cpuid to ci_index, to deal with CPUs that do not allow
writing to SPR_PIR. Don't write SPR_PIR unless the secondary cpu identifies
itself as 0.
Change the hatchstack/interrupt stack allocations to allocate a 8192byte
interrupt stack, and a 4096 byte hatch stack, align them to 16 bytes, and
allocate them no lower than 0x10000. Allocate them separately to prevent the
hatch stack corrupting the interrupt stack later on.
If the CPU is a 64bit cpu, copy SPR_ASR in cpu_hatch()
Set the idle stack to ci->ci_data.cpu_idlelwp->l_addr->u_pcb.pcb_sp.
Add OF_start_cpu(). Add a routine to ofwoea_initppc to spin up secondary
procs early, and place them into a spinloop waiting for the hatch routines
to be ready.
Modify the ipi routines to deal with openpics that reverse byte order on read
from an ipi register. (such as on the 7044)
Change the rtas setup to allocate the rtas physical base address above
the kernel, to avoid mucking up the hatch/interrupt stacks.
 1.1  17-Jan-2008  garbled branches: 1.1.2; 1.1.4; 1.1.6; 1.1.12; 1.1.14;
Add support to ofppc for the IBM 7044-270 machine. This is a POWER3-II
based machine. Currently the kernel to run on this machine is
incompatible with the standard GENERIC kernel, so for now, we have a
separate GENERIC_B64. Eventually, I hope to combine the two.

Please note, this is a port of 32bit ofppc, not a powerpc64 port.

Thanks to Matt Thomas and Kevin Bowling for helping to make this port
possible.

Summary of changes:

Change ofwpci to use the ofmethod config for configuring the PCI bus,
rather than indirect configuration.
Move the wiring of the interrupt controllers from at the start of the
boot, into the configuration of the first PCI bus.
Rewrite the map_isa_ioregs() hack to work on a machine without BATs
Fix a ton of bugs in the genofw_find_pics routine, and in the map_space code.
Split the pic_openpic into openpic_common and pic_openpic.
Create a new pic_distopenpic driver, for the distributed openpic found on
some newer IBM machines.
Fix a bad panic in pmap_extract on 64bit bridge mode
 1.1.14.2  23-Mar-2008  matt sync with HEAD
 1.1.14.1  17-Jan-2008  matt file pic_distopenpic.c was added on branch matt-armv6 on 2008-03-23 02:04:18 +0000
 1.1.12.1  02-Jun-2008  mjf Sync with HEAD.
 1.1.6.2  18-Feb-2008  mjf Sync with HEAD.
 1.1.6.1  17-Jan-2008  mjf file pic_distopenpic.c was added on branch mjf-devfs on 2008-02-18 21:04:58 +0000
 1.1.4.2  21-Jan-2008  yamt sync with head
 1.1.4.1  17-Jan-2008  yamt file pic_distopenpic.c was added on branch yamt-lazymbuf on 2008-01-21 09:38:27 +0000
 1.1.2.2  19-Jan-2008  bouyer Sync with HEAD
 1.1.2.1  17-Jan-2008  bouyer file pic_distopenpic.c was added on branch bouyer-xeni386 on 2008-01-19 12:14:43 +0000
 1.3.2.1  23-Jun-2008  wrstuden Sync w/ -current. 34 merge conflicts to follow.
 1.4.30.1  23-Jun-2011  cherry Catchup with rmind-uvmplock merge.
 1.4.26.1  06-Jun-2011  jruoho Sync with HEAD.
 1.4.20.1  12-Jun-2011  rmind sync with head
 1.7.6.1  18-Feb-2012  mrg merge to -current.
 1.7.2.1  17-Apr-2012  yamt sync with head
 1.9.24.1  28-Aug-2017  skrll Sync with HEAD
 1.9.6.1  03-Dec-2017  jdolecek update from HEAD
 1.10.10.1  10-Jun-2019  christos Sync with HEAD
 1.10.8.1  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

RSS XML Feed