Home | History | Annotate | Download | only in rogue
History log of /src/games/rogue/score.c
RevisionDateAuthorComments
 1.16  26-Aug-2011  dholland Use __dead and __printflike instead of __attribute__.
 1.15  12-Aug-2009  dholland sprinkle static
 1.14  14-Jan-2008  dholland ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.
 1.13  14-Jan-2008  dholland Whitespace/KNF nits.
 1.12  27-Dec-2007  dholland Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.
 1.11  07-Aug-2003  agc branches: 1.11.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.
 1.10  07-Jul-2002  tron Make "rogue" build with "WARNS=2". The necessary patches were supplied
by David A. Holland in PR bin/17498.
 1.9  09-Aug-2001  wiz Fix for FreeBSD/13278, from FreeBSD:
When a game ends that makes the top 10, the function insert_score in
score.c is called to make the new score file. But the case for KFIRE
(killed by fire) incorrectly uses strcpy instead of strcat (all the
other cases use strcat). This puts the string in the wrong place and
corrupts the score file.
 1.8  12-Sep-1999  jsm Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.
 1.7  10-Nov-1998  hubertf constify, per PR 6148
 1.6  12-Oct-1997  lukem WARNSify (not an insignificant task...)
 1.5  22-Apr-1995  cgd clean up import, NetBSD RCS Ids
 1.4  10-Nov-1993  cgd new curses update
 1.3  23-Sep-1993  mycroft Use `r+' rather than `a+' when opening score file.
 1.2  01-Aug-1993  mycroft Add RCS identifiers.
 1.1  21-Mar-1993  cgd branches: 1.1.1;
Initial revision
 1.1.1.2  22-Apr-1995  cgd src/games/rogue from Lite
 1.1.1.1  21-Mar-1993  cgd initial import of 386bsd-0.1 sources
 1.11.22.2  23-Mar-2008  matt sync with HEAD
 1.11.22.1  09-Jan-2008  matt sync with HEAD

RSS XML Feed