Home | History | Annotate | Download | only in altq
History log of /src/sys/altq/altq_hfsc.c
RevisionDateAuthorComments
 1.31  08-Jan-2025  joe return: remove parenthesis from return statements
 1.30  21-Sep-2021  christos branches: 1.30.6;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.
 1.29  30-Aug-2021  riastradh sys/altq: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
 1.28  15-Nov-2018  maxv branches: 1.28.4;
Remove the 't' argument from m_tag_find().
 1.27  28-Jul-2017  riastradh branches: 1.27.2; 1.27.4;
Zero buffers copied to userland to avoid stack disclosure.

From Ilja Van Sprundel.
 1.26  20-Apr-2016  knakahara branches: 1.26.10;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation
 1.25  22-Jan-2016  christos Prevent interface deletion from running into an infinite loop when altq closes.
$ cat /etc/altq.conf
interface ppp0 bandwidth 10M priq
class priq ppp0 high_class_ppp NULL priority 1
class priq ppp0 low_class_ppp NULL priority 0 default
filter ppp0 high_class_ppp 0 0 0 0 1
$ ifconfig ppp0 create
$ /etc/rc.d/altqd onestart
$ ifconfig ppp0 destroy
$ pkill altqd
XXX: pullup-7
 1.24  18-Jun-2008  yamt branches: 1.24.36; 1.24.40; 1.24.42; 1.24.52; 1.24.58; 1.24.60; 1.24.62; 1.24.66;
merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@. requested by core@
 1.23  04-Mar-2007  christos branches: 1.23.36; 1.23.38; 1.23.40; 1.23.42; 1.23.44;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
 1.22  16-Nov-2006  christos branches: 1.22.4;
__unused removal on arguments; approved by core.
 1.21  20-Oct-2006  elad Kill some KAUTH_GENERIC_ISSUSER.
 1.20  13-Oct-2006  peter Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.
 1.19  12-Oct-2006  peter Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).
 1.18  12-Oct-2006  christos - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
 1.17  21-Jul-2006  ad branches: 1.17.4; 1.17.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.
 1.16  15-May-2006  christos kauth fallout
 1.15  14-May-2006  elad integrate kauth.
 1.14  23-Apr-2006  christos Complete the FREE -> free transition and add more NULL checks for malloc
returns. Although these cannot happen because M_WAITOK, the rest of the
code does them already, so this is good for consistency. From Mindaugas
 1.13  23-Apr-2006  christos Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.
 1.12  24-Dec-2005  perry branches: 1.12.4; 1.12.6; 1.12.8; 1.12.10; 1.12.12;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
 1.11  11-Dec-2005  christos merge ktrace-lwp.
 1.10  26-Feb-2005  perry branches: 1.10.4;
nuke trailing whitespace
 1.9  13-Feb-2004  wiz branches: 1.9.8; 1.9.10;
Uppercase CPU, plural is CPUs.
 1.8  09-Nov-2003  christos - kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables
 1.7  06-Jan-2003  christos branches: 1.7.2;
avoid name collision [class_stats]
 1.6  18-May-2002  itojun sync with KAME.
- don't MALLOC() with M_WAITOK in the spl block.
move the allocation before splnet().
- when we reset vt of a class, reset the runtime service curve as well.
- don't use max() to compare 64 bit values.
 1.5  12-Nov-2001  lukem branches: 1.5.8;
add RCSIDs
 1.4  26-Oct-2001  itojun avoid divide-by-zero when the specified bandwidth is less than 8bps.
OpenBSD PR: kernel/2150
 1.3  13-Apr-2001  thorpej branches: 1.3.2; 1.3.4; 1.3.6;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.
 1.2  14-Dec-2000  thorpej branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.
 1.1  14-Dec-2000  thorpej branches: 1.1.1;
Initial revision
 1.1.1.1  14-Dec-2000  thorpej Import ALTQ from KAME.
 1.2.4.4  07-Jan-2003  thorpej Sync with HEAD.
 1.2.4.3  20-Jun-2002  nathanw Catch up to -current.
 1.2.4.2  14-Nov-2001  nathanw Catch up to -current.
 1.2.4.1  21-Jun-2001  nathanw Catch up to -current.
 1.2.2.3  21-Apr-2001  bouyer Sync with HEAD
 1.2.2.2  05-Jan-2001  bouyer Sync with HEAD
 1.2.2.1  14-Dec-2000  bouyer file altq_hfsc.c was added on branch thorpej_scsipi on 2001-01-05 17:39:36 +0000
 1.3.6.1  12-Nov-2001  thorpej Sync the thorpej-mips-cache branch with -current.
 1.3.4.1  10-Oct-2001  fvdl Convert all remaining devices.
 1.3.2.2  23-Jun-2002  jdolecek catch up with -current on kqueue branch
 1.3.2.1  10-Jan-2002  thorpej Sync kqueue branch with -current.
 1.5.8.1  30-May-2002  gehenna Catch up with -current.
 1.7.2.5  04-Mar-2005  skrll Sync with HEAD.

Hi Perry!
 1.7.2.4  21-Sep-2004  skrll Fix the sync with head I botched.
 1.7.2.3  18-Sep-2004  skrll Sync with HEAD.
 1.7.2.2  12-Aug-2004  skrll Adapt to new world order.
 1.7.2.1  03-Aug-2004  skrll Sync with HEAD
 1.9.10.1  19-Mar-2005  yamt sync with head. xen and whitespace. xen part is not finished.
 1.9.8.1  29-Apr-2005  kent sync with -current
 1.10.4.3  03-Sep-2007  yamt sync with head.
 1.10.4.2  30-Dec-2006  yamt sync with head.
 1.10.4.1  21-Jun-2006  yamt sync with head.
 1.12.12.3  25-Sep-2006  peter sync with head.
 1.12.12.2  09-Jun-2006  peter Merge 2006-05-24 NetBSD-current into the peter-altq branch.
 1.12.12.1  18-Mar-2006  peter Sync with KAME.
 1.12.10.3  11-May-2006  elad sync with head
 1.12.10.2  10-Mar-2006  elad generic_authorize() -> kauth_authorize_generic().
 1.12.10.1  08-Mar-2006  elad Adapt to kernel authorization KPI.
 1.12.8.2  11-Aug-2006  yamt sync with head
 1.12.8.1  24-May-2006  yamt sync with head.
 1.12.6.1  01-Jun-2006  kardel Sync with head.
 1.12.4.1  09-Sep-2006  rpaulo sync with head
 1.17.6.2  10-Dec-2006  yamt sync with head.
 1.17.6.1  22-Oct-2006  yamt sync with head
 1.17.4.1  18-Nov-2006  ad Sync with head.
 1.22.4.1  12-Mar-2007  rmind Sync with HEAD.
 1.23.44.1  18-Jun-2008  simonb Sync with head.
 1.23.42.1  23-Jun-2008  wrstuden Sync w/ -current. 34 merge conflicts to follow.
 1.23.40.1  04-May-2009  yamt sync with head.
 1.23.38.1  24-Apr-2008  peter Add PACKET_TAG_ALTQ_QID and use it for pf/ALTQ. The ALTQ code compiles now.

ok yamt@
 1.23.36.1  29-Jun-2008  mjf Sync with HEAD.
 1.24.66.1  12-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1485):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.24.62.1  12-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1485):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.24.60.3  28-Aug-2017  skrll Sync with HEAD
 1.24.60.2  22-Apr-2016  skrll Sync with HEAD
 1.24.60.1  19-Mar-2016  skrll Sync with HEAD
 1.24.58.1  12-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1485):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.24.52.1  19-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1488):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.24.42.1  19-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1488):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.24.40.1  03-Dec-2017  jdolecek update from HEAD
 1.24.36.1  19-Aug-2017  snj Pull up following revision(s) (requested by mrg in ticket #1488):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.26.10.2  21-Jun-2023  martin Pull up following revision(s) (requested by riastradh in ticket #1831):

sys/altq/altq_hfsc.c: revision 1.29
sys/altq/altq_priq.c: revision 1.27

sys/altq: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
 1.26.10.1  09-Aug-2017  snj Pull up following revision(s) (requested by spz in ticket #198):
sys/altq/altq_cbq.c: revision 1.31
sys/altq/altq_hfsc.c: revision 1.27
sys/altq/altq_jobs.c: revision 1.11
sys/altq/altq_priq.c: revision 1.24
sys/altq/altq_wfq.c: revision 1.22
Zero buffers copied to userland to avoid stack disclosure.
From Ilja Van Sprundel.
--
Reject negative indices.
(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)
From Ilja Van Sprundel.
 1.27.4.1  10-Jun-2019  christos Sync with HEAD
 1.27.2.1  26-Nov-2018  pgoyette Sync with HEAD, resolve a couple of conflicts
 1.28.4.1  03-Aug-2022  martin Pull up following revision(s) (requested by riastradh in ticket #1488):

sys/altq/altq_hfsc.c: revision 1.29
sys/altq/altq_priq.c: revision 1.27

sys/altq: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
 1.30.6.1  11-Nov-2023  thorpej Mostly de-tangle ifnet::if_snd from ifaltq, in a way that's minimally-
invasive to the ALTQ code itself.

The point of this is to lay the groundwork for future changes to ifqueue,
which among other benefits, will also hide the ALTQ ABI from drivers.

RSS XML Feed