History log of /src/sys/arch/arm/gemini/gemini_gmac.c |
Revision | | Date | Author | Comments |
1.22 |
| 07-Aug-2021 |
thorpej | Merge thorpej-cfargs2.
|
1.21 |
| 24-Apr-2021 |
thorpej | branches: 1.21.8; Merge thorpej-cfargs branch:
Simplify and make extensible the config_search() / config_found() / config_attach() interfaces: rather than having different variants for which arguments you want pass along, just have a single call that takes a variadic list of tag-value arguments.
Adjust all call sites: - Simplify wherever possible; don't pass along arguments that aren't actually needed. - Don't be explicit about what interface attribute is attaching if the device only has one. (More simplification.) - Add a config_probe() function to be used in indirect configuiration situations, making is visibly easier to see when indirect config is in play, and allowing for future change in semantics. (As of now, this is just a wrapper around config_match(), but that is an implementation detail.)
Remove unnecessary or redundant interface attributes where they're not needed.
There are currently 5 "cfargs" defined: - CFARG_SUBMATCH (submatch function for direct config) - CFARG_SEARCH (search function for indirect config) - CFARG_IATTR (interface attribte) - CFARG_LOCATORS (locators array) - CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)
...and a sentinel value CFARG_EOL.
Add some extra sanity checking to ensure that interface attributes aren't ambiguous.
Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark ports to associate those device handles with device_t instance. This will trickle trough to more places over time (need back-end for pre-OFW Sun OBP; any others?).
|
1.20 |
| 04-Feb-2020 |
skrll | branches: 1.20.8; Trailing whitespace
|
1.19 |
| 04-Feb-2020 |
skrll | Adopt <net/if_stats.h>
|
1.18 |
| 30-Oct-2019 |
msaitoh | branches: 1.18.2; ether_input() automatically add input bytes to if_ibytes, so it's not required to do in the driver who use ether_input().
|
1.17 |
| 22-Jan-2019 |
msaitoh | branches: 1.17.4; Change MII PHY read/write API from:
int (*mii_readreg_t)(device_t, int, int); void (*mii_writereg_t)(device_t, int, int, int); to:
int (*mii_readreg_t)(device_t, int, int, uint16_t *); int (*mii_writereg_t)(device_t, int, int, uint16_t);
Now we can test if a read/write operation failed or not by the return value.
In 802.3 spec says that the PHY shall not respond to read/write transaction to the unimplemented register(22.2.4.3). Detecting timeout can be used to check whether a register is implemented or not (if the register conforms to the spec). ukphy(4) can be used this for MII_MMDACR and MII_MMDAADR.
Note that I noticed that the following code do infinite loop in the read/wirte function. If it accesses unimplemented PHY register, it will hang. It should be fixed:
arm/at91/at91emac.c arm/ep93xx/epe.c arm/omap/omapl1x_emac.c mips/ralink/ralink_eth.c arch/powerpc/booke/dev/pq3etsec.c(read) dev/cadence/if_cemac.c <- hkenken dev/ic/lan9118.c
Tested with the following device:
axe+ukphy axe+rgephy axen+rgephy (tested by Andrius V) wm+atphy wm+ukphy wm+igphy wm+ihphy wm+makphy sk+makphy sk+brgphy sk+gentbi msk+makphy sip+icsphy sip+ukphy re+rgephy bge+brgphy bnx+brgphy gsip+gphyter rtk+rlphy fxp+inphy (tested by Andrius V) tlp+acphy ex+exphy epic+qsphy vge+ciphy (tested by Andrius V) vr+ukphy (tested by Andrius V) vte+ukphy (tested by Andrius V)
Not tested (MAC): arm:at91emac arm:cemac arm:epe arm:geminigmac arm:enet arm:cpsw arm:emac(omac) arm:emac(sunxi) arm:npe evbppc:temac macppc:bm macppc:gm mips:aumac mips:ae mips:cnmac mips:reth mips:sbmac playstation2:smap powerpc:tsec powerpc:emac(ibm4xx) sgimips:mec sparc:be sf ne(ax88190, dl10019) awge ep gem hme smsh mtd sm age alc ale bce cas et jme lii nfe pcn ste stge tl xi aue mue smsc udav url
Not tested (PHY): amhphy bmtphy dmphy etphy glxtphy ikphy iophy lxtphy nsphyter pnaphy rdcphy sqphy tlphy tqphy urlphy
|
1.16 |
| 26-Jun-2018 |
msaitoh | branches: 1.16.2; Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same as FreeBSD.
This change also fixes a bug that the direction is misunderstand on some environment by passing the direction to bpf_mtap*() instead of checking m->m_pkthdr.rcvif.
|
1.15 |
| 09-May-2018 |
maxv | Remove nonsensical KASSERT.
|
1.14 |
| 26-Apr-2018 |
maxv | Fix inverted arguments in m_gethdr().
|
1.13 |
| 01-Jun-2017 |
chs | branches: 1.13.2; 1.13.8; remove checks for failure after memory allocation calls that cannot fail:
kmem_alloc() with KM_SLEEP kmem_zalloc() with KM_SLEEP percpu_alloc() pserialize_create() psref_class_create()
all of these paths include an assertion that the allocation has not failed, so callers should not assert that again.
|
1.12 |
| 28-Mar-2017 |
ozaki-r | Avoid touching a mbuf after enqueuing it
|
1.11 |
| 15-Dec-2016 |
ozaki-r | branches: 1.11.2; Move bpf_mtap and if_ipackets++ on Rx of each driver to percpuq if_input
The benefits of the change are: - We can reduce codes - We can provide the same behavior between drivers - Where/When if_ipackets is counted up - Note that some drivers still update packet statistics in their own way (periodical update) - Moved bpf_mtap run in softint - This makes it easy to MP-ify bpf
Proposed on tech-kern and tech-net
|
1.10 |
| 06-Dec-2016 |
ozaki-r | Use if_percpuq_enqueue, not if_input
Because gmac_hwqueue_rxconsume is called in hardware interrupt.
|
1.9 |
| 10-Jun-2016 |
ozaki-r | branches: 1.9.2; Introduce m_set_rcvif and m_reset_rcvif
The API is used to set (or reset) a received interface of a mbuf. They are counterpart of m_get_rcvif, which will come in another commit, hide internal of rcvif operation, and reduce the diff of the upcoming change.
No functional change.
|
1.8 |
| 09-Feb-2016 |
ozaki-r | Introduce softint-based if_input
This change intends to run the whole network stack in softint context (or normal LWP), not hardware interrupt context. Note that the work is still incomplete by this change; to that end, we also have to softint-ify if_link_state_change (and bpf) which can still run in hardware interrupt.
This change softint-ifies at ifp->if_input that is called from each device driver (and ieee80211_input) to ensure Layer 2 runs in softint (e.g., ether_input and bridge_input). To this end, we provide a framework (called percpuq) that utlizes softint(9) and percpu ifqueues. With this patch, rxintr of most drivers just queues received packets and schedules a softint, and the softint dequeues packets and does rest packet processing.
To minimize changes to each driver, percpuq is allocated in struct ifnet for now and that is initialized by default (in if_attach). We probably have to move percpuq to softc of each driver, but it's future work. At this point, only wm(4) has percpuq in its softc as a reference implementation.
Additional information including performance numbers can be found in the thread at tech-kern@ and tech-net@: http://mail-index.netbsd.org/tech-kern/2016/01/14/msg019997.html
Acknowledgment: riastradh@ greatly helped this work. Thank you very much!
|
1.7 |
| 01-Jul-2011 |
dyoung | branches: 1.7.12; 1.7.30; #include <sys/bus.h> instead of <machine/bus.h>.
|
1.6 |
| 05-Apr-2010 |
joerg | Push the bpf_ops usage back into bpf.h. Push the common ifp->if_bpf check into the inline functions as well the fourth argument for bpf_attach.
|
1.5 |
| 19-Jan-2010 |
pooka | branches: 1.5.2; 1.5.4; Redefine bpf linkage through an always present op vector, i.e. #if NBPFILTER is no longer required in the client. This change doesn't yet add support for loading bpf as a module, since drivers can register before bpf is attached. However, callers of bpf can now be modularized.
Dynamically loadable bpf could probably be done fairly easily with coordination from the stub driver and the real driver by registering attachments in the stub before the real driver is loaded and doing a handoff. ... and I'm not going to ponder the depths of unload here.
Tested with i386/MONOLITHIC, modified MONOLITHIC without bpf and rump.
|
1.4 |
| 18-Jan-2010 |
pooka | Pass correct pointer to bpf_mtap() and most likely avoid a crash if bpf is activated.
not even compile-tested, since i can't find any config in the tree which uses this(?)
|
1.3 |
| 23-Dec-2008 |
matt | branches: 1.3.2; 1.3.4; 1.3.8; Baby steps to a working driver. transmit works. receive sometimes works but the h/w is doing really weird shit.
|
1.2 |
| 15-Dec-2008 |
matt | Get the gmac driver close to working.
|
1.1 |
| 14-Dec-2008 |
matt | Add the beginning of a driver which supports the on-chip gmac (gigabit) ethernet port. It's still being debugged but it attaches and does some things right. And a lot wrong. That's what debugging is for.
|
1.3.8.4 |
| 11-Aug-2010 |
yamt | sync with head.
|
1.3.8.3 |
| 11-Mar-2010 |
yamt | sync with head
|
1.3.8.2 |
| 04-May-2009 |
yamt | sync with head.
|
1.3.8.1 |
| 23-Dec-2008 |
yamt | file gemini_gmac.c was added on branch yamt-nfs-mp on 2009-05-04 08:10:41 +0000
|
1.3.4.2 |
| 19-Jan-2009 |
skrll | Sync with HEAD.
|
1.3.4.1 |
| 23-Dec-2008 |
skrll | file gemini_gmac.c was added on branch nick-hppapmap on 2009-01-19 13:15:57 +0000
|
1.3.2.2 |
| 17-Jan-2009 |
mjf | Sync with HEAD.
|
1.3.2.1 |
| 23-Dec-2008 |
mjf | file gemini_gmac.c was added on branch mjf-devfs2 on 2009-01-17 13:27:52 +0000
|
1.5.4.1 |
| 30-May-2010 |
rmind | sync with head
|
1.5.2.1 |
| 30-Apr-2010 |
uebayasi | Sync with HEAD.
|
1.7.30.4 |
| 28-Aug-2017 |
skrll | Sync with HEAD
|
1.7.30.3 |
| 05-Feb-2017 |
skrll | Sync with HEAD
|
1.7.30.2 |
| 09-Jul-2016 |
skrll | Sync with HEAD
|
1.7.30.1 |
| 19-Mar-2016 |
skrll | Sync with HEAD
|
1.7.12.1 |
| 03-Dec-2017 |
jdolecek | update from HEAD
|
1.9.2.2 |
| 26-Apr-2017 |
pgoyette | Sync with HEAD
|
1.9.2.1 |
| 07-Jan-2017 |
pgoyette | Sync with HEAD. (Note that most of these changes are simply $NetBSD$ tag issues.)
|
1.11.2.1 |
| 21-Apr-2017 |
bouyer | Sync with HEAD
|
1.13.8.4 |
| 26-Jan-2019 |
pgoyette | Sync with HEAD
|
1.13.8.3 |
| 28-Jul-2018 |
pgoyette | Sync with HEAD
|
1.13.8.2 |
| 21-May-2018 |
pgoyette | Sync with HEAD
|
1.13.8.1 |
| 02-May-2018 |
pgoyette | Synch with HEAD
|
1.13.2.1 |
| 06-Nov-2019 |
martin | Pull up following revision(s) (requested by msaitoh in ticket #1427):
sys/arch/arm/broadcom/bcm53xx_eth.c: revision 1.39 sys/dev/pcmcia/if_xi.c: revision 1.91 sys/dev/ic/aic6915.c: revision 1.40 sys/dev/pci/if_tl.c: revision 1.117 sys/arch/arm/gemini/gemini_gmac.c: revision 1.18 sys/dev/ic/elinkxl.c: revision 1.133 sys/dev/pci/if_ste.c: revision 1.57 sys/dev/pci/if_alc.c: revision 1.43 sys/dev/pci/if_stge.c: revision 1.72 sys/dev/pci/if_ale.c: revision 1.34 sys/dev/pci/if_age.c: revision 1.62 sys/dev/pci/if_txp.c: revision 1.60 sys/dev/ic/i82557.c: revision 1.156 sys/dev/pci/if_vte.c: revision 1.27 sys/arch/powerpc/booke/dev/pq3etsec.c: revision 1.47 sys/arch/arm/gemini/if_gpn.c: revision 1.13
if_percpuq(9) and ether_input() automatically increment if_ipackets, so don't add number of RX frames from device's statistics counter to if_ipackets to avoid double count.
|
1.16.2.3 |
| 13-Apr-2020 |
martin | Mostly merge changes from HEAD upto 20200411
|
1.16.2.2 |
| 08-Apr-2020 |
martin | Merge changes from current as of 20200406
|
1.16.2.1 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
1.17.4.1 |
| 06-Nov-2019 |
martin | Pull up following revision(s) (requested by msaitoh in ticket #403):
sys/arch/arm/broadcom/bcm53xx_eth.c: revision 1.39 sys/dev/pcmcia/if_xi.c: revision 1.91 sys/dev/ic/aic6915.c: revision 1.40 sys/dev/pci/if_tl.c: revision 1.117 sys/arch/arm/gemini/gemini_gmac.c: revision 1.18 sys/dev/ic/elinkxl.c: revision 1.133 sys/dev/pci/if_ste.c: revision 1.57 sys/dev/pci/if_alc.c: revision 1.43 sys/dev/pci/if_stge.c: revision 1.72 sys/dev/pci/if_ale.c: revision 1.34 sys/dev/pci/if_age.c: revision 1.62 sys/dev/pci/if_txp.c: revision 1.60 sys/dev/ic/i82557.c: revision 1.156 sys/dev/pci/if_vte.c: revision 1.27 sys/arch/powerpc/booke/dev/pq3etsec.c: revision 1.47 sys/arch/arm/gemini/if_gpn.c: revision 1.13
if_percpuq(9) and ether_input() automatically increment if_ipackets, so don't add number of RX frames from device's statistics counter to if_ipackets to avoid double count.
|
1.18.2.1 |
| 29-Feb-2020 |
ad | Sync with head.
|
1.20.8.2 |
| 03-Apr-2021 |
thorpej | Give config_attach() the tagged variadic argument treatment and mechanically convert all call sites.
|
1.20.8.1 |
| 20-Mar-2021 |
thorpej | The proliferation if config_search_*() and config_found_*() combinations is a little absurd, so begin to tidy this up:
- Introduce a new cfarg_t enumerated type, that defines the types of tag-value variadic arguments that can be passed to the various config_*() functions (CFARG_SUBMATCH, CFARG_IATTR, and CFARG_LOCATORS, for now, plus a CFARG_EOL sentinel). - Collapse config_search_*() into config_search() that takes these variadic arguments. - Convert all call sites of config_search_*() to the new signature. Noticed several incorrect usages along the way, which will be audited in a future commit.
|
1.21.8.1 |
| 04-Aug-2021 |
thorpej | Adapt to CFARGS().
|