| History log of /src/sys/dev/ic/aic79xx_inline.h |
| Revision | | Date | Author | Comments |
| 1.24 |
| 13-Aug-2021 |
andvar | fix typos in words "pointer" and s/fram /frame/
|
| 1.23 |
| 08-Feb-2020 |
msaitoh | Apply FreeBSD r357300:
> aic7xxx(4): Fix unintended sign extension in ahd_inq()
>
> ahd_inb() returns type uint8_t. The shift left by untyped 24 implicitly
> promotes the result to type (signed) int. Then the binary OR with uint64_t
> values sign-extends the integer. If bit 31 of the read value happened to be
> set, the 64-bit result would have all upper 32 bits set to 1 due to OR.
> This is clearly not intended.
>
> Reported by: Coverity
> CID: 980473 (old one!)
|
| 1.22 |
| 27-Apr-2013 |
kardel | branches: 1.22.36; 1.22.44;
fix panic due to physaddr instead of offset being passed to ahd_dmamap_sync
|
| 1.21 |
| 03-Apr-2013 |
christos | undo previous commit of unrelated debugging.
|
| 1.20 |
| 03-Apr-2013 |
christos | instead of ifnet use ethercom.
|
| 1.19 |
| 05-Sep-2009 |
tsutsui | branches: 1.19.12; 1.19.22;
Remove unnecessary casts against void pointers.
|
| 1.18 |
| 02-Sep-2009 |
tsutsui | TAB vs space cleanup.
|
| 1.17 |
| 15-Mar-2009 |
cegger | ansify function definitions
|
| 1.16 |
| 21-Mar-2008 |
dyoung | branches: 1.16.4; 1.16.12; 1.16.18;
Use aprint_*_dev(), and device_xname(). Constify a bit.
|
| 1.15 |
| 16-Nov-2006 |
christos | branches: 1.15.24; 1.15.44; 1.15.48;
__unused removal on arguments; approved by core.
|
| 1.14 |
| 12-Oct-2006 |
christos | - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
|
| 1.13 |
| 16-Feb-2006 |
perry | branches: 1.13.14; 1.13.16;
Change "inline" back to "__inline" in .h files -- C99 is still too
new, and some apps compile things in C89 mode. C89 keywords stay.
As per core@.
|
| 1.12 |
| 24-Dec-2005 |
perry | branches: 1.12.2; 1.12.4; 1.12.6;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
|
| 1.11 |
| 11-Dec-2005 |
christos | merge ktrace-lwp.
|
| 1.10 |
| 27-Feb-2005 |
perry | branches: 1.10.4;
nuke trailing whitespace
|
| 1.9 |
| 02-Nov-2003 |
wiz | branches: 1.9.8; 1.9.10;
Fix some typos. From Tom Cosgrove via jmc@openbsd.
|
| 1.8 |
| 29-Aug-2003 |
thorpej | Apply the following change from 06/28/2003 04:43:19 by gibbs to the
FreeBSD ahd driver:
Implement ahd_inq_scbram() and change the implemention
of ahd_inl_scbram to use ahd_inw_scbram instead of
ahd_inb_scbram().
|
| 1.7 |
| 29-Aug-2003 |
thorpej | Apply the following change made on 5/26/2003 21:26:51 by gibbs to the
FreeBSD ahd driver:
Correct/Simplify ignore wide residue message handling
aic79xx.c:
In ahd_handle_ign_wide_residue():
o Use SCB_XFERLEN_ODD SCB field to determine transfer
"oddness" rather than the DATA_COUNT_ODD logic.
SCB_XFERLEN_ODD is toggled on every ignore wide
residue message so that multiple ignore wide residue
messages for the same transaction are properly supported.
o If the sg list has been exausted, the sequencer
doesn't bother to update the residual data count
since it is known to be zero. Perform the zeroing
manually before calculating the remaining data count.
o Use multibyte in/out macros instead of shifting/masking
by hand.
aic79xx_inline.h:
In ahd_setup_scb_common(), setup the SCB_XFERLEN_ODD field.
aic79xx.reg:
Use the SCB_TASK_ATTRIBUTE field as a bit field in the
non-packetized case. We currently only define one bit,
SCB_XFERLEN_ODD.
Remove the ODD_SEG bit field that was used to carry the odd
transfer length information through the SG cache. This
is obviated by SCB_XFERLEN_ODD field.
Remove the DATA_COUNT_ODD scratch ram byte that was used
dynamicaly compute data transfer oddness. This is obviated
by SCB_XFERLEN_ODD field.
aic79xx.seq:
Remove all updates to the DATA_COUNT_ODD scratch ram field.
Remove all uses of ODD_SEG. These two save quite a few
sequencer instructions.
Use SCB_XFERLEN_ODD to validate the end of transfer
ignore wide residue message case.
|
| 1.6 |
| 29-Aug-2003 |
thorpej | Apply the following change made 5/26/2003 21:18:48 by gibbs to the
FreeBSD ahd driver:
Change hadling of the Rev. A packetized lun output bug
to be more efficient by having the sequencer copy the
single byte of valid lun data into the long lun field.
aic79xx.c:
Memset our hardware SCB to 0 so that untouched
fields don't confuse diagnostic output. With the
old method for handling the Rev A bug, if the long
lun field was not 0, this could result in bogus
lun information being sent to drives.
Use the same SCB transfer size for all chip types
now that the long lun is not DMA'ed to the chip.
aic79xx.seq:
Add code to copy lun information for Rev.A hardware.
aic79xx_inline.h:
Remove host update of the long_lun field on every
packetized command.
|
| 1.5 |
| 29-Aug-2003 |
thorpej | Apply the following change checked in 2003/05/04 00:20:07 by gibbs
to the FreeBSD ahd driver:
Correct spelling errors.
Switch to handling bad SCSI status as a sequencer interrupt
instead of having the kernel proccess these failures via
the completion queue. This is done because:
o The old scheme required us to pause the sequencer and clear
critical sections for each SCB. It seems that these pause
actions, if coincident with a sequencer FIFO interrupt, would
result in a FIFO interrupt getting lost or directing to the
wrong FIFO. This caused hangs when the driver was stressed
under high "queue full" loads.
o The completion code assumed that it was always called with
the sequencer running. This may not be the case in timeout
processing where completions occur manually via
ahd_pause_and_flushwork().
o With this scheme, the extra expense of clearing critical
sections is avoided since the sequencer will only self pause
once all pending selections have cleared and it is not in
a critical section.
aic79xx.c
Add code to handle the new BAD_SCB_STATUS sequencer
interrupt code. This just redirects the SCB through
the already existing ahd_complete_scb() code path.
Remove code in ahd_handle_scsi_status() that paused
the sequencer, made sure that no selections where
pending, and cleared critical sections. Bad
status SCBs are now only processed when all of these
conditions are true.
aic79xx.reg:
Add the BAD_SCB_STATUS sequencer interrupt code.
aic79xx.seq:
When completing an SCB upload to the host, if
we are doing this because the SCB contains non-zero
SCSI status, defer completing the SCB until there
are no pending selection events. When completing
these SCBs, use the new BAD_SCB_STATUS sequencer
interrupt. For all other uploaded SCBs (currently
only for underruns), the SCB is completed via the
normal done queue. Additionally, keep the SCB that
is currently being uploaded on the COMPLETE_DMA_SCB
list until the dma is completed, not just until the
DMA is started. This ensures that the DMA is restarted
properly should the host disable the DMA transfer for
some reason.
In our RevA workaround for Maxtor drives, guard against
the host pausing us while trying to pause I/O until the
first data-valid REQ by clearing the current snapshot
so that we can tell if the transfer has completed prior
to us noticing the REQINIT status.
In cfg4data_intr, shave off an instruction before getting
the data path running by adding an entrypoint to the
overrun handler to also increment the FIFO use count.
In the overrun handler, be sure to clear our LONGJMP
address in both exit paths.
Perform a few sequencer optimizations.
aic79xx.c:
Print the full path from the SCB when a packetized
status overrun occurs.
Remove references to LONGJMP_SCB which is being
removed from firmware usage.
Print the new SCB_FIFO_USE_COUNT field in the
per-SCB section of ahd_dump_card_state(). The
SCB_TAG field is now re-used by the sequencer,
so it no longer makes sense to reference this
field in the kernel driver.
aic79xx.h:
Re-arrange fields in the hardware SCB from largest
size type to smallest. This makes it easier to
move fields without changing field alignment.
The hardware scb tag field is now down near the
"spare" portion of the SCB to facilitate reuse
by the sequencer.
aic79xx.reg:
Remove LONGJMP_ADDR.
Rearrange SCB fields to match aic79xx.h.
Add SCB_FIFO_USE_COUNT as the first byte
of the SCB_TAG field.
aic79xx.seq:
Add a per-SCB "Fifos in use count" field and use
it to determine when it is safe (all data posted)
to deliver status back to the host. The old method
involved polling one or both FIFOs to verify that
the current task did not have pending data. This
makes running down the GSFIFO very cheap, so we
will empty the GSFIFO in one idle loop pass in
all cases.
Use this simplification of the completion process
to prune down the data FIFO teardown sequencer for
packetized transfers. Much more code is now shared
between the data residual and transfer complete cases.
Correct some issues in the packetized status handler.
It used to be possible to CLRCHN our FIFO before status
had fully transferred to the host. We also failed to
handle NONPACKREQ phases that could occur should a CRC
error occur during transmission of the status data packet.
Correct a few big endian issues:
aic79xx.c:
aic79xx_inline.h:
aic79xx_pci.c:
aic79xx_osm.c:
o Always get the SCB's tag via the SCB_GET_TAG acccessor
o Add missing use of byte swapping macros when touching
hscb fields.
o Don't double swap SEEPROM data when it is printed.
Correct a big-endian bug. We cannot assign a
o When assigning a 32bit LE variable to a 64bit LE
variable, we must be explict about how the words
of the 64bit LE variable are initialized. Cast to
(uint32_t*) to do this.
aic79xx.c:
In ahd_clear_critical_section(), hit CRLSCSIINT
after restoring the interrupt masks to avoid what
appears to be a glitch on SCSIINT. Any real SCSIINT
status will be persistent and will immidiately
reset SCSIINT. This clear should only get rid of
spurious SCSIINTs.
This glitch was the cause of the "Unexpected PKT busfree"
status that occurred under high queue full loads
Call ahd_fini_scbdata() after shutdown so that
any ahd_chip_init() routine that might access
SCB data will not access free'd memory.
Reset the bus on an IOERR since the chip doesn't
seem to reset to the new voltage level without
this.
Change offset calculation for scatter gather maps
so that the calculation is correct if an integral
multiple of sg lists does not fit in the allocation
size.
Adjust bus dma tag for data buffers based on 39BIT
addressing flag in our softc.
Use the QFREEZE count to simplify ahd_pause_and_flushworkd().
We can thus rely on the sequencer eventually clearing ENSELO.
In ahd_abort_scbs(), fix a bug that could potentially
corrupt sequencer state. The saved SCB was being
restored in the SCSI mode instead of the saved mode.
It turns out that the SCB did not need to be saved at all
as the scbptr is already restored by all subroutines
called during this function that modify that register.
aic79xx.c:
aic79xx.h:
aic79xx_pci.c:
Add support for parsing the seeprom vital product
data. The VPD data are currently unused.
aic79xx.h:
aic79xx.seq:
aic79xx_pci.c:
Add a firmware workaround to make the LED blink
brighter during packetized operations on the H2A.
aic79xx_inline.h:
The host does not use timer interrupts, so don't
gate our decision on whether or not to unpause
the sequencer on whether or not a timer interrupt
is pending.
|
| 1.4 |
| 26-Jul-2003 |
thorpej | Make this work on systems where bus_dmamap_sync() is not a noop.
In particular, when doing the "swap hscbs" trick, the scb must
reference the correct hscb_map when it gets a new hscb, otherwise
when you go to sync an hscb later, you could end up using the wrong
dmamap.
In order to make this work, we have to convert the shared_data stuff
to use a map_node, because of the "sentinel" trick played with the
initial "next_hscb".
This driver now works on XScale-based platforms.
|
| 1.3 |
| 08-Jul-2003 |
itojun | function prototype must not have variable name
|
| 1.2 |
| 03-May-2003 |
wiz | branches: 1.2.2;
DMA, not dma nor Dma.
|
| 1.1 |
| 21-Apr-2003 |
fvdl | Add file that I missed when adding the ahd driver.
|
| 1.2.2.4 |
| 04-Mar-2005 |
skrll | Sync with HEAD.
Hi Perry!
|
| 1.2.2.3 |
| 21-Sep-2004 |
skrll | Fix the sync with head I botched.
|
| 1.2.2.2 |
| 18-Sep-2004 |
skrll | Sync with HEAD.
|
| 1.2.2.1 |
| 03-Aug-2004 |
skrll | Sync with HEAD
|
| 1.9.10.1 |
| 19-Mar-2005 |
yamt | sync with head. xen and whitespace. xen part is not finished.
|
| 1.9.8.1 |
| 29-Apr-2005 |
kent | sync with -current
|
| 1.10.4.2 |
| 24-Mar-2008 |
yamt | sync with head.
|
| 1.10.4.1 |
| 30-Dec-2006 |
yamt | sync with head.
|
| 1.12.6.1 |
| 22-Apr-2006 |
simonb | Sync with head.
|
| 1.12.4.1 |
| 09-Sep-2006 |
rpaulo | sync with head
|
| 1.12.2.1 |
| 18-Feb-2006 |
yamt | sync with head.
|
| 1.13.16.2 |
| 10-Dec-2006 |
yamt | sync with head.
|
| 1.13.16.1 |
| 22-Oct-2006 |
yamt | sync with head
|
| 1.13.14.1 |
| 18-Nov-2006 |
ad | Sync with head.
|
| 1.15.48.1 |
| 03-Apr-2008 |
mjf | Sync with HEAD.
|
| 1.15.44.1 |
| 24-Mar-2008 |
keiichi | sync with head.
|
| 1.15.24.1 |
| 23-Mar-2008 |
matt | sync with HEAD
|
| 1.16.18.1 |
| 13-May-2009 |
jym | Sync with HEAD.
Commit is split, to avoid a "too many arguments" protocol error.
|
| 1.16.12.1 |
| 28-Apr-2009 |
skrll | Sync with HEAD.
|
| 1.16.4.2 |
| 16-Sep-2009 |
yamt | sync with head
|
| 1.16.4.1 |
| 04-May-2009 |
yamt | sync with head.
|
| 1.19.22.1 |
| 23-Jun-2013 |
tls | resync from head
|
| 1.19.12.1 |
| 22-May-2014 |
yamt | sync with head.
for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.
this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
|
| 1.22.44.1 |
| 29-Feb-2020 |
ad | Sync with head.
|
| 1.22.36.1 |
| 08-Apr-2020 |
martin | Merge changes from current as of 20200406
|
