| History log of /src/sys/netbt/hci_link.c |
| Revision | | Date | Author | Comments |
| 1.27 |
| 05-Jul-2024 |
rin | sys: Drop redundant NULL check before m_freem(9)
m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c
Compile-tested on amd64/ALL.
Suggested by knakahara@
|
| 1.26 |
| 04-Dec-2021 |
andvar | fix typos in comments and log messages, mainly in establish(ed).
|
| 1.25 |
| 07-Sep-2018 |
plunky | two issues noted by maxv@
1. If an adaptor sends repeated fragments indicating HCI_PACKET_START,
we would leak mbufs. Fix that by releasing the previous in that case.
2. If an adaptor sends fragments which overflow the expected total
payload length, it could build up the pending packet to use up system
mbufs. Fix that by changing the unsigned calculation to a comparison
and rejecting oversize packets
|
| 1.24 |
| 20-May-2014 |
rmind | branches: 1.24.26; 1.24.28;
netbt: rename some attach/detach functions to have _pcb suffix, so
we could use standard attach/detach naming for pr_usrreq functions.
No functional change.
|
| 1.23 |
| 27-Jul-2011 |
plunky | branches: 1.23.12; 1.23.26;
cleanup some DIAGNOSTIC and KASSERT code
- remove #ifdef DIAGNOSTIC, so that we won't act
differently
- handle the cases where a Bluetooth adapter
sends invalid packet data (I've not seen this,
but it is not impossible)
- use KASSERT for actual impossible situations
(to catch bad future development)
|
| 1.22 |
| 14-Oct-2010 |
plunky | Some Broadcom controllers emit empty ACL packets during connection
setup, using the handle that they have not yet told us for the
connection-to-be. Disconnecting can cause problems so just ignore
zero length ACL packets on unknown connection handles.
fixes a problem reported by Nick Hudson
|
| 1.21 |
| 24-Sep-2009 |
plunky | branches: 1.21.2; 1.21.4;
Only accept incoming ACL connections when there is potential
L2CAP listener available.
|
| 1.20 |
| 24-Apr-2008 |
ad | branches: 1.20.2; 1.20.12;
Merge the socket locking patch:
- Socket layer becomes MP safe.
- Unix protocols become MP safe.
- Allows protocol processing interrupts to safely block on locks.
- Fixes a number of race conditions.
With much feedback from matt@ and plunky@.
|
| 1.19 |
| 16-Mar-2008 |
plunky | branches: 1.19.2;
we always know the bdaddr and type of a link when creating it, so
pass them to the _alloc() function and let it set them.
|
| 1.18 |
| 16-Mar-2008 |
plunky | insert new links at the tail of the queue so that if a create_connection
command fails to start we can find the relevant link, since it will be
the first one with the pending flag set.
|
| 1.17 |
| 06-Mar-2008 |
plunky | a "Create Connection" command can sometimes fail to start for whatever
reason and the command_status event returns failure but we get no
indication of which connection failed (for instance in the case where
we tried to open too many connections all at once)
So, keep a flag on the link to indicate pending status until the
command_status event is returned to help us decide which should
be failed.
|
| 1.16 |
| 10-Nov-2007 |
plunky | branches: 1.16.10; 1.16.14;
use more device_t and device_xxx() accessors
make bluetooth stack keep device_t instead of softc pointer as
device is not necessarily part of softc, and pass device_t to
driver callbacks. hci_devname is no longer required.
|
| 1.15 |
| 03-Nov-2007 |
plunky | branches: 1.15.2;
"struct callout" -> callout_t
don't use callout_reset()
do use callout_destroy()
|
| 1.14 |
| 16-Sep-2007 |
plunky | branches: 1.14.4;
improve memo taking of known bluetooth devices
- centralise creation of new memo into function
hci_memo_new(), when a memo exists for that address,
just update the timestamp.
- all results of inquiry/rssi result are processed; even
if no memo can be allocated, we may update a timestamp.
- for new connections, query the clock offset of the remote
device, in order that we can use it to facilitate future
reconnections
- as a connection is removed, make a memo of the clock offset
|
| 1.13 |
| 07-Sep-2007 |
plunky | add event processing for "Inquiry result with RSSI", and modify the memo
contents so that this will fit.
|
| 1.12 |
| 09-Jul-2007 |
ad | branches: 1.12.2; 1.12.6; 1.12.8;
Merge some of the less invasive changes from the vmlocking branch:
- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements
|
| 1.11 |
| 21-Apr-2007 |
plunky | Add 'service level' security for L2CAP and RFCOMM connections, following
the Linux (BlueZ) API.
- L2CAP or RFCOMM connections can require the baseband radio link
mode be any of:
authenticated (devices are paired)
encrypted (implies authentication)
secured (encryption, plus generate new link key)
- for sockets, the mode is set using setsockopt(2) and the socket
connection will be aborted if the mode change fails.
- mode settings will be applied during connection establishment, and
for safety, we enter a wait state and will only proceed when the mode
settings are successfuly set.
- It is possible to change the mode on already open connections, but
not possible to guarantee that data already queued (from either end)
will not be delivered. (this is a feature, not a bug)
- bthidev(4) and rfcomm_sppd(1) support "auth", "encrypt" and
"secure" options
- btdevctl(8) by default enables "auth" for HIDs, and "encrypt" for
keyboards (which are required to support it)
|
| 1.10 |
| 30-Mar-2007 |
plunky | be more explicit and consistent in use of KASSERT with pointers,
test against NULL
|
| 1.9 |
| 26-Dec-2006 |
alc | branches: 1.9.2; 1.9.6; 1.9.8;
CID-3819: `n' is always NULL here, remove dead code.
|
| 1.8 |
| 16-Nov-2006 |
christos | branches: 1.8.2; 1.8.4;
__unused removal on arguments; approved by core.
|
| 1.7 |
| 12-Oct-2006 |
christos | - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
|
| 1.6 |
| 04-Oct-2006 |
christos | fix empty if
|
| 1.5 |
| 11-Sep-2006 |
plunky | branches: 1.5.2;
Endian issues:
hci_event.c:
- Convert memo->response.clock_offset to host-endian.
hci_ioctl.c:
- printf format tweak (size_t)
hci_link.c:
- Convert memo->response.clock_offset from host-endian.
- Tweak a DIAGNOSTIC message.
l2cap_signal.c:
- In l2cap_recv_config_req(), rp->scid is little-endian so make sure
we convert from host-endian.
from scw@
|
| 1.4 |
| 11-Sep-2006 |
plunky | hci_link.c:
- In hci_link_free(), do not unlink items from a LIST queue within
a LIST_FOREACH() iterator.
rfcomm_session.c:
- In rfcomm_session_recv_mcc_nsc(), do not unlink items from a LIST
queue within a LIST_FOREACH() iterator.
from scw@
|
| 1.3 |
| 26-Jul-2006 |
tron | branches: 1.3.2; 1.3.4; 1.3.6;
Bluetooth fixes by Iain Hibbert:
- Enable listening and incoming connections for SCO links.
|
| 1.2 |
| 26-Jul-2006 |
tron | Bluetooth fixes by Iain Hibbert:
- Utilise cached inquiry results when making connections.
|
| 1.1 |
| 19-Jun-2006 |
gdamore | branches: 1.1.2; 1.1.4; 1.1.6; 1.1.8;
Initial import of bluetooth stack on behalf of Iain Hibbert. (plunky@,
NetBSD Foundation Membership still pending.) This stack was written by
Iain under sponsorship from Itronix Inc.
The stack includes support for rfcomm networking (networking via your
bluetooth enabled cell phone), hid devices (keyboards/mice), and headsets.
Drivers for both PCMCIA and USB bluetooth controllers are included.
|
| 1.1.8.2 |
| 13-Jul-2006 |
gdamore | Merge from HEAD.
|
| 1.1.8.1 |
| 19-Jun-2006 |
gdamore | file hci_link.c was added on branch gdamore-uart on 2006-07-13 17:49:58 +0000
|
| 1.1.6.4 |
| 14-Sep-2006 |
yamt | sync with head.
|
| 1.1.6.3 |
| 11-Aug-2006 |
yamt | sync with head
|
| 1.1.6.2 |
| 26-Jun-2006 |
yamt | sync with head.
|
| 1.1.6.1 |
| 19-Jun-2006 |
yamt | file hci_link.c was added on branch yamt-pdpolicy on 2006-06-26 12:53:57 +0000
|
| 1.1.4.2 |
| 22-Jun-2006 |
chap | Complete a sync sys/ with head.
|
| 1.1.4.1 |
| 19-Jun-2006 |
chap | file hci_link.c was added on branch chap-midi on 2006-06-22 03:39:50 +0000
|
| 1.1.2.7 |
| 17-Mar-2008 |
yamt | sync with head.
|
| 1.1.2.6 |
| 15-Nov-2007 |
yamt | sync with head.
|
| 1.1.2.5 |
| 27-Oct-2007 |
yamt | sync with head.
|
| 1.1.2.4 |
| 03-Sep-2007 |
yamt | sync with head.
|
| 1.1.2.3 |
| 30-Dec-2006 |
yamt | sync with head.
|
| 1.1.2.2 |
| 21-Jun-2006 |
yamt | sync with head.
|
| 1.1.2.1 |
| 19-Jun-2006 |
yamt | file hci_link.c was added on branch yamt-lazymbuf on 2006-06-21 15:10:51 +0000
|
| 1.3.6.2 |
| 09-Sep-2006 |
rpaulo | sync with head
|
| 1.3.6.1 |
| 26-Jul-2006 |
rpaulo | file hci_link.c was added on branch rpaulo-netinet-merge-pcb on 2006-09-09 02:58:38 +0000
|
| 1.3.4.2 |
| 12-Jan-2007 |
ad | Sync with head.
|
| 1.3.4.1 |
| 18-Nov-2006 |
ad | Sync with head.
|
| 1.3.2.1 |
| 14-Sep-2006 |
riz | Pull up following revision(s) (requested by plunky in ticket #161):
sys/dev/bluetooth/btdev.h: revision 1.4
distrib/sets/lists/comp/mi: revision 1.922
usr.sbin/postinstall/postinstall: revision 1.25
sys/netbt/hci_unit.c: revision 1.3
sys/netbt/hci_ioctl.c: revision 1.4
usr.sbin/sdpd/profile.c: revision 1.2
usr.sbin/btdevctl/btdevctl.c: revision 1.2
share/man/man4/Makefile: revision 1.405
distrib/sets/lists/man/mi: revision 1.930
distrib/sets/lists/etc/mi: revision 1.176
usr.sbin/sdpd/profile.c: revision 1.3
usr.sbin/btdevctl/btdevctl.c: revision 1.3
etc/MAKEDEV.tmpl: revision 1.62
distrib/sets/lists/base/mi: revision 1.650
usr.sbin/btdevctl/btdevctl.h: revision 1.2
usr.bin/sdpquery/sdpquery.1: revision 1.4
sys/netbt/rfcomm_session.c: revision 1.2
usr.sbin/btdevctl/btdevctl.8: revision 1.3
usr.bin/sdpquery/search.c: revision 1.2
usr.sbin/sdpd/Makefile: revision 1.2
sys/dev/bluetooth/Makefile: revision 1.3
usr.sbin/btdevctl/cfg.c: file removal
sys/netbt/files.netbt: revision 1.4
usr.sbin/btdevctl/sdp.c: revision 1.1
sys/dev/bluetooth/bthidev.c: revision 1.3
etc/bluetooth/Makefile: revision 1.3
sys/dev/pcmcia/files.pcmcia: revision 1.51
sys/dev/bluetooth/bthidev.c: revision 1.4
sys/dev/bluetooth/bthidev.h: revision 1.3
usr.sbin/btdevctl/dev.c: file removal
sys/dev/bluetooth/files.bluetooth: revision 1.10
sys/arch/i386/conf/GENERIC: revision 1.777
share/man/man4/ubt.4: revision 1.6
share/man/man4/bthub.4: revision 1.3
sys/netbt/hci.h: revision 1.5
sys/arch/i386/conf/GENERIC_LAPTOP: revision 1.202
lib/libsdp/sdp.h: revision 1.2
usr.sbin/btdevctl/print.c: revision 1.1
share/man/man4/bthidev.4: revision 1.5
share/man/man4/btdev.4: file removal
usr.sbin/btdevctl/print.c: revision 1.2
sys/arch/i386/conf/GENERIC_LAPTOP: revision 1.205
usr.sbin/btdevctl/Makefile: revision 1.2
sys/dev/usb/files.usb: revision 1.70
sys/netbt/l2cap_signal.c: revision 1.2
sys/netbt/hci_link.c: revision 1.4
sys/dev/bluetooth/bthub.c: revision 1.3
share/man/man4/btsco.4: revision 1.5
sys/netbt/hci_link.c: revision 1.5
share/man/man4/btdev.4: revision 1.4
sys/dev/bluetooth/btkbd.c: revision 1.3
sys/dev/bluetooth/btdev.c: file removal
sys/netbt/hci_event.c: revision 1.2
sys/dev/bluetooth/btsco.h: revision 1.2
etc/mtree/special: revision 1.101
sys/dev/bluetooth/btsco.c: revision 1.3
sys/conf/majors: revision 1.27
usr.sbin/sdpd/hf.c: revision 1.1
sys/dev/bluetooth/btsco.c: revision 1.4
share/man/man5/rc.conf.5: revision 1.107
sys/dev/bluetooth/btdev.c: revision 1.2
etc/rc.d/btdevctl: revision 1.2
usr.sbin/btdevctl/db.c: revision 1.1
etc/rc.d/btdevctl: revision 1.3
etc/bluetooth/btdevctl.conf: revision 1.1
usr.sbin/btdevctl/hid.c: file removal
sys/arch/i386/conf/GENERIC: revision 1.781
sys/dev/bluetooth/btdev.h: revision 1.3
Make btdev default count explicit
Fix typo in variable name
update to bluetooth device attachment:
remove pseudo-device btdev(4) and inherent limitations
add bthub(4) which autoconfigures at bluetooth controllers as they
are enabled. bluetooth devices now attach here.
btdevctl(8) and its cache is updated to handle new semantics
etc/rc.d/btdevctl is updated to configure devices from a list
in /etc/bluetooth/btdevctl.conf
also include service name in dictionary being sent to kernel.
(this is not used just yet, but it might be in the future and it will
be easier if we dont have to provide code to handle its absence)
clarify the CAVEAT section somewhat
Add service discovery support for the Handsfree profile
Replace static 'FreeBSD' string with operating system name gleaned
from uname(3)
Halt the callout on detach
btsco.c:
- sco_getopt(..., SO_SCO_MTU, ...) expects the address of a uint16_t,
not an int. So change sc_mtu's type to uint16_t.
- Try a little harder to ensure btsco_round_blocksize() does not
return zero. Prevents a subsequent panic in audio_init_ringbuffer().
from scw@
Endian issues:
hci_event.c:
- Convert memo->response.clock_offset to host-endian.
hci_ioctl.c:
- printf format tweak (size_t)
hci_link.c:
- Convert memo->response.clock_offset from host-endian.
- Tweak a DIAGNOSTIC message.
l2cap_signal.c:
- In l2cap_recv_config_req(), rp->scid is little-endian so make sure
we convert from host-endian.
from scw@
hci_link.c:
- In hci_link_free(), do not unlink items from a LIST queue within
a LIST_FOREACH() iterator.
rfcomm_session.c:
- In rfcomm_session_recv_mcc_nsc(), do not unlink items from a LIST
queue within a LIST_FOREACH() iterator.
from scw@
guard against a possible situation where the list of l2cap channels is changed
when the bluetooth code is not expecting it to be. During a disconnect, we can
detach the channel that is being disconnected, but its not really safe to detach
any others.
Print explicit 64-bit types using the format macros from int_fmtio.h.
Unbreaks the build for our LP64 ports, where "long long" typically is
not 64 bits.
|
| 1.5.2.2 |
| 10-Dec-2006 |
yamt | sync with head.
|
| 1.5.2.1 |
| 22-Oct-2006 |
yamt | sync with head
|
| 1.8.4.1 |
| 03-Sep-2007 |
wrstuden | Sync w/ NetBSD-4-RC_1
|
| 1.8.2.2 |
| 21-Nov-2010 |
riz | Pull up following revision(s) (requested by plunky in ticket #1409):
sys/netbt/hci_link.c: revision 1.22
Some Broadcom controllers emit empty ACL packets during connection
setup, using the handle that they have not yet told us for the
connection-to-be. Disconnecting can cause problems so just ignore
zero length ACL packets on unknown connection handles.
fixes a problem reported by Nick Hudson
|
| 1.8.2.1 |
| 19-Jul-2007 |
liamjfoy | Pull up following revision(s) (requested by plunky in ticket #744):
sys/netbt/l2cap_lower.c: revision 1.6
sys/dev/bluetooth/btdev.h: revision 1.6
sys/netbt/sco_socket.c: revision 1.9
sys/netbt/rfcomm_upper.c: revision 1.3
sys/netbt/l2cap_socket.c: revision 1.7
sys/netbt/rfcomm_upper.c: revision 1.5
lib/libusbhid/usbhid.h: revision 1.5
sys/netbt/rfcomm_upper.c: revision 1.6
usr.sbin/btdevctl/btdevctl.c: revision 1.4
usr.sbin/btdevctl/btdevctl.h: revision 1.3
usr.sbin/btdevctl/btdevctl.8: revision 1.4
sys/netbt/rfcomm_session.c: revision 1.5
sys/netbt/hci.h: revision 1.10
usr.bin/rfcomm_sppd/rfcomm_sppd.c: revision 1.6
sys/netbt/hci_link.c: revision 1.11
usr.bin/rfcomm_sppd/rfcomm_sppd.c: revision 1.7
usr.bin/rfcomm_sppd/rfcomm_sppd.c: revision 1.8
sys/dev/bluetooth/btsco.c: revision 1.14
sys/netbt/rfcomm_session.c: revision 1.9
usr.sbin/btdevctl/sdp.c: revision 1.2
share/man/man9/bluetooth.9: revision 1.2
usr.sbin/btdevctl/sdp.c: revision 1.3
sys/dev/bluetooth/bthidev.c: revision 1.8
sys/netbt/l2cap.h: revision 1.4
sys/netbt/rfcomm.h: revision 1.3
sys/netbt/l2cap.h: revision 1.5
sys/netbt/l2cap_misc.c: revision 1.3
share/man/man4/bluetooth.4: revision 1.5
lib/libusbhid/usbhid.3: revision 1.11
sys/netbt/bluetooth.h: revision 1.5
share/man/man4/bthidev.4: revision 1.8
sys/netbt/rfcomm_dlc.c: revision 1.3
usr.sbin/btdevctl/print.c: revision 1.8
sys/netbt/rfcomm_socket.c: revision 1.7
sys/netbt/l2cap_signal.c: revision 1.4
sys/netbt/l2cap_signal.c: revision 1.5
sys/netbt/l2cap_signal.c: revision 1.7
sys/netbt/hci_event.c: revision 1.6
usr.bin/rfcomm_sppd/rfcomm_sppd.1: revision 1.5
sys/netbt/l2cap_upper.c: revision 1.3
sys/netbt/l2cap_lower.c: revision 1.2
usr.sbin/btdevctl/db.c: revision 1.3
sys/netbt/l2cap_upper.c: revision 1.6
lib/libusbhid/descr.c: revision 1.5
sys/netbt/l2cap_upper.c: revision 1.7
sys/netbt/l2cap_lower.c: revision 1.4
Add 'service level' security for L2CAP and RFCOMM connections, following
the Linux (BlueZ) API.
- L2CAP or RFCOMM connections can require the baseband radio link
mode be any of:
authenticated (devices are paired)
encrypted (implies authentication)
secured (encryption, plus generate new link key)
- for sockets, the mode is set using setsockopt(2) and the socket
connection will be aborted if the mode change fails.
- mode settings will be applied during connection establishment, and
for safety, we enter a wait state and will only proceed when the mode
settings are successfuly set.
- It is possible to change the mode on already open connections, but
not possible to guarantee that data already queued (from either end)
will not be delivered. (this is a feature, not a bug)
- bthidev(4) and rfcomm_sppd(1) support "auth", "encrypt" and
"secure" options
- btdevctl(8) by default enables "auth" for HIDs, and "encrypt" for
keyboards (which are required to support it)
- ALSO INCLUDES OTHER MINOR FIXES
|
| 1.9.8.1 |
| 11-Jul-2007 |
mjf | Sync with head.
|
| 1.9.6.4 |
| 09-Oct-2007 |
ad | Sync with head.
|
| 1.9.6.3 |
| 01-Jul-2007 |
ad | Adapt to callout API change.
|
| 1.9.6.2 |
| 08-Jun-2007 |
ad | Sync with head.
|
| 1.9.6.1 |
| 10-Apr-2007 |
ad | Sync with head.
|
| 1.9.2.2 |
| 07-May-2007 |
yamt | sync with head.
|
| 1.9.2.1 |
| 15-Apr-2007 |
yamt | sync with head.
|
| 1.12.8.3 |
| 23-Mar-2008 |
matt | sync with HEAD
|
| 1.12.8.2 |
| 09-Jan-2008 |
matt | sync with HEAD
|
| 1.12.8.1 |
| 06-Nov-2007 |
matt | sync with HEAD
|
| 1.12.6.3 |
| 11-Nov-2007 |
joerg | Sync with HEAD.
|
| 1.12.6.2 |
| 04-Nov-2007 |
jmcneill | Sync with HEAD.
|
| 1.12.6.1 |
| 02-Oct-2007 |
joerg | Sync with HEAD.
|
| 1.12.2.1 |
| 10-Sep-2007 |
skrll | Sync with HEAD.
|
| 1.14.4.1 |
| 13-Nov-2007 |
bouyer | Sync with HEAD
|
| 1.15.2.1 |
| 19-Nov-2007 |
mjf | Sync with HEAD.
|
| 1.16.14.2 |
| 02-Jun-2008 |
mjf | Sync with HEAD.
|
| 1.16.14.1 |
| 03-Apr-2008 |
mjf | Sync with HEAD.
|
| 1.16.10.1 |
| 24-Mar-2008 |
keiichi | sync with head.
|
| 1.19.2.1 |
| 18-May-2008 |
yamt | sync with head.
|
| 1.20.12.1 |
| 21-Nov-2010 |
riz | Pull up following revision(s) (requested by plunky in ticket #1461):
sys/netbt/hci_link.c: revision 1.22
Some Broadcom controllers emit empty ACL packets during connection
setup, using the handle that they have not yet told us for the
connection-to-be. Disconnecting can cause problems so just ignore
zero length ACL packets on unknown connection handles.
fixes a problem reported by Nick Hudson
|
| 1.20.2.1 |
| 11-Mar-2010 |
yamt | sync with head
|
| 1.21.4.1 |
| 05-Mar-2011 |
rmind | sync with head
|
| 1.21.2.1 |
| 22-Oct-2010 |
uebayasi | Sync with HEAD (-D20101022).
|
| 1.23.26.1 |
| 10-Aug-2014 |
tls | Rebase.
|
| 1.23.12.1 |
| 20-Aug-2014 |
tls | Rebase to HEAD as of a few days ago.
|
| 1.24.28.1 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
| 1.24.26.1 |
| 30-Sep-2018 |
pgoyette | Ssync with HEAD
|
