Home | History | Annotate | Download | only in ic
History log of /src/sys/dev/ic/cac.c
RevisionDateAuthorComments
 1.64  10-Feb-2024  andvar s/musn't/mustn't/ in comments.
 1.63  07-Aug-2021  thorpej Merge thorpej-cfargs2.
 1.62  24-Apr-2021  thorpej branches: 1.62.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).
 1.61  10-Nov-2019  chs branches: 1.61.10;
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.
 1.60  08-May-2019  cnst bio(4) drivers: remove noop fallthrough-to-default bio(4) cmd cases

* Makes it easier to do code/feature analysis by not having
extra noop code/symbols spattered around.

* Only an issue in cac(4) and ciss(4); other drivers don't do this.

* No binary changes.
 1.59  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.58  28-Oct-2017  riastradh branches: 1.58.2; 1.58.4;
Kill some more extern struct cfdriver declarations.

Down with externs in .c!
 1.57  27-Sep-2016  pgoyette Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).
 1.56  07-Jul-2016  msaitoh branches: 1.56.2;
KNF. Remove extra spaces. No functional change.
 1.55  12-Mar-2015  christos Dedup the conversion of bioc_disk and bioc_vol to envsys_data_t
 1.54  27-Oct-2012  chs branches: 1.54.14;
split device_t/softc for all remaining drivers.
replace "struct device *" with "device_t".
use device_xname(), device_unit(), etc.
 1.53  20-Jun-2011  pgoyette branches: 1.53.2; 1.53.12;
Initialize current value for ENVSYS_DRIVE sensors
 1.52  20-Jun-2011  pgoyette Initializes sensors states before registering.
 1.51  13-Nov-2010  uebayasi branches: 1.51.6;
Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.
 1.50  14-Mar-2010  pgoyette branches: 1.50.2;
Remove setting of edata->monitor since that member no longer exists.
 1.49  12-May-2009  cegger branches: 1.49.2;
struct device * -> device_t, no functional changes intended.
 1.48  18-Mar-2009  cegger bzero -> memset
 1.47  08-Jun-2008  tsutsui branches: 1.47.6; 1.47.12;
Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.
 1.46  28-Apr-2008  martin branches: 1.46.2;
Remove clause 3 and 4 from TNF licenses
 1.45  08-Apr-2008  cegger branches: 1.45.2; 1.45.4;
use aprint_*_dev and device_xname
 1.44  14-Mar-2008  mhitch Initial bio(4) support; only volume status is handled. The driver doesn't
yet know about physical drives. Derived from the OpenBSD ciss(4) bio(4)
support.
 1.43  05-Dec-2007  ad branches: 1.43.8; 1.43.12;
Match the docs: MUTEX_DRIVER/SPIN are now only for porting code written
for Solaris.
 1.42  19-Oct-2007  ad branches: 1.42.2; 1.42.4;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h
 1.41  09-Jul-2007  ad branches: 1.41.6; 1.41.8; 1.41.12;
Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements
 1.40  04-Mar-2007  christos branches: 1.40.2; 1.40.4;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
 1.39  09-Feb-2007  ad branches: 1.39.2;
Merge newlock2 to head.
 1.38  29-Dec-2006  ad - Print number of channels and firmware revision.
- Cut polling delay to make crashdumps faster.
 1.37  28-Nov-2006  ad Improve error handling. Related to PR/21900.
 1.36  16-Nov-2006  christos __unused removal on arguments; approved by core.
 1.35  12-Oct-2006  christos - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
 1.34  29-Jan-2006  dsl branches: 1.34.18; 1.34.20;
Make almost everything #include <sys/bswap.h> instead of <machine/bswap.h>
The bswap.h and endian.h files are all rather incestuous, but I want to
get the constant folding stuff into one place - sys/bswap.h
 1.33  11-Dec-2005  christos branches: 1.33.2;
merge ktrace-lwp.
 1.32  25-Aug-2005  drochner kill a number of autoconf submatch functions which follow the
standard scheme:
if (<configured> != <wildcard> && <configured> != <real>)
then fail
else
ask device match function

This is handled by config_stdsubmatch() now.
 1.31  25-Aug-2005  drochner replace the "locdesc_t" structure carrying the number of locators
explicitely by a plain integer array
the length in now known to all relevant parties, so this avoids
duplication of information, and we can allocate that thing in
drivers without hacks
 1.30  30-May-2005  christos branches: 1.30.2;
- add missing const
- fix variable shadowing
- remove unneeded casts
 1.29  27-Feb-2005  perry nuke trailing whitespace
 1.28  13-Sep-2004  drochner branches: 1.28.4; 1.28.6;
a round of autoconf cleanup:
-convert submatch() style functions (passed to config_search() or
config_found_sm()) to the locator passing variants
-pass interface attributes in some cases
-make submatch() functions look uniformly as far as possible
-avoid macros which just hide cfdata members, and reduce dependencies
on "locators.h"
 1.27  24-Aug-2004  thorpej Use ANSI function decls and more use of static.
 1.26  05-Dec-2003  pk cac_cmd:
* don't let cac_ccb_alloc() sleep since it regularly runs in an
interrupt context
* return EAGAIN instead EBUSY (or -1), which is what the upper ld
layer expects to get on transient resource shortages.
* ignore error from cac_ccb_start(), since a `fifo full' condition is
handled internally in the lower layer, i.e. the transaction started
from ldstart() has been queued at the lower layer and must be taken
off ld's disk queue.
 1.25  31-Jan-2003  thorpej branches: 1.25.2;
Use aprint_*().
 1.24  06-Jan-2003  wiz specified, not specifed.
 1.23  01-Jan-2003  thorpej Use aprint_normal() in cfprint routines.
 1.22  27-Sep-2002  thorpej Introduce a new routine, config_match(), which invokes the
cfattach->ca_match function in behalf of the caller. Use it
rather than invoking cfattach->ca_match directly.
 1.21  01-Jun-2002  lukem SIMPLEQ rototill:
- implement SIMPLEQ_REMOVE(head, elm, type, field). whilst it's O(n),
this mirrors the functionality of SLIST_REMOVE() (the other
singly-linked list type) and FreeBSD's STAILQ_REMOVE()
- remove the unnecessary elm arg from SIMPLEQ_REMOVE_HEAD().
this mirrors the functionality of SLIST_REMOVE_HEAD() (the other
singly-linked list type) and FreeBSD's STAILQ_REMOVE_HEAD()
- remove notes about SIMPLEQ not supporting arbitrary element removal
- use SIMPLEQ_FOREACH() instead of home-grown for loops
- use SIMPLEQ_EMPTY() appropriately
- use SIMPLEQ_*() instead of accessing sqh_first,sqh_last,sqe_next directly
- reorder manual page; be consistent about how the types are listed
- other minor cleanups
 1.20  25-Jan-2002  ad branches: 1.20.8;
- Always validate the return value read from the outbound FIFO.
- Copy access method info into the softc so we don't double dereference.
- Remove static on functions.
 1.19  13-Nov-2001  lukem add/cleanup RCSID
 1.18  19-Jul-2001  thorpej Use BUS_DMA_READ and BUS_DMA_WRITE in some obvious places.
 1.17  07-Mar-2001  thorpej branches: 1.17.2;
Add BUS_DMA_STREAMING to data transfer maps.
 1.16  11-Dec-2000  ad branches: 1.16.2;
Report soft-errors-per-unit once per minute at most.
 1.15  14-Nov-2000  thorpej branches: 1.15.2;
NBPG -> PAGE_SIZE
 1.14  08-Nov-2000  ad Move lsu stuff to more logical locations, and push queueing into the lsu
driver.
 1.13  19-Oct-2000  ad Update for lsu; untested.
 1.12  08-Sep-2000  ad - Set CCB_ACTIVE flag in all cases when DIAGNOSTIC is defined.
- Correct arguments to bus_dmamap_create().
 1.11  01-Sep-2000  ad FLUSH_CACHE will not return until complete.
 1.10  01-Sep-2000  ad - Interface cleanup. static, const in places.
- Pull in linkage useful for both PCI and EISA boards from cac_pci.c.
- cac_ccb_done() now frees the done CCB if the CCB callback completes.
- Model-specific linkage is now responsible for DMA synchronization.
- Use wakeup_one() in cac_ccb_free().
- Start synchronous commands `manually'.
- Add one hardware check in DIAGNOSTIC case.
- Improve error messages.
- Start firmware background tasks on controllers that need it.
 1.9  31-Jul-2000  ad Previous would have misbehaved if polled commands overlapped.
 1.8  24-Jul-2000  ad Increase polled command timeout to 2s.
 1.7  06-Jul-2000  thorpej Use device_lookup().
 1.6  13-Jun-2000  ad branches: 1.6.2;
Use my proper name.
 1.5  03-May-2000  thorpej branches: 1.5.2;
Fill in ccb->ccb_req.sgcount with the value that's guaranteed to
be initialized.
 1.4  26-Apr-2000  ad - Rearrange some spl*() calls to be as intended.
- Scan cac_cd in cac_shutdown(), don't use a SIMPLEQ.
 1.3  24-Mar-2000  ad Remove paraniod debug check that was mistakenly committed.
 1.2  20-Mar-2000  ad - Remove dead code.
- Make synchronous writes optional, disabled by default (*way* too slow).
- Handle case where dm_nsegs > CAC_SG_SIZE.
- Fix a couple of silly bugs.
- Fix use of __attribute__((__packed__));
 1.1  16-Mar-2000  ad Driver for Compaq array controllers and disks (cac(4)/ca(4)).
 1.5.2.1  22-Jun-2000  minoura Sync w/ netbsd-1-5-base.
 1.6.2.4  29-Jan-2002  he Pull up revisions 1.20 (requested by ad):
Some fixes:
o Always validate return value read from outbound FIFO
o Copy access method into to softc to avoid double dereference
o Remove static on functions
Fixes PR#14453.
 1.6.2.3  25-Oct-2001  he Pull up revisions 1.10-1.18 (via patch, requested by ad):
Add Mylex DACC960, CAC-EISA, and I2O block/SCSI drivers.
 1.6.2.2  09-Aug-2000  ad Pull up revision 1.9 (approved by releng-1-5):
Previous would have misbehaved if polled commands overlapped.
 1.6.2.1  26-Jul-2000  ad Pull up revision 1.8 (approved by releng):
Increase polled command timeout to 2s.
 1.15.2.5  12-Mar-2001  bouyer Sync with HEAD.
 1.15.2.4  13-Dec-2000  bouyer Sync with HEAD (for UBC fixes).
 1.15.2.3  22-Nov-2000  bouyer Sync with HEAD.
 1.15.2.2  20-Nov-2000  bouyer Update thorpej_scsipi to -current as of a month ago
A i386 GENERIC kernel compiles without the siop, ahc and bha drivers
(will be updated later). i386 IDE/ATAPI and ncr work, as well as
sparc/esp_sbus. alpha should work as well (untested yet).
siop, ahc and bha will be updated once I've updated the branch to current
-current, as well as machine-dependant code.
 1.15.2.1  14-Nov-2000  bouyer file cac.c was added on branch thorpej_scsipi on 2000-11-20 11:40:25 +0000
 1.16.2.8  07-Jan-2003  thorpej Sync with HEAD.
 1.16.2.7  03-Jan-2003  thorpej Sync with HEAD.
 1.16.2.6  18-Oct-2002  nathanw Catch up to -current.
 1.16.2.5  20-Jun-2002  nathanw Catch up to -current.
 1.16.2.4  28-Feb-2002  nathanw Catch up to -current.
 1.16.2.3  14-Nov-2001  nathanw Catch up to -current.
 1.16.2.2  24-Aug-2001  nathanw Catch up with -current.
 1.16.2.1  09-Apr-2001  nathanw Catch up with -current.
 1.17.2.5  10-Oct-2002  jdolecek sync kqueue with -current; this includes merge of gehenna-devsw branch,
merge of i386 MP branch, and part of autoconf rototil work
 1.17.2.4  23-Jun-2002  jdolecek catch up with -current on kqueue branch
 1.17.2.3  11-Feb-2002  jdolecek Sync w/ -current.
 1.17.2.2  10-Jan-2002  thorpej Sync kqueue branch with -current.
 1.17.2.1  03-Aug-2001  lukem update to -current
 1.20.8.1  20-Jun-2002  gehenna catch up with -current.
 1.25.2.6  10-Nov-2005  skrll Sync with HEAD. Here we go again...
 1.25.2.5  04-Mar-2005  skrll Sync with HEAD.

Hi Perry!
 1.25.2.4  21-Sep-2004  skrll Fix the sync with head I botched.
 1.25.2.3  18-Sep-2004  skrll Sync with HEAD.
 1.25.2.2  25-Aug-2004  skrll Sync with HEAD.
 1.25.2.1  03-Aug-2004  skrll Sync with HEAD
 1.28.6.1  19-Mar-2005  yamt sync with head. xen and whitespace. xen part is not finished.
 1.28.4.1  29-Apr-2005  kent sync with -current
 1.30.2.7  17-Mar-2008  yamt sync with head.
 1.30.2.6  07-Dec-2007  yamt sync with head
 1.30.2.5  27-Oct-2007  yamt sync with head.
 1.30.2.4  03-Sep-2007  yamt sync with head.
 1.30.2.3  26-Feb-2007  yamt sync with head.
 1.30.2.2  30-Dec-2006  yamt sync with head.
 1.30.2.1  21-Jun-2006  yamt sync with head.
 1.33.2.1  01-Feb-2006  yamt sync with head.
 1.34.20.2  10-Dec-2006  yamt sync with head.
 1.34.20.1  22-Oct-2006  yamt sync with head
 1.34.18.3  15-Jan-2007  ad MP locking.
 1.34.18.2  12-Jan-2007  ad Sync with head.
 1.34.18.1  18-Nov-2006  ad Sync with head.
 1.39.2.1  12-Mar-2007  rmind Sync with HEAD.
 1.40.4.1  11-Jul-2007  mjf Sync with head.
 1.40.2.2  23-Oct-2007  ad Sync with head.
 1.40.2.1  21-Mar-2007  ad GC the simplelock/spinlock debugging stuff.
 1.41.12.1  25-Oct-2007  bouyer Sync with HEAD.
 1.41.8.3  23-Mar-2008  matt sync with HEAD
 1.41.8.2  09-Jan-2008  matt sync with HEAD
 1.41.8.1  06-Nov-2007  matt sync with HEAD
 1.41.6.2  09-Dec-2007  jmcneill Sync with HEAD.
 1.41.6.1  26-Oct-2007  joerg Sync with HEAD.

Follow the merge of pmap.c on i386 and amd64 and move
pmap_init_tmp_pgtbl into arch/x86/x86/pmap.c. Modify the ACPI wakeup
code to restore CR4 before jumping back into kernel space as the large
page option might cover that.
 1.42.4.1  08-Dec-2007  ad Sync with head.
 1.42.2.1  08-Dec-2007  mjf Sync with HEAD.
 1.43.12.3  29-Jun-2008  mjf Sync with HEAD.
 1.43.12.2  02-Jun-2008  mjf Sync with HEAD.
 1.43.12.1  03-Apr-2008  mjf Sync with HEAD.
 1.43.8.1  24-Mar-2008  keiichi sync with head.
 1.45.4.4  11-Aug-2010  yamt sync with head.
 1.45.4.3  16-May-2009  yamt sync with head
 1.45.4.2  04-May-2009  yamt sync with head.
 1.45.4.1  16-May-2008  yamt sync with head.
 1.45.2.2  17-Jun-2008  yamt sync with head.
 1.45.2.1  18-May-2008  yamt sync with head.
 1.46.2.1  23-Jun-2008  wrstuden Sync w/ -current. 34 merge conflicts to follow.
 1.47.12.1  13-May-2009  jym Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.
 1.47.6.1  28-Apr-2009  skrll Sync with HEAD.
 1.49.2.1  30-Apr-2010  uebayasi Sync with HEAD.
 1.50.2.1  05-Mar-2011  rmind sync with head
 1.51.6.1  23-Jun-2011  cherry Catchup with rmind-uvmplock merge.
 1.53.12.2  03-Dec-2017  jdolecek update from HEAD
 1.53.12.1  20-Nov-2012  tls Resync to 2012-11-19 00:00:00 UTC
 1.53.2.1  30-Oct-2012  yamt sync with head
 1.54.14.3  05-Oct-2016  skrll Sync with HEAD
 1.54.14.2  09-Jul-2016  skrll Sync with HEAD
 1.54.14.1  06-Apr-2015  skrll Sync with HEAD
 1.56.2.1  04-Nov-2016  pgoyette Sync with HEAD
 1.58.4.2  13-Apr-2020  martin Mostly merge changes from HEAD upto 20200411
 1.58.4.1  10-Jun-2019  christos Sync with HEAD
 1.58.2.1  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)
 1.61.10.3  28-Mar-2021  thorpej Correct the names of the arguments passed to cac_rescan(), and update
a local variable to avoid a name collision. Also, no need to be explcit
about our interface attribute, since we carry only one.
 1.61.10.2  22-Mar-2021  thorpej Audit CFARG_IATTR in config_found() calls, and remove it in situations
where the interface attribute is not ambiguous.
 1.61.10.1  22-Mar-2021  thorpej Mechanical conversion of config_found_sm_loc() -> config_found().
CFARG_IATTR usage needs to be audited.
 1.62.8.1  04-Aug-2021  thorpej Adapt to CFARGS().

RSS XML Feed