Home | History | Annotate | Download | only in cadence
History log of /src/sys/dev/cadence/if_cemac.c
RevisionDateAuthorComments
 1.46  12-Oct-2025  thorpej Use ether_getaddr().
 1.45  15-Oct-2024  lloyd Allow non-Realtek PHYs to be used with Zynq SoCs.

The cemac driver used to skip the first PHY found in order to work
around a bug where Realtek PHYs attached to a cemac Ethernet would
report at PHY numbers 0 and 1. Unfortunately if you don't have this
bug, then your only PHY would get skipped.

The Zynq FDT always has a working PHY number recorded in it, so we now
simply use that number (if present) instead of searching for all
available PHYs.
 1.44  06-Oct-2024  skrll fix whitespace from previous
 1.43  05-Oct-2024  skrll Make cemac(4) MP safe.

Tested with qemu and

qemu-system-arm \
-kernel netbsd.ub \
-dtb zynq-zc702.dtb \
-M xilinx-zynq-a9 \
-sd armv7.img \
-append "root=ld0a -x -v" \
-serial null -serial mon:stdio \
-nographic
 1.42  29-Sep-2024  skrll Rename a softc member. NFC.
 1.41  29-Sep-2024  skrll Sprinkle some const
 1.40  28-Aug-2024  skrll Shorten a bit definition name.
 1.39  27-Aug-2024  skrll Wrap long lines
 1.38  27-Aug-2024  skrll Whitespace
 1.37  25-Aug-2024  skrll Comment fixes.
 1.36  25-Aug-2024  skrll Use roundup - same code before and after.
 1.35  25-Aug-2024  skrll Sprinkle const and remove unnecessary casts.
 1.34  25-Aug-2024  skrll KNF
 1.33  25-Aug-2024  skrll Re-organise to enable other attachments.
 1.32  24-Aug-2024  skrll Header inclusion maintenance and KNF
 1.31  24-Aug-2024  skrll KNF
 1.30  24-Aug-2024  skrll G/C
 1.29  24-Aug-2024  skrll KNF
 1.28  05-Jul-2024  rin sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@
 1.27  29-Jun-2024  riastradh branches: 1.27.2;
if_stats(9): Add ifp argument to if_stat..._ref.

This will enable us to pass the ifp through to a dtrace probe inside.

No functional change intended in this change, but this is an API
change visible to modules so it shouldn't be pulled up.

PR kern/58377
 1.26  12-Nov-2022  jmcneill Skip the first PHY found to remove the shadow PHY that appears at
the broadcast address 0.
 1.25  18-Sep-2022  thorpej Eliminate use of IFF_OACTIVE.
 1.24  31-Dec-2021  riastradh sys: Use if_init wrapper function.

Exception: Not in kern_pmf.c, for the kind of silly reason that it
avoids having kern_pmf.c refer to symbols defined only in net; this
avoids a pain in the rump.
 1.23  28-Jun-2020  skrll Use prop_data_value (not prop_data_data_nocopy)
 1.22  29-Jan-2020  thorpej Adopt <net/if_stats.h>.
 1.21  28-May-2019  msaitoh branches: 1.21.4;
Use ETHER_LOCK()/ETHER_UNLOCK() for all ethernet drivers to protect ec_multi*.
 1.20  23-May-2019  msaitoh Whitespace fix (mainly tabify).
 1.19  23-May-2019  msaitoh No functional change:
- Change ac(was arpcom) to ec(ethercom)
- Simplify MII structure initialization.
- u_int*_t -> uint*_t.
- KNF
 1.18  19-May-2019  alnsn Kill unused sc variable and fix the build.
 1.17  22-Apr-2019  msaitoh On drivers which use MII(4) and have hook SIOC[GS]IFMEDIA which just pass to
ifmedia_ioctl(), the hook is not required because ether_ioctl has it
(if_ethersubr.c rev. 1.160). These drivers don't return ENETRESET in
ifmedia_ioctl(), so no functional change.
 1.16  05-Feb-2019  msaitoh Remove very old IFF_NOTRAILERS flag.
 1.15  22-Jan-2019  msaitoh Change MII PHY read/write API from:

int (*mii_readreg_t)(device_t, int, int);
void (*mii_writereg_t)(device_t, int, int, int);
to:

int (*mii_readreg_t)(device_t, int, int, uint16_t *);
int (*mii_writereg_t)(device_t, int, int, uint16_t);

Now we can test if a read/write operation failed or not by the return value.

In 802.3 spec says that the PHY shall not respond to read/write transaction
to the unimplemented register(22.2.4.3). Detecting timeout can be used to
check whether a register is implemented or not (if the register conforms to
the spec). ukphy(4) can be used this for MII_MMDACR and MII_MMDAADR.

Note that I noticed that the following code do infinite loop in the
read/wirte function. If it accesses unimplemented PHY register, it will hang.
It should be fixed:

arm/at91/at91emac.c
arm/ep93xx/epe.c
arm/omap/omapl1x_emac.c
mips/ralink/ralink_eth.c
arch/powerpc/booke/dev/pq3etsec.c(read)
dev/cadence/if_cemac.c <- hkenken
dev/ic/lan9118.c


Tested with the following device:

axe+ukphy
axe+rgephy
axen+rgephy (tested by Andrius V)
wm+atphy
wm+ukphy
wm+igphy
wm+ihphy
wm+makphy
sk+makphy
sk+brgphy
sk+gentbi
msk+makphy
sip+icsphy
sip+ukphy
re+rgephy
bge+brgphy
bnx+brgphy
gsip+gphyter
rtk+rlphy
fxp+inphy (tested by Andrius V)
tlp+acphy
ex+exphy
epic+qsphy
vge+ciphy (tested by Andrius V)
vr+ukphy (tested by Andrius V)
vte+ukphy (tested by Andrius V)

Not tested (MAC):
arm:at91emac
arm:cemac
arm:epe
arm:geminigmac
arm:enet
arm:cpsw
arm:emac(omac)
arm:emac(sunxi)
arm:npe
evbppc:temac
macppc:bm
macppc:gm
mips:aumac
mips:ae
mips:cnmac
mips:reth
mips:sbmac
playstation2:smap
powerpc:tsec
powerpc:emac(ibm4xx)
sgimips:mec
sparc:be
sf
ne(ax88190, dl10019)
awge
ep
gem
hme
smsh
mtd
sm
age
alc
ale
bce
cas
et
jme
lii
nfe
pcn
ste
stge
tl
xi
aue
mue
smsc
udav
url

Not tested (PHY):
amhphy
bmtphy
dmphy
etphy
glxtphy
ikphy
iophy
lxtphy
nsphyter
pnaphy
rdcphy
sqphy
tlphy
tqphy
urlphy
 1.14  15-Jul-2018  maxv Retire ipkdb entirely. The option was removed from the config files
yesterday.

ok kamil christos
 1.13  26-Jun-2018  msaitoh branches: 1.13.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.
 1.12  22-Jun-2018  msaitoh It's not required to include net/bpfdesc.h. Remove it.
 1.11  23-May-2017  ozaki-r branches: 1.11.2; 1.11.8; 1.11.10;
Apply deferred if_start to more drivers

And annotate some XXX_start as it runs in softint to clarify that
it doesn't need deferred if_start.
 1.10  15-Dec-2016  ozaki-r Move bpf_mtap and if_ipackets++ on Rx of each driver to percpuq if_input

The benefits of the change are:
- We can reduce codes
- We can provide the same behavior between drivers
- Where/When if_ipackets is counted up
- Note that some drivers still update packet statistics in their own
way (periodical update)
- Moved bpf_mtap run in softint
- This makes it easy to MP-ify bpf

Proposed on tech-kern and tech-net
 1.9  10-Jun-2016  ozaki-r branches: 1.9.2;
Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.
 1.8  09-Feb-2016  ozaki-r Introduce softint-based if_input

This change intends to run the whole network stack in softint context
(or normal LWP), not hardware interrupt context. Note that the work is
still incomplete by this change; to that end, we also have to softint-ify
if_link_state_change (and bpf) which can still run in hardware interrupt.

This change softint-ifies at ifp->if_input that is called from
each device driver (and ieee80211_input) to ensure Layer 2 runs
in softint (e.g., ether_input and bridge_input). To this end,
we provide a framework (called percpuq) that utlizes softint(9)
and percpu ifqueues. With this patch, rxintr of most drivers just
queues received packets and schedules a softint, and the softint
dequeues packets and does rest packet processing.

To minimize changes to each driver, percpuq is allocated in struct
ifnet for now and that is initialized by default (in if_attach).
We probably have to move percpuq to softc of each driver, but it's
future work. At this point, only wm(4) has percpuq in its softc
as a reference implementation.

Additional information including performance numbers can be found
in the thread at tech-kern@ and tech-net@:
http://mail-index.netbsd.org/tech-kern/2016/01/14/msg019997.html

Acknowledgment: riastradh@ greatly helped this work.
Thank you very much!
 1.7  24-Aug-2015  rjs Add hardware checksumming support.
 1.6  24-Aug-2015  rjs Fix logic for setting multicast addresses.

Setting CRC values for hashes is broken so all multicast addresses are
accepted for now.
 1.5  24-Aug-2015  rjs Whitespace.
 1.4  24-Aug-2015  rjs printf -> aprint.
 1.3  13-Aug-2015  rjs Add gem versions of collision counters.
 1.2  20-May-2015  ozaki-r Remove leftover use of AF_NS and NS option

Unnecessary NETISR_NS is also removed.
 1.1  23-Jan-2015  hkenken branches: 1.1.2; 1.1.4;
Initial Zynq (Xilinx) support
Add support for ZedBoard evaluation board and Parallella board.
* cemac(4) Cadence EMAC/GEM(Gigabit) Ethernet Controller driver
based on at91emac
 1.1.4.2  11-May-2015  msaitoh Pull up following revision(s) (requested by nonaka in ticket #751):
sys/arch/arm/zynq/zynq_axi.c: revision 1.1
sys/arch/evbarm/conf/files.zynq: revision 1.1
sys/arch/arm/zynq/zynq_uart.c: revision 1.1
sys/arch/evbarm/zynq/genassym.cf: revision 1.1
sys/arch/evbarm/zynq/zynq_start.S: revision 1.1
sys/arch/arm/zynq/zynq_slcrreg.h: revision 1.1
sys/arch/arm/zynq/zynq_usbreg.h: revision 1.1
sys/arch/arm/zynq/zynq7000_uart.c: revision 1.1
sys/arch/arm/zynq/zynq7000_sdhc.c: revision 1.1
sys/arch/arm/zynq/zynq_slcrvar.h: revision 1.1
sys/arch/arm/zynq/zynq_usbvar.h: revision 1.1
sys/arch/evbarm/conf/PARALLELLA_INSTALL: revision 1.1
sys/arch/arm/zynq/zynq_uartreg.h: revision 1.1
sys/arch/evbarm/zynq/platform.h: revision 1.1
sys/arch/evbarm/conf/mk.zynq: revision 1.1
sys/arch/evbarm/conf/files.zedboard: revision 1.1
sys/arch/arm/zynq/zynq7000_usb.c: revision 1.1
sys/dev/cadence/if_cemacvar.h: revision 1.1
sys/arch/arm/zynq/files.zynq: revision 1.1
sys/arch/arm/zynq/zynq_slcr.c: revision 1.1
sys/arch/arm/zynq/zynq7000_intr.h: revision 1.1
sys/arch/arm/conf/majors.arm32: revision 1.36
sys/arch/arm/zynq/zynq_uartvar.h: revision 1.1
sys/arch/evbarm/conf/files.parallella: revision 1.1
sys/arch/arm/zynq/zynq_space.c: revision 1.1
sys/dev/cadence/if_cemac.c: revision 1.1
sys/arch/evbarm/conf/PARALLELLA: revision 1.1
sys/arch/arm/zynq/zynq7000_board.c: revision 1.1
sys/arch/evbarm/Makefile: revision 1.10
sys/arch/evbarm/zynq/zynq_machdep.c: revision 1.1
sys/arch/arm/zynq/zynq7000_reg.h: revision 1.1
sys/arch/evbarm/conf/ZEDBOARD: revision 1.1
sys/dev/cadence/cemacreg.h: revision 1.1
sys/arch/evbarm/conf/std.zynq: revision 1.1
sys/arch/arm/zynq/zynq_dma.c: revision 1.1
sys/arch/arm/zynq/zynq_cemac.c: revision 1.1
sys/arch/arm/zynq/zynq7000_var.h: revision 1.1
sys/arch/evbarm/conf/ZEDBOARD_INSTALL: revision 1.1
sys/arch/arm/zynq/zynq_usb.c: revision 1.1
Initial Zynq (Xilinx) support
Add support for ZedBoard evaluation board and Parallella board.
* cemac(4) Cadence EMAC/GEM(Gigabit) Ethernet Controller driver
based on at91emac
 1.1.4.1  23-Jan-2015  msaitoh file if_cemac.c was added on branch netbsd-7 on 2015-05-11 11:00:33 +0000
 1.1.2.8  28-Aug-2017  skrll Sync with HEAD
 1.1.2.7  05-Feb-2017  skrll Sync with HEAD
 1.1.2.6  09-Jul-2016  skrll Sync with HEAD
 1.1.2.5  19-Mar-2016  skrll Sync with HEAD
 1.1.2.4  22-Sep-2015  skrll Sync with HEAD
 1.1.2.3  06-Jun-2015  skrll Sync with HEAD
 1.1.2.2  06-Apr-2015  skrll Sync with HEAD
 1.1.2.1  23-Jan-2015  skrll file if_cemac.c was added on branch nick-nhusb on 2015-04-06 15:18:08 +0000
 1.9.2.1  07-Jan-2017  pgoyette Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
 1.11.10.3  26-Jan-2019  pgoyette Sync with HEAD
 1.11.10.2  28-Jul-2018  pgoyette Sync with HEAD
 1.11.10.1  25-Jun-2018  pgoyette Sync with HEAD
 1.11.8.2  03-Dec-2017  jdolecek update from HEAD
 1.11.8.1  23-May-2017  jdolecek file if_cemac.c was added on branch tls-maxphys on 2017-12-03 11:36:59 +0000
 1.11.2.1  26-Jul-2018  snj Pull up following revision(s) (requested by msaitoh in ticket #938):
sys/arch/acorn32/podulebus/if_ie.c: revision 1.41
sys/arch/amiga/dev/if_es.c: revision 1.58
sys/arch/amiga/dev/if_qn.c: revision 1.45
sys/arch/arm/at91/at91emac.c: revision 1.20
sys/arch/arm/ep93xx/epe.c: revision 1.37
sys/arch/emips/ebus/if_le_ebus.c: revision 1.14
sys/arch/emips/ebus/if_le_ebus.c: revision 1.15
sys/arch/mac68k/dev/if_mc.c: revision 1.46
sys/arch/macppc/dev/am79c950.c: revision 1.39
sys/arch/newsmips/apbus/if_sn.c: revision 1.40
sys/arch/next68k/dev/mb8795.c: revision 1.59
sys/arch/playstation2/dev/if_smap.c: revision 1.25
sys/arch/playstation2/dev/if_smap.c: revision 1.26
sys/arch/sun2/dev/if_ec.c: revision 1.28
sys/arch/sun3/dev/if_ie.c: revision 1.63
sys/arch/x68k/dev/if_ne_intio.c: revision 1.19
sys/arch/xen/xen/if_xennet_xenbus.c: revision 1.75
sys/arch/xen/xen/xennetback_xenbus.c: revision 1.63
sys/dev/bi/if_ni.c: revision 1.45
sys/dev/cadence/if_cemac.c: revision 1.12
sys/dev/ic/am7990.c: revision 1.78
sys/dev/ic/am79900.c: revision 1.27
sys/dev/ic/an.c: revision 1.67
sys/dev/ic/cs89x0.c: revision 1.40
sys/dev/ic/dm9000.c: revision 1.13
sys/dev/ic/dm9000.c: revision 1.14
sys/dev/ic/dp8390.c: revision 1.88
sys/dev/ic/elink3.c: revision 1.141
sys/dev/ic/elinkxl.c: revision 1.122
sys/dev/ic/hme.c: revision 1.98
sys/dev/ic/i82586.c: revision 1.77
sys/dev/ic/lance.c: revision 1.53
sys/dev/ic/mb86950.c: revision 1.27
sys/dev/ic/mb86960.c: revision 1.86
sys/dev/ic/mtd803.c: revision 1.34
sys/dev/ic/pdq_ifsubr.c: revision 1.59
sys/dev/ic/rrunner.c: revision 1.86
sys/dev/ic/seeq8005.c: revision 1.58
sys/dev/ic/sgec.c: revision 1.47
sys/dev/ic/smc90cx6.c: revision 1.72
sys/dev/ic/smc91cxx.c: revision 1.96
sys/dev/ic/tropic.c: revision 1.49
sys/dev/ic/wi.c: revision 1.245
sys/dev/isa/if_eg.c: revision 1.93
sys/dev/isa/if_el.c: revision 1.95
sys/dev/isa/if_iy.c: revision 1.101
sys/dev/ofw/ofnet.c: revision 1.58
sys/dev/pci/if_alc.c: revision 1.27
sys/dev/pci/if_de.c: revision 1.152
sys/dev/pci/if_fpa.c: revision 1.61
sys/dev/pci/if_jme.c: revision 1.34
sys/dev/pci/if_tl.c: revision 1.108
sys/dev/pci/if_vte.c: revision 1.19
sys/dev/pci/ixgbe/ixgbe.h: revision 1.50
sys/dev/pcmcia/if_cnw.c: revision 1.62
sys/dev/pcmcia/if_malo_pcmcia.c: revision 1.17
sys/dev/pcmcia/if_ray.c: revision 1.89
sys/dev/pcmcia/if_xi.c: revision 1.81
sys/dev/pcmcia/mhzc.c: revision 1.51
sys/dev/pcmcia/xirc.c: revision 1.34
sys/dev/qbus/if_de.c: revision 1.33
sys/dev/qbus/if_qe.c: revision 1.78
sys/dev/qbus/if_qt.c: revision 1.22
sys/dev/sbus/be.c: revision 1.87
sys/dev/sbus/qe.c: revision 1.68
sys/dev/scsipi/if_se.c: revision 1.96
sys/dev/usb/if_atu.c: revision 1.59
sys/net/if_l2tp.c: revision 1.28 via patch
sys/net/if_ppp.c: revision 1.160
It's not required to include net/bpfdesc.h. Remove it.
--
Simplify like other drivers. NULL check of ifp->if_bpf is done in
bpf_mtap(), so it's not required to do it here.
--
Remove duplicated inclusion of net/bpf.h.
--
Remove duplicated inclusion of net/bpf.h.
--
Simplify bpf_mtap() call. No functional change.
 1.13.2.2  08-Apr-2020  martin Merge changes from current as of 20200406
 1.13.2.1  10-Jun-2019  christos Sync with HEAD
 1.21.4.1  29-Feb-2020  ad Sync with head.
 1.27.2.1  02-Aug-2025  perseant Sync with HEAD

RSS XML Feed