| History log of /src/sys/dev/scsipi/ses.c |
| Revision | | Date | Author | Comments |
| 1.52 |
| 09-Sep-2021 |
riastradh | sys/dev: Memset zero before copyout.
Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
|
| 1.51 |
| 08-Mar-2019 |
msaitoh | branches: 1.51.4;
s/ are are / are /
s/ a a / a /
|
| 1.50 |
| 20-Nov-2016 |
mlelstv | branches: 1.50.8; 1.50.16;
Make scsipi framework MPSAFE.
Data structures are now protected by a per-adapter mutex at IPL_BIO
that is created by the scsibus or atapibus instance when the adapter
is configured.
The enable reference counter and the channel freeze counter which are
currently used by HBA code before the adapter is configured, are made
atomic.
The target drivers are now all tagged as D_MPSAFE.
Almost all HBA drivers still require the kernel lock to present,
so all callbacks into HBA code are still protected by kernel lock
unless the driver is tagged as SCSIPI_ADAPT_MPSAFE.
TODO: refactor sd and cd to use dksubr.
|
| 1.49 |
| 14-Jul-2016 |
msaitoh | branches: 1.49.2;
- Use aprint*() more in xxx_attach().
- Add missing aprint_naive("\n").
- Remove extra spaces and tabs.
- KNF.
|
| 1.48 |
| 24-Aug-2015 |
pooka | would you like some freshly ground _KERNEL_OPT with that?
yes? excellent choice, sir/madam.
|
| 1.47 |
| 25-Jul-2014 |
dholland | branches: 1.47.4;
Add d_discard to all struct cdevsw instances I could find.
All have been set to "nodiscard"; some should get a real implementation.
|
| 1.46 |
| 16-Mar-2014 |
dholland | branches: 1.46.2;
Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.
I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.
|
| 1.45 |
| 07-Apr-2013 |
wiz | branches: 1.45.4;
Add detach support. From martin@.
"Works for me."
Addresses PR 44283.
|
| 1.44 |
| 27-Oct-2012 |
chs | split device_t/softc for all remaining drivers.
replace "struct device *" with "device_t".
use device_xname(), device_unit(), etc.
|
| 1.43 |
| 17-Jul-2011 |
joerg | branches: 1.43.2; 1.43.8; 1.43.12; 1.43.14;
Retire varargs.h support. Move machine/stdarg.h logic into MI
sys/stdarg.h and expect compiler to provide proper builtins, defaulting
to the GCC interface. lint still has a special fallback.
Reduce abuse of _BSD_VA_LIST_ by defining __va_list by default and
derive va_list as required by standards.
|
| 1.42 |
| 12-May-2009 |
cegger | struct device * -> device_t, no functional changes intended.
|
| 1.41 |
| 12-May-2009 |
cegger | struct cfdata * -> cfdata_t, no functional changes intended.
|
| 1.40 |
| 08-Jun-2008 |
tsutsui | branches: 1.40.12;
Use device_lookup_private() rather than using cd_devs[] directly to get softc.
XXX maybe we should change a type of cd_devs[] in struct cfdriver
from (void *) to device_t.
|
| 1.39 |
| 05-Apr-2008 |
cegger | branches: 1.39.2; 1.39.4; 1.39.6;
use aprint_*_dev and device_xname
|
| 1.38 |
| 04-Mar-2007 |
christos | branches: 1.38.36;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|
| 1.37 |
| 16-Nov-2006 |
christos | branches: 1.37.4;
__unused removal on arguments; approved by core.
|
| 1.36 |
| 12-Oct-2006 |
christos | - sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386
|
| 1.35 |
| 03-Sep-2006 |
christos | branches: 1.35.2; 1.35.4;
add missing initializer
|
| 1.34 |
| 14-Apr-2006 |
christos | Coverity CID 1100: Avoid NULL pointer dereferences.
|
| 1.33 |
| 30-Mar-2006 |
thorpej | Use device_private().
|
| 1.32 |
| 11-Dec-2005 |
christos | branches: 1.32.4; 1.32.6; 1.32.8; 1.32.10; 1.32.12;
merge ktrace-lwp.
|
| 1.31 |
| 30-May-2005 |
christos | branches: 1.31.2;
- remove bogus casts
- add more const
|
| 1.30 |
| 27-Feb-2005 |
perry | nuke trailing whitespace
|
| 1.29 |
| 01-Feb-2005 |
reinoud | Backing out changes to clean up scsipi. I was pointed out there were
problems i hadn't seen. To prevent lossage i'd decided to back off all
changes and let them be reviewed on tech-kern.
|
| 1.28 |
| 31-Jan-2005 |
reinoud | Part of the cleanup of sys/scsipi's use of types; rename all u_int* to
uint* and change the u_long's to uint32_t's where possible. Note that the
iocl definitions/hooks have to be ulong (or u_long) or they'll bomb out.
|
| 1.27 |
| 31-Jan-2005 |
reinoud | As part of cleaning up sys/scsipi, replace all u_char by uint8_t and
replace all `short' with int16_t.
|
| 1.26 |
| 18-Sep-2004 |
mycroft | branches: 1.26.4; 1.26.6;
Minor rearrangement. Whitespace and #include cleanup.
|
| 1.25 |
| 17-Sep-2004 |
mycroft | Remove the "xfer" argument to scsipi_command().
|
| 1.24 |
| 09-Sep-2004 |
bouyer | Make the xxstart() functions reentrant again, as some drivers HBA can call
scsipi_done() from their scsipi_request().
For this, add a struct scsipi_xfer * argument to scsipi_command().
If not NULL scsipi_command() will use this to enqueue this xfer, otherwise
it'll try to allocate a new one. This scsipi_xfer has to be allocated
and initialised by scsipi_make_xs() or equivalent.
In xxstart(), allocate a scsipi_xfer using scsipi_make_xs(), and if not NULL,
dequeue the buffer before calling scsipi_command(). This makes sure that
scsipi_command() will not fail, and also makes sure that xxstart() won't
be called again between the BUFQ_PEEK() and BUFQ_GET().
Fix "dequeued wrong buf" panics reported by Juergen Hannken-Illjes in
private mail and Andreas Wrede on current-users@.
Thanks to Jason Thorpe and Chuck Silver for review, and Andreas Wrede for
testing the patch.
|
| 1.23 |
| 21-Aug-2004 |
thorpej | Use ANSI function decls and make use of static.
|
| 1.22 |
| 29-Jun-2003 |
fvdl | branches: 1.22.2; 1.22.4;
Back out the lwp/ktrace changes. They contained a lot of colateral damage,
and need to be examined and discussed more.
|
| 1.21 |
| 28-Jun-2003 |
darrenr | Pass lwp pointers throughtout the kernel, as required, so that the lwpid can
be inserted into ktrace records. The general change has been to replace
"struct proc *" with "struct lwp *" in various function prototypes, pass
the lwp through and use l_proc to get the process pointer when needed.
Bump the kernel rev up to 1.6V
|
| 1.20 |
| 07-Feb-2003 |
mjacob | kern/20231- pass the correct argument (arg_addr) on thru to scsipi_do_ioctl,
not the locally dereferenced fetch.
|
| 1.19 |
| 20-Jan-2003 |
simonb | The Double-Semi-Colon Police.
|
| 1.18 |
| 23-Oct-2002 |
jdolecek | merge kqueue branch into -current
kqueue provides a stateful and efficient event notification framework
currently supported events include socket, file, directory, fifo,
pipe, tty and device changes, and monitoring of processes and signals
kqueue is supported by all writable filesystems in NetBSD tree
(with exception of Coda) and all device drivers supporting poll(2)
based on work done by Jonathan Lemon for FreeBSD
initial NetBSD port done by Luke Mewburn and Jason Thorpe
|
| 1.17 |
| 02-Oct-2002 |
thorpej | Add trailing ; to CFATTACH_DECL.
|
| 1.16 |
| 30-Sep-2002 |
thorpej | Use CFATTACH_DECL().
|
| 1.15 |
| 27-Sep-2002 |
thorpej | Declare all cfattach structures const.
|
| 1.14 |
| 06-Sep-2002 |
gehenna | Merge the gehenna-devsw branch into the trunk.
This merge changes the device switch tables from static array to
dynamically generated by config(8).
- All device switches is defined as a constant structure in device drivers.
- The new grammer ``device-major'' is introduced to ``files''.
device-major <prefix> char <num> [block <num>] [<rules>]
- All device major numbers must be listed up in port dependent majors.<arch>
by using this grammer.
- Added the new naming convention.
The name of the device switch must be <prefix>_[bc]devsw for auto-generation
of device switch tables.
- The backward compatibility of loading block/character device
switch by LKM framework is broken. This is necessary to convert
from block/character device major to device name in runtime and vice versa.
- The restriction to assign device major by LKM is completely removed.
We don't need to reserve LKM entries for dynamic loading of device switch.
- In compile time, device major numbers list is packed into the kernel and
the LKM framework will refer it to assign device major number dynamically.
|
| 1.13 |
| 15-Nov-2001 |
lukem | branches: 1.13.8; 1.13.10;
don't need <sys/types.h> when including <sys/param.h>
|
| 1.12 |
| 13-Nov-2001 |
lukem | add RCSIDs
|
| 1.11 |
| 18-Jul-2001 |
thorpej | branches: 1.11.2;
bcopy -> memcpy
|
| 1.10 |
| 18-Jul-2001 |
thorpej | bzero -> memset
|
| 1.9 |
| 25-Apr-2001 |
bouyer | branches: 1.9.2;
Pull up the thorpej_scsipi branch to main branch.
This is a completely rewritten scsipi_xfer execution engine, and the
associated changes to HBA drivers. Overview of changes & features:
- All xfers are queued in the mid-layer, rather than doing so in an
ad-hoc fashion in individual adapter drivers.
- Adapter/channel resource management in the mid-layer, avoids even trying
to start running an xfer if the adapter/channel doesn't have the resources.
- Better communication between the mid-layer and the adapters.
- Asynchronous event notification mechanism from adapter to mid-layer and
peripherals.
- Better peripheral queue management: freeze/thaw, sorted requeueing during
recovery, etc.
- Clean separation of peripherals, adapters, and adapter channels (no more
scsipi_link).
- Kernel thread for each scsipi_channel makes error recovery much easier
(no more dealing with interrupt context when recovering from an error).
- Mid-layer support for tagged queueing: commands can have the tag type
set explicitly, tag IDs are allocated in the mid-layer (thus eliminating
the need to use buggy tag ID allocation schemes in many adapter drivers).
- support for QUEUE FULL and CHECK CONDITION status in mid-layer; the command
will be requeued, or a REQUEST SENSE will be sent as appropriate.
Just before the merge syssrc has been tagged with thorpej_scsipi_beforemerge
|
| 1.8 |
| 08-Aug-2000 |
mjacob | branches: 1.8.2; 1.8.4;
Don't attempt to actually read SAF-TE temperature objects- nobody seems
to be obeying the original spec as to what the numeric value means.
Temperature flags are unaffected- these are still the 'pseudo-thermometers'
and overtemp/undertemp warnings will be caught and translated to SES objects
here.
|
| 1.7 |
| 08-Jul-2000 |
sommerfeld | printf format paranoia
|
| 1.6 |
| 22-May-2000 |
thorpej | Remove an used variable and add a missing `}' so that this compiles.
|
| 1.5 |
| 14-May-2000 |
dante | Change scsipi_inquiry_data strucure to be ANSI SPC-2 rev16 compliant
|
| 1.4 |
| 20-Feb-2000 |
mjacob | Oops...I forgot that the GEM-2 chip is so lame that if you don't tell
it exactly the right amount of data to transfer for WRITE BUFFER/Global
it will stay stuck in command phase (causing a command phase overrun).
|
| 1.3 |
| 21-Jan-2000 |
mjacob | slight change for platform independence
|
| 1.2 |
| 21-Jan-2000 |
mjacob | cleanup SAF-TE attachment code
|
| 1.1 |
| 20-Jan-2000 |
mjacob | add SES driver
|
| 1.8.4.7 |
| 11-Nov-2002 |
nathanw | Catch up to -current
|
| 1.8.4.6 |
| 18-Oct-2002 |
nathanw | Catch up to -current.
|
| 1.8.4.5 |
| 17-Sep-2002 |
nathanw | Catch up to -current.
|
| 1.8.4.4 |
| 08-Jan-2002 |
nathanw | Catch up to -current.
|
| 1.8.4.3 |
| 14-Nov-2001 |
nathanw | Catch up to -current.
|
| 1.8.4.2 |
| 24-Aug-2001 |
nathanw | Catch up with -current.
|
| 1.8.4.1 |
| 21-Jun-2001 |
nathanw | Catch up to -current.
|
| 1.8.2.2 |
| 20-Nov-2000 |
bouyer | Update thorpej_scsipi to -current as of a month ago
A i386 GENERIC kernel compiles without the siop, ahc and bha drivers
(will be updated later). i386 IDE/ATAPI and ncr work, as well as
sparc/esp_sbus. alpha should work as well (untested yet).
siop, ahc and bha will be updated once I've updated the branch to current
-current, as well as machine-dependant code.
Main changes to the scsipi code itself:
- add a scsipi_channel->type to allow umass to attach to both atapibus and
scsibus. Will die when IDE is converted from ata_atapi_attach to
scsipi_channel/scsipi_adapter
- Add a chan_defquirks to scsipi_channel so that adapters can pass a default
set of quirks to be set for each device attached
- add adapt_getgeom and adapt_accesschk callbacks
|
| 1.8.2.1 |
| 08-Aug-2000 |
bouyer | file ses.c was added on branch thorpej_scsipi on 2000-11-20 09:59:28 +0000
|
| 1.9.2.3 |
| 10-Oct-2002 |
jdolecek | sync kqueue with -current; this includes merge of gehenna-devsw branch,
merge of i386 MP branch, and part of autoconf rototil work
|
| 1.9.2.2 |
| 10-Jan-2002 |
thorpej | Sync kqueue branch with -current.
|
| 1.9.2.1 |
| 03-Aug-2001 |
lukem | update to -current
|
| 1.11.2.2 |
| 26-Sep-2001 |
fvdl | * add a VCLONED vnode flag that indicates a vnode representing a cloned
device.
* rename REVOKEALL to REVOKEALIAS, and add a REVOKECLONE flag, to pass
to VOP_REVOKE
* the revoke system call will revoke all aliases, as before, but not the
clones
* vdevgone is called when detaching a device, so make it use REVOKECLONE
to get rid of all clones as well
* clean up all uses of VOP_OPEN wrt. locking.
* add a few VOPS to spec_vnops that need to do something when it's a
clone vnode (access and getattr)
* add a copy of the vnode vattr structure of the original 'master' vnode
to the specinfo of a cloned vnode. could possibly redirect getattr to
the 'master' vnode, but this has issues with revoke
* add a vdev_reassignvp function that disassociates a vnode from its
original device, and reassociates it with the specified dev_t. to be
used by cloning devices only, in case a new minor is allocated.
* change all direct references in drivers to v_devcookie and v_rdev
to vdev_privdata(vp) and vdev_rdev(vp). for diagnostic purposes
when debugging race conditions that still exist wrt. locking and
revoking vnodes.
* make the locking state of a vnode consistent when passed to
d_open and d_close (unlocked). locked would be better, but has
some deadlock issues
|
| 1.11.2.1 |
| 07-Sep-2001 |
thorpej | Commit my "devvp" changes to the thorpej-devvp branch. This
replaces the use of dev_t in most places with a struct vnode *.
This will form the basic infrastructure for real cloning device
support (besides being architecurally cleaner -- it'll be good
to get away from using numbers to represent objects).
|
| 1.13.10.2 |
| 16-Jun-2003 |
grant | Pull up revision 1.20 (requested by mjacob in ticket #1162):
kern/20231- pass the correct argument (arg_addr) on thru to scsipi_do_ioctl,
not the locally dereferenced fetch.
|
| 1.13.10.1 |
| 16-Jun-2003 |
grant | Pull up revision 1.19 (requested by mjacob in ticket #1162):
The Double-Semi-Colon Police.
|
| 1.13.8.1 |
| 16-May-2002 |
gehenna | Add the character device switch.
|
| 1.22.4.1 |
| 11-Sep-2004 |
he | Pull up revision 1.24 (via patch, requested by bouyer in ticket #837):
Improve handling of memory shortage, to fix problems like:
sd3(mpt0:0:1:0): unable to allocate scsipi_xfer
sd3: not queued, error 12
The theory is that other consumers of pool memory is causing
this memory shortage in certain somewhat hard to reproduce
situations.
This is done by giving scsipi_command an extra argument to
optionally pass a preallocated scsipi_xfer, and allocating a
scsipi_xfer before dequeueing a buffer in the various *start()
functions. If the allocation of a scsipi_xfer fails, schedule
a callout for delayed invocation of the start function. Also
reserve one page for scsipi_xfer structs, to ensure that we will
eventually have some available once pending commands complete.
Should fix PR#25670.
|
| 1.22.2.6 |
| 10-Nov-2005 |
skrll | Sync with HEAD. Here we go again...
|
| 1.22.2.5 |
| 04-Mar-2005 |
skrll | Sync with HEAD.
Hi Perry!
|
| 1.22.2.4 |
| 21-Sep-2004 |
skrll | Fix the sync with head I botched.
|
| 1.22.2.3 |
| 18-Sep-2004 |
skrll | Sync with HEAD.
|
| 1.22.2.2 |
| 25-Aug-2004 |
skrll | Sync with HEAD.
|
| 1.22.2.1 |
| 02-Jul-2003 |
darrenr | Apply the aborted ktrace-lwp changes to a specific branch. This is just for
others to review, I'm concerned that patch fuziness may have resulted in some
errant code being generated but I'll look at that later by comparing the diff
from the base to the branch with the file I attempt to apply to it. This will,
at the very least, put the changes in a better context for others to review
them and attempt to tinker with removing passing of 'struct lwp' through
the kernel.
|
| 1.26.6.1 |
| 19-Mar-2005 |
yamt | sync with head. xen and whitespace. xen part is not finished.
|
| 1.26.4.1 |
| 29-Apr-2005 |
kent | sync with -current
|
| 1.31.2.3 |
| 03-Sep-2007 |
yamt | sync with head.
|
| 1.31.2.2 |
| 30-Dec-2006 |
yamt | sync with head.
|
| 1.31.2.1 |
| 21-Jun-2006 |
yamt | sync with head.
|
| 1.32.12.2 |
| 24-May-2006 |
tron | Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.
|
| 1.32.12.1 |
| 31-Mar-2006 |
tron | Merge 2006-03-31 NetBSD-current into the "peter-altq" branch.
|
| 1.32.10.1 |
| 19-Apr-2006 |
elad | sync with head.
|
| 1.32.8.3 |
| 03-Sep-2006 |
yamt | sync with head.
|
| 1.32.8.2 |
| 24-May-2006 |
yamt | sync with head.
|
| 1.32.8.1 |
| 01-Apr-2006 |
yamt | sync with head.
|
| 1.32.6.1 |
| 22-Apr-2006 |
simonb | Sync with head.
|
| 1.32.4.1 |
| 09-Sep-2006 |
rpaulo | sync with head
|
| 1.35.4.2 |
| 10-Dec-2006 |
yamt | sync with head.
|
| 1.35.4.1 |
| 22-Oct-2006 |
yamt | sync with head
|
| 1.35.2.1 |
| 18-Nov-2006 |
ad | Sync with head.
|
| 1.37.4.1 |
| 12-Mar-2007 |
rmind | Sync with HEAD.
|
| 1.38.36.3 |
| 29-Jun-2008 |
mjf | Sync with HEAD.
|
| 1.38.36.2 |
| 02-Jun-2008 |
mjf | Sync with HEAD.
|
| 1.38.36.1 |
| 05-Apr-2008 |
mjf | - add "file-system DEVFS" and "pseudo-device devfsctl" to conf/std seeing
as these are always needed.
- convert many, many drivers over to the New Devfs World Order. For a
list of device drivers yet to be converted see,
http://www.netbsd.org/~mjf/devfs-todo.html.
- add a new device_unregister_all(device_t) function to remove all device
names associated with a device_t, which saves us having to construct
device names when the driver is detached.
- add a DEV_AUDIO type for devices.
|
| 1.39.6.1 |
| 23-Jun-2008 |
wrstuden | Sync w/ -current. 34 merge conflicts to follow.
|
| 1.39.4.2 |
| 16-May-2009 |
yamt | sync with head
|
| 1.39.4.1 |
| 04-May-2009 |
yamt | sync with head.
|
| 1.39.2.1 |
| 17-Jun-2008 |
yamt | sync with head.
|
| 1.40.12.1 |
| 13-May-2009 |
jym | Sync with HEAD.
Commit is split, to avoid a "too many arguments" protocol error.
|
| 1.43.14.1 |
| 29-Apr-2013 |
riz | Pull up following revision(s) (requested by jakllsch in ticket #878):
sys/dev/scsipi/ses.c: revision 1.45
Add detach support. From martin@.
"Works for me."
Addresses PR 44283.
|
| 1.43.12.4 |
| 03-Dec-2017 |
jdolecek | update from HEAD
|
| 1.43.12.3 |
| 20-Aug-2014 |
tls | Rebase to HEAD as of a few days ago.
|
| 1.43.12.2 |
| 23-Jun-2013 |
tls | resync from head
|
| 1.43.12.1 |
| 20-Nov-2012 |
tls | Resync to 2012-11-19 00:00:00 UTC
|
| 1.43.8.1 |
| 29-Apr-2013 |
riz | Pull up following revision(s) (requested by jakllsch in ticket #878):
sys/dev/scsipi/ses.c: revision 1.45
Add detach support. From martin@.
"Works for me."
Addresses PR 44283.
|
| 1.43.2.2 |
| 22-May-2014 |
yamt | sync with head.
for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.
this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
|
| 1.43.2.1 |
| 30-Oct-2012 |
yamt | sync with head
|
| 1.45.4.1 |
| 18-May-2014 |
rmind | sync with head
|
| 1.46.2.1 |
| 10-Aug-2014 |
tls | Rebase.
|
| 1.47.4.3 |
| 05-Dec-2016 |
skrll | Sync with HEAD
|
| 1.47.4.2 |
| 05-Oct-2016 |
skrll | Sync with HEAD
|
| 1.47.4.1 |
| 22-Sep-2015 |
skrll | Sync with HEAD
|
| 1.49.2.1 |
| 07-Jan-2017 |
pgoyette | Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
|
| 1.50.16.1 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
| 1.50.8.1 |
| 21-Jun-2023 |
martin | Pull up following revision(s) (requested by riastradh in ticket #1835):
sys/dev/pci/if_iwi.c: revision 1.117
sys/dev/raidframe/rf_netbsdkintf.c: revision 1.401
sys/dev/scsipi/ses.c: revision 1.52
sys/dev/isa/mcd.c: revision 1.121
(all via patch)
sys/dev: Memset zero before copyout.
Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
|
| 1.51.4.1 |
| 03-Aug-2022 |
martin | Pull up following revision(s) (requested by riastradh in ticket #1485):
sys/dev/pci/if_iwi.c: revision 1.117
sys/dev/raidframe/rf_netbsdkintf.c: revision 1.401
sys/dev/scsipi/ses.c: revision 1.52
sys/dev/isa/mcd.c: revision 1.121
sys/dev: Memset zero before copyout.
Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.
I think the iwi(4), mcd(4), and ses(4) changes actually plug leaks;
the raidframe(4) change probably doesn't (but doesn't hurt).
|
